Re: [PATCH v2] samsung-laptop: enable better lid handling

2015-01-29 Thread Julijonas Kikutis
> Patch is generally fine, thanks for addressing my comments. Prior to merging I > always run checkpatch.pl just in case I missed anything obvious: > > $ scripts/checkpatch.pl ~/samsung/01-lid-handling.patch > WARNING: Prefer kstrto to single variable sscanf > #219: FILE: drivers/platform/x86/sam

[PATCH v3] samsung-laptop: enable better lid handling

2015-01-29 Thread Julijonas Kikutis
ices, even when your laptop is powered off. 1 means enabled, 0 means disabled. + +What: /sys/devices/platform/samsung/lid_handling +Date: December 11, 2014 +KernelVersion: 3.19 +Contact: Julijonas Kikutis +Description: Some Samsung laptops handle lid closi

Re: [PATCH] samsung-laptop: enable better lid handling

2015-01-27 Thread Julijonas Kikutis
> > However, a user with another laptop in the bug report says that "power > > button has to be pressed twice to wake the machine" in this mode. > > This is with this patch applied? No, the commenter in bugzilla reports that it happened after manually outputting the command to debugfs. Of course,

[PATCH v2] samsung-laptop: enable better lid handling

2015-01-27 Thread Julijonas Kikutis
ices, even when your laptop is powered off. 1 means enabled, 0 means disabled. + +What: /sys/devices/platform/samsung/lid_handling +Date: December 11, 2014 +KernelVersion: 3.19 +Contact: Julijonas Kikutis +Description: Some Samsung laptops handle lid closi

samsung-laptop: enable better lid handling

2015-01-14 Thread Julijonas Kikutis
Hello, I sent the patch to linux-kernel, platform-driver-x86, and to the maintainer of samsung-laptop a month ago and have not received any response. Any response would be welcome. I have some additional thoughts about the patch. I don't know whether it is a

[PATCH] samsung-laptop: enable better lid handling

2014-12-11 Thread Julijonas Kikutis
-laptop is unfortunately disabled. Signed-off-by: Julijonas Kikutis --- .../ABI/testing/sysfs-driver-samsung-laptop| 8 ++ drivers/platform/x86/samsung-laptop.c | 121 - 2 files changed, 128 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sy