[PATCH] btrfs: assign error values to the correct bio structs

2016-10-16 Thread Junjie Mao
Fixes: 4246a0b63bd8 ("block: add a bi_error field to struct bio") Signed-off-by: Junjie Mao <junjie@enight.me> --- fs/btrfs/compression.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index ccc70d9695

[PATCH] btrfs: assign error values to the correct bio structs

2016-10-16 Thread Junjie Mao
Fixes: 4246a0b63bd8 ("block: add a bi_error field to struct bio") Signed-off-by: Junjie Mao --- fs/btrfs/compression.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c index ccc70d96958d..d4d8b7e36b2f 100644 ---

[PATCH] USB: idmouse.c: Put the interface on error

2016-02-21 Thread Junjie Mao
usb_autopm_put_interface() should be called regardless of what idmouse_create_image() returns. Signed-off-by: Junjie Mao <junjie@enight.me> --- drivers/usb/misc/idmouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/idmouse.c b/drivers/us

[PATCH] USB: idmouse.c: Put the interface on error

2016-02-21 Thread Junjie Mao
usb_autopm_put_interface() should be called regardless of what idmouse_create_image() returns. Signed-off-by: Junjie Mao --- drivers/usb/misc/idmouse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c index 4e38683c653c

[PATCH] Initialize iter->started in trace_init_global_iter()

2015-11-17 Thread Junjie Mao
b02518a11e33 ]--- [ 123.250022] Kernel panic - not syncing: Fatal exception [ 123.250022] Kernel Offset: 0xaa0 from 0x8100 (relocation range: 0x8000-0xbfff) This bug has been reported in http://lkml.org/lkml/2014/9/2/11. Reported-by: Fengguang Wu Signed-off-by

[PATCH] Initialize iter->started in trace_init_global_iter()

2015-11-17 Thread Junjie Mao
tel.com> Signed-off-by: Junjie Mao <junjie@enight.me> --- kernel/trace/trace.c | 23 +-- kernel/trace/trace.h | 3 ++- kernel/trace/trace_kdb.c | 8 +++- 3 files changed, 30 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace.c b/ke

Need a pairing decrement if pm_runtime_get_sync() fails?

2015-07-17 Thread Junjie Mao
ist of these 102 call sites, along with their contexts, are attached below for reference. Best Regards Junjie Mao arch/arm/common/edma.c: ret = pm_runtime_get_sync(dev); arch/arm/common/edma.c- if (ret < 0) { ar

Need a pairing decrement if pm_runtime_get_sync() fails?

2015-07-17 Thread Junjie Mao
of these 102 call sites, along with their contexts, are attached below for reference. Best Regards Junjie Mao arch/arm/common/edma.c: ret = pm_runtime_get_sync(dev); arch/arm/common/edma.c- if (ret 0) { arch/arm/common

[PATCH] ASoC: Intel: fix runtime pm imbalance on error

2015-07-16 Thread Junjie Mao
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Junjie Mao --- sound/soc/intel/atom/sst/sst_drv_interface.c | 9 +++-- 1 file changed

[PATCH] ASoC: Intel: fix runtime pm imbalance on error

2015-07-16 Thread Junjie Mao
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Junjie Mao junjie@enight.me --- sound/soc/intel/atom/sst/sst_drv_interface.c | 9

[PATCH v2] edac: remove dev_attr_sdram_scrub_rate on failure and destory path

2015-02-03 Thread Junjie Mao
v2: also remove the sysfs node in edac_remove_sysfs_mci_device Signed-off-by: Junjie Mao --- drivers/edac/edac_mc_sysfs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 8e48d32efe37..97eefc409cac 100644 --- a/drivers

[PATCH v2] edac: remove dev_attr_sdram_scrub_rate on failure and destory path

2015-02-03 Thread Junjie Mao
v2: also remove the sysfs node in edac_remove_sysfs_mci_device Signed-off-by: Junjie Mao junjie@hotmail.com --- drivers/edac/edac_mc_sysfs.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 8e48d32efe37..97eefc409cac

Re: [PATCH v2] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
Guenter Roeck writes: > On Tue, Feb 03, 2015 at 10:40:14AM +0800, Junjie Mao wrote: >> v2: do not call kfree on allocated devs after device_initialize is called >> >> Signed-off-by: Junjie Mao >> --- >> drivers/edac/i7core_edac.c | 37 +++

[PATCH] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
v3: call device_remove_file on failure v2: do not call kfree on allocated devs after device_initialize is called Signed-off-by: Junjie Mao --- drivers/edac/i7core_edac.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/drivers/edac

[PATCH v2] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
v2: do not call kfree on allocated devs after device_initialize is called Signed-off-by: Junjie Mao --- drivers/edac/i7core_edac.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c

[PATCH] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
Signed-off-by: Junjie Mao --- drivers/edac/i7core_edac.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c index 9cd0b301f81b..98911150411b 100644 --- a/drivers/edac/i7core_edac.c

[PATCH] edac: remove dev_attr_sdram_scrub_rate on failure

2015-02-02 Thread Junjie Mao
Signed-off-by: Junjie Mao --- drivers/edac/edac_mc_sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 8e48d32efe37..ab2963bdd0d5 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -1068,6

[PATCH] edac: remove dev_attr_sdram_scrub_rate on failure

2015-02-02 Thread Junjie Mao
Signed-off-by: Junjie Mao junjie@hotmail.com --- drivers/edac/edac_mc_sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 8e48d32efe37..ab2963bdd0d5 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac

[PATCH] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
Signed-off-by: Junjie Mao junjie@hotmail.com --- drivers/edac/i7core_edac.c | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/drivers/edac/i7core_edac.c b/drivers/edac/i7core_edac.c index 9cd0b301f81b..98911150411b 100644

[PATCH v2] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
v2: do not call kfree on allocated devs after device_initialize is called Signed-off-by: Junjie Mao junjie@hotmail.com --- drivers/edac/i7core_edac.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/drivers/edac/i7core_edac.c b

Re: [PATCH v2] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
Guenter Roeck li...@roeck-us.net writes: On Tue, Feb 03, 2015 at 10:40:14AM +0800, Junjie Mao wrote: v2: do not call kfree on allocated devs after device_initialize is called Signed-off-by: Junjie Mao junjie@hotmail.com --- drivers/edac/i7core_edac.c | 37

[PATCH] i7core_edac: release resources on error in i7core_create_sysfs_devices

2015-02-02 Thread Junjie Mao
v3: call device_remove_file on failure v2: do not call kfree on allocated devs after device_initialize is called Signed-off-by: Junjie Mao junjie@hotmail.com --- drivers/edac/i7core_edac.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff

[PATCH v2] edac: fix the leak of mci->bus->name when bus_register fails

2015-01-28 Thread Junjie Mao
Also use goto labels for all failure paths in edac_create_sysfs_mci_device and update meaningless labels. Signed-off-by: Junjie Mao --- drivers/edac/edac_mc_sysfs.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac

[PATCH v2] edac: fix the leak of mci-bus-name when bus_register fails

2015-01-28 Thread Junjie Mao
Also use goto labels for all failure paths in edac_create_sysfs_mci_device and update meaningless labels. Signed-off-by: Junjie Mao junjie@hotmail.com --- drivers/edac/edac_mc_sysfs.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/edac

[tip:x86/urgent] x86, kaslr: Prevent .bss from overlaping initrd

2014-11-01 Thread tip-bot for Junjie Mao
Commit-ID: e6023367d779060fddc9a52d1f474085b2b36298 Gitweb: http://git.kernel.org/tip/e6023367d779060fddc9a52d1f474085b2b36298 Author: Junjie Mao AuthorDate: Fri, 31 Oct 2014 21:40:38 +0800 Committer: Thomas Gleixner CommitDate: Sat, 1 Nov 2014 22:20:50 +0100 x86, kaslr: Prevent .bss

[tip:x86/urgent] x86, kaslr: Prevent .bss from overlaping initrd

2014-11-01 Thread tip-bot for Junjie Mao
Commit-ID: e6023367d779060fddc9a52d1f474085b2b36298 Gitweb: http://git.kernel.org/tip/e6023367d779060fddc9a52d1f474085b2b36298 Author: Junjie Mao eternal@gmail.com AuthorDate: Fri, 31 Oct 2014 21:40:38 +0800 Committer: Thomas Gleixner t...@linutronix.de CommitDate: Sat, 1 Nov 2014 22

[PATCH v3] x86, kaslr: Prevent .bss from overlaping initrd

2014-10-31 Thread Junjie Mao
so that existing logic can effectively avoids the overlap. Fixes: 82fa9637a2 ("x86, kaslr: Select random position from e820 maps") Reported-by: Fengguang Wu Signed-off-by: Junjie Mao [kees: switched to perl to avoid hex translation pain in mawk vs gawk] [kees: calculated overlap w

[PATCH v3] x86, kaslr: Prevent .bss from overlaping initrd

2014-10-31 Thread Junjie Mao
that existing logic can effectively avoids the overlap. Fixes: 82fa9637a2 (x86, kaslr: Select random position from e820 maps) Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Junjie Mao eternal@gmail.com [kees: switched to perl to avoid hex translation pain in mawk vs gawk] [kees

[PATCH] x86, kaslr: Prevent .bss from overlaping initrd

2014-10-30 Thread Junjie Mao
t;x86, kaslr: Select random position from e820 maps") Reported-by: Fengguang Wu Signed-off-by: Junjie Mao --- arch/x86/boot/compressed/Makefile | 3 ++- arch/x86/boot/compressed/aslr.c| 5 +++-- arch/x86/boot/compressed/head_32.S | 3 ++- arch/x86/boot/compressed/head_64.S | 3 +++

[PATCH] x86, kaslr: Prevent .bss from overlaping initrd

2014-10-30 Thread Junjie Mao
, kaslr: Select random position from e820 maps) Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Junjie Mao eternal@gmail.com --- arch/x86/boot/compressed/Makefile | 3 ++- arch/x86/boot/compressed/aslr.c| 5 +++-- arch/x86/boot/compressed/head_32.S | 3 ++- arch/x86/boot

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Junjie Mao
I was not familiar with the acquiring/releasing API either, until I met with this bug... Perhaps we can use static checkers to avoid these issues as early as possible. Any suggestions? Best Regards Junjie Mao Martin Pitt writes: > Acked-By: Martin Pitt > > Hello Junjie, > > J

Re: [PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-29 Thread Junjie Mao
I was not familiar with the acquiring/releasing API either, until I met with this bug... Perhaps we can use static checkers to avoid these issues as early as possible. Any suggestions? Best Regards Junjie Mao Martin Pitt martin.p...@ubuntu.com writes: Acked-By: Martin Pitt martin.p

[PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-27 Thread Junjie Mao
x30 [0.505451] [<79677b10>] ? rest_init+0xc0/0xc0 [0.505451] Code: 89 d8 e8 cf 9b 9f ff 8b 4f 04 8d 55 e4 89 d8 e8 72 9d 9f ff 8d 43 2c 89 c1 89 45 d8 8b 43 30 8d 55 e4 89 53 30 89 4d e4 89 45 e8 <89> 10 8b 55 dc 8b 45 e0 89 7d ec e8 db af 9f ff eb 11 90 31 c0 [0.505451] EIP:

[PATCH] mac80211_hwsim: release driver when ieee80211_register_hw fails

2014-10-27 Thread Junjie Mao
Signed-off-by: Junjie Mao eternal@gmail.com --- drivers/net/wireless/mac80211_hwsim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index babbdc1ce741..c9ad4cf1adfb 100644 --- a/drivers/net