Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

iio/scmi: port driver to the new scmi_sensor_proto_ops interface Port driver to the new SCMI Sensor interface based on protocol handles and common devm_get_ops(). Cc: Jyoti Bhayana Cc: Jonathan Cameron Acked-by: Jyoti Bhayana Signed-off-by: Cristian Marussi On Thu

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

Hi Christian, Thanks for the detailed explanation. Sounds good to me. Thanks, Jyoti On Tue, Mar 16, 2021 at 3:22 PM Cristian Marussi wrote: > > Hi Jyoti, > > On Tue, Mar 16, 2021 at 10:51:48AM -0700, Jyoti Bhayana wrote: > > Hi Christian, > > > > Thanks for

Re: [PATCH v7 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

0 > -9439 -9431 -9423 9169807128884412416.00 > -9438 -9430 -9422 9169807128884412416.00 > -9437 -9429 -9421 9169807128884412416.00 > -9436 -9428 -9420 9169807128884412416.00 > -9435 -9427 -9419 9169807128884412416.00 > ^CCaught signal 2 > Disabling: in_acce

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

the event is registered a second time , the logic is all good. > ret = handle->notify_ops->devm_event_notifier_register(sdev, Thanks, Jyoti On Tue, Mar 16, 2021 at 5:50 AM Cristian Marussi wrote: > > Port driver to the new SCMI Sensor interface based on protocol handles > and

Re: [PATCH v7 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

Hi Jonathan, No worries. Thanks for the update. It looks good now. Thanks, Jyoti On Sun, Mar 14, 2021 at 8:40 AM Jonathan Cameron wrote: > > On Sat, 13 Mar 2021 11:55:39 -0800 > Jyoti Bhayana wrote: > > > Hi Jonathan, > > > > I still see the old version 6 in ib-i

Re: [PATCH v7 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

Hi Jonathan, I still see the old version 6 in ib-iio-scmi-5.12-rc2-take2 as well. Thanks, Jyoti On Sat, Mar 13, 2021 at 9:11 AM Jonathan Cameron wrote: > > On Fri, 12 Mar 2021 09:54:12 -0800 > Jyoti Bhayana wrote: > > > Hi Jonathan, > > > > I also see what Cri

Re: [PATCH v7 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

gnore me and I'll go ahead with this branch if you say so. > > Thanks > > Cristian > > > > On Fri, Mar 12, 2021 at 12:16:39PM +, Jonathan Cameron wrote: > > On Thu, 11 Mar 2021 21:08:44 + > > Jonathan Cameron wrote: > > > > > On Tue,

Re: [PATCH v7 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

ed, Mar 10, 2021 at 3:16 AM Peter Hilber wrote: > > On 10.03.21 00:12, Jyoti Bhayana wrote: > > This change provides ARM SCMI Protocol based IIO device. > > This driver provides support for Accelerometer and Gyroscope using > > SCMI Sensor Protocol extensions added

[PATCH v7 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using SCMI Sensor Protocol extensions added in the SCMIv3.0 ARM specification Reported-by: kernel test robot Signed-off-by: Jyoti Bhayana Link: https://lore.kernel.org/r

[PATCH v7 0/1] Adding support for IIO SCMI based sensors

version of the patch series has been tested using version 5.4.21 branch of Android common kernel. Any feedback welcome, Thanks, Jyoti Bhayana v6 --> v7 - Fixed the error reported by kernel test robot v5 --> v6 - Fixed the warning by kernel test robot - Incorporated the feedback comment

Re: [PATCH v6 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

gt; > > > On Tue, Feb 23, 2021 at 10:30:37AM -0800, Jyoti Bhayana wrote: > > > Hi Jonathan, > > > > > > Thanks for the detailed and careful review of this patch. Good to hear > > > that v7 is not required. Please find below answers to your > &

Re: [PATCH v6 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

us, perhaps _query_ or _format_ or _convert_ (to reflect you are converting values to expected form). Thanks, Jyoti On Sun, Feb 21, 2021 at 6:46 AM Jonathan Cameron wrote: > > On Fri, 12 Feb 2021 17:22:35 + > Jyoti Bhayana wrote: > > > This change provides ARM SCMI Pr

[PATCH v6 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using SCMI Sensor Protocol extensions added in the SCMIv3.0 ARM specification Reported-by: kernel test robot Signed-off-by: Jyoti Bhayana --- MAINTAINERS

[PATCH v6 0/1] Adding support for IIO SCMI based sensors

version of the patch series has been tested using version 5.4.21 branch of Android common kernel. Any feedback welcome, Thanks, Jyoti Bhayana v5 --> v6 - Fixed the warning by kernel test robot - Incorporated the feedback comments from v5 - Fixed the bug found in scmi_iio_set_odr_val

[PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using SCMI Sensor Protocol extensions added in the SCMIv3.0 ARM specification Signed-off-by: Jyoti Bhayana --- MAINTAINERS| 6 + drivers

[PATCH v5 0/1] Adding support for IIO SCMI based sensors

version of the patch series has been tested using version 5.4.21 branch of Android common kernel. Any feedback welcome, Thanks, Jyoti Bhayana v4 --> v5 - Dropped the RFC tag - Added channel ext_info for raw_available - Incorporated the feedback comments from v4 review of the patch v3 --&

Re: [RFC PATCH v4 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

5:11 AM Jonathan Cameron wrote: > > On Fri, 29 Jan 2021 22:18:18 + > Jyoti Bhayana wrote: > > > This change provides ARM SCMI Protocol based IIO device. > > This driver provides support for Accelerometer and Gyroscope using > > SCMI Sensor Protocol extensions added

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

, Jan 26, 2021 at 7:29 AM Peter Hilber wrote: > > On 22.01.21 00:21, Jyoti Bhayana wrote: > > > > > + > > +static int scmi_iio_get_sensor_max_range(struct iio_dev *iio_dev, int *val, > > + int *val2) > > +{ > >

Re: [RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

an Marussi wrote: > > Hi Jyoti, > > a few remarks below. > > On Thu, Jan 21, 2021 at 11:21:47PM +, Jyoti Bhayana wrote: > > This change provides ARM SCMI Protocol based IIO device. > > This driver provides support for Accelerometer and Gyroscope using > >

[RFC PATCH v4 0/1] Adding support for IIO SCMI based sensors

version of the patch series has been tested using version 5.4.21 branch of Android common kernel. Any feedback welcome, Thanks, Jyoti Bhayana v3 --> v4 - Incorporated the feedback comments from v3 review of the patch v2 --> v3 - Incorporated the feedback comments from v2 review of the

[RFC PATCH v4 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using SCMI Sensor Protocol extensions added in the SCMIv3.0 ARM specification Signed-off-by: Jyoti Bhayana --- MAINTAINERS| 6 + drivers/iio

[RFC PATCH v3 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using new SCMI Sensor Protocol defined by the upcoming SCMIv3.0 ARM specification Signed-off-by: Jyoti Bhayana --- MAINTAINERS| 6 + drivers

[RFC PATCH v3 0/1] Adding support for IIO SCMI based sensors

/ This version of the patch series has been tested using version 5.4.21 branch of Android common kernel. Any feedback welcome, Thanks, Jyoti Bhayana v2 --> v3 - Incorporated the feedback comments from v2 review of the patch v1 --> v2 - Incorporated the feedback comments from v1 review

Re: Reply to [RFC PATCH v2 0/1] Adding support for IIO SCMI based sensors

) min/max range is using H32 bits 2) resolution exponent is greater than the scale exponent. Thanks, Jyoti On Sun, Jan 17, 2021 at 3:56 AM Jonathan Cameron wrote: > > On Sat, 16 Jan 2021 23:15:56 -0800 > Jyoti Bhayana wrote: > > > Hi Jonathan, > > > > Can you cla

Re: Reply to [RFC PATCH v2 0/1] Adding support for IIO SCMI based sensors

: > > On Mon, 11 Jan 2021 13:17:51 -0800 > Jyoti Bhayana wrote: > > > Hi Jonathan, > > > > I know it is a bit confusing. Let me try to explain it with some > > examples to hopefully clarify some things here. > > SCMI Platform talks to the native/actual senso

Re: Reply to [RFC PATCH v2 0/1] Adding support for IIO SCMI based sensors

ve an IIO attribute for resolution like mentioned above. Thanks, Jyoti Thank you so much Jyoti On Mon, Jan 11, 2021 at 4:34 AM Jonathan Cameron wrote: > > On Sun, 10 Jan 2021 22:44:44 -0800 > Jyoti Bhayana wrote: > > > Hi Jonathan, > > > > In section 4.7.2.5.1 of

Re: Reply to [RFC PATCH v2 0/1] Adding support for IIO SCMI based sensors

nge and as well as resolution, then I have to use the float format with the scale applied. If there is another way which you know of and prefer, please let me know. Thanks, Jyoti Thanks, Jyoti On Sat, Jan 9, 2021 at 11:01 AM Jonathan Cameron wrote: > > On Wed, 6 Jan 2021 21:23:53 +000

Reply to [RFC PATCH v2 0/1] Adding support for IIO SCMI based sensors

Hi Jonathan, Instead of adding IIO_VAL_INT_H32_L32, I am thinking of adding IIO_VAL_FRACTIONAL_LONG or IIO_VAL_FRACTIONAL_64 as the scale/exponent used for min/max range can be different than the one used in resolution according to specification. I am planning to use read_avail for IIO_CHAN_IN

Reply to [RFC PATCH v2 0/1] Adding support for IIO SCMI based sensors

Hi Jonathan, > So, sensor_max_range can effectively be exposed as a combination of > scale and the *_raw_avail for a raw read (via the read_avail callback in IIO). > We'll ignore the fact the interface assumes a single value (so I assume > symmetric?) Based on the SCMI specification the sensor m

[RFC PATCH v2 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using new SCMI Sensor Protocol defined by the upcoming SCMIv3.0 ARM specification Signed-off-by: Jyoti Bhayana --- MAINTAINERS| 6 + drivers

[RFC PATCH v2 0/1] Adding support for IIO SCMI based sensors

a/\ linux.git/log/?h=for-next/scmi This version of the patch series has been tested using version 5.4.21 branch of Android common kernel. Any feedback welcome, Thanks, Jyoti Bhayana v1 --> v2 - Incorporated the feedback comments from v1 review of the patch - Regarding the new ABI for sensor

[RFC PATCH 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

This change provides ARM SCMI Protocol based IIO device. This driver provides support for Accelerometer and Gyroscope using new SCMI Sensor Protocol defined by the upcoming SCMIv3.0 ARM specification Signed-off-by: Jyoti Bhayana --- MAINTAINERS | 6 + drivers/iio/Kconfig

[RFC PATCH 0/1] Adding support for IIO SCMI based sensors

s based on linux kernel version 5.4.21 has been tested using branch of Android common kernel. Any feedback welcome, Thanks, Jyoti Bhayana Jyoti Bhayana (1): iio/scmi: Adding support for IIO SCMI Based Sensors MAINTAINERS | 6 + drivers/iio/Kconfig | 1 + d