th multiple - so the naming is a bit confusing.
Hm, I too think that the name is confusing and doesn't show the correct
context..is vimc_streamer_referance a better name? What name do you
suggest?
Thanks,
Kaaira
>
> --
> Kieran
>
> On 19/08/2020 19:04, Kaaira Gupta wro
On Wed, Sep 02, 2020 at 11:46:50AM +0100, Kieran Bingham wrote:
> Hi Kaaira,
>
> On 19/08/2020 19:04, Kaaira Gupta wrote:
> > If multiple captures try to enable stream, start their stream but do not
> > initialise the pipeline again. Also, don't start the thread sep
On Wed, Sep 02, 2020 at 11:29:31AM +0100, Kieran Bingham wrote:
> Hi Kaaira,
>
> On 19/08/2020 19:04, Kaaira Gupta wrote:
> > Multiple streams will share same stream struct if we want them to run on
> > same thread. So remove it from vimc_cap struct so that it doesn't get
&
Hi,
On Wed, Sep 02, 2020 at 11:13:09AM +0100, Kieran Bingham wrote:
> Hi Kaaira,
>
> On 19/08/2020 19:04, Kaaira Gupta wrote:
> > Make separate functions for stopping streaming of entities in path of a
> > particular stream and stopping thread. This is needed to ensure th
On Wed, Sep 02, 2020 at 10:56:46AM +0100, Kieran Bingham wrote:
> Hi Kaaira, Dafna,
>
> On 28/08/2020 21:37, Dafna Hirschfeld wrote:
> > Hi,
> >
> > Am 21.08.20 um 23:01 schrieb Kaaira Gupta:
> >> Hi,
> >>
> >> On Fri, Au
Hi,
Sorry for the late reply
On Fri, Aug 28, 2020 at 10:37:14PM +0200, Dafna Hirschfeld wrote:
> Hi,
>
> Am 21.08.20 um 23:01 schrieb Kaaira Gupta:
> > Hi,
> >
> > On Fri, Aug 21, 2020 at 05:11:23PM +0200, Dafna Hirschfeld wrote:
> > >
> > >
&g
On Thu, Aug 20, 2020 at 04:36:56PM +0100, Kieran Bingham wrote:
> Hi Kaaira,
>
> On 19/08/2020 19:04, Kaaira Gupta wrote:
> > In the process of making vimc compatible for multiple streams, we need
> > to create a frame passing process such that two different entities can
&
Hi,
On Fri, Aug 21, 2020 at 05:11:23PM +0200, Dafna Hirschfeld wrote:
>
>
> Am 19.08.20 um 20:04 schrieb Kaaira Gupta:
> > Separate the process of initialising pipeline array from starting
> > streaming for all entities in path of a stream. This is needed because
> >
subdevices could go
out of sync as they are being started and stopped at the same time,
prevent this by serializing starting and stopping of the vimc streamer.
[Kaaira: only rebased the patch on current HEAD of media-tree]
Signed-off-by: Niklas Söderlund
Signed-off-by: Kaaira Gupta
---
.../media/test
through their use counts.
Signed-off-by: Kaaira Gupta
---
.../media/test-drivers/vimc/vimc-streamer.c | 95 ---
1 file changed, 83 insertions(+), 12 deletions(-)
diff --git a/drivers/media/test-drivers/vimc/vimc-streamer.c
b/drivers/media/test-drivers/vimc/vimc-streamer.c
index
Start another capture, if one is already running, by checking for
existing pipe. If it exists already, don't fail to start second capture,
instead join it to the already running pipeline.
Use the same stream struct used by already running capture.
Signed-off-by: Kaaira Gupta
---
drivers/media
If multiple captures try to enable stream, start their stream but do not
initialise the pipeline again. Also, don't start the thread separately.
Starting their streams will update the use count and their frames would
be processed by the already running thread.
Signed-off-by: Kaaira Gupta
-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/vimc-capture.c | 15 +++
drivers/media/test-drivers/vimc/vimc-streamer.c | 17 ++---
drivers/media/test-drivers/vimc/vimc-streamer.h | 2 ++
3 files changed, 19 insertions(+), 15 deletions(-)
diff --git a/drivers/media/test
-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/vimc-capture.c | 3 +++
drivers/media/test-drivers/vimc/vimc-common.h | 2 ++
drivers/media/test-drivers/vimc/vimc-debayer.c | 7 +++
drivers/media/test-drivers/vimc/vimc-scaler.c | 7 +++
drivers/media/test-drivers/vimc/vimc-sensor.c | 6
Move the function vimc_get_source_entity() to vimc-common.c to make it
reusable.
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/vimc-common.c | 14 +++
drivers/media/test-drivers/vimc/vimc-common.h | 12 ++
.../media/test-drivers/vimc/vimc-streamer.c | 24
the frame which gets passed on.
So, to take care of this, add a get_frame callback to vimc device and
use it to get the frames for an entity from previous entity instead of
returning and passing the frames as an argument in process_frame.
Signed-off-by: Kaaira Gupta
---
.../media/test-drivers/vimc
Make separate functions for stopping streaming of entities in path of a
particular stream and stopping thread. This is needed to ensure that
thread doesn't stop when one device stops streaming in case of multiple
streams.
Signed-off-by: Kaaira Gupta
---
.../media/test-drivers/vimc/vimc
.
Kaaira Gupta (7):
media: vimc: Move get_source_entity to vimc-common
media: vimc: Add get_frame callback
media: vimc: Separate starting stream from pipeline initialisation
media: vimc: Separate closing of stream and thread
media: vimc: Dynamically allocate stream struct
media: vimc: Join
On Wed, Aug 05, 2020 at 12:19:52AM +0530, Kaaira Gupta wrote:
> Hi
>
> On Tue, Aug 04, 2020 at 11:24:56AM +0100, Kieran Bingham wrote:
> > Hi Kaaira,
> >
> > On 31/07/2020 18:22, Kaaira Gupta wrote:
> > > Hi everyone,
> > >
> > > On Wed, Ju
Hi
On Tue, Aug 04, 2020 at 11:24:56AM +0100, Kieran Bingham wrote:
> Hi Kaaira,
>
> On 31/07/2020 18:22, Kaaira Gupta wrote:
> > Hi everyone,
> >
> > On Wed, Jul 29, 2020 at 05:24:25PM +0200, Dafna Hirschfeld wrote:
> >>
> >>
> >> On 29.07.
29.07.20 15:05, Kieran Bingham wrote:
> > > > Hi Dafna,
> > > >
> > > > On 28/07/2020 15:00, Dafna Hirschfeld wrote:
> > > > >
> > > > >
> > > > > On 28.07.20 14:07, Dafna Hirschfeld wrote:
> > > > > > Hi
>
On Thu, Jul 30, 2020 at 01:51:12PM +0300, Laurent Pinchart wrote:
Hi,
> Hi Kaaira,
>
> Thank you for the patches.
>
> On Fri, Jul 24, 2020 at 05:32:10PM +0530, Kaaira Gupta wrote:
> > This is version 2 of the patch series posted by Niklas for allowing
> &g
On Tue, Jul 28, 2020 at 04:00:46PM +0200, Dafna Hirschfeld wrote:
>
>
> On 28.07.20 14:07, Dafna Hirschfeld wrote:
> > Hi
> >
> > On 28.07.20 13:39, Kaaira Gupta wrote:
> > > On Mon, Jul 27, 2020 at 02:54:30PM -0300, Helen Koike wrote:
> > > >
On Tue, Jul 28, 2020 at 02:24:37PM +0200, Dafna Hirschfeld wrote:
>
>
> On 24.07.20 14:02, Kaaira Gupta wrote:
> > An output which is running is already part of a pipeline and trying to
> > start a new pipeline is not possible. This prevents two capture devices
> >
On Mon, Jul 27, 2020 at 02:54:30PM -0300, Helen Koike wrote:
> Hi,
>
> On 7/27/20 11:31 AM, Kieran Bingham wrote:
> > Hi all,
> >
> > +Dafna for the thread discussion, as she's missed from the to/cc list.
> >
> >
> > On 24/07/2020 13:21, Kaaira Gu
On Fri, Jul 24, 2020 at 02:15:21PM +0200, Niklas Söderlund wrote:
Hi,
> Hi Kaaira,
>
> Thanks for your work.
Thanks for yours :D
>
> On 2020-07-24 17:32:10 +0530, Kaaira Gupta wrote:
> > This is version 2 of the patch series posted by Niklas for allowing
> &g
as they are being started and stopped at the same time,
prevent this by serializing starting and stopping of the vimc streamer.
[Kaaira: rebased the patch on current HEAD of media-tree
(8f2a4a9d5ff5202d0b3e3a144ebb9b67aabadd29)]
Signed-off-by: Niklas Söderlund
Signed-off-by: Kaaira Gupta
Söderlund
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/vimc-debayer.c | 8
drivers/media/test-drivers/vimc/vimc-scaler.c | 8
drivers/media/test-drivers/vimc/vimc-sensor.c | 9 -
3 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers
for
simultaneously use.
Changes since v1:
- All three patches rebased on latest media-tree.
Patch 3:
- Search for an entity with a non-NULL pipe instead of searching
for sensor. This terminates the search at output itself.
Kaaira Gupta (3):
media: vimc: Add usage count
and conditions accordingly]
Signed-off-by: Niklas Söderlund
Signed-off-by: Kaaira Gupta
---
.../media/test-drivers/vimc/vimc-capture.c| 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/drivers/media/test-drivers/vimc/vimc-capture.c
b/drivers/media/test-drivers
*) to this function.
Signed-off-by: Kaaira Gupta
Reviewed-by: Helen Koike
Reviewed-by: Kieran Bingham
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 10 +-
include/media/tpg/v4l2-tpg.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
Reviewed-by: Helen Koike
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 30 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff
t patterns
(Reported-by: kernel test robot )
- Renamed variables from camelcase to use '_'
- prefixed 'media' to the patches.
Kaaira Gupta (3):
media: tpg: change char argument to const char
media: tpg: Add function to return colors' order of test image
media: vimc: Add
Add a control in VIMC to display information such as the correct order of
colors for a given test pattern, counter, brightness, hue, saturation,
contrast, width and height at sensor over test image.
Signed-off-by: Kaaira Gupta
Acked-by: Helen Koike
Reviewed-by: Kieran Bingham
---
drivers
Add a control in VIMC to display information such as the correct order of
colors for a given test pattern, counter, brightness, hue, saturation,
contrast, width and height at sensor over test image.
Signed-off-by: Kaaira Gupta
Acked-by: Helen Koike
---
drivers/media/test-drivers/vimc/Kconfig
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
Reviewed-by: Helen Koike
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 30 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff
*)
to this function.
Signed-off-by: Kaaira Gupta
Reviewed-by: Helen Koike
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 10 +-
include/media/tpg/v4l2-tpg.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
.
Kaaira Gupta (3):
media: tpg: change char argument to const char
media: tpg: Add function to return colors' order of test image
media: vimc: Add a control to display info on test image
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 40 +--
drivers/media/test-drivers/vimc/Kconfig
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 30 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/media/common
for separate test patterns
(Reported-by: kernel test robot )
- Renamed variables from camelcase to use '_'
- prefixed 'media' to the patches.
Kaaira Gupta (3):
media: tpg: change char argument to const char
media: tpg: Add function to return colors' order of test image
Add a control in VIMC to display information such as the correct order of
colors for a given test pattern, counter, brightness, hue, saturation,
contrast, width and height at sensor over test image.
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/Kconfig | 2 +
drivers
Change the argument of type char * to const char * for function
tpg_gen_text().
Signed-off-by: Kaaira Gupta
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 10 +-
include/media/tpg/v4l2-tpg.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
On Fri, Jun 26, 2020 at 01:01:03PM -0300, Helen Koike wrote:
> Hi Kaaira,
>
> On 6/26/20 10:07 AM, Kaaira Gupta wrote:
> > Add a control in VIMC to display information such as the correct order of
> > colors for a given test pattern, brightness, hue, saturation, contrast,
Add a control in VIMC to display information such as the correct order of
colors for a given test pattern, brightness, hue, saturation, contrast,
width and height at sensor over test image.
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/Kconfig | 2 +
drivers/media/test
)
- Made separate switch cases for separate test patterns
(Reported-by: kernel test robot )
- Renamed variables from camelcase to use '_'
- prefixed 'media' to the patches.
Kaaira Gupta (3):
media: tpg: change char argument to const char
media: tpg: Add function to return
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 30 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/media/common
Change the argument of type char * to const char * for function
tpg_gen_text().
Signed-off-by: Kaaira Gupta
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 10 +-
include/media/tpg/v4l2-tpg.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
On Fri, Jun 26, 2020 at 08:59:19AM -0300, Helen Koike wrote:
> Hi Kaaira,
>
> Thanks for the patch,
>
> On 6/26/20 8:36 AM, Kaaira Gupta wrote:
> > Add a control in VIMC to display information such as the correct order of
> > colors for a given test pattern, brightness
On Fri, Jun 26, 2020 at 08:59:19AM -0300, Helen Koike wrote:
> Hi Kaaira,
>
> Thanks for the patch,
>
> On 6/26/20 8:36 AM, Kaaira Gupta wrote:
> > Add a control in VIMC to display information such as the correct order of
> > colors for a given test pattern, brightness
variables from camelcase to use '_'
- prefixed 'media' to the patches.
Kaaira Gupta (3):
media: tpg: change char argument to const char
media: tpg: Add function to return colors' order of test image
media: vimc: Add a control to display info on test image
drivers/media/common/v4l2
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 30 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/media/common
Add a control in VIMC to display information such as the correct order of
colors for a given test pattern, brightness, hue, saturation, contrast,
width and height at sensor, and time since streaming started over test image.
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/Kconfig
Change the argument of type char * to const char * for function
tpg_gen_text().
Signed-off-by: Kaaira Gupta
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 10 +-
include/media/tpg/v4l2-tpg.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 29 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 28 insertions(+), 2 deletions(-)
diff --git a/drivers/media/common
Add a control in VIMC to display information such as the correct order of
colors for a given test pattern, brightness, hue, saturation, contrast,
width and height at sensor over test image.
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/Kconfig | 2 +
drivers/media/test
Change the argument of type char * to const char * for function
tpg_gen_text().
Signed-off-by: Kaaira Gupta
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 10 +-
include/media/tpg/v4l2-tpg.h | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git
. (Reported-by: kernel test robot )
- Made separate switch cases for separate test patterns
(Reported-by: kernel test robot )
- Renamed variables from camelcase to use '_'
- prefixed 'media' to the patches.
Kaaira Gupta (3):
media: tpg: change char argument to const char
On Sat, Jun 20, 2020 at 12:05:28PM +0200, Dafna Hirschfeld wrote:
> Hi, thanks for the patch
>
> On 18.06.20 21:05, Kaaira Gupta wrote:
> > Add a control in VIMC to display information such as the correct oder of
> > colors for a given test pattern, brightness, hue,
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 32 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/media/common
robot )
- Made separate switch cases for separate test patterns
(Reported-by: kernel test robot )
- Renamed variables from camelcase to use '_'
- prefixed 'media' to the patches.
Kaaira Gupta (2):
media: tpg: Add function to return colors' order of test image
Add a control in VIMC to display information such as the correct oder of
colors for a given test pattern, brightness, hue, saturation, contrast
and, width and height at sensor over test image; and display that
information.
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/Kconfig
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
Reviewed-by: Kieran Bingham
---
Changes since v2:
- Create a 'define' to prevent repetition of the common color
sequence string.
- Use 'fallthrough' on case statement to prevent repetition of
code.
Changes
On Mon, Jun 15, 2020 at 12:48:20PM +0100, Kieran Bingham wrote:
> Hi Kaaira,
>
> On 14/06/2020 21:02, Kaaira Gupta wrote:
> > Add a control in VIMC to show the correct order of the colors for a
> > given test pattern.
> > The control can be accessed by using sh
Add a control in VIMC to show the correct order of the colors for a
given test pattern.
The control can be accessed by using show_colors_order in v4l2-ctl
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/Kconfig | 2 ++
drivers/media/test-drivers/vimc/vimc-common.h | 1
for text in tpg_gen_text().
Signed-off-by: Kaaira Gupta
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 32 +--
include/media/tpg/v4l2-tpg.h | 1 +
2 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
b
camelcase to use '_'
- prefixed 'media' to the patches.
Kaaira Gupta (2):
media: tpg: Add function to return colors' order of test image
media: vimc: Add a control to show test pattern colors' order
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 32 +++--
drivers/media/test
() for patterns for which color order
does not exist/make sense to print.
Make a separate control for the same in vimc to make displaying the
text optional.
Signed-off-by: Kaaira Gupta
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 24 -
drivers/media/test-drivers/vimc/Kconfig
, and maybe we can print some other useful information as well
(like vivid does).
Signed-off-by: Kaaira Gupta
---
drivers/media/test-drivers/vimc/Kconfig | 2 ++
drivers/media/test-drivers/vimc/vimc-core.c | 9 +
drivers/media/test-drivers/vimc/vimc-sensor.c | 8
3 files changed
On Mon, Jun 01, 2020 at 01:36:59PM -0300, Helen Koike wrote:
>
>
> On 6/1/20 10:53 AM, Kaaira Gupta wrote:
> > Hi!
> >
> > Currently there is no method to know if the test image generated by vimc
> > is correct (except for comparing it with a known '
Hi!
Currently there is no method to know if the test image generated by vimc
is correct (except for comparing it with a known 'correct' image). So, I
wanted to investigate about a possibility to add text to each color bar
of the generated pattern. I think currently vivid supports this
s its supported formats wih --list-formats. Shouldn't BA24 be
possible to capture with vimc?
If yes, which entity should support it, if not debayer? Should there be
a separate conversion entity, or should we keep the support in debayer
itself for efficiency issues?
>
>
> On 28.05.20 2
Running qcam for pixelformat 0x34324142 showed that vimc debayer does
not support it. Hence, add the support for Alpha (255).
Signed-off-by: Kaaira Gupta
---
.../media/test-drivers/vimc/vimc-debayer.c| 27 ---
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git
72 matches
Mail list logo
