[v1] drm/msm/disp/dpu1: program 3d_merge only if block is attached

2021-04-02 Thread Kalyan Thota
Update the 3d merge as active in the data path only if the hw block is selected in the configuration. Reported-by: Stephen Boyd Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm

[v1] drm/msm/disp/dpu1: fix warn stack reported during dpu resume

2021-03-31 Thread Kalyan Thota
x the WARN condition appropriately. Reported-by: Steev Klimaszewski Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 +--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 9 + drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 11 ++- 3 files changed, 20 insert

[v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume

2021-03-22 Thread Kalyan Thota
From: Kalyan Thota DPU runtime resume will request for a min vote on the AXI bus as it is a necessary step before turning ON the AXI clock. The change does below 1) Move the icc path set before requesting runtime get_sync. 2) remove the dependency of hw catalog for min ib vote as it is

[v1] drm/msm/disp/dpu1: fix display underruns during modeset.

2021-03-19 Thread Kalyan Thota
uring atomic check when there is no modeset enable. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 1 - drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf

[v1] drm/msm/disp/dpu1: fix warning reported by kernel bot in dpu driver

2021-03-04 Thread Kalyan Thota
Fix a warning, pointing to an early deference of a variable before check. This bug was introduced in the following commit. commit 4259ff7ae509 ("drm/msm/dpu: add support for pcc color block in dpu driver") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Ka

[v4] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-18 Thread Kalyan Thota
vblank timestamp support. (Rob). - Add changes to provide vblank counter from dpu driver. Changes in v2: - Fix warn stack reported by Rob Clark with v2 patch. Changes in v3: - Move back to HW frame counter (Rob). Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

[v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Kalyan Thota
From: Kalyan Thota Set the flag vblank_disable_immediate = true to turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups and help in power saving. To enable vblank_disable_immediate flag the

[v3] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu

2021-02-12 Thread Kalyan Thota
vblank timestamp support. (Rob) - Add changes to provide vblank counter from dpu driver. Changes in v2: - fix warn stack reported by Rob with v2 patch Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c| 80 + drivers/gpu/drm/msm/disp/dpu1

[v2] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2020-12-18 Thread Kalyan Thota
vblank timestamp support. (Rob) - Add changes to provide vblank counter from dpu driver. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 80 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 30 drivers/gpu/drm/msm/disp/dpu1

[v1] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2020-12-14 Thread Kalyan Thota
Turn off vblank irqs immediately as soon as drm_vblank_put is requested so that there are no irqs triggered during idle state. This will reduce cpu wakeups and help in power saving. The change also enable driver timestamp for vblanks. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp

[v1] drm/msm/dpu: consider vertical front porch in the prefill bw calculation

2020-11-25 Thread Kalyan Thota
to fill the latency lines. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index 7ea90d2..315b999

[v3] drm/msm/dpu: Fix reservation failures in modeset

2020-08-10 Thread Kalyan Thota
in v2: - Handle dpu_kms_get_global_state API failure as it may return EDEADLK (swboyd). Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1

[v2] drm/msm/dpu: Fix reservation failures in modeset

2020-08-07 Thread Kalyan Thota
-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 63976dc..50a98d1 100644 --- a/drivers/gpu/drm

[v1] drm/msm/dpu: Fix reservation failures in modeset

2020-08-05 Thread Kalyan Thota
--> old, new modeset disables --> virt disable modeset enable --> virt modeset Allow reservations to be cleared only when crtc active is false as in that case there wont be any modeset enable after disable. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_enco

[v1] drm/msm/dpu: update reservations in commit path

2020-08-04 Thread Kalyan Thota
the composition if resources are not available. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

[v1] drm/msm/dpu: Fix scale params in plane validation

2020-07-30 Thread Kalyan Thota
Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c index 6379fe1..e46dcb9 100644 --- a/drivers/gpu/drm/msm/dis

[PATCH 3/3] drm/msm/dpu: add support for clk and bw scaling for display

2020-07-16 Thread Kalyan Thota
This change adds support to scale src clk and bandwidth as per composition requirements. Interconnect registration for bw has been moved to mdp device node from mdss to facilitate the scaling. Changes in v1: - Address armv7 compilation issues with the patch (Rob) Signed-off-by: Kalyan Thota

[PATCH 1/3] arm64: dts: sc7180: add interconnect bindings for display

2020-07-16 Thread Kalyan Thota
From: Krishna Manikandan This change adds the interconnect bindings to the MDSS node. This will establish Display to DDR path for bus bandwidth voting. Changes in v2: - Change in commit message(Matthias Kaehlcke) Changes in v3: - Updated commit message to include revie

[PATCH 2/3] arm64: dts: sc7180: add bus clock to mdp node for sc7180 target

2020-07-16 Thread Kalyan Thota
From: Krishna Manikandan Move the bus clock to mdp device node,in order to facilitate bus band width scaling on sc7180 target. The parent device MDSS will not vote for bus bw, instead the vote will be triggered by mdp device node. Since a minimum vote is required to turn on bus clock, move the c

[v1] drm/msm/dpu: enumerate second cursor pipe for external interface

2020-06-25 Thread Kalyan Thota
Setup an RGB HW pipe as cursor which can be used on secondary interface. For SC7180 2 HW pipes are enumerated as cursors 1 - primary interface 2 - secondary interface Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 ++-- 1 file changed, 6 insertions

[v2] drm/msm/dpu: add support for dither block in display

2020-06-25 Thread Kalyan Thota
This change enables dither block for primary interface in display. Enabled for 6bpc in the current version. Changes in v1: - Remove redundant error checks (Rob). Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 39 +++ drivers/gpu/drm/msm/disp

[PATCH] drm/msm/dpu: add support for dither block in display

2020-06-24 Thread Kalyan Thota
This change enables dither block for primary interface in display. Enabled for 6bpc in the current version. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 45 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 66

[v1] drm/msm/dpu: add support for clk and bw scaling for display

2020-06-18 Thread Kalyan Thota
This change adds support to scale src clk and bandwidth as per composition requirements. Interconnect registration for bw has been moved to mdp device node from mdss to facilitate the scaling. Changes in v1: - Address armv7 compilation issues with the patch (Rob) Signed-off-by: Kalyan Thota

[v8] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-06-18 Thread Kalyan Thota
o turn off the resources. Changes in v7: - Add "__maybe_unused" to the functions to avoid compilation failures. Cleanup unnecessary configs (Doug). Signed-off-by: Kalyan Thota Reviewed-by: Douglas Anderson --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + drivers/gpu/drm/msm/dsi/dsi

[PATCH v6] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-06-04 Thread Kalyan Thota
o turn off the resources. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 + drivers/gpu/drm/msm/dsi/dsi.c | 2 + drivers/gpu/drm/msm/msm_drv.c | 67 - 3 files changed, 37 insertions(+), 34 deletions(-) diff --git

[PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

2020-05-01 Thread Kalyan Thota
are and PM complete phases there by ensuring that clks are on when panel off commands are being processed. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi.c | 2 ++ drivers/gpu/drm/msm/msm_drv.c | 20 +++