Re: [Patch v5 12/12] Documention: v4l: Documentation for HEVC CIDs

Hi, Please find my comments inline. On 19 June 2017 at 07:10, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > --- > Documentation/media/uapi/v4l/extended-controls.rst | 364 > +

Re: [Patch v5 12/12] Documention: v4l: Documentation for HEVC CIDs

Hi, Please find my comments inline. On 19 June 2017 at 07:10, Smitha T Murthy wrote: > Added V4l2 controls for HEVC encoder > > Signed-off-by: Smitha T Murthy > --- > Documentation/media/uapi/v4l/extended-controls.rst | 364 > + > 1 file changed, 364 insertions(+) > >

Re: [Patch v5 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements

buf_addr1 += ctx->me_buffer_size; > + buf_size1 -= (ctx->luma_dpb_size + > ctx->chroma_dpb_size > + + ctx->me_buffer_size); > + } > } > > writel(buf_addr1, mfc_regs->e_scratch_buffer_addr); > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > index 021b8db..975bbc5 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > @@ -26,6 +26,8 @@ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 128) > #define S5P_MFC_DEC_MV_SIZE_V10(x, y) (MB_WIDTH(x) * \ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 512) > +#define enc_lcu_width(x_size) DIV_ROUND_UP(x_size, 32) > +#define enc_lcu_height(y_size) DIV_ROUND_UP(y_size, 32) Why is this in lower case? Maybe S5P_MFC_LCU_WIDTH/HEIGHT would be better? > > /* Definition */ > #define ENC_MULTI_SLICE_MB_MAX ((1 << 30) - 1) > -- > 2.7.4 > Apart from the above, it looks good to me. Acked-by: Kamil Debski <ka...@wypas.org> Best wishes, Kamil Debski

Re: [Patch v5 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements

;luma_dpb_size + > ctx->chroma_dpb_size > + + ctx->me_buffer_size); > + } > } > > writel(buf_addr1, mfc_regs->e_scratch_buffer_addr); > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > index 021b8db..975bbc5 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.h > @@ -26,6 +26,8 @@ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 128) > #define S5P_MFC_DEC_MV_SIZE_V10(x, y) (MB_WIDTH(x) * \ > (((MB_HEIGHT(y)+1)/2)*2) * 64 + 512) > +#define enc_lcu_width(x_size) DIV_ROUND_UP(x_size, 32) > +#define enc_lcu_height(y_size) DIV_ROUND_UP(y_size, 32) Why is this in lower case? Maybe S5P_MFC_LCU_WIDTH/HEIGHT would be better? > > /* Definition */ > #define ENC_MULTI_SLICE_MB_MAX ((1 << 30) - 1) > -- > 2.7.4 > Apart from the above, it looks good to me. Acked-by: Kamil Debski Best wishes, Kamil Debski

[PATCH] MAINTAINERS: update email and list of Samsung HW driver maintainers

Change my email address in the MAINTAINERS file. Add new maintainers of selected Samsung HW drivers. Signed-off-by: Kamil Debski <k.deb...@samsung.com> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> Cc: Andrew Morton <a...@linux-foundation.org> Cc: Guenter Roeck <l

[PATCH] MAINTAINERS: update email and list of Samsung HW driver maintainers

Change my email address in the MAINTAINERS file. Add new maintainers of selected Samsung HW drivers. Signed-off-by: Kamil Debski Cc: Greg Kroah-Hartman Cc: Andrew Morton Cc: Guenter Roeck Cc: Kishon Vijay Abraham I Cc: Mauro Carvalho Chehab Cc: linux-hw...@vger.kernel.org Cc: Andrzej Hajda

RE: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove()

nuxtv/master? Best wishes, -- Kamil Debski Samsung R Institute Poland > -Original Message- > From: Shuah Khan [mailto:shua...@osg.samsung.com] > Sent: Monday, June 13, 2016 9:45 PM > To: kyungmin.p...@samsung.com; k.deb...@samsung.com; > jtp.p...@samsung.com; mche...@osg.sa

RE: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove()

of linuxtv/master is : "commit 0db5c79989de2c68d5abb7ba891bfdb3cd3b7e05 Author: Mauro Carvalho Chehab Date: Thu Jun 16 08:04:40 2016 -0300 [media] media-devnode.h: Fix documentation" Could you please rebase the two patches mentioned above to the linuxtv/master? Best wishes, -- Ka

RE: [PATCH v5 08/46] hwmon: pwm-fan: use pwm_get_args() where appropriate

dout and expose real PWM state even when the PWM has just been > requested (before the user calls pwm_config/enable/disable()). > > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Kamil Debski <k.deb...@samsung.com> Best wishes, -- Kamil Debski Samsung R Institute Poland

RE: [PATCH v5 08/46] hwmon: pwm-fan: use pwm_get_args() where appropriate

dout and expose real PWM state even when the PWM has just been > requested (before the user calls pwm_config/enable/disable()). > > Signed-off-by: Boris Brezillon Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R Institute Poland

RE: [PATCH v5 35/46] hwmon: pwm-fan: switch to the atomic API

t; > Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> Acked-by: Kamil Debski <k.deb...@samsung.com> Best wishes, -- Kamil Debski Samsung R Institute Poland

RE: [PATCH v5 35/46] hwmon: pwm-fan: switch to the atomic API

t; > Signed-off-by: Boris Brezillon Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R Institute Poland

RE: [PATCH 1/1] mtd: nand_bbt: separate struct nand_chip from nand_bbt.c

find it below. Best wishes, Kamil Debski From: linux-mtd [mailto:linux-mtd-boun...@lists.infradead.org] On Behalf Of Peter Pan ?? (peterpandong) Sent: 15 May 2015 08:32 > Currently nand_bbt.c is tied with struct nand_chip, and it makes other > NAND family chips hard to use nand_bbt.c. Mayb

RE: [PATCH 1/1] mtd: nand_bbt: separate struct nand_chip from nand_bbt.c

find it below. Best wishes, Kamil Debski From: linux-mtd [mailto:linux-mtd-boun...@lists.infradead.org] On Behalf Of Peter Pan ?? (peterpandong) Sent: 15 May 2015 08:32 Currently nand_bbt.c is tied with struct nand_chip, and it makes other NAND family chips hard to use nand_bbt.c. Maybe it's

RE: [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array

d-off-by: Axel Lin Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R Institute Poland > --- > drivers/phy/phy-exynos4210-usb2.c | 1 - drivers/phy/phy-exynos4x12- > usb2.c | 1 - drivers/phy/phy-exynos5250-usb2.c | 1 - > 3 files changed, 3 deletions(-) > > dif

RE: [PATCH] phy: samsung-usb2: Remove NULL terminating entry from phys array

@ingics.com Acked-by: Kamil Debski k.deb...@samsung.com Best wishes, -- Kamil Debski Samsung RD Institute Poland --- drivers/phy/phy-exynos4210-usb2.c | 1 - drivers/phy/phy-exynos4x12- usb2.c | 1 - drivers/phy/phy-exynos5250-usb2.c | 1 - 3 files changed, 3 deletions(-) diff --git

RE: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver name and global structure

Hi, > From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] > Sent: Thursday, December 11, 2014 7:30 AM > To: Kishon Vijay Abraham I; Kamil Debski > Cc: linux-kernel@vger.kernel.org; Linux USB Mailing List; Vivek Gautam > Subject: Re: [PATCH] phy: phy-samsung-usb2: Don'

RE: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver name and global structure

Hi, From: Vivek Gautam [mailto:gautamvivek1...@gmail.com] Sent: Thursday, December 11, 2014 7:30 AM To: Kishon Vijay Abraham I; Kamil Debski Cc: linux-kernel@vger.kernel.org; Linux USB Mailing List; Vivek Gautam Subject: Re: [PATCH] phy: phy-samsung-usb2: Don't use same name for driver name

RE: [PATCH] media / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

Hi, > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Wednesday, December 03, 2014 3:14 AM > To: linux-me...@vger.kernel.org > Cc: Kyungmin Park; Sylwester Nawrocki; Mauro Carvalho Chehab; Kukjin > Kim; linux-samsung-...@vger.kernel.org; Kamil Debski; Philipp Zabel;

RE: [PATCH] media / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

Hi, From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] Sent: Wednesday, December 03, 2014 3:14 AM To: linux-me...@vger.kernel.org Cc: Kyungmin Park; Sylwester Nawrocki; Mauro Carvalho Chehab; Kukjin Kim; linux-samsung-...@vger.kernel.org; Kamil Debski; Philipp Zabel; Linux PM list; Linux

RE: [PATCH 09/12] media: s5p-mfc: use vb2_ops_wait_prepare/finish helper

Hi, Please provide a commit description. No matter how obvious the commit seems. Best wishes, -- Kamil Debski Samsung R Institute Poland > -Original Message- > From: Lad, Prabhakar [mailto:prabhakar.cse...@gmail.com] > Sent: Tuesday, November 18, 2014 12:24 PM > To:

RE: [PATCH 09/12] media: s5p-mfc: use vb2_ops_wait_prepare/finish helper

Hi, Please provide a commit description. No matter how obvious the commit seems. Best wishes, -- Kamil Debski Samsung RD Institute Poland -Original Message- From: Lad, Prabhakar [mailto:prabhakar.cse...@gmail.com] Sent: Tuesday, November 18, 2014 12:24 PM To: Hans Verkuil; Mauro

[PATCH v2] ARM: dts: Add pwm-fan node to the Odroid-U3 board

Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the "pwm" label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski --- Changes since v1: - added pwm label to the pwm@139D node in exynos4.dtsi - u

[PATCH v2] ARM: dts: Add pwm-fan node to the Odroid-U3 board

Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com --- Changes since v1: - added pwm label to the pwm@139D node in exynos4.dtsi

[PATCH] hwmon: (pwm-fan) Fix suspend/resume behavior

The state of a PWM output is not clearly defined after resume. Some PWM drivers do not restore the duty cycle upon resume, thus it is necessary to manually restore the correct value. Signed-off-by: Kamil Debski --- drivers/hwmon/pwm-fan.c | 13 ++--- 1 file changed, 10 insertions

[PATCH] ARM: dts: Add pwm-fan node to the Odroid-U3 board

Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. Signed-off-by: Kamil Debski --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts

[PATCH] hwmon: (pwm-fan) Fix suspend/resume behavior

The state of a PWM output is not clearly defined after resume. Some PWM drivers do not restore the duty cycle upon resume, thus it is necessary to manually restore the correct value. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/hwmon/pwm-fan.c | 13 ++--- 1 file changed

[PATCH] ARM: dts: Add pwm-fan node to the Odroid-U3 board

Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. Signed-off-by: Kamil Debski k.deb...@samsung.com --- arch/arm/boot/dts/exynos4412-odroidu3.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b

RE: [PATCH] [media] s5p-mfc: Use decode status instead of display status on MFCv5

Hi Sjoerd, > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Sjoerd Simons > Sent: Monday, September 22, 2014 2:52 PM > To: Kyungmin Park; Kamil Debski; Arun Kumar K > Cc: Mauro Carvalho Chehab; linux-arm-ker...@lists.infradead.o

RE: [PATCH] [media] s5p-mfc: Use decode status instead of display status on MFCv5

Hi Sjoerd, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Sjoerd Simons Sent: Monday, September 22, 2014 2:52 PM To: Kyungmin Park; Kamil Debski; Arun Kumar K Cc: Mauro Carvalho Chehab; linux-arm-ker...@lists.infradead.org; linux- me

[PATCH v2] MAINTAINERS: add entry for the Samsung USB2 PHY driver

Add MAINTAINERS entry for the Samsung USB2 PHY driver. Signed-off-by: Kamil Debski --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 05dc39d..548602f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7873,6 +7873,19 @@ S

[PATCH v2] MAINTAINERS: add entry for the Samsung USB2 PHY driver

Add MAINTAINERS entry for the Samsung USB2 PHY driver. Signed-off-by: Kamil Debski k.deb...@samsung.com --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 05dc39d..548602f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7873,6

[PATCH] MAINTAINERS: add entry for the Samsung USB2 PHY driver

Signed-off-by: Kamil Debski --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 05dc39d..548602f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7873,6 +7873,19 @@ S: Supported L: net...@vger.kernel.org F: drivers

[PATCH] MAINTAINERS: add entry for the PWM fan driver

Signed-off-by: Kamil Debski --- MAINTAINERS |8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 548602f..38e4765 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7244,6 +7244,14 @@ T: git git://linuxtv.org/media_tree.git S: Maintained F

[PATCH] MAINTAINERS: add entry for the PWM fan driver

Signed-off-by: Kamil Debski k.deb...@samsung.com --- MAINTAINERS |8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 548602f..38e4765 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7244,6 +7244,14 @@ T: git git://linuxtv.org/media_tree.git S

[PATCH] MAINTAINERS: add entry for the Samsung USB2 PHY driver

Signed-off-by: Kamil Debski k.deb...@samsung.com --- MAINTAINERS | 13 + 1 file changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 05dc39d..548602f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7873,6 +7873,19 @@ S: Supported L: net

RE: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

Hi Guenter, > From: Guenter Roeck [mailto:li...@roeck-us.net] > Sent: Wednesday, July 16, 2014 3:53 PM > To: Kamil Debski; devicet...@vger.kernel.org; linux- > ker...@vger.kernel.org; lm-sens...@lm-sensors.org > Cc: t.f...@samsung.com; m.szyprow...@samsung.com; tklau...@dist

[PATCH v5] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski Reviewed-by: Varka Bhadram Reviewed-by: Tobias Klauser --- Changes since

RE: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

Hi Varka, Thank you for the review. I agree with your comments in this and your second email. I have just sent an updated version 4 of the patch. Best wishes, -- Kamil Debski Samsung R Institute Poland > -Original Message- > From: Varka Bhadram [mailto:varkabhad...@gmail.com]

[PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- Changes since v3: - fix missing "\n" in error message

[PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski k.deb...@samsung.com --- Changes since v3: - fix missing \n in error messages

RE: [PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

Hi Varka, Thank you for the review. I agree with your comments in this and your second email. I have just sent an updated version 4 of the patch. Best wishes, -- Kamil Debski Samsung RD Institute Poland -Original Message- From: Varka Bhadram [mailto:varkabhad...@gmail.com] Sent

[PATCH v5] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski k.deb...@samsung.com Reviewed-by: Varka Bhadram varkabhad...@gmail.com

RE: [PATCH v4] hwmon: pwm-fan: Add pwm-fan driver

Hi Guenter, From: Guenter Roeck [mailto:li...@roeck-us.net] Sent: Wednesday, July 16, 2014 3:53 PM To: Kamil Debski; devicet...@vger.kernel.org; linux- ker...@vger.kernel.org; lm-sens...@lm-sensors.org Cc: t.f...@samsung.com; m.szyprow...@samsung.com; tklau...@distanz.ch; linux

[PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- Changes since v2: - add CONFIG_PM_SLEEP around pwm_fan_suspend

[PATCH v3] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski k.deb...@samsung.com --- Changes since v2: - add CONFIG_PM_SLEEP around

[PATCH v2] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- Changes since v1: - added documentation to Documentation/hwmon - fix

RE: [lm-sensors] [PATCH] hwmon: pwm-fan: Add pwm-fan driver

Hi, I forgot to address one of the comments. > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter > Roeck > Sent: Wednesday, July 09, 2014 6:58 PM > To: Kamil Debski > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; lm- > sens...@lm-sensors.org;

RE: [lm-sensors] [PATCH] hwmon: pwm-fan: Add pwm-fan driver

Hi, I forgot to address one of the comments. From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck Sent: Wednesday, July 09, 2014 6:58 PM To: Kamil Debski Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; lm- sens...@lm-sensors.org; t.f...@samsung.com

[PATCH v2] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski k.deb...@samsung.com --- Changes since v1: - added documentation

RE: [PATCH] hwmon: pwm-fan: Add pwm-fan driver

Hi Tobias, Thank you for your review. > From: Tobias Klauser [mailto:tklau...@distanz.ch] > Sent: Wednesday, July 09, 2014 7:50 PM > > On 2014-07-09 at 16:53:20 +0200, Kamil Debski > wrote: > > The pwm-fan driver enables control of fans connected to PWM lines. > &g

RE: [lm-sensors] [PATCH] hwmon: pwm-fan: Add pwm-fan driver

Hi Guenter, Thank you for your review. > From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter > Roeck > Sent: Wednesday, July 09, 2014 6:58 PM > > On Wed, Jul 09, 2014 at 04:53:20PM +0200, Kamil Debski wrote: > > The pwm-fan driver enables control of fans c

RE: [lm-sensors] [PATCH] hwmon: pwm-fan: Add pwm-fan driver

Hi Guenter, Thank you for your review. From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter Roeck Sent: Wednesday, July 09, 2014 6:58 PM On Wed, Jul 09, 2014 at 04:53:20PM +0200, Kamil Debski wrote: The pwm-fan driver enables control of fans connected to PWM lines

RE: [PATCH] hwmon: pwm-fan: Add pwm-fan driver

Hi Tobias, Thank you for your review. From: Tobias Klauser [mailto:tklau...@distanz.ch] Sent: Wednesday, July 09, 2014 7:50 PM On 2014-07-09 at 16:53:20 +0200, Kamil Debski k.deb...@samsung.com wrote: The pwm-fan driver enables control of fans connected to PWM lines. This driver uses

[PATCH] hwmon: gpio-fan: Change name passed to hwmon_device_register_with_groups

Commit 648cd48c9e566f53c5df30d79857e0937ae13b09 (hwmon: Do not accept invalid name attributes) added check for "-" in the name of hwmon device. This patch changes the name supplied by gpio-fan so that it is accepted by hwmon. Signed-off-by: Kamil Debski --- drivers/hwmon/gpio-fan.c |

[PATCH] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski --- .../devicetree/bindings/hwmon/pwm-fan.txt | 12 ++ drivers

[PATCH] hwmon: pwm-fan: Add pwm-fan driver

The pwm-fan driver enables control of fans connected to PWM lines. This driver uses the PWM framework, so it is compatible with all PWM devices that provide drivers through the PWM framework. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/hwmon/pwm-fan.txt

[PATCH] hwmon: gpio-fan: Change name passed to hwmon_device_register_with_groups

Commit 648cd48c9e566f53c5df30d79857e0937ae13b09 (hwmon: Do not accept invalid name attributes) added check for - in the name of hwmon device. This patch changes the name supplied by gpio-fan so that it is accepted by hwmon. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/hwmon/gpio

[PATCH v2] phy: phy-samsung-usb2: Change phy power on/power off sequence

The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits have different function. This patch fixes the defines of register bits and changes the way how phys are powered on and off. Signed-off-by: Kamil Debski --- drivers/phy/phy

[PATCH v2] phy: phy-samsung-usb2: Change phy power on/power off sequence

The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits have different function. This patch fixes the defines of register bits and changes the way how phys are powered on and off. Signed-off-by: Kamil Debski k.deb...@samsung.com

RE: [PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence

Hi Daniel, > From: Daniel Drake [mailto:dr...@endlessm.com] > Sent: Tuesday, June 24, 2014 5:09 PM > > On Tue, Jun 24, 2014 at 1:54 PM, Kamil Debski > wrote: > > The Exynos4412 USB 2.0 PHY hardware differs from the description > > provided in the documentation. Some r

[PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence

The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits have different function. This patch fixes the defines of register bits and changes the way how phys are powered on and off. Signed-off-by: Kamil Debski --- drivers/phy/phy

[PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence

The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits have different function. This patch fixes the defines of register bits and changes the way how phys are powered on and off. Signed-off-by: Kamil Debski k.deb...@samsung.com

RE: [PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence

Hi Daniel, From: Daniel Drake [mailto:dr...@endlessm.com] Sent: Tuesday, June 24, 2014 5:09 PM On Tue, Jun 24, 2014 at 1:54 PM, Kamil Debski k.deb...@samsung.com wrote: The Exynos4412 USB 2.0 PHY hardware differs from the description provided in the documentation. Some register bits

RE: [PATCH] phy: exynos: fix building as a module

nd spotting this error. Acked-by: Kamil Debski Best wishes, -- Kamil Debski Samsung R Institute Poland > > Signed-off-by: Arnd Bergmann > > diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index > 2faf78e..7728518 100644 > --- a/drivers/phy/Makefile >

RE: [PATCH] phy: exynos: fix building as a module

Debski k.deb...@samsung.com Best wishes, -- Kamil Debski Samsung RD Institute Poland Signed-off-by: Arnd Bergmann a...@arndb.de diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index 2faf78e..7728518 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -13,8 +13,9 @@ obj

[PATCH v10 3/4] phy: Add new Exynos USB 2.0 PHY driver

Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation/phy/samsung-usb2.txt

[PATCH v10 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v10 2/4] phy: core: Add devm_of_phy_get to phy-core

Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v10 1/4] phy: core: Add an exported of_phy_get function

was added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

[PATCH v10 0/4] phy: Add new Exynos USB 2.0 PHY driver

Hi, This is the tenth version of this patchset. The only difference since v9 is correction in the documentation. Best wishes, Kamil Debski -- Changes from v9: 1) phy: core: Add an exported of_phy_get function - No changes since v9. 2) phy: core: Add devm_of_phy_get to phy-core

RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

-usb2.c > > @@ -0,0 +1,222 @@ > > +/* > > + * Samsung SoC USB 1.1/2.0 PHY driver > > + * > > + * Copyright (C) 2013 Samsung Electronics Co., Ltd. > > + * Author: Kamil Debski > > + * > > + * This program is free software; you can redistribute it and/or &g

RE: [PATCH v9 0/4] phy: Add new Exynos USB 2.0 PHY driver

onsider adding a "Tested-by" tag? I am planning to send v10 soon, which will address comments to v9. > > With best wishes, > Tobias Best wishes, -- Kamil Debski Samsung R Institute Poland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

RE: [PATCH v9 0/4] phy: Add new Exynos USB 2.0 PHY driver

planning to send v10 soon, which will address comments to v9. With best wishes, Tobias Best wishes, -- Kamil Debski Samsung RD Institute Poland -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: [PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

.c new file mode 100644 index 000..c3b7719 --- /dev/null +++ b/drivers/phy/phy-samsung-usb2.c @@ -0,0 +1,222 @@ +/* + * Samsung SoC USB 1.1/2.0 PHY driver + * + * Copyright (C) 2013 Samsung Electronics Co., Ltd. + * Author: Kamil Debski k.deb...@samsung.com

[PATCH v10 0/4] phy: Add new Exynos USB 2.0 PHY driver

Hi, This is the tenth version of this patchset. The only difference since v9 is correction in the documentation. Best wishes, Kamil Debski -- Changes from v9: 1) phy: core: Add an exported of_phy_get function - No changes since v9. 2) phy: core: Add devm_of_phy_get to phy-core

[PATCH v10 1/4] phy: core: Add an exported of_phy_get function

was added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9

[PATCH v10 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile

[PATCH v10 2/4] phy: core: Add devm_of_phy_get to phy-core

Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed

[PATCH v10 3/4] phy: Add new Exynos USB 2.0 PHY driver

Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation

[PATCH v9 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v9 2/4] phy: core: Add devm_of_phy_get to phy-core

Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation/phy/samsung-usb2.txt

[PATCH v9 0/4] phy: Add new Exynos USB 2.0 PHY driver

more testing. Since v7 this patch includes fixes for checkpath errors and was rebased onto Kishon's next branch. v9 brings whitespace corrections compared to v8. Best wishes, Kamil Debski -- Changes from v8: 1) phy: core: Add an exported of_phy_get function - No changes since v8. 2

[PATCH v9 1/4] phy: core: Add an exported of_phy_get function

was added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

[PATCH v8 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile |1

[PATCH v8 3/4] phy: Add new Exynos USB 2.0 PHY driver

Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation/phy/samsung-usb2.txt

[PATCH v8 2/4] phy: core: Add devm_of_phy_get to phy-core

Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed, 39 insertions

[PATCH v8 1/4] phy: core: Add an exported of_phy_get function

was added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9 deletions(-) diff

[PATCH v8 0/4] phy: Add new Exynos USB 2.0 PHY driver

more testing. Since v7 this patch includes fixes for checkpath errors and was rebased onto Kishon's next branch. Best wishes, Kamil Debski -- Changes from v7: 1) phy: core: Add an exported of_phy_get function - No changes since v7. 2) phy: core: Add devm_of_phy_get to phy-core

RE: [PATCH v7 3/4] phy: Add new Exynos USB 2.0 PHY driver

Hi Sander, > From: Kamil Debski [mailto:k.deb...@samsung.com] > Sent: Tuesday, March 04, 2014 4:24 PM > > Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the > generic PHY framework. The driver includes support for the Exynos 4210 > and 4x12 SoC familie

RE: [PATCH v7 3/4] phy: Add new Exynos USB 2.0 PHY driver

Hi Sander, From: Kamil Debski [mailto:k.deb...@samsung.com] Sent: Tuesday, March 04, 2014 4:24 PM Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4210 and 4x12 SoC families. Signed-off-by: Kamil

[PATCH v8 0/4] phy: Add new Exynos USB 2.0 PHY driver

more testing. Since v7 this patch includes fixes for checkpath errors and was rebased onto Kishon's next branch. Best wishes, Kamil Debski -- Changes from v7: 1) phy: core: Add an exported of_phy_get function - No changes since v7. 2) phy: core: Add devm_of_phy_get to phy-core

[PATCH v8 1/4] phy: core: Add an exported of_phy_get function

was added and it was exported. The function enables to get a phy for a given device tree node. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 45 - include/linux/phy/phy.h |6 ++ 2 files changed, 42 insertions(+), 9

[PATCH v8 2/4] phy: core: Add devm_of_phy_get to phy-core

Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed

[PATCH v8 3/4] phy: Add new Exynos USB 2.0 PHY driver

Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation

[PATCH v8 4/4] phy: Add Exynos 5250 support to the Exynos USB 2.0 PHY driver

Add support for Exynos 5250. This driver is to replace the old USB 2.0 PHY driver. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt|1 + drivers/phy/Kconfig| 11 + drivers/phy/Makefile

[PATCH v9 3/4] phy: Add new Exynos USB 2.0 PHY driver

Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the generic PHY framework. The driver includes support for the Exynos 4x10 and 4x12 SoC families. Signed-off-by: Kamil Debski k.deb...@samsung.com --- .../devicetree/bindings/phy/samsung-phy.txt| 53 Documentation

[PATCH v9 0/4] phy: Add new Exynos USB 2.0 PHY driver

more testing. Since v7 this patch includes fixes for checkpath errors and was rebased onto Kishon's next branch. v9 brings whitespace corrections compared to v8. Best wishes, Kamil Debski -- Changes from v8: 1) phy: core: Add an exported of_phy_get function - No changes since v8. 2

[PATCH v9 2/4] phy: core: Add devm_of_phy_get to phy-core

Adding devm_of_phy_get will allow to get phys by supplying a pointer to the struct device_node instead of struct device. Signed-off-by: Kamil Debski k.deb...@samsung.com --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |8 2 files changed

  1   2   3   >