[PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

hidpp20_adc_map_status_voltage to avoid using `long` type - added bit flag definitions in hidpp20_adc_map_status_voltage Signed-off-by: Kamil Domański --- drivers/hid/hid-logitech-hidpp.c | 197 ++- 1 file changed, 196 insertions(+), 1 deletion(-) diff --git a

[PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

hidpp20_adc_map_status_voltage to avoid using `long` type - added bit flag definitions in hidpp20_adc_map_status_voltage Signed-off-by: Kamil Domański --- drivers/hid/hid-logitech-hidpp.c | 197 ++- 1 file changed, 196 insertions(+), 1 deletion(-) diff --git a

Re: [PATCH v2] HID: logitech-hidpp: add support for Logitech G533 headset

Hi Filipe, >> +bool isConnected; >> +bool isCharging; >> +bool chargingComplete; >> +bool chargingFault; > > From my initial comments: > >> We use snake case. Will be fixed in v3. >> + >> +long flags = (long) data[2]; > >> Use u8 instead. Why are we even using a variable f

Re: [PATCH] HID: logitech-hidpp: add support for Logitech G533 headset

On Sun, 2020-05-17 at 16:52 +0100, Filipe Laíns wrote: > On Sun, 2020-04-26 at 17:18 +0200, Kamil Domański wrote: > > *snip* > > > +/* > > -- > > */ > > +/* 0x1F20: