Re: [PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend

2019-03-19 Thread Karoly Pados
>> On Di, 2019-03-19 at 11:36 +0100, Johan Hovold wrote: >> On Mon, Feb 18, 2019 at 10:17:12AM +0100, Oliver Neukum wrote: >>> On So, 2019-02-17 at 18:59 +0100, Karoly Pados wrote: >>>> Current GPIO code in cp210x fails to take USB autosuspend into account, >>

[PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend

2019-02-17 Thread Karoly Pados
Current GPIO code in cp210x fails to take USB autosuspend into account, making it practically impossible to use GPIOs with autosuspend enabled without user configuration. Fix this like for ftdi_sio in a previous patch. Tested on a CP2102N. Signed-off-by: Karoly Pados --- Changelog: - v2

Re: [PATCH] USB: serial: cp210x: Fix GPIO in autosuspend

2019-02-06 Thread Karoly Pados
;ll submit something by the weekend when I'm home again. Karoly February 4, 2019 5:09 PM, "Johan Hovold" wrote: > On Tue, Jan 15, 2019 at 11:29:42AM +0100, Johan Hovold wrote: > >> On Tue, Jan 15, 2019 at 10:26:07AM +0100, Johan Hovold wrote: >> On Tue, Jan

Re: [PATCH] USB: serial: cp210x: Fix GPIO in autosuspend

2019-01-15 Thread Karoly Pados
> I think it's better to add the autopm call to gpio210x_gpio_get/set > only. This will allow for a simpler patch, and keeps the autopm handling > confined to the gpio paths. I'll submit a v2. >> @@ -1383,6 +1397,7 @@ static void cp210x_gpio_set(struct gpio_chip *gc, >> unsigned int gpio, int >>

[PATCH] USB: serial: cp210x: Fix GPIO in autosuspend

2019-01-14 Thread Karoly Pados
Current GPIO code in cp210x fails to take USB autosuspend into account, making it practically impossible to use GPIOs with autosuspend enabled without user configuration. Fix this like for ftdi_sio in a previous patch. Tested on a CP2102N. Signed-off-by: Karoly Pados --- drivers/usb/serial

[PATCH] USB: serial: ftdi_sio: Fix GPIO not working in autosuspend

2019-01-14 Thread Karoly Pados
use the GPIOs on machines that have USB autosuspend enabled. This patch fixes the issue by acquiring a PM lock on the device for the duration of the USB transfers. Tested on an FT231X device. Signed-off-by: Karoly Pados --- Please consider backporting to 4.20.x, otherwise the GPIO driver is not

Re: [PATCH v5] USB: serial: ftdi_sio: implement GPIO support for FT-X devices

2018-09-24 Thread Karoly Pados
Oops, I sent v4 again, so it had no changes at all. Can't I just resend v5 instead of calling it v6? September 24, 2018 10:48 AM, "Johan Hovold" wrote: > On Sun, Sep 23, 2018 at 06:03:30PM +0200, Karoly Pados wrote: > >> This patch allows using the CBUS pins of F

Re: [PATCH v4] USB: serial: ftdi_sio: implement GPIO support for FT-X devices

2018-09-18 Thread Karoly Pados
>> + goto out_free; >> + >> + /* Chip-type guessing logic based on libftdi. */ >> + priv->gc.ngpio = 4; /* FT230X, FT231X */ >> + if (le16_to_cpu(serial->dev->descriptor.bcdDevice) != 0x1000) >> + priv->gc.ngpio = 1; /* FT234XD */ > > As I mentioned in my last mail: I've asked FTDI about this, but

Re: [PATCH v2] USB: serial: cp210x: Implement GPIO support for CP2102N

2018-07-20 Thread Karoly Pados
16 PM, "Johan Hovold" wrote: > On Wed, Jul 18, 2018 at 09:38:12PM +, Karoly Pados wrote: > >> Hello Johan, >> >> I hope maybe after you come back from your vacation you can still >> merge this into 4.19, I guess the merge window will still be open. >

[PATCH v4] USB: serial: cp210x: Implement GPIO support for CP2102N

2018-07-20 Thread Karoly Pados
until somebody clears this up further. Signed-off-by: Karoly Pados --- Patch changelog: v1: Initial implementation. v2: Incorporate Johan's feedback, most importantly generalize new code and unify with CP2105. v3 (by Johan): Apply stylistic and minor bug fixes. v4: Corrected commit messag