[PATCH] staging: comedi: ni_pcimio: remove unused variable 'serial_number'

2017-02-09 Thread Karthik Nayak
ning: incorrect type in assignment (different base types) drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:expected restricted __be32 [usertype] serial_number drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:got unsigned int Signed-off-by: Karthik Nayak --- drivers/staging/comedi

Re: [PATCH] staging: comedi: Fix incorrect type assignment

2017-02-09 Thread Karthik Nayak
Hello, On Thu, Feb 9, 2017 at 4:34 PM, Greg KH wrote: > On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote: >> This patch fixes the following sparse error: >> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect type >> in assignment

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

2017-02-08 Thread Karthik Nayak
atch, thanks :) > Sorry for the multiple messages, now that we're deleting the whole block, I think it makes sense to squash the commits, so I'll send one single patch. -- Regards, Karthik Nayak

[PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Karthik Nayak
/drivers//ni_pcimio.c:1229:32:got unsigned int This is done by removing the whole code block, since the variable 'serial_number' is only assigned but never used. Helped-by: Ian Abbott Signed-off-by: Karthik Nayak --- drivers/staging/comedi/drivers/ni_pcimio.c | 9 - drivers/stag

Re: [PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

2017-02-08 Thread Karthik Nayak
Hey, On Wed, Feb 8, 2017 at 11:10 PM, Ian Abbott wrote: > On 08/02/2017 16:55, Karthik Nayak wrote: >> >> Drop the 'serial_number' variable from the struct 'ni_private' since >> its never used after assignment. >> >> Signed-off-by: Kart

[PATCH 2/2] staging: comedi: drop unused variable from struct 'ni_private'

2017-02-08 Thread Karthik Nayak
Drop the 'serial_number' variable from the struct 'ni_private' since its never used after assignment. Signed-off-by: Karthik Nayak --- This is to be based on top of "staging: comedi: Fix incorrect type assignment" to which this is replied to. drivers/staging/

Re: [PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Karthik Nayak
Hi, On Wed, Feb 8, 2017 at 7:18 PM, Ian Abbott wrote: > On 08/02/17 13:26, Karthik Nayak wrote: >> >> Hello, >> >> On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott wrote: >>> >>> On 07/02/17 19:06, Karthik Nayak wrote: >>>> >>>> &

Re: [PATCH] staging: comedi: Fix incorrect type assignment

2017-02-08 Thread Karthik Nayak
Hello, On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott wrote: > On 07/02/17 19:06, Karthik Nayak wrote: >> >> This patch fixes the following sparse error: >> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect >> type in assignment (different base types

[PATCH] staging: comedi: Fix incorrect type assignment

2017-02-07 Thread Karthik Nayak
/drivers//ni_pcimio.c:1229:32:got unsigned int This is done by introducing a temporary variable which is of type '__be32' and converting the existing variable to type 'unsigned int'. Signed-off-by: Karthik Nayak --- drivers/staging/comedi/drivers/ni_pcimio.c | 5 +++-- dr

[PATCH] staging: lustre: selftest: Make brw_inject_one_error() static

2016-12-23 Thread Karthik Nayak
Since the function brw_inject_one_error() is used only within brw_test.c, make it static. This was reported as a warning by sparse. Signed-off-by: Karthik Nayak --- drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH] Staging: rtl8192u: removed an unnecessary else statement

2014-12-18 Thread karthik nayak
On 12/19/2014 04:08 AM, Jeremiah Mahler wrote: Karthik, On Thu, Dec 18, 2014 at 02:50:11PM +0530, Karthik Nayak wrote: As per checkpatch warning, removed an unnecessary else statement proceeding an if statement with a return. Signed-off-by: Karthik Nayak --- drivers/staging/rtl8192u

[PATCH] staging: gdm724x: remove prohibited space before the comma

2014-12-18 Thread Karthik Nayak
Remove checkpatch error of prohibited space before the comma. Signed-off-by: Karthik Nayak --- drivers/staging/gdm724x/gdm_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index b5b063a..d1ab996

[PATCH] Staging: rtl8192u: removed an unnecessary else statement

2014-12-18 Thread Karthik Nayak
As per checkpatch warning, removed an unnecessary else statement proceeding an if statement with a return. Signed-off-by: Karthik Nayak --- drivers/staging/rtl8192u/r8192U_dm.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u

[PATCH] Staging: rtl8712: removed an unnecessary else statement

2014-12-15 Thread Karthik Nayak
As per checkpatch warning, removed an unnecessary else statement proceeding an if statement with a return. Signed-off-by: Karthik Nayak --- drivers/staging/rtl8712/rtl8712_recv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b

[PATCH] staging: bcm: remove unnecessary else statement

2014-09-30 Thread Karthik Nayak
Removed the else statement occurring after an if statement with a return value as per checkpatch warning. Signed-off-by: Karthik Nayak --- drivers/staging/bcm/InterfaceMisc.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/bcm/InterfaceMisc.c b

[PATCH] staging: et131x: remove unneccessary 'out of memory' message

2014-09-30 Thread Karthik Nayak
Removes the 'out of memory' warning issued by checkpatch Signed-off-by: Karthik Nayak --- drivers/staging/et131x/et131x.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 41fcaa0..f92cceb 10

Re: [PATCH] staging: et131x: remove unneccessary 'out of memory' message

2014-09-30 Thread karthik nayak
Oops, i sent the old commit again, sorry! Regards, Karthik Nayak On Tue, Sep 30, 2014 at 11:10 PM, Fabio Estevam wrote: > On Tue, Sep 30, 2014 at 2:19 PM, Karthik Nayak wrote: >> Removes the 'out of memory' warning issues by checkpatch >> >> Signed-off-by: Ka

[PATCH] staging: bcm: multiple checkpatch fixes for InterfaceIdleMode.c

2014-09-30 Thread Karthik Nayak
1. WARNING: else is not generally useful after a break or return 2. WARNING: quoted string split across lines 3. WARNING: break quoted strings at a space character Signed-off-by: Karthik Nayak --- drivers/staging/bcm/InterfaceIdleMode.c | 11 +-- 1 file changed, 5 insertions(+), 6

[PATCH] staging: et131x: remove unneccessary 'out of memory' message

2014-09-30 Thread Karthik Nayak
Removes the 'out of memory' warning issues by checkpatch Signed-off-by: Karthik Nayak --- drivers/staging/et131x/et131x.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 41fcaa0..f1a9296 100644 --- a/drive