On Fri, May 24, 2013 at 9:37 AM, Konrad Rzeszutek Wilk
wrote:
> On Wed, May 22, 2013 at 05:12:24PM -0500, Kent Yoder wrote:
>> On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk
>> wrote:
>> > On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote:
>> >&g
On Wed, May 22, 2013 at 3:57 PM, Konrad Rzeszutek Wilk
wrote:
> On Wed, May 22, 2013 at 02:47:01PM -0500, Kent Yoder wrote:
>> >> + notify_remote_via_evtchn(priv->evtchn);
>> >> +
>> >> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
>> &
>> + notify_remote_via_evtchn(priv->evtchn);
>> +
>> + ordinal = be32_to_cpu(*((__be32 *) (buf + 6)));
>
> Um, + 6? Why? Is there an #define for that magic constant?
> Should this value be read before you do the wait_for_tpm_stat stuff?
This is hardcoded to 6 even in tpm.c. Time for a #
Signed-off-by: Kent Yoder
---
v2: Replace Kent with other so that NX isn't unmaintained,
leave tpmdd-devel as maintainer for TPM
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 829c032..5ec293d 100644
--- a/MAINTA
On Wed, May 22, 2013 at 09:37:20AM -0700, Joe Perches wrote:
> On Wed, 2013-05-22 at 10:56 -0500, Kent Yoder wrote:
>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -3971,7 +3971,8 @@ S:Maintained
> > F: arch/ia64/
> >
> > IBM Power in-Nest
Signed-off-by: Kent Yoder
---
MAINTAINERS | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 829c032..592af73 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3971,7 +3971,8 @@ S:Maintained
F: arch/ia64/
IBM Power in-Nest
Hi James,
The following changes since commit 4726e8fa1dcad533362475ebf91f70d5b6b6292f:
security: clarify cap_inode_getsecctx description (2013-05-12 21:32:38 +1000)
are available in the git repository at:
git://github.com/shpedoikal/linux.git tpmdd-05-21-13
for you to fetch changes up to 1
with
some instructions, here: http://smatch.sourceforge.net/.
Kent
> However, these warning will be corrected in the next patch and the others too.
>
> Regards,
>
> Mathias Leblanc
>
> -----Original Message-
> From: Kent Yoder [mailto:shpedoi...@gmail.com]
> Sent: 10
On Fri, May 10, 2013 at 8:38 AM, Kent Yoder wrote:
> Hi Mathias,
Sorry, this note got sent before I was done somehow...
A few compile warnings left:
drivers/char/tpm/tpm_spi_stm_st33.c: In function ‘tpm_stm_spi_status’:
drivers/char/tpm/tpm_spi_stm_st33.c:289:2: error: ‘data’ is u
Thanks!
Kent
On Mon, May 6, 2013 at 4:53 PM, Benjamin Herrenschmidt
wrote:
> On Mon, 2013-05-06 at 14:24 -0500, Kent Yoder wrote:
>> Hi Ben, just a friendly reminder to please apply.
>
> Oh, I assumed that stuff was going via some drivers/crypto maintainer...
>
> I can app
Hi Ben, just a friendly reminder to please apply.
Thanks,
Kent
On Fri, Apr 12, 2013 at 12:13:59PM -0500, Kent Yoder wrote:
> Fixes a race on driver init with registering algorithms where the
> driver status flag wasn't being set before self testing started.
>
> Added the cr
Hi Mathias,
On Mon, May 06, 2013 at 01:14:44PM +0200, Matthias Leblanc wrote:
> From: Mathias Leblanc
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * und
On Thu, May 02, 2013 at 07:39:50PM +0800, Libo Chen wrote:
>
> Add missing unregister tis_drv after register pdev fail
>
> Signed-off-by: Libo Chen
Hi Libo - thanks for the contribution, but I got an similar patch
last week from Wei Yongjun. Its staged over here [1] and will be pushed
soon.
On Sun, Apr 28, 2013 at 03:16:33AM +0200, Peter Hüwe wrote:
> Hi Matthias,
>
> it's nice to see that you consider most of the comments, unfortunately I
> still
> have some left ;)
>
> > +/*
> > + * tpm_st33_spi_init initialize driver
> > + * @return: 0 if successful, else non zero value.
> > +
Kent
> Regards,
>
> Mathias
>
> -Original Message-
> From: Kent Yoder [mailto:shpedoi...@gmail.com]
> Sent: 22 April, 2013 20:31
> To: Mathias LEBLANC
> Cc: Kent Yoder; Rajiv Andrade; Marcel Selhorst; Sirrix AG;
> tpmdd-de...@lists.sourceforge.net; Je
On Thu, Apr 25, 2013 at 03:07:47PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Add the missing platform_driver_unregister() before return
> from init_tis() in the device register error handling case.
>
> Signed-off-by: Wei Yongjun
Applied and staged here, thanks!
git://github.com/sh
On Tue, Apr 23, 2013 at 10:03 AM, wrote:
> 2013-04-23 16:43 skrev Kent Yoder:
>
>> On Tue, Apr 23, 2013 at 04:30:53PM +0200, peteraspl...@gentoo.se wrote:
>>>
>>> 2013-04-11 23:41 skrev Kent Yoder:
>>> >On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl
On Tue, Apr 23, 2013 at 04:30:53PM +0200, peteraspl...@gentoo.se wrote:
> 2013-04-11 23:41 skrev Kent Yoder:
> >On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl...@gentoo.se
> >wrote:
> >>2013-04-02 16:03 skrev Kent Yoder:
> >>>Hi Peter,
> >>&
You're under the tpm_mutex, so I think you're
safe from other TPM writes, but what about other devices on the bus?
Can they contend for the read/write?
Kent
> Regards,
>
> Mathias Leblanc
>
> -Original Message-
> From: Kent Yoder [mailto:shpedoi...@gmail.com]
On Mon, Apr 22, 2013 at 06:20:17PM +0200, Matthias Leblanc wrote:
> From: Mathias Leblanc
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain co
On Mon, Apr 22, 2013 at 10:50:06AM +0200, Mathias Leblanc wrote:
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> This is the dr
Hi Daniel - this looks good, only one minor comment below...
On Thu, Apr 11, 2013 at 10:56:01AM -0400, Daniel De Graaf wrote:
> This is a complete rewrite of the Xen TPM frontend driver, taking
> advantage of a simplified frontend/backend interface and adding support
> for cancellation and timeout
Hi James,
The following changes since commit 958d2c2f4ad905e3ffa1711d19184d21d9b00cc1:
Smack: include magic.h in smackfs.c (2013-04-03 13:13:51 +1100)
are available in the git repository at:
git://github.com/shpedoikal/linux.git tpmdd-04-17-13
for you to fetch changes up to 32d33b29ba077d6
Hi Matthias,
On Fri, Apr 12, 2013 at 10:44:11AM +0200, Matthias Leblanc wrote:
> From: Mathias Leblanc
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * un
On Tue, Apr 16, 2013 at 6:57 PM, Greg KH wrote:
> On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote:
>> Hi Duncan,
>>
>> On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote:
>> > If the TPM has already been sent a SaveState command before the driver
>&
error for number of bytes processed in the sha code.
Signed-off-by: Kent Yoder
---
Patch v3, was: drivers/crypto/nx: fix init race, alignmasks and GCM bug
Applied to:
git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git#next
drivers/crypto/nx/nx-aes-cbc.c | 1 +
drivers/crypto/nx/n
On Sat, Apr 06, 2013 at 06:00:59PM +0200, peteraspl...@gentoo.se wrote:
> 2013-04-02 16:03 skrev Kent Yoder:
> >Hi Peter,
> >
> >On Mon, Apr 1, 2013 at 4:17 PM, wrote:
> >>2013-03-28 14:12 skrev peter.hu...@infineon.com:
> >>>What also might be
No problem, turns out I had a few more updates I needed to sneak into
the patch anyway. Please see v3 in a new thread, applied to the
ppc-dev-next tree.
Thanks,
Kent
On Thu, Mar 28, 2013 at 1:24 PM, Benjamin Herrenschmidt
wrote:
> On Thu, 2013-03-28 at 11:32 -0500, Kent Yoder wrote:
>&g
Hi Peter,
On Mon, Apr 1, 2013 at 4:17 PM, wrote:
> 2013-03-28 14:12 skrev peter.hu...@infineon.com:
>> What also might be worth a look - in your bugzilla it states:
>> [ 0.225891] pnp 00:0a: Plug and Play ACPI device, IDs IFX0102 PNP0c31
>> (active)
>> [ 9.150673] tpm_tis 00:0a: 1.2 TPM (device-
Hi Ben, will you carry this patch in the linuxppc-dev tree?
Thanks,
Kent
-- Forwarded message --
From: Kent Yoder
Date: Wed, Mar 20, 2013 at 9:22 AM
Subject: [PATCH v2] drivers/crypto/nx: fix init race, alignmasks and GCM bug
To: linux-kernel@vger.kernel.org
Cc: linux-cry
On Mon, Mar 25, 2013 at 10:08 AM, Matthias Leblanc
wrote:
> From: admin01
>
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> Th
Fixes a race on driver init with registering algorithms where the
driver status flag wasn't being set before self testing started.
Added the cra_alignmask field for CBC and ECB modes.
Fixed a bug in GCM where AES block size was being used instead of
authsize.
Signed-off-by: Kent
Hi Duncan,
On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote:
> If the TPM has already been sent a SaveState command before the driver
> is loaded it may have problems sending that same command again later.
>
> This issue is seen with the Chromebook Pixel due to a firmware bug in
> the legacy
On Mon, Mar 11, 2013 at 9:20 AM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Remove duplicated include.
HI Wei, thanks for the patch. I've already staged the same patch for
inclusion in the next pull request for TPM drivers here:
https://github.com/shpedoikal/linux/commit/6c09a9f5fcb3955afbae2e
On Thu, Feb 28, 2013 at 4:06 AM, Jean Delvare wrote:
> From: Shubhrajyoti Datta
>
> Convert the struct i2c_msg initialization to C99 format. This makes
> maintaining and editing the code simpler. Also helps once other fields
> like transferred are added in future.
>
> Thanks to Julia Lawall for a
On Mon, Mar 4, 2013 at 2:08 PM, Kent Yoder wrote:
>>> >
>>> > +
>>> > +#ifdef CONFIG_OF
>>> > +static const struct of_device_id tpm_tis_i2c_of_match[] = {
>>> > + { .compatible = "infineon,tpm_i2c_infineon", .data = (void *)
>> >
>> > +
>> > +#ifdef CONFIG_OF
>> > +static const struct of_device_id tpm_tis_i2c_of_match[] = {
>> > + { .compatible = "infineon,tpm_i2c_infineon", .data = (void *)0 },
>> > + { .compatible = "infineon,slb9635tt", .data = (void *)0 },
>> > + { .compatible = "infineon,slb9645tt", .data =
Fixes a race on driver init with registering algorithms where the
driver status flag wasn't being set before self testing started.
Added the cra_alignmask field for CBC and ECB modes.
Fixed a bug in GCM where AES block size was being used instead of
authsize.
Signed-off-by: Kent
On Thu, Feb 28, 2013 at 4:32 PM, Jean Delvare wrote:
> On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote:
>> thanks for resending.
>
> You're welcome.
>
>> Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare:
>> > From: Shubhrajyoti Datta
>> >
>> > Convert the struct i2c_msg initial
On Tue, Feb 26, 2013 at 4:21 AM, Matthew Garrett wrote:
> On Tue, Feb 26, 2013 at 02:07:22AM -0800, Raymond Jennings wrote:
>> Just curious here, but is this as much of an issue if a user is
>> somehow able to take ownership of his own machine?
>
> No, if you're doing your own key management then
On Mon, Jan 28, 2013 at 8:11 AM, Kent Yoder wrote:
> On Fri, Jan 25, 2013 at 01:25:38PM -0700, Jason Gunthorpe wrote:
>> On Tue, Jan 22, 2013 at 05:29:23PM -0600, Kent Yoder wrote:
>> > Hi Jason,
>> >
>> > On Wed, Nov 21, 2012 at 3:15 PM, Jason Gunthorpe
>&
Hi Jason,
On Wed, Nov 21, 2012 at 3:15 PM, Jason Gunthorpe
wrote:
> We've been testing an alternative TPM for our embedded products and
> found random kernel boot failures due to time outs after the continue
> self test command.
>
> This was happening randomly, and has been *very* hard to track d
On Wed, Jan 9, 2013 at 1:41 PM, Peter Hüwe wrote:
> In my opinion a driver should never ever oops, even if the user does something
> stupid (e.g. like probing from userspace ;)
Exactly... I've coded up a fix for the oops and staged it here, please test:
https://github.com/shpedoikal/linux.git
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote:
> This patch converts the suspend and resume functions for
> tpm_i2c_stm_st33 to the new dev_pm_ops.
>
> Signed-off-by: Peter Huewe
One minor tweak, the PM funcs need to be inside CONFIG_PM_SLEEP to
avoid warnings when compiled witho
On Thu, Dec 06, 2012 at 01:20:51AM +0100, Peter Huewe wrote:
> This patch converts the suspend and resume functions for
> tpm_i2c_stm_st33 to the new dev_pm_ops.
Ignore my last mail. I'll take a look at this.
Thanks,
Kent
> Signed-off-by: Peter Huewe
> ---
> Note:
> I'm sending this patch on
On Thu, Dec 06, 2012 at 01:10:32AM +0100, Peter Hüwe wrote:
> Am Donnerstag, 6. Dezember 2012, 00:09:41 schrieb Kent Yoder:
> > >
> > > > static int tpm_st33_i2c_pm_suspend(struct i2c_client *client,
> > > > pm_message_t mesg)
> > > >
> > &g
On Wed, Dec 05, 2012 at 10:14:48PM +0100, Peter Hüwe wrote:
> Hi Kent, Matthias,
>
> Am Mittwoch, 5. Dezember 2012, 19:07:20 schrieb Kent Yoder:
> > Heh, duh, well of course it is. I've now staged everything I'm
> > planning on pushing at:
> >
> > git
On Wed, Dec 05, 2012 at 09:20:47PM +0100, Peter Hüwe wrote:
> Hi Kent,
> >
> > Heh, duh, well of course it is. I've now staged everything I'm
> > planning on pushing at:
> >
> > git://github.com/shpedoikal/linux.git tpmdd-12-05-12
> >
> > Please test and let me know if I missed anything.
> >
On Wed, Dec 05, 2012 at 11:45:27AM -0600, Kent Yoder wrote:
> On Wed, Dec 05, 2012 at 11:13:51AM -0600, Kent Yoder wrote:
> > On Wed, Dec 05, 2012 at 05:11:40PM +0100, Mathias LEBLANC wrote:
> > > Hi Peter,
> > >
> > > Thanks for your contribution.
> > &
On Wed, Dec 05, 2012 at 11:13:51AM -0600, Kent Yoder wrote:
> On Wed, Dec 05, 2012 at 05:11:40PM +0100, Mathias LEBLANC wrote:
> > Hi Peter,
> >
> > Thanks for your contribution.
> > I have modified the driver files name and descriptions.
> > Regarding the warnin
Peter Hüwe [mailto:peterhu...@gmx.de]
> Sent: 29 November, 2012 01:05
> To: Mathias LEBLANC
> Cc: Kent Yoder; Kent Yoder; Jean-Luc BLANC; linux-kernel@vger.kernel.org;
> Rajiv Andrade; tpmdd-de...@lists.sourceforge.net; sir...@jasper.es
> Subject: Re: [tpmdd-devel] [PATCH 1/1] TPM: ST
On Thu, Nov 29, 2012 at 01:54:52PM -0800, Joe Perches wrote:
> On Thu, 2012-11-29 at 22:08 +0100, Peter Huewe wrote:
> > Bool initializations should use true and false. Bool tests don't need
> > comparisons
> []
> > .v3 for this tiny patch... shame on me.
>
> Don't be silly...
>
> > diff --git a
On Thu, Nov 29, 2012 at 01:42:47AM +0100, Peter Huewe wrote:
> Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro:
> > On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote:
> > > - itpm = (probe == 0) ? 0 : 1;
> > > + itpm = (probe == 0) ? false : true;
> >
> > Charm
tpm_do_selftest function to get the tpm ready, but it
> can be removed
This looks like its base64 encoded...
> ____
> From: Kent Yoder [shpedoi...@gmail.com]
> Sent: 28 November 2012 16:31
> To: Mathias LEBLANC
> Cc: Kent Yoder; Jean-Luc BL
ot; branch.
Kent
> Matthias Leblanc
>
> ____From: Kent Yoder
> [shpedoi...@gmail.com]
> Sent: 27 November 2012 15:48
> To: Mathias LEBLANC
> Cc: Kent Yoder; Jean-Luc BLANC; linux-kernel@vger.kernel.org; Rajiv Andrade;
> tpmdd-de...@lists.sourceforge.net; Sirrix AG
> Subject
it.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git
Thanks,
Kent
> Regards,
>
> Matthias Leblanc
>
> From: Kent Yoder [k...@linux.vnet.ibm.com]
> Sent: 26 November 2012 18:46
> To: Mathias LEBLANC
> Cc: Rajiv Andrade; Marc
On Wed, Nov 21, 2012 at 11:50:24PM +0100, Peter Huewe wrote:
> Am Mittwoch, 21. November 2012, 21:56:45 schrieb Jason Gunthorpe:
> > This seems to be preferred these days.
> >
> > Signed-off-by: Jason Gunthorpe
>
> Looks good to me
> Reviewed-by: Peter Huewe
Applied. I also rolled in an update
On Wed, Nov 21, 2012 at 01:54:33PM -0700, Jason Gunthorpe wrote:
> The TPM will respond to TPM_GET_CAP with TPM_ERR_INVALID_POSTINIT if
> TPM_STARTUP has not been issued. Detect this and automatically
> issue TPM_STARTUP.
>
> This is for embedded applications where the kernel is the first thing
>
Hi Mathias,
On Mon, Nov 19, 2012 at 11:15:21PM +0100, Mathias Leblanc wrote:
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> T
ecurity-next tree. From there the code is pushed to Linus' tree.
Kent
> Thanks,
>
> Mathias Leblanc
>
> -----Original Message-
> From: Kent Yoder [mailto:k...@linux.vnet.ibm.com]
> Sent: 14 November, 2012 23:07
> To: Mathias LEBLANC
> Cc: Rajiv
On Fri, Nov 16, 2012 at 12:31:29AM +0100, Peter Huewe wrote:
> This patch changes the semantics of the duration calculation for an
> ordinal, by masking out the higher bits of a tpm command, which specify
> whether it's an TPM_PROTECTED_COMMAND, TPM_UNPROTECTED_COMMAND,
> TPM_CONNECTION_COMMAND, TP
On Thu, Nov 15, 2012 at 06:25:54PM +0100, Peter Huewe wrote:
> Shall I resend a v2?
Please do - thanks!
> Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
On Wed, Nov 14, 2012 at 11:37:06PM +0100, Peter Hüwe wrote:
> Am Mittwoch, 14. November 2012, 23:18:26 schrieb Kent Yoder:
> > On Mon, Nov 12, 2012 at 11:37:18PM +0100, Peter Huewe wrote:> >
> > > This patch also gets rid of the (false positive) sparse warning:
> >
On Mon, Nov 12, 2012 at 11:37:18PM +0100, Peter Huewe wrote:
> This patch changes the semantics of the duration calculation for an
> ordinal, by masking out the higher bits of a tpm command, which specify
> whether it's an TPM_PROTECTED_COMMAND, TPM_UNPROTECTED_COMMAND,
> TPM_CONNECTION_COMMAND, TP
On Mon, Nov 12, 2012 at 11:37:17PM +0100, Peter Huewe wrote:
> The entries in tpm_protected_ordinal_duration are exactly the same as
> the first 12 in tpm_ordinal_duration, so we can simply remove this one,
> and save some bytes.
>
> This does not change the behavior of the driver.
>
> Signed-off
Hi Mathias,
On Wed, Nov 14, 2012 at 03:31:42PM +0100, Mathias Leblanc wrote:
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> T
Reviewed-by: Peter Huewe
Signed-off-by: Kent Yoder
---
Documentation/ABI/stable/sysfs-class-tpm | 185 +++
1 file changed, 185 insertions(+)
create mode 100644 Documentation/ABI/stable/sysfs-class-tpm
diff --git a/Documentation/ABI/stable/sysfs-class-tpm
b
Hi Peter,
On Mon, Nov 12, 2012 at 08:47:55AM +, peter.hu...@infineon.com wrote:
> Hi Kent,
>
> thanks a lot for this effort!
> I really appreciate it.
>
> > +What: /sys/class/misc/tpmX/device/active
> > +Date: April 2006
> > +KernelVersion: 2.6.17
> > +Contact:
On Thu, Nov 8, 2012 at 9:36 AM, Fioravante, Matthew E.
wrote:
>> >>> On 07.11.12 at 19:14, Matthew Fioravante
>> >>> wrote:
>> > On 11/07/2012 09:46 AM, Kent Yoder wrote:
>> >>> --- a/drivers/char/tpm/tpm.h
>> >>> ++
Signed-off-by: Kent Yoder
---
Documentation/ABI/stable/sysfs-class-tpm | 182 +++
1 file changed, 182 insertions(+)
create mode 100644 Documentation/ABI/stable/sysfs-class-tpm
diff --git a/Documentation/ABI/stable/sysfs-class-tpm
b/Documentation/ABI/stable/sysfs
On Thu, Nov 08, 2012 at 08:17:32AM +, Jan Beulich wrote:
> >>> On 07.11.12 at 19:14, Matthew Fioravante
> >>> wrote:
> > On 11/07/2012 09:46 AM, Kent Yoder wrote:
> >>> --- a/drivers/char/tpm/tpm.h
> >>> +++ b/drivers/ch
the values of the starting steps below ...
> Access to these localities in the driver * Linux * has been given only for
> the purpose of validation.
Ok cool, so it can be removed? :-)
Kent
>
> From: Kent Yoder [k...@linux.vnet.ibm.com]
> Sent: 07 November 2012 16:
On Wed, Nov 07, 2012 at 01:15:09PM +0100, Mathias Leblanc wrote:
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> This is the dr
> >>+static struct attribute *vtpm_attrs[] = {
> >>+ &dev_attr_pubek.attr,
> >>+ &dev_attr_pcrs.attr,
> >>+ &dev_attr_enabled.attr,
> >>+ &dev_attr_active.attr,
> >>+ &dev_attr_owned.attr,
> >>+ &dev_attr_temp_deactivated.attr,
> >>+ &dev_attr_caps.attr,
> >>+ &dev_a
Hi Matthew,
On Mon, Nov 05, 2012 at 10:09:57AM -0500, Matthew Fioravante wrote:
> This patch ports the xen vtpm frontend driver for linux
> from the linux-2.6.18-xen.hg tree to linux-stable.
>
> Signed-off-by: Matthew Fioravante
> ---
> drivers/char/tpm/Kconfig |9 +
> drivers/char/
Hi James,
This time against security-next...
The following changes since commit 61d335dd27c67d656f114c091a46cf95cbeeb77c:
Merge branch 'security-next-keys' of
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/security-keys into
next-queue (2012-10-03 13:00:17 +1000)
are available in
On Thu, Nov 01, 2012 at 02:56:14AM +1100, James Morris wrote:
> On Tue, 30 Oct 2012, Kent Yoder wrote:
>
> > Hi James,
> >
> > Please pull as an update for 3.7.
> >
> > Thanks,
> > Kent
> >
> > The following changes since commit 8f0d8163
Hi Mathias,
On Tue, Oct 30, 2012 at 02:28:50PM +0100, Mathias Leblanc wrote:
> * STMicroelectronics version 1.2.0, Copyright (C) 2010
> * STMicroelectronics comes with ABSOLUTELY NO WARRANTY.
> * This is free software, and you are welcome to redistribute it
> * under certain conditions.
>
> T
Hi James,
Please pull as an update for 3.7.
Thanks,
Kent
The following changes since commit 8f0d8163b50e01f398b14bcd4dc039ac5ab18d64:
Linux 3.7-rc3 (2012-10-28 12:24:48 -0700)
are available in the git repository at:
git://github.com/shpedoikal/linux.git tpmdd-v3.7-rc3
for you to fetch c
> Using open/close is an interesting idea, but it wouldn't work. open()
> is coded to return EBUSY if another process has it open, rather than
> block, and spinning on open would be unacceptable.
I'm trying to imagine when spinning would be unacceptable? Keygen
could take several seconds, regard
Hi James,
The following changes since commit bf5308344527d015ac9a6d2bda4ad4d40fd7d943:
Merge tag 'v3.6-rc7' into next (2012-09-28 13:37:32 +1000)
are available in the git repository at:
git://github.com/shpedoikal/linux.git tpmdd-next-v3.6
for you to fetch changes up to abce9ac292e13da367
On Sun, Sep 30, 2012 at 05:33:45PM -0600, Jason Gunthorpe wrote:
> How to use the TPM is really a user space policy choice, if the
> environment wants to use middleware then fine, but it is possible to
> make correct TPM apps without using middleware.
I'm not sure how I feel about this. The sing
Hi Jason,
On Tue, Oct 02, 2012 at 03:04:53PM -0600, Jason Gunthorpe wrote:
> This provides an open firwmare driver binding for tpm_tis. OF
> is useful on arches where PNP is not used.
>
> Allow the tpm_tis driver to be selected if OF is compiled in.
>
> Signed-off-by: Jason Gunthorpe
> ---
> d
The following changes since commit ecefbd94b834fa32559d854646d777c56749ef1c:
Merge tag 'kvm-3.7-1' of git://git.kernel.org/pub/scm/virt/kvm/kvm
(2012-10-04 09:30:33 -0700)
are available in the git repository at:
git://github.com/shpedoikal/linux.git tpmdd-fixes-v3.6
for you to fetch chang
Hi James,
The following changes since commit ecefbd94b834fa32559d854646d777c56749ef1c:
Merge tag 'kvm-3.7-1' of git://git.kernel.org/pub/scm/virt/kvm/kvm
(2012-10-04 09:30:33 -0700)
are available in the git repository at:
git://github.com/shpedoikal/linux.git tpmdd-fixes-v3.6
for you to
Please ignore.
On Wed, Oct 10, 2012 at 10:06:53AM -0500, Kent Yoder wrote:
> The following changes since commit ecefbd94b834fa32559d854646d777c56749ef1c:
>
> Merge tag 'kvm-3.7-1' of git://git.kernel.org/pub/scm/virt/kvm/kvm
> (2012-10-04 09:30:33 -0700)
>
&
> > Hmm, tpm_add_ppi is just sysfs_create_group, which only ever returns
> > 0. Looks like we can remove this error path, but PPI is unusable in the
> > failure case.
>
> sysfs_create_group will return 0 on success or return error code. So I don't
> think we can remove this error path. The previ
Hi Jimmy,
On Tue, Oct 09, 2012 at 05:35:22PM +0800, gang@intel.com wrote:
> From: Gang Wei
>
> This patch try to fix the S3 regression https://lkml.org/lkml/2012/10/5/433,
> which includes below line:
> [ 1554.684638] sysfs: cannot create duplicate filename
> '/devices/pnp0/00:0c/ppi'
>
>
xpect the commit that added this failure mode is the commit below.
>
> Xiaoyan Zhang, Kent Yoder can you guys look at this see why the tpm
> code is adding itself multiple times into sysfs?
It looks like the ppi sysfs teardown code is MIA. Xiaoyan, can you add
it to tpm_ppi.c, with a ca
> Curiously the current code does call TPM_SaveState on suspend, but
> relies on the BIOS to do TPM_Startup(ST_STATE) on resume, why the
> asymmetry?
This is based on the PC Client Implementation for BIOS spec in the
TCG. On suspend, the OS is responsible for the save state and then on
resume th
On Mon, Oct 01, 2012 at 10:15:36AM -0600, Jason Gunthorpe wrote:
> On Mon, Oct 01, 2012 at 09:17:28AM +, peter.hu...@infineon.com wrote:
> > Hi Jason,
> >
> > > The TPM will respond to TPM_GET_CAP with TPM_ERR_INVALID_POSTINIT if
> > > TPM_STARTUP has not been issued. This will result in the T
> +/* irq == 0 -> autoprobe, -1 ->forced no interrupt,
> + others -> irq line to use */
> static int tpm_tis_init(struct device *dev, resource_size_t start,
> - resource_size_t len, unsigned int irq)
> + resource_size_t len, int irq)
> {
> u32 vendo
Hi Jason,
On Sun, Sep 30, 2012 at 05:30:12PM -0600, Jason Gunthorpe wrote:
> The TPM will respond to TPM_GET_CAP with TPM_ERR_INVALID_POSTINIT if
> TPM_STARTUP has not been issued. This will result in the TPM driver
> failing to load and no way to recover. Detect this and automatically
> issue TPM
> > James did accept my pull request, so these are already in
> > security-next...
>
> For the driver itself, it's not a big issue (though I did found issue
> while reviewing it so it will need another round of updates). For the
> code that changes arch/powerpc, especially prom_init.c, that stuf
On Wed, Sep 05, 2012 at 01:40:07PM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote:
> > On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote:
> > > This patch adds a new device driver to support IBM virtual TPM
> > > (vT
acpi_os_map_memory expects its return value to be in the __iomem address
space. Tag the variable we're using as such and use memcpy_fromio to
avoid further sparse warnings.
Signed-off-by: Kent Yoder
---
drivers/char/tpm/tpm_acpi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
On Sun, Sep 02, 2012 at 09:30:30AM -0700, Dan Carpenter wrote:
> Sparse finds that bug as well. ;)
>
> drivers/acpi/acpica/tbfadt.c:247:15: warning: incorrect type in assignment
> (different address spaces)
> drivers/acpi/acpica/tbfadt.c:247:15:expected struct acpi_table_header
> *table
> d
On Thu, Aug 30, 2012 at 10:45:56AM -0700, Dan Carpenter wrote:
> On Thu, Aug 30, 2012 at 09:38:41AM -0500, Kent Yoder wrote:
> > acpi_os_map_memory expects its return value to be in the __iomem address
> > space. Cast it back later when used in a memcpy to avoid the same sparse
&g
nt
Reviewed-by: Kent Yoder
>
> Signed-off-by: Xiaoyan Zhang
> Signed-off-by: Fengguang Wu
> ---
> drivers/char/tpm/tpm.c |4 ++--
> drivers/char/tpm/tpm_ppi.c | 37 +++--
> 2 files changed, 21 insertions(+), 20 deletions(-)
>
&
acpi_os_map_memory expects its return value to be in the __iomem address
space. Cast it back later when used in a memcpy to avoid the same sparse
warning there.
Signed-off-by: Kent Yoder
---
drivers/char/tpm/tpm_acpi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a
1 - 100 of 133 matches
Mail list logo
