Re: FW: Regulator API ignored return values

2013-03-11 Thread Kevin Liu
> -Original Message- > From: linux-mmc-ow...@vger.kernel.org > [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Chris Ball > Sent: Tuesday, March 12, 2013 5:56 AM > To: Arnd Bergmann > Cc: linux-kernel@vger.kernel.org; Stephen Warren; > linux-arm-ker...@lists.infradead.org; Mark Brow

Re: [PATCH 3/3 RESEND] mmc: sdhci: check voltage range only on regulators aware of voltage value

2013-02-20 Thread Kevin Liu
2013/2/14 Ulf Hansson : > On 14 February 2013 09:05, Marek Szyprowski wrote: >> >> On 2/13/2013 12:35 PM, Mark Brown wrote: >>> >>> On Wed, Feb 13, 2013 at 08:45:56AM +0100, Guennadi Liakhovetski wrote: >>> > On Wed, 13 Feb 2013, Marek Szyprowski wrote: >>> >>> > > BTW, mmc_regulator_get_ocrmask()

Re: [PATCH 3/3] mmc: sdhci: check voltage range only on regulators aware of voltage value

2012-12-04 Thread Kevin Liu
2012/12/5 Mark Brown > > On Tue, Dec 04, 2012 at 10:50:03PM +0800, Kevin Liu wrote: > > 2012/12/4 Marek Szyprowski : > > > > + if (host->vmmc && regulator_get_voltage(host->vmmc) > 0) { > > > ret = regula

Re: [PATCH 3/3] mmc: sdhci: check voltage range only on regulators aware of voltage value

2012-12-04 Thread Kevin Liu
2012/12/4 Marek Szyprowski : > Some regulators don't report any voltage values, so checking supported > voltage range results in disabling all SDHCI_CAN_VDD_* flags and > registration failure. This patch finally provides a correct fix for the > registration of SDHCI driver with all possible voltage

Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-20 Thread Kevin Liu
2012/11/20 Marek Szyprowski : > Hello, > > > On 11/20/2012 3:14 PM, Kevin Liu wrote: >> >> 2012/11/20 Marek Szyprowski : >> > Hello, >> > >> > >> > On 11/20/2012 12:36 PM, Kevin Liu wrote: >> >> >> >> 2012/11/20 Ma

Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-20 Thread Kevin Liu
2012/11/20 Marek Szyprowski : > Hello, > > > On 11/20/2012 12:36 PM, Kevin Liu wrote: >> >> 2012/11/20 Marek Szyprowski : >> > On 11/20/2012 9:59 AM, Kevin Liu wrote: >> >> 2012/11/20 Marek Szyprowski : >> >> > On 11/14/2012 8:11

Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-20 Thread Kevin Liu
2012/11/20 Marek Szyprowski : > Hello, > > > On 11/20/2012 9:59 AM, Kevin Liu wrote: >> >> 2012/11/20 Marek Szyprowski : >> > Hello, >> > >> > >> > On 11/14/2012 8:11 AM, Kevin Liu wrote: >> >> >> >> > From: lin

Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-20 Thread Kevin Liu
2012/11/20 Marek Szyprowski : > Hello, > > > On 11/14/2012 8:11 AM, Kevin Liu wrote: >> >> > From: linux-mmc-ow...@vger.kernel.org >> > [mailto:linux-mmc-ow...@vger.kernel.org] On Behalf Of Chris Ball >> > Sent: Tuesday, November 13, 2012 10:14 PM &g

Re: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-14 Thread Kevin Liu
2012/11/14 Philip Rakity : > > On Nov 14, 2012, at 8:57 AM, Kevin Liu wrote: > >> 2012/11/14 Mark Brown : >>> On Wed, Nov 14, 2012 at 04:36:28PM +0800, Kevin Liu wrote: >>>> 2012/11/14 Mark Brown : >>> >>>>> Should this be regulator

Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-14 Thread Kevin Liu
2012/11/14 Mark Brown : > On Wed, Nov 14, 2012 at 04:36:28PM +0800, Kevin Liu wrote: >> 2012/11/14 Mark Brown : > >> > Should this be regulator_set_voltage_tol()? Otherwise it'd be good to >> > explain where the numbers come from. > >> In SD physical

Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-14 Thread Kevin Liu
2012/11/14 Mark Brown : > On Wed, Nov 14, 2012 at 03:11:37PM +0800, Kevin Liu wrote: > >> - ret = regulator_set_voltage(host->vqmmc, 330, 330); >> + ret = regulator_set_voltage(host->vqmmc, 270, 360); > > Should thi

Re: FW: [PATCH v2] mmc: sdhci: apply voltage range check only for non-fixed regulators

2012-11-13 Thread Kevin Liu
o fixed 2.8V regulator, what results in >> clearing all available voltages and fail. The same situation is when one >> enable dummy regulator and try to use sdhci with it. My patch fixes this >> and restores sdhci to working state as it was before (before fixing >> regulator