Re: [RFC 02/19] ktf: Introduce the main part of the kernel side of ktf

On Sun, 2019-09-08 at 18:23 -0700, Brendan Higgins wrote: > On Tue, Aug 13, 2019 at 08:09:17AM +0200, Knut Omang wrote: > > Sorry, it's taken me way too long to get down to a proper code review on > this. I was hoping to send you something a couple weeks ago in > preparation for

Re: [RFC 06/19] ktf: A simple debugfs interface to test results

On Tue, 2019-08-13 at 10:21 +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 13, 2019 at 08:09:21AM +0200, Knut Omang wrote: > > From: Alan Maguire > > > > While test results is available via netlink from user space, sometimes > > it may be useful to be able to access

[RFC 02/19] ktf: Introduce the main part of the kernel side of ktf

simple additional example tests. ktf.h: Defines the KTF user API for kernel clients ktf_test.c: Kernel side code for tracking and reporting ktf test results Signed-off-by: Knut Omang --- tools/testing/selftests/ktf/kernel/Makefile | 15 +- tools/testing/selftests/ktf/kernel/ktf.h

Re: Linux Testing Microconference at LPC

On Wed, 2019-05-22 at 14:02 -0700, Brendan Higgins wrote: > On Wed, May 15, 2019 at 08:36:49PM -0400, Sasha Levin wrote: > > On Wed, May 15, 2019 at 04:44:19PM -0600, shuah wrote: > > > Hi Sasha and Dhaval, > > > > > > On 4/11/19 11:37 AM, Dhaval Giani wrote: > > > > Hi Folks, > > > > > > > >

Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework

On Wed, 2019-05-08 at 23:20 -0400, Theodore Ts'o wrote: > On Wed, May 08, 2019 at 07:13:59PM -0700, Frank Rowand wrote: > > > If you want to use vice grips as a hammer, screwdriver, monkey wrench, > > > etc. there's nothing stopping you from doing that. But it's not fair > > > to object to other

Re: Linux Testing Microconference at LPC

Hi, On Thu, 2019-04-11 at 10:37 -0700, Dhaval Giani wrote: > Hi Folks, > > This is a call for participation for the Linux Testing microconference > at LPC this year. > > For those who were at LPC last year, as the closing panel mentioned, > testing is probably the next big push needed to

Re: [RFC v4 08/17] kunit: test: add support for test abort

On Mon, 2019-03-25 at 15:32 -0700, Brendan Higgins wrote: > On Fri, Mar 22, 2019 at 12:11 AM Knut Omang wrote: > > On Thu, 2019-03-21 at 18:41 -0700, Brendan Higgins wrote: > > > On Thu, Mar 21, 2019 at 6:10 PM Frank Rowand > > > wrote: > > > > On

Re: [Announce] LPC 2018: Testing and Fuzzing Microconference

On Wed, 2018-09-19 at 10:14 -0700, Dhaval Giani wrote: > Hi folks, > > Sasha and I are pleased to announce the Testing and Fuzzing track at > LPC [ 1 ]. We are planning to continue the discussions from last > year's microconference [2]. Many discussions from the Automated > Testing Summit [3]

Re: [Announce] LPC 2018: Testing and Fuzzing Microconference

On Wed, 2018-09-19 at 10:14 -0700, Dhaval Giani wrote: > Hi folks, > > Sasha and I are pleased to announce the Testing and Fuzzing track at > LPC [ 1 ]. We are planning to continue the discussions from last > year's microconference [2]. Many discussions from the Automated > Testing Summit [3]

Re: [Announce] LPC 2018: Testing and Fuzzing Microconference

On Mon, 2018-09-24 at 15:42 +0200, Dmitry Vyukov wrote: > On Sat, Sep 22, 2018 at 2:52 PM, Matthew Wilcox wrote: > > On Wed, Sep 19, 2018 at 10:13:15AM -0700, Dhaval Giani wrote: > >> Sasha and I are pleased to announce the Testing and Fuzzing track at > >> LPC [ 1 ]. We are planning to continue

Re: [Announce] LPC 2018: Testing and Fuzzing Microconference

On Mon, 2018-09-24 at 15:42 +0200, Dmitry Vyukov wrote: > On Sat, Sep 22, 2018 at 2:52 PM, Matthew Wilcox wrote: > > On Wed, Sep 19, 2018 at 10:13:15AM -0700, Dhaval Giani wrote: > >> Sasha and I are pleased to announce the Testing and Fuzzing track at > >> LPC [ 1 ]. We are planning to continue

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Mon, 2018-02-05 at 08:20 +0100, Knut Omang wrote: > On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote: Hi Masahiro, I know these are busy times but any hope of getting forward on this? Anything more I can do to ease the process? Thanks for your time, Knut > > 2018-02-05 15:

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Mon, 2018-02-05 at 08:20 +0100, Knut Omang wrote: > On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote: Hi Masahiro, I know these are busy times but any hope of getting forward on this? Anything more I can do to ease the process? Thanks for your time, Knut > > 2018-02-05 15:

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote: > 2018-02-05 15:41 GMT+09:00 Knut Omang <knut.om...@oracle.com>: > > On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote: > >> Add scripts/runchecks which has generic support for running > >> checker tools

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Mon, 2018-02-05 at 16:03 +0900, Masahiro Yamada wrote: > 2018-02-05 15:41 GMT+09:00 Knut Omang : > > On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote: > >> Add scripts/runchecks which has generic support for running > >> checker tools in a conve

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote: > Add scripts/runchecks which has generic support for running > checker tools in a convenient and user friendly way that > the author hopes can contribute to rein in issues detected > by these tools in a manageable and co

Re: [PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Fri, 2018-01-19 at 11:14 +0100, Knut Omang wrote: > Add scripts/runchecks which has generic support for running > checker tools in a convenient and user friendly way that > the author hopes can contribute to rein in issues detected > by these tools in a manageable and co

Re: clang warning: implicit conversion in intel_ddi.c:1481

On Fri, 2018-02-02 at 16:50 +0100, Greg KH wrote: > On Fri, Feb 02, 2018 at 04:37:55PM +0200, Jani Nikula wrote: > > On Fri, 02 Feb 2018, Greg KH wrote: > > > On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote: > > >> > > >> +Knut, Fengguang > > >> > > >> On

Re: clang warning: implicit conversion in intel_ddi.c:1481

On Fri, 2018-02-02 at 16:50 +0100, Greg KH wrote: > On Fri, Feb 02, 2018 at 04:37:55PM +0200, Jani Nikula wrote: > > On Fri, 02 Feb 2018, Greg KH wrote: > > > On Fri, Feb 02, 2018 at 12:44:38PM +0200, Jani Nikula wrote: > > >> > > >> +Knut, Fengguang > > >> > > >> On Fri, 02 Feb 2018, Greg KH

Re: clang warning: implicit conversion in intel_ddi.c:1481

On Fri, 2018-02-02 at 12:44 +0200, Jani Nikula wrote: > +Knut, Fengguang > > On Fri, 02 Feb 2018, Greg KH wrote: > > - If clang now builds the kernel "cleanly", yes, I want to take > > warning fixes in the stable tree. And even better yet, if you > >

Re: clang warning: implicit conversion in intel_ddi.c:1481

On Fri, 2018-02-02 at 12:44 +0200, Jani Nikula wrote: > +Knut, Fengguang > > On Fri, 02 Feb 2018, Greg KH wrote: > > - If clang now builds the kernel "cleanly", yes, I want to take > > warning fixes in the stable tree. And even better yet, if you > > keep working to ensure the

[PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

inelle documentation also had the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Reviewed-by: John Haxby <john.ha...@oracle.com> Re

[PATCH v4 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

inelle documentation also had the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Reviewed-by: Åsmund Østvold Reviewed-by: John Haxby Reviewed-by: Tom Saeger --- Documentation/dev-tools/coccinelle.rst | 12 +- Documentation/dev-tools/index.rst |

[PATCH v4 0/1] Support for generalized use of make C={1,2} via a wrapper program

ailable at all (checkdoc) or where only a few can be filtered out (sparse) With this in place it also became almost trivial to make the look and feel similar for sparse, smatch and checkdoc as for checkpatch, with some optional color support too, to make fixing issues in the code, the goal of thi

[PATCH v4 0/1] Support for generalized use of make C={1,2} via a wrapper program

ailable at all (checkdoc) or where only a few can be filtered out (sparse) With this in place it also became almost trivial to make the look and feel similar for sparse, smatch and checkdoc as for checkpatch, with some optional color support too, to make fixing issues in the code, the goal of thi

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Sun, 2018-01-07 at 08:12 -0200, Mauro Carvalho Chehab wrote: > Em Fri, 05 Jan 2018 20:41:41 +0100 > Knut Omang <knut.om...@oracle.com> escreveu: > > > On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote: > > > Em Thu, 04 Jan 2018 21:15:31 +

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Sun, 2018-01-07 at 08:12 -0200, Mauro Carvalho Chehab wrote: > Em Fri, 05 Jan 2018 20:41:41 +0100 > Knut Omang escreveu: > > > On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote: > > > Em Thu, 04 Jan 2018 21:15:31 +0100 > > > Knut Omang escreveu:

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Sun, 2018-01-07 at 13:03 +0100, Philippe Ombredanne wrote: > Knut, > > On Fri, Jan 5, 2018 at 3:30 PM, Jani Nikula <jani.nik...@linux.intel.com> > wrote: > > On Thu, 04 Jan 2018, Knut Omang <knut.om...@oracle.com> wrote: > >> On Thu, 2018-01-04 at 17:50

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Sun, 2018-01-07 at 13:03 +0100, Philippe Ombredanne wrote: > Knut, > > On Fri, Jan 5, 2018 at 3:30 PM, Jani Nikula > wrote: > > On Thu, 04 Jan 2018, Knut Omang wrote: > >> On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote: > >>> On Thu, 04 Jan 2018,

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote: > Em Thu, 04 Jan 2018 21:15:31 +0100 > Knut Omang <knut.om...@oracle.com> escreveu: > > > > I'm surprised the commit message and the provided documentation say > > > nothing about using CHECK=foo

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Fri, 2018-01-05 at 16:08 -0200, Mauro Carvalho Chehab wrote: > Em Thu, 04 Jan 2018 21:15:31 +0100 > Knut Omang escreveu: > > > > I'm surprised the commit message and the provided documentation say > > > nothing about using CHECK=foo on the command line. That alrea

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote: > On Thu, 04 Jan 2018, Knut Omang <knut.om...@oracle.com> wrote: > > Add scripts/runchecks which has generic support for running > > checker tools in a convenient and user friendly way that > > the author hopes can c

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote: > On Thu, 04 Jan 2018, Knut Omang wrote: > > Add scripts/runchecks which has generic support for running > > checker tools in a convenient and user friendly way that > > the author hopes can contribute to re

[PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Reviewed-by: John Haxby <john.ha...@oracle.com> --- Documentation/dev-t

[PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Reviewed-by: Åsmund Østvold Reviewed-by: John Haxby --- Documentation/dev-tools/coccinelle.rst | 12 +- Documentation/dev-tools/index.rst | 1 +- Documentation/dev-tools/runchecks.rst | 215 +

[PATCH v3 0/1] Support for generalized use of make C={1,2} via a wrapper program

ome optional color support too, to make fixing issues in the code, the goal of this whole exercise, much more pleasant IMHO :-) Thanks, Knut Knut Omang (1): runchecks: Generalize make C={1,2} to support multiple checkers Documentation/dev-tools/coccinelle.rst | 12 +- Documentation/dev-

[PATCH v3 0/1] Support for generalized use of make C={1,2} via a wrapper program

ome optional color support too, to make fixing issues in the code, the goal of this whole exercise, much more pleasant IMHO :-) Thanks, Knut Knut Omang (1): runchecks: Generalize make C={1,2} to support multiple checkers Documentation/dev-tools/coccinelle.rst | 12 +- Documentation/dev-

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

Joe Perches writes: > On Tue, 2017-12-12 at 08:43 +1100, Dave Chinner wrote: >> On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote: >> > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote: >> > > 1. Using lockdep_set_novalidate_class() for anything other >> > >

Re: [PATCH v4 72/73] xfs: Convert mru cache to XArray

Joe Perches writes: > On Tue, 2017-12-12 at 08:43 +1100, Dave Chinner wrote: >> On Sat, Dec 09, 2017 at 09:00:18AM -0800, Joe Perches wrote: >> > On Sat, 2017-12-09 at 09:36 +1100, Dave Chinner wrote: >> > > 1. Using lockdep_set_novalidate_class() for anything other >> > > than device->mutex

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Mon, 2017-12-18 at 17:56 +, Bart Van Assche wrote: > On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote: > > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > > > > > Today when we run checkers we get so many warnings it is too hard to > > > > make any sense of it. > >

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Mon, 2017-12-18 at 17:56 +, Bart Van Assche wrote: > On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote: > > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > > > > > Today when we run checkers we get so many warnings it is too hard to > > > > make any sense of it. > >

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Mon, 2017-12-18 at 16:04 +0200, Leon Romanovsky wrote: > On Mon, Dec 18, 2017 at 01:36:26PM +0100, Knut Omang wrote: > > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > > > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > > > Add a runch

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Mon, 2017-12-18 at 16:04 +0200, Leon Romanovsky wrote: > On Mon, Dec 18, 2017 at 01:36:26PM +0100, Knut Omang wrote: > > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > > > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > > > Add a runch

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Mon, 2017-12-18 at 07:30 -0800, Joe Perches wrote: > On Mon, 2017-12-18 at 14:05 +0100, Knut Omang wrote: > > > Here is a list of the checkpatch messages for drivers/infiniband > > > sorted by type. > > > > > > Many of these might be corrected by using &g

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Mon, 2017-12-18 at 07:30 -0800, Joe Perches wrote: > On Mon, 2017-12-18 at 14:05 +0100, Knut Omang wrote: > > > Here is a list of the checkpatch messages for drivers/infiniband > > > sorted by type. > > > > > > Many of these might be corrected by using &g

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > I like the ability to add more checkers and keep then in the main > > > upstream tree. But adding overrides for specific subsystems goes

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > I like the ability to add more checkers and keep then in the main > > > upstream tree. But adding overrides for specific subsystems goes

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sun, 2017-12-17 at 22:00 -0800, Joe Perches wrote: > On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > > > I like the ability to add more checkers and keep then in the main > &

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sun, 2017-12-17 at 22:00 -0800, Joe Perches wrote: > On Sun, 2017-12-17 at 22:00 -0700, Jason Gunthorpe wrote: > > On Sun, Dec 17, 2017 at 03:14:10AM +0100, Knut Omang wrote: > > > > > > I like the ability to add more checkers and keep then in the main > &

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > Add a runchecks.cfg to drivers/infiniband/core > > to start "reining in" future checker errors, > > and making it easier to selective

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > Add a runchecks.cfg to drivers/infiniband/core > > to start "reining in" future checker errors, > > and making it easier to selective

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sat, 2017-12-16 at 09:47 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:25 +0100 > Knut Omang <knut.om...@oracle.com> wrote: > > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part o

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sat, 2017-12-16 at 09:47 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:25 +0100 > Knut Omang wrote: > > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part of automatic and developer tes

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On Sat, 2017-12-16 at 10:24 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > > On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang <knut.om...@oracle.com> wrote: > > > +# Code simplification: > > > +# > > > +exc

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On Sat, 2017-12-16 at 10:24 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > > On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > > > +# Code simplification: > > > +# > > > +except ALLOC_WITH_MULTIPLY ib.c &

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On Sat, 2017-12-16 at 12:00 -0800, santosh.shilim...@oracle.com wrote: > On 12/16/17 10:24 AM, Joe Perches wrote: > > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > >> On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang <knut.om...@oracle.com> > >> wr

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On Sat, 2017-12-16 at 12:00 -0800, santosh.shilim...@oracle.com wrote: > On 12/16/17 10:24 AM, Joe Perches wrote: > > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > >> On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang > >> wrote: > >>> +# Code

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:29 +0100 > Knut Omang <knut.om...@oracle.com> wrote: > > > + > > +# Important to fix from a quality perspective: > > +# > > +except AVOID_BUG connection.c ib.

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:29 +0100 > Knut Omang wrote: > > > + > > +# Important to fix from a quality perspective: > > +# > > +except AVOID_BUG connection.c ib.c ib_cm.c ib_rdma.c ib_recv.c ib_ring

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sat, 2017-12-16 at 09:00 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 17:27 +0100, Knut Omang wrote: > > On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote: > > > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > > > This patch series implements fea

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sat, 2017-12-16 at 09:00 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 17:27 +0100, Knut Omang wrote: > > On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote: > > > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > > > This patch series implements fea

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part of automatic and developer testing. > &g

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Sat, 2017-12-16 at 07:21 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part of automatic and developer testing. > &g

Re: [PATCH v2 3/5] checkpatch: Improve --fix-inplace for TABSTOP

On Sat, 2017-12-16 at 07:13 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > If the --fix-inplace option for TABSTOP encounters a sitation with several > > spaces (but less than 8) at the end of an indentation, it will assume that > >

Re: [PATCH v2 3/5] checkpatch: Improve --fix-inplace for TABSTOP

On Sat, 2017-12-16 at 07:13 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 15:42 +0100, Knut Omang wrote: > > If the --fix-inplace option for TABSTOP encounters a sitation with several > > spaces (but less than 8) at the end of an indentation, it will assume that > >

Re: [PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

/runchecks.rst > > @@ -0,0 +1,215 @@ > > +.. Copyright 2017 Knut Omang <knut.om...@oracle.com> > > + > > +Makefile support for running checkers > > += > > + > > +Tools like sparse, coccinelle and scripts/checkpatch.p

Re: [PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

/runchecks.rst > > @@ -0,0 +1,215 @@ > > +.. Copyright 2017 Knut Omang > > + > > +Makefile support for running checkers > > += > > + > > +Tools like sparse, coccinelle and scripts/checkpatch.pl is able to detect a > >

[PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

ess sparse specific and more generic. The coccinelle documentation also had the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Revi

[PATCH v2 2/5] Documentation: Add doc for runchecks, a checker runner

ess sparse specific and more generic. The coccinelle documentation also had the behaviour of C=1 and C=2 swapped. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Reviewed-by: Åsmund Østvold Reviewed-by: John Haxby --- Documentation/dev-tools/coccinelle.rst | 12 +- Documentation/dev-tools

[PATCH v2 3/5] checkpatch: Improve --fix-inplace for TABSTOP

B, which is visually worse IMO. Reported-by: Håkon Bugge <haakon.bu...@oracle.com> Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scr

[PATCH v2 3/5] checkpatch: Improve --fix-inplace for TABSTOP

B, which is visually worse IMO. Reported-by: Håkon Bugge Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 040aa79..febe010 100755 --- a/scrip

[PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

checks.rst for motivation and details. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> --- drivers/infiniband/core/runchecks.cfg | 83 - 1

[PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

nd details. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> --- net/rds/runchecks.cfg | 76 - 1 file changed, 76 insertions(+)

[PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

checks.rst for motivation and details. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Reviewed-by: Åsmund Østvold --- drivers/infiniband/core/runchecks.cfg | 83 - 1 file changed, 83 insertions(+) create mode 100644 drivers/infiniband/core/runchecks.cfg

[PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

nd details. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Reviewed-by: Åsmund Østvold --- net/rds/runchecks.cfg | 76 - 1 file changed, 76 insertions(+) create mode 100644 net/rds/runchecks.cfg diff --git a/net/rds/runchecks.cfg b/net/rds/runchec

[PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

checker in cases where types either are not available at all (checkdoc) or where only a few can be filtered out (sparse) With this in place it also became trivial to make the look and feel similar for sparse and checkdoc as for checkpatch, with some optional color support too, to make fixing issues in the

[PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

checker in cases where types either are not available at all (checkdoc) or where only a few can be filtered out (sparse) With this in place it also became trivial to make the look and feel similar for sparse and checkdoc as for checkpatch, with some optional color support too, to make fixing issues in the

[PATCH v2 1/5] runchecks: Generalize make C={1,2} to support multiple checkers

ght now. The code is designed to be easily extensible to support more checkers as they emerge, and some generic checker support is even available just via simple additions to "scripts/runchecks.cfg". Signed-off-by: Knut Omang <knut.om...@oracle.com> --- Makefile

[PATCH v2 1/5] runchecks: Generalize make C={1,2} to support multiple checkers

ght now. The code is designed to be easily extensible to support more checkers as they emerge, and some generic checker support is even available just via simple additions to "scripts/runchecks.cfg". Signed-off-by: Knut Omang --- Makefile | 23 +- scripts/Makefi

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 17:00 -0700, Jim Davis wrote: > On Mon, Nov 20, 2017 at 2:22 PM, Luc Van Oostenryck > wrote: > > > Should it be possible to somehow keep the distinction between > > the flags coming from KBUILD_CFLAGS and the pure CHECKFLAGS? > > Well, the

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 17:00 -0700, Jim Davis wrote: > On Mon, Nov 20, 2017 at 2:22 PM, Luc Van Oostenryck > wrote: > > > Should it be possible to somehow keep the distinction between > > the flags coming from KBUILD_CFLAGS and the pure CHECKFLAGS? > > Well, the practical problem seems to be

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 21:08 +0100, Luc Van Oostenryck wrote: > On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote: > > > > I'd be nice if people could just specify CHECK and CHECKFLAGS to run > > their favorite checker, but currently CHECKFLAGS seems hardwired for > > running sparse. So

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Mon, 2017-11-20 at 21:08 +0100, Luc Van Oostenryck wrote: > On Mon, Nov 20, 2017 at 12:48:35PM -0700, Jim Davis wrote: > > > > I'd be nice if people could just specify CHECK and CHECKFLAGS to run > > their favorite checker, but currently CHECKFLAGS seems hardwired for > > running sparse. So

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, 2017-11-21 at 01:18 +0900, Masahiro Yamada wrote: > 2017-11-17 2:01 GMT+09:00 Knut Omang <knut.om...@oracle.com>: > > Add interpretation of a new environment variable P={1,2} in spirit of the > > C= option, but executing checkpatch instead of sparse. > > &g

Re: [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

On Tue, 2017-11-21 at 01:18 +0900, Masahiro Yamada wrote: > 2017-11-17 2:01 GMT+09:00 Knut Omang : > > Add interpretation of a new environment variable P={1,2} in spirit of the > > C= option, but executing checkpatch instead of sparse. > > > > Signed-off-by: Knut Om

Re: [PATCH 0/7] Support for automatic checkpatch running in the kernel

-checkpatch.html Thanks, Knut On Thu, 2017-11-16 at 18:01 +0100, Knut Omang wrote: > This patch series implements features to facilitate running checkpatch on the > entire kernel as part of automatic testing. > > This is done by by adding a few small features to checkpatch and put these >

Re: [PATCH 0/7] Support for automatic checkpatch running in the kernel

-checkpatch.html Thanks, Knut On Thu, 2017-11-16 at 18:01 +0100, Knut Omang wrote: > This patch series implements features to facilitate running checkpatch on the > entire kernel as part of automatic testing. > > This is done by by adding a few small features to checkpatch and put these >

Re: [PATCH 0/7] Support for automatic checkpatch running in the kernel

On Thu, 2017-11-16 at 14:57 -0800, Kees Cook wrote: > On Thu, Nov 16, 2017 at 9:01 AM, Knut Omang <knut.om...@oracle.com> wrote: > > The most important checkpatch feature added is the --ignore-cfg feature, > > which > > takes a file argument and parses that fil

Re: [PATCH 0/7] Support for automatic checkpatch running in the kernel

On Thu, 2017-11-16 at 14:57 -0800, Kees Cook wrote: > On Thu, Nov 16, 2017 at 9:01 AM, Knut Omang wrote: > > The most important checkpatch feature added is the --ignore-cfg feature, > > which > > takes a file argument and parses that file according to this

Re: [PATCH 1/7] checkpatch: Implement new --ignore-cfg parameter

On Thu, 2017-11-16 at 09:09 -0800, Joe Perches wrote: > (adding Andrew Morton) > > On Thu, 2017-11-16 at 18:01 +0100, Knut Omang wrote: > > This parameter is intended to be used in a subsequent commit to kbuild to > > allow > > a convenient way to run check

Re: [PATCH 1/7] checkpatch: Implement new --ignore-cfg parameter

On Thu, 2017-11-16 at 09:09 -0800, Joe Perches wrote: > (adding Andrew Morton) > > On Thu, 2017-11-16 at 18:01 +0100, Knut Omang wrote: > > This parameter is intended to be used in a subsequent commit to kbuild to > > allow > > a convenient way to run check

[PATCH 6/7] checkpatch: Make --ignore-cfg look recursively for the file

-by: Knut Omang <knut.om...@oracle.com> --- scripts/checkpatch.pl | 44 ++-- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c17178e..a276eca 100755 --- a/scripts/checkpatch.pl +++ b/s

[PATCH 6/7] checkpatch: Make --ignore-cfg look recursively for the file

-by: Knut Omang --- scripts/checkpatch.pl | 44 ++-- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c17178e..a276eca 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl

[PATCH 1/7] checkpatch: Implement new --ignore-cfg parameter

in) and as documentation of TODOs and dont's if there are well justified exceptions. Signed-off-by: Knut Omang <knut.om...@oracle.com> Acked-by: Håkon Bugge <haakon.bu...@oracle.com> Acked-by: Åsmund Østvold <asmund.ostv...@oracle.com> --- scripts/

[PATCH 1/7] checkpatch: Implement new --ignore-cfg parameter

in) and as documentation of TODOs and dont's if there are well justified exceptions. Signed-off-by: Knut Omang Acked-by: Håkon Bugge Acked-by: Åsmund Østvold --- scripts/checkpatch.pl | 57 - 1 file changed, 57 insertions(+) diff --git a/scripts

[PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

Add interpretation of a new environment variable P={1,2} in spirit of the C= option, but executing checkpatch instead of sparse. Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Acked-by: Åsmund Østvold <asmund.ostv...@oracle.com

[PATCH 2/7] kbuild: Add P= command line flag to run checkpatch

Add interpretation of a new environment variable P={1,2} in spirit of the C= option, but executing checkpatch instead of sparse. Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Acked-by: Åsmund Østvold --- Makefile | 20 +++- scripts/Makefile.build | 13

[PATCH 4/7] Documentation: Add documentation for the new P= Makefile option

Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> Reviewed-by: Åsmund Østvold <asmund.ostv...@oracle.com> Reviewed-by: John Haxby <john.ha...@oracle.com> Signed-off-by: Knut Omang <knut.om...@oracle.com> --- Doc

[PATCH 4/7] Documentation: Add documentation for the new P= Makefile option

Signed-off-by: Knut Omang Reviewed-by: Håkon Bugge Reviewed-by: Åsmund Østvold Reviewed-by: John Haxby Signed-off-by: Knut Omang --- Documentation/dev-tools/index.rst | 1 +- Documentation/dev-tools/run-checkpatch.rst | 105 ++- 2 files changed, 106 insertions

[PATCH 5/7] checkpatch: Improve --fix-inplace for TABSTOP

B, which is visually worse IMO. Reported-by: Håkon Bugge <haakon.bu...@oracle.com> Signed-off-by: Knut Omang <knut.om...@oracle.com> Reviewed-by: Håkon Bugge <haakon.bu...@oracle.com> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scr

  1   2   >