Re: [PATCH] ASoC: Intel: Atom: ix spelling mistake: "allocationf" -> "allocation"

2017-02-21 Thread Koul, Vinod
On Tue, 2017-02-21 at 16:50 +, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message. Acked-by: Vinod Koul -- ~Vinod

Re: [PATCH] ASoC: Intel: Atom: ix spelling mistake: "allocationf" -> "allocation"

2017-02-21 Thread Koul, Vinod
On Tue, 2017-02-21 at 16:50 +, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err message. Acked-by: Vinod Koul -- ~Vinod

Re: [PATCH] dmaengine: st_fdma: Update st_fdma to 'depends on REMOTEPROC'.

2016-11-03 Thread Koul, Vinod
On Fri, 2016-10-21 at 09:44 +0100, Peter Griffin wrote: > During randconfig builds you can get the following warning > "warning: (ST_FDMA) selects ST_SLIM_REMOTEPROC which has unmet direct >  dependencies (REMOTEPROC)" > > randconfig builds should always build without any warnings so > update

Re: [PATCH] dmaengine: st_fdma: Update st_fdma to 'depends on REMOTEPROC'.

2016-11-03 Thread Koul, Vinod
On Fri, 2016-10-21 at 09:44 +0100, Peter Griffin wrote: > During randconfig builds you can get the following warning > "warning: (ST_FDMA) selects ST_SLIM_REMOTEPROC which has unmet direct >  dependencies (REMOTEPROC)" > > randconfig builds should always build without any warnings so > update

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-01 Thread Koul, Vinod
On Sun, 2016-10-30 at 10:06 +0800, Chen-Yu Tsai wrote: > Looking at the dmaengine API, I believe we got it wrong. > > max_burst in dma_slave_config denotes the largest amount of data > a single transfer should be, as described in dmaengine.h: Not a single transfer but smallest transaction within

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-01 Thread Koul, Vinod
On Sun, 2016-10-30 at 10:06 +0800, Chen-Yu Tsai wrote: > Looking at the dmaengine API, I believe we got it wrong. > > max_burst in dma_slave_config denotes the largest amount of data > a single transfer should be, as described in dmaengine.h: Not a single transfer but smallest transaction within

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 16:00 -0700, Sören Brinkmann wrote: > On Wed, 2016-04-06 at 22:13:59 +0000, Koul, Vinod wrote: > > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > > a/Documen

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 16:00 -0700, Sören Brinkmann wrote: > On Wed, 2016-04-06 at 22:13:59 +0000, Koul, Vinod wrote: > > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > > a/Documen

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > +++ > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > @@ -24,8 +24,8 @@

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > +++ > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > @@ -24,8 +24,8 @@

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: > On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul > wrote: > > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > > > > On Fri, Mar 18, 2016 at

Re: [PATCH v3 01/15] dmaengine: dw: fix master selection

2016-04-06 Thread Koul, Vinod
On Wed, 2016-04-06 at 22:56 +0300, Andy Shevchenko wrote: > On Wed, Apr 6, 2016 at 9:56 PM, Vinod Koul > wrote: > > On Mon, Apr 04, 2016 at 08:10:54PM +0300, Andy Shevchenko wrote: > > > On Mon, 2016-04-04 at 10:03 -0700, Vinod Koul wrote: > > > > On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy

Re: [PATCH 0/2] Bypass BAM init if Remotely controlled

2016-04-05 Thread Koul, Vinod
On Tue, 2016-04-05 at 16:21 -0500, Andy Gross wrote: > On Tue, Apr 05, 2016 at 11:19:50AM -0700, Vinod Koul wrote: > > On Tue, Mar 22, 2016 at 11:55:56AM +0200, Stanimir Varbanov wrote: > > > On 03/22/2016 11:49 AM, Pramod Gurav wrote: > > > > On some QOCM platforms(eg 8996) BAM control registers

Re: [PATCH 0/2] Bypass BAM init if Remotely controlled

2016-04-05 Thread Koul, Vinod
On Tue, 2016-04-05 at 16:21 -0500, Andy Gross wrote: > On Tue, Apr 05, 2016 at 11:19:50AM -0700, Vinod Koul wrote: > > On Tue, Mar 22, 2016 at 11:55:56AM +0200, Stanimir Varbanov wrote: > > > On 03/22/2016 11:49 AM, Pramod Gurav wrote: > > > > On some QOCM platforms(eg 8996) BAM control registers

Re: linux-next: build failure after merge of the slave-dma tree

2015-10-14 Thread Koul, Vinod
On Thu, 2015-10-15 at 11:51 +1100, Stephen Rothwell wrote: > Hi Vinod, > > After merging the slave-dma tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/dma/idma64.h:19:47: fatal error: asm-generic/io-64-nonatomic-lo-hi.h: > No > such file or directory >

Re: linux-next: build failure after merge of the slave-dma tree

2015-10-14 Thread Koul, Vinod
On Thu, 2015-10-15 at 11:51 +1100, Stephen Rothwell wrote: > Hi Vinod, > > After merging the slave-dma tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/dma/idma64.h:19:47: fatal error: asm-generic/io-64-nonatomic-lo-hi.h: > No > such file or directory >

Re: [PATCH v2 6/9] dmaengine: st_fdma: Add fdma suspend and resume callbacks.

2015-10-13 Thread Koul, Vinod
On Tue, 2015-10-13 at 12:19 +0100, Peter Griffin wrote: > Hi Vinod, > > On Wed, 07 Oct 2015, Vinod Koul wrote: > > > On Fri, Sep 11, 2015 at 03:14:28PM +0100, Peter Griffin wrote: > > > +#define ST_FDMA_PM (_fdma_pm) > > > +#else > > > +#define ST_FDMA_PM NULL > > > +#endif > > Pls

Re: [PATCH v2 6/9] dmaengine: st_fdma: Add fdma suspend and resume callbacks.

2015-10-13 Thread Koul, Vinod
On Tue, 2015-10-13 at 12:19 +0100, Peter Griffin wrote: > Hi Vinod, > > On Wed, 07 Oct 2015, Vinod Koul wrote: > > > On Fri, Sep 11, 2015 at 03:14:28PM +0100, Peter Griffin wrote: > > > +#define ST_FDMA_PM (_fdma_pm) > > > +#else > > > +#define ST_FDMA_PM NULL > > > +#endif > > Pls

Re: [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file

2015-10-08 Thread Koul, Vinod
On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote: > +#define FDMA_ID_OFST 0x0 > +#define FDMA_VER_OFST0x4 > > + > +#define FDMA_EN_OFST 0x8 Why cant these be BIT() to maintain consistency? -- ~Vinod

Re: [PATCH v2 3/9] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file

2015-10-08 Thread Koul, Vinod
On Fri, 2015-09-11 at 15:14 +0100, Peter Griffin wrote: > +#define FDMA_ID_OFST 0x0 > +#define FDMA_VER_OFST0x4 > > + > +#define FDMA_EN_OFST 0x8 Why cant these be BIT() to maintain consistency? -- ~Vinod

Re: [PATCH v4 00/25] dmaengine/ARM: Merge the edma drivers into one

2015-10-06 Thread Koul, Vinod
On Tue, 2015-10-06 at 09:15 +0300, Peter Ujfalusi wrote: > Hi > > On 09/24/2015 01:01 PM, Peter Ujfalusi wrote: > > Hi, > > > > Changes since v3: > > - Separated the two (patch 10/11 in v2 patch 10 in v3) patch which got > > squashed > > by accident for v3 > > - Added Tony's Acked-by to patch

Re: [PATCH v4 00/25] dmaengine/ARM: Merge the edma drivers into one

2015-10-06 Thread Koul, Vinod
On Tue, 2015-10-06 at 09:15 +0300, Peter Ujfalusi wrote: > Hi > > On 09/24/2015 01:01 PM, Peter Ujfalusi wrote: > > Hi, > > > > Changes since v3: > > - Separated the two (patch 10/11 in v2 patch 10 in v3) patch which got > > squashed > > by accident for v3 > > - Added Tony's Acked-by to patch

Re: [PATCH v6 2/2] dmaengine: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-10-05 Thread Koul, Vinod
On Mon, 2015-10-05 at 13:50 +, Appana Durga Kedareswara Rao wrote: > > > > On Mon, Sep 07, 2015 at 06:03:18PM +0530, Kedareswara rao Appana wrote: > > > This is the driver for the AXI Central Direct Memory Access (AXI > > > CDMA) core, which is a soft Xilinx IP core that provides > > >

Re: [PATCH v6 2/2] dmaengine: Add Xilinx AXI Central Direct Memory Access Engine driver support

2015-10-05 Thread Koul, Vinod
On Mon, 2015-10-05 at 13:50 +, Appana Durga Kedareswara Rao wrote: > > > > On Mon, Sep 07, 2015 at 06:03:18PM +0530, Kedareswara rao Appana wrote: > > > This is the driver for the AXI Central Direct Memory Access (AXI > > > CDMA) core, which is a soft Xilinx IP core that provides > > >

RE: [PATCH 3.7] dma: sh: Don't use ENODEV for failing slave lookup

2012-12-03 Thread Koul, Vinod
> > If dmaengine driver's .device_alloc_chan_resources() method returns -ENODEV, > dma_request_channel() will decide, that the driver has been removed and will > remove > the device from its list. To prevent this use ENXIO if a slave lookup fails. > > Reported-by: Kuninori Morimoto >

RE: [PATCH v2] dmatest: Fix NULL pointer dereference on ioat

2012-12-03 Thread Koul, Vinod
> On Wed, Nov 14, 2012 at 8:17 AM, viresh kumar wrote: > > On Mon, Nov 12, 2012 at 4:33 AM, Jon Mason wrote: > >> device_control is an optional and not implemented in all DMA drivers. > >> Any calls to these will result in a NULL pointer dereference. > >> dmatest makes two of these calls when

RE: [PATCH v2] dmatest: Fix NULL pointer dereference on ioat

2012-12-03 Thread Koul, Vinod
On Wed, Nov 14, 2012 at 8:17 AM, viresh kumar viresh.ku...@linaro.org wrote: On Mon, Nov 12, 2012 at 4:33 AM, Jon Mason jon.ma...@intel.com wrote: device_control is an optional and not implemented in all DMA drivers. Any calls to these will result in a NULL pointer dereference. dmatest

RE: [PATCH 3.7] dma: sh: Don't use ENODEV for failing slave lookup

2012-12-03 Thread Koul, Vinod
If dmaengine driver's .device_alloc_chan_resources() method returns -ENODEV, dma_request_channel() will decide, that the driver has been removed and will remove the device from its list. To prevent this use ENXIO if a slave lookup fails. Reported-by: Kuninori Morimoto

RE: [PATCH 1/1] ARM: ux500: Describe UART platform registering issues more accurately

2012-11-16 Thread Koul, Vinod
> > > is there anything you are waiting for still? Should Jon resend his > > > latest patches to make sure we get them merged this time? > > > > > > I have multiple people that want to send me patches for 3.8 based on > > > that work, so we are running out of time now. > > > > Vinod responded

RE: [PATCH 1/1] ARM: ux500: Describe UART platform registering issues more accurately

2012-11-16 Thread Koul, Vinod
is there anything you are waiting for still? Should Jon resend his latest patches to make sure we get them merged this time? I have multiple people that want to send me patches for 3.8 based on that work, so we are running out of time now. Vinod responded today saying it will be

RE: [PATCH] dma: tegra: fix interrupt name issue with apb dma.

2012-10-04 Thread Koul, Vinod
> > > > (Dropping stable Cc; Olof/Arnd or Vinod, is it possible you could add > > that into the patch description when applying this?) > > > > Reported-by: Stephen Warren > > Acked-by: Stephen Warren > > Should be no problem. If Vinod wants to pick it up: > > Acked-by: Arnd Bergmann Will do

RE: [PATCH] dma: tegra: fix interrupt name issue with apb dma.

2012-10-04 Thread Koul, Vinod
(Dropping stable Cc; Olof/Arnd or Vinod, is it possible you could add that into the patch description when applying this?) Reported-by: Stephen Warren swar...@nvidia.com Acked-by: Stephen Warren swar...@nvidia.com Should be no problem. If Vinod wants to pick it up: Acked-by: Arnd