Re: [PATCH 2/2] ARM: dts: exynos: use Exynos5420 dedicated USB2 PHY compatible

2020-11-20 Thread Krzysztof Kozlowski
On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote: > USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the > recently introduced dedicated compatible for Exynos5420. > > Signed-off-by: Marek Szyprowski > --- > arch/arm/boot/dts/exynos54xx.dtsi | 6 +++--- > 1

Re: [PATCH 1/2] phy: samsung: Add support for the Exynos5420 variant of the USB2 PHY

2020-11-20 Thread Krzysztof Kozlowski
phy-exynos5250-usb2.c | 48 +-- > drivers/phy/samsung/phy-samsung-usb2.c| 6 +++ > drivers/phy/samsung/phy-samsung-usb2.h| 1 + > 5 files changed, 48 insertions(+), 15 deletions(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID

2020-11-20 Thread Krzysztof Kozlowski
On Fri, Nov 20, 2020 at 06:11:11PM +0800, Alice Guo wrote: > In order to be able to use NVMEM APIs to read soc unique ID, add the > nvmem data cell and name for nvmem-cells to the "soc" node, and add a > nvmem node which provides soc unique ID to efuse@3035. > > v2: remove the subject prefix

Re: [PATCH v4 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-20 Thread Krzysztof Kozlowski
On Fri, Nov 20, 2020 at 06:11:09PM +0800, Alice Guo wrote: > Add DT Binding doc for the Unique ID of i.MX 8M series. > > v2: remove the subject prefix "LF-2571-1" > v3: put it into Documentation/devicetree/bindings/arm/fsl.yaml > modify the description of nvmem-cells > use "make

Re: [PATCH v4 4/4] soc: imx8m: change to use platform driver

2020-11-20 Thread Krzysztof Kozlowski
On Fri, Nov 20, 2020 at 06:11:12PM +0800, Alice Guo wrote: > Directly reading ocotp register depends on that bootloader enables ocotp > clk, which is not always effective, so change to use nvmem API. Using > nvmem API requires to support driver defer probe and thus change > soc-imx8m.c to use

Re: [PATCH v2 2/2] ARM: multi_v7_defconfig: enable dfsdm audio support

2020-11-20 Thread Krzysztof Kozlowski
On Fri, Nov 20, 2020 at 10:15:06AM +0100, Olivier Moysan wrote: > Add STM32 DFSDM audio support by enabling CONFIG_SND_SOC_STM32_DFSDM > as module. > > Signed-off-by: Olivier Moysan > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) >

Re: [EXT] Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-19 Thread Krzysztof Kozlowski
On Fri, Nov 20, 2020 at 06:21:55AM +, Alice Guo wrote: > > > + soc: > > > +type: object > > > +properties: > > > + compatible: > > > +oneOf: > > > + - description: new version DTS for i.MX8M SoCs > > > +items: > > > + - enum: > > > +

[PATCH] clk: samsung: allow compile testing of Exynos, S3C64xx and S5Pv210

2020-11-19 Thread Krzysztof Kozlowski
/ARCH option. Add separate Kconfig options for each of them to be able to compile test. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/samsung/Kconfig | 67 ++-- drivers/clk/samsung/Makefile | 22 ++-- include/linux/clk/samsung.h | 4 +-- 3 files

Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver

2020-11-19 Thread Krzysztof Kozlowski
On Thu, Nov 19, 2020 at 07:32:17AM +, Alice Guo wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年11月18日 22:11 > > To: Alice Guo > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.de; >

[PATCH v6 4/4] media: i2c: imx258: get clock from device properties and enable it via runtime PM

2020-11-18 Thread Krzysztof Kozlowski
the clock when accessing the IMX258 registers and when streaming starts with runtime PM. Signed-off-by: Krzysztof Kozlowski --- Changes since v5: 1. Move clk_get_rate() out of else block. Changes since v4: 1. Add missing imx258_power_off. Changes since v3: 1. None Changes since v2: 1. Do not try

[PATCH v6 3/4] media: i2c: imx258: simplify getting state container

2020-11-18 Thread Krzysztof Kozlowski
pointer dereferences. Signed-off-by: Krzysztof Kozlowski --- Changes since v3: 1. None Changes since v2: 1. New patch --- drivers/media/i2c/imx258.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index ba7f29622974

[PATCH v6 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor

2020-11-18 Thread Krzysztof Kozlowski
Add bindings for the IMX258 camera sensor. The bindings, just like the driver, are quite limited, e.g. do not support regulator supplies. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- Changes since v4: 1. Add clock-lanes, 2. Add Rob's review, 3. Add one more example

Re: [PATCH v5 4/4] media: i2c: imx258: get clock from device properties and enable it via runtime PM

2020-11-18 Thread Krzysztof Kozlowski
On Mon, Nov 02, 2020 at 05:08:47PM +0200, Sakari Ailus wrote: > Hi Krysztof, > > On Mon, Oct 19, 2020 at 07:26:17PM +0200, Krzysztof Kozlowski wrote: > > The IMX258 sensor driver checked in device properties for a > > clock-frequency property which actually does no

[PATCH v6 2/4] media: i2c: imx258: add support for binding via device tree

2020-11-18 Thread Krzysztof Kozlowski
The IMX258 can be used also on embedded designs using device tree so allow the sensor to bind to a device tree node. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. None --- drivers/media/i2c/imx258.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c

[PATCH v3] ASoC: sunxi: do not select COMMON_CLK to fix builds

2020-11-18 Thread Krzysztof Kozlowski
arch/mips/ralink/clk.o:(.text+0x88): first defined here Signed-off-by: Krzysztof Kozlowski Reviewed-by: Samuel Holland Acked-by: Maxime Ripard --- Changes since v2: 1. Fix title, 2. Add Maxime's ack. Changes since v1: 1. Do not select COMMON_CLK in arch/arm/mach-sunxi/Kconfig, 2. Add Samuel'

Re: [PATCH v2] ARM: sunxi: do not select COMMON_CLK to fix builds

2020-11-18 Thread Krzysztof Kozlowski
On Wed, 18 Nov 2020 at 16:38, Maxime Ripard wrote: > > On Tue, Nov 17, 2020 at 07:23:10PM +0100, Krzysztof Kozlowski wrote: > > COMMON_CLK is a user-selectable option with its own dependencies. The > > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers >

Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver

2020-11-18 Thread Krzysztof Kozlowski
On Wed, Nov 18, 2020 at 02:07:41PM +, Alice Guo wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年11月18日 18:42 > > To: Alice Guo > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.de; >

Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver

2020-11-18 Thread Krzysztof Kozlowski
On Wed, Nov 18, 2020 at 10:28:47AM +, Alice Guo wrote: > > > If it is properly explained and there is no other way then yes, you could. > > Here, for > > old DTBs, I would prefer to use > > of_platform_device_create() and bind to "soc" node (child of root). > > This way you would always

Re: [PATCH 2/2] ARM: multi_v7_defconfig: enable dfsdm audio support

2020-11-18 Thread Krzysztof Kozlowski
On Wed, Nov 18, 2020 at 10:50:13AM +0100, Olivier Moysan wrote: > Add DFSDM audio support by enabling CONFIG_SND_SOC_STM32_DFSDM > as module. Please say why do you enable it (e.g. for what SoC). Best regards, Krzysztof

Re: [PATCH 1/2] ARM: multi_v7_defconfig: enable spdifrx support

2020-11-18 Thread Krzysztof Kozlowski
On Wed, Nov 18, 2020 at 10:50:12AM +0100, Olivier Moysan wrote: > Add STM32 SPDIFRX support by enabling CONFIG_SND_SOC_STM32_SPDIFRX > as module. > > Signed-off-by: Olivier Moysan > --- > arch/arm/configs/multi_v7_defconfig | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK

2020-11-17 Thread Krzysztof Kozlowski
On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > > COMMON_CLK even though is a user-selectable symbol, is still selected by > > multiple other config options. COMMON_CLK should not be used when > > legac

[PATCH 3/4] dt-bindings: hwmon: convert TI ADS7828 bindings to dt-schema

2020-11-17 Thread Krzysztof Kozlowski
Convert the TI ADS7828 bindings to dt-schema. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/hwmon/ads7828.txt | 25 .../devicetree/bindings/hwmon/ti,ads7828.yaml | 57 +++ .../devicetree/bindings/trivial-devices.yaml | 4 -- 3 files changed, 57

[PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

2020-11-17 Thread Krzysztof Kozlowski
Convert the Analog Devices ADM1275 bindings to dt-schema. Signed-off-by: Krzysztof Kozlowski --- .../bindings/hwmon/adi,adm1275.yaml | 58 +++ .../devicetree/bindings/hwmon/adm1275.txt | 25 Documentation/hwmon/adm1275.rst | 2 +- 3 files

[PATCH 2/4] dt-bindings: hwmon: convert AD AD741x bindings to dt-schema

2020-11-17 Thread Krzysztof Kozlowski
Convert the Analog Devices AD741x bindings to dt-schema. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/hwmon/ad741x.txt | 15 --- .../devicetree/bindings/hwmon/adi,ad741x.yaml | 39 +++ 2 files changed, 39 insertions(+), 15 deletions(-) delete mode

[PATCH 1/4] dt-bindings: hwmon: convert TI INA2xx bindings to dt-schema

2020-11-17 Thread Krzysztof Kozlowski
Convert the TI INA2xx bindings to dt-schema. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/hwmon/ina2xx.txt | 24 .../devicetree/bindings/hwmon/ti,ina2xx.yaml | 55 +++ MAINTAINERS | 2 +- 3 files changed, 56

[PATCH] dt-bindings: arm: vt8500: remove redundant white-spaces

2020-11-17 Thread Krzysztof Kozlowski
Remove redundant white-spaces, no functional change. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/arm/vt8500.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/vt8500.yaml b/Documentation/devicetree

[PATCH 3/4] ARM: dts: s3c24xx: add SMDK2416 board compatible

2020-11-17 Thread Krzysztof Kozlowski
Add a compatible for SMDK2416 board next to the SoC compatible. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s3c2416-smdk2416.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/s3c2416-smdk2416.dts b/arch/arm/boot/dts/s3c2416-smdk2416.dts

[PATCH 1/4] dt-bindings: arm: samsung: document SMDK2416 board binding

2020-11-17 Thread Krzysztof Kozlowski
Add binding for the SMDK2416 board. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings

[PATCH 4/4] ARM: dts: s3c6410: correct SMDK6410 board compatible

2020-11-17 Thread Krzysztof Kozlowski
The SMDK6410 DTS was incorrectly called mini6410, probably copy-paste from FriendlyARM Mini6410 board. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/s3c6410-smdk6410.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/s3c6410-smdk6410.dts b/arch

[PATCH 2/4] dt-bindings: arm: samsung: document S3C6410-based boards binding

2020-11-17 Thread Krzysztof Kozlowski
Add bindings for the FriendlyARM Mini6410 and Samsung SMDK6410 boards. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/arm/samsung/samsung-boards.yaml| 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml

Re: [PATCH -next] ASoC: samsung: fix platform_no_drv_owner.cocci warnings

2020-11-17 Thread Krzysztof Kozlowski
no_drv_owner.cocci > > Signed-off-by: Zou Wei > --- > sound/soc/samsung/midas_wm1811.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: irq-loongson-pch-pic.c:undefined reference to `of_iomap'

2020-11-17 Thread Krzysztof Kozlowski
On Mon, Nov 16, 2020 at 10:21:26AM +0100, Arnd Bergmann wrote: > On Mon, Nov 16, 2020 at 9:37 AM Geert Uytterhoeven > wrote: > > On Mon, Nov 16, 2020 at 9:33 AM Arnd Bergmann wrote: > > > On Mon, Nov 16, 2020 at 5:33 AM Randy Dunlap > > > wrote: > > > > On 11/13/20 3:27 PM, kernel test robot

[PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-17 Thread Krzysztof Kozlowski
reference to `clk_set_parent' Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Put depends in DRM_IMX_LDB option only. --- drivers/gpu/drm/imx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig index 6231048aa5aa

[PATCH v2] ARM: sunxi: do not select COMMON_CLK to fix builds

2020-11-17 Thread Krzysztof Kozlowski
arch/mips/ralink/clk.o:(.text+0x88): first defined here Signed-off-by: Krzysztof Kozlowski Reviewed-by: Samuel Holland --- Changes since v1: 1. Do not select COMMON_CLK in arch/arm/mach-sunxi/Kconfig, 2. Add Samuel's review. --- sound/soc/sunxi/Kconfig | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-17 Thread Krzysztof Kozlowski
On Tue, 17 Nov 2020 at 11:56, Philipp Zabel wrote: > > On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote: > > The iMX DRM drivers use Common Clock Framework thus they cannot be built > > on platforms without it (e.g. compile test on MIPS with RALINK

Re: [PATCH net-next v2 1/3] nfc: s3fwrn5: Remove the max_payload

2020-11-17 Thread Krzysztof Kozlowski
ovided you > > with a tag, so you should include it. > > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html > > > > Reviewed-by: Krzysztof Kozlowski > > > > Best regards, > > Krzysztof > > > > Sorry about that. I incl

Re: [RFC 2/3] ARM: sunxi: do not select COMMON_CLK to fix builds

2020-11-16 Thread Krzysztof Kozlowski
On Mon, Nov 16, 2020 at 10:36:12PM -0600, Samuel Holland wrote: > On 11/15/20 11:09 AM, Krzysztof Kozlowski wrote: > > COMMON_CLK is a user-selectable option with its own dependencies. The > > most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers > > should

Re: [EXT] Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-16 Thread Krzysztof Kozlowski
On Tue, Nov 17, 2020 at 07:10:28AM +, Alice Guo wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年11月17日 0:03 > > To: Alice Guo > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.de; >

[PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
reference to `clk_set_parent' Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/imx/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig index 6231048aa5aa..65f9ef625337 100644 --- a/drivers/gpu/drm/imx/Kconfig

[PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
+0x1600): undefined reference to `clk_get_parent' /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0): undefined reference to `clk_get_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/ingenic/Kconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] phy: tegra: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
): undefined reference to `clk_get_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- drivers/usb/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig index ef4787cd3d37..0015697470ef 100644

[PATCH 2/4] ASoC: sh: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
reference to `clk_set_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- sound/soc/sh/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/sh/Kconfig b/sound/soc/sh/Kconfig index ef8a29b9f641..346c806ba390 100644 --- a/sound/soc/sh/Kconfig +++ b/sound

[PATCH 4/4] ASoC: ti: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
to `clk_set_parent' follow /usr/bin/mips-linux-gnu-ld: sound/soc/ti/omap-dmic.o: in function `omap_dmic_set_dai_sysclk': omap-dmic.c:(.text+0xa5c): undefined reference to `clk_get_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- sound/soc/ti/Kconfig | 9 + 1 file

[PATCH 1/4] ASoC: meson: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
:(.text+0x3a0): undefined reference to `clk_set_parent' /usr/bin/mips-linux-gnu-ld: sound/soc/meson/axg-tdm-formatter.o: in function `axg_tdm_formatter_event': (.text+0x7ec): undefined reference to `clk_set_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski

[PATCH 3/4] ASoC: stm: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
reference to `clk_set_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- sound/soc/stm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/stm/Kconfig b/sound/soc/stm/Kconfig index bbade257fe89..da1f7a16605b 100644 --- a/sound/soc/stm/Kconfig +++ b/sound

[PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests

2020-11-16 Thread Krzysztof Kozlowski
reference to `clk_set_parent' Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/exynos/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 6417f374b923..951d5f708e92 100644

Re: drivers/mmc/host/tmio_mmc.c:177 tmio_mmc_probe() warn: argument 3 to %08lx specifier is cast from pointer

2020-11-16 Thread Krzysztof Kozlowski
On Mon, Nov 16, 2020 at 12:22:36PM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 > commit: 54d8454436a205682bd89d66d8d9eedbc8452d15 mmc: host: Enable compile > testing of

[PATCH] mmc: tmio: do not print real IOMEM pointer

2020-11-16 Thread Krzysztof Kozlowski
-by: Krzysztof Kozlowski --- drivers/mmc/host/tmio_mmc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c index d2d3b8df1bbe..b55a29c53d9c 100644 --- a/drivers/mmc/host/tmio_mmc.c +++ b/drivers/mmc/host/tmio_mmc.c

Re: [EXT] Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver

2020-11-16 Thread Krzysztof Kozlowski
On Mon, Nov 16, 2020 at 08:18:59AM +, Alice Guo wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年11月15日 0:41 > > To: Alice Guo > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.de; >

Re: [EXT] Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-16 Thread Krzysztof Kozlowski
On Mon, Nov 16, 2020 at 07:04:13AM +, Alice Guo wrote: > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年11月15日 0:50 > > To: Alice Guo > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.de; > >

[PATCH 0/3] clk/sunxi/media: Fix builds with COMMON_CLK and HAVE_LEGACY_CLK

2020-11-15 Thread Krzysztof Kozlowski
marked as RFC. Best regards, Krzysztof Krzysztof Kozlowski (3): clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK ARM: sunxi: do not select COMMON_CLK to fix builds media: atomisp: do not select COMMON_CLK to fix builds arch/arm/mach-sunxi/Kconfig | 1 + drivers/clk

[PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK

2020-11-15 Thread Krzysztof Kozlowski
of ‘clk_unprepare’ was here The definitions clk_bulk_prepare() (and unprepare) already have proper surrounding #ifdef so add them also for clk_prepare()/clk_unprepare(). Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/clk/clk.c b

[RFC 2/3] ARM: sunxi: do not select COMMON_CLK to fix builds

2020-11-15 Thread Krzysztof Kozlowski
arch/mips/ralink/clk.o:(.text+0x88): first defined here Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-sunxi/Kconfig | 1 + sound/soc/sunxi/Kconfig | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index eea

[RFC 3/3] media: atomisp: do not select COMMON_CLK to fix builds

2020-11-15 Thread Krzysztof Kozlowski
COMMON_CLK is a user-selectable option with its own dependencies. The most important dependency is !HAVE_LEGACY_CLK. User-selectable drivers should not select COMMON_CLK because they will create a dependency cycle and build failures. Signed-off-by: Krzysztof Kozlowski --- drivers/staging

Re: [PATCH v2 1/6] ARM: dts: exynos: Fix Ethernet interface description for Odroid XU3

2020-11-15 Thread Krzysztof Kozlowski
On Tue, Nov 03, 2020 at 07:44:07PM +0100, Łukasz Stelmach wrote: > Assign appropriate compatible properties. > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, applied. Best regards,

Re: [PATCH v2 2/6] ARM: dts: exynos: Add an alias for the Ethernet interface on Odroid XU3

2020-11-15 Thread Krzysztof Kozlowski
On Tue, Nov 03, 2020 at 07:44:08PM +0100, Łukasz Stelmach wrote: > Add an alias to enable bootloaders to find the Ethernet > interface and assign a MAC address. > > Signed-off-by: Łukasz Stelmach > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 4 > 1 file changed, 4 insertions(+) >

Re: pl353-smc.c:undefined reference to `amba_driver_register'

2020-11-15 Thread Krzysztof Kozlowski
On Sun, Nov 15, 2020 at 06:17:53AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: f01c30de86f1047e9bae1b1b1417b0ce8dcd15b1 > commit: ea0c0ad6b6eb36726088991d97a55b99cae456d0 memory: Enable compile > testing for most

Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-14 Thread Krzysztof Kozlowski
On Fri, Nov 13, 2020 at 07:04:06PM +0800, Alice Guo wrote: > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > .../devicetree/bindings/arm/fsl.yaml | 25 +++ > 1 file changed, 25 insertions(+) > > diff --git

Re: [PATCH v3 4/4] soc: imx8m: change to use platform driver

2020-11-14 Thread Krzysztof Kozlowski
On Fri, Nov 13, 2020 at 07:04:09PM +0800, Alice Guo wrote: > Directly reading ocotp register depends on that bootloader enables ocotp > clk, which is not always effective, so change to use nvmem API. Using > nvmem API requires to support driver defer probe and thus change > soc-imx8m.c to use

Re: [PATCH v3 3/4] arm64: dts: imx8m: add nvmem-cell related stuff

2020-11-14 Thread Krzysztof Kozlowski
On Fri, Nov 13, 2020 at 07:04:08PM +0800, Alice Guo wrote: > Add nvmem-cell related stuff for the soc unique ID. Do not silently ignore comments during review. Let me repeat my comment from v1: Subject and commit msg: please do not add "stuff" but describe what are you adding and why (what is

Re: [PATCH v3 2/4] arm64: dts: imx8m: add compatible string to .dtsi file

2020-11-14 Thread Krzysztof Kozlowski
to .dtsi file for binding of imx8_soc_init_driver > and device. s/file/files/ With above changes: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-11-14 Thread Krzysztof Kozlowski
On Fri, Nov 13, 2020 at 07:04:06PM +0800, Alice Guo wrote: > Add DT Binding doc for the Unique ID of i.MX 8M series. > Please align the subject prefix with history (git log --oneline). What are the changes comparing to v2 and v1? Where is the changelog? Best regards, Krzysztof

Re: [PATCH] ASoC: samsung: remove the unused variable value assignment

2020-11-14 Thread Krzysztof Kozlowski
On Fri, Nov 13, 2020 at 10:51:19PM +0800, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The value of variable ret is overwritten by the following call > devm_snd_soc_register_card(), so here the value assignment is useless. > Remove it. > > Reported-by: Tosk Robot Where can we find the

Re: [PATCH v8 08/26] memory: tegra30-emc: Continue probing if timings are missing in device-tree

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:38AM +0300, Dmitry Osipenko wrote: > EMC driver will become mandatory after turning it into interconnect > provider because interconnect users, like display controller driver, will > fail to probe using newer device-trees that have interconnect properties. > Thus make

Re: [PATCH v8 07/26] memory: tegra30-emc: Make driver modular

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:37AM +0300, Dmitry Osipenko wrote: > Add modularization support to the Tegra30 EMC driver, which now can be > compiled as a loadable kernel module. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/Kconfig | 2 +- > drivers/memory/tegra/mc.c

Re: [PATCH v8 04/26] memory: tegra20-emc: Add devfreq support

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:34AM +0300, Dmitry Osipenko wrote: > Add devfreq support to the Tegra20 EMC driver. Memory utilization > statistics will be periodically polled from the memory controller and > appropriate minimum clock rate will be selected by the devfreq governor. > >

Re: [PATCH v8 05/26] memory: tegra20-emc: Remove IRQ number from error message

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:35AM +0300, Dmitry Osipenko wrote: > Remove IRQ number from error message since it doesn't add any useful > information, especially because this number is virtual. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra20-emc.c | 2 +- > 1 file

Re: [PATCH v8 06/26] memory: tegra30: Add FIFO sizes to memory clients

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:36AM +0300, Dmitry Osipenko wrote: > The latency allowness is calculated based on buffering capabilities of > memory clients. Add FIFO sizes to the Tegra30 memory clients. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra30.c | 66

Re: [PATCH v8 03/26] memory: tegra20-emc: Factor out clk initialization

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:33AM +0300, Dmitry Osipenko wrote: > Factor out clk initialization and make it resource-managed. This makes > easier to follow code and will help to make further changes cleaner. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra20-emc.c | 70

Re: [PATCH v8 02/26] memory: tegra20-emc: Use dev_pm_opp_set_clkname()

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:32AM +0300, Dmitry Osipenko wrote: > The dev_pm_opp_get_opp_table() shouldn't be used by drivers, use > dev_pm_opp_set_clkname() instead. > > Suggested-by: Viresh Kumar > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra20-emc.c | 30

Re: [PATCH v8 01/26] memory: tegra: Correct stub of devm_tegra_memory_controller_get()

2020-11-14 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:31AM +0300, Dmitry Osipenko wrote: > Correct typo in a stub of devm_tegra_memory_controller_get() to fix a > non-ARM kernel compile-testing. > > Reported-by: Stephen Rothwell > Signed-off-by: Dmitry Osipenko > --- > include/soc/tegra/mc.h | 2 +- Thanks, applied.

Re: [PATCH v4] clk: samsung: Prevent potential endless loop in the PLL set_rate ops

2020-11-12 Thread Krzysztof Kozlowski
On Tue, Nov 10, 2020 at 08:32:26PM +0100, Sylwester Nawrocki wrote: > The PLL status polling loops in the set_rate callbacks of some PLLs > have no timeout detection and may become endless loops when something > goes wrong with the PLL. > > For some PLLs there is already the ktime API based

Re: [PATCH v9 3/5] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-12 Thread Krzysztof Kozlowski
> 1 file changed, 8 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH] clk: samsung: allow building the clkout driver as module

2020-11-12 Thread Krzysztof Kozlowski
On Thu, Nov 12, 2020 at 03:36:35PM +0100, Sylwester Nawrocki wrote: > On 11/10/20 20:37, Krzysztof Kozlowski wrote: > > The Exynos clock output driver can be built as module (it does not have > > to be part of core init process) for better customization. Adding a > > KCon

Re: [PATCH v6 0/5] AX88796C SPI Ethernet Adapter

2020-11-12 Thread Krzysztof Kozlowski
On Thu, 12 Nov 2020 at 12:51, Łukasz Stelmach wrote: > > This is a driver for AX88796C Ethernet Adapter connected in SPI mode as > found on ARTIK5 evaluation board. The driver has been ported from a > v3.10.9 vendor kernel for ARTIK5 board. > > Changes in v6: > - fixed typos in Kconfig > -

Re: [PATCH v4 18/24] iommu/mediatek: Support master use iova over 32bit

2020-11-11 Thread Krzysztof Kozlowski
djust its bank number. > > Each a bank is a iova_region which is a independent iommu-domain. > the iova range for each iommu-domain can't cross 4G. > > Signed-off-by: Yong Wu > Acked-by: Krzysztof Kozlowski # memory part > --- > drivers/iommu/mtk_iommu.c | 12 +++

Re: [PATCH v4 06/24] iommu/mediatek: Use the common mtk-smi-larb-port.h

2020-11-11 Thread Krzysztof Kozlowski
e/soc/mediatek/smi.h | 2 -- > 4 files changed, 2 insertions(+), 9 deletions(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 05/24] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 08:38:19PM +0800, Yong Wu wrote: > This patch adds decriptions for mt8192 IOMMU and SMI. > > mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation > table format. The M4U-SMI HW diagram is as below: > > EMI >

Re: [PATCH v4 03/24] dt-bindings: memory: mediatek: Extend LARB_NR_MAX to 32

2020-11-11 Thread Krzysztof Kozlowski
ndings/memory/mtk-smi-larb-port.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 04/24] dt-bindings: memory: mediatek: Add domain definition

2020-11-11 Thread Krzysztof Kozlowski
e in its special > range. > > This is a preparing patch for multi-domain support. > > Signed-off-by: Yong Wu > --- > include/dt-bindings/memory/mtk-smi-larb-port.h | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v4 02/24] dt-bindings: memory: mediatek: Add a common larb-port header file

2020-11-11 Thread Krzysztof Kozlowski
ings/memory/mtk-smi-larb-port.h | 15 +++ > 6 files changed, 20 insertions(+), 5 deletions(-) > create mode 100644 include/dt-bindings/memory/mtk-smi-larb-port.h > > diff --git a/include/dt-bindings/memory/mt2712-larb-port.h > b/include/dt-bindings/memory/mt2712-larb-p

Re: [PATCH v4 10/18] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-11-11 Thread Krzysztof Kozlowski
On Wed, 11 Nov 2020 at 10:32, Serge Semin wrote: > > On Wed, Nov 11, 2020 at 10:16:28AM +0100, Krzysztof Kozlowski wrote: > > On Wed, Nov 11, 2020 at 12:08:45PM +0300, Serge Semin wrote: > > > DWC USB3 DT node is supposed to be compliant with the Generic xHCI &g

Re: [PATCH v8 11/26] memory: tegra124-emc: Make driver modular

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 12:17:37PM +0300, Dmitry Osipenko wrote: > 11.11.2020 12:04, Krzysztof Kozlowski пишет: > >> -obj-$(CONFIG_TEGRA124_EMC)+= clk-tegra124-emc.o > >> +obj-$(CONFIG_ARCH_TEGRA_124_SOC) += clk-tegra124-emc.o > >> +obj-$(CONF

Re: [PATCH v4 10/18] dt-bindings: usb: Convert DWC USB3 bindings to DT schema

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 12:08:45PM +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available

Re: [PATCH v8 11/26] memory: tegra124-emc: Make driver modular

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:41AM +0300, Dmitry Osipenko wrote: > Add modularization support to the Tegra124 EMC driver, which now can be > compiled as a loadable kernel module. > > Note that EMC clock must be registered at clk-init time, otherwise PLLM > will be disabled as unused clock at boot

Re: [PATCH v8 10/26] memory: tegra30-emc: Factor out clk initialization

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 09:51:15AM +0100, Krzysztof Kozlowski wrote: > On Wed, Nov 11, 2020 at 04:14:40AM +0300, Dmitry Osipenko wrote: > > Factor out clk initialization and make it resource-managed. This makes > > easier to follow code and will help to make further

Re: [PATCH v8 10/26] memory: tegra30-emc: Factor out clk initialization

2020-11-11 Thread Krzysztof Kozlowski
On Wed, Nov 11, 2020 at 04:14:40AM +0300, Dmitry Osipenko wrote: > Factor out clk initialization and make it resource-managed. This makes > easier to follow code and will help to make further changes cleaner. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra30-emc.c | 70

[PATCH] clk: samsung: allow building the clkout driver as module

2020-11-10 Thread Krzysztof Kozlowski
The Exynos clock output driver can be built as module (it does not have to be part of core init process) for better customization. Adding a KConfig entry allows also compile testing for build coverage. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/samsung/Kconfig | 10

Re: [PATCH v2 3/3] MAINTAINERS: Add dt-bindings to mailbox entry

2020-11-10 Thread Krzysztof Kozlowski
On Thu, Sep 03, 2020 at 09:53:25PM +0200, Krzysztof Kozlowski wrote: > Cover the dt-bindings of mailbox drivers by mailbox maintainers entry. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. New patch Jassi, Any comments on this patch? Best regards, Krzysztof

[PATCH v2 2/2] ARM: dts: imx6q-pico: fix board compatibles

2020-11-10 Thread Krzysztof Kozlowski
There are four flavors of TechNexion PICO-IMX6 boards. They have their own DTSes, even though in Dwarf, Nymph and Pi are exactly the same. They also have their own bindings so adjust the compatibles to match the bindings. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. None

[PATCH v2 1/2] dt-bindings: arm: fsl: document i.MX7S boards

2020-11-10 Thread Krzysztof Kozlowski
Document and adjust the compatibles for i.MX7S based boards. The Toradex boards use multiple compatibles. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- Changes since v1: 1. Rebase, 2. Add Rob's review. --- Documentation/devicetree/bindings/arm/fsl.yaml | 12 +--- 1

Re: [PATCH 1/6] ARM: dts: exynos: use hyphens in Exynos3250 node names

2020-11-10 Thread Krzysztof Kozlowski
On Thu, Nov 05, 2020 at 07:45:01PM +0100, Krzysztof Kozlowski wrote: > Use hyphens instead of underscores in the Exynos3250 node names which is > expected by naming convention, multiple dtschema files and pointed out > by dtc W=2 builds. Use also generic "ppmu" node name for PP

Re: [PATCH v8 6/7] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-11-10 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 11:36:56AM +0100, Sylwester Nawrocki wrote: > From: Artur Świgoń > > This patch adds an 'interconnects' property to Exynos4412 DTS in order to > declare the interconnect path used by the mixer. Please note that the > 'interconnect-names' property is not needed when there

Re: [PATCH v8 5/7] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-11-10 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 11:36:55AM +0100, Sylwester Nawrocki wrote: > This patch adds the following properties for Exynos4412 interconnect > bus nodes: > - interconnects: to declare connections between nodes in order to >guarantee PM QoS requirements between nodes, > - #interconnect-cells:

Re: [PATCH V3] memory: tegra: add missing put_device() call in error path of tegra_emc_probe()

2020-11-10 Thread Krzysztof Kozlowski
On Tue, Nov 10, 2020 at 09:33:11AM +0800, Yu Kuai wrote: > The reference to device obtained with of_find_device_by_node() should > be dropped. Thus add jump target to fix the exception handling for this > function implementation. > > Fixes: 73a7f0a90641("memory: tegra: Add EMC (external memory

Re: [PATCH 00/19] Second step support for A100

2020-11-10 Thread Krzysztof Kozlowski
On Tue, 10 Nov 2020 at 07:00, Frank Lee wrote: > > It seems that sending too many e-mails at one time will cause some > emails to fail to be sent out. I will try again. Hi, Instead please reduce the address list to relevant people, as pointed out by scripts/get_maintainer.pl. Don't Cc

Re: [PATCH V2] memory: tegra: add missing put_devcie() call in error path of tegra_emc_probe()

2020-11-09 Thread Krzysztof Kozlowski
On Mon, Nov 09, 2020 at 09:28:47PM +0800, Yu Kuai wrote: > The reference to device obtained with of_find_device_by_node() should > be dropped. Thus add jump target to fix the exception handling for this > function implementation. You still need to correct the typo devcie->device in subject, as in

Re: linux-next: build failure after merge of the drivers-memory tree

2020-11-09 Thread Krzysztof Kozlowski
On Mon, 9 Nov 2020 at 02:01, Dmitry Osipenko wrote: > > 09.11.2020 02:23, Stephen Rothwell пишет: > > Hi all, > > > > After merging the drivers-memory tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > > In file included from drivers/devfreq/tegra20-devfreq.c:18: > >

Re: [PATCH] arm64: dts: imx: Fix imx8mm-kontron-n801x-s.dtb target

2020-11-08 Thread Krzysztof Kozlowski
On Sun, 8 Nov 2020 at 20:13, Nathan Chancellor wrote: > > Hi Krzysztof, > > On Sun, Nov 08, 2020 at 10:31:10AM +0100, Krzysztof Kozlowski wrote: > > On Sun, 8 Nov 2020 at 03:23, Nathan Chancellor > > wrote: > > > > Hi, > > > > Thanks for the

Re: [PATCH v2 2/2] arm64: dts: exynos: Correct psci compatible used on Exynos7

2020-11-08 Thread Krzysztof Kozlowski
On Sat, Nov 07, 2020 at 02:39:26PM +0100, Paweł Chmiel wrote: > It's not possible to reboot or poweroff Exynos7420 using PSCI. Instead > we need to use syscon reboot/poweroff drivers, like it's done for other > Exynos SoCs. This was confirmed by checking vendor source and testing it > on Samsung

<    6   7   8   9   10   11   12   13   14   15   >