Re: [PATCH v2 1/4] arm64: defconfig: Enable Librem 5 devkit components

2020-12-19 Thread Krzysztof Kozlowski
er > --- > arch/arm64/configs/defconfig | 8 ++++ > 1 file changed, 8 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/4] arm64: dts: imx8mq-librem5: Move usdhc clocks assignment to board DT

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 11:31:30AM +0100, Martin Kepplinger wrote: > According to commit e045f044e84e ("arm64: dts: imx8mq: Move usdhc clocks > assignment to board DT") add the clocks assignment to imx8mq-librem5.dtsi > too. > > Signed-off-by: Martin Kepplinger This should go with Fixes tag as

Re: [PATCH 2/4] arm64: dts: imx8mq-librem5: add pinctrl for the touchscreen description

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 11:31:29AM +0100, Martin Kepplinger wrote: > Add the pinctrl description for the interrupt. Please describe why do you need to add it. From the patch contents I easily see what you are doing. But neither the commit title nor the message describe what you want to achieve

Re: [PATCH v8 3/4] arm64: dts: imx8m: add NVMEM provider and consumer to read soc unique ID

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 04:37:25PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > In order to be able to use NVMEM APIs to read soc unique ID, add the > nvmem data cell and name for nvmem-cells to the "soc" node, and add a > nvmem node which provides soc unique ID to efuse@3035. > >

Re: [PATCH v8 4/4] soc: imx8m: change to use platform driver

2020-12-19 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 04:37:26PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Directly reading ocotp register depends on that bootloader enables ocotp > clk, which is not always effective, so change to use nvmem API. Using > nvmem API requires to support driver defer probe and thus

Re: [PATCH v2 16/18] arm64: dts: hi3660: Harmonize DWC USB3 DT nodes name

2020-12-19 Thread Krzysztof Kozlowski
requires the USB nodes to have the name acceptable by the regexp: > > "^usb(@.*)?" . Make sure the "snps,dwc3"-compatible nodes are correctly > > named. > > > > Signed-off-by: Serge Semin > > Acked-by: Krzysztof Kozlowski > > --- > > arch

Re: [PATCH v2 41/48] memory: tegra20-emc: Use devm_tegra_core_dev_init_opp_table()

2020-12-19 Thread Krzysztof Kozlowski
On Thu, Dec 17, 2020 at 09:06:31PM +0300, Dmitry Osipenko wrote: > Use common devm_tegra_core_dev_init_opp_table() helper for the OPP table > initialization. > > Signed-off-by: Dmitry Osipenko > --- > drivers/memory/tegra/tegra20-emc.c | 57 +++--- > 1 file changed, 4

Re: [PATCH v2 07/48] dt-bindings: arm: tegra: Add binding for core power domain

2020-12-19 Thread Krzysztof Kozlowski
On Thu, Dec 17, 2020 at 09:05:57PM +0300, Dmitry Osipenko wrote: > All NVIDIA Tegra SoCs have a core power domain where majority of hardware > blocks reside. Add binding for the core power domain. > > Signed-off-by: Dmitry Osipenko > --- > .../arm/tegra/nvidia,tegra20-core-domain.yaml | 48

Re: [PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

2020-12-18 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 02:25:39PM +0100, Marek Szyprowski wrote: > On 10.12.2020 22:29, Krzysztof Kozlowski wrote: > > Interrupt line can be configured on different hardware in different way, > > even inverted. Therefore driver should not enforce specific trigger > >

Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-18 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 09:05:00AM +, Alice Guo (OSS) wrote: > > +required: > > > + - compatible > > > + - nvmem-cells > > > + - nvmem-cell-names > > > + > > > +additionalProperties: true > > > > Don't leave comments unresolved (or resolve them against review without > >

Re: [PATCH v8 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-18 Thread Krzysztof Kozlowski
On Fri, Dec 18, 2020 at 04:37:23PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v8: > - match soc node with regular expression > Changes for v7: > - change to a separate schema

Re: [PATCH v7 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-16 Thread Krzysztof Kozlowski
On Wed, Dec 16, 2020 at 09:55:34AM +, Alice Guo (OSS) wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: 2020年12月15日 17:11 > > To: Alice Guo (OSS) > > Cc: robh...@kernel.org; shawn...@kernel.org; s.ha...@pengutronix.

Re: [PATCH] clk: s2mps11: Fix a resource leak in error handling paths in the probe function

2020-12-15 Thread Krzysztof Kozlowski
missing of_node_put and of_clk_del_provider") > > Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11") > Signed-off-by: Christophe JAILLET > --- > drivers/clk/clk-s2mps11.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/4] arm64: dts: imx8mq-librem5-devkit: Mark more regulators as always-on

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:13PM +0100, Guido Günther wrote: > They power vital parts of the board and low power consumption is not > really an issue here. It also brings things more in line with what > Purism is using downstream. I don't find it a proper explanation. Not all regulators power

Re: [PATCH 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:14PM +0100, Guido Günther wrote: > Otherwise the boot hangs early on. And previously it was booting or maybe never tested? Maybe the issue is actually different, e.g. you miss some power domains? Best regards, Krzysztof

Re: [PATCH 2/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:12PM +0100, Guido Günther wrote: > The board has it's own rtc chip. s/rtc/RTC/ Even if you have on-board RTC, why disabling the SNVS? Best regards, Krzysztof > > Signed-off-by: Guido Günther > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4

Re: [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components

2020-12-15 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:17:11PM +0100, Guido Günther wrote: > This enables > > - touchscreen: CONFIG_TOUCHSCREEN_GOODIX > - charge controller: CONFIG_CHARGER_BQ25890 > - audio codec: CONFIG_SND_SOC_IMX_SGTL5000 > - rtc: CONFIG_RTC_DRV_M41T80 > - magnetometer: CONFIG_IIO_ST_MAGN_3AXIS > - pwm:

Re: [PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove unused NCI prop commands

2020-12-15 Thread Krzysztof Kozlowski
s/nfc/s3fwrn5/nci.h | 22 -- > 2 files changed, 47 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 net-next 1/2] nfc: s3fwrn5: Remove the delay for NFC sleep

2020-12-15 Thread Krzysztof Kozlowski
++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v7 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-15 Thread Krzysztof Kozlowski
On Tue, Dec 15, 2020 at 04:35:48PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > -

Re: [PATCH v7 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-15 Thread Krzysztof Kozlowski
On Tue, Dec 15, 2020 at 04:35:48PM +0800, Alice Guo (OSS) wrote: > From: Alice Guo > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > Signed-off-by: Alice Guo > --- > > Changes for v7: > - change to a separate schema file > Changes for v6: > - none > Changes for v5: > -

Re: [PATCH -next] fbdev: s3c2410fb: convert comma to semicolon

2020-12-14 Thread Krzysztof Kozlowski
On Mon, Dec 14, 2020 at 09:33:17PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/video/fbdev/s3c2410fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by

Re: [PATCH net-next] nfc: s3fwrn5: Remove unused nci prop commands

2020-12-14 Thread Krzysztof Kozlowski
On Mon, Dec 14, 2020 at 08:46:58PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > remove the unused nci prop commands that samsung driver doesn't use. Don't send patches one-by-one, but group them in a patchset. Previous comments apply here as well - NCI is acronym, start with capital

Re: [PATCH net-next] nfc: s3fwrn5: Remove the delay for nfc sleep

2020-12-14 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 07:12:38PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > remove the delay for nfc sleep because nfc doesn't need the sleep delay. Please start sentences with capital letter. s/nfc/NFC/ (here and in subject) This explanation is very vague. Please rephrase it. Best

Re: [PATCH net-next] nfc: s3fwrn5: Release the nfc firmware

2020-12-14 Thread Krzysztof Kozlowski
On Sun, Dec 13, 2020 at 06:58:50PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > add the code to release the nfc firmware when the firmware image size is > wrong. s/add/Add/ s/nfc/NFC/ Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [linux-nfc] [PATCH net-next] MAINTAINERS: Update maintainer for SAMSUNG S3FWRN5 NFC

2020-12-14 Thread Krzysztof Kozlowski
On Mon, Dec 14, 2020 at 09:28:23PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > add an email to look after the SAMSUNG NFC driver. Hi Bongsu, Review and testing is always appreciated. However before adding an entry to Maintainers, I would prefer to see some activity in maintainer-like

Re: [RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

2020-12-11 Thread Krzysztof Kozlowski
On Fri, Dec 11, 2020 at 05:44:26PM +0200, Iskren Chernev wrote: > > On 12/11/20 9:47 AM, Krzysztof Kozlowski wrote: > > On Thu, Dec 10, 2020 at 10:25:34PM +0100, Krzysztof Kozlowski wrote: > >> Interrupt line can be configured on different hardware in different way, > >

Re: [RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
On Thu, Dec 10, 2020 at 11:16:00PM +0100, Sebastian Reichel wrote: > (I shortened the Cc) > > Hi, > > On Thu, Dec 10, 2020 at 10:25:34PM +0100, Krzysztof Kozlowski wrote: > > [...] > > index d956c67d5155..f737de0470de 100644 > > --- a/drivers/power/supply/max

Re: [RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
On Thu, Dec 10, 2020 at 10:25:34PM +0100, Krzysztof Kozlowski wrote: > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to

[PATCH 04/18] ARM: dts: exynos: correct MUIC interrupt trigger level on Midas family

2020-12-10 Thread Krzysztof Kozlowski
is shared so using level sensitive interrupt is here especially important to avoid races. Fixes: 7eec1266751b ("ARM: dts: Add Maxim 77693 PMIC to exynos4412-trats2") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- 1 file changed, 1 insertion(+),

[PATCH 01/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on GT-I9100

2020-12-10 Thread Krzysztof Kozlowski
The Maxim fuel gauge datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct. Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2") Signed-off-by:

[PATCH] nfc: s3fwrn5: let core configure the interrupt trigger

2020-12-10 Thread Krzysztof Kozlowski
If interrupt trigger is not set when requesting the interrupt, the core will take care of reading trigger type from Devicetree. There is no point to do it in the driver. Signed-off-by: Krzysztof Kozlowski --- drivers/nfc/s3fwrn5/i2c.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions

[PATCH 06/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid X/U3 family

2020-12-10 Thread Krzysztof Kozlowski
is shared so using level sensitive interrupt is here especially important to avoid races. Fixes: eea6653aae7b ("ARM: dts: Enable PMIC interrupts for exynos4412-odroid-common") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +- 1 file changed, 1

[PATCH 03/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on Midas family

2020-12-10 Thread Krzysztof Kozlowski
Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi index 111c32bae02c..b8b75dc81aa1 100644 --- a/arch/arm/boot/dts/exynos4412-

[PATCH 07/18] ARM: dts: exynos: correct PMIC interrupt trigger level on P4 Note family

2020-12-10 Thread Krzysztof Kozlowski
is shared so using level sensitive interrupt is here especially important to avoid races. Fixes: f48b5050c301 ("ARM: dts: exynos: add Samsung's Exynos4412-based P4 Note boards") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-p4note.dtsi | 2 +- 1 file changed, 1 inser

[PATCH 10/18] ARM: dts: s5pv210: correct fuel gauge interrupt trigger level on Fascinate family

2020-12-10 Thread Krzysztof Kozlowski
The Maxim fuel gauge datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct. Fixes: 99bb20321f0e ("ARM: dts: s5pv210: Correct fuelgauge definition on Aries") Signed-off-by:

[PATCH 09/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Snow

2020-12-10 Thread Krzysztof Kozlowski
is shared so using level sensitive interrupt is here especially important to avoid races. Fixes: c61248afa819 ("ARM: dts: Add max77686 RTC interrupt to cros5250-common") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5250-snow-common.dtsi | 2 +- 1 file changed, 1 inser

[PATCH 11/18] ARM: dts: qcom: msm8974-lge-nexus5: correct fuel gauge interrupt trigger level

2020-12-10 Thread Krzysztof Kozlowski
The Maxim fuel gauge datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct. Fixes: 45dfa741df86 ("ARM: dts: qcom: msm8974-lge-nexus5: Add fuel gauge") Signed-off-by:

[RFC 14/18] rtc: max77686: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
after by the RTC, the interrupt might not be yet cleared/acked thus the second one would not be noticed. Signed-off-by: Krzysztof Kozlowski --- This patch should wait till DTS changes are merged, as it relies on proper Devicetree. --- drivers/rtc/rtc-max77686.c | 4 ++-- 1 file changed, 2

[RFC 13/18] mfd: max77686: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
after by the RTC, the interrupt might not be yet cleared/acked thus the second one would not be noticed. Signed-off-by: Krzysztof Kozlowski --- This patch should wait till DTS changes are merged, as it relies on proper Devicetree. --- Documentation/devicetree/bindings/clock/maxim,max77686.txt | 4

[PATCH 12/18] ARM: dts: qcom: msm8974-samsung-klte: correct fuel gauge interrupt trigger level

2020-12-10 Thread Krzysztof Kozlowski
The Maxim fuel gauge datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct. Fixes: da8d46992e67 ("ARM: dts: qcom: msm8974-klte: Add fuel gauge") Signed-off-by: Krzysztof

[PATCH 4/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Spring

2020-12-10 Thread Krzysztof Kozlowski
: Add exynos5250-spring device tree") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5250-spring.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts index 9d2baea62d0d..fb

[PATCH 5/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Arndale Octa

2020-12-10 Thread Krzysztof Kozlowski
Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts index bf457d0c02eb..1aad4859c5f1 100644 --- a/arch/ar

[PATCH 9/9] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct. Signed-off-by: Krzysztof Kozlowski --- This patch should wait till DTS changes are merged, as it relies on proper Devicetree. --- drivers/mfd/sec-irq.c

[PATCH 6/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 family

2020-12-10 Thread Krzysztof Kozlowski
The Samsung PMIC datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU. The falling edge interrupt will mostly work but it's not correct. Fixes: aac4e0615341 ("ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC") Signed-off-by: Krzysztof

[PATCH 8/9] arm64: dts: exynos: correct PMIC interrupt trigger level on Espresso

2020-12-10 Thread Krzysztof Kozlowski
: Add S2MPS15 PMIC node on exynos7-espresso") Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-es

[PATCH 7/9] arm64: dts: exynos: correct PMIC interrupt trigger level on TM2

2020-12-10 Thread Krzysztof Kozlowski
: dts: exynos: Add dts file for Exynos5433-based TM2 board") Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/

[PATCH 3/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Rinato

2020-12-10 Thread Krzysztof Kozlowski
: Add board dts file for exynos3250-rinato") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-rinato.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts index a2

[PATCH 1/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Artik 5

2020-12-10 Thread Krzysztof Kozlowski
: dts: exynos: Add exynos3250-artik5 dtsi file for ARTIK5 module") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-artik5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos3250-artik5.dtsi b/arch/arm/boot/dts/exynos3250-artik5.

[PATCH 2/9] ARM: dts: exynos: correct PMIC interrupt trigger level on Monk

2020-12-10 Thread Krzysztof Kozlowski
: add board dts file for Exynos3250-based Monk board") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-monk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts index 69

[RFC 15/18] mfd: max77693: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
after by the RTC, the interrupt might not be yet cleared/acked thus the second one would not be noticed. Signed-off-by: Krzysztof Kozlowski --- This patch should wait till DTS changes are merged, as it relies on proper Devicetree. --- Documentation/devicetree/bindings/mfd/max77693.txt | 2

[RFC 17/18] mfd: max14577: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
shortly after by the RTC, the interrupt might not be yet cleared/acked thus the second one would not be noticed. Signed-off-by: Krzysztof Kozlowski --- This patch should wait till DTS changes are merged, as it relies on proper Devicetree. --- Documentation/devicetree/bindings/mfd/max14577.txt

[RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
with a requirement of acknowledge from the CPU therefore the edge falling is not correct. Signed-off-by: Krzysztof Kozlowski --- This patch should wait till DTS changes are merged, as it relies on proper Devicetree. --- .../devicetree/bindings/power/supply/max17040_battery.txt | 2 +- drivers/power

[RFC 16/18] power: supply: max17042: Do not enforce (incorrect) interrupt trigger type

2020-12-10 Thread Krzysztof Kozlowski
shortly after by the RTC, the interrupt might not be yet cleared/acked thus the second one would not be noticed. Signed-off-by: Krzysztof Kozlowski --- This patch should wait till DTS changes are merged, as it relies on proper Devicetree. --- drivers/power/supply/max17042_battery.c | 2 +- 1 file

[PATCH 05/18] ARM: dts: exynos: correct PMIC interrupt trigger level on Midas family

2020-12-10 Thread Krzysztof Kozlowski
is shared so using level sensitive interrupt is here especially important to avoid races. Fixes: 15dfdfad2d4a ("ARM: dts: Add basic dts for Exynos4412-based Trats 2 board") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-midas.dtsi | 2 +- 1 file changed, 1 insertion(+),

[PATCH 08/18] ARM: dts: exynos: correct PMIC interrupt trigger level on SMDK5250

2020-12-10 Thread Krzysztof Kozlowski
is shared so using level sensitive interrupt is here especially important to avoid races. Fixes: 47580e8d94c2 ("ARM: dts: Specify MAX77686 pmic interrupt for exynos5250-smdk5250") Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +- 1 file changed, 1 inser

[PATCH 02/18] ARM: dts: exynos: correct fuel gauge interrupt trigger level on P4 Note family

2020-12-10 Thread Krzysztof Kozlowski
Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos4412-p4note.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi index b2f9d5448a18..5fe371543cbb 100644 --- a/arch/arm/boot/dts/

[PATCH] arm64: dts: exynos: correct S3FWRN5 NFC interrupt trigger level on TM2

2020-12-10 Thread Krzysztof Kozlowski
The S3FWRN5 datasheet describe the interrupt line as rising edge. The current configuration as level high, could cause spurious interrupts. Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] regulator: max14577: Add proper module aliases strings

2020-12-10 Thread Krzysztof Kozlowski
gt; --- > drivers/regulator/max14577-regulator.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 net-next 2/2] nfc: s3fwrn5: Remove hard coded interrupt trigger type from the i2c module

2020-12-10 Thread Krzysztof Kozlowski
On Tue, Dec 08, 2020 at 11:10:12PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > For the flexible control of interrupt trigger type, remove the hard coded > interrupt trigger type in the i2c module. The trigger type will be loaded > from a dts. > > Signed-off-by: Bongsu Jeon > --- >

Re: Broken /usr/bin/env (invalid option)

2020-12-09 Thread Krzysztof Kozlowski
On Wed, 9 Dec 2020 at 14:13, Dominique Martinet wrote: > > Krzysztof Kozlowski wrote on Wed, Dec 09, 2020: > > Your commit ece075366294 ("ld-version: use /usr/bin/env awk for > > shebank") breaks current linux-next on Ubuntu 16.04: > > > > $ make

Broken /usr/bin/env (invalid option)

2020-12-09 Thread Krzysztof Kozlowski
Hi Dominique, Your commit ece075366294 ("ld-version: use /usr/bin/env awk for shebank") breaks current linux-next on Ubuntu 16.04: $ make defconfig make[1]: Entering directory '/mnt/data2/linux/linux-upstream/out' GEN Makefile *** Default configuration is based on

Re: [PATCH v5 06/27] dt-bindings: mediatek: Add binding for mt8192 IOMMU

2020-12-09 Thread Krzysztof Kozlowski
r CCU0/1(camera control unit) is HW requirement. > > Signed-off-by: Yong Wu > Reviewed-by: Rob Herring > --- > .../bindings/iommu/mediatek,iommu.yaml| 18 +- > include/dt-bindings/memory/mt8192-larb-port.h | 240 ++ > 2 files changed, 257 ins

Re: [PATCH v5 05/27] dt-bindings: memory: mediatek: Rename header guard for SMI header file

2020-12-09 Thread Krzysztof Kozlowski
On Wed, Dec 09, 2020 at 04:00:40PM +0800, Yong Wu wrote: > Only rename the header guard for all the SoC larb port header file. > No funtional change. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Yong Wu > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v6 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

2020-12-08 Thread Krzysztof Kozlowski
On Wed, Dec 09, 2020 at 02:30:22AM +, Alice Guo (OSS) wrote: > Gentle ping.. and Krzysztof Kozlowski, do you agree? I did not know that you wait for something from my side. > > Best Regards, > Alice Guo > > > -Original Message- > > From: linux-arm-ker

Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

2020-12-08 Thread Krzysztof Kozlowski
On Tue, Dec 08, 2020 at 08:57:49AM +, S.j. Wang wrote: > > On Tue, Dec 08, 2020 at 08:44:51AM +, S.j. Wang wrote: > > > > > > > > > > > > > > On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski > > wrote: > > > &g

Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

2020-12-08 Thread Krzysztof Kozlowski
On Tue, Dec 08, 2020 at 08:44:51AM +, S.j. Wang wrote: > > > > > > > > > > On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote: > > > > > > On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > > > > &

Re: [PATCH v2 4/4] soc: samsung: exynos-chipid: convert to driver and merge exynos-asv

2020-12-08 Thread 'Krzysztof Kozlowski'
On Tue, Dec 08, 2020 at 12:31:23PM +0530, Pankaj Dubey wrote: > > > > -Original Message- > > From: Krzysztof Kozlowski > > Sent: Tuesday, December 8, 2020 12:35 AM > > To: Krzysztof Kozlowski ; linux-arm- > > ker...@lists.infradead.org; linux-samsung

Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

2020-12-08 Thread Krzysztof Kozlowski
On Tue, Dec 08, 2020 at 09:03:34AM +0100, Krzysztof Kozlowski wrote: > On Tue, Dec 08, 2020 at 03:16:35AM +, S.j. Wang wrote: > > Hi > > > > > > > > On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote: > > > > On Mon, Dec 07,

Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

2020-12-08 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 04:19:16PM -0800, Guenter Roeck wrote: > On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote: > > On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote: > > > Convert the Analog Devices ADM1275 bindings to dt-schema. >

Re: [PATCH 2/2] ARM: dts: aspeed: Add device tree for Ampere's Mt. Jade BMC

2020-12-08 Thread Krzysztof Kozlowski
On Tue, 8 Dec 2020 at 05:42, Joel Stanley wrote: > > On Tue, 8 Dec 2020 at 04:37, Quan Nguyen wrote: > > > > The Mt. Jade BMC is an ASPEED AST2500-based BMC for the Mt. Jade > > hardware reference platform with Ampere's Altra Processor Family. > > > > Reviewed-by: Andrew Jeffery > >

Re: [PATCH 1/2] dt-bindings: vendor-prefixes: Add an entry for AmpereComputing.com

2020-12-08 Thread Krzysztof Kozlowski
On Tue, 8 Dec 2020 at 05:41, Joel Stanley wrote: > > Hello Rob, > > On Tue, 8 Dec 2020 at 04:37, Quan Nguyen wrote: > > > > Add "ampere" entry for Ampere Computing LLC: amperecomputing.com > > > > Reviewed-by: Andrew Jeffery > > Reviewed-by: Joel Stanley > > Signed-off-by: Quan Nguyen > >

Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

2020-12-08 Thread Krzysztof Kozlowski
On Tue, Dec 08, 2020 at 03:16:35AM +, S.j. Wang wrote: > Hi > > > > > On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote: > > > On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > > > > Error log: > > > >

[PATCH v2 3/4] soc: samsung: exynos-chipid: order list of SoCs by name

2020-12-07 Thread Krzysztof Kozlowski
Bring some order to the list of SoCs. No functional change. Signed-off-by: Krzysztof Kozlowski --- drivers/soc/samsung/exynos-chipid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c index

[PATCH v2 4/4] soc: samsung: exynos-chipid: convert to driver and merge exynos-asv

2020-12-07 Thread Krzysztof Kozlowski
of work to be done early, when the kernel has to bring up critical devices. 5. Makes the Chip ID code defer-probe friendly, Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-exynos/Kconfig| 1 - drivers/soc/samsung/Kconfig | 12 ++--- drivers/soc/samsung/Makefile| 3

[PATCH v2 1/4] soc: samsung: exynos-asv: don't defer early on not-supported SoCs

2020-12-07 Thread Krzysztof Kozlowski
-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- drivers/soc/samsung/exynos-asv.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c index 8abf4dfaa5c5..f653e3533f0f 100644 --- a/drivers/s

[PATCH v2 2/4] soc: samsung: exynos-asv: handle reading revision register error

2020-12-07 Thread Krzysztof Kozlowski
If regmap_read() fails, the product_id local variable will contain random value from the stack. Do not try to parse such value and fail the ASV driver probe. Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver") Cc: Signed-off-by: Krzysztof Kozlowski --- d

[PATCH v2 0/4] soc: samsung: exynos-chipid and asv improvements

2020-12-07 Thread Krzysztof Kozlowski
vision register error". 4. Add patch "soc: samsung: exynos-chipid: convert to driver and merge exynos-asv". Best regards, Krzysztof Krzysztof Kozlowski (3): soc: samsung: exynos-asv: handle reading revision register error soc: samsung: exynos-chipid: order list of SoCs by name

[PATCH] soc: fix comment for freeing soc_dev_attr

2020-12-07 Thread Krzysztof Kozlowski
The soc_dev_attr is stored soc_dev->attr during soc_device_register() so it could be used till the cleanup call: soc_device_unregister(). Therefore this memory should not be freed prior, but after unregistering soc device. Signed-off-by: Krzysztof Kozlowski --- drivers/base/soc.c | 2 +- 1 f

[PATCH] MAINTAINERS: crypto: s5p-sss: drop Kamil Konieczny

2020-12-07 Thread Krzysztof Kozlowski
. Signed-off-by: Krzysztof Kozlowski --- .mailmap | 1 - Documentation/devicetree/bindings/crypto/samsung-slimsss.yaml | 1 - Documentation/devicetree/bindings/crypto/samsung-sss.yaml | 1 - MAINTAINERS

Re: [PATCH net-next] nfc: s3fwrn5: Change irqflags

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 10:39:01PM +0900, Bongsu Jeon wrote: > On Mon, Dec 7, 2020 at 8:51 PM Krzysztof Kozlowski wrote: > > > > On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wrote: > > > From: Bongsu Jeon > > > > > > change irqflags fro

Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 02:21:40PM +0100, Krzysztof Kozlowski wrote: > On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > > Error log: > > sysfs: cannot create duplicate filename '/bus/platform/devices/3000.bus' > > > > The spba bus name is d

Re: [PATCH] arm64: dts: imx8mn: Fix duplicate node name

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 02:53:24PM +0800, Shengjiu Wang wrote: > Error log: > sysfs: cannot create duplicate filename '/bus/platform/devices/3000.bus' > > The spba bus name is duplicate with aips bus name. > Refine spba bus name to fix this issue. > > Fixes: 970406eaef3a ("arm64: dts:

Re: [PATCH net-next] nfc: s3fwrn5: Change irqflags

2020-12-07 Thread Krzysztof Kozlowski
On Mon, Dec 07, 2020 at 08:38:27PM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > change irqflags from IRQF_TRIGGER_HIGH to IRQF_TRIGGER_RISING for stable > Samsung's nfc interrupt handling. 1. Describe in commit title/subject the change. Just a word "change irqflags" is not enough. 2.

Re: [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees

2020-12-05 Thread Krzysztof Kozlowski
On Fri, Dec 04, 2020 at 04:54:55PM +0100, Thierry Reding wrote: > On Tue, Dec 01, 2020 at 01:57:44AM +0300, Dmitry Osipenko wrote: > > 01.12.2020 00:17, Jon Hunter пишет: > > > Hi Dmitry, > > > > > > On 23/11/2020 00:27, Dmitry Osipenko wrote: > > >> Add EMC OPP DVFS tables and update board

Re: [PATCH 1/2] soc: samsung: exynos-chipid: order list of SoCs by name

2020-12-05 Thread Krzysztof Kozlowski
On Wed, 2 Dec 2020 21:59:54 +0200, Krzysztof Kozlowski wrote: > Bring some order to the list of SoCs. No functional change. Applied, thanks! [1/2] soc: samsung: exynos-chipid: order list of SoCs by name [2/2] soc: samsung: exynos-chipid: initialize later - with arch_initcall com

Re: [PATCH] memory: jz4780_nemc: Fix potential NULL dereference in jz4780_nemc_probe()

2020-12-05 Thread Krzysztof Kozlowski
@@ > expression pdev, res, n, t, e, e1, e2; > @@ > > [...] Applied, thanks! [1/1] memory: jz4780_nemc: Fix potential NULL dereference in jz4780_nemc_probe() commit: 4bfa07300b9334b487ed4f3d4901c35ebb31b7ca Best regards, -- Krzysztof Kozlowski

Re: [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused

2020-12-05 Thread Krzysztof Kozlowski
s_clkout_suspend(struct device *dev) > |^ > > [...] Applied, thanks! [1/1] clk: samsung: mark PM functions as __maybe_unused commit: 4c44274ee457e3f7012dc532c8c9cc8964a82612 Best regards, -- Krzysztof Kozlowski

Re: [PATCH] memory: ti-emif-sram: only build for ARMv7

2020-12-05 Thread Krzysztof Kozlowski
t the target machines to configurations that have ARMv7 enabled. Applied, thanks! [1/1] memory: ti-emif-sram: only build for ARMv7 commit: d77d22d701b0471584abe1871570bb43deb6e3c4 Best regards, -- Krzysztof Kozlowski

Re: [PATCH v11 00/10] Introduce memory interconnect for NVIDIA Tegra SoCs

2020-12-05 Thread Krzysztof Kozlowski
rconnect framework commit: 01a51facb74fb337ff9fe734caa85dd6e246ef48 Best regards, -- Krzysztof Kozlowski

Re: [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused

2020-12-04 Thread Krzysztof Kozlowski
used-function] >210 | static int exynos_clkout_suspend(struct device *dev) >|^ > > Mark them as __maybe_unused to shut up the otherwise harmless warning. > > Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module > driv

Re: [PATCH v2 net-next] nfc: s3fwrn5: skip the NFC bootloader mode

2020-12-04 Thread Krzysztof Kozlowski
. >- change the skip handling code. Patch is now much cleaner and smaller. Thanks. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > > drivers/nfc/s3fwrn5/core.c | 23 +-- > drivers/nfc/s3fwrn5/firmware.c | 11 +-- > drivers/nfc/

Re: [PATCH] clk: samsung: mark PM functions as __maybe_unused

2020-12-04 Thread Krzysztof Kozlowski
On Thu, Dec 03, 2020 at 11:53:11PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > I understand this happens with !PM builds. It would be good to mention this in commit msg. With commit msg improved: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > drivers/clk/sa

Re: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests

2020-12-04 Thread Krzysztof Kozlowski
On Mon, Nov 16, 2020 at 07:54:03PM +, Paul Cercueil wrote: > Hi Krzysztof, > > Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski a écrit > : > > The Ingenic DRM uses Common Clock Framework thus it cannot be built on > > platforms without it (e.g. compile

Re: [PATCH net-next] nfc: s3fwrn5: skip the NFC bootloader mode

2020-12-03 Thread Krzysztof Kozlowski
On Fri, Dec 04, 2020 at 12:39:50AM +0900, Bongsu Jeon wrote: > From: Bongsu Jeon > > If there isn't proper NFC firmware image, > Bootloader mode will be skipped. Wrap your commit msg as described in submitting patches (so at 75 character). > > Signed-off-by: Bongsu Jeon > --- >

Re: [PATCH v2 4/5] amba: Make the remove callback return void

2020-12-03 Thread Krzysztof Kozlowski
ers/input/serio/ambakmi.c | 3 +-- > > drivers/memory/pl172.c | 4 +--- > > drivers/memory/pl353-smc.c | 4 +--- For the memory: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes

2020-12-03 Thread Krzysztof Kozlowski
On Thu, Dec 03, 2020 at 10:41:54AM +, Lad, Prabhakar wrote: > Hi Krzysztof, > > On Thu, Nov 26, 2020 at 7:11 PM Lad Prabhakar > wrote: > > > > Hi All, > > > > This patch series fixes trivial issues in RPC-IF driver. > > > > Changes for v2: > > * Balanced PM in rpcif_disable_rpm > > * Fixed

Re: [PATCH 3/3] ARM: dts: exynos: Fix charging regulator voltage and current for i9100

2020-12-03 Thread Krzysztof Kozlowski
On Thu, Dec 03, 2020 at 10:23:01AM +0200, Krzysztof Kozlowski wrote: > On Thu, Dec 03, 2020 at 05:46:03AM +, Timon Bätz wrote: > > On Wednesday, December 2, 2020 11:04 PM, Krzysztof Kozlowski > > wrote: > > > > > On Wed, Dec 02, 2020 at 09:07:28PM +, Timon

Re: [PATCH 3/3] ARM: dts: exynos: Fix charging regulator voltage and current for i9100

2020-12-03 Thread Krzysztof Kozlowski
On Thu, Dec 03, 2020 at 05:46:03AM +, Timon Bätz wrote: > On Wednesday, December 2, 2020 11:04 PM, Krzysztof Kozlowski > wrote: > > > On Wed, Dec 02, 2020 at 09:07:28PM +, Timon Baetz wrote: > > > > > Set CHARGER current and CHARGER_CV voltage according

Re: [PATCH 3/3] ARM: dts: exynos: Fix charging regulator voltage and current for i9100

2020-12-02 Thread Krzysztof Kozlowski
On Wed, Dec 02, 2020 at 09:07:28PM +, Timon Baetz wrote: > Set CHARGER current and CHARGER_CV voltage according to Galaxy S2 kernel > fork. > > Signed-off-by: Timon Baetz > --- > arch/arm/boot/dts/exynos4210-i9100.dts | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

<    3   4   5   6   7   8   9   10   11   12   >