Re: [PATCH] drm/amdkfd: fix a potential NULL pointer dereference

2019-09-19 Thread Kuehling, Felix
On 2019-09-18 12:30 p.m., Allen Pais wrote: > alloc_workqueue is not checked for errors and as a result, > a potential NULL dereference could occur. > > Signed-off-by: Allen Pais > --- > drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/dri

Re: [PATCH v15 11/17] drm/amdgpu, arm64: untag user pointers

2019-05-07 Thread Kuehling, Felix
s patch untag user pointers in > amdgpu_gem_userptr_ioctl() for the GEM case and in amdgpu_amdkfd_gpuvm_ > alloc_memory_of_gpu() for the KFD case. This also makes sure that an > untagged pointer is passed to amdgpu_ttm_tt_get_user_pages(), which uses > it for vma lookups. > > Suggested-by: Kuehling, Fel

Re: [PATCH 00/10] HMM updates for 5.1

2019-03-18 Thread Kuehling, Felix
For amdgpu I looked over the changes and they look reasonable to me. Philip Yang (CCed) already rebased amdgpu on top of Jerome's patches and is looking forward to using the new helpers and simplifying our driver code. Feel free to add my Acked-by to the patches. Regards,   Felix On 3/13/2019

Re: [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu

2019-01-31 Thread Kuehling, Felix
Thank you, Nathan. I applied your patch to amd-staging-drm-next. Sorry for the late response. I'm catching up with my email backlog after a vacation. Regards,   Felix On 2019-01-21 6:52 p.m., Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: war

Re: [PATCH] drm/amdgpu_vm: fix boolean expressions

2019-01-03 Thread Kuehling, Felix
On 2019-01-03 12:34 p.m., Gustavo A. R. Silva wrote: > Fix boolean expressions by using logical AND operator '&&' > instead of bitwise operator '&'. > > This issue was detected with the help of Coccinelle. > > Fixes: c8c5e569c5b0 ("drm/amdgpu: Consolidate visible vs. real vram check > v2.") Actual

Re: [RFC PATCH 00/14] Heterogeneous Memory System (HMS) and hbind()

2018-12-04 Thread Kuehling, Felix
On 2018-12-04 4:57 p.m., Jerome Glisse wrote: > On Tue, Dec 04, 2018 at 01:37:56PM -0800, Dave Hansen wrote: >> Yeah, our NUMA mechanisms are for managing memory that the kernel itself >> manages in the "normal" allocator and supports a full feature set on. >> That has a bunch of implications, lik