On Sun, 28 Feb 2021 11:38:54 +0100, Dario Binacchi wrote:
> Date: Sun, 28 Feb 2021 11:38:54 +0100
> From: Dario Binacchi
> To: linux-kernel@vger.kernel.org
> Cc: Federico Vaga , Alexander Stein
> , Dario Binacchi
> , "David S. Miller" , Jakub
> Kicinski , Marc Kleine-Budde , Oliver
> Hartkop
On Sun, 28 Feb 2021 11:38:52 +0100, Dario Binacchi wrote:
> According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use
> IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX).
>
> Signed-off-by: Dario Binacchi
> ---
>
> (no changes since v1)
>
> drivers/net/can/c_can/c_can.c | 2 +-
>
On di, 15 sep 2020 21:49:25 +0530, Manivannan Sadhasivam wrote:
> Hi,
>
> On Thu, Sep 10, 2020 at 07:08:00PM +0530, Manivannan Sadhasivam wrote:
> > Hello,
>
> Just a quick question: I don't see any activity on this specific driver for
> sometime (back in Martin days itself). Is it due to lack of
On ma, 22 jun 2020 14:54:15 +0200, Marc Kleine-Budde wrote:
> On 6/22/20 2:43 PM, Kurt Van Dijck wrote:
> > I get RX-0: FIFO overflows in listen-only mode (back-to-back burst of
> > the single other node).
>
> Single other node? Who's ACKing the CAN frames?
he
arded against load.
Kurt
On ma, 22 jun 2020 14:30:31 +0200, Kurt Van Dijck wrote:
>
> On ma, 22 jun 2020 12:55:41 +0200, Marc Kleine-Budde wrote:
> > On 6/22/20 12:25 PM, Kurt Van Dijck wrote:
> > > I got my board up with a 5.7, despite device-tree problems completely
> >
vger.kernel.org
> Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
> Thunderbird/68.9.0
>
> On 6/22/20 12:25 PM, Kurt Van Dijck wrote:
> > I got my board up with a 5.7, despite device-tree problems comp
Hey Marc,
On do, 18 jun 2020 14:35:28 +0200, Marc Kleine-Budde wrote:
> On 6/18/20 2:30 PM, Kurt Van Dijck wrote:
> > On do, 18 jun 2020 00:36:29 +0200, Marc Kleine-Budde wrote:
> >> On 6/17/20 6:59 PM, Kurt Van Dijck wrote:
> >>> I'm in the process of gettin
On do, 18 jun 2020 00:36:29 +0200, Marc Kleine-Budde wrote:
> On 6/17/20 6:59 PM, Kurt Van Dijck wrote:
> > I'm in the process of getting a Variscite imx8m mini SOM online, with
>
> Have your heard about the imx8m plus? It has CAN cores! We have a board in the
&
On do, 11 jun 2020 18:26:19 +0200, Marc Kleine-Budde wrote:
> On 6/10/20 9:44 AM, Manivannan Sadhasivam wrote:
> > Hello,
> >
> > This series adds CAN network driver support for Microchip MCP25XXFD CAN
> > Controller with MCP2517FD as the target controller version. This series is
> > mostly inspir
On di, 01 okt 2019 09:40:57 +0200, Kurt Van Dijck wrote:
> On do, 26 sep 2019 08:50:51 +, Jeroen Hofstee wrote:
> > While the state is update when the error counters increase and decrease,
> > there is no event when the bus recovers and the error counters decrease
> > aga
he C_CAN module doesn't have the software reset.
>
> [1]
> http://www.bosch-semiconductors.com/media/ip_modules/pdf_2/c_can_fd8/users_manual_c_can_fd8_r210_1.pdf
>
> Signed-off-by: Jeroen Hofstee
I observed no problems after applying the patch.
Tested-by: Kurt Van Dijck
e ERROR_PASSIVE -> ERROR_WARNING ->
> ERROR_ACTIVE instead of directly to ERROR_ACTIVE again.
This looks like a proper thing to do
Acked-by: Kurt Van Dijck
Sorry, wrong list
Hey,
I work on a beaglebone-like board using the AM335x can chip, with an RT
kernel.
The can irq task is by default rt prio 50.
I have a process running on rt prio 10 using CAN_RAW socket.
I see that softirqd runs on regular timeslicing.
Do CAN frames need to pass through the softirqd in order t
> Hi Kurt,
>
> On 07/28/2017 09:41 PM, Kurt Van Dijck wrote:
>
> >>The transceiver is an analog device that needs to support faster
> >>switching frequency (FETs) including minimizing delay to support CAN-FD
> >>ie higher bitrate. From the transceiver pe
>
> On 07/28/2017 01:33 PM, Oliver Hartkopp wrote:
> > Hi Kurt,
> >
> > On 07/28/2017 03:02 PM, Kurt Van Dijck wrote:
> >
> >>>> The word 'max-arbitration-bitrate' makes the difference very clear.
> >>>
> >>> I thi
>
> On 07/28/2017 06:57 AM, Kurt Van Dijck wrote:
>
> >So while _a_ transceiver may be spec'd to 1MBit during arbitration,
> >CAN FD packets may IMHO exceed that speed during data phase.
>
> When the bitrate is limited to 1Mbit/s you are ONLY allowed to use 1
>
> On 07/27/2017 01:47 PM, Oliver Hartkopp wrote:
> > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote:
> >>
> >
> >> I'm fine with switching to using bitrate instead of speed. Kurk was
> >> originally the one that suggested to use the term arbitration and data
> >> since thats how the spec r
looks way more clear to me.
That's my opinion.
The important things, like the contents of the functions, look good.
Kind regards,
Kurt Van Dijck
--- Original message ---
> Date: Mon, 8 Aug 2016 14:28:39 +0200
> From: Wolfgang Grandegger
>
[...]
> >>>+
> >>>+ if (!(cf->can_id & CAN_RTR_FLAG)) {
> >>>+ writel(data[0], &cf_buf->data[0]);
> >>>+ writel(data[1], &cf_buf->data[1]);
> >>
> >>Why do you not check cf->can_dlc h
ror: 'cleanup_module' aliased
> to undefined symbol '&softingcs_driver_exit'
>
> Caused by commit a750fa4edd9e ("softingcs: use module_pcmcia_driver").
>
> I have used the char-misc tree form next-20130315 for today.
I have no idea what I've over
can: add LED trigger support
> can: mcp251x: add LED trigger support
> can: sja1000: add LED trigger support
>
> Kurt Van Dijck (2):
> can: export a safe netdev_priv wrapper for candev
> can: rename LED trigger name on netdev renames
>
> drivers/net/can/Kconfig
On Mon, Dec 17, 2012 at 08:28:48AM +0100, Bernd Krumboeck wrote:
> Hello Fabio!
>
> Am 2012-12-16 12:08, schrieb Fabio Baltieri:
> >This patch implements the functions to add two LED triggers, named
> >-tx and -rx, to a canbus device driver.
> >
> >Triggers are called from specific handlers by eac
On Tue, Sep 11, 2012 at 09:13:14AM +0200, Fabio Baltieri wrote:
> Hi Oliver,
>
> On Tue, Sep 11, 2012 at 07:42:19AM +0200, Oliver Hartkopp wrote:
> > On 10.09.2012 22:08, Kurt Van Dijck wrote:
> > > But the initial name must have been set properly already in that ca
On Mon, Sep 10, 2012 at 10:08:44PM +0200, Kurt Van Dijck wrote:
> On Mon, Sep 10, 2012 at 09:01:21PM +0200, Oliver Hartkopp wrote:
> > On 10.09.2012 20:40, Fabio Baltieri wrote:
> >
> > > On Mon, Sep 10, 2012 at 08:25:50PM +0200, Oliver Hartkopp wrote:
> > >>
On Mon, Sep 10, 2012 at 09:01:21PM +0200, Oliver Hartkopp wrote:
> On 10.09.2012 20:40, Fabio Baltieri wrote:
>
> > On Mon, Sep 10, 2012 at 08:25:50PM +0200, Oliver Hartkopp wrote:
> >> On 10.09.2012 16:28, Kurt Van Dijck wrote:
> >>> Fabio,
> >>>
&
LED trigger name according to the CAN device name when
the latter changes.
v1 - Kurt Van Dijck
v2 - Fabio Baltieri
- remove rename blocking if trigger is bound
- use led-subsystem function for the actual rename (still WiP)
- call init/exit functions from dev.c
v3 - Kurt Van Dijck
- safe operation for
can: export a safe netdev_priv wrapper for candev
In net_device notifier calls, it was impossible to determine
if a CAN device is based on candev in a safe way.
This patch adds such test in order to access candev storage
from within those notifiers.
Signed-off-by: Kurt Van Dijck
Acked-by
LED trigger name according to the CAN device name when
the latter changes.
v1 - Kurt Van Dijck
v2 - Fabio Baltieri
- remove rename blocking if trigger is bound
- use led-subsystem function for the actual rename (still WiP)
- call init/exit functions from dev.c
v3 - Kurt Van Dijck
- safe operation for
can: export a safe netdev_priv wrapper for candev
In net_device notifier calls, it was impossible to determine
if a CAN device is based on candev in a safe way.
This patch adds such test in order to access candev storage
from within those notifiers.
Signed-off-by: Kurt Van Dijck
diff --git a
Hey Fabio,
On Sun, Sep 09, 2012 at 05:27:54PM +0200, Fabio Baltieri wrote:
> Implements a led_trigger_rename() function to rename a trigger with
> proper locking.
This is the way to go.
Maybe add 'default_trigger' tests? In a later phase?
>
> This also implies that "name" in "struct led_trigger"
On Thu, Sep 06, 2012 at 10:46:00PM +0200, Fabio Baltieri wrote:
> On Thu, Sep 06, 2012 at 09:31:07PM +0200, Oliver Hartkopp wrote:
> > >> +
> > >> +/*
> > >> + * NETDEV rename notifier to rename the associated led triggers too
> > >> + */
> > >> +static int can_led_notifier(struct notifier_block *n
On Thu, Sep 06, 2012 at 10:57:28PM +0200, Fabio Baltieri wrote:
> On Thu, Sep 06, 2012 at 05:11:58PM +0200, Kurt Van Dijck wrote:
> > > > I also think that led triggers should be available.
> > >
> > > Right, that's why I think the only way is to use d
On Thu, Sep 06, 2012 at 01:17:39PM +0200, Fabio Baltieri wrote:
> Hi Kurt,
>
> On Thu, Sep 6, 2012 at 12:33 PM, Kurt Van Dijck wrote:
> > On Tue, Sep 04, 2012 at 10:15:53PM +0200, Fabio Baltieri wrote:
> >> On Tue, Sep 04, 2012 at 09:11:28AM +0200, Kurt Van Dijck wrote
On Tue, Sep 04, 2012 at 10:15:53PM +0200, Fabio Baltieri wrote:
> On Tue, Sep 04, 2012 at 09:11:28AM +0200, Kurt Van Dijck wrote:
> > On Mon, Sep 03, 2012 at 10:54:49PM +0200, Oliver Hartkopp wrote:
> > > On 03.09.2012 20:29, Fabio Baltieri wrote:
> > >
> > >
when
the latter changes.
This patch is meant as illustration only.
In case of VCAN device rename, a segmentation fault will occur.
Signed-off-by: Kurt Van Dijck
---
drivers/net/can/led.c | 57 +
1 file changed, 57 insertions(+)
diff --git a
On Mon, Sep 03, 2012 at 10:54:49PM +0200, Oliver Hartkopp wrote:
> On 03.09.2012 20:29, Fabio Baltieri wrote:
>
> > On Mon, Sep 03, 2012 at 08:13:35PM +0200, Kurt Van Dijck wrote:
> >> On Mon, Sep 03, 2012 at 02:40:39PM +0200, Marc Kleine-Budde wrote:
> >>> The
On Mon, Sep 03, 2012 at 02:40:39PM +0200, Marc Kleine-Budde wrote:
> On 08/25/2012 12:01 AM, Fabio Baltieri wrote:
> > Hello Kurt,
> >
> > On Fri, Aug 24, 2012 at 02:42:48PM +0200, Kurt Van Dijck wrote:
> >> On Fri, Aug 24, 2012 at 01:28:16PM +0200, Marc Kleine-Budde
On Sat, Aug 25, 2012 at 12:01:42AM +0200, Fabio Baltieri wrote:
> Hello Kurt,
>
> On Fri, Aug 24, 2012 at 02:42:48PM +0200, Kurt Van Dijck wrote:
> > On Fri, Aug 24, 2012 at 01:28:16PM +0200, Marc Kleine-Budde wrote:
> > > On 08/24/2012 07:10 AM, Kurt Van Di
On Fri, Aug 24, 2012 at 01:28:16PM +0200, Marc Kleine-Budde wrote:
> On 08/24/2012 07:10 AM, Kurt Van Dijck wrote:
> > Hello,
> >
> > I find the CAN led triggers an interesting thing.
> >
> > And then, this scenario fell crossed my mind:
> > Imagine I do:
gt; + */
> +
> +#ifndef CAN_LED_H
> +#define CAN_LED_H
> +
> +#include
> +#include
> +
> +enum can_led_event {
> + CAN_LED_EVENT_OPEN,
> + CAN_LED_EVENT_STOP,
> + CAN_LED_EVENT_TX,
> + CAN_LED_EVENT_RX,
> +};
> +
> +#ifdef CONFIG_CAN_LE
I see the problem, and the solution. You may add
Acked-by: Kurt Van Dijck
On Sat, Jul 14, 2012 at 06:43:04PM +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Typically, the return value desired for the failure of a function with an
> integer return value is a negative intege
42 matches
Mail list logo
