RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

2015-10-06 Thread Kweh, Hock Leong
> -Original Message- > From: Bryan O'Donoghue [mailto:pure.lo...@nexus-software.ie] > Sent: Tuesday, October 06, 2015 10:54 PM > >> > >> Aside from that, I'm curious which types of capsules you've used here > >> too - does it include the MFH header ? Keep in mind the initial > >> firmware

RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

2015-10-06 Thread Kweh, Hock Leong
> -Original Message- > From: Bryan O'Donoghue [mailto:pure.lo...@nexus-software.ie] > Sent: Tuesday, October 06, 2015 5:27 AM > > Wilson - trying to test this out on a Galileo Gen2 - which branch are you > doing > this against ? > > I can apply the first patch you're proposing to squash

RE: [PATCH v6 2/2] efi: a misc char interface for user to update efi firmware

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Tuesday, October 06, 2015 3:06 AM > > >> And what if cap_hdr isn't written yet? > > > > This design mainly targeting a simplest interface that user could > > upload efi capsule in a single command action: cat

RE: [PATCH v6 2/2] efi: a misc char interface for user to update efi firmware

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Sunday, October 04, 2015 7:16 AM > > + > > + /* setup capsule binary info structure */ > > + if (cap_info.header_obtained == 0 && cap_info.index == 0) { > > + efi_capsule_header_t

RE: [PATCH v6 0/2] Enable capsule loader interface for efi firmware updating

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, October 03, 2015 5:06 PM > On Sat, Oct 03, 2015 at 03:18:41AM +, Kweh, Hock Leong wrote: > > > What does the error case look like? A standard glibc message about &

RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, October 05, 2015 9:14 PM > > So this one is still a separate patch. > > If you're going to ignore review comments, maybe I should stop wasting my > time reviewing your stuff... > > -- > Regards/Gruss, >

[PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

2015-10-05 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" This patch export efi_capsule_supported() function symbol for capsule kernel module to use. Cc: Matt Fleming Signed-off-by: Kweh, Hock Leong --- drivers/firmware/efi/capsule.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/efi/c

[PATCH v7 2/2] efi: a misc char interface for user to update efi firmware

2015-10-05 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Introducing a kernel module to expose capsule loader interface (misc char device file note) for user to upload capsule binaries. Example method to load the capsule binary: cat firmware.bin > /dev/efi_capsule_loader Cc: Matt Fleming Signed-off-by: Kwe

[PATCH v7 0/2] Enable capsule loader interface for efi firmware updating

2015-10-05 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Dear maintainers & communities, This patchset is created on top of Matt's patchset: 1.)https://lkml.org/lkml/2014/10/7/390 "[PATCH 1/2] efi: Move efi_status_to_err() to efi.h" 2.)https://lkml.org/lkml/2014/10/7/391 "[PATCH 2/2] efi: Capsu

RE: [PATCH v6 2/2] efi: a misc char interface for user to update efi firmware

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Tuesday, October 06, 2015 3:06 AM > > >> And what if cap_hdr isn't written yet? > > > > This design mainly targeting a simplest interface that user could > > upload efi capsule in a single command action: cat

[PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

2015-10-05 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> This patch export efi_capsule_supported() function symbol for capsule kernel module to use. Cc: Matt Fleming <matt.flem...@intel.com> Signed-off-by: Kweh, Hock Leong <hock.leong.k...@intel.com> --- drivers/firmwa

[PATCH v7 2/2] efi: a misc char interface for user to update efi firmware

2015-10-05 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> Introducing a kernel module to expose capsule loader interface (misc char device file note) for user to upload capsule binaries. Example method to load the capsule binary: cat firmware.bin > /dev/efi_capsule_loader Cc: Matt

[PATCH v7 0/2] Enable capsule loader interface for efi firmware updating

2015-10-05 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> Dear maintainers & communities, This patchset is created on top of Matt's patchset: 1.)https://lkml.org/lkml/2014/10/7/390 "[PATCH 1/2] efi: Move efi_status_to_err() to efi.h" 2.)https://lkml.org/lkml/2014/10/7

RE: [PATCH v7 1/2] efi: export efi_capsule_supported() function symbol

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Monday, October 05, 2015 9:14 PM > > So this one is still a separate patch. > > If you're going to ignore review comments, maybe I should stop wasting my > time reviewing your stuff... > > -- > Regards/Gruss, >

RE: [PATCH v6 0/2] Enable capsule loader interface for efi firmware updating

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, October 03, 2015 5:06 PM > On Sat, Oct 03, 2015 at 03:18:41AM +, Kweh, Hock Leong wrote: > > > What does the error case look like? A standard glibc message about &

RE: [PATCH v6 2/2] efi: a misc char interface for user to update efi firmware

2015-10-05 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Sunday, October 04, 2015 7:16 AM > > + > > + /* setup capsule binary info structure */ > > + if (cap_info.header_obtained == 0 && cap_info.index == 0) { > > + efi_capsule_header_t

RE: [PATCH v6 0/2] Enable capsule loader interface for efi firmware updating

2015-10-02 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, October 03, 2015 1:37 AM > To: Kweh, Hock Leong > Cc: Matt Fleming; Greg Kroah-Hartman; Ong, Boon Leong; LKML; linux- > e...@vger.kernel.org; Sam Protsenko; Peter Jones; Andy Lutom

RE: [PATCH v6 1/2] efi: export efi_capsule_supported() function symbol

2015-10-02 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, October 03, 2015 1:37 AM > To: Kweh, Hock Leong > Cc: Matt Fleming; Greg Kroah-Hartman; Ong, Boon Leong; LKML; linux- > e...@vger.kernel.org; Sam Protsenko; Peter Jones; Andy Lutom

RE: [PATCH v6 1/2] efi: export efi_capsule_supported() function symbol

2015-10-02 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, October 03, 2015 1:37 AM > To: Kweh, Hock Leong > Cc: Matt Fleming; Greg Kroah-Hartman; Ong, Boon Leong; LKML; linux- > e...@vger.kernel.org; Sam Protsenko; Peter Jones; Andy Lutom

RE: [PATCH v6 0/2] Enable capsule loader interface for efi firmware updating

2015-10-02 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Saturday, October 03, 2015 1:37 AM > To: Kweh, Hock Leong > Cc: Matt Fleming; Greg Kroah-Hartman; Ong, Boon Leong; LKML; linux- > e...@vger.kernel.org; Sam Protsenko; Peter Jones; Andy Lutom

[PATCH v6 1/2] efi: export efi_capsule_supported() function symbol

2015-10-01 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" This patch export efi_capsule_supported() function symbol for capsule kernel module to use. Cc: Matt Fleming Signed-off-by: Kweh, Hock Leong --- drivers/firmware/efi/capsule.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/efi/c

[PATCH v6 0/2] Enable capsule loader interface for efi firmware updating

2015-10-01 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Dear maintainers & communities, This patchset is created on top of Matt's patchset: 1.)https://lkml.org/lkml/2014/10/7/390 "[PATCH 1/2] efi: Move efi_status_to_err() to efi.h" 2.)https://lkml.org/lkml/2014/10/7/391 "[PATCH 2/2] efi: Capsu

[PATCH v6 2/2] efi: a misc char interface for user to update efi firmware

2015-10-01 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Introducing a kernel module to expose capsule loader interface (misc char device file note) for user to upload capsule binaries. Example method to load the capsule binary: cat firmware.bin > /dev/efi_capsule_loader Cc: Matt Fleming Signed-off-by: Kwe

[PATCH v6 0/2] Enable capsule loader interface for efi firmware updating

2015-10-01 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> Dear maintainers & communities, This patchset is created on top of Matt's patchset: 1.)https://lkml.org/lkml/2014/10/7/390 "[PATCH 1/2] efi: Move efi_status_to_err() to efi.h" 2.)https://lkml.org/lkml/2014/10/7

[PATCH v6 2/2] efi: a misc char interface for user to update efi firmware

2015-10-01 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> Introducing a kernel module to expose capsule loader interface (misc char device file note) for user to upload capsule binaries. Example method to load the capsule binary: cat firmware.bin > /dev/efi_capsule_loader Cc: Matt

[PATCH v6 1/2] efi: export efi_capsule_supported() function symbol

2015-10-01 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" <hock.leong.k...@intel.com> This patch export efi_capsule_supported() function symbol for capsule kernel module to use. Cc: Matt Fleming <matt.flem...@intel.com> Signed-off-by: Kweh, Hock Leong <hock.leong.k...@intel.com> --- drivers/firmwa

RE: [PATCH v5 2/2] efi: a misc char interface for user to update efi firmware

2015-09-02 Thread Kweh, Hock Leong
; > > > Example method to load the capsule binary: > > cat firmware.bin > /dev/efi_capsule_loader > > OK interesting, we're going down the misc char device route - Andy > might be happier, even if there is no ioctl(2) support. > > > Cc: Matt Fleming >

RE: [PATCH v5 2/2] efi: a misc char interface for user to update efi firmware

2015-09-02 Thread Kweh, Hock Leong
; > > > Example method to load the capsule binary: > > cat firmware.bin > /dev/efi_capsule_loader > > OK interesting, we're going down the misc char device route - Andy > might be happier, even if there is no ioctl(2) support. > > > Cc: Matt Fleming <matt

[PATCH v5 1/2] efi: export efi_capsule_supported() function symbol

2015-08-20 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" This patch export efi_capsule_supported() function symbol for capsule kernel module to use. Cc: Matt Fleming Signed-off-by: Kweh, Hock Leong --- drivers/firmware/efi/capsule.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/firmware/efi/c

[PATCH v5 2/2] efi: a misc char interface for user to update efi firmware

2015-08-20 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Introducing a kernel module to expose capsule loader interface (misc char device file note) for user to upload capsule binaries. Example method to load the capsule binary: cat firmware.bin > /dev/efi_capsule_loader Cc: Matt Fleming Signed-off-by: Kwe

[PATCH v5 0/2] Enable capsule loader interface for efi firmware

2015-08-20 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Dear maintainers & communities, This patchset is created on top of Matt's patchset: 1.)https://lkml.org/lkml/2014/10/7/390 "[PATCH 1/2] efi: Move efi_status_to_err() to efi.h" 2.)https://lkml.org/lkml/2014/10/7/391 "[PATCH 2/2] efi: Capsu

[PATCH v5 0/2] Enable capsule loader interface for efi firmware

2015-08-20 Thread Kweh, Hock Leong
From: Kweh, Hock Leong hock.leong.k...@intel.com Dear maintainers communities, This patchset is created on top of Matt's patchset: 1.)https://lkml.org/lkml/2014/10/7/390 [PATCH 1/2] efi: Move efi_status_to_err() to efi.h 2.)https://lkml.org/lkml/2014/10/7/391 [PATCH 2/2] efi: Capsule update

[PATCH v5 1/2] efi: export efi_capsule_supported() function symbol

2015-08-20 Thread Kweh, Hock Leong
From: Kweh, Hock Leong hock.leong.k...@intel.com This patch export efi_capsule_supported() function symbol for capsule kernel module to use. Cc: Matt Fleming matt.flem...@intel.com Signed-off-by: Kweh, Hock Leong hock.leong.k...@intel.com --- drivers/firmware/efi/capsule.c |1 + 1 file

[PATCH v5 2/2] efi: a misc char interface for user to update efi firmware

2015-08-20 Thread Kweh, Hock Leong
From: Kweh, Hock Leong hock.leong.k...@intel.com Introducing a kernel module to expose capsule loader interface (misc char device file note) for user to upload capsule binaries. Example method to load the capsule binary: cat firmware.bin /dev/efi_capsule_loader Cc: Matt Fleming matt.flem

RE: [RFC 0/3] Add capsule update using error on close semantics

2015-04-30 Thread Kweh, Hock Leong
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Thursday, April 30, 2015 7:08 AM > To: linux-...@vger.kernel.org > Cc: Kweh, Hock Leong; LKML; Andy Lutomirski; Greg Kroah-Hartman; Peter > Jones > Subject: [RFC 0/

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-30 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Thursday, April 30, 2015 2:41 AM > > On Wed, Apr 29, 2015 at 4:23 AM, Kweh, Hock Leong > wrote: > > > > Dear communities, > > > > I agree with James. Due to

RE: [RFC 0/3] Add capsule update using error on close semantics

2015-04-30 Thread Kweh, Hock Leong
-Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Thursday, April 30, 2015 7:08 AM To: linux-...@vger.kernel.org Cc: Kweh, Hock Leong; LKML; Andy Lutomirski; Greg Kroah-Hartman; Peter Jones Subject: [RFC 0/3] Add capsule update using error

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-30 Thread Kweh, Hock Leong
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] Sent: Thursday, April 30, 2015 2:41 AM On Wed, Apr 29, 2015 at 4:23 AM, Kweh, Hock Leong hock.leong.k...@intel.com wrote: Dear communities, I agree with James. Due to different people may have different

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-29 Thread Kweh, Hock Leong
; > > On Mon, 2015-04-27 at 14:59 -0700, Andy Lutomirski wrote: > > >> On Fri, Apr 24, 2015 at 8:16 AM, James Bottomley > > >> wrote: > > >> > On Fri, 2015-04-24 at 02:14 +, Kweh, Hock Leong wrote: > > >> >> &g

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-29 Thread Kweh, Hock Leong
: On Mon, 2015-04-27 at 14:59 -0700, Andy Lutomirski wrote: On Fri, Apr 24, 2015 at 8:16 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2015-04-24 at 02:14 +, Kweh, Hock Leong wrote: -Original Message- From: James Bottomley

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-23 Thread Kweh, Hock Leong
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Thursday, April 23, 2015 10:10 PM > > On Thu, 2015-04-23 at 08:30 +0000, Kweh, Hock Leong wrote: > > > -Original Message- > > > From: James

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-23 Thread Kweh, Hock Leong
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Wednesday, April 22, 2015 11:19 PM > > > Yes, I think we've all agreed we can do it ... it's now a question of whether > we > can stomach the ick factor of actually initiating a

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-23 Thread Kweh, Hock Leong
-Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Wednesday, April 22, 2015 11:19 PM Yes, I think we've all agreed we can do it ... it's now a question of whether we can stomach the ick factor of actually initiating a transaction in

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-23 Thread Kweh, Hock Leong
-Original Message- From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] Sent: Thursday, April 23, 2015 10:10 PM On Thu, 2015-04-23 at 08:30 +, Kweh, Hock Leong wrote: -Original Message- From: James Bottomley [mailto:james.bottom

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-20 Thread Kweh, Hock Leong
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, April 20, 2015 10:43 PM > > On Mon, Apr 20, 2015 at 03:28:32AM +0000, Kweh, Hock Leong wrote: > > Regarding the 'reboot require' status, is it critical to have a 1 to

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-20 Thread Kweh, Hock Leong
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Monday, April 20, 2015 10:43 PM On Mon, Apr 20, 2015 at 03:28:32AM +, Kweh, Hock Leong wrote: Regarding the 'reboot require' status, is it critical to have a 1 to 1 status match

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-19 Thread Kweh, Hock Leong
> -Original Message- > From: Matt Fleming [mailto:m...@codeblueprint.co.uk] > Sent: Friday, April 17, 2015 10:37 PM > > On Fri, 17 Apr, at 03:49:24PM, Greg KH wrote: > > > > Not really, the kernel namespace is what matters at that point in time. > > > > And maybe it does matter, I haven't

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-19 Thread Kweh, Hock Leong
-Original Message- From: Matt Fleming [mailto:m...@codeblueprint.co.uk] Sent: Friday, April 17, 2015 10:37 PM On Fri, 17 Apr, at 03:49:24PM, Greg KH wrote: Not really, the kernel namespace is what matters at that point in time. And maybe it does matter, I haven't thought

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-16 Thread Kweh, Hock Leong
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Wednesday, April 15, 2015 9:19 PM > > On Wed, Apr 15, 2015 at 11:32:29AM +0000, Kweh, Hock Leong wrote: > > > -Original Message- > > > Fro

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-16 Thread Kweh, Hock Leong
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Wednesday, April 15, 2015 9:19 PM On Wed, Apr 15, 2015 at 11:32:29AM +, Kweh, Hock Leong wrote: -Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-15 Thread Kweh, Hock Leong
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, April 14, 2015 10:09 PM > > On Tue, Apr 14, 2015 at 05:44:56PM +0800, Kweh, Hock Leong wrote: > > From: "Kweh, Hock Leong" > > > > Introduci

RE: [PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-15 Thread Kweh, Hock Leong
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Tuesday, April 14, 2015 10:09 PM On Tue, Apr 14, 2015 at 05:44:56PM +0800, Kweh, Hock Leong wrote: From: Kweh, Hock Leong hock.leong.k...@intel.com Introducing a kernel module to expose

[PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-13 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Introducing a kernel module to expose capsule loader interface for user to upload capsule binaries. This module leverage the request_firmware_direct_full_path() to obtain the binary at a specific path input by user. Example method to load the capsule binar

[PATCH v4 1/2] firmware_loader: introduce new API - request_firmware_direct_full_path()

2015-04-13 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Introduce this new API for loading firmware from a specific location instead of /lib/firmware/ by providing a full path to the firmware file. Cc: Ming Lei Cc: Matt Fleming Signed-off-by: Kweh, Hock Leong --- drivers/base/firmware_clas

[PATCH v4 0/2] Enable capsule loader interface for efi firmware updating

2015-04-13 Thread Kweh, Hock Leong
From: "Kweh, Hock Leong" Dear maintainers & communities, This patchset is created on top of "efi: Capsule update support" patch: http://permalink.gmane.org/gmane.linux.kernel.efi/4837 It expose a sysfs loader interface for user to upload the capsule binary and calling

[PATCH v4 0/2] Enable capsule loader interface for efi firmware updating

2015-04-13 Thread Kweh, Hock Leong
From: Kweh, Hock Leong hock.leong.k...@intel.com Dear maintainers communities, This patchset is created on top of efi: Capsule update support patch: http://permalink.gmane.org/gmane.linux.kernel.efi/4837 It expose a sysfs loader interface for user to upload the capsule binary and calling

[PATCH v4 1/2] firmware_loader: introduce new API - request_firmware_direct_full_path()

2015-04-13 Thread Kweh, Hock Leong
From: Kweh, Hock Leong hock.leong.k...@intel.com Introduce this new API for loading firmware from a specific location instead of /lib/firmware/ by providing a full path to the firmware file. Cc: Ming Lei ming@canonical.com Cc: Matt Fleming matt.flem...@intel.com Signed-off-by: Kweh, Hock

[PATCH v4 2/2] efi: an sysfs interface for user to update efi firmware

2015-04-13 Thread Kweh, Hock Leong
From: Kweh, Hock Leong hock.leong.k...@intel.com Introducing a kernel module to expose capsule loader interface for user to upload capsule binaries. This module leverage the request_firmware_direct_full_path() to obtain the binary at a specific path input by user. Example method to load

RE: [PATCH v3 0/3] Enable a capsule loader interface for user to update

2015-04-12 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Friday, April 10, 2015 9:58 PM > > On Sat, Apr 11, 2015 at 03:40:41AM +0800, Kweh, Hock Leong wrote: > > From: "Kweh, Hock Leong" > > > > Hi Guys, > > > >

RE: [PATCH v3 0/3] Enable a capsule loader interface for user to update

2015-04-12 Thread Kweh, Hock Leong
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Friday, April 10, 2015 9:58 PM On Sat, Apr 11, 2015 at 03:40:41AM +0800, Kweh, Hock Leong wrote: From: Kweh, Hock Leong hock.leong.k...@intel.com Hi Guys, This patchset is created on top of efi: Capsule

RE: [PATCHv3 0/1] Intel Quark X1000 DTS thermal driver

2015-03-30 Thread Kweh, Hock Leong
> -Original Message- > From: Ong, Boon Leong > Sent: Tuesday, March 31, 2015 7:58 AM > To: Zhang, Rui; edubez...@gmail.com > Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Ong, Boon > Leong; pure.lo...@nexus-software.ie; Kweh, Hock Leong; > andy.shevche..

RE: [PATCHv3 0/1] Intel Quark X1000 DTS thermal driver

2015-03-30 Thread Kweh, Hock Leong
-Original Message- From: Ong, Boon Leong Sent: Tuesday, March 31, 2015 7:58 AM To: Zhang, Rui; edubez...@gmail.com Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Ong, Boon Leong; pure.lo...@nexus-software.ie; Kweh, Hock Leong; andy.shevche...@gmail.com Subject: RE

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-06 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Friday, March 06, 2015 7:09 AM > > On Mar 5, 2015 1:19 AM, "Kweh, Hock Leong" > wrote: > > > > > > This really is not a big deal. User should cope with it.

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-06 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Friday, March 06, 2015 4:14 PM > > On Thu, Mar 05, 2015 at 03:08:42PM -0800, Andy Lutomirski wrote: > > No. Only root should be able to load capsules, but even root may not > > be able to write to /lib. > > So

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-06 Thread Kweh, Hock Leong
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] Sent: Friday, March 06, 2015 7:09 AM On Mar 5, 2015 1:19 AM, Kweh, Hock Leong hock.leong.k...@intel.com wrote: This really is not a big deal. User should cope with it. No, it's a big deal, and the user

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-06 Thread Kweh, Hock Leong
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Friday, March 06, 2015 4:14 PM On Thu, Mar 05, 2015 at 03:08:42PM -0800, Andy Lutomirski wrote: No. Only root should be able to load capsules, but even root may not be able to write to /lib. So basically

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-05 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Wednesday, March 04, 2015 4:38 AM > > On Mon, Mar 2, 2015 at 9:56 PM, Kweh, Hock Leong > wrote: > > > > Just to call out that using firmware class auto locate binary feature is

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-05 Thread Kweh, Hock Leong
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] Sent: Wednesday, March 04, 2015 4:38 AM On Mon, Mar 2, 2015 at 9:56 PM, Kweh, Hock Leong hock.leong.k...@intel.com wrote: Just to call out that using firmware class auto locate binary feature is limited

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Kweh, Hock Leong
> -Original Message- > From: Matt Fleming [mailto:m...@console-pimps.org] > Sent: Monday, March 02, 2015 8:30 PM > > On Mon, 02 Mar, at 10:59:00AM, Kweh Hock Leong wrote: > > > -Original Message- > > > From: Borislav Petkov [mailto:b...@alien8.de

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Wednesday, February 25, 2015 8:49 PM > > On Wed, Feb 25, 2015 at 12:38:20PM +0000, Kweh, Hock Leong wrote: > > The reason we use this interface for efi capsule is that efi capsule >

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Kweh, Hock Leong
-Original Message- From: Matt Fleming [mailto:m...@console-pimps.org] Sent: Monday, March 02, 2015 8:30 PM On Mon, 02 Mar, at 10:59:00AM, Kweh Hock Leong wrote: -Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Wednesday, February 25, 2015 8:49

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-03-02 Thread Kweh, Hock Leong
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Wednesday, February 25, 2015 8:49 PM On Wed, Feb 25, 2015 at 12:38:20PM +, Kweh, Hock Leong wrote: The reason we use this interface for efi capsule is that efi capsule support multi binaries to be uploaded

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-02-27 Thread Kweh, Hock Leong
> -Original Message- > From: Roy Franz [mailto:roy.fr...@linaro.org] > Sent: Friday, February 27, 2015 1:07 PM > > On Sun, Nov 2, 2014 at 7:07 PM, Kweh Hock Leong > > +/* > > + * This function will store the capsule binary and pass it to > > + * efi_

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-02-27 Thread Kweh, Hock Leong
-Original Message- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Friday, February 27, 2015 1:07 PM On Sun, Nov 2, 2014 at 7:07 PM, Kweh Hock Leong +/* + * This function will store the capsule binary and pass it to + * efi_capsule_update() API in capsule.c */ static int

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-02-25 Thread Kweh, Hock Leong
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Wednesday, February 25, 2015 7:48 PM > > On Tue, Feb 24, 2015 at 12:49:09PM +0000, Kweh, Hock Leong wrote: > > So this sounds pretty overengineered for no reason, or maybe I'm missing > t

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-02-25 Thread Kweh, Hock Leong
-Original Message- From: Borislav Petkov [mailto:b...@alien8.de] Sent: Wednesday, February 25, 2015 7:48 PM On Tue, Feb 24, 2015 at 12:49:09PM +, Kweh, Hock Leong wrote: So this sounds pretty overengineered for no reason, or maybe I'm missing the reason. If I had to give

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-02-24 Thread Kweh, Hock Leong
> -Original Message- > From: Kweh, Hock Leong > Sent: Tuesday, February 24, 2015 6:54 PM > > In callbackfn_efi_capsule, you call request_firmware_nowait. When that > callback is invoked, I think that the /sys/class/firmware/efi-capsule-file > directory

RE: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface

2015-02-24 Thread Kweh, Hock Leong
-Original Message- From: Kweh, Hock Leong Sent: Tuesday, February 24, 2015 6:54 PM In callbackfn_efi_capsule, you call request_firmware_nowait. When that callback is invoked, I think that the /sys/class/firmware/efi-capsule-file directory doesn't exist at all. If the callback

RE: [PATCH] thermal: intel Quark SoC X1000 DTS thermal driver

2015-02-22 Thread Kweh, Hock Leong
> -Original Message- > From: Ong, Boon Leong > Sent: Monday, February 23, 2015 9:39 AM > Subject: RE: [PATCH] thermal: intel Quark SoC X1000 DTS thermal driver > > >Just to bring out for discussion, do you think we should put a "safety range" > >for reporting out the critical trip

RE: [PATCH] thermal: intel Quark SoC X1000 DTS thermal driver

2015-02-22 Thread Kweh, Hock Leong
-Original Message- From: Ong, Boon Leong Sent: Monday, February 23, 2015 9:39 AM Subject: RE: [PATCH] thermal: intel Quark SoC X1000 DTS thermal driver Just to bring out for discussion, do you think we should put a safety range for reporting out the critical trip temperature value

RE: [PATCH] thermal: intel Quark SoC X1000 DTS thermal driver

2015-02-12 Thread Kweh, Hock Leong
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Ong Boon Leong > Sent: Thursday, February 12, 2015 12:52 AM > To: Zhang, Rui; edubez...@gmail.com > Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org >

RE: [PATCH] thermal: intel Quark SoC X1000 DTS thermal driver

2015-02-12 Thread Kweh, Hock Leong
-Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Ong Boon Leong Sent: Thursday, February 12, 2015 12:52 AM To: Zhang, Rui; edubez...@gmail.com Cc: linux...@vger.kernel.org; linux-kernel@vger.kernel.org Subject:

RE: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-17 Thread Kweh, Hock Leong
> -Original Message- > From: Matt Fleming [mailto:m...@console-pimps.org] > Sent: Monday, November 17, 2014 11:12 PM > > > > - Only doing module unload is required to be aware of this synchronization > > -> Ensuring the call back does not fall into unloaded code which may > cause > >

[PATCH v3] firmware loader: fix hung task warning dump

2014-11-17 Thread Kweh Hock Leong
From: "Kweh, Hock Leong" When using request_firmware_nowait() with FW_ACTION_NOHOTPLUG param to expose user helper interface, if the user do not react immediately, after 120 seconds there will be a hung task warning message dumped as below: [ 3000.784235] INFO: task kworker/0:0:82

[PATCH v3] firmware loader: fix hung task warning dump

2014-11-17 Thread Kweh Hock Leong
From: Kweh, Hock Leong hock.leong.k...@intel.com When using request_firmware_nowait() with FW_ACTION_NOHOTPLUG param to expose user helper interface, if the user do not react immediately, after 120 seconds there will be a hung task warning message dumped as below: [ 3000.784235] INFO: task

RE: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-17 Thread Kweh, Hock Leong
-Original Message- From: Matt Fleming [mailto:m...@console-pimps.org] Sent: Monday, November 17, 2014 11:12 PM - Only doing module unload is required to be aware of this synchronization - Ensuring the call back does not fall into unloaded code which may cause

RE: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-12 Thread Kweh, Hock Leong
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Sunday, November 09, 2014 3:07 AM > > > > > Besides aborting through user helper interface, a new API > > request_firmware_abort() allows kernel driver module to abort the > > request_firmware() /

RE: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort()

2014-11-12 Thread Kweh, Hock Leong
-Original Message- From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] Sent: Sunday, November 09, 2014 3:07 AM Besides aborting through user helper interface, a new API request_firmware_abort() allows kernel driver module to abort the request_firmware() /

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-10 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > > #!/bin/sh > > > > old=$(cat > > /sys/devices/platform/efi_capsule_user_helper/capsule_loaded) > > > > for arg in "$@" > > do > > if [ -f $arg ] > > then > > echo 1 >

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-10 Thread Kweh, Hock Leong
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] #!/bin/sh old=$(cat /sys/devices/platform/efi_capsule_user_helper/capsule_loaded) for arg in $@ do if [ -f $arg ] then echo 1

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-06 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Wednesday, November 05, 2014 12:36 AM > > Am I missing something here? The current proposal is missing the > success/failure part, unless you count the loaded count (in a different sysfs > directory) as a

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-06 Thread Kweh, Hock Leong
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] Sent: Wednesday, November 05, 2014 12:36 AM Am I missing something here? The current proposal is missing the success/failure part, unless you count the loaded count (in a different sysfs directory) as a useful

RE: [PATCH v2 0/3] Enable user helper interface for efi capsule update

2014-11-05 Thread Kweh, Hock Leong
> -Original Message- > From: Fleming, Matt > Sent: Tuesday, November 04, 2014 10:08 PM > To: Greg Kroah-Hartman > > > > Good point, I don't know. > > > > Who ever wrote this code should know this, can someone please provide > > a use-case for how this is all supposed to work? > > That

RE: [PATCH v2 0/3] Enable user helper interface for efi capsule update

2014-11-05 Thread Kweh, Hock Leong
-Original Message- From: Fleming, Matt Sent: Tuesday, November 04, 2014 10:08 PM To: Greg Kroah-Hartman Good point, I don't know. Who ever wrote this code should know this, can someone please provide a use-case for how this is all supposed to work? That would be Wilson.

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-04 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > Sent: Tuesday, November 04, 2014 2:32 PM > > It seems like a large fraction of the code in this module exists just to work > around the fact that request_firmware doesn't do what you want it to do. > You have code

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-04 Thread Kweh, Hock Leong
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] Sent: Tuesday, November 04, 2014 2:32 PM It seems like a large fraction of the code in this module exists just to work around the fact that request_firmware doesn't do what you want it to do. You have code to:

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-03 Thread Kweh, Hock Leong
> -Original Message- > From: Andy Lutomirski [mailto:l...@amacapital.net] > > > > Andy, here's the steps to load a capsule. I don't have a problem with > > this, it's userspace driven, no "autoloading" of files in /lib/, and > > works with sysfs. > > > > Have any objection to it, I don't.

RE: [PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-03 Thread Kweh, Hock Leong
-Original Message- From: Andy Lutomirski [mailto:l...@amacapital.net] Andy, here's the steps to load a capsule. I don't have a problem with this, it's userspace driven, no autoloading of files in /lib/, and works with sysfs. Have any objection to it, I don't. Thanks Greg

[PATCH v2 3/3] efi: Capsule update with user helper interface

2014-11-02 Thread Kweh Hock Leong
From: "Kweh, Hock Leong" Introducing a kernel module to expose user helper interface for user to upload capsule binaries. This module leverage the request_firmware_nowait() to expose an interface to user. Example steps to load the capsule binary: 1.) echo 1 > /sys/class/firmwar

[PATCH v2 2/3] firmware loader: fix hung task warning dump

2014-11-02 Thread Kweh Hock Leong
From: "Kweh, Hock Leong" When using request_firmware_nowait() with FW_ACTION_NOHOTPLUG param to expose user helper interface, if the user do not react immediately, after 120 seconds there will be a hung task warning message dumped as below: [ 3000.784235] INFO: task kworker/0:0:82

<    1   2   3   >