Re: [PATCH v2] scsi: be2iscsi: Use kasprintf

2017-10-11 Thread Kyle Fortin
> +++ b/drivers/scsi/be2iscsi/be_main.h > @@ -155,8 +155,6 @@ > #define PAGES_REQUIRED(x) \ > ((x < PAGE_SIZE) ? 1 : ((x + PAGE_SIZE - 1) / PAGE_SIZE)) > > -#define BEISCSI_MSI_NAME 20 /* size of msi_name string */ > - > #define MEM_DESCR_OFFSET 8 > #define BEISCSI_DEFQ_HDR 1 > #define BEISCSI_DEFQ_DATA 0 > -- > 2.7.4 > Looks good. Reviewed-by: Kyle Fortin

Re: [PATCH] scsi: be2iscsi: Use kasprintf

2017-10-10 Thread Kyle Fortin
>host_no); > ret = request_irq(pci_irq_vector(pcidev, i), be_isr_mcc, 0, > phba->msi_name[i], &phwi_context->be_eq[i]); > if (ret) { > -- > 2.7.4 Since you are getting rid of the only use for BEISCSI_MSI_NAME within drivers/scsi/be2iscsi/be_main.h, that should be removed too. -- Kyle Fortin - Oracle Linux Engineering

Re: [PATCH] block: add partition uuid into uevent as "PARTUUID"

2017-10-10 Thread Kyle Fortin
amp; part->info->volname[0]) > add_uevent_var(env, "PARTNAME=%s", part->info->volname); > + if (part->info && part->info->uuid[0]) > + add_uevent_var(env, "PARTUUID=%s", part->info->uuid); > return 0; > } Looks fine. Reviewed-by: Kyle Fortin

Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-09 Thread Kyle Fortin
; 72 chars, otherwise it turns into an unreadable mess when people >> try to view them. >> >> -- >> Jens Axboe >> > > Noted! Thanks for the heads up on the char limit. scripts/checkpatch.pl would have caught it too -- Kyle Fortin - Oracle Linux Engineering

Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

2017-10-06 Thread Kyle Fortin
; > - > - if (bs->bvec_integrity_pool) > - mempool_destroy(bs->bvec_integrity_pool); > + mempool_destroy(bs->bio_integrity_pool); > + mempool_destroy(bs->bvec_integrity_pool); > } > EXPORT_SYMBOL(bioset_integrity_free); > > -- > 2.1.4 Looks good. Reviewed-by: Kyle Fortin