?
The first person to the lpc bus needs to call pci_enable_device and the
last to leave one should call pci_disable_device, how as a device driver
on this bus do I know if I am the first or last one and need to make the
appropriate call?
Thanks,
Kylie Hall
Signed-off-by: Kylene Hall <[EMAIL PROTEC
I have tested this patch and agree that using msleep is the right. Please
apply this patch to the tpm driver. One hunk might fail b/c the
typo has been fixed already.
Thanks,
Kylie Hall
On Fri, 11 Mar 2005, Nishanth Aravamudan wrote:
> Not sure what happened to the original mail, but I'm
I have tested this patch and agree that using msleep is the right. Please
apply this patch to the tpm driver. One hunk might fail b/c the
typo has been fixed already.
Thanks,
Kylie Hall
On Fri, 11 Mar 2005, Nishanth Aravamudan wrote:
Not sure what happened to the original mail, but I'm not
?
The first person to the lpc bus needs to call pci_enable_device and the
last to leave one should call pci_disable_device, how as a device driver
on this bus do I know if I am the first or last one and need to make the
appropriate call?
Thanks,
Kylie Hall
Signed-off-by: Kylene Hall [EMAIL PROTECTED
The patch at the bottom addresses a number of the concerns raised in this
email along with a couple of other comments which this generated regarding
not needing __force and the need for a MAINTAINERS entry.
Signed-off-by: Kylene Hall <[EMAIL PROTECTED]>
On Wed, 9 Mar 2005, Jeff Garzik
The patch at the bottom addresses a number of the concerns raised in this
email along with a couple of other comments which this generated regarding
not needing __force and the need for a MAINTAINERS entry.
Signed-off-by: Kylene Hall [EMAIL PROTECTED]
On Wed, 9 Mar 2005, Jeff Garzik wrote
On Wed, 2005-02-09 at 16:04, Chris Wright wrote:
> > +#define TPM_DEVICE_ATTRS { \
> > + __ATTR(pubek, S_IRUGO, show_pubek, NULL), \
> > + __ATTR(pcrs, S_IRUGO, show_pcrs, NULL), \
> > + __ATTR(caps, S_IRUGO, show_caps, NULL), \
> > + __ATTR(cancel, S_IWUSR | S_IWGRP, NULL, store_cancel) }
On Wed, 2005-02-09 at 16:04, Chris Wright wrote:
+#define TPM_DEVICE_ATTRS { \
+ __ATTR(pubek, S_IRUGO, show_pubek, NULL), \
+ __ATTR(pcrs, S_IRUGO, show_pcrs, NULL), \
+ __ATTR(caps, S_IRUGO, show_caps, NULL), \
+ __ATTR(cancel, S_IWUSR | S_IWGRP, NULL, store_cancel) }
This
On Wed, 9 Feb 2005, Greg KH wrote:
> On Wed, Feb 09, 2005 at 12:05:42PM -0600, Kylene Hall wrote:
> > @@ -539,9 +551,8 @@ void tpm_remove_hardware(struct device *
> > dev_set_drvdata(dev, NULL);
> > misc_deregister(>vendor->miscdev);
> >
> >
On Fri, 4 Feb 2005, Greg KH wrote:
> On Fri, Feb 04, 2005 at 03:37:20PM -0600, Kylene Hall wrote:
> > On Fri, 2005-02-04 at 14:52, Greg KH wrote:
> > > On Fri, Feb 04, 2005 at 02:12:50PM -0600, Kylene Hall wrote:
> > > > +static struct class tpm_class =
On Fri, 4 Feb 2005, Greg KH wrote:
On Fri, Feb 04, 2005 at 03:37:20PM -0600, Kylene Hall wrote:
On Fri, 2005-02-04 at 14:52, Greg KH wrote:
On Fri, Feb 04, 2005 at 02:12:50PM -0600, Kylene Hall wrote:
+static struct class tpm_class = {
+ .name = tpm
On Wed, 9 Feb 2005, Greg KH wrote:
On Wed, Feb 09, 2005 at 12:05:42PM -0600, Kylene Hall wrote:
@@ -539,9 +551,8 @@ void tpm_remove_hardware(struct device *
dev_set_drvdata(dev, NULL);
misc_deregister(chip-vendor-miscdev);
- device_remove_file(dev, dev_attr_pubek
On Fri, 2005-02-04 at 14:52, Greg KH wrote:
> On Fri, Feb 04, 2005 at 02:12:50PM -0600, Kylene Hall wrote:
> > +static struct class tpm_class = {
> > + .name = "tpm",
> > + .class_dev_attrs = tpm_attrs,
> > +};
>
> Where is your release function?
he
driver, device and tpm specific files (pcrs, etc) now live. This patch
also includes a new sysfs file for each tpm that is needed to support
canceling an operation.
Thanks,
Kylie
Signed-off-by: Kylene Hall <[EMAIL PROTECTED]>
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm.c
linux-2.
, device and tpm specific files (pcrs, etc) now live. This patch
also includes a new sysfs file for each tpm that is needed to support
canceling an operation.
Thanks,
Kylie
Signed-off-by: Kylene Hall [EMAIL PROTECTED]
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm.c
linux-2.6.10-tpm/drivers/char
On Fri, 2005-02-04 at 14:52, Greg KH wrote:
On Fri, Feb 04, 2005 at 02:12:50PM -0600, Kylene Hall wrote:
+static struct class tpm_class = {
+ .name = tpm,
+ .class_dev_attrs = tpm_attrs,
+};
Where is your release function? Did you see any warnings from the
kernel when you removed
device stuff and future non-pci chips can easily be connected to the
architecture.
Thanks,
Kylie
Signed-off-by: Kylene Hall <[EMAIL PROTECTED]>
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm_atmel.c
linux-2.6.10-tpm/drivers/char/tpm/tpm_atmel.c
--- linux-2.6.10/drivers/char/tpm/tpm_a
device stuff and future non-pci chips can easily be connected to the
architecture.
Thanks,
Kylie
Signed-off-by: Kylene Hall [EMAIL PROTECTED]
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm_atmel.c
linux-2.6.10-tpm/drivers/char/tpm/tpm_atmel.c
--- linux-2.6.10/drivers/char/tpm/tpm_atmel.c 2005
There is also a typo in the driver version in the 2.6.11-rc2-mm2 tree that
is not fixed by the previous patch. Please apply this upated version to
fix the previously acknowledged problems and this typo causing a build
error.
Thanks,
Kylie
On Fri, 28 Jan 2005, Kylene Hall wrote:
> This pa
There is also a typo in the driver version in the 2.6.11-rc2-mm2 tree that
is not fixed by the previous patch. Please apply this upated version to
fix the previously acknowledged problems and this typo causing a build
error.
Thanks,
Kylie
On Fri, 28 Jan 2005, Kylene Hall wrote:
This patch
Thanks,
Kylie
Signed-off-by: Kylene Hall <[EMAIL PROTECTED]>
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm_atmel.c
linux-2.6.10-tpm/drivers/char/tpm/tpm_atmel.c
--- linux-2.6.10/drivers/char/tpm/tpm_atmel.c 2005-01-18 16:42:17.0
-0600
+++ linux-2.6.10-tpm/drivers/char/tpm
,
Kylie
Signed-off-by: Kylene Hall [EMAIL PROTECTED]
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm_atmel.c
linux-2.6.10-tpm/drivers/char/tpm/tpm_atmel.c
--- linux-2.6.10/drivers/char/tpm/tpm_atmel.c 2005-01-18 16:42:17.0
-0600
+++ linux-2.6.10-tpm/drivers/char/tpm/tpm_atmel.c
TED]>
Thanks,
Kylie
Signed-off-by: Kylene Hall <[EMAIL PROTECTED]>
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm.c
linux-2.6.10-tpm/drivers/char/tpm/tpm.c
--- linux-2.6.10/drivers/char/tpm/tpm.c 2005-01-18 18:10:16.0 -0600
+++ linux-2.6.10-tpm/drivers/char/tpm/tpm.c 2005
On Tue, 2005-01-18 at 16:47, Greg KH wrote:
> On Tue, Jan 18, 2005 at 04:29:23PM -0600, Kylene Hall wrote:
> > There were misplaced spinlock acquires and releases in the probe, open,
> > close and release paths which were causing might_sleep and schedule while
> >
On Tue, 2005-01-18 at 16:37, Chris Wright wrote:
> * Kylene Hall ([EMAIL PROTECTED]) wrote:
> > There were misplaced spinlock acquires and releases in the probe, open,
> > close and release paths which were causing might_sleep and schedule while
> > atomic error messages
TED]>
Signed-off-by: Kylene Hall <[EMAIL PROTECTED]>
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm.c
linux-2.6.10-tpm/drivers/char/tpm/tpm.c
--- linux-2.6.10/drivers/char/tpm/tpm.c 2005-01-18 16:42:17.0 -0600
+++ linux-2.6.10-tpm/drivers/char/tpm/tpm.c 2005-01-18 12:52:53.
]
Signed-off-by: Kylene Hall [EMAIL PROTECTED]
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm.c
linux-2.6.10-tpm/drivers/char/tpm/tpm.c
--- linux-2.6.10/drivers/char/tpm/tpm.c 2005-01-18 16:42:17.0 -0600
+++ linux-2.6.10-tpm/drivers/char/tpm/tpm.c 2005-01-18 12:52:53.0
-0600
On Tue, 2005-01-18 at 16:37, Chris Wright wrote:
* Kylene Hall ([EMAIL PROTECTED]) wrote:
There were misplaced spinlock acquires and releases in the probe, open,
close and release paths which were causing might_sleep and schedule while
atomic error messages accompanied by stack traces
On Tue, 2005-01-18 at 16:47, Greg KH wrote:
On Tue, Jan 18, 2005 at 04:29:23PM -0600, Kylene Hall wrote:
There were misplaced spinlock acquires and releases in the probe, open,
close and release paths which were causing might_sleep and schedule while
atomic error messages accompanied
,
Kylie
Signed-off-by: Kylene Hall [EMAIL PROTECTED]
---
diff -uprN linux-2.6.10/drivers/char/tpm/tpm.c
linux-2.6.10-tpm/drivers/char/tpm/tpm.c
--- linux-2.6.10/drivers/char/tpm/tpm.c 2005-01-18 18:10:16.0 -0600
+++ linux-2.6.10-tpm/drivers/char/tpm/tpm.c 2005-01-18 18:13:59.0
30 matches
Mail list logo
