Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 01:44 PM, Mark Brown wrote: On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: +wm8731-mclk = devm_clk_get(spi-dev, mclk); +if (IS_ERR(wm8731-mclk)) { +wm8731-mclk = NULL; +dev_warn(spi-dev, assuming static MCLK\n); +} This is broken for

Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 06:26 PM, Lars-Peter Clausen wrote: On 02/03/2015 06:17 PM, Russell King - ARM Linux wrote: On Tue, Feb 03, 2015 at 05:53:48PM +0100, Lars-Peter Clausen wrote: On 02/03/2015 01:44 PM, Mark Brown wrote: On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: +wm8731

Re: [alsa-devel] [RFC PATCH] ASoC: wm8731: let codec to manage clock by itself

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 06:17 PM, Russell King - ARM Linux wrote: On Tue, Feb 03, 2015 at 05:53:48PM +0100, Lars-Peter Clausen wrote: On 02/03/2015 01:44 PM, Mark Brown wrote: On Tue, Feb 03, 2015 at 08:54:57AM +0100, Manuel Lauss wrote: +wm8731-mclk = devm_clk_get(spi-dev, mclk); +if (IS_ERR

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Lars-Peter Clausen
On 02/03/2015 11:17 AM, Zubair Lutfullah Kakakhel wrote: [...] V4 Changes Removed clock binding because of pending work in clock tree. Will add binding later. Rather than introduce a bad binding now and change later. But this patch is introducing a bad binding. The part needs the clock to

Re: [PATCH] media: i2c: ADV7604: Migrate to regmap

2015-02-03 Thread Lars-Peter Clausen
On 02/01/2015 11:08 AM, Jean-Michel Hautbois wrote: Looks mostly good, some things in addition to what Hans already said. [...] - -static s32 adv_smbus_write_byte_data(struct adv7604_state *state, -enum adv7604_page page, u8 command, -

Re: [PATCH] regmap: Fix i2c word access when using SMBus access functions

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 12:48 AM, Guenter Roeck wrote: [...] static int regmap_i2c_write(void *context, const void *data, size_t count) { struct device *dev = context; @@ -180,7 +216,10 @@ static const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c, else if

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 10:50 AM, Nicholas Mc Guire wrote: On Mon, 02 Feb 2015, Lars-Peter Clausen wrote: On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved into the if condition as the return value is only used to detect timeout. But the return value

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved into the if condition as the return value is only used to detect timeout. But the return value

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 10:50 AM, Nicholas Mc Guire wrote: On Mon, 02 Feb 2015, Lars-Peter Clausen wrote: On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved

Re: [PATCH] regmap: Fix i2c word access when using SMBus access functions

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 12:48 AM, Guenter Roeck wrote: [...] static int regmap_i2c_write(void *context, const void *data, size_t count) { struct device *dev = context; @@ -180,7 +216,10 @@ static const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c, else if

Re: [alsa-devel] [PATCH_V3 0/4] sound:soc: jz4740: DT, dynamic sampling, enable clocks

2015-01-27 Thread Lars-Peter Clausen
On 01/26/2015 03:53 PM, Zubair Lutfullah Kakakhel wrote: Hi, Here are a few simple patches for the jz4740. For 1-3: Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [alsa-devel] [PATCH_V3 0/4] sound:soc: jz4740: DT, dynamic sampling, enable clocks

2015-01-27 Thread Lars-Peter Clausen
On 01/26/2015 03:53 PM, Zubair Lutfullah Kakakhel wrote: Hi, Here are a few simple patches for the jz4740. For 1-3: Acked-by: Lars-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [alsa-devel] [PATCH 1/7] ALSA: pcm: Add snd_interval_ranges() and snd_pcm_hw_constraint_ranges()

2015-01-26 Thread Lars-Peter Clausen
mentioning that this is the extension of snd_pcm_hw_constraint_list() from points to ranges. Otherwise looks good. Reviewed-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [alsa-devel] [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 05:42 PM, Mark Brown wrote: On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra code when devtype is assigned to check for an of_node and look at the DT

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-26 Thread Lars-Peter Clausen
On 01/24/2015 02:18 PM, Jean-Francois Moine wrote: On Sat, 24 Jan 2015 12:27:35 +0100 Lars-Peter Clausen wrote: On 01/23/2015 07:34 PM, Jean-Francois Moine wrote: On Fri, 23 Jan 2015 14:56:04 +0100 Lars-Peter Clausen wrote: On 01/23/2015 01:15 PM, Jean-Francois Moine wrote

Re: [alsa-devel] [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 12:30 PM, Zubair Lutfullah Kakakhel wrote: On 26/01/15 10:40, Lars-Peter Clausen wrote: On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: As we are moving away from platform to DT, we cant rely on the board file to do this now. So enable it here. I don't understand

Re: [alsa-devel] [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 12:32 PM, Zubair Lutfullah Kakakhel wrote: On 26/01/15 10:37, Lars-Peter Clausen wrote: On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] +Required properties: +- compatible : "ingenic,jz4740-i2s" +- reg : I2S registers location and length +- clocks : A

Re: [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: As we are moving away from platform to DT, we cant rely on the board file to do this now. So enable it here. I don't understand this changelog. The board file never did this. The driver enables the clock in the startup() callback.

Re: [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] +Required properties: +- compatible : "ingenic,jz4740-i2s" +- reg : I2S registers location and length +- clocks : AIC and I2S PLL clock specifiers. +- clock-names: "aic" and "i2s" We also need a handle to the DMA channels.

Re: [PATCH 1/4] sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] #define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12) +#define JZ_AIC_I2S_FMT_DISABLE_BIT_ICLK BIT(13) This looks like it slipped in by accident. Otherwise the patch looks good. -- To unsubscribe from this list: send the line

Re: [alsa-devel] [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 05:42 PM, Mark Brown wrote: On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote: Le 16/01/2015 02:17, Bo Shen a écrit : Does this end up in the i2c_driver_id driver data or do we need some extra code when devtype is assigned to check for an of_node and look at the DT

Re: [alsa-devel] [PATCH 1/7] ALSA: pcm: Add snd_interval_ranges() and snd_pcm_hw_constraint_ranges()

2015-01-26 Thread Lars-Peter Clausen
. Might be worth mentioning that this is the extension of snd_pcm_hw_constraint_list() from points to ranges. Otherwise looks good. Reviewed-by: Lars-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 1/4] sound: soc: jz4740: Add dynamic sampling rate support to jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] #define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12) +#define JZ_AIC_I2S_FMT_DISABLE_BIT_ICLK BIT(13) This looks like it slipped in by accident. Otherwise the patch looks good. -- To unsubscribe from this list: send the line

Re: [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] +Required properties: +- compatible : ingenic,jz4740-i2s +- reg : I2S registers location and length +- clocks : AIC and I2S PLL clock specifiers. +- clock-names: aic and i2s We also need a handle to the DMA channels. Currently the

Re: [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: As we are moving away from platform to DT, we cant rely on the board file to do this now. So enable it here. I don't understand this changelog. The board file never did this. The driver enables the clock in the startup() callback.

Re: [alsa-devel] [PATCH 2/4] dt: sound: jz4740: Add binding documentation for jz4740-i2s

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 12:32 PM, Zubair Lutfullah Kakakhel wrote: On 26/01/15 10:37, Lars-Peter Clausen wrote: On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: [...] +Required properties: +- compatible : ingenic,jz4740-i2s +- reg : I2S registers location and length +- clocks : AIC and I2S PLL

Re: [alsa-devel] [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe

2015-01-26 Thread Lars-Peter Clausen
On 01/26/2015 12:30 PM, Zubair Lutfullah Kakakhel wrote: On 26/01/15 10:40, Lars-Peter Clausen wrote: On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: As we are moving away from platform to DT, we cant rely on the board file to do this now. So enable it here. I don't understand

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-26 Thread Lars-Peter Clausen
On 01/24/2015 02:18 PM, Jean-Francois Moine wrote: On Sat, 24 Jan 2015 12:27:35 +0100 Lars-Peter Clausen l...@metafoo.de wrote: On 01/23/2015 07:34 PM, Jean-Francois Moine wrote: On Fri, 23 Jan 2015 14:56:04 +0100 Lars-Peter Clausen l...@metafoo.de wrote: On 01/23/2015 01:15 PM, Jean

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-24 Thread Lars-Peter Clausen
On 01/23/2015 07:34 PM, Jean-Francois Moine wrote: On Fri, 23 Jan 2015 14:56:04 +0100 Lars-Peter Clausen wrote: On 01/23/2015 01:15 PM, Jean-Francois Moine wrote: [...] The DT should describe the hardware, and the simple-card mixes hardware and software. For example, the kirkwood controller

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-24 Thread Lars-Peter Clausen
On 01/23/2015 07:34 PM, Jean-Francois Moine wrote: On Fri, 23 Jan 2015 14:56:04 +0100 Lars-Peter Clausen l...@metafoo.de wrote: On 01/23/2015 01:15 PM, Jean-Francois Moine wrote: [...] The DT should describe the hardware, and the simple-card mixes hardware and software. For example

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-23 Thread Lars-Peter Clausen
On 01/23/2015 01:15 PM, Jean-Francois Moine wrote: [...] The DT should describe the hardware, and the simple-card mixes hardware and software. For example, the kirkwood controller may create 2 CPU DAIs. With the simple-card, the DT contains a number to reference these DAIs (for example,

Re: [PATCH] iio: imu: adis16400: Fix sign extension

2015-01-23 Thread Lars-Peter Clausen
On 01/23/2015 12:34 AM, Rasmus Villemoes wrote: The intention is obviously to sign-extend a 12 bit quantity. But because of C's promotion rules, the assignment is equivalent to "val16 &= 0xfff;". Use the proper API for this. Signed-off-by: Rasmus Villemoes Acked-by: Lars

Re: [PATCH] staging: iio: ad2s1200: Fix sign extension

2015-01-23 Thread Lars-Peter Clausen
is promoted to int before the inner shift. sign_extend32 works equally well for 8 and 16 bits types, so use that. Signed-off-by: Rasmus Villemoes Acked-by: Lars-Peter Clausen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-23 Thread Lars-Peter Clausen
On 01/23/2015 01:15 PM, Jean-Francois Moine wrote: [...] The DT should describe the hardware, and the simple-card mixes hardware and software. For example, the kirkwood controller may create 2 CPU DAIs. With the simple-card, the DT contains a number to reference these DAIs (for example,

Re: [PATCH] staging: iio: ad2s1200: Fix sign extension

2015-01-23 Thread Lars-Peter Clausen
shift. sign_extend32 works equally well for 8 and 16 bits types, so use that. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk Acked-by: Lars-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] iio: imu: adis16400: Fix sign extension

2015-01-23 Thread Lars-Peter Clausen
-Peter Clausen l...@metafoo.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-22 Thread Lars-Peter Clausen
On 01/22/2015 09:07 AM, Jean-Francois Moine wrote: On Wed, 21 Jan 2015 21:14:07 +0100 Lars-Peter Clausen wrote: [...] + card->dai_link->dai_fmt = + snd_soc_of_parse_daifmt(of_cpu, "dt-audio-card,", +

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-22 Thread Lars-Peter Clausen
On 01/22/2015 09:07 AM, Jean-Francois Moine wrote: On Wed, 21 Jan 2015 21:14:07 +0100 Lars-Peter Clausen l...@metafoo.de wrote: [...] + card-dai_link-dai_fmt = + snd_soc_of_parse_daifmt(of_cpu, dt-audio-card,, + NULL, NULL

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-21 Thread Lars-Peter Clausen
[...] + card->dai_link->dai_fmt = + snd_soc_of_parse_daifmt(of_cpu, "dt-audio-card,", + NULL, NULL) & + ~SND_SOC_DAIFMT_MASTER_MASK; This one does not seem to be in the bindings documentation. -- To unsubscribe

Re: [PATCH 1/3] spi/xilinx: Use automatic bus number on device tree

2015-01-21 Thread Lars-Peter Clausen
On 01/21/2015 04:53 PM, Ricardo Ribalda Delgado wrote: If there is more than one spi device on a device tree, the second one will fail to probe due to a duplicated bus_num. > [...] This should already be fixed. See commit 4b153a2137c5 ("spi: xilinx: Use pdev->id instead of pdev->dev.id for

Re: [PATCH 1/3] spi/xilinx: Use automatic bus number on device tree

2015-01-21 Thread Lars-Peter Clausen
On 01/21/2015 04:53 PM, Ricardo Ribalda Delgado wrote: If there is more than one spi device on a device tree, the second one will fail to probe due to a duplicated bus_num. [...] This should already be fixed. See commit 4b153a2137c5 (spi: xilinx: Use pdev-id instead of pdev-dev.id for the

Re: [alsa-devel] [PATCH v2 3/3] ASoC: add generic dt-card support

2015-01-21 Thread Lars-Peter Clausen
[...] + card-dai_link-dai_fmt = + snd_soc_of_parse_daifmt(of_cpu, dt-audio-card,, + NULL, NULL) + ~SND_SOC_DAIFMT_MASTER_MASK; This one does not seem to be in the bindings documentation. -- To unsubscribe from

Re: [PATCH] staging: iio: ad5933: fix format string warnings

2015-01-20 Thread Lars-Peter Clausen
:367]: (warning) %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4) requires 'int' but the argument type is 'unsigned int'. Signed-off-by: Asaf Vertz Acked-by: Lars-Peter

Re: [PATCH] staging: iio: ad5933: fix format string warnings

2015-01-20 Thread Lars-Peter Clausen
Acked-by: Lars-Peter Clausen l...@metafoo.de Thanks. --- drivers/staging/iio/impedance-analyzer/ad5933.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c index b6bd609

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

2015-01-19 Thread Lars-Peter Clausen
On 01/20/2015 08:12 AM, Greg Kroah-Hartman wrote: On Tue, Jan 20, 2015 at 08:05:20AM +0100, Lars-Peter Clausen wrote: On 01/20/2015 02:41 AM, Greg Kroah-Hartman wrote: On Mon, Jan 19, 2015 at 11:04:27PM +, Russell King - ARM Linux wrote: On Tue, Jan 20, 2015 at 03:01:42AM +0800, Greg

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

2015-01-19 Thread Lars-Peter Clausen
On 01/20/2015 02:41 AM, Greg Kroah-Hartman wrote: On Mon, Jan 19, 2015 at 11:04:27PM +, Russell King - ARM Linux wrote: On Tue, Jan 20, 2015 at 03:01:42AM +0800, Greg Kroah-Hartman wrote: On Mon, Jan 19, 2015 at 07:55:56PM +0100, Wolfram Sang wrote: diff --git a/drivers/i2c/i2c-core.c

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

2015-01-19 Thread Lars-Peter Clausen
On 01/19/2015 07:55 PM, Wolfram Sang wrote: [...] Let's get rid of this code before really nobody knows/understands anymore what this was for and if it has a subtle use. Getting rid of this is the right thing, cause it's just not how it should be done, but unfortunately it is not as simple

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

2015-01-19 Thread Lars-Peter Clausen
On 01/20/2015 02:41 AM, Greg Kroah-Hartman wrote: On Mon, Jan 19, 2015 at 11:04:27PM +, Russell King - ARM Linux wrote: On Tue, Jan 20, 2015 at 03:01:42AM +0800, Greg Kroah-Hartman wrote: On Mon, Jan 19, 2015 at 07:55:56PM +0100, Wolfram Sang wrote: diff --git a/drivers/i2c/i2c-core.c

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

2015-01-19 Thread Lars-Peter Clausen
On 01/20/2015 08:12 AM, Greg Kroah-Hartman wrote: On Tue, Jan 20, 2015 at 08:05:20AM +0100, Lars-Peter Clausen wrote: On 01/20/2015 02:41 AM, Greg Kroah-Hartman wrote: On Mon, Jan 19, 2015 at 11:04:27PM +, Russell King - ARM Linux wrote: On Tue, Jan 20, 2015 at 03:01:42AM +0800, Greg

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

2015-01-19 Thread Lars-Peter Clausen
On 01/19/2015 07:55 PM, Wolfram Sang wrote: [...] Let's get rid of this code before really nobody knows/understands anymore what this was for and if it has a subtle use. Getting rid of this is the right thing, cause it's just not how it should be done, but unfortunately it is not as simple

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 01:02 PM, Mark Brown wrote: [...] I don't think that we need to prevent module unload when a stream is active. From a framework point of view is not different from hot-unplug. I don't see a reason why we'd jump through hoops to actively forbid removing the module once it works

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 09:47 AM, Takashi Iwai wrote: At Wed, 14 Jan 2015 09:15:36 +0100, Lars-Peter Clausen wrote: On 01/14/2015 08:43 AM, Takashi Iwai wrote: At Tue, 13 Jan 2015 21:54:12 +, Mark Brown wrote: On Tue, Jan 13, 2015 at 06:24:44PM +0100, Takashi Iwai wrote: Wang, Jiada (ESD) wrote

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 09:25 AM, jiwang wrote: Hi On 01/14/2015 05:15 PM, Lars-Peter Clausen wrote: On 01/14/2015 08:43 AM, Takashi Iwai wrote: At Tue, 13 Jan 2015 21:54:12 +, Mark Brown wrote: On Tue, Jan 13, 2015 at 06:24:44PM +0100, Takashi Iwai wrote: Wang, Jiada (ESD) wrote: I am using

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 08:43 AM, Takashi Iwai wrote: At Tue, 13 Jan 2015 21:54:12 +, Mark Brown wrote: On Tue, Jan 13, 2015 at 06:24:44PM +0100, Takashi Iwai wrote: Wang, Jiada (ESD) wrote: I am using i.MX6Q sabreSD board, which have imx_wm892 machine driver, wm8962 codec and SSI CPU DAI, I

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 08:43 AM, Takashi Iwai wrote: At Tue, 13 Jan 2015 21:54:12 +, Mark Brown wrote: On Tue, Jan 13, 2015 at 06:24:44PM +0100, Takashi Iwai wrote: Wang, Jiada (ESD) wrote: I am using i.MX6Q sabreSD board, which have imx_wm892 machine driver, wm8962 codec and SSI CPU DAI, I

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 09:25 AM, jiwang wrote: Hi On 01/14/2015 05:15 PM, Lars-Peter Clausen wrote: On 01/14/2015 08:43 AM, Takashi Iwai wrote: At Tue, 13 Jan 2015 21:54:12 +, Mark Brown wrote: On Tue, Jan 13, 2015 at 06:24:44PM +0100, Takashi Iwai wrote: Wang, Jiada (ESD) wrote: I am using

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 09:47 AM, Takashi Iwai wrote: At Wed, 14 Jan 2015 09:15:36 +0100, Lars-Peter Clausen wrote: On 01/14/2015 08:43 AM, Takashi Iwai wrote: At Tue, 13 Jan 2015 21:54:12 +, Mark Brown wrote: On Tue, Jan 13, 2015 at 06:24:44PM +0100, Takashi Iwai wrote: Wang, Jiada (ESD) wrote

Re: [alsa-devel] unload Audio drivers while playback stream is active case kernel crash

2015-01-14 Thread Lars-Peter Clausen
On 01/14/2015 01:02 PM, Mark Brown wrote: [...] I don't think that we need to prevent module unload when a stream is active. From a framework point of view is not different from hot-unplug. I don't see a reason why we'd jump through hoops to actively forbid removing the module once it works

Re: [PATCH v2] ASoC: wm8904: fix runtime warning

2015-01-13 Thread Lars-Peter Clausen
On 01/13/2015 10:34 AM, Bo Shen wrote: [...] - { "AIFOUTL", "Left", "ADCL" }, - { "AIFOUTL", "Right", "ADCR" }, - { "AIFOUTR", "Left", "ADCL" }, - { "AIFOUTR", "Right", "ADCR" }, + { "AIFOUTL Mux", "Left", "ADCL" }, + { "AIFOUTL Mux", "Right", "ADCR" }, +

Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning

2015-01-13 Thread Lars-Peter Clausen
On 01/13/2015 06:36 AM, Bo Shen wrote: Hi Lars-Perter Clausen, On 01/12/2015 05:30 PM, Lars-Peter Clausen wrote: On 01/12/2015 04:32 AM, Bo Shen wrote: [...] diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index 4d2d2b1..38582d7 100644 --- a/sound/soc/codecs/wm8904.c +++ b

Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning

2015-01-13 Thread Lars-Peter Clausen
On 01/13/2015 06:36 AM, Bo Shen wrote: Hi Lars-Perter Clausen, On 01/12/2015 05:30 PM, Lars-Peter Clausen wrote: On 01/12/2015 04:32 AM, Bo Shen wrote: [...] diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index 4d2d2b1..38582d7 100644 --- a/sound/soc/codecs/wm8904.c +++ b

Re: [PATCH v2] ASoC: wm8904: fix runtime warning

2015-01-13 Thread Lars-Peter Clausen
On 01/13/2015 10:34 AM, Bo Shen wrote: [...] - { AIFOUTL, Left, ADCL }, - { AIFOUTL, Right, ADCR }, - { AIFOUTR, Left, ADCL }, - { AIFOUTR, Right, ADCR }, + { AIFOUTL Mux, Left, ADCL }, + { AIFOUTL Mux, Right, ADCR }, + { AIFOUTR Mux, Left, ADCL }, +

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-12 Thread Lars-Peter Clausen
On 01/12/2015 02:54 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 17:16 +0100, Lars-Peter Clausen wrote: On 01/09/2015 05:14 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:54 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:50 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:41

Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning

2015-01-12 Thread Lars-Peter Clausen
On 01/12/2015 04:32 AM, Bo Shen wrote: [...] diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index 4d2d2b1..38582d7 100644 --- a/sound/soc/codecs/wm8904.c +++ b/sound/soc/codecs/wm8904.c @@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route adc_intercon[] = { {

Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning

2015-01-12 Thread Lars-Peter Clausen
On 01/12/2015 04:32 AM, Bo Shen wrote: [...] diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index 4d2d2b1..38582d7 100644 --- a/sound/soc/codecs/wm8904.c +++ b/sound/soc/codecs/wm8904.c @@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route adc_intercon[] = { {

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-12 Thread Lars-Peter Clausen
On 01/12/2015 02:54 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 17:16 +0100, Lars-Peter Clausen wrote: On 01/09/2015 05:14 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:54 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:50 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:41

Re: [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO_BUF

2015-01-10 Thread Lars-Peter Clausen
On 01/08/2015 05:40 PM, Karol Wrona wrote: iio kfifo can be used without trigger support so there is no need to build it. Signed-off-by: Karol Wrona Looks good, not sure why this was ever selected it in the first place. Reviewed-by: Lars-Peter Clausen --- drivers/iio/Kconfig |1

Re: [PATCH 1/2] iio: Add no-triggered buffer helper functions

2015-01-10 Thread Lars-Peter Clausen
On 01/08/2015 05:40 PM, Karol Wrona wrote: These ones helps to create and manage iio_kfifo buffer when no-triggered buffer is used. [...] +int iio_notriggered_buffer_setup(struct iio_dev *indio_dev, +const struct iio_buffer_setup_ops *setup_ops) + +{ + int

Re: [PATCH 1/2] iio: Add no-triggered buffer helper functions

2015-01-10 Thread Lars-Peter Clausen
On 01/08/2015 05:40 PM, Karol Wrona wrote: These ones helps to create and manage iio_kfifo buffer when no-triggered buffer is used. [...] +int iio_notriggered_buffer_setup(struct iio_dev *indio_dev, +const struct iio_buffer_setup_ops *setup_ops) + +{ + int

Re: [PATCH 2/2] iio: Deselect IIO_TRIGGER for IIO_KFIFO_BUF

2015-01-10 Thread Lars-Peter Clausen
On 01/08/2015 05:40 PM, Karol Wrona wrote: iio kfifo can be used without trigger support so there is no need to build it. Signed-off-by: Karol Wrona k.wr...@samsung.com Looks good, not sure why this was ever selected it in the first place. Reviewed-by: Lars-Peter Clausen l...@metafoo.de

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 05:14 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:54 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:50 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:41 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:38 PM, Ivan T. Ivanov wrote: Instead of checking whether

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 04:50 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:41 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:38 PM, Ivan T. Ivanov wrote: Instead of checking whether provider module is still loaded on every access to device just lock module to memory when client get reference

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 04:38 PM, Ivan T. Ivanov wrote: Instead of checking whether provider module is still loaded on every access to device just lock module to memory when client get reference to provider device. This has nothing to do with the module, it's about the device. In the Linux device

Re: [alsa-devel] [PATCH] ASoC: rockchip: i2s: add rockchip_dmaengine_pcm_config

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 02:52 AM, Jianqun Xu wrote: This patch makes snd_dmaengine_pcm_register with rockchip_dmaengine_pcm_config, which configure the parameters of period and buffer match to rockchip DMAC. === without rockchip_dmaengine_pcm_config, and test with command - aplay -D

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 04:38 PM, Ivan T. Ivanov wrote: Instead of checking whether provider module is still loaded on every access to device just lock module to memory when client get reference to provider device. This has nothing to do with the module, it's about the device. In the Linux device

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 04:50 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:41 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:38 PM, Ivan T. Ivanov wrote: Instead of checking whether provider module is still loaded on every access to device just lock module to memory when client get reference

Re: [PATCH] iio: Simplify IIO provider access locking mechanism

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 05:14 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:54 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:50 PM, Ivan T. Ivanov wrote: On Fri, 2015-01-09 at 16:41 +0100, Lars-Peter Clausen wrote: On 01/09/2015 04:38 PM, Ivan T. Ivanov wrote: Instead of checking whether

Re: [alsa-devel] [PATCH] ASoC: rockchip: i2s: add rockchip_dmaengine_pcm_config

2015-01-09 Thread Lars-Peter Clausen
On 01/09/2015 02:52 AM, Jianqun Xu wrote: This patch makes snd_dmaengine_pcm_register with rockchip_dmaengine_pcm_config, which configure the parameters of period and buffer match to rockchip DMAC. === without rockchip_dmaengine_pcm_config, and test with command - aplay -D

Re: [RFC PATCH] iio: Add new operating mode for non triggered sw buffers

2015-01-08 Thread Lars-Peter Clausen
Cameron Signed-off-by: Karol Wrona Looks good, thanks. Reviewed-by: Lars-Peter Clausen --- drivers/iio/industrialio-buffer.c |2 ++ include/linux/iio/iio.h |6 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/industrialio-buffer.c b

Re: [RFC PATCH] iio: Add new operating mode for non triggered sw buffers

2015-01-08 Thread Lars-Peter Clausen
Cameron ji...@kernel.org Signed-off-by: Karol Wrona k.wr...@samsung.com Looks good, thanks. Reviewed-by: Lars-Peter Clausen l...@metafoo.de --- drivers/iio/industrialio-buffer.c |2 ++ include/linux/iio/iio.h |6 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-07 Thread Lars-Peter Clausen
On 01/07/2015 05:13 PM, Arnd Bergmann wrote: On Wednesday 07 January 2015 15:29:36 Lars-Peter Clausen wrote: On 01/06/2015 02:48 PM, Arnd Bergmann wrote: On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-07 Thread Lars-Peter Clausen
On 01/06/2015 02:48 PM, Arnd Bergmann wrote: On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-07 Thread Lars-Peter Clausen
On 01/06/2015 02:48 PM, Arnd Bergmann wrote: On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-07 Thread Lars-Peter Clausen
On 01/07/2015 05:13 PM, Arnd Bergmann wrote: On Wednesday 07 January 2015 15:29:36 Lars-Peter Clausen wrote: On 01/06/2015 02:48 PM, Arnd Bergmann wrote: On Tuesday 06 January 2015 11:45:58 Lars-Peter Clausen wrote: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/06/2015 01:47 PM, Måns Rullgård wrote: Lars-Peter Clausen writes: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really incompatible

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really incompatible with the way that other drivers use the dmaengine API, so we should get rid of it.

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really incompatible with the way that other drivers use the dmaengine API, so we should get rid of it.

Re: [PATCH, RFC] MIPS: jz4740: use dma filter function

2015-01-06 Thread Lars-Peter Clausen
On 01/06/2015 01:47 PM, Måns Rullgård wrote: Lars-Peter Clausen l...@metafoo.de writes: On 01/05/2015 11:39 PM, Arnd Bergmann wrote: As discussed on the topic of shmobile DMA today, jz4740 is the only user of the slave_id field in dma_slave_config besides shmobile. This use is really

Re: [alsa-devel] [PATCH 1/3] ASoC: samsung: Add machine driver for Trats2

2015-01-05 Thread Lars-Peter Clausen
Hi, A few small comments inline. On 01/05/2015 12:25 PM, Inha Song wrote: --- /dev/null +++ b/sound/soc/samsung/trats2_wm1811.c @@ -0,0 +1,216 @@ [...] +#include +#include +#include +#include +#include +#include "i2s.h" +#include "i2s-regs.h" You probably don't need i2s-regs.h

Re: [alsa-devel] [PATCH 1/3] ASoC: samsung: Add machine driver for Trats2

2015-01-05 Thread Lars-Peter Clausen
Hi, A few small comments inline. On 01/05/2015 12:25 PM, Inha Song wrote: --- /dev/null +++ b/sound/soc/samsung/trats2_wm1811.c @@ -0,0 +1,216 @@ [...] +#include linux/of.h +#include linux/module.h +#include linux/clk.h +#include sound/soc.h +#include sound/pcm_params.h +#include i2s.h

Re: [PATCH] ASoC: adi: Add missing return statement.

2014-12-31 Thread Lars-Peter Clausen
On 12/31/2014 05:20 PM, Andrew Jackson wrote: From: Andrew Jackson The probe routine was disabling the clock even if the system was configured successfully. Add a return statement to leave clocks enabled. Signed-off-by: Andrew Jackson Acked-by: Lars-Peter Clausen Thanks, never noticed

Re: [PATCH] ASoC: adi: Add missing return statement.

2014-12-31 Thread Lars-Peter Clausen
-by: Lars-Peter Clausen l...@metafoo.de Thanks, never noticed since the clock is shared with other peripherals. --- Spotted while reviewing clock preparation sound/soc/adi/axi-i2s.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi

Re: [RFC PATCH 0/3] Introduce IIO interface for fingerprint sensors

2014-12-18 Thread Lars-Peter Clausen
Adding V4L folks to Cc for more input. On 12/08/2014 03:10 PM, Baluta, Teodora wrote: Hello, On Vi, 2014-12-05 at 02:15 +, Jonathan Cameron wrote: On 04/12/14 13:00, Teodora Baluta wrote: This patchset adds support for fingerprint sensors through the IIO interface. This way userspace

Re: [RFC PATCH 2/2] iio: kfifo: Add resource management devm_iio_kfifo_allocate/free

2014-12-18 Thread Lars-Peter Clausen
On 12/09/2014 08:29 PM, Karol Wrona wrote: iio kfifo allocate/free gained their devm_ wrappers. Change-Id: I10c19ccd7c01491caf088b3629137425ddccd29c Signed-off-by: Karol Wrona Suggested-by: Jonathan Cameron Looks good to me. [...] +struct iio_buffer *devm_iio_kfifo_allocate(struct device

Re: [RFC PATCH 1/2] iio: kfifo: Remove unused argument in iio_kfifo_allocate

2014-12-18 Thread Lars-Peter Clausen
On 12/09/2014 08:29 PM, Karol Wrona wrote: indio_dev was unused in function body plus some small style fix - add new lines after "if(sth) return sth" and before the last return statement. Looks good, except for the missing updates for the users. Doing some digging in the git history raveled

Re: [PATCH v3] sound/soc/adi/axi-spdif.c: Support programmable master clock

2014-12-18 Thread Lars-Peter Clausen
r anyway. To detect if the source clock is fixed, the driver calls clk_round_rate for two frequencies. If the results are equal, or if the call returns an error, the driver assumes the clock is fixed. Signed-off-by: Mike Looijmans Acked-by: Lars-Peter Clausen Thanks. -- To unsubscribe from this

Re: [PATCH v3] sound/soc/adi/axi-spdif.c: Support programmable master clock

2014-12-18 Thread Lars-Peter Clausen
clock is fixed, the driver calls clk_round_rate for two frequencies. If the results are equal, or if the call returns an error, the driver assumes the clock is fixed. Signed-off-by: Mike Looijmans mike.looijm...@topic.nl Acked-by: Lars-Peter Clausen l...@metafoo.de Thanks. -- To unsubscribe

Re: [RFC PATCH 1/2] iio: kfifo: Remove unused argument in iio_kfifo_allocate

2014-12-18 Thread Lars-Peter Clausen
On 12/09/2014 08:29 PM, Karol Wrona wrote: indio_dev was unused in function body plus some small style fix - add new lines after if(sth) return sth and before the last return statement. Looks good, except for the missing updates for the users. Doing some digging in the git history raveled

Re: [RFC PATCH 2/2] iio: kfifo: Add resource management devm_iio_kfifo_allocate/free

2014-12-18 Thread Lars-Peter Clausen
On 12/09/2014 08:29 PM, Karol Wrona wrote: iio kfifo allocate/free gained their devm_ wrappers. Change-Id: I10c19ccd7c01491caf088b3629137425ddccd29c Signed-off-by: Karol Wrona k.wr...@samsung.com Suggested-by: Jonathan Cameron ji...@kernel.org Looks good to me. [...] +struct iio_buffer

<    6   7   8   9   10   11   12   13   14   15   >