Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-21 Thread Lars-Peter Clausen
On 03/18/2013 11:43 AM, Sebastian Hesselbarth wrote: > This patch adds a common clock driver for Silicon Labs Si5351a/b/c > i2c programmable clock generators. Currently, the driver supports > DT kernels only and VXCO feature of si5351b is not implemented. DT > bindings selectively allow to overwrit

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-03-16 Thread Lars-Peter Clausen
On 03/16/2013 01:37 AM, Doug Anderson wrote: > On Fri, Mar 15, 2013 at 2:53 PM, Lars-Peter Clausen wrote: >> What exactly is the spinlock protecting against here? Concurrent runs of >> exynos_adc_isr? This is probably not issue in the first place. >> >> What you want

Re: [RFC: PATCH 2/2] iio: adc: exynos_adc: Handle timeout and race conditions

2013-03-15 Thread Lars-Peter Clausen
derson > Cc: Lars-Peter Clausen > --- > Discussion thread for this patch can be found at > http://www.gossamer-threads.com/lists/linux/kernel/1693284?page=last > > I've not seen any reference to spin lock usage in IIO. > Kindly, suggest me if there is a better way to avoi

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Lars-Peter Clausen
On 03/13/2013 07:35 PM, Lars-Peter Clausen wrote: > On 03/13/2013 07:23 PM, Doug Anderson wrote: >> Lars, >> >> On Wed, Mar 13, 2013 at 11:11 AM, Lars-Peter Clausen wrote: >>> Agreed. Adding the dependency on OF in Kconfig should be all that is needed. >>

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Lars-Peter Clausen
On 03/13/2013 07:23 PM, Doug Anderson wrote: > Lars, > > On Wed, Mar 13, 2013 at 11:11 AM, Lars-Peter Clausen wrote: >> Agreed. Adding the dependency on OF in Kconfig should be all that is needed. > > I think changing the timeout from 'unsigned long' to '

Re: [PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-13 Thread Lars-Peter Clausen
On 03/13/2013 07:01 PM, Doug Anderson wrote: > Naveen, > > On Tue, Mar 12, 2013 at 9:48 PM, Naveen Krishna Chatradhi > wrote: >> Doug, There was a comment from Lars regarding the match not >> being NULL, if driver depends on CONFIG_OF. So, i've removed >> the NULL check in v2 of this patch. >>

[PATCH] regmap: Fix regcache-rbtree sync

2013-03-13 Thread Lars-Peter Clausen
upply ranges to the sync operations"). Cc: sta...@vger.kernel.org Signed-off-by: Lars-Peter Clausen --- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c ind

Re: [PATCH] backlight: da903x_bl: switch to using SIMPLE_DEV_PM_OPS

2013-03-12 Thread Lars-Peter Clausen
On 03/12/2013 06:48 AM, Jingoo Han wrote: > This reduces #ifdefs in the code. Also, CONFIG_PM_SLEEP is used > to avoid warnings of unused functions if CONFIG_PM_SLEEP is not > defined. > > Signed-off-by: Jingoo Han I think you can eliminate the suspend/resume functions all together by using the

Re: [PATCH linux-next v2] ASoC: adau1373: adau1373_hw_params: Silence overflow warning

2013-03-11 Thread Lars-Peter Clausen
~ADAU1373_BCLKDIV_SOURCE as the mask, which for this register is > functionally equivalent to ADAU1373_BCLKDIV_SR_MASK | > ADAU1373_BCLKDIV_BCLK_MASK. > > Cc: Lars-Peter Clausen > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: dev

Re: [PATCH 2/4] tty: max310x: Use dev_pm_ops

2013-03-11 Thread Lars-Peter Clausen
acy suspend/resume for the >>>>>> max310x driver. >>>>>> >>>>>> Cc: Alexander Shiyan >>>>>> Signed-off-by: Lars-Peter Clausen >>>>>> --- >>>>>> drivers/tty/serial/max310x.c | 24 +++

Re: [PATCH] ASoC: adau1373: adau1373_hw_params: Silence overflow warning

2013-03-11 Thread Lars-Peter Clausen
On 03/11/2013 04:37 PM, Tim Gardner wrote: > On 03/11/2013 04:01 AM, Lars-Peter Clausen wrote: >> On 03/10/2013 06:34 PM, Tim Gardner wrote: >>> ADAU1373_BCLKDIV_SOURCE is defined as BIT(5) which uses UL constants. On >>> amd64 the result of the ones complement op

Re: [PATCH 2/4] tty: max310x: Use dev_pm_ops

2013-03-11 Thread Lars-Peter Clausen
On 03/11/2013 07:41 PM, Alexander Shiyan wrote: >> On 03/11/2013 07:10 PM, Alexander Shiyan wrote: >>> Hello. >>> >>>> Use dev_pm_ops instead of the deprecated legacy suspend/resume for the >>>> max310x driver. >>>> >&

Re: [PATCH 2/4] tty: max310x: Use dev_pm_ops

2013-03-11 Thread Lars-Peter Clausen
On 03/11/2013 07:10 PM, Alexander Shiyan wrote: > Hello. > >> Use dev_pm_ops instead of the deprecated legacy suspend/resume for the >> max310x driver. >> >> Cc: Alexander Shiyan >> Signed-off-by: Lars-Peter Clausen >> --- >> drivers/tty/seri

[PATCH 3/4] tty: mrst_max3110: Use dev_pm_ops

2013-03-11 Thread Lars-Peter Clausen
Use dev_pm_ops instead of the deprecated legacy suspend/resume for the mrst_max3110 driver. Cc: Alan Cox Signed-off-by: Lars-Peter Clausen --- drivers/tty/serial/mrst_max3110.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/tty/serial

[PATCH 2/4] tty: max310x: Use dev_pm_ops

2013-03-11 Thread Lars-Peter Clausen
Use dev_pm_ops instead of the deprecated legacy suspend/resume for the max310x driver. Cc: Alexander Shiyan Signed-off-by: Lars-Peter Clausen --- drivers/tty/serial/max310x.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial

[PATCH 4/4] tty: ifx6x60: Remove unused suspend/resume callbacks

2013-03-11 Thread Lars-Peter Clausen
: Chen Jun Signed-off-by: Lars-Peter Clausen --- drivers/tty/serial/ifx6x60.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c index 68d7ce9..ae63c14 100644 --- a/drivers/tty/serial/ifx6x60.c +++ b/drivers/tty

[PATCH 1/4] tty: max3100: Use dev_pm_ops

2013-03-11 Thread Lars-Peter Clausen
Use dev_pm_ops instead of the deprecated legacy suspend/resume for the max3100 driver. Signed-off-by: Lars-Peter Clausen --- drivers/tty/serial/max3100.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial

Re: [PATCH v4 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-03-11 Thread Lars-Peter Clausen
[...] > * struct with auxiliary transfer status information, otherwise the call > * will just return a simple status code > * @device_issue_pending: push pending transactions to hardware > + * @device_slave_sg_limits: return the slave SG capabilities > */ > struct dma_device { > > @@

[PATCH v3] clk: Add axi-clkgen driver

2013-03-11 Thread Lars-Peter Clausen
ff-by: Lars-Peter Clausen --- Changes since v2: * Use devm_ioremap_resource() instead of devm_request_and_ioremap() Changes since v1: * Fix error in the filter coef lookup table * Use unsigend long long arithmetic to avoid overflow when calculating the current

Re: [PATCH] ASoC: adau1373: adau1373_hw_params: Silence overflow warning

2013-03-11 Thread Lars-Peter Clausen
warning that the upper 32 bits are lost. > > sound/soc/codecs/adau1373.c: In function 'adau1373_hw_params': > sound/soc/codecs/adau1373.c:940:3: warning: large integer implicitly > truncated to unsigned type [-Woverflow] > > gcc version 4.6.3 > > Cc: Lars-Peter

[PATCH 5/5] power: pm2301_charger: Remove no-op suspend/resume callbacks

2013-03-10 Thread Lars-Peter Clausen
Having suspend/resume callbacks which do nothing other then return 0 are functional equivalent to having no suspend/resume callbacks. So just remove these no-op suspend/resume callbacks. Cc: Lee Jones Signed-off-by: Lars-Peter Clausen --- drivers/power/pm2301_charger.c | 13 - 1

[PATCH 4/5] power: pm2301_charger: Remove __dev* annotations

2013-03-10 Thread Lars-Peter Clausen
_remove' undeclared here (not in a function) This patch removes the __dev* annotations, which fixes the build errors. Cc: Lee Jones Signed-off-by: Lars-Peter Clausen --- drivers/power/pm2301_charger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH 3/5] power: sbs-battery: Use dev_pm_ops

2013-03-10 Thread Lars-Peter Clausen
Use dev_pm_ops instead of the deprecated legacy suspend/resume callbacks. Cc: Rhyland Klein Signed-off-by: Lars-Peter Clausen --- drivers/power/sbs-battery.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/power/sbs-battery.c b/drivers/power/sbs

[PATCH 1/5] power: ds2782_battery: Use dev_pm_ops

2013-03-10 Thread Lars-Peter Clausen
Use dev_pm_ops instead of the deprecated legacy suspend/resume callbacks. Cc: Evgeny Romanov Signed-off-by: Lars-Peter Clausen --- drivers/power/ds2782_battery.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/power/ds2782_battery.c b

[PATCH 2/5] power: max17040_battery: Use dev_pm_ops

2013-03-10 Thread Lars-Peter Clausen
Use dev_pm_ops instead of the deprecated legacy suspend/resume callbacks. Cc: Minkyu Kang Signed-off-by: Lars-Peter Clausen --- drivers/power/max17040_battery.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/power/max17040_battery.c b/drivers

[PATCH 3/6] i2c: Ignore return value of i2c_del_adapter()

2013-03-09 Thread Lars-Peter Clausen
: Benjamin Herrenschmidt Cc: Lars Poeschel Signed-off-by: Lars-Peter Clausen --- drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 3 +-- drivers/i2c/busses/i2c-amd756-s4882.c| 6 +- drivers/i2c/busses/i2c-at91.c| 5 ++--- drivers/i2c/busses/i2c-cbus-gpio.c | 4

[PATCH 0/6] Make return type of i2c_del_adapter() (and i2c_del_mux_adapter()) void

2013-03-09 Thread Lars-Peter Clausen
also updated in this series. - Lars Lars-Peter Clausen (6): i2c: Remove detach_adapter i2c: i2c_del_adapter: Don't treat removing a non-registered adapter as error i2c: Ignore return value of i2c_del_adapter() i2c: Make return type of i2c_del_adapter() void i2c: Ignore the ret

[PATCH 4/6] i2c: Make return type of i2c_del_adapter() void

2013-03-09 Thread Lars-Peter Clausen
s. Signed-off-by: Lars-Peter Clausen --- drivers/i2c/i2c-core.c | 6 ++ include/linux/i2c.h| 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 7727d33..838d030 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/

[PATCH 1/6] i2c: Remove detach_adapter

2013-03-09 Thread Lars-Peter Clausen
The detach_adapter callback has been deprecated for quite some time and has no user left. Keeping it alive blocks other cleanups, so remove it. Signed-off-by: Lars-Peter Clausen --- drivers/i2c/i2c-core.c | 33 ++--- include/linux/i2c.h| 7 ++- 2 files

[PATCH 2/6] i2c: i2c_del_adapter: Don't treat removing a non-registered adapter as error

2013-03-09 Thread Lars-Peter Clausen
I2C adapter from the system. If the adapter is not registered in the first place this becomes a no-op. So we can return success without having to do anything. Signed-off-by: Lars-Peter Clausen --- drivers/i2c/i2c-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 6/6] i2c: Make the return type of i2c_del_mux_adapter() void

2013-03-09 Thread Lars-Peter Clausen
ed to fail. This is the case for i2c_del_mux_adapter(), so make its return type void to make the fact that it won't fail explicit. Signed-off-by: Lars-Peter Clausen --- drivers/i2c/i2c-mux.c | 4 +--- include/linux/i2c-mux.h | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 5/6] i2c: Ignore the return value of i2c_del_mux_adapter()

2013-03-09 Thread Lars-Peter Clausen
). A subsequent patch will make the return type of i2c_del_mux_adapter() void. Cc: Guenter Roeck Signed-off-by: Lars-Peter Clausen --- drivers/i2c/muxes/i2c-mux-pca954x.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c

Re: RFC: Zynq Clock Controller

2013-03-08 Thread Lars-Peter Clausen
On 03/08/2013 06:38 PM, Sören Brinkmann wrote: > On Fri, Mar 08, 2013 at 08:12:20AM +0100, Lars-Peter Clausen wrote: >> On 03/08/2013 12:25 AM, Sören Brinkmann wrote: >>> On Thu, Mar 07, 2013 at 11:02:58PM +0100, Lars-Peter Clausen wrote: >>>> On 03/07/2013 0

Re: RFC: Zynq Clock Controller

2013-03-07 Thread Lars-Peter Clausen
On 03/08/2013 12:25 AM, Sören Brinkmann wrote: > On Thu, Mar 07, 2013 at 11:02:58PM +0100, Lars-Peter Clausen wrote: >> On 03/07/2013 08:11 PM, Sören Brinkmann wrote: >>> On Thu, Mar 07, 2013 at 10:36:35AM +0100, Lars-Peter Clausen wrote: >>>> On 03/06/2013 0

Re: RFC: Zynq Clock Controller

2013-03-07 Thread Lars-Peter Clausen
On 03/07/2013 08:11 PM, Sören Brinkmann wrote: > On Thu, Mar 07, 2013 at 10:36:35AM +0100, Lars-Peter Clausen wrote: >> On 03/06/2013 06:27 PM, Sören Brinkmann wrote: >>> Hi Jan, >>> >>> what a small world. Good to hear from you. >>> >>> On

Re: RFC: Zynq Clock Controller

2013-03-07 Thread Lars-Peter Clausen
On 03/06/2013 06:27 PM, Sören Brinkmann wrote: > Hi Jan, > > what a small world. Good to hear from you. > > On Wed, Mar 06, 2013 at 12:51:21PM +0100, Jan Lübbe wrote: >> Hi Sören, >> >> On Tue, 2013-03-05 at 12:04 -0800, Sören Brinkmann wrote: >>> For this reasons, I'd like to propose moving Zyn

Re: [PATCH] iio: adc: exynos5_adc: fix compilation warnings

2013-03-06 Thread Lars-Peter Clausen
On 03/06/2013 05:11 AM, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Ch > > Fixes the compilation warnings and potential NULL pointer > dereferencing pointed out by "Dan Carpenter". > I'd say that's a rather un-potential NULL pointer dereferencing, but if it makes the static checkers

Re: linux-next: Tree for Mar 4 (iio)

2013-03-04 Thread Lars-Peter Clausen
On 03/04/2013 07:40 PM, Randy Dunlap wrote: > On 03/03/13 19:43, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20130301: >> > > on x86_64: > > warning: (AD7606 && AD799X_RING_BUFFER && MXS_LRADC && IIO_ADIS_LIB_BUFFER && > INV_MPU6050_IIO && HID_SENSOR_ACCEL_3D && AD_SIGMA_DELTA && AD72

Re: [PATCH v5] iio: Add OF support

2013-02-25 Thread Lars-Peter Clausen
; to get it accepted, please let me know. > Was kind of hoping for a few ack/ reviewed by comments! Missed current merge > window so I will pick it up for start of next cycle and assume silence means > everyone else is happy! The latest version looked good to me, you can add my: Reviewed-

Re: [PATCH 09/16] ia64 idle: delete pm_idle

2013-02-21 Thread Lars-Peter Clausen
On 02/10/2013 06:58 AM, Len Brown wrote: > From: Len Brown > > pm_idle() on ia64 was a synonym for default_idle(). > So simply invoke default_idle() directly. > > Signed-off-by: Len Brown > Cc: linux-i...@vger.kernel.org > --- > arch/ia64/kernel/process.c | 3 --- > arch/ia64/kernel/setup.c

[PATCH] microblaze idle: Fix compile error

2013-02-21 Thread Lars-Peter Clausen
arch/microblaze/kernel/process.c:100: error: (Each undeclared identifier is reported only once arch/microblaze/kernel/process.c:100: error: for each function it appears in.) arch/microblaze/kernel/process.c:106: error: implicit declaration of function 'idle' This pa

[PATCH] blackfin idle: Fix compile error

2013-02-21 Thread Lars-Peter Clausen
ocess.c:83: error: (Each undeclared identifier is reported only once arch/blackfin/kernel/process.c:83: error: for each function it appears in.) arch/blackfin/kernel/process.c:88: error: implicit declaration of function ‘idle’ This patch fixes it. Signed-off-by: Lars-Peter Clausen

Re: [PATCH 05/16] blackfin idle: delete pm_idle

2013-02-20 Thread Lars-Peter Clausen
On 02/20/2013 08:59 PM, Rafael J. Wysocki wrote: > On Wednesday, February 20, 2013 08:53:38 PM Lars-Peter Clausen wrote: >> On 02/20/2013 08:52 PM, Rafael J. Wysocki wrote: >>> On Monday, February 18, 2013 05:28:19 PM Lars-Peter Clausen wrote: >>>> On 02/10/

Re: [PATCH 05/16] blackfin idle: delete pm_idle

2013-02-20 Thread Lars-Peter Clausen
On 02/20/2013 08:52 PM, Rafael J. Wysocki wrote: > On Monday, February 18, 2013 05:28:19 PM Lars-Peter Clausen wrote: >> On 02/10/2013 06:58 AM, Len Brown wrote: >>> From: Len Brown >>> >>> pm_idle is dead code on blackfin. >>> >>

[PATCH] backlight: adp8860/adp8870: Fix resume

2013-02-19 Thread Lars-Peter Clausen
Clearing the NSTBY bit in the control register also automatically clears the BLEN bit. So we need to make sure to set it again during resume, otherwise the backlight will stay off. Cc: sta...@vger.kernel.org Signed-off-by: Lars-Peter Clausen --- drivers/video/backlight/adp8860_bl.c | 2

Re: [PATCH] dma: timb_dma: Fix compiler warning

2013-02-19 Thread Lars-Peter Clausen
On 02/18/2013 08:59 PM, maxin.j...@gmail.com wrote: > From: "Maxin B. John" > > Fix this compiler warning: > warning: 'td_remove' defined but not used [-Wunused-function] > > Signed-off-by: Maxin B. John > --- > drivers/dma/timb_dma.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-

[PATCH] mfd:adp5520: Restore mode bits on resume

2013-02-19 Thread Lars-Peter Clausen
The adp5520 unfortunately also clears the BL_EN bit when the nSTNDBY bit is cleared. So we need to make sure to restore it during resume if it was set before suspend. Cc: sta...@vger.kernel.org Signed-off-by: Lars-Peter Clausen --- drivers/mfd/adp5520.c | 8 ++-- 1 file changed, 6

Re: [PATCH 05/16] blackfin idle: delete pm_idle

2013-02-18 Thread Lars-Peter Clausen
On 02/10/2013 06:58 AM, Len Brown wrote: > From: Len Brown > > pm_idle is dead code on blackfin. > > Signed-off-by: Len Brown > Cc: uclinux-dist-de...@blackfin.uclinux.org > --- > arch/blackfin/kernel/process.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/arch/blackfin/kerne

Re: [PATCH v2] clk: Add axi-clkgen driver

2013-02-16 Thread Lars-Peter Clausen
On 02/16/2013 03:52 AM, Mike Turquette wrote: > Quoting Lars-Peter Clausen (2013-01-23 06:04:52) >> +static const struct of_device_id axi_clkgen_ids[] = { >> + { .compatible = "adi,axi-clkgen-1.00.a" }, >> + { }, >> +}; >> +MODULE_DEVICE_TAB

Re: Query related to MSR(Magnetic Stripe Reader) Device Driver

2013-02-15 Thread Lars-Peter Clausen
On 02/15/2013 12:18 PM, Priyaranjan Das wrote: > Hi Greg, > > On Thu, Jan 31, 2013 at 11:09 AM, Priyaranjan Das > wrote: >> Hi Greg, >> >> On Tue, Jan 29, 2013 at 7:03 PM, Greg KH wrote: >>> On Mon, Jan 28, 2013 at 03:25:08PM +0530, Priyaranjan Das wrote: Hi Greg, On Tue, Jan 22,

Re: [PATCH v7] iio: adc: add exynos adc driver under iio framwork

2013-02-15 Thread Lars-Peter Clausen
On 02/15/2013 02:17 PM, Naveen Krishna Ch wrote: > On 15 February 2013 18:43, Lars-Peter Clausen wrote: >> On 02/15/2013 07:56 AM, Naveen Krishna Chatradhi wrote: >>> This patch adds New driver to support: >>> 1. Supports ADC IF found on EXYNOS4412/EXYNOS5250 >>

Re: [PATCH v7] iio: adc: add exynos adc driver under iio framwork

2013-02-15 Thread Lars-Peter Clausen
ngs > > Signed-off-by: Naveen Krishna Chatradhi Looks good. Reviewed-by: Lars-Peter Clausen One minor thing though, there are a couple of places where you break a line into multiple lines, even though the line fits easily inside the 80 chars per line limit. In my opinion this doesn't

Re: [PATCH v6] iio: adc: add exynos adc driver under iio framwork

2013-02-14 Thread Lars-Peter Clausen
On 02/14/2013 01:11 PM, Naveen Krishna Chatradhi wrote: > This patch adds New driver to support: > 1. Supports ADC IF found on EXYNOS4412/EXYNOS5250 >and future SoCs from Samsung > 2. Add ADC driver under iio/adc framework > 3. Also adds the Documentation for device tree bindings > > Signed-of

Re: iio: adc: add exynos5 adc driver under iio framwork

2013-02-13 Thread Lars-Peter Clausen
On 02/13/2013 02:53 PM, Naveen Krishna Ch wrote: [...] >>> ADC driver will use of_platform_populate() to populate the child nodes >>> (ntc thermistors in my case) >>> >>> I've modified the NTC driver to support DT. in probe >>> chan = iio_channel_get(&pdev->dev, "adcX"); >>> and using "id" field to

Re: iio: adc: add exynos5 adc driver under iio framwork

2013-02-13 Thread Lars-Peter Clausen
On 02/13/2013 02:16 PM, Naveen Krishna Ch wrote: > Please ignore the unfinished previous mail. > > > > On 13 February 2013 08:18, Naveen Krishna Ch > wrote: >> On 13 February 2013 02:37, Guenter Roeck wrote: >>> On Wed, Jan 23, 2013 at 04:58:06AM -, Naveen Krishna Chatradhi wrote: Th

Re: [PATCH v3] IIO ADC support for AD7923

2013-02-13 Thread Lars-Peter Clausen
On 02/13/2013 07:47 AM, Christophe Leroy wrote: > This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. > > Signed-off-by: Patrick Vasseur > Signed-off-by: Christophe Leroy Looks good, thanks. Reviewed-by: Lars-Peter Clausen > > diff -urN linux-ne

Re: [PATCH v2] IIO ADC support for AD7923

2013-02-12 Thread Lars-Peter Clausen
On 02/12/2013 06:10 PM, Christophe Leroy wrote: > This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. > > Signed-off-by: Patrick Vasseur > Signed-off-by: Christophe Leroy Looks good to me except for one small, but important issue. [...] > diff -urN linux-next-e347c98/dr

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 08:15 PM, Tomasz Figa wrote: > Hi, > > On Thursday 24 of January 2013 19:19:57 Lars-Peter Clausen wrote: >> On 01/24/2013 05:12 PM, Doug Anderson wrote: >>> Lars, >>> >>> Thank you for your comments / thoughts... >> >> Hi, >

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 05:12 PM, Doug Anderson wrote: > Lars, > > Thank you for your comments / thoughts... > Hi, > > On Thu, Jan 24, 2013 at 1:54 AM, Lars-Peter Clausen wrote: >> adc: adc@12D1 { >> >> #io-channel-cells = <1>; >>

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 03:20 PM, Naveen Krishna Ch wrote: > On 24 January 2013 15:24, Lars-Peter Clausen wrote: >> >> On 01/24/2013 01:42 AM, Doug Anderson wrote: >>> Lars, >>> >>> On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen wrote: >>>>> Fe

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-24 Thread Lars-Peter Clausen
On 01/24/2013 01:42 AM, Doug Anderson wrote: > Lars, > > On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen wrote: >>> Few doubts regarding the mappings and child device handling. >>> Kindly, suggest me better methods. >> >> The patch looks mostly good n

[PATCH v2] clk: Add axi-clkgen driver

2013-01-23 Thread Lars-Peter Clausen
ff-by: Lars-Peter Clausen --- Changes since v1: * Fix error in the filter coef lookup table * Use unsigend long long arithmetic to avoid overflow when calculating the current clock frequency. * Use readl/writel instead of ioread32/iowrite32 --- .../devicetree/bin

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-23 Thread Lars-Peter Clausen
On 01/23/2013 05:58 AM, Naveen Krishna Chatradhi wrote: > This patch add an ADC IP found on EXYNOS5 series socs from Samsung. > Also adds the Documentation for device tree bindings. > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v1: > > 1. Fixed comments from Lars > 2. Added s

Re: [PATCH] clk: Add axi-clkgen driver

2013-01-23 Thread Lars-Peter Clausen
On 01/23/2013 11:27 AM, Russell King - ARM Linux wrote: > On Wed, Jan 23, 2013 at 11:00:56AM +0100, Lars-Peter Clausen wrote: >> I think I read somewhere at some point that ioread{8,16,32} is preferred >> over write{b,h,l} in new code. > > But... there's *no* point us

Re: [PATCH] clk: Add axi-clkgen driver

2013-01-23 Thread Lars-Peter Clausen
On 01/22/2013 06:55 PM, Mike Turquette wrote: > Quoting Lars-Peter Clausen (2013-01-09 10:12:00) > >> +static void axi_clkgen_write(struct axi_clkgen *axi_clkgen, >> + unsigned int reg, unsigned int val) >> +{ >> + iowrite32(val, axi_clkgen->base

Re: [PATCH] clk: Add axi-clkgen driver

2013-01-23 Thread Lars-Peter Clausen
On 01/22/2013 07:08 PM, Josh Cartwright wrote: > On Wed, Jan 09, 2013 at 07:12:00PM +0100, Lars-Peter Clausen wrote: >> This driver adds support for the AXI clkgen pcore to the common clock >> framework. >> The AXI clkgen pcore is a AXI front-end to the MMCM_ADV frequency sy

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-22 Thread Lars-Peter Clausen
Hi, On 01/21/2013 02:37 PM, Naveen Krishna Chatradhi wrote: > This patch add an ADC IP found on EXYNOS5 series socs from Samsung. > Also adds the Documentation for device tree bindings. >[...] > diff --git a/drivers/iio/adc/exynos5_adc.c b/drivers/iio/adc/exynos5_adc.c > new file mode 100644 > ind

Re: [PATCH] staging/iio: Use correct argument for sizeof

2013-01-22 Thread Lars-Peter Clausen
On 01/22/2013 07:43 AM, Dan Carpenter wrote: > On Mon, Jan 21, 2013 at 10:14:02PM +0100, Peter Huewe wrote: >> found with coccicheck >> sizeof when applied to a pointer typed expression gives the size of >> the pointer >> > > The original code is correct, in this case. We're storing an array > of

Re: [PATCH] power: bq27x00_battery: Export all battery registers via sysfs

2013-01-20 Thread Lars-Peter Clausen
On 01/19/2013 03:01 PM, Pali Rohár wrote: > bq27xxx batteries have a lot of properties, more than power_supply interface. > Some of them can be usefull for userspace applications (like CI bit) but > does not make sense to add bq specified property to power_supply interface. > When bq27x00_battery i

Re: [PATCH v3 4/8] MFD: ti_am335x_tscadc: add device tree binding information

2013-01-19 Thread Lars-Peter Clausen
Hi, On 01/18/2013 11:48 AM, Patil, Rachna wrote: > From: "Patil, Rachna" > > Signed-off-by: Patil, Rachna > --- > .../devicetree/bindings/mfd/ti_am335x_tscadc.txt | 35 > > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ti

Re: [PATCH] IIO ADC support for AD7923

2013-01-19 Thread Lars-Peter Clausen
.git;a=blob;f=drivers/iio/adc/ad7298.c;h=b34d754994d50d53f60fee694440658ba0b137dd;hb=HEAD > > We are a bit new comers in Kernel Development, so thanks for your help. > > Christophe > > Le 08/01/2013 11:27, Lars-Peter Clausen a écrit : >> On 01/08/2013 09:42 AM, Christoph

Re: [PATCH] IIO ADC support for AD7923

2013-01-17 Thread Lars-Peter Clausen
On 01/17/2013 06:11 PM, Alessandro Rubini wrote: >>> I wonder if IIO config symbols should have IIO_ in their name, so >>> people looking at config files knows what they actually are. >>> Actually, all USB drivers have USB in their config name, which is >>> useful even if e.g. "PL2303" cannot be bu

Re: [PATCH] IIO ADC support for AD7923

2013-01-12 Thread Lars-Peter Clausen
On 01/08/2013 10:14 AM, Alessandro Rubini wrote: >> +config AD7923 > > I wonder if IIO config symbols should have IIO_ in their name, so > people looking at config files knows what they actually are. > Actually, all USB drivers have USB in their config name, which is > useful even if e.g. "PL2303"

Re: [PATCH 1/3] spi: Add helper functions for setting up transfers

2013-01-10 Thread Lars-Peter Clausen
On 01/10/2013 09:53 AM, Julia Lawall wrote: >> +@r1@ >> +identifier fn; >> +identifier xfers; >> +@@ >> +fn(...) >> +{ >> +... >> +( >> +struct spi_transfer xfers[...]; >> +| >> +struct spi_transfer xfers[]; >> +) >> +... >> +} > > Can it happen that there would be more than one sp

Re: [PATCH 1/3] spi: Add helper functions for setting up transfers

2013-01-09 Thread Lars-Peter Clausen
On 01/09/2013 08:20 PM, Jonathan Cameron wrote: > On 01/09/2013 05:31 PM, Lars-Peter Clausen wrote: >> Quite often the pattern used for setting up and transferring a synchronous >> SPI >> transaction looks very much like the following: >> >> struc

[PATCH] clk: Add axi-clkgen driver

2013-01-09 Thread Lars-Peter Clausen
ff-by: Lars-Peter Clausen --- .../devicetree/bindings/clock/axi-clkgen.txt | 22 ++ drivers/clk/Kconfig| 8 + drivers/clk/Makefile | 1 + drivers/clk/clk-axi-clkgen.c | 326 + 4

[PATCH 2/3] iio: Use spi_sync_transfer()

2013-01-09 Thread Lars-Peter Clausen
Use the new spi_sync_transfer() helper function instead of open-coding it. Signed-off-by: Lars-Peter Clausen --- drivers/iio/dac/ad5360.c | 7 +-- drivers/iio/dac/ad5421.c | 7 +-- drivers/iio/dac/ad5504.c | 6 +- drivers/iio/dac/ad5686.c | 7

[PATCH 3/3] staging:iio: Use spi_sync_transfer()

2013-01-09 Thread Lars-Peter Clausen
Use the new spi_sync_transfer() helper function instead of open-coding it. Signed-off-by: Lars-Peter Clausen --- drivers/staging/iio/accel/kxsd9.c | 6 +--- drivers/staging/iio/accel/lis3l02dq_core.c | 18 ++-- drivers/staging/iio/accel/sca3000_core.c | 13 ++--- drivers

[PATCH 1/3] spi: Add helper functions for setting up transfers

2013-01-09 Thread Lars-Peter Clausen
pt which can detect such sequences as described above and transform them automatically to use the new helper functions. Signed-off-by: Lars-Peter Clausen --- I'm not entirely happy with names of the two new functions and I'm open for better suggestions. --- include/linux/spi/spi.h

Re: [PATCH] IIO ADC support for AD7923

2013-01-08 Thread Lars-Peter Clausen
On 01/08/2013 09:42 AM, Christophe Leroy wrote: > This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem. > > Signed-off-by: Patrick Vasseur > Signed-off-by: Christophe Leroy Hi, Thanks for the driver, looks pretty good. Some comments inline. - Lars > > diff -uN linux-3.

Re: Support for Marvell 88E1510 and 88E1116R

2013-01-02 Thread Lars-Peter Clausen
On 01/02/2013 10:58 AM, Michal Simek wrote: > Hi guys, > > just a question regarding to Marvell 88e1510 and 88E1116R phys. > We have these phys on the arm zynq board and would like to add > support to the kernel. Is there any repository with these phys? > If yes, when are you going to add them to

Re: [PATCH] staging:iio:adis16260: select IIO_ADIS_LIB to fix build error

2012-12-30 Thread Lars-Peter Clausen
fined! > ERROR: "adis_read_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined! > ERROR: "adis_single_conversion" [drivers/staging/iio/gyro/adis16260.ko] > undefined! > > Selecting IIO_ADIS_LIB at Kconfig file fixes this issue. > > Reported-by: Fengg

Re: [PATCH 4/4 v4] rtc: add rtc-driver for HID sensors of type time

2012-12-14 Thread Lars-Peter Clausen
On 12/14/2012 04:24 PM, Alexander Holler wrote: > Am 14.12.2012 15:34, schrieb Lars-Peter Clausen: >> On 12/14/2012 03:29 PM, Alexander Holler wrote: >>> Am 14.12.2012 15:15, schrieb Alexander Holler: >>>> Am 14.12.2012 14:08, schrieb Alexander Holler: >>>>

Re: [PATCH 4/4 v4] rtc: add rtc-driver for HID sensors of type time

2012-12-14 Thread Lars-Peter Clausen
On 12/14/2012 03:29 PM, Alexander Holler wrote: > Am 14.12.2012 15:15, schrieb Alexander Holler: >> Am 14.12.2012 14:08, schrieb Alexander Holler: >>> Am 14.12.2012 10:42, schrieb Lars-Peter Clausen: >> >>>> And another thing I've overlooked before: >&

Re: [PATCH 1/6] iio: adc: ad7266: Don't set error code to st->vref_uv

2012-12-14 Thread Lars-Peter Clausen
On 12/14/2012 08:47 AM, Axel Lin wrote: > regulator_get_voltage() may return negative error code. > Add error checking to avoid setting error code to st->vref_uv. > > Signed-off-by: Axel Lin Thanks Axel, for the whole series: Acked-by: Lars-Peter Clausen > --- > dri

Re: [PATCH 4/4 v4] rtc: add rtc-driver for HID sensors of type time

2012-12-14 Thread Lars-Peter Clausen
On 12/12/2012 12:11 PM, Alexander Holler wrote: > This driver makes the time from HID sensors (hubs) which are offering > such available like any other RTC does. > > Currently the time can only be read. Setting the time must be done > through sending a report, which currently isn't supported by >

Re: [PATCH 4/4 v3] rtc: add rtc-driver for HID sensors of type time

2012-12-12 Thread Lars-Peter Clausen
On 12/12/2012 11:14 AM, Alexander Holler wrote: > Am 12.12.2012 10:51, schrieb Lars-Peter Clausen: > >> Looks good, but as I wrote during the last review the __devinits need to go. >> A few other suggerstions online > > Oh, have forgotten it. Ok, will make a v4, changing

Re: [PATCH 4/4 v3] rtc: add rtc-driver for HID sensors of type time

2012-12-12 Thread Lars-Peter Clausen
On 12/11/2012 07:21 PM, Alexander Holler wrote: > This driver makes the time from HID sensors (hubs) which are offering > such available like any other RTC does. > > Currently the time can only be read. Setting the time must be done > through sending a report, which currently isn't supported by >

Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

2012-12-11 Thread Lars-Peter Clausen
On 12/11/2012 10:31 AM, Jonathan Cameron wrote: > On 10/12/12 22:50, Alexander Holler wrote: >> Am 10.12.2012 22:42, schrieb Jonathan Cameron: >>> On 12/10/2012 09:39 PM, Lars-Peter Clausen wrote: >>>> On 12/10/2012 10:26 PM, Alexander Holler wrote: >>>>

Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

2012-12-10 Thread Lars-Peter Clausen
On 12/10/2012 11:20 PM, Alexander Holler wrote: > [...] >>> +init_completion(&time_state->comp_last_time); >> >> This needs to be INIT_COMPLETION. init_completion must be called exactly >> once on a completion, which should be from inside probe() in this case. > > Ah, so I've misread http://lw

Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

2012-12-10 Thread Lars-Peter Clausen
On 12/10/2012 10:26 PM, Alexander Holler wrote: > Am 10.12.2012 21:22, schrieb Lars-Peter Clausen: >> On 12/10/2012 08:45 PM, Alexander Holler wrote: >>> Am 10.12.2012 18:05, schrieb Lars-Peter Clausen: >>> >>>> Looks pretty good now. But there are still

Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

2012-12-10 Thread Lars-Peter Clausen
On 12/10/2012 08:45 PM, Alexander Holler wrote: > Am 10.12.2012 18:05, schrieb Lars-Peter Clausen: > >> Looks pretty good now. But there are still some IIO remnants which should be >> removed as well. Also the driver should move to drivers/rtc/ since, well, >> it's

Re: [PATCH 3/3 v2] iio: add rtc-driver for HID sensors of type time

2012-12-10 Thread Lars-Peter Clausen
On 12/10/2012 03:51 PM, Alexander Holler wrote: > This driver makes the time from HID sensors (hubs) which are offering > such available like any other RTC does. > > Currently the time can only be read. Setting the time must be done > through sending a report, which currently isn't supported by >

Re: linux-next: fetch failure the xilinx tree

2012-12-10 Thread Lars-Peter Clausen
On 12/09/2012 06:24 AM, Stephen Rothwell wrote: > Hi John, > > Attempting to fetch the xilinx tree produces this error (and has for some > days, now): > > fatal: The remote end hung up unexpectedly > They renamed the repository from linux-2.6-xlnx to linux-xlnx. I stumbled over it as well. - L

Re: [PATCH 3/3] iio: add rtc-driver for HID sensors of type time

2012-12-09 Thread Lars-Peter Clausen
On 12/09/2012 07:16 PM, Alexander Holler wrote: > Am 09.12.2012 17:40, schrieb Alexander Holler: >> Am 09.12.2012 13:55, schrieb Lars-Peter Clausen: >>> On 12/09/2012 01:21 PM, Alexander Holler wrote: >>>> This driver makes the time from HID sensors (hubs) which ar

Re: [PATCH 3/3] iio: add rtc-driver for HID sensors of type time

2012-12-09 Thread Lars-Peter Clausen
On 12/09/2012 01:21 PM, Alexander Holler wrote: > This driver makes the time from HID sensors (hubs) which are offering > such available like any other RTC does. > > Currently the time can only be read. Setting the time must be done > through sending a report, which currently isn't supported by >

[PATCH resend] spi: Add support for specifying 3-wire mode via device tree

2012-12-06 Thread Lars-Peter Clausen
This patch allows to specify that a SPI device is connected in 3-wire mode via device tree. Signed-off-by: Lars-Peter Clausen Acked-by: Rob Herring --- Documentation/devicetree/bindings/spi/spi-bus.txt | 2 ++ drivers/spi/spi.c | 2 ++ 2 files changed, 4

Re: [PATCH RFT] spi: spi-xcomm: Fix wrong setting for SPI_XCOMM_SETTINGS_CPHA

2012-12-05 Thread Lars-Peter Clausen
On 12/04/2012 07:27 AM, Axel Lin wrote: > The logic of setting SPI_XCOMM_SETTINGS_CPHA bit is reversed. > > Signed-off-by: Axel Lin > --- > Hi Lars, > The logic of setting SPI_XCOMM_SETTINGS_CPHA bit looks wrong to me. > Can you check if this patch works? > > Thanks, > Axel Hi Axel, Thanks for

Re: [PATCH 1/5] asm-generic/mmu.h: Remove unused vmlist field from mm_context_t

2012-12-03 Thread Lars-Peter Clausen
On 12/04/2012 12:54 AM, Arnd Bergmann wrote: > On Thursday 01 November 2012, Lars-Peter Clausen wrote: >> Nothing is using the vmlist field in mm_context_t anymore. It has been >> removed >> from the non-generic versions over 3 years ago 8feae1311 ("NOMMU: Make VMAs &g

Re: [PATCH 5/5] xtensa: Use generic asm/mmu.h for nommu

2012-12-03 Thread Lars-Peter Clausen
field from the mm_context_t struct in asm-generic/mmu.h. So without that patch this patch basically doubles the size of your mm_context_t. - Lars > > On 11/1/12 3:24 AM, Lars-Peter Clausen wrote: >> The nommu portion of mmu.h of the extensa platform is basically the >> same as the >>

<    7   8   9   10   11   12   13   14   >