mpiler not
initializing the holes ? Maybe something along the lines of
video_put_user() is copying uninitialized stack memory to userspace due
to the compiler not initializing holes in the structures declared on the
stack. Fix it by initializing the structures using memset().
Reviewed-by: Laurent Pi
Hi Peilin,
On Sun, Jul 26, 2020 at 02:07:52PM -0400, Peilin Ye wrote:
> On Sun, Jul 26, 2020 at 08:30:44PM +0300, Laurent Pinchart wrote:
> > Hi Peilin,
> >
> > Thank you for the patch.
> >
> > On Sun, Jul 26, 2020 at 12:44:39PM -0400, Peilin Ye wrote:
sequence = vb->sequence;
> + vb32.memory = vb->memory;
> + vb32.m.userptr = vb->m.userptr;
> + vb32.length = vb->length;
> + vb32.request_fd = vb->request_fd;
>
> if (copy_to_user(arg, , sizeof(vb32)))
> return -EFAULT;
--
Regards,
Laurent Pinchart
ocess/index.rst b/Documentation/process/index.rst
> index f07c9250c3ac..ed861f6f8d25 100644
> --- a/Documentation/process/index.rst
> +++ b/Documentation/process/index.rst
> @@ -27,6 +27,7 @@ Below are the essential guides that every developer should
> read.
> submitting-patches
> programming-language
> coding-style
> + inclusive-terminology
> maintainer-pgp-guide
> email-clients
> kernel-enforcement-statement
--
Regards,
Laurent Pinchart
| DRM_BRIDGE_OP_EDID
> | DRM_BRIDGE_OP_HPD;
> adv7511->bridge.of_node = dev->of_node;
> + adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
>
> drm_bridge_add(>bridge);
>
--
Regards,
Laurent Pinchart
Hi Tomasz,
On Wed, Jul 22, 2020 at 07:12:12PM +0200, Tomasz Figa wrote:
> On Wed, Jul 22, 2020 at 6:30 PM Laurent Pinchart wrote:
> > On Wed, Jul 22, 2020 at 03:24:59PM +, Tomasz Figa wrote:
> > > On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote:
> &g
Hi Dafna and Tomasz,
On Wed, Jul 22, 2020 at 03:24:59PM +, Tomasz Figa wrote:
> On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote:
> > On 16.08.19 02:13, Laurent Pinchart wrote:
> > > On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote:
>
> [snip
_bridge_attach_flags flags)
> > +{
> > + struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
> > + int ret;
> > +
> > + if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) {
> > + dev_err(lt9611->dev, "Fix bridge driver to make connector
> > optional!");
> > + return -EINVAL;
> > + }
>
> This should say that the display driver should be fixed.
> If a display driver expects this bridge to create the connector
> it would not work.
Actually, for new bridge drivers, connector creation should be optional
from the start. We don't want a failure in that case, the feature should
be implemented.
--
Regards,
Laurent Pinchart
f the bridge
> structure was left unset, which makes the helper function always return
> -EINVAL.
>
> Signed-off-by: Laurentiu Palcu
Reviewed-by: Laurent Pinchart
> ---
> Hi,
>
> I've hit this while trying to use this helper in the new i.MX8MQ DCSS
> driver, as
Hi Swapnil,
Thank you for the patch.
On Wed, Jul 22, 2020 at 09:40:39AM +0200, Swapnil Jakhade wrote:
> Add a new DRM bridge driver for Cadence MHDP DPTX IP used in TI J721e SoC.
> MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and
> embedded Display Port (eDP) standards.
eturn 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Reviewed-by: Laurent Pinchart
I expect Sakari to take this patch in his tree when he will be back from
vacation at the end of the month.
> ---
> Continuing
Hi Guido,
Thank you for the patch.
On Sat, Jul 18, 2020 at 08:26:37PM +0200, Guido Günther wrote:
> We don't create a connector but let panel_bridge handle that so there's
> no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR.
>
> Signed-off-by: Guido Günther
Reviewed-by: Laur
Hi Vishal,
Thank you for the patch.
Hans, there are a few questions for you below.
On Thu, Jun 25, 2020 at 11:43:01AM +0200, Hans Verkuil wrote:
> On 18/06/2020 07:33, Vishal Sagar wrote:
> > The Xilinx UHD-SDI Rx subsystem soft IP is used to capture native SDI
> > streams from SDI sources like
ne-rate = ;
> > + clocks = <_1>, <_1>, <_2>;
> > + clock-names = "s_axi_aclk", "sdi_rx_clk", "video_out_clk";
> > + xlnx,bpc = <10>;
I would group the xlnx,* properties after the standard properties.
> > +
> > + ports {
> > +#address-cells = <1>;
> > +#size-cells = <0>;
> > +port@0 {
> > + reg = <0>;
> > + sdirx_out: endpoint {
> > +remote-endpoint = <_sdirx_in>;
> > + };
> > +};
> > + };
> > +};
> > +...
> > diff --git a/include/dt-bindings/media/xilinx-sdi.h
> > b/include/dt-bindings/media/xilinx-sdi.h
> > new file mode 100644
> > index ..11938fade041
> > --- /dev/null
> > +++ b/include/dt-bindings/media/xilinx-sdi.h
> > @@ -0,0 +1,20 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Xilinx SDI device tree bindings
> > + *
> > + * Copyright (C) 2020 Xilinx, Inc.
> > + *
> > + * Contacts: Vishal Sagar
> > + */
> > +
> > +#ifndef __DT_BINDINGS_MEDIA_XILINX_SDI_H__
> > +#define __DT_BINDINGS_MEDIA_XILINX_SDI_H__
> > +
> > +/*
> > + * SDI Configurations
> > + */
> > +#define XSDI_STD_3G0
> > +#define XSDI_STD_6G1
> > +#define XSDI_STD_12G_8DS 2
> > +
> > +#endif /* __DT_BINDINGS_MEDIA_XILINX_SDI_H__ */
--
Regards,
Laurent Pinchart
_DV_FL_HAS_CEA861_VIC, { 0, 0 }, 115) \
> +}
> +
> #define V4L2_DV_BT_CEA_4096X2160P50 { \
> .type = V4L2_DV_BT_656_1120, \
> V4L2_INIT_BT_TIMINGS(4096, 2160, 0, \
> @@ -297,7 +327,6 @@
> V4L2_DV_FL_HAS_CEA861_VIC, { 0, 0 }, 102) \
> }
>
> -
This seems to be an unrelated change. Apart from that,
Reviewed-by: Laurent Pinchart
> /* VESA Discrete Monitor Timings as per version 1.0, revision 12 */
>
> #define V4L2_DV_BT_DMT_640X350P85 { \
--
Regards,
Laurent Pinchart
t; return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>
> Signed-off-by: Alexander A. Klimov
Reviewed-by: Laurent Pinchart
Will you get this patch merged as part of a bigger series, or do you
expect us to take care of it ? In the latter ca
> --- a/drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2011 Texas Instruments Incorporated - https://www.ti.com/
> * Author: Rob Clark
> */
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c
> b/drivers/gpu/drm/omapdrm/omap_irq.c
> index 382bcdc72ac0..de80cd3455c8 100644
> --- a/drivers/gpu/drm/omapdrm/omap_irq.c
> +++ b/drivers/gpu/drm/omapdrm/omap_irq.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2011 Texas Instruments Incorporated - https://www.ti.com/
> * Author: Rob Clark
> */
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
> b/drivers/gpu/drm/omapdrm/omap_plane.c
> index 73ec99819a3d..21e0b9785599 100644
> --- a/drivers/gpu/drm/omapdrm/omap_plane.c
> +++ b/drivers/gpu/drm/omapdrm/omap_plane.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2011 Texas Instruments Incorporated - https://www.ti.com/
> * Author: Rob Clark
> */
>
> diff --git a/drivers/gpu/drm/omapdrm/tcm-sita.c
> b/drivers/gpu/drm/omapdrm/tcm-sita.c
> index 817be3c41863..9e1acbd2c7aa 100644
> --- a/drivers/gpu/drm/omapdrm/tcm-sita.c
> +++ b/drivers/gpu/drm/omapdrm/tcm-sita.c
> @@ -5,7 +5,7 @@
> * Lajos Molnar
> * Andy Gross
> *
> - * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/
> + * Copyright (C) 2012 Texas Instruments Incorporated - https://www.ti.com/
> *
> * This package is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License version 2 as
--
Regards,
Laurent Pinchart
20 *ctx, u16 addr)
> {
> - u8 ret;
> + u8 ret = 0;
>
> sii8620_read_buf(ctx, addr, , 1);
> return ret;
--
Regards,
Laurent Pinchart
Hi Dafna,
On Fri, Jul 10, 2020 at 02:59:36PM +0200, Dafna Hirschfeld wrote:
> On 15.08.19 20:46, Laurent Pinchart wrote:
> > On Tue, Jul 30, 2019 at 03:42:45PM -0300, Helen Koike wrote:
> >> From: Jeffy Chen
> >>
> >> Add the header for userspace
> >>
Hi GVRao,
Thank you for pinging me privately.
On Mon, Jun 22, 2020 at 02:19:22PM +, Venkateshwar Rao Gannavarapu wrote:
> On Wednesday, June 17, 2020 3:18 AM, Laurent Pinchart wrote:
> > On Tue, Jun 09, 2020 at 02:48:25AM +, Venkateshwar Rao Gannavarapu
> > wrote:
contributors.
That's an interesting point, because to me, it's the exact opposite. One
of the intellectual rewards I find in working with the kernel is that
our community is international and multicultural, allowing me to learn
about other cultures. Aiming for the lowest common denominator seems to
me to be closer to erasing cultural differences than including them.
--
Regards,
Laurent Pinchart
xp-lpcg.c | 4 ++
> drivers/clk/imx/clk-imx8qxp.c | 4 ++
> drivers/clk/imx/clk-pll14xx.c | 5 ++
> drivers/clk/imx/clk-sscg-pll.c | 2 +
> drivers/clk/imx/clk-vf610.c| 5 ++
> drivers/clk/imx/clk.c | 17 +--
> drivers/clk/imx/clk.h | 6 +++
> 26 files changed, 231 insertions(+), 57 deletions(-)
--
Regards,
Laurent Pinchart
Hi Tobias,
On Wed, Jul 01, 2020 at 04:07:09PM +0200, Tobias Klauser wrote:
> On 2020-07-01 at 16:01:08 +0200, Laurent Pinchart
> wrote:
> > On Wed, Jul 01, 2020 at 04:00:26PM +0200, Tobias Klauser wrote:
> >> On 2020-07-01 at 15:44:43 +0200, Laurent Pinchart
> >>
On Wed, Jul 01, 2020 at 04:00:26PM +0200, Tobias Klauser wrote:
> On 2020-07-01 at 15:44:43 +0200, Laurent Pinchart
> wrote:
> > On Wed, Jul 01, 2020 at 07:06:43PM +0530, Vinod Koul wrote:
> > > On 01-07-20, 16:19, Laurent Pinchart wrote:
> > > > On Wed, Jul 01,
dd DT bindings for Xilinx ZynqMP PSGTR
PHY")
Signed-off-by: Laurent Pinchart
---
Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml
b/Documentation/
Hi Vinod,
On Wed, Jul 01, 2020 at 07:06:43PM +0530, Vinod Koul wrote:
> On 01-07-20, 16:19, Laurent Pinchart wrote:
> > On Wed, Jul 01, 2020 at 11:04:38AM +0200, Tobias Klauser wrote:
> > > This fixes the following compiler warning when building with
> > > CO
Hi Rob,
On Mon, Jun 29, 2020 at 04:30:11PM -0600, Rob Herring wrote:
> On Mon, 29 Jun 2020 15:00:52 +0300, Laurent Pinchart wrote:
> > From: Anurag Kumar Vulisha
> >
> > Add DT bindings for the Xilinx ZynqMP PHY. ZynqMP SoCs have a High Speed
> > Processing Syste
int xpsgtr_suspend(struct device *dev)
> |^~
Oops :-S Sorry about that.
Reviewed-by: Laurent Pinchart
Vinod or Kishon, can you pick this patch up, or do I need to send a pull
request ? (It's my first driver in the PHY subsystem so I don't know
what the usual practices are there)
> Sig
such case where absence of a graph in a
> device-tree is a legit condition.
>
> This patch adds of_graph_is_present() which returns true if given
> device-tree node contains OF graph port.
>
> Reviewed-by: Rob Herring
> Signed-off-by: Dmitry Osipenko
Reviewed-by: Laure
Hi Rob,
Thank you for the patch.
On Tue, Jun 30, 2020 at 02:02:16PM -0600, Rob Herring wrote:
> Convert the analog TV, DVI, HDMI, and VGA connector bindings to DT schema
> format.
>
> Cc: Sam Ravnborg
> Cc: Laurent Pinchart
> Cc: Maxime Ripard
> Signed-off-by: R
;
> int of_graph_get_endpoint_count(const struct device_node *np);
> @@ -56,6 +57,11 @@ struct device_node *of_graph_get_remote_node(const struct
> device_node *node,
> u32 port, u32 endpoint);
> #else
>
> +static inline bool of_graph_is_present(const struct device_node *node)
> +{
> + return false;
> +}
> +
> static inline int of_graph_parse_endpoint(const struct device_node *node,
> struct of_endpoint *endpoint)
> {
--
Regards,
Laurent Pinchart
Hi Vinod,
On Mon, Jun 29, 2020 at 06:49:17PM +0530, Vinod Koul wrote:
> On 29-06-20, 15:00, Laurent Pinchart wrote:
> > Hello,
> >
> > The patch series adds a PHY driver for the Xilinx ZynqMP gigabit serial
> > transceivers (PS-GTR). The PS-GTR is a set of 4 PHYs that
Hi Ramzi,
On Mon, Jun 29, 2020 at 11:24:13AM +0200, Ramzi Ben Meftah wrote:
> On Fri, Jun 26, 2020 at 04:12:51AM +0300, Laurent Pinchart wrote:
> > On Thu, Jun 25, 2020 at 10:41:09AM -0700, Steve Longerbeam wrote:
> >> On 6/24/20 7:01 PM, Laurent Pinchart wrote:
> >>&
-by: Anurag Kumar Vulisha
Signed-off-by: Laurent Pinchart
---
Changes since v8:
- Enable compilation with COMPILE_TEST
- Fix years in copyright notice
- Rebase on phy/next
Changes since v7:
- Move driver to xilinx subdirectory
- Fix typo in MAINTAINERS
- Remove dash lines in section header comments
Bindings
+
+maintainers:
+ - Laurent Pinchart
+
+description: |
+ This binding describes the Xilinx ZynqMP Gigabit Transceiver (GTR) PHY. The
+ GTR provides four lanes and is used by USB, SATA, PCIE, Display port and
+ Ethernet SGMII controllers.
+
+properties:
+ "#phy-cells":
+
Add a DT node for the PS-GTR transceivers.
Signed-off-by: Laurent Pinchart
Acked-by: Michal Simek
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
index
in MAINTAINERS has been fixed.
[1] https://patchwork.kernel.org/cover/10735681/
Anurag Kumar Vulisha (2):
dt-bindings: phy: Add DT bindings for Xilinx ZynqMP PSGTR PHY
phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver
Laurent Pinchart (1):
arm64: dts: zynqmp: Add GTR
Hi Vinod,
On Mon, Jun 29, 2020 at 03:09:43PM +0530, Vinod Koul wrote:
> On 13-05-20, 20:22, Laurent Pinchart wrote:
> > Hello,
> >
> > The patch series adds a PHY driver for the Xilinx ZynqMP gigabit serial
> > transceivers (PS-GTR). The PS-GTR is a set of 4 PHYs that
Hi Sam,
On Sun, Jun 28, 2020 at 09:52:45AM +0200, Sam Ravnborg wrote:
> On Sun, Jun 28, 2020 at 10:07:45AM +0300, Laurent Pinchart wrote:
> > On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote:
> >> 27.06.2020 23:43, Laurent Pinchart пишет:
> >>> On M
.compatible = "starry,kr070pe2t",
> + .data = _kr070pe2t,
> }, {
> .compatible = "starry,kr122ea0sra",
> .data = _kr122ea0sra,
--
Regards,
Laurent Pinchart
gt; }, {
> .compatible = "samsung,ltn140at29-301",
> .data = _ltn140at29_301,
> + }, {
> + .compatible = "satoz,sat050at40h12r2",
> + .data = _sat050at40h12r2,
> }, {
> .compatible = "sharp,ld-d5116z01b",
> .data = _ld_d5116z01b,
--
Regards,
Laurent Pinchart
Hi Dmitry,
On Sun, Jun 28, 2020 at 02:44:15AM +0300, Dmitry Osipenko wrote:
> 27.06.2020 23:43, Laurent Pinchart пишет:
> > On Mon, Jun 22, 2020 at 01:27:42AM +0300, Dmitry Osipenko wrote:
> >> This patch adds missing BUS fields to the display panel descriptions of
> >>
070WP03XG
> 3. Chunghwa CLAA101WA01A
> 4. Chunghwa CLAA101WB01
> 5. Innolux N156BGE L21
> 6. Samsung LTN101NT05
>
> Suggested-by: Laurent Pinchart
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/gpu/drm/panel/panel-simple.c | 12
> 1 file changed, 12 in
er will tell you why.
Regardless, drivers/staging/media/soc_camera/soc_camera.c is in staging
because it will be removed from the kernel, cleanups for this file won't
be accepted.
> static int soc_camera_try_fmt(struct soc_camera_device *icd,
> struct v4l2_format *f)
--
Regards,
Laurent Pinchart
Hi Steve,
On Thu, Jun 25, 2020 at 10:41:09AM -0700, Steve Longerbeam wrote:
> On 6/24/20 7:01 PM, Laurent Pinchart wrote:
> > On Wed, Jun 24, 2020 at 09:53:07AM +0200, Jacopo Mondi wrote:
> >> On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote:
> >&
Hi Ramzi,
On Thu, Jun 25, 2020 at 12:18:35PM +0200, Ramzi Ben Meftah wrote:
> On Thu, Jun 25, 2020 at 12:47:24PM +0300, Laurent Pinchart wrote:
> > On Thu, Jun 25, 2020 at 11:30:46AM +0200, Ramzi Ben Meftah wrote:
> >> On Thu, Jun 25, 2020 at 05:01:38AM +0300, Laurent Pinchart w
Hi Ramzi,
On Thu, Jun 25, 2020 at 11:30:46AM +0200, Ramzi Ben Meftah wrote:
> On Thu, Jun 25, 2020 at 05:01:38AM +0300, Laurent Pinchart wrote:
> > On Wed, Jun 24, 2020 at 09:53:07AM +0200, Jacopo Mondi wrote:
> >> On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH
O_RDWR | (flags & EFD_SHARED_FCNTL_FLAGS));
> >>if (IS_ERR(file))
> >>eventfd_free_ctx(ctx);
> >> diff --git a/include/linux/eventfd.h b/include/linux/eventfd.h
> >> index ff0b981..87de343 100644
> >> --- a/include/linux/eventfd.h
> >> +++ b/include/linux/eventfd.h
> >> @@ -8,23 +8,11 @@
> >> #ifndef _LINUX_EVENTFD_H
> >> #define _LINUX_EVENTFD_H
> >>
> >> +#include
> >> +
> >> #include
> >> #include
> >>
> >> -/*
> >> - * CAREFUL: Check include/uapi/asm-generic/fcntl.h when defining
> >> - * new flags, since they might collide with O_* ones. We want
> >> - * to re-use O_* flags that couldn't possibly have a meaning
> >> - * from eventfd, in order to leave a free define-space for
> >> - * shared O_* flags.
> >> - */
> >> -#define EFD_SEMAPHORE (1 << 0)
> >> -#define EFD_CLOEXEC O_CLOEXEC
> >> -#define EFD_NONBLOCK O_NONBLOCK
> >> -
> >> -#define EFD_SHARED_FCNTL_FLAGS (O_CLOEXEC | O_NONBLOCK)
> >> -#define EFD_FLAGS_SET (EFD_SHARED_FCNTL_FLAGS | EFD_SEMAPHORE)
> >> -
> >> struct file;
> >>
> >> #ifdef CONFIG_EVENTFD
> >> diff --git a/include/uapi/linux/eventfd.h b/include/uapi/linux/eventfd.h
> >> new file mode 100644
> >> index 000..097dcad
> >> --- /dev/null
> >> +++ b/include/uapi/linux/eventfd.h
> >> @@ -0,0 +1,33 @@
> >> +/*
> >> + * Copyright (C) 2013 Martin Sustrik
> >> + *
> >> + * This program is free software; you can redistribute it and/or modify
> >> + * it under the terms of the GNU General Public License as published by
> >> + * the Free Software Foundation; either version 2 of the License, or
> >> + * (at your option) any later version.
> >> + */
> >> +
> >> +#ifndef _UAPI_LINUX_EVENTFD_H
> >> +#define _UAPI_LINUX_EVENTFD_H
> >> +
> >> +/* For O_CLOEXEC */
> >> +#include
> >> +#include
> >> +
> >> +/*
> >> + * CAREFUL: Check include/asm-generic/fcntl.h when defining
> >> + * new flags, since they might collide with O_* ones. We want
> >> + * to re-use O_* flags that couldn't possibly have a meaning
> >> + * from eventfd, in order to leave a free define-space for
> >> + * shared O_* flags.
> >> + */
> >> +
> >> +/* Provide semaphore-like semantics for reads from the eventfd. */
> >> +#define EFD_SEMAPHORE (1 << 0)
> >> +/* Provide event mask semantics for the eventfd. */
> >> +#define EFD_MASK (1 << 1)
> >> +/* Set the close-on-exec (FD_CLOEXEC) flag on the eventfd. */
> >> +#define EFD_CLOEXEC O_CLOEXEC
> >> +/* Create the eventfd in non-blocking mode. */
> >> +#define EFD_NONBLOCK O_NONBLOCK
> >> +#endif /* _UAPI_LINUX_EVENTFD_H */
--
Regards,
Laurent Pinchart
(*g_tvnorms_output)(struct v4l2_subdev *sd, v4l2_std_id *std);
> > int (*g_input_status)(struct v4l2_subdev *sd, u32 *status);
> > + int (*enuminput)(struct v4l2_subdev *sd, struct v4l2_input *input);
> > + int (*g_input)(struct v4l2_subdev *sd, u32 *index);
> > + int (*s_input)(struct v4l2_subdev *sd, u32 index);
> > int (*s_stream)(struct v4l2_subdev *sd, int enable);
> > int (*g_pixelaspect)(struct v4l2_subdev *sd, struct v4l2_fract *aspect);
> > int (*g_frame_interval)(struct v4l2_subdev *sd,
--
Regards,
Laurent Pinchart
Hi Andrzej,
On Wed, Jun 24, 2020 at 04:03:30PM +0200, Andrzej Hajda wrote:
> On 24.06.2020 15:33, Laurent Pinchart wrote:
> > On Wed, Jun 24, 2020 at 01:41:27PM +0200, Andrzej Hajda wrote:
> >> Using probe_err code has following advantages:
> >> - shorter code,
> &g
Hi Vinod,
On Wed, Jun 24, 2020 at 10:56:35PM +0530, Vinod Koul wrote:
> On 24-06-20, 19:39, Laurent Pinchart wrote:
>
> > > > +/* Number of GT lanes */
> > > > +#define NUM_LANES 4
> > >
> > > Should this be coded in driver li
-by: Anurag Kumar Vulisha
Signed-off-by: Laurent Pinchart
---
Changes since v8:
- Enable compilation with COMPILE_TEST
- Fix years in copyright notice
Changes since v7:
- Move driver to xilinx subdirectory
- Fix typo in MAINTAINERS
- Remove dash lines in section header comments
- Fix wrong indentation
Hi Vinod,
On Wed, Jun 24, 2020 at 08:41:21PM +0530, Vinod Koul wrote:
> Hi Laurent,
>
> Mostly this looks fine to me, some minor nitpicks below:
>
> On 13-05-20, 20:22, Laurent Pinchart wrote:
> > +config PHY_XILINX_ZYNQMP
> > + tristate "Xilinx Zy
It bothers me that the common pattern of writing the error code at the
end of the message isn't possible anymore. Maybe I'll get used to it,
but it removes some flexibility.
>
> /* Locate the panel DT node. */
> panel_node = of_graph_get_remote_node(dev->of_node, 1, 0);
--
Regards,
Laurent Pinchart
ts as specified in the format string
> > + *
> > + * This helper implements common pattern present in probe functions for
> > error
> > + * checking: print message if the error is not -EPROBE_DEFER and propagate
> > it.
> > + * In case of -EPROBE_DEFER it sets defer probe reason, which can be
> > checked
> > + * later by reading devices_deferred debugfs attribute.
> > + * It replaces code sequence:
> > + * if (err != -EPROBE_DEFER)
> > + * dev_err(dev, ...);
> > + * return err;
> > + * with
> > + * return probe_err(dev, err, ...);
> > + *
> > + * Returns @err.
> > + *
> > + */
> > +#define probe_err(dev, err, args...) __probe_err(dev, (long)(err), args)
> >
> > /* Create alias, so I can be autoloaded. */
> > #define MODULE_ALIAS_CHARDEV(major,minor) \
> >
--
Regards,
Laurent Pinchart
t args;
> > +
> > + if (err == -EPROBE_DEFER)
> > + return err;
> > +
> > + va_start(args, fmt);
> > + vaf.fmt = fmt;
> > + vaf.va =
> > +
> > + dev_err(dev, "error %d: %pV", err, );
> > +
> > + va_end(args);
> > +
> > + return err;
> > +}
> > +EXPORT_SYMBOL_GPL(probe_err);
>
> Please be specific in global symbols, how about "driver_probe_error()"?
Or dev_err_probe() to match the existing dev_* functions ?
> And merge the other patch into this one, as Raphael said, otherwise this
> just looks odd to add something and then fix it up later.
--
Regards,
Laurent Pinchart
As Geert and Laurent point out, this driver does not need this header in
> the two files that include it. Remove it so there are no warnings.
>
> Fixes: e0cf615d725c ("asm-generic: don't include in
> cacheflush.h")
> Suggested-by: Geert Uytterhoeven
> Suggested-by: Laure
Hi Dmitry,
Thank you for the patch.
On Mon, Jun 22, 2020 at 01:27:41AM +0300, Dmitry Osipenko wrote:
> The EDT ET057090DHU panel has a DPI connector and not LVDS. This patch
> corrects the panel's description.
>
> Reported-by: Laurent Pinchart
> Fixes: 94f07917ebe8 ("d
everting it until we check each panel individually.
> > };
> >
> > static const struct drm_display_mode edt_etm0700g0dh6_mode = {
> > @@ -2055,6 +2060,7 @@ static const struct panel_desc innolux_n156bge_l21 = {
> > .width = 344,
> > .height = 193,
> > },
> > + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> > };
> >
> > static const struct drm_display_mode innolux_p120zdg_bf1_mode = {
> > @@ -3001,6 +3007,7 @@ static const struct panel_desc samsung_ltn101nt05 = {
> > .width = 223,
> > .height = 125,
> > },
> > + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> > };
> >
> > static const struct drm_display_mode samsung_ltn140at29_301_mode = {
--
Regards,
Laurent Pinchart
Hi Vishal,
On Tue, Jun 09, 2020 at 06:23:43PM +, Vishal Sagar wrote:
> On Wednesday, May 6, 2020 8:42 PM, Laurent Pinchart wrote:
> > On Wed, Apr 29, 2020 at 07:47:04PM +0530, Vishal Sagar wrote:
> > > The Xilinx UHD-SDI Rx subsystem soft IP is used to capture native SDI
Hi GVRao,
Sorry for the delayed reply.
On Tue, Jun 09, 2020 at 02:48:25AM +, Venkateshwar Rao Gannavarapu wrote:
> Hi Laurent,
>
> Thanks for the review.
> Please see my comments about D-PHY and bridge driver implementation.
>
> On Sunday, June 7, 2020 7:55 AM, Laur
ich represents physical orientation of a display
> panel and hence it should be applicable to all panels.
Adding a bit more food for thoughts, the DT rotation property for camera
sensor modules has recently been documented with lots of details. See
https://lore.kernel.org/linux-media/20200509090456.3496481-3-jac...@jmondi.org/,
part of the documentation may be useful for panels.
> > Sam seems like you've done most of the YAML conversion. IMHO it would
> > make sense to revisit the patches and inherit common properties only
> > as applicable.
> >
> >> I don't think that it makes sense to wire up rotation property to all
> >> panel drivers at once because those drivers will be untested, at least I
> >> don't know anything about those other panels and can't test them. It
> >> will be much better to support the rotation on by as-needed basis for
> >> each panel driver individually.
> >
> > How about CCing the author and reviewer asking them to test the patch?
> > The only place where the patches might cause an issue is with tiny,
> > although patches would still be appreciated.
>
> There are quite a lot of panel drivers and I'm a bit doubtful that at
> least half of devices that use those panels have any real use for the
> rotation property. I could write the patches.. but in the end it could
> be a wasted effort if nobody needs it, so I'd prefer not to do it.
--
Regards,
Laurent Pinchart
balanced.
>
> Signed-off-by: Dinghao Liu
Reviewed-by: Laurent Pinchart
I have however received multiple similar patches recently, for different
drivers. I've CC'ed Rafael, the PM maintainer, in one of those e-mail
threads, and questioned whether we should really mass-patch drivers, o
chsel)
> int ret;
>
> ret = pm_runtime_get_sync(vin->dev);
> - if (ret < 0)
> + if (ret < 0) {
> + pm_runtime_put_noidle(vin->dev);
> return ret;
> + }
>
> /* Make register writes take effect immediately. */
> vnmc = rvin_read(vin, VNMC_REG);
--
Regards,
Laurent Pinchart
On Tue, Jun 16, 2020 at 05:07:34AM +0300, Laurent Pinchart wrote:
> Hi Qiushi,
>
> (CC'ing Rafael and Geert)
>
> Thank you for the patch.
>
> On Sat, Jun 13, 2020 at 06:23:57PM -0500, wu000...@umn.edu wrote:
> > From: Qiushi Wu
> >
> > pm_runtime_get
gt;dev);
>
> ret = pm_runtime_get_sync(>dev);
> - if (ret < 0)
> + if (ret < 0) {
> + pm_runtime_put_noidle(>dev);
> goto done;
> + }
>
> vsp1->version = vsp1_read(vsp1, VI6_IP_VERSION);
> pm_runtime_put_sync(>dev);
--
Regards,
Laurent Pinchart
e a of_graph_has_port() function. The could would
be simpler here.
> remote = of_graph_get_remote_node(np, port, endpoint);
> if (!remote)
> return -ENODEV;
--
Regards,
Laurent Pinchart
On Tue, Jun 16, 2020 at 04:21:12AM +0300, Laurent Pinchart wrote:
> Hi Dmitry,
>
> Thank you for the patch.
>
> On Sun, Jun 14, 2020 at 08:22:29PM +0300, Dmitry Osipenko wrote:
> > In some case, like a DRM display code for example, it's useful to silently
> > che
_get_remote_node(
> return NULL;
> }
>
> +static inline struct device_node *of_graph_get_local_port(
> + const struct device_node *node)
> +{
> + return NULL;
> +}
> +
> #endif /* CONFIG_OF */
>
> #endif /* __LINUX_OF_GRAPH_H */
> --
> 2.26.0
>
--
Regards,
Laurent Pinchart
> + if (ret < 0) {
> + pm_runtime_put(host->dev);
> return ret;
> + }
>
> cdns_dsi_init_link(dsi);
>
--
Regards,
Laurent Pinchart
Hi Eugeniu,
On Fri, Jun 12, 2020 at 05:36:07PM +0200, Eugeniu Rosca wrote:
> On Fri, Jun 12, 2020 at 06:10:05PM +0300, Laurent Pinchart wrote:
> > On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote:
> > > On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote:
&
Hi Jacopo,
On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote:
> On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote:
> > On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote:
> > > Note that the CMM driver is controlled by the DU driver. As t
Hi Kishon,
On Thu, May 28, 2020 at 04:55:38AM +0300, Laurent Pinchart wrote:
> On Tue, May 26, 2020 at 12:32:01PM -0600, Rob Herring wrote:
> > On Wed, 13 May 2020 20:22:37 +0300, Laurent Pinchart wrote:
> > > From: Anurag Kumar Vulisha
> > >
> > > Add D
e of
> > the tpg to print the colors.
>
> I agree. The tpg knows where each color is and based on the width and height
> it can
> print the text. A tpg_gen_pattern_text() function that does the work would be
> very
> nice.
Could we go one step further, and print the colour name on each colour
bar ?
> It also doesn't make sense for all patterns, so this is really a nice feature
> to
> incorporate into the TPG itself and enable it via a vivid and vimc control.
>
> > For example, a function in v4l2-tpg-core.c that get the pattern as an
> > argument and return
> > this string, or maybe returns a const pointer to the array of colors, or
> > something like that.
> > Then maybe we can add a control in vivid for the same tpg feature.
> >
> > Note also that the sensor has a control to change the pattern:
> > vimc_sen_ctrl_test_pattern
> > So the string depends on that pattern.
> >
> >> + tpg_gen_text(>tpg, basep, 1, 1, str);
> >> +
> >>return vsen->frame;
> >> }
> >>
--
Regards,
Laurent Pinchart
s of return paths from rpm_resume() that return an error,
more than just rpm_callback(). Do you consider that none of them are
valid errors that drivers need to handle ?
--
Regards,
Laurent Pinchart
Hi Qian,
I forgot to mention, I think the subject line should be
drm/rcar-du: Make DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU
Could you please let me know if you're OK with these two small changes ?
On Mon, Jun 08, 2020 at 06:14:43AM +0300, Laurent Pinchart wrote:
> On Sun, Jun 07, 2020 at 10
end of ARM devices
>
> CONFIG_DRM_RCAR_WRITEBACK=y
>
> #
> # Frame buffer Devices
>
> Let DRM_RCAR_WRITEBACK depend on DRM_RCAR_DU instead.
>
> Signed-off-by: Qian Cai
Reviewed-by: Laurent Pinchart
No need to submit a v3 if you agree with the above change, I'll fix it
in my tr
eave it as it is.
The vsp1_probe() function has a struct vsp1_device whose dev field is
populated by the time it needs to call pm_runtime_get_sync() and
pm_runtime_get_put(), so I think you can use vsp1_device_get() and
vsp1_device_put() as drop-in replacements without changing the
parameters to these two functions.
--
Regards,
Laurent Pinchart
ad, as DRM_RCAR_WRITEBACK is
used to select compilation of rcar_du_writeback.c that is part of the
rcar-du driver ?
--
Regards,
Laurent Pinchart
On Mon, Jun 08, 2020 at 04:54:57AM +0300, Laurent Pinchart wrote:
> Hi Dinghao,
>
> Thank you for the patch.
>
> On Sat, May 23, 2020 at 07:54:26PM +0800, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > when it returns an
to me, but we also need a similar change in the
vsp1_device_get() function if I'm not mistaken. Could you combine both
in the same patch ?
>
> vsp1->version = vsp1_read(vsp1, VI6_IP_VERSION);
> pm_runtime_put_sync(>dev);
--
Regards,
Laurent Pinchart
program the CMM. There
should thus be no need for manual suspend/resume handling in the CMM as
far as I can tell, but we need to ensure that the CMM is suspended
before and resumed after the DU. I believe this could be implemented
using device links.
> >>> [*] https://github.com/renesas-rcar/du_cmm
> >>> [**]
> >>> https://github.com/renesas-rcar/du_cmm/blob/c393ed49834bdbc/meta-rcar-gen3/recipes-kernel/linux/linux-renesas/0001-drm-rcar-du-Add-DU-CMM-support.patch#L1912
--
Regards,
Laurent Pinchart
00c2 f9403a60 d2800084 a9400663 (f9401400)
> ---[ end trace 3875369841fb288a ]---
>
> Fixes: f3b98e3c4d2e16 ("media: vsp1: Provide support for extended command
> pools")
> Cc: sta...@vger.kernel.org # v4.19+
> Signed-off-by: Eugeniu Rosca
> Reviewed-by: Kieran Bingha
Hi GVRao,
On Sun, May 31, 2020 at 05:41:50PM +, Venkateshwar Rao Gannavarapu wrote:
> On Sunday, May 24, 2020 8:38 AM, Laurent Pinchart wrote:
> > On Mon, May 04, 2020 at 11:43:48AM -0700, Hyun Kwon wrote:
> >> On Mon, 2020-04-20 at 14:20:56 -0700, Venkateshwar Rao
Hi Vishal,
On Thu, May 28, 2020 at 07:25:12AM +, Vishal Sagar wrote:
> On Wednesday, May 27, 2020 9:42 PM, Laurent Pinchart wrote:
> > On Wed, May 27, 2020 at 07:27:18PM +0530, Vishal Sagar wrote:
> > > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem.
> >
> + { 'H', 'E', 'V', 'C', 0x00, 0x00, 0x10, 0x00, \
> + 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> +
>
> /* ----
> * Driver specific constants.
--
Regards,
Laurent Pinchart
> As Geert (thanks) explained what I've tested with is suspend-to-idle,
> which retains the state of the LUT tables (and I assume other
> not-yet-implemented CMM features, like CLU). I recall the out-of-tree
> driver has suspend/resume routines but I never really tested that.
>
> > [*] https://github.com/renesas-rcar/du_cmm
> > [**]
> > https://github.com/renesas-rcar/du_cmm/blob/c393ed49834bdbc/meta-rcar-gen3/recipes-kernel/linux/linux-renesas/0001-drm-rcar-du-Add-DU-CMM-support.patch#L1912
--
Regards,
Laurent Pinchart
edia] omap3isp: CCDC, preview engine and resizer]")
There's an extra ']' at the end. Apart from that,
Reviewed-by: Laurent Pinchart
Sakari, could you take this patch ?
> Signed-off-by: Chuhong Yuan
> ---
> Changes in v2:
> - Fix the typo.
>
> drivers/media/platform/omap3
Hello Xin,
Thank you for the patch.
On Thu, Jun 04, 2020 at 03:58:05PM +0800, Xin Ji wrote:
> The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed
> for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K.
>
> Signed-off-by: Xin Ji
> ---
>
Hi Vinod,
On Thu, Jun 04, 2020 at 12:55:48PM +0530, Vinod Koul wrote:
> On 28-05-20, 04:52, Laurent Pinchart wrote:
>
> > > +static int lt9611_bridge_attach(struct drm_bridge *bridge,
> > > + enum drm_bridge_attach_flags flags)
> > >
Hi Vinod,
On Thu, Jun 04, 2020 at 12:48:59PM +0530, Vinod Koul wrote:
> Hi Laurent,
>
> Sorry for late reply, I was out last week.
No worries.
> On 28-05-20, 04:48, Laurent Pinchart wrote:
> > > +
> > > + interrupts:
> > > +maxItems: 1
> > &g
Hi Vishal,
On Mon, Jun 01, 2020 at 03:14:52PM +, Vishal Sagar wrote:
> On Wednesday, May 6, 2020 6:32 PM, Laurent Pinchart wrote:
> > On Wed, Apr 29, 2020 at 07:47:03PM +0530, Vishal Sagar wrote:
> > > Add bindings documentation for Xilinx UHD-SDI Receiver Subsystem.
>
rg instead of just hardcoding NULL.
>
> Cc: Laurent Pinchart
> Signed-off-by: Adrian Ratiu
> ---
> New in v8.
> ---
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 --
> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 2 +-
> include/drm/bridge/dw_mipi_dsi.h
search for "hdmi-connector" in
the .dts files in the kernel for plenty of examples.
> +
> +Required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-names
> + - ports
> +
> +Example:
> + - |
> +mhdp: mhdp@32c0 {
> + compatible = "nxp,imx8mq-cdns-hdmi";
> + reg = <0x32c0 0x10>;
> + interrupts = ,
> + ;
> + interrupt-names = "plug_in", "plug_out";
> +
> + ports {
> +mhdp_in: endpoint {
> + remote-endpoint = <_out>;
> +};
> + };
> +};
--
Regards,
Laurent Pinchart
gt; +#define IRQ_OUT 1
> +#define IRQ_NUM 2
> +
> +#define cdns_mhdp_plat_call(mhdp, operation) \
> + (!(mhdp) ? -ENODEV : (((mhdp)->plat_data &&
> (mhdp)->plat_data->operation) ? \
> + (mhdp)->plat_data->operation(mhdp) : ENOIOCTLCMD))
> +
> enum voltage_swing_level {
> VOLTAGE_LEVEL_0,
> VOLTAGE_LEVEL_1,
> @@ -504,9 +519,29 @@ struct cdns_mhdp_connector {
> struct cdns_mhdp_bridge *bridge;
> };
>
> +struct cdns_plat_data {
> + /* Vendor PHY support */
> + int (*bind)(struct platform_device *pdev,
> + struct drm_encoder *encoder,
> + struct cdns_mhdp_device *mhdp);
> + void (*unbind)(struct device *dev);
> +
> + int (*phy_set)(struct cdns_mhdp_device *mhdp);
> + bool (*phy_video_valid)(struct cdns_mhdp_device *mhdp);
> + int (*firmware_init)(struct cdns_mhdp_device *mhdp);
> + void (*pclk_rate)(struct cdns_mhdp_device *mhdp);
> +
> + int (*power_on)(struct cdns_mhdp_device *mhdp);
> + int (*power_off)(struct cdns_mhdp_device *mhdp);
> +
> + char *plat_name;
> + int lane_mapping;
> +};
> +
> struct cdns_mhdp_device {
> struct device *dev;
> struct cdns_mhdp_connector connector;
> + struct cdns_mhdp_bridge bridge;
>
> void __iomem *regs_base;
> struct reset_control *spdif_rst;
> @@ -520,6 +555,11 @@ struct cdns_mhdp_device {
>
> unsigned int fw_version;
>
> + struct delayed_work hotplug_work;
> + u32 lane_mapping;
> + bool power_up;
> + struct mutex lock;
> + int irq[IRQ_NUM];
> union {
> struct _dp_data {
> u32 rate;
> @@ -528,6 +568,8 @@ struct cdns_mhdp_device {
> u8 dpcd[DP_RECEIVER_CAP_SIZE];
> } dp;
> };
> + const struct cdns_plat_data *plat_data;
> +
> };
>
> void cdns_mhdp_clock_reset(struct cdns_mhdp_device *mhdp);
> @@ -535,7 +577,7 @@ void cdns_mhdp_set_fw_clk(struct cdns_mhdp_device *mhdp,
> unsigned long clk);
> int cdns_mhdp_load_firmware(struct cdns_mhdp_device *mhdp, const u32 *i_mem,
> u32 i_size, const u32 *d_mem, u32 d_size);
> int cdns_mhdp_set_firmware_active(struct cdns_mhdp_device *mhdp, bool
> enable);
> -int cdns_mhdp_set_host_cap(struct cdns_mhdp_device *mhdp, bool flip);
> +int cdns_mhdp_set_host_cap(struct cdns_mhdp_device *mhdp);
> int cdns_mhdp_event_config(struct cdns_mhdp_device *mhdp);
> u32 cdns_mhdp_get_event(struct cdns_mhdp_device *mhdp);
> int cdns_mhdp_read_hpd(struct cdns_mhdp_device *mhdp);
> @@ -547,10 +589,18 @@ int cdns_mhdp_get_edid_block(void *mhdp, u8 *edid,
> int cdns_mhdp_train_link(struct cdns_mhdp_device *mhdp);
> int cdns_mhdp_set_video_status(struct cdns_mhdp_device *mhdp, int active);
> int cdns_mhdp_config_video(struct cdns_mhdp_device *mhdp);
> +bool cdns_mhdp_check_alive(struct cdns_mhdp_device *mhdp);
> int cdns_mhdp_audio_stop(struct cdns_mhdp_device *mhdp,
>struct audio_info *audio);
> int cdns_mhdp_audio_mute(struct cdns_mhdp_device *mhdp, bool enable);
> int cdns_mhdp_audio_config(struct cdns_mhdp_device *mhdp,
> struct audio_info *audio);
>
> +int cdns_phy_reg_write(struct cdns_mhdp_device *mhdp, u32 addr, u32 val);
> +u32 cdns_phy_reg_read(struct cdns_mhdp_device *mhdp, u32 addr);
> +
> +/* DP */
> +int cdns_dp_bind(struct platform_device *pdev, struct drm_encoder *encoder,
> + struct cdns_mhdp_device *mhdp);
> +void cdns_dp_unbind(struct device *dev);
> #endif /* CDNS_MHDP_H_ */
--
Regards,
Laurent Pinchart
p_mailbox_read(struct cdns_mhdp_device *mhdp)
> {
> - struct cdns_mhdp_device *mhdp = dp->mhdp;
>int val, ret;
> ...
> - return fancy_readl(dp, MAILBOX0_RD_DATA) & 0xff;
> + return cdns_mhdp_bus_read(mhdp, MAILBOX0_RD_DATA) & 0xff;
> }
--
Regards,
Laurent Pinchart
rmats swapped. I never noticed
because the test pattern doesn't immediately appear wrong when you swap
red and blue. Adding text in the colour bars to tell what colour they
should be would help visual verification of the pattern.
--
Regards,
Laurent Pinchart
Hi Dafna,
On Tue, Jun 02, 2020 at 03:16:03PM +0200, Dafna Hirschfeld wrote:
> On 02.06.20 14:45, Laurent Pinchart wrote:
> > On Tue, Jun 02, 2020 at 08:31:26AM -0300, Helen Koike wrote:
> >> On 6/2/20 8:24 AM, Kieran Bingham wrote:
> >>> On 02/06/2020 11:55, Helen K
> >>>>>> vpix = vimc_pix_map_by_code(vdeb->src_code);
> >>>>>> - index = VIMC_FRAME_INDEX(lin, col, vdeb->sink_fmt.width, 3);
> >>>>>> - for (i = 0; i < 3; i++) {
> >>>>>> - switch (vpix->pixelformat) {
> >>>>>> - case V4L2_PIX_FMT_RGB24:
> >>>>>> - vdeb->src_frame[index + i] = rgb[i];
> >>>>>> - break;
> >>>>>> - case V4L2_PIX_FMT_BGR24:
> >>>>>> - vdeb->src_frame[index + i] = rgb[2 - i];
> >>>>>> - break;
> >>>>>> +
> >>>>>> + if (vpix->pixelformat == V4L2_PIX_FMT_ARGB32) {
> >>>>>> + index = VIMC_FRAME_INDEX(lin, col, vdeb->sink_fmt.width, 4);
> >>>>>> + vdeb->src_frame[index] = 255;
> >>>>>> + for (i = 0; i < 3; i++)
> >>>>>> + vdeb->src_frame[index + i + 1] = rgb[i];
> >>>>>> + } else {
> >>>>>> + index = VIMC_FRAME_INDEX(lin, col, vdeb->sink_fmt.width, 3);
> >>>>>> + for (i = 0; i < 3; i++) {
> >>>>>> + switch (vpix->pixelformat) {
> >>>>>> + case V4L2_PIX_FMT_RGB24:
> >>>>>> + vdeb->src_frame[index + i] = rgb[i];
> >>>>>> + break;
> >>>>>> + case V4L2_PIX_FMT_BGR24:
> >>>>>> + vdeb->src_frame[index + i] = rgb[2 - i];
> >>>>>> + break;
> >>>>>> + }
> >>>>>> }
> >>>>>> }
> >>>>>> }
--
Regards,
Laurent Pinchart
5;
> > > + for (i = 0; i < 3; i++)
> > > + vdeb->src_frame[index + i + 1] = rgb[i];
> > > + } else {
> > > + index = VIMC_FRAME_INDEX(lin, col, vdeb->sink_fmt.width, 3);
> > > + for (i = 0; i < 3; i++) {
> > > + switch (vpix->pixelformat) {
> > > + case V4L2_PIX_FMT_RGB24:
> > > + vdeb->src_frame[index + i] = rgb[i];
> > > + break;
> > > + case V4L2_PIX_FMT_BGR24:
> > > + vdeb->src_frame[index + i] = rgb[2 - i];
> > > + break;
> > > + }
> > > }
> > > }
> > > }
--
Regards,
Laurent Pinchart
601 - 700 of 4490 matches
Mail list logo
