Hi Kieran,
Thank you for the patch.
On Monday, 6 August 2018 17:39:02 EEST Kieran Bingham wrote:
> From: Kieran Bingham
>
> Add myself as a co-maintainer for the Renesas VSP driver.
>
> Signed-off-by: Kieran Bingham
Acked-by: Laurent Pinchart
and applied to my tree.
Tha
Hi Kieran,
Thank you for the patch.
On Monday, 6 August 2018 17:39:02 EEST Kieran Bingham wrote:
> From: Kieran Bingham
>
> Add myself as a co-maintainer for the Renesas VSP driver.
>
> Signed-off-by: Kieran Bingham
Acked-by: Laurent Pinchart
and applied to my tree.
Tha
atch they get
> > the same subdev name. Of course, I could fix that in the sensor driver
> > itself, but that's not what we want, or do we ?
>
> Good point. I missed the naming of the SPI devices ignored any bus
> information there. I'm rather inclined towards taking the SPI patch. Hans,
> Mauro, Laurent; any opinion on that?
I agree that the SPI patch makes sense, I think we should take it.
--
Regards,
Laurent Pinchart
atch they get
> > the same subdev name. Of course, I could fix that in the sensor driver
> > itself, but that's not what we want, or do we ?
>
> Good point. I missed the naming of the SPI devices ignored any bus
> information there. I'm rather inclined towards taking the SPI patch. Hans,
> Mauro, Laurent; any opinion on that?
I agree that the SPI patch makes sense, I think we should take it.
--
Regards,
Laurent Pinchart
Hi Zhong Jiang,
Thank you for the patch.
On Saturday, 18 August 2018 13:57:12 EEST zhong jiang wrote:
> We prefer to ERR_CAST rather than ERR_PTR(PTR_ERR()), So just
> replace it.
>
> The issue is detected with the help of Coccinelle
>
> Signed-off-by: zhong jiang
Re
Hi Zhong Jiang,
Thank you for the patch.
On Saturday, 18 August 2018 13:57:12 EEST zhong jiang wrote:
> We prefer to ERR_CAST rather than ERR_PTR(PTR_ERR()), So just
> replace it.
>
> The issue is detected with the help of Coccinelle
>
> Signed-off-by: zhong jiang
Re
debugfs_remove_recursive(uvc_debugfs_root_dir);
> + debugfs_remove_recursive(uvc_debugfs_root_dir);
> }
--
Regards,
Laurent Pinchart
debugfs_remove_recursive(uvc_debugfs_root_dir);
> + debugfs_remove_recursive(uvc_debugfs_root_dir);
> }
--
Regards,
Laurent Pinchart
ware that that
identifier has been deprecated by the FSF in favour of the GPL-2.0-or-later
identifier, but until Documentation/process/license-rules.rst gets updated,
please use GPL-2.0+.
> /*
> * TI OMAP4 ISS V4L2 Driver
> *
Could you please remove the boilerplate license text, as it's not needed
anymore ?
Those two comments apply to all the other files.
[snip$
--
Regards,
Laurent Pinchart
ware that that
identifier has been deprecated by the FSF in favour of the GPL-2.0-or-later
identifier, but until Documentation/process/license-rules.rst gets updated,
please use GPL-2.0+.
> /*
> * TI OMAP4 ISS V4L2 Driver
> *
Could you please remove the boilerplate license text, as it's not needed
anymore ?
Those two comments apply to all the other files.
[snip$
--
Regards,
Laurent Pinchart
Hi Andrzej,
On Wednesday, 30 May 2018 16:07:29 EEST Andrzej Hajda wrote:
> On 30.05.2018 14:35, Laurent Pinchart wrote:
> > On Wednesday, 30 May 2018 12:59:12 EEST Andrzej Hajda wrote:
> >> On 28.05.2018 12:18, Laurent Pinchart wrote:
> >>> On Monday, 28 May 2018 12:
Hi Andrzej,
On Wednesday, 30 May 2018 16:07:29 EEST Andrzej Hajda wrote:
> On 30.05.2018 14:35, Laurent Pinchart wrote:
> > On Wednesday, 30 May 2018 12:59:12 EEST Andrzej Hajda wrote:
> >> On 28.05.2018 12:18, Laurent Pinchart wrote:
> >>> On Monday, 28 May 2018 12:
+ #address-cells = <1>;
> + #size-cells = <0>;
> + port@1 {
> + reg = <1>;
> + lvds_ep: endpoint {
> + remote-endpoint = <_ep>;
> + };
> + };
> + };
--
Regards,
Laurent Pinchart
vddmipi-supply = <_1v2_reg>;
> + vddlvds133-supply = <_3v3_reg>;
> + vddlvds112-supply = <_1v2_reg>;
> + reset-gpios = < 6 GPIO_ACTIVE_LOW>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@1 {
> + reg = <1>;
> + lvds_ep: endpoint {
> + remote-endpoint = <_ep>;
> + };
> + };
> + };
--
Regards,
Laurent Pinchart
DRM bridge wrapper of DRM panels
Otherwise you'll potentially have to patch every user of DRM_PANEL_BRIDGE as
done in this patch.
--
Regards,
Laurent Pinchart
r of DRM panels
Otherwise you'll potentially have to patch every user of DRM_PANEL_BRIDGE as
done in this patch.
--
Regards,
Laurent Pinchart
ideas on the sysfs group 'power' not found bug on removal while on
> use?
I haven't had time to investigate them yet, please feel free to give it a go
without waiting for me :-)
> Thanks, it will be great to get this fixed.
>
> On Sat, May 26, 2018 at 07:21:11PM +0300, Laurent Pinchart
ideas on the sysfs group 'power' not found bug on removal while on
> use?
I haven't had time to investigate them yet, please feel free to give it a go
without waiting for me :-)
> Thanks, it will be great to get this fixed.
>
> On Sat, May 26, 2018 at 07:21:11PM +0300, Laurent Pinchart
nd the use of newly plugged in USB video cameras until the
> system is rebooted.
>
> Signed-off-by: David Fries <da...@fries.net>
> Cc: Guennadi Liakhovetski <g.liakhovet...@gmx.de>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Mauro Carvalho C
nd the use of newly plugged in USB video cameras until the
> system is rebooted.
>
> Signed-off-by: David Fries
> Cc: Guennadi Liakhovetski
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: sta...@vger.kernel.org
Philipp Zabel has already posted a similar patch,
On Saturday, 26 May 2018 19:16:54 EEST Laurent Pinchart wrote:
> Hi Dimitri,
And sorry for the spelling mistake :-/
> Thank you for the patch.
>
> I'll review this in details, but as this patch is based on the "[PATCH/RFC
> 1/4] drm: Add colorkey properties" patch I've
On Saturday, 26 May 2018 19:16:54 EEST Laurent Pinchart wrote:
> Hi Dimitri,
And sorry for the spelling mistake :-/
> Thank you for the patch.
>
> I'll review this in details, but as this patch is based on the "[PATCH/RFC
> 1/4] drm: Add colorkey properties" patch I've
ane
> properties related to the color keying to cover various HW capabilities.
>
> This patch is based on the initial work done by Laurent Pinchart, most of
> credits for this patch goes to him.
>
> Signed-off-by: Dmitry Osipenko <dig...@gmail.com>
> ---
> drivers/gpu/
ane
> properties related to the color keying to cover various HW capabilities.
>
> This patch is based on the initial work done by Laurent Pinchart, most of
> credits for this patch goes to him.
>
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/gpu/drm/dr
car_du_vsp.c
> @@ -322,7 +322,7 @@ rcar_du_vsp_plane_atomic_duplicate_state(struct
> drm_plane *plane) return NULL;
>
> __drm_atomic_helper_plane_duplicate_state(plane, >state);
> - copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha;
> + copy->state.alpha = plane->state->alpha;
>
> return >state;
> }
--
Regards,
Laurent Pinchart
ic_duplicate_state(struct
> drm_plane *plane) return NULL;
>
> __drm_atomic_helper_plane_duplicate_state(plane, >state);
> - copy->alpha = to_rcar_vsp_plane_state(plane->state)->alpha;
> + copy->state.alpha = plane->state->alpha;
>
> return >state;
> }
--
Regards,
Laurent Pinchart
r UVC 1.5 device, and the UVC 1.5 device can be
recognized.
More changes to the driver are needed for full UVC 1.5 compatibility.
However, at least the UVC 1.5 Realtek RTS5847/RTS5852 cameras have been
reported to work well.
Cc: sta...@vger.kernel.org
Signed-off-b
ver are needed for full UVC 1.5 compatibility.
However, at least the UVC 1.5 Realtek RTS5847/RTS5852 cameras have been
reported to work well.
Cc: sta...@vger.kernel.org
Signed-off-by: ming_qian
[Factor out code to helper function, update size checks]
Signed-off-by: Laur
ted by on-board switches SW-53 and SW-54 with CVBS input selected
> by the default switches configuration.
>
> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se>
Reviewed-by: Laurent Pinchart <laur
ted by on-board switches SW-53 and SW-54 with CVBS input selected
> by the default switches configuration.
>
> Signed-off-by: Jacopo Mondi
> Reviewed-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
> ---
> v3 -> v4:
> - Use 'adi,adv7180cp' compatible string in place
Hi Jacopo,
On Monday, 21 May 2018 15:33:40 EEST jacopo mondi wrote:
> On Mon, May 21, 2018 at 01:54:55PM +0300, Laurent Pinchart wrote:
> > On Monday, 21 May 2018 12:57:05 EEST jacopo mondi wrote:
> >> On Fri, May 18, 2018 at 06:12:15PM +0300, Laurent Pinchart wrote:
> >&
Hi Jacopo,
On Monday, 21 May 2018 15:33:40 EEST jacopo mondi wrote:
> On Mon, May 21, 2018 at 01:54:55PM +0300, Laurent Pinchart wrote:
> > On Monday, 21 May 2018 12:57:05 EEST jacopo mondi wrote:
> >> On Fri, May 18, 2018 at 06:12:15PM +0300, Laurent Pinchart wrote:
> >&
Hi Jacopo,
On Monday, 21 May 2018 12:57:05 EEST jacopo mondi wrote:
> On Fri, May 18, 2018 at 06:12:15PM +0300, Laurent Pinchart wrote:
> > On Friday, 18 May 2018 17:47:57 EEST Jacopo Mondi wrote:
> >> Describe CVBS video input through analog video decoder ADV7180
> >&g
Hi Jacopo,
On Monday, 21 May 2018 12:57:05 EEST jacopo mondi wrote:
> On Fri, May 18, 2018 at 06:12:15PM +0300, Laurent Pinchart wrote:
> > On Friday, 18 May 2018 17:47:57 EEST Jacopo Mondi wrote:
> >> Describe CVBS video input through analog video decoder ADV7180
> >&g
acopo+rene...@jmondi.org>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
> v2 -> v3:
> - Add comment on HDMI output port about the shared CVBS/HDMI video path
> - Add Niklas'
ewed-by: Niklas Söderlund
Reviewed-by: Laurent Pinchart
> ---
> v2 -> v3:
> - Add comment on HDMI output port about the shared CVBS/HDMI video path
> - Add Niklas' R-b tag
> ---
> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 48 +++
> 1 file cha
gt;;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + vin4_in: endpoint {
> + remote-endpoint = <_out>;
> + };
> + };
> + };
> +};
--
Regards,
Laurent Pinchart
@ -246,3 +268,23 @@
> timeout-sec = <60>;
> status = "okay";
> };
> +
> + {
> + pinctrl-0 = <_pins_cvbs>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + vin4_in: endpoint {
> + remote-endpoint = <_out>;
> + };
> + };
> + };
> +};
--
Regards,
Laurent Pinchart
t; + "rockchip,grf");
> + if (IS_ERR(grf)) {
> + dev_err(dev, "Can't find GRF syscon\n");
> + return -ENODEV;
> + }
> + }
> + priv->regmap_grf = grf;
> +
> + drv_data = of_id->data;
> + for (i = 0; i < drv_data->num_clks; i++) {
> + priv->clks[i] = devm_clk_get(dev, drv_data->clks[i]);
> +
> + if (IS_ERR(priv->clks[i])) {
> + dev_err(dev, "Failed to get %s\n", drv_data->clks[i]);
> + return PTR_ERR(priv->clks[i]);
> + }
> + }
> +
> + priv->grf_regs = drv_data->regs;
> + priv->drv_data = drv_data;
> + priv->stream_on = mipidphy_txrx_stream_on;
> + priv->txrx_base_addr = NULL;
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + priv->txrx_base_addr = devm_ioremap_resource(dev, res);
> + if (IS_ERR(priv->txrx_base_addr))
> + priv->stream_on = mipidphy_rx_stream_on;
> +
> + sd = >sd;
> + v4l2_subdev_init(sd, _subdev_ops);
> + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> + snprintf(sd->name, sizeof(sd->name), "rockchip-sy-mipi-dphy");
> + sd->dev = dev;
> +
> + platform_set_drvdata(pdev, >entity);
> +
> + ret = rockchip_mipidphy_media_init(priv);
> + if (ret < 0)
> + return ret;
> +
> + pm_runtime_enable(>dev);
> +
> + return 0;
> +}
> +
> +static int rockchip_mipidphy_remove(struct platform_device *pdev)
> +{
> + struct media_entity *me = platform_get_drvdata(pdev);
> + struct v4l2_subdev *sd = media_entity_to_v4l2_subdev(me);
> +
> + media_entity_cleanup(>entity);
> +
> + pm_runtime_disable(>dev);
> +
> + return 0;
> +}
> +
> +static const struct dev_pm_ops rockchip_mipidphy_pm_ops = {
> + SET_RUNTIME_PM_OPS(mipidphy_runtime_suspend,
> +mipidphy_runtime_resume, NULL)
> +};
> +
> +static struct platform_driver rockchip_isp_mipidphy_driver = {
> + .probe = rockchip_mipidphy_probe,
> + .remove = rockchip_mipidphy_remove,
> + .driver = {
> + .name = "rockchip-sy-mipi-dphy",
> + .pm = _mipidphy_pm_ops,
> + .of_match_table = rockchip_mipidphy_match_id,
> + },
> +};
> +
> +module_platform_driver(rockchip_isp_mipidphy_driver);
> +MODULE_AUTHOR("Rockchip Camera/ISP team");
> +MODULE_DESCRIPTION("Rockchip MIPI DPHY driver");
> +MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/drivers/media/platform/rockchip/isp1/mipi_dphy_sy.h
> b/drivers/media/platform/rockchip/isp1/mipi_dphy_sy.h new file mode 100644
> index ..c558791064a2
> --- /dev/null
> +++ b/drivers/media/platform/rockchip/isp1/mipi_dphy_sy.h
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Rockchip MIPI Synopsys DPHY driver
> + *
> + * Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd.
> + */
> +
> +#ifndef __MIPI_DPHY_SY_H__
> +#define __MIPI_DPHY_SY_H__
> +
> +#include
> +
> +void rkisp1_set_mipi_dphy_sy_lanes(struct v4l2_subdev *dphy, int lanes);
> +
> +#endif /* __RKISP1_MIPI_DPHY_SY_H__ */
--
Regards,
Laurent Pinchart
> + dev_err(dev, "Can't find GRF syscon\n");
> + return -ENODEV;
> + }
> + }
> + priv->regmap_grf = grf;
> +
> + drv_data = of_id->data;
> + for (i = 0; i < drv_data->num_clks; i++) {
> + priv->clks[i] = devm_clk_get(dev, drv_data->clks[i]);
> +
> + if (IS_ERR(priv->clks[i])) {
> + dev_err(dev, "Failed to get %s\n", drv_data->clks[i]);
> + return PTR_ERR(priv->clks[i]);
> + }
> + }
> +
> + priv->grf_regs = drv_data->regs;
> + priv->drv_data = drv_data;
> + priv->stream_on = mipidphy_txrx_stream_on;
> + priv->txrx_base_addr = NULL;
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + priv->txrx_base_addr = devm_ioremap_resource(dev, res);
> + if (IS_ERR(priv->txrx_base_addr))
> + priv->stream_on = mipidphy_rx_stream_on;
> +
> + sd = >sd;
> + v4l2_subdev_init(sd, _subdev_ops);
> + sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> + snprintf(sd->name, sizeof(sd->name), "rockchip-sy-mipi-dphy");
> + sd->dev = dev;
> +
> + platform_set_drvdata(pdev, >entity);
> +
> + ret = rockchip_mipidphy_media_init(priv);
> + if (ret < 0)
> + return ret;
> +
> + pm_runtime_enable(>dev);
> +
> + return 0;
> +}
> +
> +static int rockchip_mipidphy_remove(struct platform_device *pdev)
> +{
> + struct media_entity *me = platform_get_drvdata(pdev);
> + struct v4l2_subdev *sd = media_entity_to_v4l2_subdev(me);
> +
> + media_entity_cleanup(>entity);
> +
> + pm_runtime_disable(>dev);
> +
> + return 0;
> +}
> +
> +static const struct dev_pm_ops rockchip_mipidphy_pm_ops = {
> + SET_RUNTIME_PM_OPS(mipidphy_runtime_suspend,
> +mipidphy_runtime_resume, NULL)
> +};
> +
> +static struct platform_driver rockchip_isp_mipidphy_driver = {
> + .probe = rockchip_mipidphy_probe,
> + .remove = rockchip_mipidphy_remove,
> + .driver = {
> + .name = "rockchip-sy-mipi-dphy",
> + .pm = _mipidphy_pm_ops,
> + .of_match_table = rockchip_mipidphy_match_id,
> + },
> +};
> +
> +module_platform_driver(rockchip_isp_mipidphy_driver);
> +MODULE_AUTHOR("Rockchip Camera/ISP team");
> +MODULE_DESCRIPTION("Rockchip MIPI DPHY driver");
> +MODULE_LICENSE("Dual BSD/GPL");
> diff --git a/drivers/media/platform/rockchip/isp1/mipi_dphy_sy.h
> b/drivers/media/platform/rockchip/isp1/mipi_dphy_sy.h new file mode 100644
> index ..c558791064a2
> --- /dev/null
> +++ b/drivers/media/platform/rockchip/isp1/mipi_dphy_sy.h
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Rockchip MIPI Synopsys DPHY driver
> + *
> + * Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd.
> + */
> +
> +#ifndef __MIPI_DPHY_SY_H__
> +#define __MIPI_DPHY_SY_H__
> +
> +#include
> +
> +void rkisp1_set_mipi_dphy_sy_lanes(struct v4l2_subdev *dphy, int lanes);
> +
> +#endif /* __RKISP1_MIPI_DPHY_SY_H__ */
--
Regards,
Laurent Pinchart
07/05/18 17:19, Mauro Carvalho Chehab wrote:
> >>>> Em Mon, 07 May 2018 16:26:08 +0300 Laurent Pinchart escreveu:
> >>>>> On Saturday, 5 May 2018 19:08:15 EEST Mauro Carvalho Chehab wrote:
> >>>>>
> >>>>>> There was a recent dis
07/05/18 17:19, Mauro Carvalho Chehab wrote:
> >>>> Em Mon, 07 May 2018 16:26:08 +0300 Laurent Pinchart escreveu:
> >>>>> On Saturday, 5 May 2018 19:08:15 EEST Mauro Carvalho Chehab wrote:
> >>>>>
> >>>>>> There was a recent dis
explain why enabling/disabling regulators at
probe/remove solves the problem. Your patch otherwise looks OK (although if
you submit a v3 anyway you could also rename err_disable_regulator to
err_disable_regulators).
> >>> Signed-off-by: Philippe Cornu <philippe.co...@st.com>
> >>> ---
> >>>
> >>> drivers/gpu/drm/bridge/sii902x.c | 38 ++
> >>> 1 file changed, 34 insertions(+), 4 deletions(-)
--
Regards,
Laurent Pinchart
explain why enabling/disabling regulators at
probe/remove solves the problem. Your patch otherwise looks OK (although if
you submit a v3 anyway you could also rename err_disable_regulator to
err_disable_regulators).
> >>> Signed-off-by: Philippe Cornu
> >>> ---
> >>>
> >>> drivers/gpu/drm/bridge/sii902x.c | 38 ++
> >>> 1 file changed, 34 insertions(+), 4 deletions(-)
--
Regards,
Laurent Pinchart
Hi Philippe,
On Monday, 14 May 2018 12:22:16 EEST Philippe CORNU wrote:
> On 04/26/2018 12:05 AM, Laurent Pinchart wrote:
> > On Wednesday, 25 April 2018 20:11:23 EEST Rob Herring wrote:
> >> On Wed, Apr 25, 2018 at 04:17:25PM +0300, Laurent Pinchart wrote:
> >>> On
Hi Philippe,
On Monday, 14 May 2018 12:22:16 EEST Philippe CORNU wrote:
> On 04/26/2018 12:05 AM, Laurent Pinchart wrote:
> > On Wednesday, 25 April 2018 20:11:23 EEST Rob Herring wrote:
> >> On Wed, Apr 25, 2018 at 04:17:25PM +0300, Laurent Pinchart wrote:
> >>> On
ts in the DT, or prioritize HDMI?
>
> I feel this is a question for Laurent. My feeling for how we handled
> this in other cases is to go with the board default settings. I'm
> however sure there are exceptions to the rule. So maybe we should go
> with the most useful (what ever that is) configuration?
I think I'd go with CVBS as I don't think HDMI would be considered as the most
useful configuration here. The Draak board is unlikely to be used by us as a
reference platform to test HDMI capture, is it ?
This being said, you can instantiate the adv7612 and HDMI connector in DT,
without connecting them to the VIN. That would make it easy to quickly change
the configuration.
> >>> +
> >>> + remote-endpoint = <_out>;
> >>> + };
> >>> + };
> >>> + };
> >>> +};
--
Regards,
Laurent Pinchart
the DT, or prioritize HDMI?
>
> I feel this is a question for Laurent. My feeling for how we handled
> this in other cases is to go with the board default settings. I'm
> however sure there are exceptions to the rule. So maybe we should go
> with the most useful (what ever that is) configuration?
I think I'd go with CVBS as I don't think HDMI would be considered as the most
useful configuration here. The Draak board is unlikely to be used by us as a
reference platform to test HDMI capture, is it ?
This being said, you can instantiate the adv7612 and HDMI connector in DT,
without connecting them to the VIN. That would make it easy to quickly change
the configuration.
> >>> +
> >>> + remote-endpoint = <_out>;
> >>> + };
> >>> + };
> >>> + };
> >>> +};
--
Regards,
Laurent Pinchart
Hi Niklas,
On Monday, 14 May 2018 12:49:00 EEST Niklas Söderlund wrote:
> On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote:
>
> [snip]
>
> >>> + {
> >>> + pinctrl-0 = <_pins>;
> >>> + pinctrl-names = "defau
Hi Niklas,
On Monday, 14 May 2018 12:49:00 EEST Niklas Söderlund wrote:
> On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote:
>
> [snip]
>
> >>> + {
> >>> + pinctrl-0 = <_pins>;
> >>> + pinctrl-names = "defau
+
> > + vin4_in: endpoint {
> > + hsync-active = <0>;
> > + vsync-active = <0>;
>
> Comparing this to the Gen2 bindings some properties are missing,
>
> bus-width = <24>;
> pclk-sample = <1>;
> data-active = <1>;
>
> This is not a big deal as the VIN driver don't use these properties so
> no functional change should come of this but still a difference.
I think the VIN DT bindings should be updated to explicitly list the endpoint
properties that are mandatory, optional, or not allowed.
> Over all I'm happy with this change but before I add my tag I would like
> to understand why it differs from the Gen2 configuration for the adv7612
> properties.
>
> Also on a side not it is possible with hardware switches on the board
> switch the VIN4 source to a completely different pipeline CVBS connector
> -> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as
> this seems to be how the boards are shipped. But maybe mentioning this
> in the commit message would not hurt if you end-up resending the patch.
>
> > +
> > + remote-endpoint = <_out>;
> > + };
> > + };
> > + };
> > +};
--
Regards,
Laurent Pinchart
: endpoint {
> > + hsync-active = <0>;
> > + vsync-active = <0>;
>
> Comparing this to the Gen2 bindings some properties are missing,
>
> bus-width = <24>;
> pclk-sample = <1>;
> data-active = <1>;
>
> This is not a big deal as the VIN driver don't use these properties so
> no functional change should come of this but still a difference.
I think the VIN DT bindings should be updated to explicitly list the endpoint
properties that are mandatory, optional, or not allowed.
> Over all I'm happy with this change but before I add my tag I would like
> to understand why it differs from the Gen2 configuration for the adv7612
> properties.
>
> Also on a side not it is possible with hardware switches on the board
> switch the VIN4 source to a completely different pipeline CVBS connector
> -> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as
> this seems to be how the boards are shipped. But maybe mentioning this
> in the commit message would not hurt if you end-up resending the patch.
>
> > +
> > + remote-endpoint = <_out>;
> > + };
> > + };
> > + };
> > +};
--
Regards,
Laurent Pinchart
; Thanks, I have moved the new node to preserve sorting of nodes by bus
> address and applied the result. It is as follows:
>
> From: Jacopo Mondi <jacopo+rene...@jmondi.org>
> Subject: [PATCH] arm64: dts: renesas: r8a77995: Add VIN4
>
> Describe VIN4 interface for R-Car D3 R8A77
resets = < 807>;
> >> + renesas,id = <4>;
> >> + status = "disabled";
> >> + };
> >>};
>
> Thanks, I have moved the new node to preserve sorting of nodes by bus
> address and a
Hi Jacopo,
Thank you for the patch.
On Friday, 11 May 2018 13:00:00 EEST Jacopo Mondi wrote:
> Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by
> rcar-vin driver.
>
> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
Reviewed-by: Laurent Pinch
Hi Jacopo,
Thank you for the patch.
On Friday, 11 May 2018 13:00:00 EEST Jacopo Mondi wrote:
> Add compatible string for R-Car D3 R8A7795 to list of SoCs supported by
> rcar-vin driver.
>
> Signed-off-by: Jacopo Mondi
Reviewed-by: Laurent Pinchart
> ---
> Documentation/d
t
submitting a patch. GFP_DMA isn't needed for omap3isp.
--
Regards,
Laurent Pinchart
t
submitting a patch. GFP_DMA isn't needed for omap3isp.
--
Regards,
Laurent Pinchart
ferences to 'struct timeval' from the kernel,
> I also change the way the timestamp is generated internally,
> basically by open-coding the v4l2_get_timestamp() call.
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Sakari Ailus <sakari.ai...@iki.fi>
&g
ferences to 'struct timeval' from the kernel,
> I also change the way the timestamp is generated internally,
> basically by open-coding the v4l2_get_timestamp() call.
>
> Cc: Laurent Pinchart
> Cc: Sakari Ailus
> Signed-off-by: Arnd Bergmann
> ---
> I submitted this one in N
t;
> Enable the clocks, and the HDMI encoder for the M3-N Salvator-X board
> and hook it up to the HDMI connector.
>
> Based on patches from Takeshi Kihara <takeshi.kihara...@renesas.com>
>
> Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Re
t;
> Enable the clocks, and the HDMI encoder for the M3-N Salvator-X board
> and hook it up to the HDMI connector.
>
> Based on patches from Takeshi Kihara
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
> ---
> v2:
> - Remove LVDS clocks from DU node
&
>,
> + < CPG_MOD 723>,
> + < CPG_MOD 721>,
> + < CPG_MOD 727>,
> + < 1>,
> + <_clk>,
> + < 2>;
> + clock-names = "du.0", "du.1", "du.
< CPG_MOD 727>,
> + < 1>,
> + <_clk>,
> + < 2>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0",
> + "dclkin.0", "d
between
> both index types, and non-populated DU channels will be skipped without
> leaving a gap in the software CRTC indexes.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
between
> both index types, and non-populated DU channels will be skipped without
> leaving a gap in the software CRTC indexes.
>
> Signed-off-by: Kieran Bingham
> Reviewed-by: Laurent Pinchart
>
> ---
> v2:
> - devm_clk_get error message adapted to display Du chann
tween the IP
> versions are found later and require model-specific handling.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
and applied to my tree.
> ---
> .../devicetree/bind
tween the IP
> versions are found later and require model-specific handling.
>
> Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
and applied to my tree.
> ---
> .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 1 +
> 1 file changed, 1 insertion(+)
>
vity these days.
For the whole series,
Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Bartlomiej Zolnierkiewicz (3):
> video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support
> drm: shmobile: remove unused MERAM support
> video: fbdev: remove unused sh_m
vity these days.
For the whole series,
Acked-by: Laurent Pinchart
> Bartlomiej Zolnierkiewicz (3):
> video: fbdev: sh_mobile_lcdcfb: remove unused MERAM support
> drm: shmobile: remove unused MERAM support
> video: fbdev: remove unused sh_mobile_meram driver
>
> drivers/gpu/
>
> Fix this by using 'enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/tc358767.c | 2 +-
> 1 file changed, 1 i
>
> Fix this by using 'enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/bridge/tc358767.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/t
Hi Geert,
Thank you for the patch.
On Wednesday, 25 April 2018 10:49:38 EEST Geert Uytterhoeven wrote:
> Fixes: 14da3ed8dd08c581 ("devicetree/bindings: display: Document common
> panel properties")
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
Revi
Hi Geert,
Thank you for the patch.
On Wednesday, 25 April 2018 10:49:38 EEST Geert Uytterhoeven wrote:
> Fixes: 14da3ed8dd08c581 ("devicetree/bindings: display: Document common
> panel properties")
> Signed-off-by: Geert Uytterhoeven
Reviewed-by: Laurent Pinchart
>
(adv7511->gpio_pd) {
> - mdelay(5);
> + usleep_range(5000, 6000);
> gpiod_set_value_cansleep(adv7511->gpio_pd, 0);
> }
The patch looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
--
Regards,
Laurent Pinchart
y(5);
> + usleep_range(5000, 6000);
> gpiod_set_value_cansleep(adv7511->gpio_pd, 0);
> }
The patch looks good to me.
Reviewed-by: Laurent Pinchart
--
Regards,
Laurent Pinchart
Hi Peter,
Thank you for the patch.
On Friday, 27 April 2018 00:36:44 EEST Peter Rosin wrote:
> Could perhaps prevent some confusion.
>
> Signed-off-by: Peter Rosin <p...@axentia.se>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
> dri
Hi Peter,
Thank you for the patch.
On Friday, 27 April 2018 00:36:44 EEST Peter Rosin wrote:
> Could perhaps prevent some confusion.
>
> Signed-off-by: Peter Rosin
Reviewed-by: Laurent Pinchart
> ---
> drivers/gpu/drm/bridge/adv7511/Kconfig | 2 +-
> 1 file changed,
; CPG_MOD 721>,
> + < CPG_MOD 727>,
> + < 1>,
> + <_clk>,
> + < 2>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0",
> + "dclkin.0", "dclkin.1", "dclkin.3";
There's no LVDS clock in the DU anymore, you can drop it.
As for patch 14/17, I think you can squash this one with 17/17.
> +};
--
Regards,
Laurent Pinchart
k>,
> + < 2>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0",
> + "dclkin.0", "dclkin.1", "dclkin.3";
There's no LVDS clock in the DU anymore, you can drop it.
As for patch 14/17, I think you can squash this one with 17/17.
> +};
--
Regards,
Laurent Pinchart
sed on a similar patches of the the Salvator-X board
> on the R8A7796 SoC device tree
> by Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
How about adding the VGA output too ? I think you can add both VGA and HD
e Salvator-X board
> on the R8A7796 SoC device tree
> by Laurent Pinchart
Reviewed-by: Laurent Pinchart
How about adding the VGA output too ? I think you can add both VGA and HDMI in
a single patch that enables display in one go for the board. Same comment for
the Salvator-XS.
> Signed-off-by: T
< CPG_MOD 723>,
> + < CPG_MOD 721>,
> + < CPG_MOD 727>,
> + < 1>,
> + <_clk>,
> + < 2>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0",
> + "dclkin.0", "dclkin.1", "dclkin.3";
> +};
--
Regards,
Laurent Pinchart
< 1>,
> + <_clk>,
> + < 2>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0",
> + "dclkin.0", "dclkin.1", "dclkin.3";
> +};
--
Regards,
Laurent Pinchart
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:42 EEST Kieran Bingham wrote:
> Add the HDMI encoder to the R8A77965 DT in disabled state.
>
> Based on a similar patch of the R8A7796 device tree
> by Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.co
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:42 EEST Kieran Bingham wrote:
> Add the HDMI encoder to the R8A77965 DT in disabled state.
>
> Based on a similar patch of the R8A7796 device tree
> by Laurent Pinchart .
>
> Signed-off-by: Takeshi Kihara
-#include
> +#include
> #include
> #include
--
Regards,
Laurent Pinchart
8a77965.dtsi index
> 02de36b9e581..894903a59bdc 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -8,7 +8,7 @@
> * Copyright (C) 2016 Renesas Electronics Corp.
> */
>
> -#include
> +#include
> #include
> #include
--
Regards,
Laurent Pinchart
< CPG_MOD 723>,
> + < CPG_MOD 721>,
> + < CPG_MOD 727>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0";
And you can remove the LVDS clock as we
< CPG_MOD 721>,
> + < CPG_MOD 727>;
> + clock-names = "du.0", "du.1", "du.3", "lvds.0";
And you can remove the LVDS clock as well (from both cloc
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote:
> The r8a77965 has 4 VSP instances.
>
> Based on a similar patch of the R8A7796 device tree
> by Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>.
>
> Signe
Hi Kieran,
Thank you for the patch.
On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote:
> The r8a77965 has 4 VSP instances.
>
> Based on a similar patch of the R8A7796 device tree
> by Laurent Pinchart .
>
> Signed-off-by: Takeshi Kihara
> [Kieran: Rebased
> by Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara...@renesas.com>
> [Kieran: Rebase to top of tree]
> Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com>
Reviewed-by: Lauren
> by Laurent Pinchart .
>
> Signed-off-by: Takeshi Kihara
> [Kieran: Rebase to top of tree]
> Signed-off-by: Kieran Bingham
Reviewed-by: Laurent Pinchart
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 40 +++
> 1 file changed, 40 insertions(+)
&
ea..02de36b9e581 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -10,6 +10,7 @@
>
> #include
> #include
> +#include
>
> #define CPG_AUDIO_CLK_I 10
--
Regards,
Laurent Pinchart
dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -10,6 +10,7 @@
>
> #include
> #include
> +#include
>
> #define CPG_AUDIO_CLK_I 10
--
Regards,
Laurent Pinchart
du_group_setup_defr8() (but please double check). On the other hand, no
code would be simplified, and rcar_du_modeset_init() would gain some
additional complexity, so it might not be worth it.
Either way this patch looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideaso
n the other hand, no
code would be simplified, and rcar_du_modeset_init() would gain some
additional complexity, so it might not be worth it.
Either way this patch looks good to me.
Reviewed-by: Laurent Pinchart
> + .port = 2,
> + },
> + },
ould optimize this by computing it as
rgrp->num_crtcs = (rgrp->channel_mask >> 1)
| (rgrp->channel_mask & 1);
as you know that only two bits at most can be set. Up to you.
> /*
>* If we have more than one CRTCs in this group pre-associate
With those small issues fixed,
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
--
Regards,
Laurent Pinchart
*/
s/only/only./
> + rgrp->channel_mask = (rcdu->info->channel_mask >> (2 * i))
> +& GENMASK(1, 0);
> + rgrp->num_crtcs = hweight8(rgrp->channel_mask);
You could optimize this by computing it as
rgrp
901 - 1000 of 4490 matches
Mail list logo
