Re: [PATCH V10 2/6] mfd: max77620: add core driver for MAX77620/MAX20024

2016-04-27 Thread Laxman Dewangan
On Wednesday 27 April 2016 08:49 PM, Lee Jones wrote: On Wed, 30 Mar 2016, Laxman Dewangan wrote: +#define MAX77620_MFD_CELL_RES(_name, _res) \ + { \ + .name = (_name

Re: [PATCH] pinctrl: ish-pfc: avoid unused variable warning

2016-04-27 Thread Laxman Dewangan
On Wednesday 27 April 2016 03:26 PM, Arnd Bergmann wrote: After the conversion to devm_pinctrl_register, we get a warning in sh_pfc_remove when CONFIG_PINCTRL_SH_PFC_GPIO is disabled: drivers/pinctrl/sh-pfc/core.c: In function 'sh_pfc_remove': drivers/pinctrl/sh-pfc/core.c:603:17: unused

Re: [PATCH] pinctrl: ish-pfc: avoid unused variable warning

2016-04-27 Thread Laxman Dewangan
On Wednesday 27 April 2016 03:26 PM, Arnd Bergmann wrote: After the conversion to devm_pinctrl_register, we get a warning in sh_pfc_remove when CONFIG_PINCTRL_SH_PFC_GPIO is disabled: drivers/pinctrl/sh-pfc/core.c: In function 'sh_pfc_remove': drivers/pinctrl/sh-pfc/core.c:603:17: unused

Re: [PATCH 7/7] pinctrl: tegra: Add driver to configure voltage and power state of io pads

2016-04-26 Thread Laxman Dewangan
On Friday 15 April 2016 05:17 PM, Laxman Dewangan wrote: On Friday 15 April 2016 04:45 PM, Linus Walleij wrote: On Fri, Apr 15, 2016 at 11:55 AM, Laxman Dewangan <ldewan...@nvidia.com> wrote: On Friday 15 April 2016 02:55 PM, Linus Walleij wrote: If the pin could actually set a voltage

Re: [PATCH 7/7] pinctrl: tegra: Add driver to configure voltage and power state of io pads

2016-04-26 Thread Laxman Dewangan
On Friday 15 April 2016 05:17 PM, Laxman Dewangan wrote: On Friday 15 April 2016 04:45 PM, Linus Walleij wrote: On Fri, Apr 15, 2016 at 11:55 AM, Laxman Dewangan wrote: On Friday 15 April 2016 02:55 PM, Linus Walleij wrote: If the pin could actually set a voltage level it would have

Re: [PATCH 0/7] mfd: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 04:26 PM, Krzysztof Kozlowski wrote: On 04/21/2016 02:25 PM, Laxman Dewangan wrote: This series is an effort to reduce the code in error path and need of remove callback by using the devm_mfd_add_devices() and devm_regmap_add_irq_chip() or devm_request_threaded_irq APIs

Re: [PATCH 0/7] mfd: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 04:26 PM, Krzysztof Kozlowski wrote: On 04/21/2016 02:25 PM, Laxman Dewangan wrote: This series is an effort to reduce the code in error path and need of remove callback by using the devm_mfd_add_devices() and devm_regmap_add_irq_chip() or devm_request_threaded_irq APIs

[PATCH V5 4/4] gpio: tegra: Add support for gpio debounce

2016-04-25 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Stephen Warren <swar...@n

[PATCH V5 4/4] gpio: tegra: Add support for gpio debounce

2016-04-25 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren --- Changes from V1: - Write debounce count before

[PATCH V5 0/4] gpio: tegra: Cleanups and support for debounce

2016-04-25 Thread Laxman Dewangan
Add support for the debounce as Tegra210 support debounce in HW. Also do the clenaups to remove all global variables. Changes from V3: - Rearranging debounce registers and lock the DB CNT registers. Changes from V4: - Get rid of tegra_gpio_chip and tegra_irq_chip as global. Laxman Dewangan (4

[PATCH V5 0/4] gpio: tegra: Cleanups and support for debounce

2016-04-25 Thread Laxman Dewangan
Add support for the debounce as Tegra210 support debounce in HW. Also do the clenaups to remove all global variables. Changes from V3: - Rearranging debounce registers and lock the DB CNT registers. Changes from V4: - Get rid of tegra_gpio_chip and tegra_irq_chip as global. Laxman Dewangan (4

[PATCH V5 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-25 Thread Laxman Dewangan
Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Stephen Warren <swar...@nvidia.com> Reviewed-b

[PATCH V5 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-25 Thread Laxman Dewangan
Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren Reviewed-by: Alexandre Courbot --- This patch is reworked on top

[PATCH V5 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-25 Thread Laxman Dewangan
The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Suggested-by: Thierry Reding <tred...@nvidia.com> Reviewed-by: Stephen Warren <swa

[PATCH V5 1/4] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-25 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Stephen Warren <swar...@nvidia.com> Reviewed-by: Alexandre Courbot <acour...@nvidia.com> Acked-by: Thierry Reding &

[PATCH V5 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-25 Thread Laxman Dewangan
The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Signed-off-by: Laxman Dewangan Suggested-by: Thierry Reding Reviewed-by: Stephen Warren --- Changes from V2: -This is new in series based on discussion

[PATCH V5 1/4] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-25 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren Reviewed-by: Alexandre Courbot Acked-by: Thierry Reding --- Collected reviewed/ack by from Stephen, Alexandre and Thieery. --- drivers

Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 03:30 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Fri, Apr 22, 2016 at 03:39:13PM +0530, Laxman Dewangan wrote: [...] diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c [...] static struct gpio_chip tegra_gpio_chip = { This variable

Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 03:30 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Fri, Apr 22, 2016 at 03:39:13PM +0530, Laxman Dewangan wrote: [...] diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c [...] static struct gpio_chip tegra_gpio_chip = { This variable

Re: [PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 11:06 AM, Alexandre Courbot wrote: Sorry, just realized I commented on v3... On Fri, Apr 22, 2016 at 7:09 PM, Laxman Dewangan <ldewan...@nvidia.com> wrote: + spinlock_t dbc_lock[4]; /* Lock for updating debounce count register */ I'm nit'ing here, but may

Re: [PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 11:06 AM, Alexandre Courbot wrote: Sorry, just realized I commented on v3... On Fri, Apr 22, 2016 at 7:09 PM, Laxman Dewangan wrote: + spinlock_t dbc_lock[4]; /* Lock for updating debounce count register */ I'm nit'ing here, but maybe one spinlock shared by all

Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 10:43 AM, Alexandre Courbot wrote: On Fri, Apr 22, 2016 at 7:09 PM, Laxman Dewangan <ldewan...@nvidia.com> wrote: -static struct tegra_gpio_bank *tegra_gpio_banks; +struct tegra_gpio_info { I think tegra_gpio_chip would be a better name for this structure (espe

Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 10:43 AM, Alexandre Courbot wrote: On Fri, Apr 22, 2016 at 7:09 PM, Laxman Dewangan wrote: -static struct tegra_gpio_bank *tegra_gpio_banks; +struct tegra_gpio_info { I think tegra_gpio_chip would be a better name for this structure (especially if you make "s

Re: [PATCH V3 4/4] gpio: tegra: Add support for gpio debounce

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 10:25 AM, Alexandre Courbot wrote: On Wed, Apr 20, 2016 at 10:30 PM, Laxman Dewangan <ldewan...@nvidia.com> wrote: bank->int_lvl[p] = tegra_gpio_readl(tgi, @@ -550,6 +598,9 @@ static int tegra_gpio_probe(struct platform_dev

Re: [PATCH V3 4/4] gpio: tegra: Add support for gpio debounce

2016-04-25 Thread Laxman Dewangan
On Monday 25 April 2016 10:25 AM, Alexandre Courbot wrote: On Wed, Apr 20, 2016 at 10:30 PM, Laxman Dewangan wrote: bank->int_lvl[p] = tegra_gpio_readl(tgi, @@ -550,6 +598,9 @@ static int tegra_gpio_probe(struct platform_device *pdev) platform_set_drvdata(p

[PATCH 2/2] regulator: max77620: Add support for device specific ramp rate setting

2016-04-22 Thread Laxman Dewangan
for the device register configuration and ramp time calculation for voltage change. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- This patch is based on discussion on earlier patch: regulator: DT: Add support to scale ramp delay based on platform behavior The last point of the disc

[PATCH 1/2] regulator: max77620: Add details of device specific ramp rate setting

2016-04-22 Thread Laxman Dewangan
It is observed that the ramp rate measured on platform is not same as advertised ramp rate due to platform design variation. On this case, measured ramp rate is provided with property regulator-ramp-rate. For such cases, add DT property for device specific configurations. Signed-off-by: Laxman

[PATCH 2/2] regulator: max77620: Add support for device specific ramp rate setting

2016-04-22 Thread Laxman Dewangan
for the device register configuration and ramp time calculation for voltage change. Signed-off-by: Laxman Dewangan --- This patch is based on discussion on earlier patch: regulator: DT: Add support to scale ramp delay based on platform behavior The last point of the discussion is to have device specific

[PATCH 1/2] regulator: max77620: Add details of device specific ramp rate setting

2016-04-22 Thread Laxman Dewangan
It is observed that the ramp rate measured on platform is not same as advertised ramp rate due to platform design variation. On this case, measured ramp rate is provided with property regulator-ramp-rate. For such cases, add DT property for device specific configurations. Signed-off-by: Laxman

[PATCH V4 1/4] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-22 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Stephen Warren <swar...@nvidia.com> Reviewed-by: Alexandre Courbot <acour...@nvidia.com> Acked-by: Thierry Reding &

[PATCH V4 1/4] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-22 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren Reviewed-by: Alexandre Courbot Acked-by: Thierry Reding --- Collected reviewed/ack by from Stephen, Alexandre and Thieery. drivers/gpio

[PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-22 Thread Laxman Dewangan
Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Stephen Warren <swar...@nvidia.com> --- This patch

[PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-22 Thread Laxman Dewangan
Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren --- This patch is reworked on top of earlier patch gpio: tegra: Remove

[PATCH V4 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-22 Thread Laxman Dewangan
The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Suggested-by: Thierry Reding <tred...@nvidia.com> Reviewed-by: Stephen Warren <swa

[PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-22 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- Changes from V1: - Write debounce count before

[PATCH V4 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-22 Thread Laxman Dewangan
The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Signed-off-by: Laxman Dewangan Suggested-by: Thierry Reding Reviewed-by: Stephen Warren --- Changes from V2: -This is new in series based on discussion

[PATCH V4 4/4] gpio: tegra: Add support for gpio debounce

2016-04-22 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan --- Changes from V1: - Write debounce count before enable. - Make sure

Re: [PATCH 2/7] mfd: lp8788: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-22 Thread Laxman Dewangan
On Friday 22 April 2016 04:45 AM, Kim, Milo wrote: Hi Laxman, On 4/21/2016 9:25 PM, Laxman Dewangan wrote: Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This patch doesn't include the code regarding devm_mfd_add_devices

Re: [PATCH 2/7] mfd: lp8788: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-22 Thread Laxman Dewangan
On Friday 22 April 2016 04:45 AM, Kim, Milo wrote: Hi Laxman, On 4/21/2016 9:25 PM, Laxman Dewangan wrote: Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This patch doesn't include the code regarding devm_mfd_add_devices

Re: [PATCH V3 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-21 Thread Laxman Dewangan
On Friday 22 April 2016 12:03 AM, Stephen Warren wrote: On 04/20/2016 07:30 AM, Laxman Dewangan wrote: Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. diff --git a/drivers

Re: [PATCH V3 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-21 Thread Laxman Dewangan
On Friday 22 April 2016 12:03 AM, Stephen Warren wrote: On 04/20/2016 07:30 AM, Laxman Dewangan wrote: Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. diff --git a/drivers

[PATCH 2/7] mfd: lp8788: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> CC: Mi

[PATCH 2/7] mfd: lp8788: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan CC: Milo Kim --- drivers/mfd/lp8788

[PATCH 5/7] mfd: sec: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> CC: Sa

[PATCH 7/7] mfd: wl1273-core: Use devm_mfd_add_devices() for mfd_device registration

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for MFD devices registration and get rid of .remove callback to remove MFD child-devices. This is done by managed device framework. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- drivers/mfd/wl1273-core.c | 14 ++ 1 file changed, 2 inse

[PATCH 5/7] mfd: sec: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan CC: Sangbeom Kim CC: Krzysztof

[PATCH 7/7] mfd: wl1273-core: Use devm_mfd_add_devices() for mfd_device registration

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for MFD devices registration and get rid of .remove callback to remove MFD child-devices. This is done by managed device framework. Signed-off-by: Laxman Dewangan --- drivers/mfd/wl1273-core.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff

[PATCH 6/7] mfd: tps65910: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> CC

[PATCH 4/7] mfd: rc5t583: Use devm_mfd_add_devices and devm_request_threaded_irq

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_request_threaded_irq() for IRQ registration. This reduces the need of remove callback for removing MFD child devices and unregistering IRQ. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- drivers/mfd/rc5t583-irq.

[PATCH 0/7] mfd: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
the required MFD CONFIGs. Laxman Dewangan (7): mfd: as3722: Use devm_mfd_add_devices and devm_regmap_add_irq_chip mfd: lp8788: Use devm_mfd_add_devices and devm_regmap_add_irq_chip mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip mfd: rc5t583: Use devm_mfd_add_devices

[PATCH 4/7] mfd: rc5t583: Use devm_mfd_add_devices and devm_request_threaded_irq

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_request_threaded_irq() for IRQ registration. This reduces the need of remove callback for removing MFD child devices and unregistering IRQ. Signed-off-by: Laxman Dewangan --- drivers/mfd/rc5t583-irq.c | 11 ++- drivers

[PATCH 0/7] mfd: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
the required MFD CONFIGs. Laxman Dewangan (7): mfd: as3722: Use devm_mfd_add_devices and devm_regmap_add_irq_chip mfd: lp8788: Use devm_mfd_add_devices and devm_regmap_add_irq_chip mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip mfd: rc5t583: Use devm_mfd_add_devices

[PATCH 6/7] mfd: tps65910: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan CC: Tony Lindgren CC: linux-o

[PATCH 1/7] mfd: as3722: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- d

[PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> CC: C

[PATCH 1/7] mfd: as3722: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan --- drivers/mfd/as3722.c | 31

[PATCH 3/7] mfd: max77686: Use devm_mfd_add_devices and devm_regmap_add_irq_chip

2016-04-21 Thread Laxman Dewangan
Use devm_mfd_add_devices() for adding MFD child devices and devm_regmap_add_irq_chip() for IRQ chip registration. This reduces the error code path and .remove callback for removing MFD child devices and deleting IRQ chip data. Signed-off-by: Laxman Dewangan CC: Chanwoo Choi CC: Krzysztof

[PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback

2016-04-21 Thread Laxman Dewangan
SMSC MFD driver does not add any MFD child devices via mfd_add_devices() and hence it is not required to call mfd_remove_devices() to remove MFD child devices. Remove the call of the API mfd_remove_devices() which will result as remove of .remove callback for driver. Signed-off-by: Laxman

[PATCH] mfd: smsc-ece1099: Remove unnecessarily remove callback

2016-04-21 Thread Laxman Dewangan
SMSC MFD driver does not add any MFD child devices via mfd_add_devices() and hence it is not required to call mfd_remove_devices() to remove MFD child devices. Remove the call of the API mfd_remove_devices() which will result as remove of .remove callback for driver. Signed-off-by: Laxman

Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

2016-04-20 Thread Laxman Dewangan
On Thursday 21 April 2016 05:13 AM, Eduardo Valentin wrote: Laxman, On Tue, Apr 19, 2016 at 12:52:01PM +0530, Laxman Dewangan wrote: In some of platform, thermal sensors like NCT thermistors are connected to the one of ADC channel. The temperature is read by reading the voltage across

Re: [PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

2016-04-20 Thread Laxman Dewangan
On Thursday 21 April 2016 05:13 AM, Eduardo Valentin wrote: Laxman, On Tue, Apr 19, 2016 at 12:52:01PM +0530, Laxman Dewangan wrote: In some of platform, thermal sensors like NCT thermistors are connected to the one of ADC channel. The temperature is read by reading the voltage across

[PATCH 1/1] pinctrl: core: Fix build error due to devm_pinctrl_dev_match()

2016-04-20 Thread Laxman Dewangan
The closing bracket missing from final patch which causes the build break. Correcting the function. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- This may be happend by mistake when applyign the pathces for git hub from test branch to devm_pinctrl branch. This is happening on

[PATCH 1/1] pinctrl: core: Fix build error due to devm_pinctrl_dev_match()

2016-04-20 Thread Laxman Dewangan
The closing bracket missing from final patch which causes the build break. Correcting the function. Signed-off-by: Laxman Dewangan --- This may be happend by mistake when applyign the pathces for git hub from test branch to devm_pinctrl branch. This is happening on devel branch of pinctrl

[PATCH V3 4/4] gpio: tegra: Add support for gpio debounce

2016-04-20 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- Changes from V1: - Write debounce count before

[PATCH V3 4/4] gpio: tegra: Add support for gpio debounce

2016-04-20 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan --- Changes from V1: - Write debounce count before enable. - Make sure

[PATCH V3 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-20 Thread Laxman Dewangan
Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- This patch is reworked on top of earlier patch gpio: tegra:

[PATCH V3 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-20 Thread Laxman Dewangan
Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. Signed-off-by: Laxman Dewangan --- This patch is reworked on top of earlier patch gpio: tegra: Remove the need of keeping device

[PATCH V3 0/4] gpio: tegra: Cleanups and support fro debounce

2016-04-20 Thread Laxman Dewangan
Add support for the debounce as Tegra210 support debounce in HW. Also do the clenaups to remove all global variables. Laxman Dewangan (4): gpio: tegra: Don't open code of_device_get_match_data() gpio: tegra: Make of_device_id compatible data to constant gpio: tegra: Get rid of all file

[PATCH V3 0/4] gpio: tegra: Cleanups and support fro debounce

2016-04-20 Thread Laxman Dewangan
Add support for the debounce as Tegra210 support debounce in HW. Also do the clenaups to remove all global variables. Laxman Dewangan (4): gpio: tegra: Don't open code of_device_get_match_data() gpio: tegra: Make of_device_id compatible data to constant gpio: tegra: Get rid of all file

[PATCH V3 1/4] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-20 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Stephen Warren <swar...@nvidia.com> Reviewed-by: Alexandre Courbot <acour...@nvidia.com> Acked-by: Thierry Reding &

[PATCH V3 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-20 Thread Laxman Dewangan
The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Suggested-by: Thierry Reding <tred...@nvidia.com> --- Changes from V2: -This is new in

[PATCH V3 1/4] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-20 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren Reviewed-by: Alexandre Courbot Acked-by: Thierry Reding --- Collected reviewed/ack by from Stephen, Alexandre and Thieery. --- drivers

[PATCH V3 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-20 Thread Laxman Dewangan
The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Signed-off-by: Laxman Dewangan Suggested-by: Thierry Reding --- Changes from V2: -This is new in series based on discussion on previous patches. --- drivers

Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 09:41 PM, Stephen Warren wrote: On 04/19/2016 03:43 AM, Laxman Dewangan wrote: NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip

Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 09:41 PM, Stephen Warren wrote: On 04/19/2016 03:43 AM, Laxman Dewangan wrote: NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip

Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 06:07 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote: [...] @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = { .upper_offset = 0x80, }; +static struct

Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 06:07 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote: [...] @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = { .upper_offset = 0x80, }; +static struct

Re: [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 06:03 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, Apr 19, 2016 at 03:13:39PM +0530, Laxman Dewangan wrote: Remove the file static device handle variable for keeping device handle of driver as this is just required for error prints. The required

Re: [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 06:03 PM, Thierry Reding wrote: * PGP Signed by an unknown key On Tue, Apr 19, 2016 at 03:13:39PM +0530, Laxman Dewangan wrote: Remove the file static device handle variable for keeping device handle of driver as this is just required for error prints. The required

Re: [PATCH 1/2] regulator: DT: Add support to scale ramp delay based on platform behavior

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 04:25 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Apr 19, 2016 at 03:31:11PM +0530, Laxman Dewangan wrote: On Wednesday 13 April 2016 12:23 PM, Mark Brown wrote: Possibly. It did also occur to me last night that having a Maxim specific property

Re: [PATCH 1/2] regulator: DT: Add support to scale ramp delay based on platform behavior

2016-04-19 Thread Laxman Dewangan
On Tuesday 19 April 2016 04:25 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Apr 19, 2016 at 03:31:11PM +0530, Laxman Dewangan wrote: On Wednesday 13 April 2016 12:23 PM, Mark Brown wrote: Possibly. It did also occur to me last night that having a Maxim specific property

Re: [PATCH 1/2] regulator: DT: Add support to scale ramp delay based on platform behavior

2016-04-19 Thread Laxman Dewangan
On Wednesday 13 April 2016 12:23 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Apr 12, 2016 at 06:59:06PM +0530, Laxman Dewangan wrote: I have put my understanding based on datasheet and observation but it seems I am missing some important information which is making difficult

Re: [PATCH 1/2] regulator: DT: Add support to scale ramp delay based on platform behavior

2016-04-19 Thread Laxman Dewangan
On Wednesday 13 April 2016 12:23 PM, Mark Brown wrote: * PGP Signed by an unknown key On Tue, Apr 12, 2016 at 06:59:06PM +0530, Laxman Dewangan wrote: I have put my understanding based on datasheet and observation but it seems I am missing some important information which is making difficult

Re: [PATCH 7/7] pinctrl: tegra: Add driver to configure voltage and power state of io pads

2016-04-19 Thread Laxman Dewangan
Hi Linus, On Friday 15 April 2016 07:29 PM, Laxman Dewangan wrote: On Friday 15 April 2016 07:33 PM, Linus Walleij wrote: On Fri, Apr 15, 2016 at 1:47 PM, Laxman Dewangan <ldewan...@nvidia.com> wrote: On Friday 15 April 2016 04:45 PM, Linus Walleij wrote: On Fri, Apr 15, 2016 at 11

Re: [PATCH 7/7] pinctrl: tegra: Add driver to configure voltage and power state of io pads

2016-04-19 Thread Laxman Dewangan
Hi Linus, On Friday 15 April 2016 07:29 PM, Laxman Dewangan wrote: On Friday 15 April 2016 07:33 PM, Linus Walleij wrote: On Fri, Apr 15, 2016 at 1:47 PM, Laxman Dewangan wrote: On Friday 15 April 2016 04:45 PM, Linus Walleij wrote: On Fri, Apr 15, 2016 at 11:55 AM, Laxman Dewangan wrote

[PATCH V2 1/3] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-19 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Reviewed-by: Stephen Warren <swar...@nvidia.com> --- Collected reviewed by from Stephen. --- drivers/gpio/gpio-

[PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

2016-04-19 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- Changes from V1: - Write debounce count before

[PATCH V2 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-19 Thread Laxman Dewangan
Remove the file static device handle variable for keeping device handle of driver as this is just required for error prints. The required device handle are available from gpiochip structure. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- drivers/gpio/gpio-tegra.c | 8

[PATCH V2 1/3] gpio: tegra: Don't open code of_device_get_match_data()

2016-04-19 Thread Laxman Dewangan
Use of_device_get_match_data() for getting matched data instead of implementing this locally. Signed-off-by: Laxman Dewangan Reviewed-by: Stephen Warren --- Collected reviewed by from Stephen. --- drivers/gpio/gpio-tegra.c | 50 +++ 1 file changed

[PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

2016-04-19 Thread Laxman Dewangan
NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. Signed-off-by: Laxman Dewangan --- Changes from V1: - Write debounce count before enable. - Make sure

[PATCH V2 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-19 Thread Laxman Dewangan
Remove the file static device handle variable for keeping device handle of driver as this is just required for error prints. The required device handle are available from gpiochip structure. Signed-off-by: Laxman Dewangan --- drivers/gpio/gpio-tegra.c | 8 1 file changed, 4 insertions

[PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

2016-04-19 Thread Laxman Dewangan
support for thermal sensor driver which read the voltage across sensor resistance from ADC through IIO framework. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> --- Changes from V1: - Use the two dimensional lookup table for temperature vs ADC value. - Use non devm_ for thermal zone

[PATCH V4 1/2] thermal: generic-adc: Add DT binding for ADC based thermal sensor

2016-04-19 Thread Laxman Dewangan
the DT property and provide the example for how to use it. Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes from V1: - Make the lookup table to two dimensional instead of single array of linear step of temperature. - Remove deta

[PATCH V4 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

2016-04-19 Thread Laxman Dewangan
support for thermal sensor driver which read the voltage across sensor resistance from ADC through IIO framework. Signed-off-by: Laxman Dewangan --- Changes from V1: - Use the two dimensional lookup table for temperature vs ADC value. - Use non devm_ for thermal zone sensor registration

[PATCH V4 1/2] thermal: generic-adc: Add DT binding for ADC based thermal sensor

2016-04-19 Thread Laxman Dewangan
the DT property and provide the example for how to use it. Signed-off-by: Laxman Dewangan Acked-by: Rob Herring --- Changes from V1: - Make the lookup table to two dimensional instead of single array of linear step of temperature. - Remove detailing of IIO frameowrk and drivers. - Added proper

Re: [PATCH V3 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

2016-04-18 Thread Laxman Dewangan
On Monday 18 April 2016 11:01 PM, Jonathan Cameron wrote: On 18 April 2016 17:49:39 BST, Laxman Dewangan <ldewan...@nvidia.com> wrote: On Sunday 17 April 2016 04:24 PM, Jonathan Cameron wrote: On 14/04/16 15:41, Laxman Dewangan wrote: +static int gadc_thermal_read_channel(

Re: [PATCH V3 2/2] thermal: generic-adc: Add ADC based thermal sensor driver

2016-04-18 Thread Laxman Dewangan
On Monday 18 April 2016 11:01 PM, Jonathan Cameron wrote: On 18 April 2016 17:49:39 BST, Laxman Dewangan wrote: On Sunday 17 April 2016 04:24 PM, Jonathan Cameron wrote: On 14/04/16 15:41, Laxman Dewangan wrote: +static int gadc_thermal_read_channel(struct gadc_thermal_info *gti, int *val

Re: [PATCH 3/3] gpio: tegra: Add support for gpio debounce

2016-04-18 Thread Laxman Dewangan
On Monday 18 April 2016 10:08 PM, Stephen Warren wrote: On 04/18/2016 02:46 AM, Laxman Dewangan wrote: + +/* There is only one debounce count register per port and hence + * set the maximum of current and requested debounce time. + */ +max_dbc = tegra_gpio_readl(GPIO_DBC_CNT

Re: [PATCH 3/3] gpio: tegra: Add support for gpio debounce

2016-04-18 Thread Laxman Dewangan
On Monday 18 April 2016 10:08 PM, Stephen Warren wrote: On 04/18/2016 02:46 AM, Laxman Dewangan wrote: + +/* There is only one debounce count register per port and hence + * set the maximum of current and requested debounce time. + */ +max_dbc = tegra_gpio_readl(GPIO_DBC_CNT

Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

2016-04-18 Thread Laxman Dewangan
On Monday 18 April 2016 09:59 PM, Stephen Warren wrote: On 04/18/2016 02:46 AM, Laxman Dewangan wrote: Remove the file static device handle variable as this is just required for prints. The required handle can be stored in tegra_gpio_chip and hence it become redundancy. This seems fine

<    2   3   4   5   6   7   8   9   10   11   >