[PATCH 34/57] staging: most: dim2: hal: Fix one kernel-doc header and demote two non-conforming ones

Shvetsov Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/most/dim2/hal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c index 39e17a7d2f24b..30112413f20a0 100644 --- a/drivers

[PATCH 32/57] staging: rtl8723bs: core: rtw_mlme_ext: 'evt_seq' is only used if CHECK_EVENT_SEQ is set

/rtw_mlme_ext.c: In function ‘issue_probersp’: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:2543:1: warning: the frame size of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core

[PATCH 31/57] staging: rtl8723bs: core: rtw_mlme: 'retry' is only used if REJOIN is set

Aiuto Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index c624887aeed0c

[PATCH 29/57] staging: most: dim2: Provide missing descriptions and fix doc-rot

" Cc: Andrey Shvetsov Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/most/dim2/dim2.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index b34

[PATCH 28/57] staging: rtl8192u: ieee80211_softmac: Move a large data struct onto the heap

-than=] Cc: Greg Kroah-Hartman Cc: Romain Perier Cc: Allen Pais Cc: Andrea Merello Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging

[PATCH 30/57] staging: rtl8723bs: core: rtw_ieee80211: Remove seemingly pointless copy

-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index

[PATCH 27/57] staging: vt6655: upc: Suppress set but not used warning in macro

-off-by: Lee Jones --- drivers/staging/vt6655/upc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h index e086ec6e77f73..8608693ae9c3e 100644 --- a/drivers/staging/vt6655/upc.h +++ b/drivers/staging/vt6655/upc.h

[PATCH 25/57] staging: sm750fb: sm750_accel: Provide description for 'accel' and fix function naming

was for sm750_hw_copyarea() instead drivers/staging/sm750fb/sm750_accel.c:321: warning: Function parameter or member 'accel' not described in 'sm750_hw_imageblit' Cc: Sudip Mukherjee Cc: Teddy Wang Cc: Greg Kroah-Hartman Cc: linux-fb...@vger.kernel.org Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee

[PATCH 26/57] staging: most: net: Fix some kernel-doc formatting issues

/most/net/net.c:548: warning: Function parameter or member 'mac_addr' not described in 'on_netinfo' Cc: Greg Kroah-Hartman Cc: Andrey Shvetsov Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/most/net/net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH 24/57] staging: fwserial: Demote a whole host of kernel-doc abuses

or member 'callback_data' not described in 'fwserial_mgmt_handler' drivers/staging/fwserial/fwserial.c:2717: warning: Excess function parameter 'parameters' description in 'fwserial_mgmt_handler' Cc: Greg Kroah-Hartman Cc: Peter Hurley Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones

[PATCH 23/57] staging: ks7010: ks_hostif: Remove a bunch of unused variables

[-Wunused-but-set-variable] drivers/staging/ks7010/ks_hostif.c: In function ‘hostif_phy_information_confirm’: drivers/staging/ks7010/ks_hostif.c:929:19: warning: variable ‘noise’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee

[PATCH 22/57] staging: nvec: Fix a bunch of kernel-doc issues

: Andres Klode Cc: ac...@lists.launchpad.net Cc: linux-te...@vger.kernel.org Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/nvec/nvec.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c

[PATCH 21/57] staging: iio: frequency: ad9834: Provide missing description for 'devid'

: linux-...@vger.kernel.org Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/iio/frequency/ad9834.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9834.c b/drivers/staging/iio/frequency/ad9834.c index 60a3ae5587b90

[PATCH 20/57] staging: rtl8712: rtl871x_mp_ioctl: Move a large data struct onto the heap

Schilhabel Cc: Greg Kroah-Hartman Cc: Zhansaya Bagdauletkyzy Cc: Michael Straube Cc: WLAN FAE Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 29 +- 1 file changed, 17 insertions(+), 12 deletions(-) diff --git

[PATCH 18/57] staging: octeon: ethernet-tx: Fix formatting issue in function header

Fixes the following W=1 kernel build warning(s): drivers/staging/octeon/ethernet-tx.c:507: warning: bad line: Cc: Greg Kroah-Hartman Cc: Thomas Gleixner Cc: Kees Cook Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/octeon/ethernet-tx.c | 1 - 1 file changed

[PATCH 19/57] staging: rtl8723bs: core: rtw_wlan_util: Remove unused variable 'start_seq'

/core/rtw_wlan_util.c:12: Cc: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging

[PATCH 16/57] staging: rtl8723bs: core: rtw_sta_mgt: Remove unused variable 'psta'

Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index 85663182b388a..7b631a6b258a1 100644

[PATCH 17/57] staging: rtl8723bs: core: rtw_sta_mgt: Return error value directly

Schmidt Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index

[PATCH 15/57] staging: rtl8723bs: core: rtw_security: Demote non-conformant kernel-doc header

: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_security.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 13/57] staging: rtl8723bs: core: rtw_recv: Mark debug variable as __maybe_unused

[-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core

[PATCH 14/57] staging: rtl8188eu: core: rtw_security: Fix some formatting and misdocumentation

: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Larry Finger Cc: Greg Kroah-Hartman Cc: Michael Straube Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8188eu/core/rtw_security.c | 10

[PATCH 11/57] staging: rtl8723bs: core: rtw_mlme_ext: Deal with a bunch of unused variables

/rtl8723bs/core/rtw_mlme_ext.c: In function ‘led_blink_hdl’: drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:6517:25: warning: variable ‘ledBlink_param’ set but not used [-Wunused-but-set-variable] Cc: Greg Kroah-Hartman Cc: Ross Schmidt Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones

[PATCH 12/57] staging: rtl8712: rtl871x_mp_ioctl: Remove a bunch of unused tables

/rtl8712/rtl871x_mp_ioctl.h:138:34: warning: ‘oid_rtl_seg_81_80_00’ defined but not used [-Wunused-const-variable=] Cc: Larry Finger Cc: Florian Schilhabel Cc: Greg Kroah-Hartman Cc: WLAN FAE Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8712

[PATCH 09/57] staging: rtl8188eu: core: rtw_ieee80211: Fix incorrectly documented function

: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ieee80211.c b/drivers/staging/rtl8188eu/core/rtw_ieee80211.c

[PATCH 10/57] staging: rtl8723bs: core: rtw_mlme: Remove a bunch of unused variables

: variable ‘pht_addtinfo’ set but not used [-Wunused-but-set-variable] from drivers/staging/rtl8188eu/core/rtw_mlme.c:12: Cc: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 15 ++- 1 file changed, 6

[PATCH 07/57] staging: wlan-ng: cfg80211: Move large struct onto the heap

: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/wlan-ng/cfg80211.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index 759e475e303c0

[PATCH 04/57] staging: r8192U_core: Do not use kernel-doc formatting for !kernel-doc headers

was for UpdateReceivedRateHistogramStatistics8190() instead Cc: Greg Kroah-Hartman Cc: Andrea Merello Cc: Jerry chuang Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8192u/r8192U_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 08/57] staging: rtw_ioctl_set: Move 'channel_table' to the only place it's used

:41, Cc: Larry Finger Cc: Greg Kroah-Hartman Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 8 drivers/staging/rtl8188eu/include/rtw_mlme_ext.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 06/57] staging: r819xU_cmdpkt: Remove functionless method 'cmpk_handle_query_config_rx'

: Michael Straube Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 41 1 file changed, 41 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.c b/drivers/staging/rtl8192u/r819xU_cmdpkt.c index

[PATCH 05/57] staging: r819xU_phy: Remove some local variables from the stack

: Michael Straube Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8192u/r819xU_phy.c | 48 ++- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c

[PATCH 02/57] staging: android: ashmem: Supply description for 'new_range'

rauner Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Robert Love Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/android/ashmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index d66

[PATCH 03/57] staging: comedi_8254: Fix descriptions for 'i8254' and 'iobase'

' not described in 'comedi_8254_init' drivers/staging/comedi/drivers/comedi_8254.c:620: warning: Excess function parameter 'mmio' description in 'comedi_8254_init' Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Greg Kroah-Hartman Cc: "David A. Schleef" Cc: linux-stag...@lists.linux.dev Signed-o

[PATCH 01/57] staging: r8192U_core: Remove unused variable 'ret' and demote kernel-doc abuse

: Jerry chuang Cc: linux-stag...@lists.linux.dev Signed-off-by: Lee Jones --- drivers/staging/rtl8192u/r8192U_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index f48186a89fa14

[PATCH 00/57] Rid W=1 warnings from Staging

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (57): staging: r8192U_core: Remove two unused variables 'ret' and 'reset_status' staging: android: ashmem: Supply description

Re: [GIT PULL] Immutable branch between MFD, Clock, GPIO, Regulator and RTC due for the v5.13 merge window

On Wed, 14 Apr 2021, Vaittinen, Matti wrote: > Hello Lee, Mark, Stephen, Linus, Alexandre, > > On Wed, 2021-04-14 at 15:53 +0100, Lee Jones wrote: > > On Wed, 14 Apr 2021, Lee Jones wrote: > > > > > Please note that this PR will break your build unless you have th

Re: [PATCH v2 1/1] mfd: intel_quark_i2c_gpio: Don't play dirty trick with const

On Fri, 26 Mar 2021, Lee Jones wrote: > On Fri, 26 Mar 2021, Andy Shevchenko wrote: > > > As Linus rightfully noticed, the driver plays dirty trick with const, > > i.e. it assigns a place holder data structure to the const field > > in the MFD cell and then drops the c

Re: [PATCH v9 1/1] mfd: intel-m10-bmc: support for MAX10 BMC Secure Updates

On Wed, 14 Apr 2021, Tom Rix wrote: > > On 4/12/21 12:53 PM, Russ Weight wrote: > > Add macros and definitions required by the MAX10 BMC > > Secure Update driver. > > > > Signed-off-by: Russ Weight > > Acked-by: Lee Jones > > --- > &

Re: [GIT PULL] Immutable branch between MFD, Clock, GPIO, Regulator and RTC due for the v5.13 merge window

On Wed, 14 Apr 2021, Lee Jones wrote: > Please note that this PR will break your build unless you have the > required Regulator API update. > > fb8fee9efdcf0 regulator: Add regmap helper for ramp-delay setting > e3baacf542756 regulator: helpers: Export helper voltage listing

[GIT PULL] Immutable branch between MFD, Clock, GPIO, Regulator and RTC due for the v5.13 merge window

,bd71815-pmic.yaml create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd71815-regulator.yaml create mode 100644 drivers/gpio/gpio-bd71815.c create mode 100644 drivers/regulator/bd71815-regulator.c create mode 100644 include/linux/mfd/rohm-bd71815.h -- Lee Jones [李琼斯] Senior

Re: [PATCH v9 1/1] mfd: intel-m10-bmc: support for MAX10 BMC Secure Updates

On Mon, 12 Apr 2021, Russ Weight wrote: > Add macros and definitions required by the MAX10 BMC > Secure Update driver. > > Signed-off-by: Russ Weight > Acked-by: Lee Jones > --- > v9: > - Rebased on next-20210412 > v8: > - Previously patch 1/6 in "I

Re: [PATCH v2 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

2c.c | 6 ++ > 2 files changed, 16 insertions(+) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] Revert "mfd: max8997: Add of_compatible to Extcon and Charger mfd_cell"

configure charger supply, making subnodes for MFD cells > obsolete. > > Signed-off-by: Timon Baetz > --- > drivers/mfd/max8997.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org

Re: [PATCH -next] mfd: twl: Remove unused inline function twl4030charger_usb_en()

On Thu, 01 Apr 2021, YueHaibing wrote: > There is no caller in tree, so can remove it. > > Signed-off-by: YueHaibing > --- > include/linux/mfd/twl.h | 2 -- > 1 file changed, 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services

Re: [PATCH] mfd: abx500: Remove repeated struct declaration

de/linux/mfd/abx500/ab8500-bm.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Please check, but I don't think this patch is valid anymore. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH V2 3/4] dt-bindings: mfd: Convert pm8xxx bindings to yaml

/bindings/mfd/qcom-pm8xxx.yaml | 54 +++ > 2 files changed, 54 insertions(+), 100 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml Applied, thanks. -- Lee Jones [李琼斯] Se

Re: [PATCH V2 2/4] dt-bindings: mfd: Add compatible for pmk8350 rtc

/qcom-pm8xxx.txt | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

busses/i2c-designware-platdrv.c | 7 +-- > include/linux/platform_data/i2c-designware.h | 13 - > 2 files changed, 1 insertion(+), 19 deletions(-) > delete mode 100644 include/linux/platform_data/i2c-designware.h Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead -

Re: [PATCH v1 1/2] mfd: intel_quark_i2c_gpio: Convert I²C to use software nodes

providers, i.e. Device Tree, ACPI, and board files. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_quark_i2c_gpio.c | 41 +++--- > 1 file changed, 26 insertions(+), 15 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead -

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

st remove it for good. > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Wolfram Sang Do you require an immutable branch? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v1 1/1] mfd: lpc_sch: Partially revert "Add support for Intel Quark X1000"

redundant code of IRQ support. > > This reverts commit ec689a8a8155ce8b966bd5d7737a3916f5e48be3. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/lpc_sch.c | 32 ++-- > 1 file changed, 6 insertions(+), 26 deletions(-) Applied, thanks. -- L

Re: [PATCH 00/18] Rid W=1 warnings from GFS2

On Fri, 09 Apr 2021, Andreas Gruenbacher wrote: > Hi Lee, > > On Tue, Apr 6, 2021 at 1:54 PM Lee Jones wrote: > > > > These have been on the list for a couple of weeks now. > > thanks for your fixes, I've gone through them now. I've fixed up some > comments inst

Re: [PATCH net-next v3 1/2] mfd: Add Renesas Synchronization Management Unit (SMU) support

> well. > But it is actually identical to v2 Then you need to mention that in the change log. What changed from v1 => v2? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH net-next v3 1/2] mfd: Add Renesas Synchronization Management Unit (SMU) support

fd/idt82p33_reg.h > create mode 100644 include/linux/mfd/idt8a340_reg.h > create mode 100644 include/linux/mfd/rsmu.h -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [RESEND 00/25] Rid W=1 warnings from HID

On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones wrote: > > > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, whi

Re: [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description

On Wed, 07 Apr 2021, Benjamin Tissoires wrote: > On Fri, Mar 26, 2021 at 3:35 PM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should > > be on > >

Re: [PATCH] mfd: arizona: Fix rumtime PM imbalance on error

runtime > PM counter on error. > > Signed-off-by: Dinghao Liu > --- > drivers/mfd/arizona-irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Ar

Re: [PATCH v2] mfd: max8997: Replace 8998 with 8997

| 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v5 (RESEND) 4/7] mfd: hi6421-spmi-pmic: move driver from staging

ndling thread: error %d\n", > + ret); Does checkpatch complain if this is just one long line? > + return ret; > + } > + > + dev_set_drvdata(>dev, ddata); > + > + ret = devm_mfd_add_devices(>dev, PLATFORM_DEVID_NONE, > +hi6421v600_devs, ARRAY_SIZE(hi6421v600_devs), > +NULL, 0, NULL); > + if (ret < 0) > + dev_err(dev, "Failed to add child devices: %d\n", ret); > + > + return ret; > +} > + > +static void hi6421_spmi_pmic_remove(struct spmi_device *pdev) > +{ > + struct hi6421_spmi_pmic *ddata = dev_get_drvdata(>dev); > + > + free_irq(ddata->irq, ddata); > +} > + > +static const struct of_device_id pmic_spmi_id_table[] = { > + { .compatible = "hisilicon,hi6421-spmi" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, pmic_spmi_id_table); > + > +static struct spmi_driver hi6421_spmi_pmic_driver = { > + .driver = { > + .name = "hi6421-spmi-pmic", Odd spacing. Does this line up with the other '='? > + .of_match_table = pmic_spmi_id_table, > + }, > + .probe = hi6421_spmi_pmic_probe, > + .remove = hi6421_spmi_pmic_remove, > +}; > +module_spmi_driver(hi6421_spmi_pmic_driver); > + > +MODULE_DESCRIPTION("HiSilicon Hi6421v600 SPMI PMIC driver"); > +MODULE_LICENSE("GPL v2"); -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 03/11] block: mtip32xx: mtip32xx: Mark debugging variable 'start' as __maybe_unused

On Tue, 06 Apr 2021, Bart Van Assche wrote: > On 3/12/21 2:55 AM, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/block/mtip32xx/mtip32xx.c: In function ‘mtip_standby_immediate’: > > drivers/block/mtip32xx/mtip32xx.c:1216:16: wa

Re: [PATCH v1 1/1] mfd: core: Use acpi_find_child_device() for child devices lookup

- > 1 file changed, 5 insertions(+), 17 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 00/11] Rid W=1 warnings from Block

On Tue, 06 Apr 2021, Jens Axboe wrote: > On 3/12/21 3:55 AM, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > Applied 2-11,

Re: [PATCH 00/18] Rid W=1 warnings from GFS2

On Tue, 06 Apr 2021, Bob Peterson wrote: > - Original Message - > > On Fri, 26 Mar 2021, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled

Re: [PATCH 00/18] Rid W=1 warnings from GFS2

On Fri, 26 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (18): > fs: gfs2: dir: Finish off mostly complete headers demote o

Re: [RESEND 00/25] Rid W=1 warnings from HID

On Fri, 26 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (25): > HID: intel-ish-hid: Remove unused variable 'err' >

Re: [PATCH 00/11] Rid W=1 warnings from Block

On Tue, 30 Mar 2021, Lee Jones wrote: > On Fri, 12 Mar 2021, Lee Jones wrote: > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee

Re: [PATCH v1 1/2] mfd: intel_quark_i2c_gpio: Convert I²C to use software nodes

ock): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 3/3] hwmon: intel-m10-bmc-hwmon: add sensor support of Intel D5005 card

MON_C_INPUT | HWMON_C_LABEL, > > + HWMON_C_INPUT | HWMON_C_MAX | HWMON_C_LABEL, > > + HWMON_C_INPUT | HWMON_C_MAX | HWMON_C_LABEL), > > + NULL > > +}; > > + > > +static const struct m10bmc_hwmon_board_data d5005bmc_hwmon_bdata = { > > + .tables = { > > + [hwmon_temp] = d5005bmc_temp_tbl, > > + [hwmon_in] = d5005bmc_in_tbl, > > + [hwmon_curr] = d5005bmc_curr_tbl, > > + }, > > + > > + .hinfo = d5005bmc_hinfo, > > +}; > > + > > static umode_t > > m10bmc_hwmon_is_visible(const void *data, enum hwmon_sensor_types type, > > u32 attr, int channel) > > @@ -316,6 +434,10 @@ static int m10bmc_hwmon_probe(struct platform_device > > *pdev) > > .name = "n3000bmc-hwmon", > > .driver_data = (unsigned long)_hwmon_bdata, > > }, > > + { > > + .name = "d5005bmc-hwmon", > > + .driver_data = (unsigned long)_hwmon_bdata, > > + }, > > { } > > }; > > > > diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c > > It may be better to split this patch into two parts to simplify > its review and scope of responsibility. No need. Not withstanding significant changes: Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 3/3] mfd: tqmx86: add support for TQMxE40M

re x86 SoMs. > > What may go wrong in the future?.. (rhetorical question, obviously) My preference would be to be explicit. Rather than support boards implicitly i.e. by accident. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[PATCH 29/31] fs: ecryptfs: mmap: Help out one function header and demote other abuses

: fs/ecryptfs/mmap.c:379: warning: Function parameter or member 'ecryptfs_inode' not described in 'ecryptfs_write_inode_size_to_header' Cc: Tyler Hicks Cc: James Morris Cc: Tycho Andersen Cc: Christian Brauner Cc: "Michael A. Halcrow" Cc: ecryp...@vger.kernel.org Signed-off-by:

[PATCH 28/31] fs: ecryptfs: crypto: Supply some missing param descriptions and demote abuses

' description in 'ecryptfs_decode_and_decrypt_filename' Cc: Tyler Hicks Cc: Eric Biggers Cc: "Michael A. Halcrow" Cc: "Michael C. Thompson" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/crypto.c | 20 ++-- 1 file changed, 10 insertions(+), 1

[PATCH 30/31] fs: ecryptfs: inode: Help out nearly-there header and demote non-conformant ones

lcrow" Cc: "Michael C. Thompsion" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/inode.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c index 861a01713f3f4..9ac527e498e16 100644 --- a

[PATCH 27/31] fs: ecryptfs: miscdev: File headers are not good kernel-doc candidates

' not described in 'ecryptfs_miscdev_response' Cc: Tyler Hicks Cc: "Michael A. Halcrow" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/miscdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ecryptfs/miscdev.c b/fs/ecryptfs/miscdev.c index 742

[PATCH 25/31] fs: ecryptfs: messaging: Add missing param descriptions and demote abuses

Hocko Cc: Andrew Morton Cc: "Michael A. Halcrow" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/messaging.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c index c0dfd9647627a..b38bd742fd

[PATCH 22/31] fs: ecryptfs: kthread: Demote file header and provide description for 'cred'

: "Michael A. Halcrow" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/kthread.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ecryptfs/kthread.c b/fs/ecryptfs/kthread.c index a7c903cb01a05..ae4cb4e2e1348 100644 --- a/fs/ecryptfs/kthread.

[PATCH 21/31] fs: ecryptfs: dentry: File headers are not good candidates for kernel-doc

Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/dentry.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ecryptfs/dentry.c b/fs/ecryptfs/dentry.c index 44606f079efb0..acaa0825e9bbe 100644 --- a/fs/ecryptfs/dentry.c +++ b/fs/ecryptfs/dentry.c @@ -1,5 +1,5 @@ // SP

[PATCH 20/31] fs: ecryptfs: debug: Demote a couple of kernel-doc abuses

' fs/ecryptfs/debug.c:19: warning: expecting prototype for eCryptfs(). Prototype was for ecryptfs_dump_auth_tok() instead Cc: Tyler Hicks Cc: "Michael A. Halcrow" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/debug.c | 4 ++-- 1 file changed, 2 insert

[PATCH 18/31] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header

: Excess function parameter 'mv' description in 'gfs2_update_stats' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lock_dlm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c

[PATCH 17/31] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses

or member 'file' not described in 'gfs2_io_error_bh_i' fs/gfs2/util.c:546: warning: Function parameter or member 'line' not described in 'gfs2_io_error_bh_i' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/util.c | 19

[PATCH 19/31] fs: ecryptfs: read_write: File headers do not make good candidates for kernel-doc

' not described in 'ecryptfs_read_lower_page_segment' Cc: Tyler Hicks Cc: "Michael A. Halcrow" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/read_write.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ecryptfs/read_write.c b/fs/ecryptfs/re

[PATCH 15/31] fs: gfs2: recovery: Provide missing param descriptions and remove one other

parameter or member 'pass' not described in 'foreach_descriptor' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/recovery.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c

[PATCH 16/31] fs: gfs2: super: Fix kernel-doc issues where feasible demote one other

: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/super.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index 669ce921d0096..841b430d532cd 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c

[PATCH 14/31] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours

: warning: Function parameter or member 'rgd' not described in 'fast_to_acquire' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/rgrp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c

[PATCH 12/31] fs: gfs2: ops_fstype: Fix a little doc-rot

: warning: Excess function parameter 'args' description in 'gfs2_fill_super' fs/gfs2/ops_fstype.c:1102: warning: Excess function parameter 'silent' description in 'gfs2_fill_super' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2

[PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS

This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. There is more to do in filesystems. Another set will follow. Lee Jones (31): fs: gfs2: dir: Finish off mostly complete headers demote others

[PATCH 11/31] fs: gfs2: file: Strip out superfluous param description and demote kernel-doc abuse

Signed-off-by: Lee Jones --- fs/gfs2/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 2d500f90cdacf..afab20e5954fd 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@ -118,7 +118,7 @@ static int gfs2_readdir(struct file *file

[PATCH 13/31] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad'

: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index 6e173ae378c44..33520eed467c2 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -1534,7 +1534,7 @@ void gfs2_wake_up_statfs

[PATCH 26/31] fs: ecryptfs: main: Demote a bunch of non-conformant kernel-doc headers

: James Morris Cc: "Michael A. Halcrow" Cc: "Michael C. Thompson" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/main.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c

[PATCH 24/31] fs: ecryptfs: super: Fix formatting, naming and kernel-doc abuses

in 'ecryptfs_show_options' fs/ecryptfs/super.c:133: warning: Function parameter or member 'root' not described in 'ecryptfs_show_options' Cc: Tyler Hicks Cc: "Michael A. Halcrow" Cc: "Michael C. Thompson" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/super.c | 8 ---

[PATCH 02/31] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones

Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/xattr.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/fs/gfs2/xattr.c b/fs/gfs2/xattr.c index 124b3d5a72665..fe2109789f75b 100644 --- a/fs/gfs2/xattr.c

[PATCH 31/31] fs: ecryptfs: keystore: Fix some kernel-doc issues and demote non-conformant headers

: expecting prototype for parse_tag_70_packet(). Prototype was for ecryptfs_parse_tag_70_packet() instead Cc: Tyler Hicks Cc: "Michael A. Halcrow" Cc: "Michael C. Thompson" Cc: "Trevor S. Highland" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --

[PATCH 23/31] fs: ecryptfs: file: Demote kernel-doc abuses

son" Cc: ecryp...@vger.kernel.org Signed-off-by: Lee Jones --- fs/ecryptfs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index 5fb45d865ce51..18d5b91cb573e 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs/file.c @@ -1,5 +1,5

[PATCH 01/31] fs: gfs2: dir: Finish off mostly complete headers demote others

-off-by: Lee Jones --- fs/gfs2/dir.c | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index c0f2875c946c9..9c1caaef3f0cd 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -767,7 +767,7 @@ static int get_leaf

[PATCH 04/31] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others

: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glops.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index ef0b583c3417c..5711b2c8de9e2 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2

[PATCH 06/31] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others

parameter or member 'sdp' not described in 'databuf_lo_before_commit' fs/gfs2/lops.c:983: warning: Function parameter or member 'tr' not described in 'databuf_lo_before_commit' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/lops.c

[PATCH 05/31] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers

: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/log.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 6410281546f92..eef33cd251e4b 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -65,7 +65,6 @@ unsigned int

[PATCH 08/31] fs: gfs2: aops: Fix a little potential doc-rot

-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/aops.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index cc4f987687f3c..23b5be3db044c 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -540,10 +540,7 @@ int gfs2_internal_read

[PATCH 10/31] fs: gfs2: inode: Fix worthy function headers demote others

in 'gfs2_setattr_simple' fs/gfs2/inode.c:1976: warning: Function parameter or member 'mnt_userns' not described in 'gfs2_setattr' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/inode.c | 22 -- 1 file changed, 12

[PATCH 09/31] fs: gfs2: meta_io: Add missing description for 'rahead' param

Fixes the following W=1 kernel build warning(s): fs/gfs2/meta_io.c:249: warning: Function parameter or member 'rahead' not described in 'gfs2_meta_read' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/meta_io.c | 1 + 1 file

[PATCH 03/31] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others

Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/bmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index 7a358ae051851..7ff20db4999fb 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -1477,7

[PATCH 07/31] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones

parameter or member 'p' not described in 'nq_m_sync' fs/gfs2/glock.c:1993: warning: Excess function parameter 'wait' description in 'gfs2_gl_hash_clear' Cc: Bob Peterson Cc: Andreas Gruenbacher Cc: cluster-de...@redhat.com Signed-off-by: Lee Jones --- fs/gfs2/glock.c | 9 - 1 file

<    1   2   3   4   5   6   7   8   9   10   >