[PATCH 05/11] block: drbd: drbd_receiver: Demote non-conformant kernel-doc headers

2021-03-12 Thread Lee Jones
/drbd_receiver.c:4807: warning: Function parameter or member 'len' not described in 'decode_bitmap_c' Cc: Philipp Reisner Cc: Lars Ellenberg Cc: Jens Axboe Cc: drbd-...@lists.linbit.com Cc: linux-bl...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/block/drbd/drbd_receiver.c | 24

[PATCH 06/11] block: drbd: drbd_main: Remove duplicate field initialisation

2021-03-12 Thread Lee Jones
: (near initialization for ‘cmdnames[44]’) Cc: Philipp Reisner Cc: Lars Ellenberg Cc: Jens Axboe Cc: drbd-...@lists.linbit.com Cc: linux-bl...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/block/drbd/drbd_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/drbd

[PATCH 08/11] block: drbd: drbd_main: Fix a bunch of function documentation discrepancies

2021-03-12 Thread Lee Jones
in 'drbd_queue_bitmap_io' drivers/block/drbd/drbd_main.c:3563: warning: Function parameter or member 'flags' not described in 'drbd_bitmap_io' Cc: Philipp Reisner Cc: Lars Ellenberg Cc: Jens Axboe Cc: drbd-...@lists.linbit.com Cc: linux-bl...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/block/drbd

[PATCH 01/11] block: rsxx: core: Remove superfluous const qualifier

2021-03-12 Thread Lee Jones
Axboe Cc: linux-bl...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/block/rsxx/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 5ac1881396afb..813b0a554d4a8 100644 --- a/drivers/block/rsxx/core.c +++ b

[PATCH 09/11] block: drbd: drbd_receiver: Demote less than half complete kernel-doc header

2021-03-12 Thread Lee Jones
in 'drbd_submit_peer_request' drivers/block/drbd/drbd_receiver.c:1641: warning: Function parameter or member 'fault_type' not described in 'drbd_submit_peer_request' Cc: Philipp Reisner Cc: Lars Ellenberg Cc: Jens Axboe Cc: drbd-...@lists.linbit.com Cc: linux-bl...@vger.kernel.org Signed-off-by: Lee Jones

[PATCH 04/11] block: drbd: drbd_state: Fix some function documentation issues

2021-03-12 Thread Lee Jones
: warning: Function parameter or member 'state_change' not described in 'after_state_ch' Cc: Philipp Reisner Cc: Lars Ellenberg Cc: Jens Axboe Cc: drbd-...@lists.linbit.com Cc: linux-bl...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/block/drbd/drbd_state.c | 7 --- 1 file changed, 4

[PATCH 00/11] Rid W=1 warnings from Block

2021-03-12 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (11): block: rsxx: core: Remove superfluous const qualifier block: drbd: drbd_interval: Demote some kernel-doc abuses and fix

[PATCH 03/11] block: mtip32xx: mtip32xx: Mark debugging variable 'start' as __maybe_unused

2021-03-12 Thread Lee Jones
-off-by: Lee Jones --- drivers/block/mtip32xx/mtip32xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 3be0dbc674bd0..bc485f1623361 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block

[PATCH 02/11] block: drbd: drbd_interval: Demote some kernel-doc abuses and fix another header

2021-03-12 Thread Lee Jones
' not described in 'drbd_find_overlap' Cc: Philipp Reisner Cc: Lars Ellenberg Cc: Jens Axboe Cc: drbd-...@lists.linbit.com Cc: linux-bl...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/block/drbd/drbd_interval.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 28/30] scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev'

2021-03-12 Thread Lee Jones
/scsi/3w-.c:1345:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Joel Jacobson Cc: de Melo Cc: Andre Hedrick Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones

[PATCH 30/30] scsi: 3w-sas: Remove unused variables 'sglist' and 'tw_dev'

2021-03-12 Thread Lee Jones
:1411:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable] Cc: Adam Radford Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-sas.c | 10 ++ 1 file changed, 2 insert

[PATCH 29/30] scsi: 3w-9xxx: Remove a few set but unused variables

2021-03-12 Thread Lee Jones
James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/3w-9xxx.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c index b96e82de4237d..

[PATCH 24/30] scsi: a100u2w: Remove unused variable 'bios_phys'

2021-03-12 Thread Lee Jones
Cc: Doug Ledford Cc: Christoph Hellwig Cc: Alan Cox Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/a100u2w.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c index 66c514310f3c5..c99224a128f82 100644 --- a/drivers/scsi/a10

[PATCH 27/30] scsi: myrs: Remove a couple of unused 'status' variables

2021-03-12 Thread Lee Jones
: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Linux GmbH Cc: "Leonard N. Zubkoff" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/myrs.c

[PATCH 25/30] scsi: dc395x: Fix incorrect naming in function headers

2021-03-12 Thread Lee Jones
...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/dc395x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index 3ea345c124673..e28f8931e23f8 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -958,7 +

[PATCH 12/30] scsi: lpfc: lpfc_debugfs: Fix incorrectly documented function lpfc_debugfs_commonxripools_data()

2021-03-12 Thread Lee Jones
"Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index ec5328f7f1d41..c23a535ac89ac 10064

[PATCH 26/30] scsi: atp870u: Fix naming and demote incorrect and non-conformant kernel-doc header

2021-03-12 Thread Lee Jones
Tosatti Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/atp870u.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index da6ca2b153d85..9d179cd15bb84 100644 --- a/drivers/scsi/atp870u.c +++ b/drivers/scsi/atp870

[PATCH 23/30] scsi: initio: Remove unused variable 'prev'

2021-03-12 Thread Lee Jones
c: Bas Vermeulen Cc: Christoph Hellwig Cc: Brian Macy Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/initio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index 814acc57069dc..926a7045c2e5c 100644 --- a/d

[PATCH 20/30] scsi: be2iscsi: be_main: Provide missing function name in header

2021-03-12 Thread Lee Jones
s E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-driv...@broadcom.com Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c

[PATCH 21/30] scsi: be2iscsi: be_mgmt: Fix beiscsi_phys_port()'s name in header

2021-03-12 Thread Lee Jones
" Cc: "Martin K. Petersen" Cc: linux-driv...@broadcom.com Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c

[PATCH 19/30] scsi: be2iscsi: be_iscsi: Fix incorrect naming of beiscsi_iface_config_vlan()

2021-03-12 Thread Lee Jones
" Cc: "Martin K. Petersen" Cc: linux-driv...@broadcom.com Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/be2iscsi/be_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2is

[PATCH 18/30] scsi: esas2r: esas2r_log: Supply __printf(x, y) formatting for esas2r_log_master()

2021-03-12 Thread Lee Jones
Grove Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/esas2r/esas2r_log.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/esas2r/esas2r_log.c b/drivers/scsi/esas2r/esas2r_log.c

[PATCH 22/30] scsi: bnx2i: bnx2i_sysfs: Fix bnx2i_set_ccell_info()'s name in description

2021-03-12 Thread Lee Jones
s E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Anil Veerabhadrappa Cc: Eddie Wai Cc: qlogic-storage-upstr...@qlogic.com Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/bnx2i/bnx2i_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 17/30] scsi: cxgbi: cxgb3i: cxgb3i: Fix misnaming of ddp_setup_conn_digest()

2021-03-12 Thread Lee Jones
Dimitris Michailidis Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c index 37d99357120fa..203f938fca7e5 10064

[PATCH 16/30] scsi: ufs: cdns-pltfrm: Supply function names for headers

2021-03-12 Thread Lee Jones
y Chu Cc: Jan Kotas Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/ufs/cdns-pltfrm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/ufs/cdns-pltfrm.c b/drivers/scsi/ufs/cdns-pltfrm.c index 149391faa19c1..13d92043e13b0 100644 --- a/drivers/scsi/ufs

[PATCH 15/30] scsi: lpfc: lpfc_nvme: Fix kernel-doc formatting issue

2021-03-12 Thread Lee Jones
n" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c index 5fe4e93fe984e..4d78eadb65c0a 100644 --- a/drivers/scsi/lpfc/lpfc_nvme.c +++

[PATCH 14/30] scsi: bfa: bfa_fcs_lport: Move a large struct from the stack onto the heap

2021-03-12 Thread Lee Jones
: Sudarsana Kalluru Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/bfa/bfa_fcs_lport.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/bfa/bfa_fcs_lp

[PATCH 10/30] scsi: qla2xxx: qla_nx2: Fix incorrectly named function qla8044_check_temp()

2021-03-12 Thread Lee Jones
"Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/drivers/scsi/qla2xxx/qla_nx2.c index 68a16c95dcb77..7c413f93d53ee 10064

[PATCH 11/30] scsi: qla2xxx: qla_target: Fix a couple of misdocumented functions

2021-03-12 Thread Lee Jones
(). Prototype was for qlt_lport_deregister() instead Cc: Nilesh Javali Cc: gr-qlogic-storage-upstr...@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Vladislav Bolkhovitin Cc: Nathaniel Clark Cc: "Nicholas A. Bellinger" Cc: linux-s...@vger

[PATCH 13/30] scsi: lpfc: lpfc_bsg: Fix a few incorrectly named functions

2021-03-12 Thread Lee Jones
" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_bsg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c index b974d39d233b8..

[PATCH 06/30] scsi: mpt3sas: mpt3sas_transport: Fix a couple of misdocumented functions/params

2021-03-12 Thread Lee Jones
James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: mpt-fusionlinux@avagotech.com Cc: mpt-fusionlinux@broadcom.com Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_transport.c | 7 --- 1 file changed, 4 insertions(+), 3 dele

[PATCH 08/30] scsi: qla2xxx: qla_mr: Fix a couple of misnamed functions

2021-03-12 Thread Lee Jones
(). Prototype was for qlafx00_mbx_completion() instead Cc: Nilesh Javali Cc: gr-qlogic-storage-upstr...@marvell.com Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/qla2xxx/qla_mr.c | 4 ++-- 1 file changed

[PATCH 07/30] scsi: libfc: fc_fcp: Fix misspelling of fc_fcp_destroy()

2021-03-12 Thread Lee Jones
ernel.org Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_fcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index b43b5f62ee3e3..509eacd7893d7 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc

[PATCH 09/30] scsi: mpt3sas: mpt3sas_ctl: Fix some kernel-doc misnaming issues

2021-03-12 Thread Lee Jones
nux@broadcom.com Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c index 44f9a05db94e1..

[PATCH 03/30] scsi: lpfc: lpfc_scsi: Fix a bunch of kernel-doc misdemeanours

2021-03-12 Thread Lee Jones
for lpfc_poll_rearm_time(). Prototype was for lpfc_poll_rearm_timer() instead Cc: James Smart Cc: Dick Kennedy Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_scsi.c | 24

[PATCH 01/30] scsi: mpt3sas: mpt3sas_config: Fix a bunch of potential naming doc-rot

2021-03-12 Thread Lee Jones
ernel.org Signed-off-by: Lee Jones --- drivers/scsi/mpt3sas/mpt3sas_config.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/mpt3sas_config.c index 8238843523b53..55cd329089246 100644 --- a/drivers/scsi/mpt3

[PATCH 04/30] scsi: lpfc: lpfc_attr: Fix a bunch of misnamed functions

2021-03-12 Thread Lee Jones
was for lpfc_fcp_cpu_map_show() instead Cc: James Smart Cc: Dick Kennedy Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/lpfc/lpfc_attr.c | 12 ++-- 1 file changed, 6 insertions(+), 6 dele

[PATCH 05/30] scsi: libfc: fc_rport: Fix incorrect naming of fc_rport_adisc_resp()

2021-03-12 Thread Lee Jones
n" Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/libfc/fc_rport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 56003208d2e7c..cd0fb8ca2425d 100644 --- a/drivers/scsi/libfc/fc_rport.c +++

[PATCH 02/30] scsi: ufs: ufshcd: Fix incorrectly named ufshcd_find_max_sup_active_icc_level()

2021-03-12 Thread Lee Jones
tin K. Petersen" Cc: Santosh Yaraganavi Cc: Vinayak Holikatti Cc: linux-s...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b65c2899aae41..

[PATCH 00/30] [Set 2] Rid W=1 warnings in SCSI

2021-03-12 Thread Lee Jones
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (30): scsi: mpt3sas: mpt3sas_config: Fix

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-11 Thread Lee Jones
On Thu, 11 Mar 2021, Daniel Vetter wrote: > On Mon, Mar 08, 2021 at 09:19:32AM +0000, Lee Jones wrote: > > On Fri, 05 Mar 2021, Roland Scheidegger wrote: > > > > > The vmwgfx ones look all good to me, so for > > > 23-53: Reviewed-by: Roland Scheidegger > >

Re: [PATCH v3 06/15] mfd: Add ROHM BD71815 ID

2021-03-10 Thread Lee Jones
On Wed, 10 Mar 2021, Matti Vaittinen wrote: > > On Wed, 2021-03-10 at 13:31 +0000, Lee Jones wrote: > > On Wed, 10 Mar 2021, Matti Vaittinen wrote: > > > > > On Wed, 2021-03-10 at 11:17 +, Lee Jones wrote: > > > > On Wed, 10 Mar 2021, Vaittinen, Ma

Re: [PATCH v4 0/4] Some improvement for Intel MAX 10 MFD drivers

2021-03-10 Thread Lee Jones
-bmc mfd driver > and the subdev drivers. > > Main changes from v2: > - Add Tom Rix as the reviewer for intel-m10-bmc mfd driver and the subdev > drivers. > - Rebased to 5.12-rc1 > > Main changes from v3: > - Improve the comments for valid version check. Good enough. All ap

Re: [PATCH v3 06/15] mfd: Add ROHM BD71815 ID

2021-03-10 Thread Lee Jones
On Wed, 10 Mar 2021, Matti Vaittinen wrote: > On Wed, 2021-03-10 at 11:17 +0000, Lee Jones wrote: > > On Wed, 10 Mar 2021, Vaittinen, Matti wrote: > > > > > Hello Lee, > > > > > > On Wed, 2021-03-10 at 10:36 +, Lee Jones wrote: > >

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-10 Thread Lee Jones
On Wed, 10 Mar 2021, Greg KH wrote: > On Tue, Mar 09, 2021 at 06:14:37PM +0000, Lee Jones wrote: > > On Tue, 09 Mar 2021, Greg KH wrote: > > > > > On Tue, Mar 09, 2021 at 11:06:05AM +0800, Zheng Yejian wrote: > > > > From: Thomas Gleixner > > &g

Re: [PATCH v1 5/7] mfd: lpc_ich: Switch to generic pci_p2sb_bar()

2021-03-10 Thread Lee Jones
On Wed, 10 Mar 2021, Andy Shevchenko wrote: > On Wed, Mar 10, 2021 at 10:35:39AM +0000, Lee Jones wrote: > > On Mon, 08 Mar 2021, Andy Shevchenko wrote: > > > > > Instead of open coding pci_p2sb_bar() functionality we are going to > > > use generic libr

Re: [PATCH v3 06/15] mfd: Add ROHM BD71815 ID

2021-03-10 Thread Lee Jones
On Wed, 10 Mar 2021, Vaittinen, Matti wrote: > Hello Lee, > > On Wed, 2021-03-10 at 10:36 +0000, Lee Jones wrote: > > On Mon, 08 Mar 2021, Matti Vaittinen wrote: > > > > > Add chip ID for ROHM BD71815 and PMIC so that drivers can identify > > > thi

Re: [GIT PULL] Immutable branch between MFD and Input due for the v5.13 merge window

2021-03-10 Thread Lee Jones
On Tue, 09 Mar 2021, Lee Jones wrote: > On Tue, 09 Mar 2021, Lee Jones wrote: > > > Enjoy! > > > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) > > > > are av

Re: [GIT PULL] Immutable branch between MFD, PWM and RTC due for the v5.13 merge window

2021-03-10 Thread Lee Jones
On Tue, 09 Mar 2021, Lee Jones wrote: > On Mon, 01 Mar 2021, Lee Jones wrote: > > > Enjoy! > > > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) > > > > are av

[GIT PULL] Immutable branch between MFD and Watchdog due for the v5.13 merge window

2021-03-10 Thread Lee Jones
/watchdog/bd9576_wdt.c create mode 100644 include/linux/mfd/rohm-bd957x.h -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[GIT PULL v2] Immutable branch between MFD and Platform/X86 due for the v5.13 merge window

2021-03-10 Thread Lee Jones
drivers/platform/x86/intel_pmt_class.h | 1 + drivers/platform/x86/intel_pmt_telemetry.c | 20 -- 4 files changed, 122 insertions(+), 57 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro

Re: [PATCH v3 11/15] regulator: rohm-regulator: Support SNVS HW state.

2021-03-10 Thread Lee Jones
ttinen > --- > drivers/regulator/rohm-regulator.c | 6 ++ > include/linux/mfd/rohm-generic.h | 6 +- For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones > 2 files changed, 11 insertions(+), 1 deletion(-) -- Lee Jones [李琼斯]

Re: [PATCH v3 07/15] mfd: Support for ROHM BD71815 PMIC core

2021-03-10 Thread Lee Jones
remove this line. For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3 06/15] mfd: Add ROHM BD71815 ID

2021-03-10 Thread Lee Jones
On Mon, 08 Mar 2021, Matti Vaittinen wrote: > Add chip ID for ROHM BD71815 and PMIC so that drivers can identify > this IC. > > Signed-off-by: Matti Vaittinen > Acked-for-MFD-by: Lee Jones > --- > include/linux/mfd/rohm-generic.h | 1 + > 1 file changed, 1 inse

Re: [PATCH v1 5/7] mfd: lpc_ich: Switch to generic pci_p2sb_bar()

2021-03-10 Thread Lee Jones
your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v1 4/7] mfd: lpc_ich: Factor out lpc_ich_enable_spi_write()

2021-03-10 Thread Lee Jones
ay more lines than you're saving here. It's not a horrible change, so: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro:

Re: [PATCH v1 6/7] mfd: lpc_ich: Add support for pinctrl in non-ACPI system

2021-03-10 Thread Lee Jones
he has an opinion. > + return mfd_add_devices(>dev, 0, apl_gpio_devices, Please use the defines, rather than 0. > +ARRAY_SIZE(apl_gpio_devices), NULL, 0, NULL); > +} > + > static void lpc_ich_test_spi_write(struct pci_dev *dev, unsigned int devfn, >

Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-10 Thread Lee Jones
v, "Failed to add subdevices: %d\n", res); > > diff --git a/include/linux/mfd/ntxec.h b/include/linux/mfd/ntxec.h > index 361204d125f1..26ab3b8eb612 100644 > --- a/include/linux/mfd/ntxec.h > +++ b/include/linux/mfd/ntxec.h > @@ -33,5 +33,6 @@ static inline __be16 ntxec_reg8(u8 value) > > /* Known firmware versions */ > #define NTXEC_VERSION_KOBO_AURA 0xd726 /* found in Kobo Aura */ > +#define NTXEC_VERSION_TOLINO_SHINE2 0xf110 /* found in Tolino Shine 2 HD */ > > #endif -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD

2021-03-10 Thread Lee Jones
ntxec_subdev_pwm, > +ARRAY_SIZE(ntxec_subdev_pwm), > +NULL, 0, NULL); > if (res) > dev_err(ec->dev, "Failed to add subdevices: %d\n", res); >

Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64

2021-03-10 Thread Lee Jones
> drivers/fpga/Kconfig| 2 +- > drivers/mfd/Kconfig | 2 +- If it's okay with everyone else, it'll be okay with me: Acked-by: Lee Jones > drivers/net/ethernet/stmicro/stmmac/Kconfig | 4 ++-- > drivers/reset/Kconfig

Re: [PATCH v3 6/6] mfd: tps68470: Remove tps68470 MFD driver

2021-03-10 Thread Lee Jones
> drivers/mfd/Makefile | 1 - > drivers/mfd/tps68470.c| 97 --- > 5 files changed, 2 insertions(+), 118 deletions(-) > delete mode 100644 drivers/mfd/tps68470.c Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer S

Re: [PATCH 1/2] dt-bindings: leds: backlight: qcom-wled: Add PMI8994 compatible

2021-03-10 Thread Lee Jones
On Sun, 28 Feb 2021, Konrad Dybcio wrote: > Document the newly added PMI8994 compatible. > > Signed-off-by: Konrad Dybcio Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/2] dt-bindings: mfd: lp875xx: add optional reset GPIO

2021-03-10 Thread Lee Jones
+ > Documentation/devicetree/bindings/mfd/ti,lp87565-q1.yaml | 4 > 3 files changed, 12 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3 4/4] MAINTAINERS: Add entry for Intel MAX 10 mfd driver

2021-03-10 Thread Lee Jones
For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3 3/4] mfd: intel-m10-bmc: Add access table configuration to the regmap

2021-03-10 Thread Lee Jones
| 5 - > 2 files changed, 17 insertions(+), 1 deletion(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3 1/4] mfd: intel-m10-bmc: Fix the register access range

2021-03-10 Thread Lee Jones
om Rix > --- > v2: no change. > v3: no change, rebased to 5.12-rc1 > --- > include/linux/mfd/intel-m10-bmc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior

Re: [PATCH v3 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition

2021-03-10 Thread Lee Jones
0BMC_LEGACY_SYS_BASE 0x300400 > +#define M10BMC_LEGACY_BUILD_VER 0x300468 > #define M10BMC_SYS_BASE 0x300800 > #define M10BMC_MEM_END 0x1fff > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static

2021-03-10 Thread Lee Jones
, so this > commit marks it static. > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > Acked-by: Lubomir Rintel This should have been a Reviewed-by. > --- > drivers/mfd/ene-kb3930.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- L

Re: [PATCH] [RESEND] mfd: remove ab3100 driver

2021-03-10 Thread Lee Jones
ivers/mfd/ab3100-core.c > delete mode 100644 drivers/mfd/ab3100-otp.c > delete mode 100644 include/linux/mfd/ab3100.h Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: ab8500: Drop bm disable parameter

2021-03-10 Thread Lee Jones
r v5.12 > merge window. > --- > drivers/mfd/ab8500-core.c | 20 ++-- > 1 file changed, 6 insertions(+), 14 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here

2021-03-10 Thread Lee Jones
On Fri, 12 Feb 2021, Lee Jones wrote: > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > Quoting Lee Jones (2021-01-26 04:45:27) > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/clk/clkdev.c: In function ‘vclkdev_alloc’: >

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-10 Thread Lee Jones
On Tue, 09 Mar 2021, Adam Ward wrote: > Hi Lee, > > Tidy, but I've noticed the logic got inverted along the way: > > > On Tue 09 Mar 2021, Lee Jones wrote: > > On Tue, 09 Mar 2021, Mark Jonas wrote: > > This is my suggestion: > > > > /* If SMBus

Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config"

2021-03-10 Thread Lee Jones
On Wed, 10 Mar 2021, Li, Meng wrote: > > > > -Original Message- > > From: Lee Jones > > Sent: Wednesday, March 10, 2021 2:15 AM > > To: Li, Meng > > Cc: Marc Zyngier ; linux-kernel@vger.kernel.org; > > a...@arndb.de; Hao, Kexin > > Sub

Re: [PATCH v2] mfd: dbx500-prcmu: Use true and false for bool variable

2021-03-10 Thread Lee Jones
off-by: Jiapeng Chong > --- > Changes in v2: > - Make the commit message more clearer. I already fixed and applied this. Please take a look at my reply to v1. > include/linux/mfd/db8500-prcmu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) -- Lee Jones [李琼斯] Senior

Re: [GIT PULL] Immutable branch between MFD and Platform/X86 due for the v5.13 merge window

2021-03-09 Thread Lee Jones
On Tue, 09 Mar 2021, Lee Jones wrote: > On Tue, 09 Mar 2021, Hans de Goede wrote: > > > Hi Lee, > > > > On 3/9/21 7:12 PM, Lee Jones wrote: > > > Enjoy! > > > > > > The following changes since commit > > > fe07bfda2fb9cdef8a4d4008a4

Re: [GIT PULL] Immutable branch between MFD, PWM and RTC due for the v5.13 merge window

2021-03-09 Thread Lee Jones
On Mon, 01 Mar 2021, Lee Jones wrote: > Enjoy! > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/k

Re: [GIT PULL] Immutable branch between MFD and Input due for the v5.13 merge window

2021-03-09 Thread Lee Jones
On Tue, 09 Mar 2021, Lee Jones wrote: > Enjoy! > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/ke

Re: [GIT PULL] Immutable branch between MFD and Platform/X86 due for the v5.13 merge window

2021-03-09 Thread Lee Jones
On Tue, 09 Mar 2021, Hans de Goede wrote: > Hi Lee, > > On 3/9/21 7:12 PM, Lee Jones wrote: > > Enjoy! > > > > The following changes since commit fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8: > > > > Linux 5.12-rc1 (2021-02-28 16:05:19 -0800) > > I

Re: [PATCH v2] mfd: stmpe: Revert "Constify static struct resource"

2021-03-09 Thread Lee Jones
Rewrite commit message. > > V1: > https://lore.kernel.org/lkml/20210302234710.74455-1-rikard.falkeb...@gmail.com/ > > drivers/mfd/stmpe.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead

Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config"

2021-03-09 Thread Lee Jones
On Tue, 09 Mar 2021, Li, Meng wrote: > > > > -Original Message- > > From: Lee Jones > > Sent: Tuesday, March 9, 2021 5:43 PM > > To: Li, Meng > > Cc: Marc Zyngier ; linux-kernel@vger.kernel.org; > > a...@arndb.de; Hao, Kexin > > Sub

Re: [PATCH 4.4 3/3] futex: fix dead code in attach_to_pi_owner()

2021-03-09 Thread Lee Jones
e writes: > > > > This commit takes the remaining functional snippet of: > > > > ac31c7ff8624409 ("futex: Provide distinct return value when owner is > > exiting") > > > > ... and is the correct fix for this issue. > > > > Fixes: 9c3

Re: [PATCH 2/2 V2] MFD: intel_pmt: Add support for DG1

2021-03-09 Thread Lee Jones
On Tue, 09 Mar 2021, David E. Box wrote: > On Tue, 2021-03-09 at 16:45 +0000, Lee Jones wrote: > > On Wed, 24 Feb 2021, David E. Box wrote: > > > > > Adds PMT Telemetry aggregator support for the DG1 graphics PCIe > > > card. The > > > device does n

[GIT PULL] Immutable branch between MFD and Platform/X86 due for the v5.13 merge window

2021-03-09 Thread Lee Jones
drivers/platform/x86/intel_pmt_class.h | 1 + drivers/platform/x86/intel_pmt_telemetry.c | 20 -- 4 files changed, 122 insertions(+), 57 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook

Re: [PATCH 2/2 V2] MFD: intel_pmt: Add support for DG1

2021-03-09 Thread Lee Jones
unsigned long quirks) > { > @@ -147,37 +171,54 @@ static int pmt_pci_probe(struct pci_dev *pdev, const > struct pci_device_id *id) > if (info) > quirks = info->quirks; > > - do { > - struct intel_dvsec_header header; > -

Re: [PATCH v6 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller

2021-03-09 Thread Lee Jones
ad */ > + > +/* GPIO control commands */ > +#define EC_GPIO_INDEX_WRITE 0x10 > +#define EC_GPIO_STATUS_READ 0x11 > +#define EC_GPIO_STATUS_WRITE 0x12 > +#define EC_GPIO_DIR_READ 0x1D > +#define EC_GPIO_DIR_WRITE0x1E > + > +/* One Key Recovery commands */ > +#define EC_ONE_KEY_FLAG 0x9C > + > +/* ASG OEM commands */ > +#define EC_ASG_OEM 0xEA > +#define EC_ASG_OEM_READ 0x00 > +#define EC_ASG_OEM_WRITE 0x01 > +#define EC_OEM_POWER_STATUS_VIN1 0X10 > +#define EC_OEM_POWER_STATUS_VIN2 0X11 > +#define EC_OEM_POWER_STATUS_BAT1 0X12 > +#define EC_OEM_POWER_STATUS_BAT2 0X13 > + > +/* GPIO DEVICE ID */ > +#define EC_DID_ALTGPIO_0 0x10/* 0x10 AltGpio0 User > define gpio */ > +#define EC_DID_ALTGPIO_1 0x11/* 0x11 AltGpio1 User > define gpio */ > +#define EC_DID_ALTGPIO_2 0x12/* 0x12 AltGpio2 User > define gpio */ > +#define EC_DID_ALTGPIO_3 0x13/* 0x13 AltGpio3 User > define gpio */ > +#define EC_DID_ALTGPIO_4 0x14/* 0x14 AltGpio4 User > define gpio */ > +#define EC_DID_ALTGPIO_5 0x15/* 0x15 AltGpio5 User > define gpio */ > +#define EC_DID_ALTGPIO_6 0x16/* 0x16 AltGpio6 User > define gpio */ > +#define EC_DID_ALTGPIO_7 0x17/* 0x17 AltGpio7 User > define gpio */ > + > +/* Lmsensor Chip Register */ > +#define NSLM96163_CHANNEL0x02 > + > +/* NS_LM96163 address 0x98 */ > +#define NSLM96163_ADDR 0x98 > + > +/* LM96163 index(0x00) Local Temperature (Signed MSB) */ > +#define NSLM96163_LOC_TEMP 0x00 > + > +/* HWMON registers */ > +#define INA266_REG_VOLTAGE 0x02/* 1.25mV */ > +#define INA266_REG_POWER0x03/* 25mW */ > +#define INA266_REG_CURRENT 0x04/* 1mA */ > + > +struct ec_hw_pin_table { > + unsigned int vbat[2]; > + unsigned int v5[2]; > + unsigned int v12[2]; > + unsigned int vcore[2]; > + unsigned int vdc[2]; > + unsigned int ec_current[2]; > + unsigned int power[2]; > +}; > + > +struct ec_dynamic_table { > + unsigned char device_id; > + unsigned char hw_pin_num; > +}; > + > +struct ec_smbuso_em0 { > + unsigned char hw_pin_num; > +}; > + > +struct pled_hw_pin_tbl { > + unsigned int pled[6]; > +}; > + > +struct adv_ec_platform_data { > + char *bios_product_name; Where is this used? > + int sub_dev_nb; > + u32 sub_dev_mask; > + struct mutex lock; > + struct device *dev; > + struct class *adv_ec_class; > + > + struct ec_dynamic_table *dym_tbl; > +}; Check whether all of these really need to be in device data i.e. check that they are all used in sub-devices. > +int read_ad_value(struct adv_ec_platform_data *adv_ec_data, unsigned char > hwpin, > + unsigned char multi); > +int read_acpi_value(struct adv_ec_platform_data *adv_ec_data, unsigned char > addr, > + unsigned char *pvalue); > +int write_acpi_value(struct adv_ec_platform_data *adv_ec_data, unsigned char > addr, > + unsigned char value); > +int read_hw_ram(struct adv_ec_platform_data *adv_ec_data, unsigned char addr, > + unsigned char *data); > +int write_hw_ram(struct adv_ec_platform_data *adv_ec_data, unsigned char > addr, > + unsigned char data); > +int write_hwram_command(struct adv_ec_platform_data *adv_ec_data, unsigned > char data); > +int read_gpio_status(struct adv_ec_platform_data *adv_ec_data, unsigned char > PinNumber, > + unsigned char *pvalue); > +int write_gpio_status(struct adv_ec_platform_data *adv_ec_data, unsigned > char PinNumber, > + unsigned char value); > +int read_gpio_dir(struct adv_ec_platform_data *adv_ec_data, unsigned char > PinNumber, > + unsigned char *pvalue); > +int write_gpio_dir(struct adv_ec_platform_data *adv_ec_data, unsigned char > PinNumber, > + unsigned char value); > + > +#endif /* __LINUX_MFD_AHC1EC0_H */ -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: lm3533: Switch to using the new API kobj_to_dev()

2021-03-09 Thread Lee Jones
1 insertion(+), 1 deletion(-) Fixed up the commit message a bit and applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[GIT PULL] Immutable branch between MFD and Input due for the v5.13 merge window

2021-03-09 Thread Lee Jones
include/linux/mfd/atc260x/atc2603c.h create mode 100644 include/linux/mfd/atc260x/atc2609a.h create mode 100644 include/linux/mfd/atc260x/core.h -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config"

2021-03-09 Thread Lee Jones
On Mon, 22 Feb 2021, Li, Meng wrote: > > -Original Message- > > From: Lee Jones > > Sent: Monday, February 22, 2021 5:21 PM > > To: Marc Zyngier > > Cc: Li, Meng ; linux-kernel@vger.kernel.org; > > a...@arndb.de; Hao, Kexin > > Subject: Re: [

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-09 Thread Lee Jones
DA9063_TWOWIRE_TO, DA9063_TWOWIRE_TO); if (ret < 0) { dev_err(da9063->dev, "Failed to set Two-Wire Bus Mode\n"); return -EIO; } } > > > return da9063_device_init(da9063,

Re: [PATCH v3 0/4] Some improvement for Intel MAX 10 MFD drivers

2021-03-08 Thread Lee Jones
On Mon, 08 Mar 2021, Xu Yilun wrote: > On Mon, Mar 08, 2021 at 09:01:24AM +0000, Lee Jones wrote: > > On Mon, 08 Mar 2021, Xu Yilun wrote: > > > > > Hi Lee: > > > > > > Could you please help on review this patchset? They are some > > > improve

Re: [PATCH net-next] mfd: Add Renesas Synchronization Management Unit (SMU) support

2021-03-08 Thread Lee Jones
On Wed, 10 Feb 2021, min.li...@renesas.com wrote: > From: Min Li > > Add support for ClockMatrix(TM) and 82P33xxx families of timing > and synchronization devices. Currently only I2C access is supported > and SPI would be added later on. > > This mfd driver will export 2 devices to be used by

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-03-08 Thread Lee Jones
+++ b/include/linux/mfd/da9063/registers.h > @@ -1037,6 +1037,9 @@ > #define DA9063_NONKEY_PIN_AUTODOWN 0x02 > #define DA9063_NONKEY_PIN_AUTOFLPRT 0x03 > > +/* DA9063_REG_CONFIG_J (addr=0x10F) */ > +#define DA9063_TWOWIRE_TO0x40 > + >

Re: [PATCH 3/3] mfd: lp87565: move LP87565_regulator_id to .c file

2021-03-08 Thread Lee Jones
> 2 files changed, 11 insertions(+), 11 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/3] mfd: lp87565: remove unused define

2021-03-08 Thread Lee Jones
On Fri, 19 Feb 2021, Luca Ceresoli wrote: > This define appears incorrect, but it is completely unused so it can be > removed. > > Signed-off-by: Luca Ceresoli > --- > include/linux/mfd/lp87565.h | 3 --- > 1 file changed, 3 deletions(-) Applied, thanks. -- Lee Jones [

Re: [PATCH 1/3] mfd: lp87565: fix typo in define names

2021-03-08 Thread Lee Jones
nsertions(+), 17 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH -next] mfd: arizona: Make some symbols static

2021-03-08 Thread Lee Jones
Wei Yongjun > --- > drivers/mfd/arizona-spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v8 6/6] mfd: bd9576: Add safety limit/monitoring registers

2021-03-08 Thread Lee Jones
> +#define BD9576_MASK_VOUT1S_OCW 0x3f > +#define BD9576_MASK_VOUT1S_OCP 0x3f Just a quick check, are these meant to be the same value? If so: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李

Re: [PATCH v8 3/6] mfd: bd9576: Add IRQ support

2021-03-08 Thread Lee Jones
#define BD957X_REG_SMRB_ASSERT 0x15 > #define BD957X_REG_PMIC_INTERNAL_STAT0x20 > #define BD957X_REG_INT_THERM_STAT0x23 > @@ -28,6 +77,19 @@ enum { > #define BD957X_REG_INT_MAIN_STAT 0x30 > #define BD957X_REG_INT_MAIN_MASK 0x31 > > +#define UVD_IRQ_VALID_MASK 0x6F > +#define OVD_IRQ_VALID_MASK 0x2F > + > +#define BD957X_MASK_INT_MAIN_THERM BIT(0) > +#define BD957X_MASK_INT_MAIN_OVP BIT(1) > +#define BD957X_MASK_INT_MAIN_SCP BIT(2) > +#define BD957X_MASK_INT_MAIN_OCP BIT(3) > +#define BD957X_MASK_INT_MAIN_OVD BIT(4) > +#define BD957X_MASK_INT_MAIN_UVD BIT(5) > +#define BD957X_MASK_INT_MAIN_UVP BIT(6) > +#define BD957X_MASK_INT_MAIN_SYS BIT(7) > +#define BD957X_MASK_INT_ALL 0xff > + > #define BD957X_REG_WDT_CONF 0x16 > > #define BD957X_REG_POW_TRIGGER1 0x41 -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v8 2/6] mfd: Support ROHM BD9576MUF and BD9573MUF

2021-03-08 Thread Lee Jones
// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * Copyright (C) 2020 ROHM Semiconductors If you get a chance, could you please update these? > + * ROHM BD9576MUF and BD9573MUF PMIC driver > + */ For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: dbx500-prcmu: Use true and false for bool variable

2021-03-08 Thread Lee Jones
needs a ' ' before the '<'. > Signed-off-by: Jiapeng Chong > --- > include/linux/mfd/db8500-prcmu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I fixed the above and applied the patch, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source so

<    1   2   3   4   5   6   7   8   9   10   >