[RESEND 00/53] Rid GPU from W=1 warnings

2021-03-03 Thread Lee Jones
This is a resend. All of these patches have been sent before. The vmwgfx ones were even applied, but were dropped for some reason. Lee Jones (53): drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc drm/nouveau/dispnv50/disp: Remove unused variable 'ret' drm/msm/dp

[RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header

2021-03-03 Thread Lee Jones
Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Signed-off-by: Lee Jones --- arch/arm/mach-at91/pm.c| 19 --- drivers/pinctrl/pinctrl-at91.c | 2 ++ include/soc/at91/pm.h | 16 3 files changed, 26 insertions(+), 11 deletions(-) create mode

[RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location

2021-03-03 Thread Lee Jones
Mackerras Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Michael Ellerman --- arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff

Re: [PATCH rdma-rc 1/2] RDMA/mlx5: Set correct kernel-doc identifier

2021-03-02 Thread Lee Jones
On Tue, 02 Mar 2021, Leon Romanovsky wrote: > On Tue, Mar 02, 2021 at 09:31:09AM +0000, Lee Jones wrote: > > On Tue, 02 Mar 2021, Leon Romanovsky wrote: > > > > > From: Leon Romanovsky > > > > > > The W=1 allmodconfig build produces the following warni

Re: [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group

2021-03-02 Thread Lee Jones
On Mon, 01 Mar 2021, Rikard Falkeborn wrote: > On Mon, Mar 01, 2021 at 09:56:45AM +0000, Lee Jones wrote: > > On Sun, 31 Jan 2021, Rikard Falkeborn wrote: > > > > > The only usage of attr_group is to pass its address to > > > sysfs_create_group() and sysfs

Re: [PATCH rdma-rc 1/2] RDMA/mlx5: Set correct kernel-doc identifier

2021-03-02 Thread Lee Jones
+++ b/drivers/infiniband/hw/mlx5/odp.c > @@ -1082,7 +1082,7 @@ static int pagefault_single_data_segment(struct > mlx5_ib_dev *dev, > return ret ? ret : npages; > } > > -/** > +/* This is not the correct fix. Kernel-doc is asking for the function name. > * Parse a series of data s

Re: [PATCH rdma-rc 2/2] RDMA/uverbs: Fix kernel-doc warning of _uverbs_alloc

2021-03-02 Thread Lee Jones
ckly allocate memory for use with a bundle > * @bundle: The bundle > * @size: Number of bytes to allocate > * @flags: Allocator flags -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[PATCH 1/1] dt-bindings: mfd: ricoh,rn5t618: Trivial: Fix spelling mistake of 'additionally'

2021-03-01 Thread Lee Jones
Signed-off-by: Lee Jones --- Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml b/Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml index d70e85a09c84e

[GIT PULL] Immutable branch between MFD, PWM and RTC due for the v5.13 merge window

2021-03-01 Thread Lee Jones
create mode 100644 include/linux/mfd/ntxec.h -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH RESEND v5 7/8] regulator: mt6359: Add support for MT6359P regulator

2021-03-01 Thread Lee Jones
59-regulator.h | 1 + > 3 files changed, 623 insertions(+), 6 deletions(-) > create mode 100644 include/linux/mfd/mt6359p/registers.h -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH RESEND v5 5/8] mfd: Add support for the MediaTek MT6359 PMIC

2021-03-01 Thread Lee Jones
isters.h > @@ -0,0 +1,529 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2020 MediaTek Inc. This too. > + */ > + > +#ifndef __MFD_MT6359_REGISTERS_H__ > +#define __MFD_MT6359_REGISTERS_H__ [...] > +#endif /* __MFD_MT6359_REGISTERS_H__ */ > diff --g

Re: [PATCH RESEND v2] dt-bindings: mfd: Convert rn5t618 to json-schema

2021-03-01 Thread Lee Jones
| 52 > 2 files changed, 111 insertions(+), 52 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mfd/ricoh,rn5t618.yaml > delete mode 100644 Documentation/devicetree/bindings/mfd/rn5t618.txt Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer

Re: [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group

2021-03-01 Thread Lee Jones
y. > > Done with the help of coccinelle. > > Signed-off-by: Rikard Falkeborn > --- > drivers/mfd/gateworks-gsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) These patches do not seem to be on LKML. Do you know if they were rejected for some reason? -- Lee

Re: futex breakage in 4.9 stable branch

2021-03-01 Thread Lee Jones
ted. > > As for "difficulty", yes, it's rough, but the changes backported were > required, for obvious reasons :( Apologies for the fuss. The back-port become more complex the further back it was taken.. Had I known about the self-tests, I would have ensured those were passing

Re: [PATCH 2/4] mfd: simple-mfd-i2c: Adds Ampere's Altra SMpro support

2021-02-26 Thread Lee Jones
config); > if (IS_ERR(regmap)) > @@ -39,6 +49,7 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c) > > static const struct of_device_id simple_mfd_i2c_of_match[] = { > { .compatible = "kontron,sl28cpld" }, > + { .compatible = "ampere,ac01-smpro" }, > {} > }; > MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match); -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] futex: fix dead code in attach_to_pi_owner()

2021-02-25 Thread Lee Jones
h > > . > > > Sorry, the commit id c158b461306df82 in the patch does not exist in the > linux-stable repository. > The commit ID is from linux-stable-rc. > > I corrected the commit id in a subsequent email, and added a branch label. > https://lore.kernel.org/lkml/20210224100923.51315-1-nixiaom...@huawei.com/ Replied to the follow-up. > Sorry, I forgot to use "--in-reply-to=" when I sent the update patch. > > This issue occurs only in the linux-4.9.y branch v4.9.258 -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 4.9.258] futex: fix dead code in attach_to_pi_owner()

2021-02-25 Thread Lee Jones
+), 3 deletions(-) To clarify, this is not a wholesale back-port from Mainline. It takes the remaining functional snippet of: ac31c7ff8624409 ("futex: Provide distinct return value when owner is exiting") ... and is the correct fix for this issue. Reviewed-by: Lee Jones > diff

Re: [PATCH 4.9.y 1/1] futex: Fix OWNER_DEAD fixup

2021-02-25 Thread Lee Jones
On Thu, 25 Feb 2021, Zhengyejian (Zetta) wrote: > > > On 2021/2/24 19:19, Lee Jones wrote: > > On Tue, 23 Feb 2021, Zheng Yejian wrote: > > > > > From: Peter Zijlstra > > > > > > commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upst

Re: [PATCH 4.9.y 1/1] futex: Fix OWNER_DEAD fixup

2021-02-24 Thread Lee Jones
> } > > newtid = task_pid_vnr(newowner) | FUTEX_WAITERS; > + /* Owner died? */ > + if (!pi_state->owner) > + newtid |= FUTEX_OWNER_DIED; > > if (get_futex_value_locked(, uaddr)) > goto handle_fault; -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v7 0/5] Add initial support for ATC260x PMICs

2021-02-22 Thread Lee Jones
On Mon, 22 Feb 2021, Cristian Ciocaltea wrote: > On Mon, Feb 22, 2021 at 03:30:16PM +0000, Lee Jones wrote: > > On Mon, 22 Feb 2021, Cristian Ciocaltea wrote: > > > > > On Mon, Feb 22, 2021 at 09:02:47AM +, Lee Jones wrote: > > > > On Sun, 2

Re: [PATCH v7 0/5] Add initial support for ATC260x PMICs

2021-02-22 Thread Lee Jones
On Mon, 22 Feb 2021, Cristian Ciocaltea wrote: > On Mon, Feb 22, 2021 at 09:02:47AM +0000, Lee Jones wrote: > > On Sun, 21 Feb 2021, Cristian Ciocaltea wrote: > > > > > Hi Lee, > > > > > > I have just noticed your mfd-next tag for 5.12 doesn't inclu

Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup

2021-02-22 Thread Lee Jones
0180122103947.gd2...@hirez.programming.kicks-ass.net > Signed-off-by: Ingo Molnar > Signed-off-by: Zheng Yejian > --- > kernel/futex.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config"

2021-02-22 Thread Lee Jones
s to spend some time to map out the full life-cycle and propose a (possibly cross-subsystem) solution. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH net-next] mfd: Add Renesas Synchronization Management Unit (SMU) support

2021-02-22 Thread Lee Jones
On Fri, 19 Feb 2021, Min Li wrote: > Hi Lee > > When you have time, can you please take a look at my review below? a) Please don't sent contentless pings (especially in a top post). If you think your patch has been forgotten (it hasn't) submit a [RESEND]. b) Please keep an eye on the

Re: [PATCH v4] mfd: da9063: Support SMBus and I2C mode

2021-02-22 Thread Lee Jones
ing at the CC list, I think you added all > the relevant people, so it seems all good. Wolfram is correct. I'm not planning on taking patches again until -rc1 is out. Patch looks okay at first glance though. A proper review will be provided in due course. -- Lee Jones [李琼斯] Senior Technical L

Re: [PATCH v7 0/5] Add initial support for ATC260x PMICs

2021-02-22 Thread Lee Jones
sfers in Owl I2C driver (for power controller), merged in > > v5.11: > > > > https://lore.kernel.org/lkml/cover.1602190168.git.cristian.ciocal...@gmail.com/ -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 01/19] dt-bindings: aspeed-lpc: Remove LPC partitioning

2021-02-22 Thread Lee Jones
in the DTS node examples > are also fixed to adapt to the LPC DTS change. > > Signed-off-by: Chia-Wei Wang > Reviewed-by: Andrew Jeffery > Acked-by: Rob Herring > --- > .../devicetree/bindings/mfd/aspeed-lpc.txt| 100 +- > 1 file changed, 25 insertions(+), 75

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-18 Thread Lee Jones
On Wed, 17 Feb 2021, Jakub Kicinski wrote: > On Tue, 16 Feb 2021 08:20:46 +0000 Lee Jones wrote: > > On Mon, 15 Feb 2021, Jakub Kicinski wrote: > > > On Mon, 15 Feb 2021 08:49:52 + Lee Jones wrote: > > > > Yes, please share. > > > > > > ht

[GIT PULL] Backlight for v5.12

2021-02-16 Thread Lee Jones
include/linux/spi/lms283gf05.h -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[GIT PULL] MFD for v5.12

2021-02-16 Thread Lee Jones
| 2 + include/linux/sunxi-rsb.h | 2 +- 37 files changed, 847 insertions(+), 288 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb930.yaml create mode 100644 drivers/mfd/acer-ec-a500.c -- Lee Jones [李琼斯] Senior Technical Lead - Develope

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-16 Thread Lee Jones
On Mon, 15 Feb 2021, Jakub Kicinski wrote: > On Mon, 15 Feb 2021 08:49:52 +0000 Lee Jones wrote: > > > Jakub can explain how he added these checks. > > > > Yes, please share. > > https://github.com/kuba-moo/nipa Thanks for this. Oh, I see. So you conduct te

Re: [PATCH v4] MAINTAINERS: move Milo Kim to credits

2021-02-15 Thread Lee Jones
On Mon, 15 Feb 2021, Emil Velikov wrote: > Greetings everyone, > > On Mon, 15 Feb 2021 at 08:52, Lee Jones wrote: > > > > On Fri, 12 Feb 2021, Krzysztof Kozlowski wrote: > > > > > Milo Kim's email in TI bounces with permanent error (550: Invalid > >

Re: [PATCH v4] MAINTAINERS: move Milo Kim to credits

2021-02-15 Thread Lee Jones
t; - TI LP8727 charger driver, > - TI LP8788 MFD (ADC, LEDs, charger and regulator) drivers. > > Signed-off-by: Krzysztof Kozlowski > Cc: Mark Brown > Cc: Jonathan Cameron > Cc: Jingoo Han > Cc: Lee Jones > Cc: Pavel Machek > Cc: Thierry Reding > Cc: Sebastian Reich

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-15 Thread Lee Jones
see any bot > > putting test results there. How is that done? > > > > https://patchwork.kernel.org/project/linux-clk/list/ > > Compare this with for example: > > https://patchwork.kernel.org/project/netdevbpf/patch/20210213175257.28642-1-ap420...@gmail.com/ Oh, that's ni

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-12 Thread Lee Jones
On Fri, 12 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-02-12 13:26:30) > > On Fri, 12 Feb 2021, Lee Jones wrote: > > > > > The alternative is to not worry about it and review the slow drip of > > > fixes that will occur as a result. The issues I ju

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-12 Thread Lee Jones
On Fri, 12 Feb 2021, Lee Jones wrote: > On Fri, 12 Feb 2021, Stephen Boyd wrote: > > > Quoting Lee Jones (2021-02-12 01:20:16) > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > > > Quoting Lee Jones (2021-02-11 13:10:54) > &g

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-12 Thread Lee Jones
On Fri, 12 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-02-12 01:20:16) > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > Quoting Lee Jones (2021-02-11 13:10:54) > > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > >

Re: [PATCH] video: use getter/setter functions

2021-02-12 Thread Lee Jones
4.c |2 > +- > drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c |2 > +- > drivers/video/fbdev/xilinxfb.c |2 > +- > 10 files changed, 16 insertions(+), 16 deletions(-) I fixed-up th

Re: [PATCH RESEND] regulator: bd718x7, bd71828, Fix dvs voltage levels

2021-02-12 Thread Lee Jones
c | 9 ++--- > include/linux/mfd/rohm-generic.h | 14 ++ > 2 files changed, 12 insertions(+), 11 deletions(-) Happy for Mark to take this in: Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v3 3/7] mfd: max8997: Add of_compatible to extcon and charger mfd_cell

2021-02-12 Thread Lee Jones
On Thu, 11 Feb 2021, Timon Baetz wrote: > On Tue, 22 Dec 2020 09:55:22 +0000, Lee Jones wrote: > > On Tue, 22 Dec 2020, Timon Baetz wrote: > > > > > Add of_compatible ("maxim,max8997-muic") to the mfd_cell to have a > > > of_node set in the extcon dr

Re: [PATCH 08/21] clk: clkdev: Ignore suggestion to use gnu_printf() as it's not appropriate here

2021-02-12 Thread Lee Jones
On Thu, 11 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-01-26 04:45:27) > > Fixes the following W=1 kernel build warning(s): > > > > drivers/clk/clkdev.c: In function ‘vclkdev_alloc’: > > drivers/clk/clkdev.c:173:3: warning: function ‘vclkdev_alloc

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-12 Thread Lee Jones
On Thu, 11 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-02-11 13:10:54) > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > Quoting Lee Jones (2021-01-26 04:45:19) > > > > This set is part of a larger effort attempting to clean-up W=1 > &

Re: [PATCH RESEND] regulator: bd718x7, bd71828, Fix dvs voltage levels

2021-02-12 Thread Lee Jones
part of: [PATCH v2 00/17] Support ROHM BD71815 PMIC ... which has just been reviewed and is awaiting rework? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-11 Thread Lee Jones
On Thu, 11 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-01-26 04:45:19) > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > This is th

Re: [RESEND PATCH v3] MAINTAINERS: add Dan Murphy as TI LP8xxx drivers maintainer

2021-02-11 Thread Lee Jones
opose to mark entries as orphaned - without any maintainer. > Other option is to remove them entirely so they will be covered by > regular power supply entry. > > Any preferences here? Counter-proposal: Since they are driver-level entries, just remove them altogether. They are not o

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-11 Thread Lee Jones
On Wed, 10 Feb 2021, Mark Brown wrote: > On Tue, Feb 09, 2021 at 03:45:11PM +0000, Lee Jones wrote: > > On Tue, 09 Feb 2021, Hans de Goede wrote: > > > > The alternative is Mark doing a PR from ASoC to MFD to get 5/5 from the > > > previous set > > > in

Re: linux-next: build warning after merge of the rdma tree

2021-02-10 Thread Lee Jones
: tb-some-topic-branch arm64 defconfig gcc-9 https://builds.tuxbuild.com/1oIa2AR63BljDuvKHKet8Qqga7L/ Pass (1 errors - 3 warnings) : v4.9.257 https://builds.tuxbuild.com/1oIa4biSryBYrj4JoZlRGpgx8AF/ Fail (2 errors - 8 warnings) : tb-some-topic-branch -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] video: use getter/setter functions

2021-02-10 Thread Lee Jones
On Wed, 10 Feb 2021, Daniel Vetter wrote: > On Wed, Feb 10, 2021 at 08:23:41AM +0000, Lee Jones wrote: > > On Tue, 09 Feb 2021, Julia Lawall wrote: > > > > > Use getter and setter functions, for platform_device structures and a > > > spi_device structure. > &g

Re: [PATCH] video: use getter/setter functions

2021-02-10 Thread Lee Jones
t; mutex_destroy(>lock); > cancel_delayed_work_sync(>ovp_work); For my own reference (apply this as-is to your sign-off block): Acked-for-Backlight-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-09 Thread Lee Jones
On Tue, 09 Feb 2021, Hans de Goede wrote: > Hi, > > On 2/9/21 4:45 PM, Lee Jones wrote: > > On Tue, 09 Feb 2021, Hans de Goede wrote: > > > >> Hi, > >> > >> On 2/9/21 3:14 PM, Lee Jones wrote: > >>> On Mon, 08 Feb 2021, Hans de Goede

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-09 Thread Lee Jones
On Tue, 09 Feb 2021, Hans de Goede wrote: > Hi, > > On 2/9/21 3:14 PM, Lee Jones wrote: > > On Mon, 08 Feb 2021, Hans de Goede wrote: > > > >> Hi Mark, Lee, > >> > >> On 2/4/21 12:24 PM, Hans de Goede wrote: > >>> Hi all, > >

Re: [PATCH v7 3/6] mfd: bd9576: Add IRQ support

2021-02-09 Thread Lee Jones
BD957X_MASK_INT_MAIN_SYS BIT(7) > +#define BD957X_MASK_INT_ALL 0xff > + > +#define BD957X_REG_WDT_CONF 0x16 > + > +#define BD957X_REG_POW_TRIGGER1 0x41 > +#define BD957X_REG_POW_TRIGGER2 0x42 > +#define BD957X_REG_POW_TRIGGER3 0x43 > +#define BD957X_REG_POW_TRIGGER4 0x44 > +#define BD957X_REG_POW_TRIGGERL1 0x45 > +#define BD957X_REG_POW_TRIGGERS1 0x46 > + > +#define BD957X_REGULATOR_EN_MASK 0xff > +#define BD957X_REGULATOR_DIS_VAL 0xff > + > +#define BD957X_VSEL_REG_MASK 0xff > + > +#define BD957X_MASK_VOUT1_TUNE 0x87 > +#define BD957X_MASK_VOUT2_TUNE 0x87 > +#define BD957X_MASK_VOUT3_TUNE 0x1f > +#define BD957X_MASK_VOUT4_TUNE 0x1f > +#define BD957X_MASK_VOUTL1_TUNE 0x87 > + > +#define BD957X_REG_VOUT1_TUNE0x50 > +#define BD957X_REG_VOUT2_TUNE0x53 > +#define BD957X_REG_VOUT3_TUNE0x56 > +#define BD957X_REG_VOUT4_TUNE0x59 > +#define BD957X_REG_VOUTL1_TUNE 0x5c > + > +#define BD957X_MAX_REGISTER 0x61 Line all these up please. > #endif -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v7 2/6] mfd: Support ROHM BD9576MUF and BD9573MUF

2021-02-09 Thread Lee Jones
7X_MASK_VOUT4_TUNE 0x1f > +#define BD957X_MASK_VOUTL1_TUNE 0x87 > + > +#define BD957X_REG_VOUT1_TUNE0x50 > +#define BD957X_REG_VOUT2_TUNE0x53 > +#define BD957X_REG_VOUT3_TUNE0x56 > +#define BD957X_REG_VOUT4_TUNE0x59 > +#define BD957X_REG_VOUTL1_TUNE 0x5c > + > +#define BD957X_MAX_REGISTER 0x61 Nit: Can you tab these out for improved readability please? > +#endif > diff --git a/include/linux/mfd/rohm-generic.h > b/include/linux/mfd/rohm-generic.h > index 4283b5b33e04..58b4f1a0f4af 100644 > --- a/include/linux/mfd/rohm-generic.h > +++ b/include/linux/mfd/rohm-generic.h > @@ -12,6 +12,8 @@ enum rohm_chip_type { > ROHM_CHIP_TYPE_BD71847, > ROHM_CHIP_TYPE_BD70528, > ROHM_CHIP_TYPE_BD71828, > + ROHM_CHIP_TYPE_BD9576, > + ROHM_CHIP_TYPE_BD9573, > ROHM_CHIP_TYPE_AMOUNT > }; > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-09 Thread Lee Jones
. This was developed and tested on > > a Lenovo Yoga Tablet 1051L with a WM5102 codec. > > > > This was also tested by Charles Keepax, one of the Cirrus Codec folks. > > > > This depends on the previously posted "[PATCH v4 0/5] MFD/ASoC: Add > > support f

Re: [PATCH v9 0/7] Netronix embedded controller driver for Kobo and Tolino ebook readers

2021-02-09 Thread Lee Jones
> > - Added Thierry Reding's ACK to the PWM patch > > > what is the fate of this one, looks like it got all acks from > maintainers. I'll apply it when -rc1 is out. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

[GIT PULL] Immutable branch from MFD due for the v5.12 merge window

2021-02-08 Thread Lee Jones
fd/arizona-core.c | 11 drivers/mfd/arizona-i2c.c | 11 ++-- drivers/mfd/arizona-spi.c | 138 +++-- drivers/mfd/arizona.h | 9 --- 4 files changed, 141 insertions(+), 28 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Develope

Re: [PATCH v4 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-02-08 Thread Lee Jones
On Fri, 05 Feb 2021, Mark Brown wrote: > On Fri, Feb 05, 2021 at 08:34:16AM +0000, Lee Jones wrote: > > On Thu, 04 Feb 2021, Mark Brown wrote: > > > > > On Thu, Feb 04, 2021 at 03:40:58PM +, Lee Jones wrote: > > > > On Thu, 04 Feb 2021, Mark Brown wrote:

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-05 Thread Lee Jones
On Fri, 05 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-02-03 00:31:55) > > On Tue, 26 Jan 2021, Lee Jones wrote: > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > kernel builds, which are currently overwhelmingly riddled

Re: [PATCH v4 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-02-05 Thread Lee Jones
On Thu, 04 Feb 2021, Mark Brown wrote: > On Thu, Feb 04, 2021 at 03:40:58PM +0000, Lee Jones wrote: > > On Thu, 04 Feb 2021, Mark Brown wrote: > > > On Thu, Feb 04, 2021 at 03:04:56PM +, Lee Jones wrote: > > > > > This set has all the Acks we

Re: [PATCH v4 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

2021-02-04 Thread Lee Jones
ommon/soc-acpi-intel-byt-match.c | 16 + > 4 files changed, 495 insertions(+) > create mode 100644 sound/soc/intel/boards/bytcr_wm5102.c Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

2021-02-04 Thread Lee Jones
On Thu, 04 Feb 2021, Alessandrelli, Daniele wrote: > On Thu, 2021-02-04 at 11:09 +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/crypto/keembay/ocs-hcu.c:107: warning: expecting prototype for > > struct ocs_hcu_dma_lis

Re: [PATCH v4 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-02-04 Thread Lee Jones
On Thu, 04 Feb 2021, Mark Brown wrote: > On Thu, Feb 04, 2021 at 01:56:16PM +0000, Lee Jones wrote: > > > > Reviewed-by: Andy Shevchenko > > > Acked-by: Pierre-Louis Bossart > > > Signed-off-by: Hans de Goede > > > Applied, thanks. > > Whil

Re: [PATCH v4 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-02-04 Thread Lee Jones
On Thu, 04 Feb 2021, Mark Brown wrote: > On Thu, Feb 04, 2021 at 03:04:56PM +0000, Lee Jones wrote: > > On Thu, 04 Feb 2021, Mark Brown wrote: > > > On Thu, Feb 04, 2021 at 01:56:16PM +, Lee Jones wrote: > > > > > > Reviewed-by: Andy Shevchenko >

Re: [PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-02-04 Thread Lee Jones
On Thu, 04 Feb 2021, Mark Brown wrote: > On Thu, Feb 04, 2021 at 01:46:06PM +0000, Lee Jones wrote: > > On Thu, 04 Feb 2021, Mark Brown wrote: > > > > The usual pattern here is that the MFD patches get merged and then I > > > pull a shared branch in for an

Re: [PATCH v4 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr()

2021-02-04 Thread Lee Jones
eviewed-by: Andy Shevchenko > Acked-by: Pierre-Louis Bossart > Signed-off-by: Hans de Goede > --- > sound/soc/intel/common/soc-intel-quirks.h | 25 +++ > 1 file changed, 25 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Serv

Re: [PATCH v4 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1")

2021-02-04 Thread Lee Jones
E_SOFTDEP("pre: wm8994_regulator") > in the wm8994 code, which has a similar init sequence. > > Reviewed-by: Andy Shevchenko > Acked-by: Charles Keepax > Signed-off-by: Hans de Goede > --- > drivers/mfd/arizona-i2c.c | 1 + > drivers/mfd/arizona-spi.c | 1 + > 2

Re: [PATCH v4 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI

2021-02-04 Thread Lee Jones
en the ACPI "CLKE" call fails > - Drop addition of acpi_device_get_match_data() call, as the code was > moved over to use the generic device_get_match_data() helper in a > (new in v2) preparation patch > --- > drivers/mfd/arizona-spi.c | 127 +++

Re: [PATCH v4 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data()

2021-02-04 Thread Lee Jones
; --- > Changes in v2: > - New patch in v2 of this patchset > --- > drivers/mfd/arizona-core.c | 11 --- > drivers/mfd/arizona-i2c.c | 10 ++ > drivers/mfd/arizona-spi.c | 10 ++ > drivers/mfd/arizona.h | 9 - > 4 files changed, 12 in

Re: [PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-02-04 Thread Lee Jones
On Thu, 04 Feb 2021, Mark Brown wrote: > On Thu, Feb 04, 2021 at 12:07:49PM +0100, Hans de Goede wrote: > > On 2/4/21 11:57 AM, Lee Jones wrote: > > > On Thu, 04 Feb 2021, Hans de Goede wrote: > > > >> series are both ready for merging. All patches have Review

Re: [PATCH v4 resend 01/13] mfd: arizona: Drop arizona-extcon cells

2021-02-04 Thread Lee Jones
by: Charles Keepax > Tested-by: Charles Keepax > Signed-off-by: Hans de Goede > --- > drivers/mfd/arizona-core.c | 20 > 1 file changed, 20 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jo

[PATCH 12/20] crypto: atmel-ecc: Struct headers need to start with keyword 'struct'

2021-02-04 Thread Lee Jones
linux-cry...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Lee Jones --- drivers/crypto/atmel-ecc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 9bd8e5167be34..66a31e5739f4c 100644 --- a/driv

[PATCH 13/20] crypto: bcm: cipher: Provide description for 'req' and fix formatting issues

2021-02-04 Thread Lee Jones
: Rob Rice Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/cipher.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c index 851b149f71701..053315e260c22 100644 --- a/drivers/crypto/bc

[PATCH 17/20] crypto: nx: nx-aes-cbc: Headers comments should not be kernel-doc

2021-02-04 Thread Lee Jones
a Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx-aes-

Re: [PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-04 Thread Lee Jones
On Thu, 04 Feb 2021, Hans de Goede wrote: > Hi, > > On 2/4/21 12:05 PM, Lee Jones wrote: > > On Sat, 23 Jan 2021, Hans de Goede wrote: > > > >> Hi all, > >> > >> Here is v4 of my series to rework the arizona codec jack-detect support > >>

[PATCH 20/20] crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers

2021-02-04 Thread Lee Jones
'irq' not described in 'nps_core_int_isr' drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member 'data' not described in 'nps_core_int_isr' Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/cry

[PATCH 15/20] crypto: caam: caamalg_qi2: Supply a couple of 'fallback' related descriptions

2021-02-04 Thread Lee Jones
: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/caam/caamalg_qi2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/crypto/caam/caamalg_qi2.c b/drivers/crypt

[PATCH 19/20] crypto: nx: Demote header comment and add description for 'nbytes'

2021-02-04 Thread Lee Jones
Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nx/nx.c b/dr

[PATCH 14/20] crypto: caam: caampkc: Provide the name of the function

2021-02-04 Thread Lee Jones
quot; Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/caam/caampkc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/caam/caampkc.c b/drivers/crypto/caam/caampkc.c index dd5f101e43f83..e313233ec6de7 100644 --- a/drivers/crypto/

[PATCH 16/20] crypto: vmx: Source headers are not good kernel-doc candidates

2021-02-04 Thread Lee Jones
lerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Henrique Cerri Cc: linux-cry...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 10/20] crypto: chelsio: chcr_algo: Fix a couple of kernel-doc issues caused by doc-rot

2021-02-04 Thread Lee Jones
: Ayush Sawal Cc: Vinay Kumar Yadav Cc: Rohit Maheshwari Cc: Herbert Xu Cc: "David S. Miller" Cc: Manoj Malviya Cc: Atul Gupta Cc: Jitendra Lulla Cc: M R Gowda Cc: Harsh Jain Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/chelsio/chcr_algo.c | 8 +

[PATCH 11/20] crypto: ux500: cryp_core: Fix formatting issue and add description for 'session_id'

2021-02-04 Thread Lee Jones
linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/cryp/cryp_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ux500/cryp/cryp_core.c b/drivers/crypto/ux500/cryp/cryp_core.c index c3adeb2e58232..25ce56d05084e 100644 --- a/drivers/crypto/

[PATCH 18/20] crypto: nx: nx_debugfs: Header comments should not be kernel-doc

2021-02-04 Thread Lee Jones
() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org Sign

[PATCH 09/20] crypto: ux500: cryp_irq: File headers are not good kernel-doc candidates

2021-02-04 Thread Lee Jones
linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/cryp/cryp_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/ux500/cryp/cryp_irq.c b/drivers/crypto/ux500/cryp/cryp_irq.c index 7ebde69e8c76b..6d2f07bec98a7 100644 --- a/drivers/crypto/

[PATCH 08/20] crypto: ux500: cryp: Demote some conformant non-kernel headers fix another

2021-02-04 Thread Lee Jones
: Herbert Xu Cc: "David S. Miller" Cc: "Gustavo A. R. Silva" Cc: Shujuan Chen Cc: Jonas Linde Cc: Niklas Hernaeus Cc: Joakim Bech Cc: Berne Hebark Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/ux500/cryp/cryp.c | 5 +++-- 1 file changed

[PATCH 07/20] crypto: bcm: spu2: Fix a whole host of kernel-doc misdemeanours

2021-02-04 Thread Lee Jones
: "David S. Miller" Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/spu2.c | 43 ++- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/crypto/bcm/spu2.c b/drivers/crypto/bcm/spu2.c index 2db

[PATCH 06/20] crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs

2021-02-04 Thread Lee Jones
was for ocs_hcu_hash_finup() instead Cc: Daniele Alessandrelli Cc: Declan Murphy Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/keembay/ocs-hcu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH 05/20] crypto: bcm: spu: Fix formatting and misspelling issues

2021-02-04 Thread Lee Jones
' not described in 'spum_cipher_req_finish' drivers/crypto/bcm/spu.c:927: warning: Excess function parameter 'isInbound' description in 'spum_cipher_req_finish' Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/

[PATCH 03/20] crypto: chelsio: chcr_core: File headers are not good candidates for kernel-doc

2021-02-04 Thread Lee Jones
lla Cc: M R Gowda Cc: Harsh Jain Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/chelsio/chcr_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c index f91f9d762a45e..f03

[PATCH 04/20] crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and remove others

2021-02-04 Thread Lee Jones
for hash_algs_unregister_all(). Prototype was for ahash_algs_unregister_all() instead Cc: Herbert Xu Cc: "David S. Miller" Cc: Shujuan Chen Cc: Joakim Bech Cc: Berne Hebark Cc: Niklas Hernaeus Cc: Andreas Westin Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/cr

[PATCH 02/20] crypto: bcm: util: Repair a couple of documentation formatting issues

2021-02-04 Thread Lee Jones
Cc: "David S. Miller" Cc: Takashi Iwai Cc: linux-cry...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/bcm/util.c b/drivers/crypto/bcm/util.c index c4669a96eaecf..d5d9cabea5

[PATCH 01/20] crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param

2021-02-04 Thread Lee Jones
Signed-off-by: Lee Jones --- drivers/crypto/hisilicon/sec/sec_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/hisilicon/sec/sec_drv.c b/drivers/crypto/hisilicon/sec/sec_drv.c index 91ee2bb575df2..3c26871db12f3 100644 --- a/drivers/crypto/hisilicon/sec/sec_drv.c +++ b/driv

[PATCH 00/20] Rid W=1 warnings in Crypto

2021-02-04 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is set 1 of 2 sets required to fully clean Crypto. Lee Jones (20): crypto: hisilicon: sec_drv: Supply missing description

Re: [PATCH v4 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-04 Thread Lee Jones
| 44 ++ > sound/soc/codecs/wm5102.c | 12 +- > sound/soc/codecs/wm5110.c | 12 +- > sound/soc/codecs/wm8997.c | 14 +- > sound/soc/codecs/wm8998.c | 9 + > sound/soc/intel/boards/bytcr_wm5102.c

Re: [PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-02-04 Thread Lee Jones
, that's fine. > Mark and extcon-maintainers (for the follow-up series) may we have your ack > for merging these through the MFD tree ? Ah, you noticed that too! -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH RESEND] mfd: wm831x-auxadc: Prevent use after free in wm831x_auxadc_read_irq()

2021-02-04 Thread Lee Jones
tions(-) Patchwork still can't find this. I've applied it manually, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v6 2/6] mfd: ahc1ec0: Add Advantech EC include file used by dt-bindings

2021-02-04 Thread Lee Jones
hanged, 25 insertions(+) > create mode 100644 include/dt-bindings/mfd/ahc1ec0-dt.h For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Li

Re: [PATCH 2/6] mfd: Initial commit of sy7636a

2021-02-04 Thread Lee Jones
ree Software Foundation version 2. > + * > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any > + * kind, whether express or implied; without even the implied warranty > + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ Same issues as mentioned above. > +#ifndef __LINUX_MFD_SY7636A_H > +#define __LINUX_MFD_SY7636A_H Just MFD is fine. > +#include > +#include > +#include > +#include Alphabetical. > +#define SY7636A_REG_OPERATION_MODE_CRL 0x00 > +#define SY7636A_OPERATION_MODE_CRL_VCOMCTL (1 << 6) > +#define SY7636A_OPERATION_MODE_CRL_ONOFF (1 << 7) > +#define SY7636A_REG_VCOM_ADJUST_CTRL_L 0x01 > +#define SY7636A_REG_VCOM_ADJUST_CTRL_H 0x02 > +#define SY7636A_REG_VCOM_ADJUST_CTRL_MASK 0x01ff > +#define SY7636A_REG_VLDO_VOLTAGE_ADJULST_CTRL 0x03 > +#define SY7636A_REG_POWER_ON_DELAY_TIME 0x06 > +#define SY7636A_REG_FAULT_FLAG 0x07 > +#define SY7636A_FAULT_FLAG_PG (1 << 0) > +#define SY7636A_REG_TERMISTOR_READOUT 0x08 Tab out the values please. Use BIT() > +#define SY7636A_REG_MAX 0x08 > + > +struct sy7636a { > + struct device *dev; > + struct regmap *regmap; > + unsigned int vcom; Where is this used? > + struct gpio_desc *pgood_gpio; Where is this used? > + struct mutex reglock; Where is this used? > +}; > + > +int get_vcom_voltage_mv(struct regmap *regmap); > +int set_vcom_voltage_mv(struct regmap *regmap, unsigned int vcom); What calls these? > +#endif /* __LINUX_MFD_SY7636A_H */ -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 12/21] clk: sunxi: clk-sun6i-ar100: Demote non-conformant kernel-doc header

2021-02-03 Thread Lee Jones
On Wed, 03 Feb 2021, Maxime Ripard wrote: > On Tue, Jan 26, 2021 at 04:54:59PM +0000, Lee Jones wrote: > > On Tue, 26 Jan 2021, Maxime Ripard wrote: > > > > > On Tue, Jan 26, 2021 at 12:45:31PM +, Lee Jones wrote: > > > > Fixes the

Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock

2021-02-03 Thread Lee Jones
On Tue, 26 Jan 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This is the last set. Clock is clean after this. Out of interest, what n

Re: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash

2021-02-02 Thread Lee Jones
LEDDIM, pdata->ramp_time); A tab should be 8 chars in Linux. > /* >* Should be different from bl_props.brightness, so we do not exit -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

<    3   4   5   6   7   8   9   10   11   12   >