Re: [PATCH v9 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-11-03 Thread Leon Luo
Hi Vishal, In probe(), it calls imx274_load_default(imx274), which has I2C register read/write to the IMX274. If it fails, it will exit probe(). So it works as a sensor detection function as you suggested. Regards, Leon Luo 1130 Cadillac CT Milpitas, CA 95035 Phone: (510)371-1169 Fax: (408) 217

Re: [PATCH v9 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-11-03 Thread Leon Luo
Hi Vishal, In probe(), it calls imx274_load_default(imx274), which has I2C register read/write to the IMX274. If it fails, it will exit probe(). So it works as a sensor detection function as you suggested. Regards, Leon Luo 1130 Cadillac CT Milpitas, CA 95035 Phone: (510)371-1169 Fax: (408) 217

[PATCH v9 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-26 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Acked-by: Sakari Ailus <sakari.ai...@iki.fi> Acked-by: Chris Kohn <ck...@xilinx.com> --- v9: - remove v4l2_async_unregister_subdev from probe err

[PATCH v9 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-26 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo Tested-by: Sören Brinkmann Acked-by: Sakari Ailus Acked-by: Chris Kohn --- v9: - remove v4l2_async_unregister_subdev from probe error v8: - check division by zero error v7: - use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to have clean

[PATCH v9 1/2] media:imx274 device tree binding file

2017-10-26 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Acked-by: Rob Herring <r...@kernel.org> --- v9: - add an entry in MAINTAINERS v8: - no changes v7: - no changes v6

[PATCH v9 1/2] media:imx274 device tree binding file

2017-10-26 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann Acked-by: Rob Herring --- v9: - add an entry in MAINTAINERS v8: - no changes v7: - no changes v6: - no changes v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove

[PATCH v8 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-04 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Acked-by: Sakari Ailus <sakari.ai...@iki.fi> --- v8: - check division by zero error v7: - use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to have

[PATCH v8 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-04 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo Tested-by: Sören Brinkmann Acked-by: Sakari Ailus --- v8: - check division by zero error v7: - use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to have clean mutex_lock/mutex_unlock in imx274_s_stream() - define imx274_tp_regs[] as static

[PATCH v8 1/2] media:imx274 device tree binding file

2017-10-04 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Acked-by: Rob Herring <r...@kernel.org> --- v8: - no changes v7: - no changes v6: - no changes v5: - add 'p

[PATCH v8 1/2] media:imx274 device tree binding file

2017-10-04 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann Acked-by: Rob Herring --- v8: - no changes v7: - no changes v6: - no changes v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references

[PATCH v7 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-02 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Acked-by: Sakari Ailus <sakari.ai...@iki.fi> --- v7: - use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to have clean mutex_lock/mutex_unlock

[PATCH v7 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-10-02 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo Tested-by: Sören Brinkmann Acked-by: Sakari Ailus --- v7: - use __v4l2_ctrl_s_ctrl instead of v4l2_ctrl_s_ctrl to have clean mutex_lock/mutex_unlock in imx274_s_stream() - define imx274_tp_regs[] as static, move the test pattern reg out

[PATCH v7 1/2] media:imx274 device tree binding file

2017-10-02 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Acked-by: Rob Herring <r...@kernel.org> --- v7: - no changes v6: - no changes v5: - add 'port' and 'endpoi

[PATCH v7 1/2] media:imx274 device tree binding file

2017-10-02 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann Acked-by: Rob Herring --- v7: - no changes v6: - no changes v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references - document 'reg

[PATCH v6 1/2] media:imx274 device tree binding file

2017-09-24 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> --- v6: - no changes v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references - document 'reg' property v2: - no c

[PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-24 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> --- v6: - remove media/v4l2-image-sizes.h from include header - make the header file alphabetical order - remove fmt->pad check in imx274_get_fmt,

[PATCH v6 1/2] media:imx274 device tree binding file

2017-09-24 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo --- v6: - no changes v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindings/media/i2c

[PATCH v6 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-24 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo Tested-by: Sören Brinkmann --- v6: - remove media/v4l2-image-sizes.h from include header - make the header file alphabetical order - remove fmt->pad check in imx274_get_fmt, the V4L2 subdev framework does it already - change 'struct reg_8 *r

[PATCH v5 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-15 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> --- v5: - no changes v4: - use 32-bit data type to avoid __divdi3 compile error for i386 - clean up OR together error codes v3: - clean up header files

[PATCH v5 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-15 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo Tested-by: Sören Brinkmann --- v5: - no changes v4: - use 32-bit data type to avoid __divdi3 compile error for i386 - clean up OR together error codes v3: - clean up header files - use struct directly instead of alias #define - use

[PATCH v5 1/2] media:imx274 device tree binding file

2017-09-15 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> --- v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bi

[PATCH v5 1/2] media:imx274 device tree binding file

2017-09-15 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo --- v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindings/media/i2c/imx274.txt

[PATCH v4 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-01 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> --- v4: - use 32-bit data type to avoid __divdi3 compile error for i386 - clean up OR together error codes v3: - clean up header files - use struct dire

[PATCH v4 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-01 Thread Leon Luo
pattern: 12 test patterns Signed-off-by: Leon Luo Tested-by: Sören Brinkmann --- v4: - use 32-bit data type to avoid __divdi3 compile error for i386 - clean up OR together error codes v3: - clean up header files - use struct directly instead of alias #define - use v4l2_ctrl_s_ctrl instead

[PATCH v4 1/2] media:imx274 device tree binding file

2017-09-01 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> --- v4: - no changes v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindings/media/i2c/imx274.txt

[PATCH v4 1/2] media:imx274 device tree binding file

2017-09-01 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo --- v4: - no changes v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file changed, 32

[PATCH v3 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-30 Thread Leon Luo
Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> --- v3: - clean up header files - use struct directly instead of alias #define - use v4l2_ctrl_s_ctrl instead of v4l2_s_ctrl - revise debug output - move static helpers closer t

[PATCH v3 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-30 Thread Leon Luo
Signed-off-by: Leon Luo Tested-by: Sören Brinkmann --- v3: - clean up header files - use struct directly instead of alias #define - use v4l2_ctrl_s_ctrl instead of v4l2_s_ctrl - revise debug output - move static helpers closer to their call site - don't OR toegether error codes - use closest

[PATCH v3 1/2] media:imx274 device tree binding file

2017-08-30 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> --- v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindin

[PATCH v3 1/2] media:imx274 device tree binding file

2017-08-30 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file

[PATCH v3 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-30 Thread Leon Luo
Signed-off-by: Leon Luo <le...@leopardimaging.com> Tested-by: Sören Brinkmann <soren.brinkm...@xilinx.com> --- v3: - clean up header files - use struct directly instead of alias #define - use v4l2_ctrl_s_ctrl instead of v4l2_s_ctrl - revise debug output - move static helpers closer t

[PATCH v3 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-08-30 Thread Leon Luo
Signed-off-by: Leon Luo Tested-by: Sören Brinkmann --- v3: - clean up header files - use struct directly instead of alias #define - use v4l2_ctrl_s_ctrl instead of v4l2_s_ctrl - revise debug output - move static helpers closer to their call site - don't OR toegether error codes - use closest

[PATCH v3 1/2] media:imx274 device tree binding file

2017-08-30 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo <le...@leopardimaging.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> --- v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindin

[PATCH v3 1/2] media:imx274 device tree binding file

2017-08-30 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo Acked-by: Sören Brinkmann --- v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindings/media/i2c/imx274.txt | 32 ++ 1 file