Re: [PATCH v3] IB/umem: Release pid in error and ODP flow

On Tue, Jan 03, 2017 at 10:32:50AM +0800, Kenneth Lee wrote: > On Sun, Jan 01, 2017 at 08:47:12AM +0200, Leon Romanovsky wrote: > > Date: Sun, 1 Jan 2017 08:47:12 +0200 > > From: Leon Romanovsky <l...@kernel.org> > > To: Kenneth Lee <liguo...@hisilicon.com> >

Re: [PATCH v3] IB/umem: Release pid in error and ODP flow

On Tue, Jan 03, 2017 at 10:32:50AM +0800, Kenneth Lee wrote: > On Sun, Jan 01, 2017 at 08:47:12AM +0200, Leon Romanovsky wrote: > > Date: Sun, 1 Jan 2017 08:47:12 +0200 > > From: Leon Romanovsky > > To: Kenneth Lee > > CC: dledf...@redhat.com, sean.he...@intel.co

Re: linux-next: Tree for Jan 3

On Tue, Jan 03, 2017 at 03:56:08PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20161224: > > Dropped tree: rdma-leon (complex conflicts) Thanks Stephen, It is our fault. https://www.mail-archive.com/netdev@vger.kernel.org/msg145455.html I'm fixing it right now. signature.asc

Re: linux-next: Tree for Jan 3

On Tue, Jan 03, 2017 at 03:56:08PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20161224: > > Dropped tree: rdma-leon (complex conflicts) Thanks Stephen, It is our fault. https://www.mail-archive.com/netdev@vger.kernel.org/msg145455.html I'm fixing it right now. signature.asc

Re: [PATCH v3] IB/umem: Release pid in error and ODP flow

On Fri, Dec 30, 2016 at 06:18:29PM +0800, Kenneth Lee wrote: > There are two bugfixes in this patch: > > Fixes: 87773dd56d54 ("IB: ib_umem_release() should decrement mm->pinned_vm > from ib_umem_get") > This patch introduce the get_task_pid but not put it back on all error > path > >

Re: [PATCH v3] IB/umem: Release pid in error and ODP flow

On Fri, Dec 30, 2016 at 06:18:29PM +0800, Kenneth Lee wrote: > There are two bugfixes in this patch: > > Fixes: 87773dd56d54 ("IB: ib_umem_release() should decrement mm->pinned_vm > from ib_umem_get") > This patch introduce the get_task_pid but not put it back on all error > path > >

Re: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

to modules") > > Could you please give more suggestion? Thanks. Please, don't use top-posting for this mailing list. It is really-really annoying. > > On Thu, Dec 29, 2016 at 10:17:56AM +0200, Leon Romanovsky wrote: > > Date: Thu, 29 Dec 2016 10:17:56 +0200 > >

Re: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

to modules") > > Could you please give more suggestion? Thanks. Please, don't use top-posting for this mailing list. It is really-really annoying. > > On Thu, Dec 29, 2016 at 10:17:56AM +0200, Leon Romanovsky wrote: > > Date: Thu, 29 Dec 2016 10:17:56 +0200 > > From:

Re: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

On Thu, Dec 29, 2016 at 04:27:28PM +0800, Kenneth Lee wrote: > There are two bugfixes in this patch: > > 1. When the execution go to the ib_umem_odp_get() path, pid should be put >back. > 2. When the memory allocation fail, the pid also should be put back before >exit. > > Signed-off-by:

Re: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

On Thu, Dec 29, 2016 at 04:27:28PM +0800, Kenneth Lee wrote: > There are two bugfixes in this patch: > > 1. When the execution go to the ib_umem_odp_get() path, pid should be put >back. > 2. When the memory allocation fail, the pid also should be put back before >exit. > > Signed-off-by:

Re: [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

On Thu, Dec 29, 2016 at 10:24:43AM +0800, Kenneth Lee wrote: > There are two bugfixes in this patch: > > 1. When the execution go to the ib_umem_odp_get() path, pid should be put >back. > 2. When the memory allocation fail, the pid also should be put back before >exit. > > Signed-off-by:

Re: [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get()

On Thu, Dec 29, 2016 at 10:24:43AM +0800, Kenneth Lee wrote: > There are two bugfixes in this patch: > > 1. When the execution go to the ib_umem_odp_get() path, pid should be put >back. > 2. When the memory allocation fail, the pid also should be put back before >exit. > > Signed-off-by:

Re: [PATCH] net/mlx5: use rb_entry()

| 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, Acked-by: Leon Romanovsky <leo...@mellanox.com> > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c > b/drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c > index 3b026c1..7431f63 100644 &g

Re: [PATCH] net/mlx5: use rb_entry()

ed, 1 insertion(+), 1 deletion(-) Thanks, Acked-by: Leon Romanovsky > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c > b/drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c > index 3b026c1..7431f63 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_cou

Re: [PATCH] RDS: use rb_entry()

n(+), 1 deletion(-) Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> > > diff --git a/net/rds/rdma.c b/net/rds/rdma.c > index 4c93bad..ea96114 100644 > --- a/net/rds/rdma.c > +++ b/net/rds/rdma.c > @@ -135,7 +135,7 @@ void rds_rdma_drop_keys(struct

Re: [PATCH] RDS: use rb_entry()

On Tue, Dec 20, 2016 at 10:02:18PM +0800, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang > --- > net/rds/rdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Than

Re: [PATCH] IB/qib: use rb_entry()

--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> > diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c > b/drivers/infiniband/hw/qib/qib_user_sdma.c > index 3e0677c..926f3c8 100644 > --- a/drivers/infiniband/hw/q

Re: [PATCH] IB/qib: use rb_entry()

tions(+), 3 deletions(-) Thanks, Reviewed-by: Leon Romanovsky > diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c > b/drivers/infiniband/hw/qib/qib_user_sdma.c > index 3e0677c..926f3c8 100644 > --- a/drivers/infiniband/hw/qib/qib_user_sdma.c > +++ b/drivers/infiniband/hw/qi

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

On Wed, Dec 14, 2016 at 01:16:45PM -0500, Doug Ledford wrote: > On 11/21/2016 12:38 PM, Leon Romanovsky wrote: > > On Mon, Nov 21, 2016 at 09:52:53AM -0700, Jason Gunthorpe wrote: > >> On Mon, Nov 21, 2016 at 02:14:08PM +0200, Leon Romanovsky wrote: > >>>>

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

On Wed, Dec 14, 2016 at 01:16:45PM -0500, Doug Ledford wrote: > On 11/21/2016 12:38 PM, Leon Romanovsky wrote: > > On Mon, Nov 21, 2016 at 09:52:53AM -0700, Jason Gunthorpe wrote: > >> On Mon, Nov 21, 2016 at 02:14:08PM +0200, Leon Romanovsky wrote: > >>>>

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

See the patch inline which removes this BUG_ON in proper and safe way. From 7babe807affa2b27d51d3610afb75b693929ea1a Mon Sep 17 00:00:00 2001 From: Leon Romanovsky <leo...@mellanox.com> Date: Mon, 12 Dec 2016 20:02:45 +0200 Subject: [PATCH] net/mlx4: Remove BUG_ON from ICM allocation routine This patch re

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

See the patch inline which removes this BUG_ON in proper and safe way. From 7babe807affa2b27d51d3610afb75b693929ea1a Mon Sep 17 00:00:00 2001 From: Leon Romanovsky Date: Mon, 12 Dec 2016 20:02:45 +0200 Subject: [PATCH] net/mlx4: Remove BUG_ON from ICM allocation routine This patch removes BUG_ON() macro from mlx4_a

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

On Mon, Dec 12, 2016 at 12:58:59PM +0200, Ozgur Karatas wrote: > Hello all, > I think should be use to "WARN_ON" and checkpatch script give to error, I > fixed and I think should don't use "BUG_ON". > Regards, > > Signed-off-by: Ozgur Karatas <okara...@m

Re: [PATCH 1/1] Fixed to BUG_ON to WARN_ON def

On Mon, Dec 12, 2016 at 12:58:59PM +0200, Ozgur Karatas wrote: > Hello all, > I think should be use to "WARN_ON" and checkpatch script give to error, I > fixed and I think should don't use "BUG_ON". > Regards, > > Signed-off-by: Ozgur Karatas NAK, Le

Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value

by: Pan Bian <bianpan2...@163.com> Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value

lers cannot detect the > errors. This patch fixes the bug, assign "-ENOMEM" to err before the > NULL pointer checks, and remove the initialization of err at the > beginning. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189031 > Signed-off-by: Pan Bian Thanks,

Re: [PATCH 1/1] infiniband: hw: ocrdma: fix bad initialization

This patch initialize status with > "-ENOMEM". > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188831 > > Signed-off-by: Pan Bian <bianpan2...@163.com> Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH 1/1] infiniband: hw: ocrdma: fix bad initialization

with > "-ENOMEM". > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188831 > > Signed-off-by: Pan Bian Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value

(!in_mad || !out_mad) > goto out; In such case, the err initialization at the beginning of mlx4_ib_query_device function is not necessary. Can you please remove it? Besides that, look good. Reviewed-by: Leon Romanovsky <leo...@mellanox.com> > > -- > 1.9.1 > > >

Re: [PATCH 1/1] infiniband: hw: mlx4: fix improper return value

ase, the err initialization at the beginning of mlx4_ib_query_device function is not necessary. Can you please remove it? Besides that, look good. Reviewed-by: Leon Romanovsky > > -- > 1.9.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

On Mon, Nov 21, 2016 at 09:52:53AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 21, 2016 at 02:14:08PM +0200, Leon Romanovsky wrote: > > > > > > In ib_ucm_write function there is a wrong prefix: > > > > > > + pr_err_once("ucm_write: process %d (%s) t

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

On Mon, Nov 21, 2016 at 09:52:53AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 21, 2016 at 02:14:08PM +0200, Leon Romanovsky wrote: > > > > > > In ib_ucm_write function there is a wrong prefix: > > > > > > + pr_err_once("ucm_write: process %d (%s) t

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

On Mon, Nov 21, 2016 at 04:12:38PM +, Salil Mehta wrote: > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, November 16, 2016 8:36 AM > > To: Salil Mehta > > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun;

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

On Mon, Nov 21, 2016 at 04:12:38PM +, Salil Mehta wrote: > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, November 16, 2016 8:36 AM > > To: Salil Mehta > > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun;

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

On Mon, Nov 21, 2016 at 12:48:35PM +0100, Dmitry Vyukov wrote: > On Mon, Nov 21, 2016 at 12:44 PM, Leon Romanovsky <l...@kernel.org> wrote: > > On Mon, Nov 21, 2016 at 11:30:21AM +0100, Dmitry Vyukov wrote: > >> On Mon, Nov 21, 2016 at 11:25 AM, Miroslav Benes <mbe...@su

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

On Mon, Nov 21, 2016 at 12:48:35PM +0100, Dmitry Vyukov wrote: > On Mon, Nov 21, 2016 at 12:44 PM, Leon Romanovsky wrote: > > On Mon, Nov 21, 2016 at 11:30:21AM +0100, Dmitry Vyukov wrote: > >> On Mon, Nov 21, 2016 at 11:25 AM, Miroslav Benes wrote: > >> > On M

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

ug Ledford <dledf...@redhat.com> > >> Cc: Sean Hefty <sean.he...@intel.com> > >> Cc: Hal Rosenstock <hal.rosenst...@gmail.com> > >> Cc: Leon Romanovsky <l...@kernel.org> > >> Cc: linux-r...@vger.kernel.org > >> Cc: linux-ker

Re: [PATCH v2] infiniband: remove WARN that is not kernel bug

error > >> or a malicious attempt. This is not a kernel bug, remove it. > >> > >> BUG/WARNs that are not kernel bugs hinder automated testing effots. > >> > >> Signed-off-by: Dmitry Vyukov > >> Cc: Doug Ledford > >> Cc: Sean Hefty >

Re: [PULL REQUEST] Please pull rdma.git

On Sat, Nov 19, 2016 at 06:11:22PM -0500, Doug Ledford wrote: > On 11/19/2016 2:46 PM, Or Gerlitz wrote: > > On Fri, Nov 18, 2016 at 4:01 AM, Doug Ledford wrote: > >> On 11/17/2016 5:24 PM, Or Gerlitz wrote: > > > > [...] > > Are you going to comment on that to the submitter?

Re: [PULL REQUEST] Please pull rdma.git

On Sat, Nov 19, 2016 at 06:11:22PM -0500, Doug Ledford wrote: > On 11/19/2016 2:46 PM, Or Gerlitz wrote: > > On Fri, Nov 18, 2016 at 4:01 AM, Doug Ledford wrote: > >> On 11/17/2016 5:24 PM, Or Gerlitz wrote: > > > > [...] > > Are you going to comment on that to the submitter? if not, they are > >

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

On Tue, Nov 15, 2016 at 03:52:46PM +, Salil Mehta wrote: > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, November 09, 2016 7:22 AM > > To: Salil Mehta > > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun;

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

On Tue, Nov 15, 2016 at 03:52:46PM +, Salil Mehta wrote: > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Wednesday, November 09, 2016 7:22 AM > > To: Salil Mehta > > Cc: dledf...@redhat.com; Huwei (Xavier); oulijun;

Re: [PATCH] IB/usnic: simplify IS_ERR_OR_NULL to IS_ERR

R_OR_NULL(t) > + IS_ERR(t) > > @@ > expression t,e,e1; > @@ > > t = \(usnic_ib_qp_grp_get_chunk(...)\|get_qp_res_chunk(...)\) > ... when != t=e > ?- t ? PTR_ERR(t) : e1 > + PTR_ERR(t) > ... when any > // > > Signed-off-by: Julia Lawall <julia.law..

Re: [PATCH] IB/usnic: simplify IS_ERR_OR_NULL to IS_ERR

R_OR_NULL(t) > + IS_ERR(t) > > @@ > expression t,e,e1; > @@ > > t = \(usnic_ib_qp_grp_get_chunk(...)\|get_qp_res_chunk(...)\) > ... when != t=e > ?- t ? PTR_ERR(t) : e1 > + PTR_ERR(t) > ... when any > // > > Signed-off-by: Julia Lawall Thanks, Julia. Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

gt; Signed-off-by: Salil Mehta <salil.me...@huawei.com> Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

ed the round-robin > mode for allocating resources using bitmap. We use round-robin mode > for qp number and non round-robing mode for other resources like > cq number, pd number etc. > > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Salil Mehta Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

On Fri, Nov 04, 2016 at 04:36:25PM +, Salil Mehta wrote: > From: "Wei Hu (Xavier)" > > This patch modified the logic of allocating memory using APIs in > hns RoCE driver. We used kcalloc instead of kmalloc_array and > bitmap_zero. And When kcalloc failed, call vzalloc

Re: [PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

On Fri, Nov 04, 2016 at 04:36:25PM +, Salil Mehta wrote: > From: "Wei Hu (Xavier)" > > This patch modified the logic of allocating memory using APIs in > hns RoCE driver. We used kcalloc instead of kmalloc_array and > bitmap_zero. And When kcalloc failed, call vzalloc to alloc > memory. > >

Re: linux-next: manual merge of the rdma-leon-test tree with the net-next tree

On Tue, Nov 08, 2016 at 01:06:23PM +1100, Stephen Rothwell wrote: > Hi Leon, > > Today's linux-next merge of the rdma-leon-test tree got a conflict in: > > drivers/infiniband/core/roce_gid_mgmt.c > > between commit: > > 453d39329ad0 ("IB/core: Flip to the new dev walk API") > > from the

Re: linux-next: manual merge of the rdma-leon-test tree with the net-next tree

On Tue, Nov 08, 2016 at 01:06:23PM +1100, Stephen Rothwell wrote: > Hi Leon, > > Today's linux-next merge of the rdma-leon-test tree got a conflict in: > > drivers/infiniband/core/roce_gid_mgmt.c > > between commit: > > 453d39329ad0 ("IB/core: Flip to the new dev walk API") > > from the

Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event

On Sun, Oct 30, 2016 at 11:17:57PM +0200, Sagi Grimberg wrote: > > > On 27/10/16 09:59, Binoy Jayan wrote: > >Convert the completion 'mlx5_ib_umr_context:done' to a wait_event as it > >just waits for the return value to be filled. On top of Sagi's response, I'm failing to understand why it is

Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event

On Sun, Oct 30, 2016 at 11:17:57PM +0200, Sagi Grimberg wrote: > > > On 27/10/16 09:59, Binoy Jayan wrote: > >Convert the completion 'mlx5_ib_umr_context:done' to a wait_event as it > >just waits for the return value to be filled. On top of Sagi's response, I'm failing to understand why it is

Re: [PATCH v4 00/10] infiniband: Remove semaphores

dded patch - Replace semaphore umr_common:sem with wait_event > IB/mlx5: Fixed a bug pointed out by Leon Romanovsky Please keep full changelog for your next submissions/respins. Thanks signature.asc Description: PGP signature

Re: [PATCH v4 00/10] infiniband: Remove semaphores

dded patch - Replace semaphore umr_common:sem with wait_event > IB/mlx5: Fixed a bug pointed out by Leon Romanovsky Please keep full changelog for your next submissions/respins. Thanks signature.asc Description: PGP signature

Re: [PATCH v3 8/9] IB/mlx5: Add helper mlx5_ib_post_send_wait

On Wed, Oct 26, 2016 at 01:31:13PM +0530, Binoy Jayan wrote: > Clean up the following common code (to post a list of work requests to the > send queue of the specified QP) at various places and add a helper function > 'mlx5_ib_post_send_wait' to implement the same. > > - Initialize

Re: [PATCH v3 8/9] IB/mlx5: Add helper mlx5_ib_post_send_wait

On Wed, Oct 26, 2016 at 01:31:13PM +0530, Binoy Jayan wrote: > Clean up the following common code (to post a list of work requests to the > send queue of the specified QP) at various places and add a helper function > 'mlx5_ib_post_send_wait' to implement the same. > > - Initialize

Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait

On Tue, Oct 25, 2016 at 06:46:58PM +0530, Binoy Jayan wrote: > On 25 October 2016 at 17:56, Leon Romanovsky <l...@kernel.org> wrote: > > On Tue, Oct 25, 2016 at 05:31:59PM +0530, Binoy Jayan wrote: > > > In case of success (err == 0), you will call to unmap_dma in

Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait

On Tue, Oct 25, 2016 at 06:46:58PM +0530, Binoy Jayan wrote: > On 25 October 2016 at 17:56, Leon Romanovsky wrote: > > On Tue, Oct 25, 2016 at 05:31:59PM +0530, Binoy Jayan wrote: > > > In case of success (err == 0), you will call to unmap_dma instead of > > normal flo

Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait

_pd *pd, > struct ib_umem *umem, > prep_umr_reg_wqe(pd, , , dma, npages, mr->mmkey.key, >page_shift, virt_addr, len, access_flags); > > - down(>sem); > - err = ib_post_send(umrc->qp, , ); > - if (err) { > - mlx

Re: [PATCH v2 8/8] IB/mlx5: Add helper mlx5_ib_post_send_wait

gt; prep_umr_reg_wqe(pd, , , dma, npages, mr->mmkey.key, >page_shift, virt_addr, len, access_flags); > > - down(>sem); > - err = ib_post_send(umrc->qp, , ); > - if (err) { > - mlx5_ib_warn(dev, "

Re: [PATCH v2] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning

gcc-4.9, short of > initializing each of the arguments first was to change the calling > conventions to separate the error code from the umem pointer. This > avoids casting the error codes from one pointer to another incompatible > pointer, and lets gcc figure out when that the data is actually val

Re: [PATCH v2] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning

gcc-4.9, short of > initializing each of the arguments first was to change the calling > conventions to separate the error code from the umem pointer. This > avoids casting the error codes from one pointer to another incompatible > pointer, and lets gcc figure out when that the data is actuall

Re: [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning

alid > whenever we return successfully. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks Arnd for fixing it. I have a very small comment which is not related to functionality. Rather than that, Acked-by: Leon Romanovsky <leo...@mellanox.com> > --- > drivers/in

Re: [PATCH] IB/mlx5: avoid bogus -Wmaybe-uninitialized warning

alid > whenever we return successfully. > > Signed-off-by: Arnd Bergmann Thanks Arnd for fixing it. I have a very small comment which is not related to functionality. Rather than that, Acked-by: Leon Romanovsky > --- > drivers/infiniband/hw/mlx5/mr.c | 39

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Wed, Oct 05, 2016 at 08:37:35AM +0200, Christoph Hellwig wrote: > FYI, the patches look fine to me: > > Acked-by: Christoph Hellwig > > but we're past the merge window for 4.9 now unfortunately. IMHO, it still can make it. Thanks signature.asc Description: PGP signature

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

On Wed, Oct 05, 2016 at 08:37:35AM +0200, Christoph Hellwig wrote: > FYI, the patches look fine to me: > > Acked-by: Christoph Hellwig > > but we're past the merge window for 4.9 now unfortunately. IMHO, it still can make it. Thanks signature.asc Description: PGP signature

Re: [PATCHv12 0/3] rdmacg: IB/core: rdma controller support

le HCA (for example in percentages). It will allow natively define new objects without need to introduce them to the user. This HCA share will be overwritten by specific UVERBS types which you already defined. What do you think? Except this proposal, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> Thanks. signature.asc Description: PGP signature

Re: [PATCHv12 0/3] rdmacg: IB/core: rdma controller support

le HCA (for example in percentages). It will allow natively define new objects without need to introduce them to the user. This HCA share will be overwritten by specific UVERBS types which you already defined. What do you think? Except this proposal, Reviewed-by: Leon Romanovsky Thanks. signature.asc Description: PGP signature

Re: [PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs

: https://lkml.org/lkml/2016/9/1/609 > > All fixes have been done & tested by Oulijun and Huwei. > > V1->V2: * PATCH 3/20 and 13/20 have been dropped after rework > of comments by Leon Romanovsky on V1 patch. > * New patch "Fix for removal of redu

Re: [PATCH V2 for-next 00/19] IB/hns: Fixes for various misc. bugs

: https://lkml.org/lkml/2016/9/1/609 > > All fixes have been done & tested by Oulijun and Huwei. > > V1->V2: * PATCH 3/20 and 13/20 have been dropped after rework > of comments by Leon Romanovsky on V1 patch. > * New patch "Fix for removal of redu

Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state

On Tue, Sep 20, 2016 at 04:56:35PM +, Salil Mehta wrote: > > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Thursday, September 15, 2016 11:13 AM > > To: Salil Mehta > > Cc: dledf...@redhat.com; Huwei (X

Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state

On Tue, Sep 20, 2016 at 04:56:35PM +, Salil Mehta wrote: > > > > -Original Message- > > From: Leon Romanovsky [mailto:l...@kernel.org] > > Sent: Thursday, September 15, 2016 11:13 AM > > To: Salil Mehta > > Cc: dledf...@redhat.com; Huwei (X

Re: [PATCH] IB/rxe: avoid putting a large struct rxe_qp on stack

ch is the only field we access in the rollback_qp > anyway. > > Fixes: 3050b9985024 ("IB/rxe: Fix race condition between requester and > completer") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks Arnd, It is much cleaner approach. Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] IB/rxe: avoid putting a large struct rxe_qp on stack

ch is the only field we access in the rollback_qp > anyway. > > Fixes: 3050b9985024 ("IB/rxe: Fix race condition between requester and > completer") > Signed-off-by: Arnd Bergmann Thanks Arnd, It is much cleaner approach. Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH] net/mlx5: clean function declarations in eswitch.c up

nized in other file. > > So this patch moves the declarations into > drivers/net/ethernet/mellanox/mlx5/core/eswitch.h > > Signed-off-by: Baoyou Xie <baoyou@linaro.org> Thanks, Acked-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] net/mlx5: clean function declarations in eswitch.c up

nized in other file. > > So this patch moves the declarations into > drivers/net/ethernet/mellanox/mlx5/core/eswitch.h > > Signed-off-by: Baoyou Xie Thanks, Acked-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

Sorry > > 4.8 dates are close by (2 weeks) and there are two git trees involved > (that might cause merge error to Linus) so if there are no issues, I > would like to make request to Doug to consider it for 4.8 early on. > > Parav > > On Mon, Sep 12, 2016 at 10:37 AM, Leon R

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

Sorry > > 4.8 dates are close by (2 weeks) and there are two git trees involved > (that might cause merge error to Linus) so if there are no issues, I > would like to make request to Doug to consider it for 4.8 early on. > > Parav > > On Mon, Sep 12, 2016 at 10:37 AM, Leo

Re: [PATCH for-next 20/20] IB/hns: Delete the redundant lines in hns_roce_v1_m_qp()

On Fri, Sep 09, 2016 at 06:30:51PM +0800, Salil Mehta wrote: > From: Lijun Ou > > It doesn't need to assign for the filed of qp state in qpc separately > when qp happen to migrate state which supported in RoCE engine v1. > > Signed-off-by: Lijun Ou >

Re: [PATCH for-next 20/20] IB/hns: Delete the redundant lines in hns_roce_v1_m_qp()

On Fri, Sep 09, 2016 at 06:30:51PM +0800, Salil Mehta wrote: > From: Lijun Ou > > It doesn't need to assign for the filed of qp state in qpc separately > when qp happen to migrate state which supported in RoCE engine v1. > > Signed-off-by: Lijun Ou > Reviewed-by: Wei Hu (Xavier) >

Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state

On Fri, Sep 09, 2016 at 06:30:49PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The rq head in qpc was zero will miss the rq wqes which > have be sent, so here we should take the real value. > > Signed-off-by: Lijun Ou > Reviewed-by: Wei Hu (Xavier)

Re: [PATCH for-next 18/20] IB/hns: Update the rq head when modify qp state

On Fri, Sep 09, 2016 at 06:30:49PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The rq head in qpc was zero will miss the rq wqes which > have be sent, so here we should take the real value. > > Signed-off-by: Lijun Ou > Reviewed-by: Wei Hu (Xavier) > Signed-off-by: Salil Mehta > --- >

Re: [PATCH for-next 03/20] IB/hns: Add the check for pointer ctrl

On Fri, Sep 09, 2016 at 06:30:34PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The pointer ctrl may be null, so we add check for it. > > Signed-off-by: Lijun Ou > Reviewed-by: Wei Hu > Signed-off-by: Salil Mehta

Re: [PATCH for-next 03/20] IB/hns: Add the check for pointer ctrl

On Fri, Sep 09, 2016 at 06:30:34PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The pointer ctrl may be null, so we add check for it. > > Signed-off-by: Lijun Ou > Reviewed-by: Wei Hu > Signed-off-by: Salil Mehta > --- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c |6 ++ > 1 file

Re: [PATCH for-next 12/20] IB/hns: Return bad wr while post send failed

On Fri, Sep 09, 2016 at 06:30:43PM +0800, Salil Mehta wrote: > From: Lijun Ou > > While post failed, hns roce should return the wr failed to user. > We omitted this while qp type is wrong and fixed it. > > Signed-off-by: Lijun Ou > Signed-off-by: Dongdong

Re: [PATCH for-next 12/20] IB/hns: Return bad wr while post send failed

On Fri, Sep 09, 2016 at 06:30:43PM +0800, Salil Mehta wrote: > From: Lijun Ou > > While post failed, hns roce should return the wr failed to user. > We omitted this while qp type is wrong and fixed it. > > Signed-off-by: Lijun Ou > Signed-off-by: Dongdong Huang(Donald) > Reviewed-by: Wei Hu

Re: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock

On Wed, Sep 14, 2016 at 02:09:37AM +, Salil Mehta wrote: > > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Tuesday, September 13, 2016 7:50 AM >

Re: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock

On Wed, Sep 14, 2016 at 02:09:37AM +, Salil Mehta wrote: > > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Tuesday, September 13, 2016 7:50 AM >

Re: [PATCH for-next 13/20] IB/hns: Add check for some NULL pointer scenes

On Fri, Sep 09, 2016 at 06:30:44PM +0800, Salil Mehta wrote: > From: Lijun Ou > > Some pointers have not be checked when they are null, > so we add check for them. > > Signed-off-by: Lijun Ou > Signed-off-by: Dongdong Huang(Donald) >

Re: [PATCH for-next 13/20] IB/hns: Add check for some NULL pointer scenes

On Fri, Sep 09, 2016 at 06:30:44PM +0800, Salil Mehta wrote: > From: Lijun Ou > > Some pointers have not be checked when they are null, > so we add check for them. > > Signed-off-by: Lijun Ou > Signed-off-by: Dongdong Huang(Donald) > Reviewed-by: Wei Hu (Xavier) > Signed-off-by: Salil Mehta

Re: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock

On Fri, Sep 09, 2016 at 06:30:41PM +0800, Salil Mehta wrote: > From: Lijun Ou > > This lock will be used in query port interface, and will be called > while IB device was registered to OFED frame. So, the lock of iboe > must be initiated before IB device was registered.

Re: [PATCH for-next 10/20] IB/hns: Modify the init of iboe lock

On Fri, Sep 09, 2016 at 06:30:41PM +0800, Salil Mehta wrote: > From: Lijun Ou > > This lock will be used in query port interface, and will be called > while IB device was registered to OFED frame. So, the lock of iboe > must be initiated before IB device was registered. Sorry, what did you mean

Re: [PATCH for-next 16/20] IB/hns: Validate mtu when modified qp

On Fri, Sep 09, 2016 at 06:30:47PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The mtu should be validated when modify qp,so we check it. > > Signed-off-by: Lijun Ou > Signed-off-by: Peter Chen > Reviewed-by: Wei Hu (Xavier)

Re: [PATCH for-next 16/20] IB/hns: Validate mtu when modified qp

On Fri, Sep 09, 2016 at 06:30:47PM +0800, Salil Mehta wrote: > From: Lijun Ou > > The mtu should be validated when modify qp,so we check it. > > Signed-off-by: Lijun Ou > Signed-off-by: Peter Chen > Reviewed-by: Wei Hu (Xavier) > Signed-off-by: Salil Mehta > --- >

Re: [PATCH for-next 02/10] IB/hns: Register add_gid and del_gid for GID Table management

On Fri, Sep 02, 2016 at 05:37:17AM +0800, Salil Mehta wrote: > From: Lijun Ou > > This patch adds support of add_gid() and del_gid() function in the > HNS RoCE driver for manipulation of the GID table associated with > port. This shall be used be used by CM when connection is

Re: [PATCH for-next 02/10] IB/hns: Register add_gid and del_gid for GID Table management

On Fri, Sep 02, 2016 at 05:37:17AM +0800, Salil Mehta wrote: > From: Lijun Ou > > This patch adds support of add_gid() and del_gid() function in the > HNS RoCE driver for manipulation of the GID table associated with > port. This shall be used be used by CM when connection is > established. > >

Re: [PATCH for-next 03/10] IB/hns: Add & initialize "node_guid" parameter for RDMA CM

On Fri, Sep 02, 2016 at 05:37:18AM +0800, Salil Mehta wrote: > From: Lijun Ou > > According to the Infiniband spec, NodeGUID uniquely identifies a > node. This must be initialized to some unique value. This patch > adds the support to the HNS RoCE driver to fetch the NodeGUID

Re: [PATCH for-next 03/10] IB/hns: Add & initialize "node_guid" parameter for RDMA CM

On Fri, Sep 02, 2016 at 05:37:18AM +0800, Salil Mehta wrote: > From: Lijun Ou > > According to the Infiniband spec, NodeGUID uniquely identifies a > node. This must be initialized to some unique value. This patch > adds the support to the HNS RoCE driver to fetch the NodeGUID > value from DT or

Re: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq interrupt handle and fix the bug of qpn

On Fri, Sep 09, 2016 at 06:30:40PM +0800, Salil Mehta wrote: > + HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_M, > + HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_S); > + phy_port = roce_get_field(aeqe->event.qp_event.qp, > +

Re: [PATCH for-next 09/20] IB/hns: Optimize code of aeq and ceq interrupt handle and fix the bug of qpn

On Fri, Sep 09, 2016 at 06:30:40PM +0800, Salil Mehta wrote: > + HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_M, > + HNS_ROCE_AEQE_EVENT_QP_EVENT_QP_QPN_S); > + phy_port = roce_get_field(aeqe->event.qp_event.qp, > +

<    7   8   9   10   11   12   13   14   15   16   >