[PATCH mlx5-next 02/11] net/mlx5: Properly convey driver version to firmware

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky mlx5 firmware expects driver version in specific format X.X.X, so make it always correct and based on real kernel version aligned with the driver. Fixes: 012e50e109fd ("net/mlx5: Set driver version into firmware") Signed-off-by: Leon Romanovsky --- drivers/ne

[PATCH mlx5-next 01/11] net/mlx5: Don't skip vport check

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Users of mlx5_eswitch_get_vport() are required to check return value prior to passing mlx5_vport further. Fix all the places to do not skip that check. Fixes: c7eddc6092b4 ("net/mlx5: E-switch, Move devlink eswitch ports closer to eswitch") Fixes: 5d9986a3947a

[PATCH mlx5-next 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Change module registration logic to use auxiliary bus instead of custom made mlx5 register interface. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 28 ++- drivers/vdpa/mlx5/Makefile| 2 +- drivers/vdpa/mlx5

[PATCH mlx5-next 08/11] RDMA/mlx5: Convert mlx5_ib to use auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky The conversion to auxiliary bus solves long standing issue with existing mlx5_ib<->mlx5_core coupling. It required to have both modules in initramfs if one of them needed for the boot. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/ib_rep.c

[PATCH mlx5-next 10/11] net/mlx5: Simplify eswitch mode check

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Provide mlx5_core device instead of "priv" pointer while checking eswith mode. Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/counters.c | 7 --- drivers/infiniband/hw/mlx5/ib_rep.c | 5 - drivers/infiniba

[PATCH mlx5-next 09/11] net/mlx5: Delete custom device management logic

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky After conversion to use auxiliary bus, all custom device management is not needed anymore, delete it. Signed-off-by: Leon Romanovsky --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 299 +- drivers/net/ethernet/mellanox/mlx5/core/lag.c | 18

[PATCH mlx5-next 00/11] Convert mlx5 to use auxiliary bus

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This patch set converts mlx5 driver to use auxiliary bus [1]. In this series, we are connecting three subsystems (VDPA, netdev and RDMA) through mlx5_core PCI driver. That driver is responsible to create proper devices based on supported firmware. First four patches

[PATCH mlx5-next 03/11] net/mlx5_core: Clean driver version and name

2020-10-26 Thread Leon Romanovsky
From: Leon Romanovsky Remove exposed driver version as it was done in other drivers, so module version will work correctly by displaying the kernel version for which it is compiled. And move mlx5_core module name to general include, so auxiliary drivers will be able to use it as a basis for a

Re: [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support

2020-10-23 Thread Leon Romanovsky
On Fri, Oct 23, 2020 at 08:56:10AM +0200, Greg KH wrote: > On Fri, Oct 23, 2020 at 09:49:46AM +0300, Leon Romanovsky wrote: > > On Thu, Oct 22, 2020 at 05:33:28PM -0700, Dave Ertman wrote: > > > > <...> > > > > > Dave Ertman (1): > > > Add auxil

Re: [PATCH v3 00/10] Auxiliary bus implementation and SOF multi-client support

2020-10-22 Thread Leon Romanovsky
On Thu, Oct 22, 2020 at 05:33:28PM -0700, Dave Ertman wrote: <...> > Dave Ertman (1): > Add auxiliary bus support We are in merge window now and both netdev and RDMA are closed for submissions. So I'll send my mlx5 conversion patches once -rc1 will be tagged. However, It is important that thi

[PATCH rdma-rc 0/3] Fixes to coming PR

2020-10-11 Thread Leon Romanovsky
From: Leon Romanovsky Leon Romanovsky (2): RDMA/core: Postpone uobject cleanup on failure till FD close RDMA/core: Make FD destroy callback void Maor Gottlieb (1): RDMA/ucma: Fix use after free in destroy id flow drivers/infiniband/core/rdma_core.c | 45

Re: [PATCH-next 0/4] RDMA: sprintf to sysfs_emit conversions

2020-10-08 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 10:52:15PM -0700, Joe Perches wrote: > On Thu, 2020-10-08 at 08:41 +0300, Leon Romanovsky wrote: > > On Wed, Oct 07, 2020 at 07:36:23PM -0700, Joe Perches wrote: > > > A recent commit added a sysfs_emit and sysfs_emit_at to allow various > > > sys

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-10-07 Thread Leon Romanovsky
On Mon, Sep 28, 2020 at 12:50:03PM -0700, Linus Torvalds wrote: > On Mon, Sep 28, 2020 at 12:36 PM Linus Torvalds > wrote: > > > > So I'll do the pte wrprotect/restore removal. Anybody willing to do > > and test the sequence count approach? > > So the wrprotect removal is trivial, with most of it

Re: [PATCH-next 0/4] RDMA: sprintf to sysfs_emit conversions

2020-10-07 Thread Leon Romanovsky
On Wed, Oct 07, 2020 at 07:36:23PM -0700, Joe Perches wrote: > A recent commit added a sysfs_emit and sysfs_emit_at to allow various > sysfs show functions to ensure that the PAGE_SIZE buffer argument is > never overrun and always NUL terminated. Unfortunately but the sysfs_emit commit is not in r

Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code

2020-10-05 Thread Leon Romanovsky
On Mon, Oct 05, 2020 at 10:38:17AM +0200, Christoph Hellwig wrote: > On Fri, Oct 02, 2020 at 01:20:35PM -0700, Sagi Grimberg wrote: > >> Well, why would they change it? The whole point of the infrastructure > >> is that there is a single sane affinity setting for a given setup. Now > >> that setti

[PATCH rdma-next v5 4/4] RDMA/umem: Move to allocate SG table from pages

2020-10-04 Thread Leon Romanovsky
600.0MB After512001.2MB Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/umem.c | 94 +- 1 file changed, 12 insertions(+), 82 deletions(-) diff --git a/drivers/infiniband/core/umem.c b

[PATCH rdma-next v5 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-10-04 Thread Leon Romanovsky
h the Infiniband driver that allocates a single page for hold the pages. For 1TB memory registration, the temporary buffer would consume only 4KB, instead of 2GB. Signed-off-by: Maor Gottlieb Reviewed-by: Christoph Hellwig Signed-off-by: Leon Romanovsky --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c

[PATCH rdma-next v5 2/4] tools/testing/scatterlist: Rejuvenate bit-rotten test

2020-10-04 Thread Leon Romanovsky
From: Tvrtko Ursulin A couple small tweaks are needed to make the test build and run on current kernels. Signed-off-by: Tvrtko Ursulin Cc: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/Makefile | 3 ++- tools/testing/scatterlist/linux/mm.h | 35

[PATCH rdma-next v5 0/4] Dynamicaly allocate SG table from the pages

2020-10-04 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v5: * Use sg_init_table to allocate table and avoid changes is __sg_alloc_table * Fix offset issue v4: https://lore.kernel.org/lkml/20200927064647.3106737-1-l...@kernel.org * Fixed formatting in first patch. * Added fix (clear tmp_netnts) in first patch to

[PATCH rdma-next v5 3/4] tools/testing/scatterlist: Show errors in human readable form

2020-10-04 Thread Leon Romanovsky
From: Tvrtko Ursulin Instead of just asserting dump some more useful info about what the test saw versus what it expected to see. Signed-off-by: Tvrtko Ursulin Cc: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/main.c | 44 1 file

Re: [PATCH blk-next 0/2] Delete the get_vector_affinity leftovers

2020-09-30 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 12:13:56PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > There are no drivers that implement .get_vector_affinity(), so delete > the RDMA function and simplify block code. > > Thanks > > P.S. Probably it should go through block tree

Re: [PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 12:14:06PM -0300, Jason Gunthorpe wrote: > On Wed, Sep 30, 2020 at 06:05:15PM +0300, Maor Gottlieb wrote: > > This is right only for the last iteration. E.g. in the first iteration in > > case that there are more pages (left_pages), then we allocate > > SG_MAX_SINGLE_ALLOC. 

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 12:11:24PM +0200, Johannes Berg wrote: > On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: > > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > > > Leon Romanovsky writes: > > > > > > > > diff --git a/drive

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:05:49AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> --- /dev/null > >> +++ b/drivers/net/wireless/purelifi/Kconfig > >> @@ -0,0 +1,38 @@ > >> +# SPDX-License-Identifier: GPL-2.0 > >> +config

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-30 Thread Leon Romanovsky
On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: > Leon Romanovsky writes: > > >> diff --git a/drivers/net/wireless/purelifi/Kconfig > > b/drivers/net/wireless/purelifi/Kconfig > >> new file mode 100644 > >> index ..ff05eaf0a8d4 &g

Re: [PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-30 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 04:59:29PM -0300, Jason Gunthorpe wrote: > On Sun, Sep 27, 2020 at 09:46:47AM +0300, Leon Romanovsky wrote: > > @@ -296,11 +223,17 @@ static struct ib_umem *__ib_umem_get(struct ib_device > > *device, > > goto umem_release; > &g

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-09-29 Thread Leon Romanovsky
On Mon, Sep 28, 2020 at 03:49:49PM +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices, which provide lightweight, highspeed secure and > fully networked wireless communications via light. > > This driver implementation has been bas

Re: [PATCH v2] net/mlx5e: Fix use of freed pointer

2020-09-29 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 11:15:49AM +0100, Alex Dewar wrote: > If the call to mlx5_fc_create() fails, then shared_counter will be freed > before its member, shared_counter->counter, is accessed to retrieve the > error code. Fix by using an intermediate variable. > > Addresses-Coverity: CID 1497153:

Re: [PATCH v2 0/4] mm: Break COW for pinned pages during fork()

2020-09-29 Thread Leon Romanovsky
On Sun, Sep 27, 2020 at 12:35:59PM -0700, Linus Torvalds wrote: > On Fri, Sep 25, 2020 at 3:26 PM Peter Xu wrote: > > > > This series is majorly inspired by the previous discussion on the list [1], > > starting from the report from Jason on the rdma test failure. > > Ok, this is now in my git tree

Re: [PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code

2020-09-29 Thread Leon Romanovsky
On Tue, Sep 29, 2020 at 12:20:46PM +0200, Christoph Hellwig wrote: > On Tue, Sep 29, 2020 at 12:13:57PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > The RDMA vector affinity code is not backed up by any driver and always > > returns NULL to every ib

[PATCH blk-next 1/2] blk-mq-rdma: Delete not-used multi-queue RDMA map queue code

2020-09-29 Thread Leon Romanovsky
From: Leon Romanovsky The RDMA vector affinity code is not backed up by any driver and always returns NULL to every ib_get_vector_affinity() call. This means that blk_mq_rdma_map_queues() always takes fallback path. Fixes: 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity&quo

[PATCH blk-next 0/2] Delete the get_vector_affinity leftovers

2020-09-29 Thread Leon Romanovsky
From: Leon Romanovsky There are no drivers that implement .get_vector_affinity(), so delete the RDMA function and simplify block code. Thanks P.S. Probably it should go through block tree. Leon Romanovsky (2): blk-mq-rdma: Delete not-used multi-queue RDMA map queue code RDMA/core: Delete

[PATCH blk-next 2/2] RDMA/core: Delete not-implemented get_vector_affinity

2020-09-29 Thread Leon Romanovsky
From: Leon Romanovsky There are no drivers that support .get_vector_affinity(), so delete it. Fixes: 9afc97c29b03 ("mlx5: remove support for ib_get_vector_affinity") Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/device.c | 1 - include/rdma/ib_verbs.h

Re: [PATCH 3/3] net/mlx5e: Fix use of freed pointer

2020-09-28 Thread Leon Romanovsky
On Sun, Sep 27, 2020 at 12:32:53PM +0100, Alex Dewar wrote: > If the call to mlx5_fc_create() fails, then shared_counter will be freed > before its member, shared_counter->counter, is accessed to retrieve the > error code. Fix by using an intermediate variable. > > Addresses-Coverity: CID 1497153:

Re: [PATCH 2/3] net/mlx5e: Clean up error handling in mlx5e_alloc_flow()

2020-09-28 Thread Leon Romanovsky
On Sun, Sep 27, 2020 at 12:32:52PM +0100, Alex Dewar wrote: > The variable flow is used after being allocated but before being > null-checked, which will cause a null pointer dereference if the > allocation failed. Fix this and tidy up the error-checking logic in this > function. > > Addresses-Cove

Re: [PATCH][next] net/mlx5e: Fix potential null pointer dereference

2020-09-28 Thread Leon Romanovsky
x/mlx5/core/en_tc.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky

[PATCH rdma-next v4 2/4] tools/testing/scatterlist: Rejuvenate bit-rotten test

2020-09-26 Thread Leon Romanovsky
From: Tvrtko Ursulin A couple small tweaks are needed to make the test build and run on current kernels. Signed-off-by: Tvrtko Ursulin Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/Makefile | 3 ++- tools/testing/scatterlist/linux/mm.h | 35

[PATCH rdma-next v4 1/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-26 Thread Leon Romanovsky
h the Infiniband driver that allocates a single page for hold the pages. For 1TB memory registration, the temporary buffer would consume only 4KB, instead of 2GB. Signed-off-by: Maor Gottlieb Reviewed-by: Christoph Hellwig Signed-off-by: Leon Romanovsky --- drivers/gpu/drm/i915/gem/i915_gem_userptr.c

[PATCH rdma-next v4 3/4] tools/testing/scatterlist: Show errors in human readable form

2020-09-26 Thread Leon Romanovsky
From: Tvrtko Ursulin Instead of just asserting dump some more useful info about what the test saw versus what it expected to see. Signed-off-by: Tvrtko Ursulin Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- tools/testing/scatterlist/main.c | 44

[PATCH rdma-next v4 0/4] Dynamicaly allocate SG table from the pages

2020-09-26 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v4: * Fixed formatting in first patch. * Added fix (clear tmp_netnts) in first patch to fix i915 failure. * Added test patches v3: https://lore.kernel.org/linux-rdma/20200922083958.2150803-1-l...@kernel.org/ * Squashed Christopher's suggestion to

[PATCH rdma-next v4 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-26 Thread Leon Romanovsky
600.0MB After512001.2MB Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/umem.c | 92 +- 1 file changed, 12 insertions(+), 80 deletions(-) diff --git a/drivers/infiniband/core/umem.c b

Re: [PATCH 1/5] mm: Introduce mm_struct.has_pinned

2020-09-26 Thread Leon Romanovsky
On Sat, Sep 26, 2020 at 03:28:32PM -0700, Linus Torvalds wrote: > On Fri, Sep 25, 2020 at 6:15 PM Linus Torvalds > wrote: > > > > I think that over the weekend I'll do Peter's version but with the > > "page_mapcount() == 1" check, because I'm starting to like that > > better than the mm->has_pinn

[PATCH rdma-next v1 00/10] Prepare drivers to move QP allocation to ib_core

2020-09-26 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Rebased * Fixed commit messages. * Changed "fallthrough" to be "break". v0: https://lore.kernel.org/lkml/20200910140046.1306341-1-l...@kernel.org - Hi, This s

[PATCH rdma-next v3 0/9] Track memory allocation with restrack DB help

2020-09-26 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Rebased on already accepted patches. * Added mlx4 special QPs to the list of not-tracked QPs (dropped previous mlx4 special QP patch). * Separated to two patches change in return value of cma_listen_* routines. * Changed commit messages and added Fixes

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-25 Thread Leon Romanovsky
On Fri, Sep 25, 2020 at 07:29:24PM +0800, Jason Wang wrote: > > On 2020/9/25 下午6:19, Michael S. Tsirkin wrote: > > On Fri, Sep 25, 2020 at 10:20:05AM +0300, Leon Romanovsky wrote: > > > On Thu, Sep 24, 2020 at 12:02:43PM -0400, Michael S. Tsirkin wrote: > > > > O

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-25 Thread Leon Romanovsky
On Thu, Sep 24, 2020 at 12:02:43PM -0400, Michael S. Tsirkin wrote: > On Thu, Sep 24, 2020 at 08:47:05AM -0700, Randy Dunlap wrote: > > On 9/24/20 3:24 AM, Eli Cohen wrote: > > > On Thu, Sep 24, 2020 at 05:30:55AM -0400, Michael S. Tsirkin wrote: > > --- linux-next-20200917.orig/drivers/vdpa/K

[PATCH rdma-next v3 0/4] Query GID table API

2020-09-23 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Returned back port validity check, because we are using port number to check protocol type. * Removed check that interface is up from rdma_read_gid_attr_ndev_rcu(), without it, this API behaved differently from sysfs by not showing GIDs for interfaces

Re: [PATCH 0/5] mm: Break COW for pinned pages during fork()

2020-09-23 Thread Leon Romanovsky
On Mon, Sep 21, 2020 at 05:17:39PM -0400, Peter Xu wrote: > Finally I start to post formal patches because it's growing. And also since > we've discussed quite some issues already, so I feel like it's clearer on what > we need to do, and how. > > This series is majorly inspired by the previous dis

[PATCH rdma-next v3 0/5] Cleanup restrack code

2020-09-22 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Removed the mlx4 SR-IOV patch in favour of more robust fix that not needed in this series. * Cut the eroginal series to already reviewed and standalone patches. v2: https://lore.kernel.org/linux-rdma/20200907122156.478360-1-l...@kernel.org/ * Added

[PATCH rdma-next v3 0/2] Dynamicaly allocate SG table from the pages

2020-09-22 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: * Squashed Christopher's suggestion to avoid introduced new API, but extend existing one. v2: https://lore.kernel.org/linux-rdma/20200916140726.839377-1-l...@kernel.org * Fixed indentations and comments * Deleted sg_alloc_next() * Squashe

[PATCH rdma-next v2 0/4] Query GID table API

2020-09-22 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * Embedded RoCE protocol type into rdma_read_gid_attr_ndev_rcu v1: https://lore.kernel.org/lkml/2020091429.343651-1-l...@kernel.org * Moved git_type logic to cma_set_default_gid_type - Patch #2 * Changed signature of rdma_query_gid_table - Patch #3

[PATCH rdma-next v2 0/4] Improve ODP by using HMM API

2020-09-22 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * Patch #1 – Drop redundant mask. * Patch #4 – Use address and length directly from umem_odp. v1: https://lore.kernel.org/lkml/20200917112152.1075974-1-l...@kernel.org * Cleaned code. * Support a potential valid dma_address of NULL by flags detection

Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters()

2020-09-21 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 11:23:18AM +0800, Liu Shixin wrote: > On 2020/9/18 1:33, Leon Romanovsky wrote: > > On Thu, Sep 17, 2020 at 02:24:51PM -0300, Jason Gunthorpe wrote: > >> On Thu, Sep 17, 2020 at 08:05:11PM +0300, Leon Romanovsky wrote: > >>> On Thu, Sep 17, 2

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Leon Romanovsky
On Mon, Sep 21, 2020 at 02:22:02PM +0300, Gal Pressman wrote: > On 18/09/2020 18:28, Jason Gunthorpe wrote: > > On Fri, Sep 18, 2020 at 06:15:52PM +0300, Oded Gabbay wrote: > > > >> I'm sorry, but you won't be able to convince me here that I need to > >> "enslave" my entire code to RDMA, just becau

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-21 Thread Leon Romanovsky
On Sun, Sep 20, 2020 at 10:05:39PM +0300, Oded Gabbay wrote: > On Sun, Sep 20, 2020 at 11:47 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Sep 19, 2020 at 04:22:35PM -0300, Jason Gunthorpe wrote: > > > On Sat, Sep 19, 2020 at 07:27:30PM +0200, Greg Kroah-Hartman wrote: > > > > > It's probably her

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Leon Romanovsky
On Sat, Sep 19, 2020 at 10:30:12AM +0200, Greg Kroah-Hartman wrote: > On Sat, Sep 19, 2020 at 11:20:03AM +0300, Leon Romanovsky wrote: > > On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote:

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-19 Thread Leon Romanovsky
On Sat, Sep 19, 2020 at 08:40:20AM +0200, Greg Kroah-Hartman wrote: > On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote: > > > So we do have an open-source library called hl-thunk, which uses our > > > driver and indeed that was part of the requirement. > >

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 03:31:51PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 3:19 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 03:07:19PM +0300, Oded Gabbay wrote: > > > On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > > > &

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 03:07:19PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 3:03 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > > > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > &

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 02:56:09PM +0300, Oded Gabbay wrote: > On Fri, Sep 18, 2020 at 2:52 PM Leon Romanovsky wrote: > > > > On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > > > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > > > On Tue, Se

Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver

2020-09-18 Thread Leon Romanovsky
On Fri, Sep 18, 2020 at 02:36:10PM +0300, Gal Pressman wrote: > On 17/09/2020 20:18, Jason Gunthorpe wrote: > > On Tue, Sep 15, 2020 at 11:46:58PM +0300, Oded Gabbay wrote: > >> infrastructure for communication between multiple accelerators. Same > >> as Nvidia uses NVlink, we use RDMA that we have

Re: [PATCH v3 -next] vdpa: mlx5: change Kconfig depends to fix build errors

2020-09-18 Thread Leon Romanovsky
function `mlx5_vdpa_handle_set_map': > mr.c:(.text+0xf1d): undefined reference to `vhost_iotlb_itree_first' > > Signed-off-by: Randy Dunlap > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: virtualizat...@lists.linux-foundation.org > Cc: Saeed Mahameed >

Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters()

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 02:24:51PM -0300, Jason Gunthorpe wrote: > On Thu, Sep 17, 2020 at 08:05:11PM +0300, Leon Romanovsky wrote: > > On Thu, Sep 17, 2020 at 09:38:06AM -0300, Jason Gunthorpe wrote: > > > On Thu, Sep 17, 2020 at 12:08:10PM +0300, Leon Romanovsky wrote: >

Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters()

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 09:38:06AM -0300, Jason Gunthorpe wrote: > On Thu, Sep 17, 2020 at 12:08:10PM +0300, Leon Romanovsky wrote: > > On Thu, Sep 17, 2020 at 05:10:08PM +0800, Liu Shixin wrote: > > > sizeof() when applied to a pointer typed expression should give the > &g

[PATCH rdma-next v1 0/4] Improve ODP by using HMM API

2020-09-17 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Cleaned code. * Support a potential valid dma_address of NULL by flags detection, note was added to clarify things as was asked. * Fix 80 character lines in few places. v0: https://lore.kernel.org/lkml/20200914113949.346562-1-l...@kernel.org Based on

Re: [PATCH -next v2] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters()

2020-09-17 Thread Leon Romanovsky
t; 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Acked-by: Leon Romanovsky

Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters()

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 05:10:08PM +0800, Liu Shixin wrote: > sizeof() when applied to a pointer typed expression should give the > size of the pointed data, even if the data is a pointer. > > Signed-off-by: Liu Shixin > --- > drivers/infiniband/hw/mlx5/counters.c | 4 ++-- > 1 file changed, 2 in

Re: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters()

2020-09-17 Thread Leon Romanovsky
nters.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Thanks, Acked-by: Leon Romanovsky

Re: [PATCH] ptp: mark symbols static where possible

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 10:25:08AM +0800, Herrington wrote: > We get 1 warning when building kernel with W=1: > drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for > ‘pch_ch_control_read’ [-Wmissing-prototypes] > u32 pch_ch_control_read(struct pci_dev *pdev) > drivers/ptp/ptp_pch.c:19

Re: [PATCH net-next] net: stmmac: introduce rtnl_lock|unlock() on configuring real_num_rx|tx_queues

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 01:02:15PM +0800, Wong Vee Khee wrote: > From: "Tan, Tee Min" > > For driver open(), rtnl_lock is acquired by network stack but not in the > resume(). Therefore, we introduce lock_acquired boolean to control when > to use rtnl_lock|unlock() within stmmac_hw_setup(). Doesn'

Re: [PATCH rdma-next v1 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-16 Thread Leon Romanovsky
On Tue, Sep 15, 2020 at 06:23:39PM +0200, Christoph Hellwig wrote: > > +#ifndef CONFIG_ARCH_NO_SG_CHAIN > > +struct scatterlist *sg_alloc_table_append( > > + struct sg_table *sgt, struct page **pages, unsigned int n_pages, > > + unsigned int offset, unsigned long size, unsigned int max_segment,

Re: [PATCH rdma-next v1 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries

2020-09-16 Thread Leon Romanovsky
On Tue, Sep 15, 2020 at 06:19:26PM +0200, Christoph Hellwig wrote: > > + /* We decrease one since the prvious last sge in used to > > +* chainning. > > +*/ > > The normal style would be: It is netdev style of formatting, will change. > >

Re: [PATCH rdma-next v1 1/4] lib/scatterlist: Refactor sg_alloc_table_from_pages

2020-09-16 Thread Leon Romanovsky
On Tue, Sep 15, 2020 at 06:16:43PM +0200, Christoph Hellwig wrote: > On Thu, Sep 10, 2020 at 04:42:56PM +0300, Leon Romanovsky wrote: > > From: Maor Gottlieb > > > > Currently, sg_alloc_table_from_pages doesn't support dynamic chaining of > > SG entries. Th

Re: [PATCH] IB/rxe: fix kconfig dependency warning for RDMA_RXE

2020-09-15 Thread Leon Romanovsky
On Tue, Sep 15, 2020 at 01:16:00PM +0300, Necip Fazil Yildiran wrote: > When RDMA_RXE is enabled and CRYPTO is disabled, it results in the > following Kbuild warning: > > WARNING: unmet direct dependencies detected for CRYPTO_CRC32 > Depends on [n]: CRYPTO [=n] > Selected by [y]: > - RDMA_RXE

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2020-09-15 Thread Leon Romanovsky
On Mon, Sep 14, 2020 at 05:15:15PM -0400, Peter Xu wrote: > On Mon, Sep 14, 2020 at 02:34:36PM -0400, Peter Xu wrote: > > On Mon, Sep 14, 2020 at 10:32:11AM -0700, Linus Torvalds wrote: > > > On Mon, Sep 14, 2020 at 7:38 AM Jason Gunthorpe wrote: > > > > > > > > I don't have a detailed explanation

[PATCH] MAINTAINERS: Fix Max's and Shravan's emails

2020-09-15 Thread Leon Romanovsky
From: Leon Romanovsky Max's and Shravan's usernames were changed while @mellanox.com emails were transferred to be @nvidia.com. Fixes: f6da70d99c96 ("MAINTAINERS: Update Mellanox and Cumulus Network addresses to new domain") Signed-off-by: Leon Romanovsky --- MAINTAIN

[PATCH rdma-next 0/4] Improve ODP by using HMM API

2020-09-14 Thread Leon Romanovsky
From: Leon Romanovsky Based on: https://lore.kernel.org/lkml/20200914112653.345244-1-l...@kernel.org/ --- >From Yishai: This series improves ODP performance by moving to use the HMM API as of below.

[PATCH rdma-next 0/5] Reorganize mlx5 UMR creation flow

2020-09-14 Thread Leon Romanovsky
From: Leon Romanovsky This flow has become crufty and confusing. Revise it so that the rules on how UMR is used with MRs is much clearer and more correct. Fixes a few minor bugs in ODP and rereg_mr where disallowed things were not properly blocked. Thanks Jason Gunthorpe (5): RDMA/mlx5

[PATCH rdma-next v1 0/4] Query GID table API

2020-09-14 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Moved git_type logic to cma_set_default_gid_type - Patch #2 * Changed signature of rdma_query_gid_table - Patch #3 * Changed i to be unsigned - Patch #3 * Fixed multiplication overflow - Patch #4 v0: https://lore.kernel.org/lkml/20200910142204.1309061-1

[PATCH rdma-next] overflow: Include header file with SIZE_MAX declaration

2020-09-13 Thread Leon Romanovsky
From: Leon Romanovsky The various array_size functions use SIZE_MAX define, but missed limits.h causes to failure to compile code that needs overflow.h. In file included from drivers/infiniband/core/uverbs_std_types_device.c:6: ./include/linux/overflow.h: In function 'array_size':

Re: [PATCH] net: dl2k: switch from 'pci_' to 'dma_' API

2020-09-12 Thread Leon Romanovsky
On Sun, Sep 13, 2020 at 08:14:17AM +0200, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

[PATCH rdma-next v1 0/4] scatterlist: add sg_alloc_table_append function

2020-09-10 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Changed _sg_chain to be __sg_chain * Added dependency on ARCH_NO_SG_CHAIN * Removed struct sg_append v0: * https://lore.kernel.org/lkml/20200903121853.1145976-1-l...@kernel.org

[PATCH rdma-next v1 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries

2020-09-10 Thread Leon Romanovsky
. * Add a function to chain SGE to the next page. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/scatterlist.h | 29 ++ lib/scatterlist.c | 110 2 files changed, 91 insertions(+), 48 deletions(-) diff --git a

[PATCH rdma-next v1 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-10 Thread Leon Romanovsky
600.0MB After512001.2MB Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/Kconfig | 1 + drivers/infiniband/core/umem.c | 90 +- 2 files changed, 12 insertions(+), 79 deletions(-) diff --git a

[PATCH rdma-next v1 1/4] lib/scatterlist: Refactor sg_alloc_table_from_pages

2020-09-10 Thread Leon Romanovsky
more SGEs. Since sg_alloc_table_from_pages allocate exactly the number of chunks, therefore chunks are equal to the number of SG entries. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- lib/scatterlist.c | 75 --- 1 file change

[PATCH rdma-next 0/4] Query GID table API

2020-09-10 Thread Leon Romanovsky
From: Leon Romanovsky >From Avihai, When an application is not using RDMA CM and if it is using multiple RDMA devices with one or more RoCE ports, finding the right GID table entry is a long process. For example, with two RoCE dual-port devices in a system, when IP failover is used between

[PATCH rdma-next 00/10] Prepare drivers to move QP allocation to ib_core

2020-09-10 Thread Leon Romanovsky
From: Leon Romanovsky Hi, This series mainly changes mlx4, mlx5, and mthca drivers to future change of QP allocation scheme. The rdmavt driver will be sent separately. Thanks Leon Romanovsky (10): RDMA/mlx5: Embed GSI QP into general mlx5_ib QP RDMA/mlx5: Reuse existing fields in parent

Re: [PATCH -rc v1] gcov: Disable gcov build with GCC 10

2020-09-10 Thread Leon Romanovsky
On Thu, Sep 10, 2020 at 02:52:01PM +0200, Peter Oberparleiter wrote: > On 04.09.2020 17:58, Leon Romanovsky wrote: > > GCOV built with GCC 10 doesn't initialize n_function variable. > > This produces different kernel panics as was seen by Colin in > > Ubuntu [1] and me

[PATCH rdma-next v1 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-10 Thread Leon Romanovsky
with the Infiniband driver that allocates a single page for hold the pages. For 1TB memory registration, the temporary buffer would consume only 4KB, instead of 2GB. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/scatterlist.h | 6 ++ lib/scatterlist.c

Re: [PATCH rdma-next v2 0/9] Restore failure of destroy commands

2020-09-10 Thread Leon Romanovsky
On Wed, Sep 09, 2020 at 03:06:07PM -0300, Jason Gunthorpe wrote: > On Mon, Sep 07, 2020 at 03:09:12PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog: > > v2: > > * Rebased on top of the 524d8ffd07f0 > > * Removed "

[PATCH rdma-next v2 0/9] Restore failure of destroy commands

2020-09-07 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * Rebased on top of the 524d8ffd07f0 * Removed "udata" check in destroy flows * Changed ib_free_cq to return early * Used Jason's suggestion to implement "RDMA/mlx5: Issue FW command to destroy SRQ on reentry" patch. v1 *

[PATCH rdma-next v2 00/14] Track memory allocation with restrack DB help

2020-09-07 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * Added new patch to fix mlx4 failure on SR-IOV, it didn't have port set. * Changed "RDMA/cma: Delete from restrack DB after successful destroy" patch. v1: * Fixed rebase error, deleted second assignment of qp_type. * Rebased code on la

Re: [PATCH -next] RDMA/bnxt_re: Remove set but not used variable 'qplib_ctx'

2020-09-06 Thread Leon Romanovsky
t; 1 file changed, 2 deletions(-) The patch is for rdma-rc and not for rdma-next. Fixes: f86b31c6a28f ("RDMA/bnxt_re: Static NQ depth allocation") Thanks, Reviewed-by: Leon Romanovsky

[PATCH -rc v1] gcov: Disable gcov build with GCC 10

2020-09-04 Thread Leon Romanovsky
From: Leon Romanovsky GCOV built with GCC 10 doesn't initialize n_function variable. This produces different kernel panics as was seen by Colin in Ubuntu [1] and me in FC 32 [2]. As a workaround, let's disable GCOV build for broken GCC 10 version. [1] https://bugs.launchpad.net/ubun

Re: [PATCH rdma-next 0/4] scatterlist: add sg_alloc_table_append function

2020-09-03 Thread Leon Romanovsky
On Thu, Sep 03, 2020 at 05:32:17PM +0200, Christoph Hellwig wrote: > Patch 1 never made it through. Thanks, I sent it now and the patch is seen in ML. https://lore.kernel.org/linux-rdma/20200903153217.ga21...@lst.de/T/#t

[PATCH rdma-next 1/4] lib/scatterlist: Refactor sg_alloc_table_from_pages

2020-09-03 Thread Leon Romanovsky
more SGEs. Since sg_alloc_table_from_pages allocate exactly the number of chunks, therefore chunks are equal to the number of SG entries. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- lib/scatterlist.c | 75 --- 1 file change

[PATCH rdma-next 0/4] scatterlist: add sg_alloc_table_append function

2020-09-03 Thread Leon Romanovsky
From: Leon Romanovsky >From Maor: This series adds a new constructor for a scatter gather table. Like sg_alloc_table_from_pages function, this function merges all contiguous chunks of the pages a into single scatter gather entry. In contrast to sg_alloc_table_from_pages, the new API all

[PATCH rdma-next 3/4] lib/scatterlist: Add support in dynamic allocation of SG table from pages

2020-09-03 Thread Leon Romanovsky
with the Infiniband driver that allocates a single page for hold the pages. For 1TB memory registration, the temporary buffer would consume only 4KB, instead of 2GB. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/scatterlist.h | 10 +++ lib/scatterl

[PATCH rdma-next 2/4] lib/scatterlist: Add support in dynamically allocation of SG entries

2020-09-03 Thread Leon Romanovsky
. * Add a function to chain SGE to the next page. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/scatterlist.h | 29 ++ lib/scatterlist.c | 110 2 files changed, 91 insertions(+), 48 deletions(-) diff --git a

[PATCH rdma-next 4/4] RDMA/umem: Move to allocate SG table from pages

2020-09-03 Thread Leon Romanovsky
600.0MB After512001.2MB Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/umem.c | 93 +- 1 file changed, 14 insertions(+), 79 deletions(-) diff --git a/drivers/infiniband/core/umem.c b/drivers

<    1   2   3   4   5   6   7   8   9   10   >