Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Mon, Dec 18, 2017 at 01:36:26PM +0100, Knut Omang wrote: > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > > Add a runchecks.cfg to drivers/infiniband/core > > > to start "r

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Mon, Dec 18, 2017 at 01:36:26PM +0100, Knut Omang wrote: > On Mon, 2017-12-18 at 10:02 +0200, Leon Romanovsky wrote: > > On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > > > Add a runchecks.cfg to drivers/infiniband/core > > > to start "r

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > Add a runchecks.cfg to drivers/infiniband/core > to start "reining in" future checker errors, > and making it easier to selectively clean up existing > issues. > > This runchecks.cfg lets make C=2 M=drivers/infiniband/core > pass with

Re: [PATCH v2 5/5] RDMA/core: Add runchecks.cfg for drivers/infiniband/core

On Sat, Dec 16, 2017 at 03:42:30PM +0100, Knut Omang wrote: > Add a runchecks.cfg to drivers/infiniband/core > to start "reining in" future checker errors, > and making it easier to selectively clean up existing > issues. > > This runchecks.cfg lets make C=2 M=drivers/infiniband/core > pass with

Re: [PATCH] iw_cxgb4: make pointer reg_workq static

and/hw/cxgb4/device.c:69:25: warning: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > --- > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tha

Re: [PATCH] iw_cxgb4: make pointer reg_workq static

ng: symbol 'reg_workq' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On Tue, Nov 28, 2017 at 06:50:44PM +, Bart Van Assche wrote: > On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote: > > On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: > > > I could resubmit just the series, or you could just pick the 4 driver > > > patches from

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On Tue, Nov 28, 2017 at 06:50:44PM +, Bart Van Assche wrote: > On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote: > > On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: > > > I could resubmit just the series, or you could just pick the 4 driver > > > patches from

Re: [PATCH] IB/core: Use PTR_ERR_OR_ZERO()

cripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych <gomonov...@gmail.com> > --- > drivers/infiniband/core/uverbs_cmd.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] IB/core: Use PTR_ERR_OR_ZERO()

cripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Vasyl Gomonovych > --- > drivers/infiniband/core/uverbs_cmd.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On Mon, Nov 27, 2017 at 11:36:37AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote: > > This patch-set introduces three patches to fix about the memory > > related issues. > > If these patches are for-rc can you revise the commit message to more >

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On Mon, Nov 27, 2017 at 11:36:37AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote: > > This patch-set introduces three patches to fix about the memory > > related issues. > > If these patches are for-rc can you revise the commit message to more >

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Tue, Nov 21, 2017 at 07:04:56AM +0200, Leon Romanovsky wrote: > On Mon, Nov 20, 2017 at 11:06:31AM -0700, Jason Gunthorpe wrote: > > On Mon, Nov 20, 2017 at 06:10:16PM +0200, Leon Romanovsky wrote: > > > On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > &

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Tue, Nov 21, 2017 at 07:04:56AM +0200, Leon Romanovsky wrote: > On Mon, Nov 20, 2017 at 11:06:31AM -0700, Jason Gunthorpe wrote: > > On Mon, Nov 20, 2017 at 06:10:16PM +0200, Leon Romanovsky wrote: > > > On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > &

Re: [PATCH] IB: INFINIBAND should depend on HAS_DMA

plicit dependency on HAS_DMA to fix this. > > Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's > KConfigs") > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> > --- > drivers/infiniband/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] IB: INFINIBAND should depend on HAS_DMA

plicit dependency on HAS_DMA to fix this. > > Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's > KConfigs") > Signed-off-by: Geert Uytterhoeven > --- > drivers/infiniband/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Mon, Nov 20, 2017 at 11:06:31AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 20, 2017 at 06:10:16PM +0200, Leon Romanovsky wrote: > > On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > > > As was discussed in September and October, add Jason along with > &g

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Mon, Nov 20, 2017 at 11:06:31AM -0700, Jason Gunthorpe wrote: > On Mon, Nov 20, 2017 at 06:10:16PM +0200, Leon Romanovsky wrote: > > On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > > > As was discussed in September and October, add Jason along with > &g

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > As was discussed in September and October, add Jason along with > Doug to have a team maintainership model for the RDMA subystem. > > Mellanox Technologies will be funding Jason's independent work on > the maintainership. > >

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > As was discussed in September and October, add Jason along with > Doug to have a team maintainership model for the RDMA subystem. > > Mellanox Technologies will be funding Jason's independent work on > the maintainership. > >

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Fri, Nov 17, 2017 at 08:44:27PM -0500, Doug Ledford wrote: > > If you split step 5 above into 5a) Push from local work repo to local > prep repo and 5b) Do full kernel build in prep repo to test that all > code needed to compile is tracked by git, it would catch that mistake > before it makes

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Fri, Nov 17, 2017 at 08:44:27PM -0500, Doug Ledford wrote: > > If you split step 5 above into 5a) Push from local work repo to local > prep repo and 5b) Do full kernel build in prep repo to test that all > code needed to compile is tracked by git, it would catch that mistake > before it makes

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > As was discussed in September and October, add Jason along with > Doug to have a team maintainership model for the RDMA subystem. > > Mellanox Technologies will be funding Jason's independent work on > the maintainership. > >

Re: [PATCH] rdma: Add Jason as a co-maintainer

On Thu, Nov 16, 2017 at 01:44:00PM -0700, Jason Gunthorpe wrote: > As was discussed in September and October, add Jason along with > Doug to have a team maintainership model for the RDMA subystem. > > Mellanox Technologies will be funding Jason's independent work on > the maintainership. > >

Re: [PATCH/RFC] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()

On Thu, Nov 16, 2017 at 11:50:48AM +0100, Arnd Bergmann wrote: > On Thu, Nov 16, 2017 at 11:26 AM, Geert Uytterhoeven > wrote: > > With gcc-4.1.2: > > > > drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’: > >

Re: [PATCH/RFC] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()

On Thu, Nov 16, 2017 at 11:50:48AM +0100, Arnd Bergmann wrote: > On Thu, Nov 16, 2017 at 11:26 AM, Geert Uytterhoeven > wrote: > > With gcc-4.1.2: > > > > drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’: > > drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may

Re: [PATCH] infiniband: avoid uninitialized variable warning in create_udata

re/uverbs_std_types.c | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: PGP signature

Re: [PATCH] infiniband: avoid uninitialized variable warning in create_udata

; 1 file changed, 10 insertions(+), 11 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Wed, Nov 08, 2017 at 02:16:25PM -0600, Gustavo A. R. Silva wrote: > > Quoting Leon Romanovsky <l...@kernel.org>: > > > On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote: > > > > > > Quoting Leon Romanovsky <l...@kernel.org>: >

Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Wed, Nov 08, 2017 at 02:16:25PM -0600, Gustavo A. R. Silva wrote: > > Quoting Leon Romanovsky : > > > On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote: > > > > > > Quoting Leon Romanovsky : > > > > > > > On Tue, Nov 0

Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote: > > Quoting Leon Romanovsky <l...@kernel.org>: > > > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are unnecessary. >

Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote: > > Quoting Leon Romanovsky : > > > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are unnecessary. > > > > > > A

Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

cle.com> > --- > Changes in v2: > Remove assignment from "int status = -ENOMEM" as suggested by Leon > Romanovsky. > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Please use git send-email to send pa

Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

ignment from "int status = -ENOMEM" as suggested by Leon > Romanovsky. > > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Please use git send-email to send patches and not reply to the conversation. Thanks, Reviewed-by

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Tue, Nov 07, 2017 at 08:30:22AM -0600, Gustavo A. R. Silva wrote: > Hi Leon, > > Quoting Leon Romanovsky <l...@kernel.org>: > > > On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are u

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Tue, Nov 07, 2017 at 08:30:22AM -0600, Gustavo A. R. Silva wrote: > Hi Leon, > > Quoting Leon Romanovsky : > > > On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > > > Check on return value and goto label mbx_err are unnecessary. > > >

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > Check on return value and goto label mbx_err are unnecessary. > > Addresses-Coverity-ID: 1268780 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- > 1

Re: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

On Mon, Nov 06, 2017 at 08:35:14AM -0600, Gustavo A. R. Silva wrote: > Check on return value and goto label mbx_err are unnecessary. > > Addresses-Coverity-ID: 1268780 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- > 1 file changed, 1

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Tue, Nov 07, 2017 at 10:45:29AM +0800, Wei Hu (Xavier) wrote: > > > On 2017/11/1 20:26, Robin Murphy wrote: > > On 01/11/17 07:46, Wei Hu (Xavier) wrote: > >> > >> On 2017/10/12 20:59, Robin Murphy wrote: > >>> On 12/10/17 13:31, Wei Hu (Xavier) wro

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Tue, Nov 07, 2017 at 10:45:29AM +0800, Wei Hu (Xavier) wrote: > > > On 2017/11/1 20:26, Robin Murphy wrote: > > On 01/11/17 07:46, Wei Hu (Xavier) wrote: > >> > >> On 2017/10/12 20:59, Robin Murphy wrote: > >>> On 12/10/17 13:31, Wei Hu (Xavier) wro

Re: [PATCH v2] IB/rxe: don't crash, if allocation of crc algorithm failed

m = crypto_alloc_shash("crc32", 0, 0); > - if (IS_ERR(rxe->tfm)) { > + tfm = crypto_alloc_shash("crc32", 0, 0); > + if (IS_ERR(tfm)) { > pr_err("failed to allocate crc algorithm err:%ld\n", > - PTR_

Re: [PATCH v2] IB/rxe: don't crash, if allocation of crc algorithm failed

("crc32", 0, 0); > - if (IS_ERR(rxe->tfm)) { > + tfm = crypto_alloc_shash("crc32", 0, 0); > + if (IS_ERR(tfm)) { > pr_err("failed to allocate crc algorithm err:%ld\n", > - PTR_ERR(rxe->tfm)); > - return PTR_ERR(rxe->tfm); > +PTR_ERR(tfm)); > + return PTR_ERR(tfm); > } > + rxe->tfm = tfm; Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Mon, Oct 30, 2017 at 09:04:36AM +0100, SF Markus Elfring wrote: > >>> I mean you aren't really making the code any smaller > >> > >> Would anybody like to check corresponding effects in more detail > >> after a specific function call was replaced by a goto statement? > > > > You are supposed to

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Mon, Oct 30, 2017 at 09:04:36AM +0100, SF Markus Elfring wrote: > >>> I mean you aren't really making the code any smaller > >> > >> Would anybody like to check corresponding effects in more detail > >> after a specific function call was replaced by a goto statement? > > > > You are supposed to

Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

On Sun, Oct 29, 2017 at 10:20:18AM +0300, Moni Shoua wrote: > On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer > wrote: > > Following crash happens, if crc algorithm couldn't be allocated: > > > > [ 1087.989072] rdma_rxe: loaded > > [ 1097.855397] PCLMULQDQ-NI

Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

On Sun, Oct 29, 2017 at 10:20:18AM +0300, Moni Shoua wrote: > On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer > wrote: > > Following crash happens, if crc algorithm couldn't be allocated: > > > > [ 1087.989072] rdma_rxe: loaded > > [ 1097.855397] PCLMULQDQ-NI instructions are not detected. >

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Thu, Oct 26, 2017 at 08:33:39PM -0400, Dennis Dalessandro wrote: > On 10/26/2017 12:12 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > > > Add a jump target so that a bit of exception handling can be better

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Thu, Oct 26, 2017 at 08:33:39PM -0400, Dennis Dalessandro wrote: > On 10/26/2017 12:12 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > > > Add a jump target so that a bit of exception handling can be better reused > > at the end of this

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Thu, Oct 26, 2017 at 06:12:31PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Thu, Oct 26, 2017 at 06:12:31PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Fri, Oct 27, 2017 at 09:34:18AM +0200, SF Markus Elfring wrote: > >> Add a jump target so that a bit of exception handling can be better reused > >> at the end of this function. > > > > I'm not sure this is that big of a win. > > Such a view is appropriate because I proposed just another small

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On Fri, Oct 27, 2017 at 09:34:18AM +0200, SF Markus Elfring wrote: > >> Add a jump target so that a bit of exception handling can be better reused > >> at the end of this function. > > > > I'm not sure this is that big of a win. > > Such a view is appropriate because I proposed just another small

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On Fri, Oct 27, 2017 at 02:30:11PM +0200, Thomas Bogendoerfer wrote: > If there is no SFP module plugged into a port of mlx5 cards > 'cat /sys/class/infniband/mlx5_X/ports/1/rate' returns Invalid argument. > This causes tools like 'ibstat' to malfunction. This change adjusts mlx5 > to all other

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

On Fri, Oct 27, 2017 at 02:30:11PM +0200, Thomas Bogendoerfer wrote: > If there is no SFP module plugged into a port of mlx5 cards > 'cat /sys/class/infniband/mlx5_X/ports/1/rate' returns Invalid argument. > This causes tools like 'ibstat' to malfunction. This change adjusts mlx5 > to all other

Re: [PATCH v2] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, Oct 16, 2017 at 09:26:36PM +, Bart Van Assche wrote: > On Mon, 2017-10-16 at 22:57 +0300, Michael S. Tsirkin wrote: > > On Mon, Oct 16, 2017 at 10:26:33AM -0700, Bart Van Assche wrote: <...> > > > > Examples are drivers/scsi/qla2xxx and drivers/infiniband/hw/nes. > > > > These seem

Re: [PATCH v2] linux/types.h: Restore the ability to disable sparse endianness checks

On Mon, Oct 16, 2017 at 09:26:36PM +, Bart Van Assche wrote: > On Mon, 2017-10-16 at 22:57 +0300, Michael S. Tsirkin wrote: > > On Mon, Oct 16, 2017 at 10:26:33AM -0700, Bart Van Assche wrote: <...> > > > > Examples are drivers/scsi/qla2xxx and drivers/infiniband/hw/nes. > > > > These seem

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Wed, Oct 18, 2017 at 05:12:02PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/10/18 16:42, Wei Hu (Xavier) wrote: > > > > > > On 2017/10/1 0:10, Leon Romanovsky wrote: > > > On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: > > > > If

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Wed, Oct 18, 2017 at 05:12:02PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/10/18 16:42, Wei Hu (Xavier) wrote: > > > > > > On 2017/10/1 0:10, Leon Romanovsky wrote: > > > On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: > > > > If

Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const

-by: Bhumika Goyal <bhumi...@gmail.com> > --- > * Changes in v2- Combine all the followup patches and the constification > patches into a series. > > drivers/infiniband/core/cma_configfs.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: L

Re: [PATCH v2 12/15] RDMA/cma: make config_item_type const

ned-off-by: Bhumika Goyal > --- > * Changes in v2- Combine all the followup patches and the constification > patches into a series. > > drivers/infiniband/core/cma_configfs.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky signature.asc Description: PGP signature

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Thu, Oct 12, 2017 at 08:31:31PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/10/1 0:10, Leon Romanovsky wrote: > > On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: > > > If the IOMMU is enabled, the length of sg obtained from > > > __iommu_map_s

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Thu, Oct 12, 2017 at 08:31:31PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/10/1 0:10, Leon Romanovsky wrote: > > On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: > > > If the IOMMU is enabled, the length of sg obtained from > > > __iommu_map_s

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On Wed, Oct 11, 2017 at 01:13:26PM -0400, Dennis Dalessandro wrote: > On 10/11/2017 11:49 AM, Leon Romanovsky wrote: > > On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote: > > > On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: > > > > Provide informa

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On Wed, Oct 11, 2017 at 01:13:26PM -0400, Dennis Dalessandro wrote: > On 10/11/2017 11:49 AM, Leon Romanovsky wrote: > > On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote: > > > On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: > > > > Provide informa

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote: > On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: > > Provide information about used firmware files via modinfo. > > > > Signed-off-by: Thomas Bogendoerfer > > --- > >

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote: > On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: > > Provide information about used firmware files via modinfo. > > > > Signed-off-by: Thomas Bogendoerfer > > --- > > drivers/infiniband/hw/hfi1/firmware.c | 5 + > > 1

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Mon, Oct 09, 2017 at 09:16:35AM -0400, Doug Ledford wrote: > On Tue, 2017-09-12 at 17:48 +0300, Leon Romanovsky wrote: > > On Sat, Sep 09, 2017 at 03:56:07PM +0300, Leon Romanovsky wrote: > > > On Fri, Sep 08, 2017 at 03:37:45PM +0100, Colin King wrote: > > > >

Re: [PATCH] IB/rxe: check for allocation failure on elem

On Mon, Oct 09, 2017 at 09:16:35AM -0400, Doug Ledford wrote: > On Tue, 2017-09-12 at 17:48 +0300, Leon Romanovsky wrote: > > On Sat, Sep 09, 2017 at 03:56:07PM +0300, Leon Romanovsky wrote: > > > On Fri, Sep 08, 2017 at 03:37:45PM +0100, Colin King wrote: > >

Re: [PATCH 10/12] net/mlx4: replace with

On Mon, Oct 09, 2017 at 02:56:56PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:55 GMT+09:00 Leon Romanovsky <l...@kernel.org>: > > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > >> 2017-10-09 2:00 GMT+09:00 David Miller <da...@davemloft.net>

Re: [PATCH 10/12] net/mlx4: replace with

On Mon, Oct 09, 2017 at 02:56:56PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:55 GMT+09:00 Leon Romanovsky : > > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > >> 2017-10-09 2:00 GMT+09:00 David Miller : > >> > From: Masahiro Yamada > >

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

On Mon, Oct 09, 2017 at 02:58:58PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:52 GMT+09:00 Leon Romanovsky <leo...@mellanox.com>: > > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > > > <...> > >> > >> By splitting out

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

On Mon, Oct 09, 2017 at 02:58:58PM +0900, Masahiro Yamada wrote: > 2017-10-09 3:52 GMT+09:00 Leon Romanovsky : > > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > > > <...> > >> > >> By splitting out the radix_tree_root definition,

Re: [PATCH 10/12] net/mlx4: replace with

On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > 2017-10-09 2:00 GMT+09:00 David Miller : > > From: Masahiro Yamada > > Date: Mon, 9 Oct 2017 01:10:11 +0900 > > > >> The headers > >> - include/linux/mlx4/device.h > >> -

Re: [PATCH 10/12] net/mlx4: replace with

On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote: > 2017-10-09 2:00 GMT+09:00 David Miller : > > From: Masahiro Yamada > > Date: Mon, 9 Oct 2017 01:10:11 +0900 > > > >> The headers > >> - include/linux/mlx4/device.h > >> - drivers/net/ethernet/mellanox/mlx4/mlx4.h > >> require

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: <...> > > By splitting out the radix_tree_root definition, > we can reduce the header file dependency. > > Reducing the header dependency will help for speeding the kernel > build, suppressing unnecessary recompile of objects during

Re: [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: <...> > > By splitting out the radix_tree_root definition, > we can reduce the header file dependency. > > Reducing the header dependency will help for speeding the kernel > build, suppressing unnecessary recompile of objects during

Re: [PATCH] IB/ipoib: Convert timers to use timer_setup()

ledf...@redhat.com> > Cc: Sean Hefty <sean.he...@intel.com> > Cc: Hal Rosenstock <hal.rosenst...@gmail.com> > Cc: Leon Romanovsky <l...@kernel.org> > Cc: Alex Vesker <va...@mellanox.com> > Cc: Erez Shitrit <ere...@mellanox.com> > Cc:

Re: [PATCH] IB/ipoib: Convert timers to use timer_setup()

gt; Cc: Sean Hefty > Cc: Hal Rosenstock > Cc: Leon Romanovsky > Cc: Alex Vesker > Cc: Erez Shitrit > Cc: Zhu Yanjun > Cc: Dasaratharaman Chandramouli > Cc: Paolo Abeni > Cc: Ira Weiny > Cc: Yuval Shaia > Cc: linux-r...@vger.kernel.org > Cc: Thomas Gleixner

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

On Wed, Oct 04, 2017 at 05:51:54PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Tariq Toukan

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

On Wed, Oct 04, 2017 at 05:51:54PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Tariq Toukan > Cc:

Re: [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE

On Sun, Oct 01, 2017 at 03:30:42PM -0400, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) >

Re: [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE

On Sun, Oct 01, 2017 at 03:30:42PM -0400, Jérémy Lefaure wrote: > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) >

Re: [PATCH for-next 3/4] RDMA/hns: Update the IRRL table chunk size in hip08

On Sat, Sep 30, 2017 at 05:29:00PM +0800, Wei Hu (Xavier) wrote: > As the increase of the IRRL specification in hip08, the IRRL table > chunk size needs to be updated. > This patch updates the IRRL table chunk size to 256k for hip08. > > Signed-off-by: Wei Hu (Xavier) >

Re: [PATCH for-next 3/4] RDMA/hns: Update the IRRL table chunk size in hip08

On Sat, Sep 30, 2017 at 05:29:00PM +0800, Wei Hu (Xavier) wrote: > As the increase of the IRRL specification in hip08, the IRRL table > chunk size needs to be updated. > This patch updates the IRRL table chunk size to 256k for hip08. > > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Shaobo Xu

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: > If the IOMMU is enabled, the length of sg obtained from > __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg > dma address, the IOVA will not be page continuous. and the VA > returned from dma_alloc_coherent is a

Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote: > If the IOMMU is enabled, the length of sg obtained from > __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg > dma address, the IOVA will not be page continuous. and the VA > returned from dma_alloc_coherent is a

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On Fri, Sep 29, 2017 at 02:07:22PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 20:59, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: > > > > > > On 2017/9/28 17:13, Leon Romanovsky wrote: > > > > On

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On Fri, Sep 29, 2017 at 02:07:22PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 20:59, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: > > > > > > On 2017/9/28 17:13, Leon Romanovsky wrote: > > > > On

Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function

On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > It mainly places the lines for checking send doorbell status > into a special functions. As a result, we can directly call it in > check_qp_db_process_status function and keep consistent

Re: [PATCH for-next 2/9] RDMA/hns: Factor out the code for checking sdb status into a new function

On Thu, Sep 28, 2017 at 12:57:27PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > It mainly places the lines for checking send doorbell status > into a special functions. As a result, we can directly call it in > check_qp_db_process_status function and keep consistent indenting > style. > >

Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

On Thu, Sep 28, 2017 at 07:56:40PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 17:02, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: > > > From: Lijun Ou <ouli...@huawei.com> > > > > > > This

Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

On Thu, Sep 28, 2017 at 07:56:40PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 17:02, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: > > > From: Lijun Ou > > > > > > This patch

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 17:13, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: > > > From: Lijun Ou <ouli...@huawei.com> > > > > > > When

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 17:13, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: > > > From: Lijun Ou > > > > > > When lp_qp_work is NULL, it should b

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > When lp_qp_work is NULL, it should be returned ENOMEM. This patch > mainly fixes it. > > Ihis patch fixes the smatch error as below: > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:918

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > When lp_qp_work is NULL, it should be returned ENOMEM. This patch > mainly fixes it. > > Ihis patch fixes the smatch error as below: > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:918 hns_roce_v1_recreate_lp_qp()

Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > This patch mainly deletes some unused struct members for > hns_roce_ib_create_qp in order to match libhns, because > the num of struct members of hns_roce_ib_create_qp must > be the same with

Re: [PATCH for-next 8/9] RDMA/hns: Remove unused struct members in hns-abi.h

On Thu, Sep 28, 2017 at 12:57:33PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > This patch mainly deletes some unused struct members for > hns_roce_ib_create_qp in order to match libhns, because > the num of struct members of hns_roce_ib_create_qp must > be the same with hns_roce_create_qp

Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

On Wed, Sep 27, 2017 at 10:20:39AM -0400, Doug Ledford wrote: > On Tue, 2017-09-26 at 12:11 -0700, Joe Perches wrote: > > On Tue, 2017-09-26 at 18:50 +0300, Leon Romanovsky wrote: > > > So how can I reproduce the different output before and after this > > > change? &g

Re: [PATCH] IB/mlx5:: pr_err() and mlx5_ib_dbg() strings should end with newlines

On Wed, Sep 27, 2017 at 10:20:39AM -0400, Doug Ledford wrote: > On Tue, 2017-09-26 at 12:11 -0700, Joe Perches wrote: > > On Tue, 2017-09-26 at 18:50 +0300, Leon Romanovsky wrote: > > > So how can I reproduce the different output before and after this > > > change? &g

<    4   5   6   7   8   9   10   11   12   13   >