Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-02 Thread Leonard Crestez
iles for legacy devices, but I did not finish that > for this kernel cycle. > > Fixes: commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor > only") > Reported-by: Leonard Crestez > Reported-by: Fabio Estevam > Reported-by: John Stultz > Report

Re: [PATCH] regulator: fixed: Default enable high on DT regulators

2018-10-02 Thread Leonard Crestez
iles for legacy devices, but I did not finish that > for this kernel cycle. > > Fixes: commit efdfeb079cc3 ("regulator: fixed: Convert to use GPIO descriptor > only") > Reported-by: Leonard Crestez > Reported-by: Fabio Estevam > Reported-by: John Stultz > Report

[PATCH 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-01 Thread Leonard Crestez
orted) has the exact same PCIE_CTRL_APPS_TURNOFF bit in the same location. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-im

[PATCH 2/4] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d

2018-10-01 Thread Leonard Crestez
This is documented as "required" but won't be present in old dtbs. These resets are also present on other imx chips but right now only imx7d implements them through the reset controller subsystem. Signed-off-by: Leonard Crestez Acked-by: Rob Herring --- Documentation/devicetree/bi

[PATCH 4/4] PCI: imx: Add PME_Turn_Off support

2018-10-01 Thread Leonard Crestez
orted) has the exact same PCIE_CTRL_APPS_TURNOFF bit in the same location. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-im

[PATCH 2/4] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d

2018-10-01 Thread Leonard Crestez
This is documented as "required" but won't be present in old dtbs. These resets are also present on other imx chips but right now only imx7d implements them through the reset controller subsystem. Signed-off-by: Leonard Crestez Acked-by: Rob Herring --- Documentation/devicetree/bi

[PATCH 3/4] ARM: dts: imx7d: Add turnoff reset

2018-10-01 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez Acked-by: Shawn Guo --- arch/arm/boot/dts/imx7d.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index

[PATCH 0/4] PCI: imx: Add PME_Turn_Off support

2018-10-01 Thread Leonard Crestez
it touches multiple trees. Merging out of order should be fine. Some patches already carry acks for DT but somebody needs to ack the pci/reset parts. Leonard Crestez (4): reset: imx7: Add PCIE_CTRL_APPS_TURNOFF dt-bindings: imx6q-pcie: Add turnoff reset for imx7d ARM: dts: imx7d: Add tur

[PATCH 1/4] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-10-01 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez Acked-by: Rob Herring --- drivers/reset/reset-imx7.c | 1 + include/dt-bindings/reset/imx7-reset.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 3/4] ARM: dts: imx7d: Add turnoff reset

2018-10-01 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez Acked-by: Shawn Guo --- arch/arm/boot/dts/imx7d.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index

[PATCH 0/4] PCI: imx: Add PME_Turn_Off support

2018-10-01 Thread Leonard Crestez
it touches multiple trees. Merging out of order should be fine. Some patches already carry acks for DT but somebody needs to ack the pci/reset parts. Leonard Crestez (4): reset: imx7: Add PCIE_CTRL_APPS_TURNOFF dt-bindings: imx6q-pcie: Add turnoff reset for imx7d ARM: dts: imx7d: Add tur

[PATCH 1/4] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-10-01 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez Acked-by: Rob Herring --- drivers/reset/reset-imx7.c | 1 + include/dt-bindings/reset/imx7-reset.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-01 Thread Leonard Crestez
Hello, This patch seems to break network booting on imx6sx-sdb in linux-next because the enet phy regulator is not on. Reverting the patch fixes boot. Here is the regulator definition: reg_enet_3v3: regulator-enet-3v3 { compatible = "regulator-fixed"; pinctrl-names = "default";

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-01 Thread Leonard Crestez
Hello, This patch seems to break network booting on imx6sx-sdb in linux-next because the enet phy regulator is not on. Reverting the patch fixes boot. Here is the regulator definition: reg_enet_3v3: regulator-enet-3v3 { compatible = "regulator-fixed"; pinctrl-names = "default";

Re: [PATCH] serial: imx: restore handshaking irq for imx1

2018-09-20 Thread Leonard Crestez
Signed-off-by: Uwe Kleine-König Reviewed-by: Leonard Crestez I'm not sure if anyone has imx1 hardware handy can is willing to test this CTS/RTS but the fix is pretty obviously correct.

Re: [PATCH] serial: imx: restore handshaking irq for imx1

2018-09-20 Thread Leonard Crestez
Signed-off-by: Uwe Kleine-König Reviewed-by: Leonard Crestez I'm not sure if anyone has imx1 hardware handy can is willing to test this CTS/RTS but the fix is pretty obviously correct.

Re: [PATCH -next] serial: imx: remove set but not used variable 'rtsirq'

2018-09-20 Thread Leonard Crestez
On Thu, 2018-09-20 at 08:45 +0200, Jiri Slaby wrote: > On 09/20/2018, 03:58 AM, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/tty/serial/imx.c: In function 'imx_uart_probe': > > drivers/tty/serial/imx.c:2198:20: warning: > > variable 'rtsirq' set but not

Re: [PATCH -next] serial: imx: remove set but not used variable 'rtsirq'

2018-09-20 Thread Leonard Crestez
On Thu, 2018-09-20 at 08:45 +0200, Jiri Slaby wrote: > On 09/20/2018, 03:58 AM, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/tty/serial/imx.c: In function 'imx_uart_probe': > > drivers/tty/serial/imx.c:2198:20: warning: > > variable 'rtsirq' set but not

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Leonard Crestez
On Mon, 2018-09-17 at 17:52 +0100, Lorenzo Pieralisi wrote: > On Mon, Sep 17, 2018 at 04:01:21PM +0000, Leonard Crestez wrote: > > On Mon, 2018-09-17 at 16:09 +0100, Lorenzo Pieralisi wrote: > > > On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > > &g

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Leonard Crestez
On Mon, 2018-09-17 at 17:52 +0100, Lorenzo Pieralisi wrote: > On Mon, Sep 17, 2018 at 04:01:21PM +0000, Leonard Crestez wrote: > > On Mon, 2018-09-17 at 16:09 +0100, Lorenzo Pieralisi wrote: > > > On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > > &g

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Leonard Crestez
On Mon, 2018-09-17 at 16:09 +0100, Lorenzo Pieralisi wrote: > On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > > V4 adds 4 more patches with PME_Turn_Off support on top, using a new > > reset bit. I generally try to keep series short but in this case some >

Re: [PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-09-17 Thread Leonard Crestez
On Mon, 2018-09-17 at 16:09 +0100, Lorenzo Pieralisi wrote: > On Tue, Aug 14, 2018 at 07:50:14PM +0300, Leonard Crestez wrote: > > V4 adds 4 more patches with PME_Turn_Off support on top, using a new > > reset bit. I generally try to keep series short but in this case some >

Re: [RESEND] PCI: imx: Initial imx7d pm support

2018-09-03 Thread Leonard Crestez
On Tue, 2018-08-28 at 15:55 +0100, Lorenzo Pieralisi wrote: > On Tue, Aug 28, 2018 at 01:00:02PM +0000, Leonard Crestez wrote: > > On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote: > > > On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > > > &g

Re: [RESEND] PCI: imx: Initial imx7d pm support

2018-09-03 Thread Leonard Crestez
On Tue, 2018-08-28 at 15:55 +0100, Lorenzo Pieralisi wrote: > On Tue, Aug 28, 2018 at 01:00:02PM +0000, Leonard Crestez wrote: > > On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote: > > > On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > > > &g

Re: [RESEND] PCI: imx: Initial imx7d pm support

2018-08-28 Thread Leonard Crestez
On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote: > On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > make the system hang after resume when attempting any read from PC

Re: [RESEND] PCI: imx: Initial imx7d pm support

2018-08-28 Thread Leonard Crestez
On Tue, 2018-08-28 at 11:07 +0100, Lorenzo Pieralisi wrote: > On Mon, Aug 27, 2018 at 02:28:37PM +0300, Leonard Crestez wrote: > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > make the system hang after resume when attempting any read from PC

[PATCH] ARM: imx_v6_v7_defconfig: Make usbnet drivers builtin for boot

2018-08-27 Thread Leonard Crestez
supported by uboot. Signed-off-by: Leonard Crestez --- This is not a very pretty solution but very convenient. --- arch/arm/configs/imx_v6_v7_defconfig | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs

[PATCH] ARM: imx_v6_v7_defconfig: Make usbnet drivers builtin for boot

2018-08-27 Thread Leonard Crestez
supported by uboot. Signed-off-by: Leonard Crestez --- This is not a very pretty solution but very convenient. --- arch/arm/configs/imx_v6_v7_defconfig | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs

[RESEND] PCI: imx: Initial imx7d pm support

2018-08-27 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- drivers

[RESEND] PCI: imx: Initial imx7d pm support

2018-08-27 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- drivers

[PATCH v4 2/6] PCI: imx: Initial imx7d pm support

2018-08-14 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- drivers

[PATCH v4 2/6] PCI: imx: Initial imx7d pm support

2018-08-14 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- drivers

[PATCH v4 4/6] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d

2018-08-14 Thread Leonard Crestez
This is documented as "required" but won't be present in old dtbs. These resets are also present on other imx chips but right now only imx7d implements them through the reset controller subsystem. Signed-off-by: Leonard Crestez --- Documentation/devicetree/bindings/pci/fsl,imx6q-pc

[PATCH v4 4/6] dt-bindings: imx6q-pcie: Add turnoff reset for imx7d

2018-08-14 Thread Leonard Crestez
This is documented as "required" but won't be present in old dtbs. These resets are also present on other imx chips but right now only imx7d implements them through the reset controller subsystem. Signed-off-by: Leonard Crestez --- Documentation/devicetree/bindings/pci/fsl,imx6q-pc

[PATCH v4 3/6] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-08-14 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez --- drivers/reset/reset-imx7.c | 1 + include/dt-bindings/reset/imx7-reset.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/reset/reset-imx7.c b

[PATCH v4 3/6] reset: imx7: Add PCIE_CTRL_APPS_TURNOFF

2018-08-14 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez --- drivers/reset/reset-imx7.c | 1 + include/dt-bindings/reset/imx7-reset.h | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/reset/reset-imx7.c b

[PATCH v4 5/6] ARM: dts: imx7d: Add turnoff reset

2018-08-14 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx7d.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index 7234e8330a57

[PATCH v4 1/6] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-08-14 Thread Leonard Crestez
This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. That commit followed the reference manual but unfortunately the imx7d manual is incorrect. Tested with ath9k pcie card and confirmed internally. Signed-off-by: Leonard Crestez Acked-by: Lucas Stach --- arch/arm/boot/dts/imx7d.dtsi

[PATCH v4 6/6] PCI: imx: Add PME_Turn_Off support

2018-08-14 Thread Leonard Crestez
orted) has the exact same PCIE_CTRL_APPS_TURNOFF bit in the same location. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-im

[PATCH v4 1/6] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-08-14 Thread Leonard Crestez
This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. That commit followed the reference manual but unfortunately the imx7d manual is incorrect. Tested with ath9k pcie card and confirmed internally. Signed-off-by: Leonard Crestez Acked-by: Lucas Stach --- arch/arm/boot/dts/imx7d.dtsi

[PATCH v4 6/6] PCI: imx: Add PME_Turn_Off support

2018-08-14 Thread Leonard Crestez
orted) has the exact same PCIE_CTRL_APPS_TURNOFF bit in the same location. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-im

[PATCH v4 5/6] ARM: dts: imx7d: Add turnoff reset

2018-08-14 Thread Leonard Crestez
This is required for the imx pci driver to send the PME_Turn_Off TLP. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx7d.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi index 7234e8330a57

[PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-08-14 Thread Leonard Crestez
is treated as optional with old DTB there should be again no problem if reset and pci are merged out of order. Shawn/Philipp/Lorenzo: Would it make sense to merge this series through a single specific tree, such as the one for imx? Link to v3: https://lkml.org/lkml/2018/7/24/713 Leonard Crestez (6): R

[PATCH v4 0/6] PCI: imx: Initial imx7d suspend/resume support

2018-08-14 Thread Leonard Crestez
is treated as optional with old DTB there should be again no problem if reset and pci are merged out of order. Shawn/Philipp/Lorenzo: Would it make sense to merge this series through a single specific tree, such as the one for imx? Link to v3: https://lkml.org/lkml/2018/7/24/713 Leonard Crestez (6): R

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-10 Thread Leonard Crestez
On Wed, 2018-08-08 at 16:27 +0100, Lorenzo Pieralisi wrote: > On Wed, Aug 08, 2018 at 02:58:15PM +0000, Leonard Crestez wrote: > > On Wed, 2018-08-08 at 15:19 +0100, Lorenzo Pieralisi wrote: > > > On Wed, Aug 08, 2018 at 11:37:14AM +0000, Leonard Crestez wrote: > > > &g

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-10 Thread Leonard Crestez
On Wed, 2018-08-08 at 16:27 +0100, Lorenzo Pieralisi wrote: > On Wed, Aug 08, 2018 at 02:58:15PM +0000, Leonard Crestez wrote: > > On Wed, 2018-08-08 at 15:19 +0100, Lorenzo Pieralisi wrote: > > > On Wed, Aug 08, 2018 at 11:37:14AM +0000, Leonard Crestez wrote: > > > &g

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-08 Thread Leonard Crestez
On Wed, 2018-08-08 at 15:19 +0100, Lorenzo Pieralisi wrote: > On Wed, Aug 08, 2018 at 11:37:14AM +0000, Leonard Crestez wrote: > > On Wed, 2018-08-08 at 12:14 +0100, Lorenzo Pieralisi wrote: > > > On Wed, Aug 08, 2018 at 10:53:52AM +0000, Leonard Crestez wrote: > > > &g

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-08 Thread Leonard Crestez
On Wed, 2018-08-08 at 15:19 +0100, Lorenzo Pieralisi wrote: > On Wed, Aug 08, 2018 at 11:37:14AM +0000, Leonard Crestez wrote: > > On Wed, 2018-08-08 at 12:14 +0100, Lorenzo Pieralisi wrote: > > > On Wed, Aug 08, 2018 at 10:53:52AM +0000, Leonard Crestez wrote: > > > &g

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-08 Thread Leonard Crestez
On Wed, 2018-08-08 at 12:14 +0100, Lorenzo Pieralisi wrote: > On Wed, Aug 08, 2018 at 10:53:52AM +0000, Leonard Crestez wrote: > > On Tue, 2018-07-24 at 19:14 +0300, Leonard Crestez wrote: > > > Changes since v2: > > > * Print with dev_info if link fails on resume (Lu

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-08 Thread Leonard Crestez
On Wed, 2018-08-08 at 12:14 +0100, Lorenzo Pieralisi wrote: > On Wed, Aug 08, 2018 at 10:53:52AM +0000, Leonard Crestez wrote: > > On Tue, 2018-07-24 at 19:14 +0300, Leonard Crestez wrote: > > > Changes since v2: > > > * Print with dev_info if link fails on resume (Lu

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-08 Thread Leonard Crestez
On Tue, 2018-07-24 at 19:14 +0300, Leonard Crestez wrote: > Changes since v2: > * Print with dev_info if link fails on resume (Lucas) > * Add a comment on imx7d pci irq mappings (Andrey) > * Make imx6_pcie_ltssm_disable print an error on IMX6Q (Lucas) > > The ltssm_disab

Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-08-08 Thread Leonard Crestez
On Tue, 2018-07-24 at 19:14 +0300, Leonard Crestez wrote: > Changes since v2: > * Print with dev_info if link fails on resume (Lucas) > * Add a comment on imx7d pci irq mappings (Andrey) > * Make imx6_pcie_ltssm_disable print an error on IMX6Q (Lucas) > > The ltssm_disab

Re: [RFC] PCI: imx: Add multi-pd support

2018-08-03 Thread Leonard Crestez
On Tue, 2018-07-31 at 10:32 +0200, Ulf Hansson wrote: > On 24 July 2018 at 20:17, Leonard Crestez wrote: > > On some chips the PCIE and PCIE_PHY blocks are in separate power domains > > which can be power-gated independently. The driver needs to handle this > > by keepi

Re: [RFC] PCI: imx: Add multi-pd support

2018-08-03 Thread Leonard Crestez
On Tue, 2018-07-31 at 10:32 +0200, Ulf Hansson wrote: > On 24 July 2018 at 20:17, Leonard Crestez wrote: > > On some chips the PCIE and PCIE_PHY blocks are in separate power domains > > which can be power-gated independently. The driver needs to handle this > > by keepi

[RFC] PCI: imx: Add multi-pd support

2018-07-24 Thread Leonard Crestez
requires a way for pcie to keep it active or it will break when displays are off. The power-domains on imx6sx are meant to look like this: power-domains = <_disp>, <_pci>; power-domain-names = "pcie", "pcie_phy"; Signed-off-by: Leonard Crestez --- Ri

[RFC] PCI: imx: Add multi-pd support

2018-07-24 Thread Leonard Crestez
requires a way for pcie to keep it active or it will break when displays are off. The power-domains on imx6sx are meant to look like this: power-domains = <_disp>, <_pci>; power-domain-names = "pcie", "pcie_phy"; Signed-off-by: Leonard Crestez --- Ri

[PATCH v3 2/2] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6

[PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
0/472 Leonard Crestez (2): Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" PCI: imx: Initial imx7d pm support arch/arm/boot/dts/imx7d.dtsi | 12 ++-- drivers/pci/controller/dwc/pci-imx6.c | 97 +-- 2 files changed, 100 insertions(

[PATCH v3 1/2] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-24 Thread Leonard Crestez
This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. That commit followed the reference manual but unfortunately the imx7d manual is incorrect. Tested with ath9k pcie card and confirmed internally. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx7d.dtsi | 12 1

[PATCH v3 1/2] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-24 Thread Leonard Crestez
This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. That commit followed the reference manual but unfortunately the imx7d manual is incorrect. Tested with ath9k pcie card and confirmed internally. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx7d.dtsi | 12 1

[PATCH v3 2/2] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6

[PATCH v3 0/2] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
0/472 Leonard Crestez (2): Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" PCI: imx: Initial imx7d pm support arch/arm/boot/dts/imx7d.dtsi | 12 ++-- drivers/pci/controller/dwc/pci-imx6.c | 97 +-- 2 files changed, 100 insertions(

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 12:09 +0200, Lucas Stach wrote: > Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > > > On i

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 12:09 +0200, Lucas Stach wrote: > Am Montag, den 23.07.2018, 12:37 + schrieb Leonard Crestez: > > On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > > > On i

Re: [PATCH v3 1/3] soc: imx: gpc: fix PDN delay

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 09:46 +, Sven Schmitt wrote: > imx6_pm_domain_power_off() reads iso and iso2sw from > GPC_PGC_PUPSCR_OFFS > which stores the power up delays. > So use GPC_PGC_PDNSCR_OFFS for the correct delays. > > Signed-off-by: Sven Schmitt Reviewed-b

Re: [PATCH v3 1/3] soc: imx: gpc: fix PDN delay

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 09:46 +, Sven Schmitt wrote: > imx6_pm_domain_power_off() reads iso and iso2sw from > GPC_PGC_PUPSCR_OFFS > which stores the power up delays. > So use GPC_PGC_PDNSCR_OFFS for the correct delays. > > Signed-off-by: Sven Schmitt Reviewed-b

Re: [PATCH v3 3/3] soc: imx: gpc: use GPC_PGC_DOMAIN_* indexes

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 09:46 +, Sven Schmitt wrote: > Use GPC_PGC_DOMAIN_* indexes consistent. > > Signed-off-by: Sven Schmitt Reviewed-by: Leonard Crestez

Re: [PATCH v3 3/3] soc: imx: gpc: use GPC_PGC_DOMAIN_* indexes

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 09:46 +, Sven Schmitt wrote: > Use GPC_PGC_DOMAIN_* indexes consistent. > > Signed-off-by: Sven Schmitt Reviewed-by: Leonard Crestez

Re: [PATCH v3 2/3] soc: imx: gpc: clean up

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 09:46 +, Sven Schmitt wrote: > Remove unused #defines. This should be the title of the patch, "clean up" is too vague. > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -24,15 +24,11 @@ > #define GPC_PGC_CTRL_OFFS0x0 > #define GPC_PGC_PUPSCR_OFFS

Re: [PATCH v3 2/3] soc: imx: gpc: clean up

2018-07-24 Thread Leonard Crestez
On Tue, 2018-07-24 at 09:46 +, Sven Schmitt wrote: > Remove unused #defines. This should be the title of the patch, "clean up" is too vague. > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -24,15 +24,11 @@ > #define GPC_PGC_CTRL_OFFS0x0 > #define GPC_PGC_PUPSCR_OFFS

Re: [PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-24 Thread Leonard Crestez
On Mon, 2018-07-23 at 11:38 -0700, Andrey Smirnov wrote: > On Mon, Jul 23, 2018 at 5:41 AM Leonard Crestez > wrote: > > On Fri, 2018-07-20 at 08:33 -0700, Andrey Smirnov wrote: > > > On Fri, Jul 20, 2018 at 5:48 AM Leonard Crestez > > > wrote: > &

Re: [PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-24 Thread Leonard Crestez
On Mon, 2018-07-23 at 11:38 -0700, Andrey Smirnov wrote: > On Mon, Jul 23, 2018 at 5:41 AM Leonard Crestez > wrote: > > On Fri, 2018-07-20 at 08:33 -0700, Andrey Smirnov wrote: > > > On Fri, Jul 20, 2018 at 5:48 AM Leonard Crestez > > > wrote: > &

[PATCH] ARM: imx_v6_v7_defconfig: Enable DRM_PANEL_SEIKO_43WVF1G

2018-07-23 Thread Leonard Crestez
This is one of the default lcdif panel options for several imx development boards. Now that we switched to CONFIG_DRM_MXSFB=y this should be enabled as well. Signed-off-by: Leonard Crestez --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm

[PATCH] ARM: imx_v6_v7_defconfig: Enable DRM_PANEL_SEIKO_43WVF1G

2018-07-23 Thread Leonard Crestez
This is one of the default lcdif panel options for several imx development boards. Now that we switched to CONFIG_DRM_MXSFB=y this should be enabled as well. Signed-off-by: Leonard Crestez --- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm

Re: [PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-23 Thread Leonard Crestez
On Fri, 2018-07-20 at 08:33 -0700, Andrey Smirnov wrote: > On Fri, Jul 20, 2018 at 5:48 AM Leonard Crestez > wrote: > > > > This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. > > > > That commit followed the reference manual but unfortunately the

Re: [PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-23 Thread Leonard Crestez
On Fri, 2018-07-20 at 08:33 -0700, Andrey Smirnov wrote: > On Fri, Jul 20, 2018 at 5:48 AM Leonard Crestez > wrote: > > > > This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. > > > > That commit followed the reference manual but unfortunately the

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-23 Thread Leonard Crestez
On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > Hi Leonard, > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > make the system hang after resume when attempt

Re: [PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-23 Thread Leonard Crestez
On Mon, 2018-07-23 at 11:38 +0200, Lucas Stach wrote: > Hi Leonard, > > Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez: > > On imx7d the pcie-phy power domain is turned off in suspend and this can > > make the system hang after resume when attempt

[PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6

[PATCH v2 3/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Leonard Crestez
. Code is only for imx7d but a very similar sequence can be used for other socs. The original author is mostly Richard Zhu , this patch adjusts the code to the upstream imx7d implemention using reset controls and power domains. Signed-off-by: Leonard Crestez --- drivers/pci/controller/dwc/pci-imx6

[PATCH v2 2/3] reset: imx7: Fix always writing bits as 0

2018-07-20 Thread Leonard Crestez
but for other registers like MIPIPHY and HSICPHY the bits are explicitly documented as "1 means assert, 0 means deassert". The values are still reversed for IMX7_RESET_PCIE_CTRL_APPS_EN. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- drivers/reset/reset-imx7.c | 2 +- 1 file

[PATCH v2 2/3] reset: imx7: Fix always writing bits as 0

2018-07-20 Thread Leonard Crestez
but for other registers like MIPIPHY and HSICPHY the bits are explicitly documented as "1 means assert, 0 means deassert". The values are still reversed for IMX7_RESET_PCIE_CTRL_APPS_EN. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- drivers/reset/reset-imx7.c | 2 +- 1 file

[PATCH v2 0/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Leonard Crestez
/1042 Leonard Crestez (3): Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" reset: imx7: Fix always writing bits as 0 PCI: imx: Initial imx7d pm support arch/arm/boot/dts/imx7d.dtsi | 8 +-- drivers/pci/controller/dwc/pci-imx6.c | 95 +-- dri

[PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-20 Thread Leonard Crestez
This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. That commit followed the reference manual but unfortunately the imx7d manual is incorrect. Tested with ath9k pcie card and confirmed internally. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx7d.dtsi | 8 1 file

[PATCH v2 0/3] PCI: imx: Initial imx7d pm support

2018-07-20 Thread Leonard Crestez
/1042 Leonard Crestez (3): Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" reset: imx7: Fix always writing bits as 0 PCI: imx: Initial imx7d pm support arch/arm/boot/dts/imx7d.dtsi | 8 +-- drivers/pci/controller/dwc/pci-imx6.c | 95 +-- dri

[PATCH v2 1/3] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping"

2018-07-20 Thread Leonard Crestez
This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. That commit followed the reference manual but unfortunately the imx7d manual is incorrect. Tested with ath9k pcie card and confirmed internally. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx7d.dtsi | 8 1 file

[PATCH] drm/imx: Remove unused field imx_drm_device.pipes

2018-07-17 Thread Leonard Crestez
This has been unused since commit 44b460cfe554 ("drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs") Signed-off-by: Leonard Crestez --- drivers/gpu/drm/imx/imx-drm-core.c | 1 - 1 file changed, 1 deletion(-) Looking at the imx_drm_device struct it is only us

[PATCH] drm/imx: Remove unused field imx_drm_device.pipes

2018-07-17 Thread Leonard Crestez
This has been unused since commit 44b460cfe554 ("drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs") Signed-off-by: Leonard Crestez --- drivers/gpu/drm/imx/imx-drm-core.c | 1 - 1 file changed, 1 deletion(-) Looking at the imx_drm_device struct it is only us

[PATCH] soc: imx6qp: Use GENPD_FLAG_ALWAYS_ON for PU errata

2018-07-13 Thread Leonard Crestez
t; instead the pm core won't even attempt to turn it off. In theory on 6qp it is safe to turn PU off in suspend, however that is best accomplished with a new core flag. Signed-off-by: Leonard Crestez --- drivers/soc/imx/gpc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Previous

[PATCH] soc: imx6qp: Use GENPD_FLAG_ALWAYS_ON for PU errata

2018-07-13 Thread Leonard Crestez
t; instead the pm core won't even attempt to turn it off. In theory on 6qp it is safe to turn PU off in suspend, however that is best accomplished with a new core flag. Signed-off-by: Leonard Crestez --- drivers/soc/imx/gpc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Previous

Re: [PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287

2018-07-11 Thread Leonard Crestez
On Wed, 2018-07-11 at 14:16 +0200, Lucas Stach wrote: > Am Mittwoch, den 11.07.2018, 15:11 +0300 schrieb Leonard Crestez: > > Handle this in the safest possible way by keeping the DISP domain > > always-on. > > > > Signed-off-by: Leonard Crestez > > Reviewed-b

Re: [PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287

2018-07-11 Thread Leonard Crestez
On Wed, 2018-07-11 at 14:16 +0200, Lucas Stach wrote: > Am Mittwoch, den 11.07.2018, 15:11 +0300 schrieb Leonard Crestez: > > Handle this in the safest possible way by keeping the DISP domain > > always-on. > > > > Signed-off-by: Leonard Crestez > > Reviewed-b

[PATCH v3 0/2] Fix imx6sl display power domain

2018-07-11 Thread Leonard Crestez
. Link to v2: https://lkml.org/lkml/2018/7/9/447 Leonard Crestez (2): soc: imx: gpc: Disable 6sl display power gating for ERR006287 ARM: dts: imx6sl: Convert gpc to new bindings arch/arm/boot/dts/imx6sl.dtsi | 35 +++ drivers/soc/imx/gpc.c | 10

[PATCH v3 2/2] ARM: dts: imx6sl: Convert gpc to new bindings

2018-07-11 Thread Leonard Crestez
the newly-defined _disp domain from Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx6sl.dtsi | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 102c575a6025..49a56b4fd

[PATCH v3 0/2] Fix imx6sl display power domain

2018-07-11 Thread Leonard Crestez
. Link to v2: https://lkml.org/lkml/2018/7/9/447 Leonard Crestez (2): soc: imx: gpc: Disable 6sl display power gating for ERR006287 ARM: dts: imx6sl: Convert gpc to new bindings arch/arm/boot/dts/imx6sl.dtsi | 35 +++ drivers/soc/imx/gpc.c | 10

[PATCH v3 2/2] ARM: dts: imx6sl: Convert gpc to new bindings

2018-07-11 Thread Leonard Crestez
the newly-defined _disp domain from Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx6sl.dtsi | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index 102c575a6025..49a56b4fd

[PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287

2018-07-11 Thread Leonard Crestez
isplay power domain. Link: https://www.nxp.com/docs/en/errata/IMX6SLCE.pdf#page=62 Handle this in the safest possible way by keeping the DISP domain always-on. Signed-off-by: Leonard Crestez --- drivers/soc/imx/gpc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/soc/imx

[PATCH v3 1/2] soc: imx: gpc: Disable 6sl display power gating for ERR006287

2018-07-11 Thread Leonard Crestez
isplay power domain. Link: https://www.nxp.com/docs/en/errata/IMX6SLCE.pdf#page=62 Handle this in the safest possible way by keeping the DISP domain always-on. Signed-off-by: Leonard Crestez --- drivers/soc/imx/gpc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/soc/imx

Re: [PATCH] clk: core: Potentially free connection id

2018-07-11 Thread Leonard Crestez
gned-off-by: Mikko Perttunen Yes, sorry I missed this. Reviewed-by: Leonard Crestez Maybe a static __clk_free_mem function could be created instead of comments asking to keep things in sync? But there are only 2 lines so it's fine.

Re: [PATCH] clk: core: Potentially free connection id

2018-07-11 Thread Leonard Crestez
gned-off-by: Mikko Perttunen Yes, sorry I missed this. Reviewed-by: Leonard Crestez Maybe a static __clk_free_mem function could be created instead of comments asking to keep things in sync? But there are only 2 lines so it's fine.

<    1   2   3   4   5   6   7   >