[PATCH review for 4.9 21/50] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize.

[PATCH review for 4.9 09/50] mac80211: fix power saving clients handling in iwlwifi

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Emmanuel Grumbach [ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ] iwlwifi now supports RSS and can't let mac80211 track the PS state based on the Rx frames since they can come out of order. iwlwifi is now advertising AP_LINK_PS, and uses explicit notifications to teach

[PATCH review for 4.9 13/50] iio: adc: xilinx: Fix error handling

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Christophe JAILLET [ Upstream commit ca1c39ef76376b67303d01f94fe98bb68bb3861a ] Reorder error handling labels in order to match the way resources have been allocated. Signed-off-by: Christophe JAILLET Acked-by: Lars-Peter Clausen Signed-off-by: Jonathan Cameron Signed-off-by: Sasha

[PATCH review for 4.9 21/50] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize. Signed-off-by: Milan

[PATCH review for 4.9 23/50] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by

[PATCH review for 4.9 25/50] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter

[PATCH review for 4.9 46/50] regulator: core: Resolve supplies before disabling unused regulators

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Javier Martinez Canillas [ Upstream commit 3827b64dba27ebadb4faf51f2c91143e01ba1f6d ] After commit 66d228a2bf03 ("regulator: core: Don't use regulators as supplies until the parent is bound"), input supplies aren't resolved if the input supplies parent device has

[PATCH review for 4.9 23/50] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by writing code

[PATCH review for 4.9 25/50] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen

[PATCH review for 4.9 46/50] regulator: core: Resolve supplies before disabling unused regulators

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Javier Martinez Canillas [ Upstream commit 3827b64dba27ebadb4faf51f2c91143e01ba1f6d ] After commit 66d228a2bf03 ("regulator: core: Don't use regulators as supplies until the parent is bound"), input supplies aren't resolved if the input supplies parent device has not been bound. This

[PATCH review for 4.9 34/50] ceph: fix bogus endianness change in ceph_ioctl_set_layout

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit 24c149ad6914d349d8b64749f20f3f8ea5031fe0 ] sparse says: fs/ceph/ioctl.c:100:28: warning: cast to restricted __le64 preferred_osd is a __s64 so we don't need to do any conversion. Also, just remove the cast in ceph_ioctl_get_layout as

[PATCH review for 4.9 31/50] qed: Read queue state before releasing buffer

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Ram Amrani [ Upstream commit c5212b943d4b52a7d9e0d9f747e7ad59c50d31f1 ] Currently the state is read only after the buffers are relesed. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz Signed-off-by: David S.

[PATCH review for 4.4 01/26] locking/lockdep: Add nest_lock integrity test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Peter Zijlstra [ Upstream commit 7fb4a2cea6b18dab56d609530d077f168169ed6b ] Boqun reported that hlock->references can overflow. Add a debug test for that to generate a clear error when this happens. Without this, lockdep is likely to report a mysterious failure on

[PATCH review for 4.9 34/50] ceph: fix bogus endianness change in ceph_ioctl_set_layout

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit 24c149ad6914d349d8b64749f20f3f8ea5031fe0 ] sparse says: fs/ceph/ioctl.c:100:28: warning: cast to restricted __le64 preferred_osd is a __s64 so we don't need to do any conversion. Also, just remove the cast in ceph_ioctl_get_layout as it's not needed.

[PATCH review for 4.9 31/50] qed: Read queue state before releasing buffer

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Ram Amrani [ Upstream commit c5212b943d4b52a7d9e0d9f747e7ad59c50d31f1 ] Currently the state is read only after the buffers are relesed. Signed-off-by: Ram Amrani Signed-off-by: Yuval Mintz Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH review for 4.4 01/26] locking/lockdep: Add nest_lock integrity test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Peter Zijlstra [ Upstream commit 7fb4a2cea6b18dab56d609530d077f168169ed6b ] Boqun reported that hlock->references can overflow. Add a debug test for that to generate a clear error when this happens. Without this, lockdep is likely to report a mysterious failure on unlock. Reported-by:

[PATCH review for 4.9 36/50] uapi: fix linux/rds.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit feb0869d90e51ce8b6fd8a46588465b1b5a26d09 ] Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:106:2: error: unknown type name 'uint8_t' uint8_t

[PATCH review for 4.9 27/50] drm/amdgpu: refuse to reserve io mem for split VRAM buffers

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Nicolai Hähnle [ Upstream commit 4694335dad7357e9b3d7822ab13049014d74d8b0 ] When the fast blit path fails while attempting to move a buffer from RAM to VRAM, we fall back to a CPU-based memcpy that cannot handle split VRAM buffers. Instead of crashing, simply fail

[PATCH review for 4.9 36/50] uapi: fix linux/rds.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit feb0869d90e51ce8b6fd8a46588465b1b5a26d09 ] Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:106:2: error: unknown type name 'uint8_t' uint8_t name[32];

[PATCH review for 4.9 27/50] drm/amdgpu: refuse to reserve io mem for split VRAM buffers

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Nicolai Hähnle [ Upstream commit 4694335dad7357e9b3d7822ab13049014d74d8b0 ] When the fast blit path fails while attempting to move a buffer from RAM to VRAM, we fall back to a CPU-based memcpy that cannot handle split VRAM buffers. Instead of crashing, simply fail the buffer move.

[PATCH review for 4.9 39/50] IB/hfi1: Use static CTLE with Preset 6 for integrated HFIs

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Easwar Hariharan [ Upstream commit 39e2afa8d042a53d855137d4c5a689a6f5492b39 ] After extended testing, it was found that the previous PCIe Gen 3 recipe, which used adaptive CTLE with Preset 4, could cause an NMI/Surprise Link Down in about 1 in 100 to 1 in 1000

[PATCH review for 4.9 39/50] IB/hfi1: Use static CTLE with Preset 6 for integrated HFIs

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Easwar Hariharan [ Upstream commit 39e2afa8d042a53d855137d4c5a689a6f5492b39 ] After extended testing, it was found that the previous PCIe Gen 3 recipe, which used adaptive CTLE with Preset 4, could cause an NMI/Surprise Link Down in about 1 in 100 to 1 in 1000 power cycles on some

[PATCH review for 4.9 49/50] genirq: Clarify logic calculating bogus irqreturn_t values

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeremy Kerr [ Upstream commit 5d4bac9a5f4ef24b2482529bda6661a58e5b5b65 ] Although irqreturn_t is an enum, we treat it (and its enumeration constants) as a bitmask. However, bad_action_ret() uses a less-than operator to determine whether an irqreturn_t falls within

[PATCH review for 4.9 28/50] net: mvpp2: release reference to txq_cpu[] entry after unmapping

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Thomas Petazzoni [ Upstream commit 36fb7435b6ac4d288a2d4deea8934f9456ab46b6 ] The mvpp2_txq_bufs_free() function is called upon TX completion to DMA unmap TX buffers, and free the corresponding SKBs. It gets the references to the SKB to free and the

[PATCH review for 4.9 35/50] ceph: clean up unsafe d_parent accesses in build_dentry_path

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit c6b0b656ca24ede6657abb4a2cd910fa9c1879ba ] While we hold a reference to the dentry when build_dentry_path is called, we could end up racing with a rename that changes d_parent. Handle that situation correctly, by using the rcu_read_lock to

[PATCH review for 4.9 28/50] net: mvpp2: release reference to txq_cpu[] entry after unmapping

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Thomas Petazzoni [ Upstream commit 36fb7435b6ac4d288a2d4deea8934f9456ab46b6 ] The mvpp2_txq_bufs_free() function is called upon TX completion to DMA unmap TX buffers, and free the corresponding SKBs. It gets the references to the SKB to free and the DMA buffer to unmap from a per-CPU

[PATCH review for 4.9 35/50] ceph: clean up unsafe d_parent accesses in build_dentry_path

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit c6b0b656ca24ede6657abb4a2cd910fa9c1879ba ] While we hold a reference to the dentry when build_dentry_path is called, we could end up racing with a rename that changes d_parent. Handle that situation correctly, by using the rcu_read_lock to ensure that the

[PATCH review for 4.9 49/50] genirq: Clarify logic calculating bogus irqreturn_t values

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeremy Kerr [ Upstream commit 5d4bac9a5f4ef24b2482529bda6661a58e5b5b65 ] Although irqreturn_t is an enum, we treat it (and its enumeration constants) as a bitmask. However, bad_action_ret() uses a less-than operator to determine whether an irqreturn_t falls within allowable bit values,

[PATCH review for 4.9 40/50] IB/hfi1: Allocate context data on memory node

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Sebastian Sanchez [ Upstream commit b448bf9a0df6093dbadac36979a55ce4e012a677 ] There are some memory allocation calls in hfi1_create_ctxtdata() that do not use the numa function parameter. This can cause cache lines to be filled over QPI. Reviewed-by: Mike

[PATCH review for 4.9 40/50] IB/hfi1: Allocate context data on memory node

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Sebastian Sanchez [ Upstream commit b448bf9a0df6093dbadac36979a55ce4e012a677 ] There are some memory allocation calls in hfi1_create_ctxtdata() that do not use the numa function parameter. This can cause cache lines to be filled over QPI. Reviewed-by: Mike Marciniszyn Signed-off-by:

[PATCH review for 4.4 03/26] irqchip/crossbar: Fix incorrect type of local variables

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Franck Demathieu [ Upstream commit b28ace12661fbcfd90959c1e84ff5a85113a82a1 ] The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign): drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in

[PATCH review for 4.4 16/26] slub: do not merge cache if slub_debug contains a never-merge flag

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Grygorii Maistrenko [ Upstream commit c6e28895a4372992961888ffaadc9efc643b5bfe ] In case CONFIG_SLUB_DEBUG_ON=n, find_mergeable() gets debug features from commandline but never checks if there are features from the SLAB_NEVER_MERGE set. As a result selected by

[PATCH review for 4.4 03/26] irqchip/crossbar: Fix incorrect type of local variables

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Franck Demathieu [ Upstream commit b28ace12661fbcfd90959c1e84ff5a85113a82a1 ] The max and entry variables are unsigned according to the dt-bindings. Fix following 3 sparse issues (-Wtypesign): drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in argument 3 (different

[PATCH review for 4.4 16/26] slub: do not merge cache if slub_debug contains a never-merge flag

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Grygorii Maistrenko [ Upstream commit c6e28895a4372992961888ffaadc9efc643b5bfe ] In case CONFIG_SLUB_DEBUG_ON=n, find_mergeable() gets debug features from commandline but never checks if there are features from the SLAB_NEVER_MERGE set. As a result selected by slub_debug caches are

[PATCH review for 4.4 15/26] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by

[PATCH review for 4.9 47/50] btmrvl: avoid double-disable_irq() race

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeffy Chen [ Upstream commit 9af02d86e11dc409e5c3de46e81c0a492ba58905 ] It's much the same as what we did for mwifiex in: b9da4d2 mwifiex: avoid double-disable_irq() race "We have a race where the wakeup IRQ might be in flight while we're calling

[PATCH review for 3.18 04/14] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jarno Rajahalme [ Upstream commit 4b86c459c7bee3acaf92f0e2b4c6ac803eaa1a58 ] Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to

[PATCH review for 4.4 15/26] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by writing code

[PATCH review for 4.9 47/50] btmrvl: avoid double-disable_irq() race

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeffy Chen [ Upstream commit 9af02d86e11dc409e5c3de46e81c0a492ba58905 ] It's much the same as what we did for mwifiex in: b9da4d2 mwifiex: avoid double-disable_irq() race "We have a race where the wakeup IRQ might be in flight while we're calling mwifiex_disable_wake() from resume().

[PATCH review for 3.18 04/14] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jarno Rajahalme [ Upstream commit 4b86c459c7bee3acaf92f0e2b4c6ac803eaa1a58 ] Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to __nf_ct_expect_check()

[PATCH review for 4.4 10/26] f2fs: do not wait for writeback in write_begin

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jaegeuk Kim [ Upstream commit 86d54795c94532075d862aa0a79f0c981dab4bdd ] Otherwise we can get livelock like below. [79880.428136] dbench D0 18405 18404 0x [79880.428139] Call Trace: [79880.428142] __schedule+0x219/0x6b0 [79880.428144]

[PATCH review for 4.4 10/26] f2fs: do not wait for writeback in write_begin

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jaegeuk Kim [ Upstream commit 86d54795c94532075d862aa0a79f0c981dab4bdd ] Otherwise we can get livelock like below. [79880.428136] dbench D0 18405 18404 0x [79880.428139] Call Trace: [79880.428142] __schedule+0x219/0x6b0 [79880.428144] schedule+0x36/0x80

[PATCH review for 4.9 38/50] ibmvnic: Handle processing of CRQ messages in a tasklet

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Thomas Falcon [ Upstream commit 6c267b3dea09aebe84752cfedcab140c908830bb ] Create a tasklet to process queued commands or messages received from firmware instead of processing them in the interrupt handler. Note that this handler does not process network

[PATCH review for 4.4 05/26] mac80211: fix power saving clients handling in iwlwifi

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Emmanuel Grumbach [ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ] iwlwifi now supports RSS and can't let mac80211 track the PS state based on the Rx frames since they can come out of order. iwlwifi is now advertising AP_LINK_PS, and uses explicit

[PATCH review for 4.9 38/50] ibmvnic: Handle processing of CRQ messages in a tasklet

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Thomas Falcon [ Upstream commit 6c267b3dea09aebe84752cfedcab140c908830bb ] Create a tasklet to process queued commands or messages received from firmware instead of processing them in the interrupt handler. Note that this handler does not process network traffic, but communications

[PATCH review for 4.4 05/26] mac80211: fix power saving clients handling in iwlwifi

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Emmanuel Grumbach [ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ] iwlwifi now supports RSS and can't let mac80211 track the PS state based on the Rx frames since they can come out of order. iwlwifi is now advertising AP_LINK_PS, and uses explicit notifications to teach

[PATCH review for 3.18 06/14] Btrfs: send, fix failure to rename top level inode due to name collision

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Robbie Ko [ Upstream commit 4dd9920d991745c4a16f53a8f615f706fbe4b3f7 ] Under certain situations, an incremental send operation can fail due to a premature attempt to create a new top level inode (a direct child of the subvolume/snapshot root) whose name collides

[PATCH review for 3.18 06/14] Btrfs: send, fix failure to rename top level inode due to name collision

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Robbie Ko [ Upstream commit 4dd9920d991745c4a16f53a8f615f706fbe4b3f7 ] Under certain situations, an incremental send operation can fail due to a premature attempt to create a new top level inode (a direct child of the subvolume/snapshot root) whose name collides with another inode that

[PATCH review for 4.9 45/50] drm/nouveau/gr/gf100-: fix ccache error logging

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Ben Skeggs [ Upstream commit 1894054dc1b6e4395048b2c0f28832a3f4320fd3 ] Signed-off-by: Ben Skeggs Signed-off-by: Sasha Levin --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH review for 4.4 14/26] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize.

[PATCH review for 4.9 45/50] drm/nouveau/gr/gf100-: fix ccache error logging

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Ben Skeggs [ Upstream commit 1894054dc1b6e4395048b2c0f28832a3f4320fd3 ] Signed-off-by: Ben Skeggs Signed-off-by: Sasha Levin --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH review for 4.4 14/26] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize. Signed-off-by: Milan

[PATCH review for 4.4 02/26] watchdog: kempld: fix gcc-4.3 build

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit 3736d4eb6af37492aeded7fec0072dedd959c842 ] gcc-4.3 can't decide whether the constant value in kempld_prescaler[PRESCALER_21] is built-time constant or not, and gets confused by the logic in do_div(): drivers/watchdog/kempld_wdt.o: In

[PATCH review for 4.4 17/26] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter

[PATCH review for 4.4 02/26] watchdog: kempld: fix gcc-4.3 build

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit 3736d4eb6af37492aeded7fec0072dedd959c842 ] gcc-4.3 can't decide whether the constant value in kempld_prescaler[PRESCALER_21] is built-time constant or not, and gets confused by the logic in do_div(): drivers/watchdog/kempld_wdt.o: In function

[PATCH review for 4.4 17/26] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen

[PATCH review for 3.18 08/14] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize.

[PATCH review for 3.18 13/14] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data

[PATCH review for 4.4 11/26] md/linear: shutup lockdep warnning

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Shaohua Li [ Upstream commit d939cdfde34f50b95254b375f498447c82190b3e ] Commit 03a9e24(md linear: fix a race between linear_add() and linear_congested()) introduces the warnning. Acked-by: Coly Li Signed-off-by: Shaohua Li Signed-off-by: Sasha

[PATCH review for 3.18 08/14] crypto: xts - Add ECB dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Milan Broz [ Upstream commit 12cb3a1c4184f891d965d1f39f8cfcc9ef617647 ] Since the commit f1c131b45410a202eb45cc55980a7a9e4e4b4f40 crypto: xts - Convert to skcipher the XTS mode is based on ECB, so the mode must select ECB otherwise it can fail to initialize. Signed-off-by: Milan

[PATCH review for 3.18 13/14] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data length and

[PATCH review for 4.4 11/26] md/linear: shutup lockdep warnning

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Shaohua Li [ Upstream commit d939cdfde34f50b95254b375f498447c82190b3e ] Commit 03a9e24(md linear: fix a race between linear_add() and linear_congested()) introduces the warnning. Acked-by: Coly Li Signed-off-by: Shaohua Li Signed-off-by: Sasha Levin --- drivers/md/linear.c | 3 ++- 1

[PATCH review for 4.9 48/50] EDAC, mce_amd: Print IPID and Syndrome on a separate line

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Yazen Ghannam [ Upstream commit 75bf2f6478cab9b0c1d7f5f674a765d1e2ad530e ] Currently, the IPID and Syndrome are printed on the same line as the Address. There are cases when we can have a valid Syndrome but not a valid Address. For example, the MCA_SYND register

[PATCH review for 4.9 50/50] cpufreq: CPPC: add ACPI_PROCESSOR dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit a578884fa0d2768f13d37c6591a9e1ed600482d3 ] Without the Kconfig dependency, we can get this warning: warning: ACPI_CPPC_CPUFREQ selects ACPI_CPPC_LIB which has unmet direct dependencies (ACPI && ACPI_PROCESSOR) Fixes: 5477fb3bd1e8 (ACPI /

[PATCH review for 4.9 37/50] uapi: fix linux/mroute6.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit 72aa107df6a275cf03359934ca5799a2be7a1bf7 ] Include to fix the following linux/mroute6.h userspace compilation errors: /usr/include/linux/mroute6.h:80:22: error: field 'mf6cc_origin' has incomplete type struct sockaddr_in6

[PATCH review for 4.9 48/50] EDAC, mce_amd: Print IPID and Syndrome on a separate line

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Yazen Ghannam [ Upstream commit 75bf2f6478cab9b0c1d7f5f674a765d1e2ad530e ] Currently, the IPID and Syndrome are printed on the same line as the Address. There are cases when we can have a valid Syndrome but not a valid Address. For example, the MCA_SYND register can be used to hold more

[PATCH review for 4.9 50/50] cpufreq: CPPC: add ACPI_PROCESSOR dependency

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Arnd Bergmann [ Upstream commit a578884fa0d2768f13d37c6591a9e1ed600482d3 ] Without the Kconfig dependency, we can get this warning: warning: ACPI_CPPC_CPUFREQ selects ACPI_CPPC_LIB which has unmet direct dependencies (ACPI && ACPI_PROCESSOR) Fixes: 5477fb3bd1e8 (ACPI / CPPC: Add a

[PATCH review for 4.9 37/50] uapi: fix linux/mroute6.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit 72aa107df6a275cf03359934ca5799a2be7a1bf7 ] Include to fix the following linux/mroute6.h userspace compilation errors: /usr/include/linux/mroute6.h:80:22: error: field 'mf6cc_origin' has incomplete type struct sockaddr_in6 mf6cc_origin; /* Origin

[PATCH review for 4.4 04/26] mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Johannes Berg [ Upstream commit ff4dd73dd2b4806419f8ff65cbce11d5019548d0 ] Unfortunately, the nla policy was defined to have HWSIM_ATTR_RADIO_NAME as an NLA_STRING, rather than NLA_NUL_STRING, so we can't use it as a NUL-terminated string in the kernel. Rather

[PATCH review for 4.4 04/26] mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Johannes Berg [ Upstream commit ff4dd73dd2b4806419f8ff65cbce11d5019548d0 ] Unfortunately, the nla policy was defined to have HWSIM_ATTR_RADIO_NAME as an NLA_STRING, rather than NLA_NUL_STRING, so we can't use it as a NUL-terminated string in the kernel. Rather than break the API,

[PATCH review for 3.18 12/14] uapi: fix linux/mroute6.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit 72aa107df6a275cf03359934ca5799a2be7a1bf7 ] Include to fix the following linux/mroute6.h userspace compilation errors: /usr/include/linux/mroute6.h:80:22: error: field 'mf6cc_origin' has incomplete type struct sockaddr_in6

[PATCH review for 4.4 09/26] Btrfs: send, fix failure to rename top level inode due to name collision

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Robbie Ko [ Upstream commit 4dd9920d991745c4a16f53a8f615f706fbe4b3f7 ] Under certain situations, an incremental send operation can fail due to a premature attempt to create a new top level inode (a direct child of the subvolume/snapshot root) whose name collides

[PATCH review for 3.18 12/14] uapi: fix linux/mroute6.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit 72aa107df6a275cf03359934ca5799a2be7a1bf7 ] Include to fix the following linux/mroute6.h userspace compilation errors: /usr/include/linux/mroute6.h:80:22: error: field 'mf6cc_origin' has incomplete type struct sockaddr_in6 mf6cc_origin; /* Origin

[PATCH review for 4.4 09/26] Btrfs: send, fix failure to rename top level inode due to name collision

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Robbie Ko [ Upstream commit 4dd9920d991745c4a16f53a8f615f706fbe4b3f7 ] Under certain situations, an incremental send operation can fail due to a premature attempt to create a new top level inode (a direct child of the subvolume/snapshot root) whose name collides with another inode that

[PATCH review for 4.4 08/26] iio: adc: xilinx: Fix error handling

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Christophe JAILLET [ Upstream commit ca1c39ef76376b67303d01f94fe98bb68bb3861a ] Reorder error handling labels in order to match the way resources have been allocated. Signed-off-by: Christophe JAILLET Acked-by: Lars-Peter

[PATCH review for 4.4 06/26] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Dumazet [ Upstream commit 47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf ] The cited commit makes a great job of finding optimal shift/multiplier values assuming a 10 seconds wrap around, but forgot to change the overflow_period computation. It overflows in

[PATCH review for 4.4 08/26] iio: adc: xilinx: Fix error handling

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Christophe JAILLET [ Upstream commit ca1c39ef76376b67303d01f94fe98bb68bb3861a ] Reorder error handling labels in order to match the way resources have been allocated. Signed-off-by: Christophe JAILLET Acked-by: Lars-Peter Clausen Signed-off-by: Jonathan Cameron Signed-off-by: Sasha

[PATCH review for 4.4 06/26] net/mlx4_en: fix overflow in mlx4_en_init_timestamp()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Dumazet [ Upstream commit 47d3a07528ecbbccf53bc4390d70b4e3d1c04fcf ] The cited commit makes a great job of finding optimal shift/multiplier values assuming a 10 seconds wrap around, but forgot to change the overflow_period computation. It overflows in cyclecounter_cyc2ns(), and the

[PATCH review for 4.4 07/26] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jarno Rajahalme [ Upstream commit 4b86c459c7bee3acaf92f0e2b4c6ac803eaa1a58 ] Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to

[PATCH review for 4.4 20/26] ceph: clean up unsafe d_parent accesses in build_dentry_path

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit c6b0b656ca24ede6657abb4a2cd910fa9c1879ba ] While we hold a reference to the dentry when build_dentry_path is called, we could end up racing with a rename that changes d_parent. Handle that situation correctly, by using the rcu_read_lock to

[PATCH review for 3.18 01/14] locking/lockdep: Add nest_lock integrity test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Peter Zijlstra [ Upstream commit 7fb4a2cea6b18dab56d609530d077f168169ed6b ] Boqun reported that hlock->references can overflow. Add a debug test for that to generate a clear error when this happens. Without this, lockdep is likely to report a mysterious failure on

[PATCH review for 4.4 07/26] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jarno Rajahalme [ Upstream commit 4b86c459c7bee3acaf92f0e2b4c6ac803eaa1a58 ] Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert() returns void") inadvertently changed the successful return value of nf_ct_expect_related_report() from 0 to 1 due to __nf_ct_expect_check()

[PATCH review for 4.4 20/26] ceph: clean up unsafe d_parent accesses in build_dentry_path

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeff Layton [ Upstream commit c6b0b656ca24ede6657abb4a2cd910fa9c1879ba ] While we hold a reference to the dentry when build_dentry_path is called, we could end up racing with a rename that changes d_parent. Handle that situation correctly, by using the rcu_read_lock to ensure that the

[PATCH review for 3.18 01/14] locking/lockdep: Add nest_lock integrity test

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Peter Zijlstra [ Upstream commit 7fb4a2cea6b18dab56d609530d077f168169ed6b ] Boqun reported that hlock->references can overflow. Add a debug test for that to generate a clear error when this happens. Without this, lockdep is likely to report a mysterious failure on unlock. Reported-by:

[PATCH review for 4.4 21/26] uapi: fix linux/rds.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit feb0869d90e51ce8b6fd8a46588465b1b5a26d09 ] Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:106:2: error: unknown type name 'uint8_t' uint8_t

[PATCH review for 4.4 21/26] uapi: fix linux/rds.h userspace compilation errors

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: "Dmitry V. Levin" [ Upstream commit feb0869d90e51ce8b6fd8a46588465b1b5a26d09 ] Consistently use types from linux/types.h to fix the following linux/rds.h userspace compilation errors: /usr/include/linux/rds.h:106:2: error: unknown type name 'uint8_t' uint8_t name[32];

[PATCH review for 4.4 23/26] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data

[PATCH review for 3.18 09/14] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by

[PATCH review for 3.18 10/14] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter

[PATCH review for 4.4 23/26] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data length and

[PATCH review for 3.18 09/14] ocfs2/dlmglue: prepare tracking logic to avoid recursive cluster lock

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Eric Ren [ Upstream commit 439a36b8ef38657f765b80b775e2885338d72451 ] We are in the situation that we have to avoid recursive cluster locking, but there is no way to check if a cluster lock has been taken by a precess already. Mostly, we can avoid recursive locking by writing code

[PATCH review for 3.18 10/14] scsi: scsi_dh_emc: return success in clariion_std_inquiry()

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Dan Carpenter [ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen

[PATCH review for 4.4 19/26] i2c: at91: ensure state is restored after suspending

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Alexandre Belloni [ Upstream commit e3ccc921b7d8fd1fcd10a00720e09823d8078666 ] When going to suspend, the I2C registers may be lost because the power to VDDcore is cut. Restore them when resuming. Signed-off-by: Alexandre Belloni

[PATCH review for 4.4 19/26] i2c: at91: ensure state is restored after suspending

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Alexandre Belloni [ Upstream commit e3ccc921b7d8fd1fcd10a00720e09823d8078666 ] When going to suspend, the I2C registers may be lost because the power to VDDcore is cut. Restore them when resuming. Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches Signed-off-by: Wolfram Sang

[PATCH review for 4.4 25/26] genirq: Clarify logic calculating bogus irqreturn_t values

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeremy Kerr [ Upstream commit 5d4bac9a5f4ef24b2482529bda6661a58e5b5b65 ] Although irqreturn_t is an enum, we treat it (and its enumeration constants) as a bitmask. However, bad_action_ret() uses a less-than operator to determine whether an irqreturn_t falls within

[PATCH review for 4.9 41/50] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data

[PATCH review for 4.4 24/26] nfsd/callback: Cleanup callback cred on shutdown

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Kinglong Mee [ Upstream commit f7d1ddbe7648af7460d23688c8c131342eb43b3a ] The rpccred gotten from rpc_lookup_machine_cred() should be put when state is shutdown. Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

[PATCH review for 4.9 41/50] target/iscsi: Fix unsolicited data seq_end_offset calculation

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Varun Prakash [ Upstream commit 4d65491c269729a1e3b375c45e73213f49103d33 ] In case of unsolicited data for the first sequence seq_end_offset must be set to minimum of total data length and FirstBurstLength, so do not add cmd->write_data_done to the min of total data length and

[PATCH review for 4.4 24/26] nfsd/callback: Cleanup callback cred on shutdown

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Kinglong Mee [ Upstream commit f7d1ddbe7648af7460d23688c8c131342eb43b3a ] The rpccred gotten from rpc_lookup_machine_cred() should be put when state is shutdown. Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields Signed-off-by: Sasha Levin --- fs/nfsd/nfs4callback.c | 8

[PATCH review for 4.4 25/26] genirq: Clarify logic calculating bogus irqreturn_t values

2017-09-24 Thread Levin, Alexander (Sasha Levin)
From: Jeremy Kerr [ Upstream commit 5d4bac9a5f4ef24b2482529bda6661a58e5b5b65 ] Although irqreturn_t is an enum, we treat it (and its enumeration constants) as a bitmask. However, bad_action_ret() uses a less-than operator to determine whether an irqreturn_t falls within allowable bit values,

<    5   6   7   8   9   10   11   12   13   14   >