RE: [PATCH 05/24] thunderbolt: Rework capability handling

On Mon, May 22 2017, 12:45 PM, Mika Westerberg wrote: > I'm not sure it is good idea to use bit fields here at all. I'm not an expert > in C > but I remember reading somewhere that they are not suitable for representing > fields inside hardware registers. >

RE: [PATCH 05/24] thunderbolt: Rework capability handling

On Mon, May 22 2017, 12:45 PM, Mika Westerberg wrote: > I'm not sure it is good idea to use bit fields here at all. I'm not an expert > in C > but I remember reading somewhere that they are not suitable for representing > fields inside hardware registers. >

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

On Sun, May 21 2017, 11:00 AM, Mika Westerberg wrote: > On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > > On Sun, May 21, 2017 at 05:29:47AM +0000, Levy, Amir (Jer) wrote: > > > >

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

On Sun, May 21 2017, 11:00 AM, Mika Westerberg wrote: > On Sun, May 21, 2017 at 10:40:41AM +0300, Mika Westerberg wrote: > > On Sun, May 21, 2017 at 07:35:21AM +0200, Lukas Wunner wrote: > > > On Sun, May 21, 2017 at 05:29:47AM +0000, Levy, Amir (Jer) wrote: > > > >

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > + > > + default: > > + sw->generation = 1; > > + break; > > If someone adds an entry for, say, a new TB3 controller to nhi_ids[] but > forgets > to

RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > + > > + default: > > + sw->generation = 1; > > + break; > > If someone adds an entry for, say, a new TB3 controller to nhi_ids[] but > forgets > to

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

On Fri, May 19 2017, 07:35 PM, mario.limoncie...@dell.com wrote: > Here's my setup: > System: I'm using is an XPS 9350 (Has Alpine Ridge). It's got NVM 16.0. BIOS > 1.4.13 TBT Device: Dell TB16 (which has AR in the cable and in dock - both > NVM 16.0). > Is it BIOS assist or native

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

On Fri, May 19 2017, 07:35 PM, mario.limoncie...@dell.com wrote: > Here's my setup: > System: I'm using is an XPS 9350 (Has Alpine Ridge). It's got NVM 16.0. BIOS > 1.4.13 TBT Device: Dell TB16 (which has AR in the cable and in dock - both > NVM 16.0). > Is it BIOS assist or native

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Tue, Nov 22 2016, 07:28 PM, Simon Guinot wrote: > Hi Amir, > > I tested the thunderbolt-icm driver (v9 series) on an Gigabyte > motherboard > (Z170X-UD5 TH-CF) with a Thunderbolt 3 controller (Alpine Ridge 4C). > > I can see that the network interface is well created when the > motherboard

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Tue, Nov 22 2016, 07:28 PM, Simon Guinot wrote: > Hi Amir, > > I tested the thunderbolt-icm driver (v9 series) on an Gigabyte > motherboard > (Z170X-UD5 TH-CF) with a Thunderbolt 3 controller (Alpine Ridge 4C). > > I can see that the network interface is well created when the > motherboard

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Fri, Nov 18 2016, 12:07 PM, gre...@linuxfoundation.org wrote: > On Fri, Nov 18, 2016 at 08:48:36AM +0000, Levy, Amir (Jer) wrote: > > > BTW, it is quite a shame that the Thunderbolt firmware version can't > > > be read from Linux. > > > > > > > This is

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Fri, Nov 18 2016, 12:07 PM, gre...@linuxfoundation.org wrote: > On Fri, Nov 18, 2016 at 08:48:36AM +0000, Levy, Amir (Jer) wrote: > > > BTW, it is quite a shame that the Thunderbolt firmware version can't > > > be read from Linux. > > > > > > > This is

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > On Wed, Nov 09, 2016 at 03:42:53PM +0000, Levy, Amir (Jer) wrote: > > On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > > > Hi Amir, > > > > > > I have an ASUS "All Series/Z87-DELUXE/QUAD" motherb

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Tue, Nov 15 2016, 12:59 PM, Simon Guinot wrote: > On Wed, Nov 09, 2016 at 03:42:53PM +0000, Levy, Amir (Jer) wrote: > > On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > > > Hi Amir, > > > > > > I have an ASUS "All Series/Z87-DELUXE/QUAD" motherb

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Thu, Nov 10 2016, 01:44 PM, Greg KH wrote: > On Thu, Nov 10, 2016 at 11:39:19AM +0000, Levy, Amir (Jer) wrote: > > > And how about getting some internal-Intel kernel developers to > > > review and sign-off on this code? Don't make the community do the > > &g

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Thu, Nov 10 2016, 01:44 PM, Greg KH wrote: > On Thu, Nov 10, 2016 at 11:39:19AM +0000, Levy, Amir (Jer) wrote: > > > And how about getting some internal-Intel kernel developers to > > > review and sign-off on this code? Don't make the community do the > > &g

RE: [PATCH v9 7/8] thunderbolt: Networking doc

On Wed, Nov 9 2016, 06:00 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:07PM +0200, Amir Levy wrote: > > Adding Thunderbolt(TM) networking documentation. > > > > Signed-off-by: Amir Levy > > --- > > Documentation/00-INDEX | 2 + > >

RE: [PATCH v9 7/8] thunderbolt: Networking doc

On Wed, Nov 9 2016, 06:00 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:07PM +0200, Amir Levy wrote: > > Adding Thunderbolt(TM) networking documentation. > > > > Signed-off-by: Amir Levy > > --- > > Documentation/00-INDEX | 2 + > >

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Wed, Nov 9 2016, 06:02 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Wed, Nov 9 2016, 06:02 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Wed, Nov 9 2016, 04:36 PM, Simon Guinot wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between

RE: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Fri, Sep 30 2016, 09:40 AM, David Miller wrote: > From: Greg KH > Date: Fri, 30 Sep 2016 08:30:05 +0200 > > > On Fri, Sep 30, 2016 at 01:55:55AM -0400, David Miller wrote: > >> From: Amir Levy > >> Date: Wed, 28 Sep 2016 17:44:22 +0300 >

RE: [PATCH v8 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

On Fri, Sep 30 2016, 09:40 AM, David Miller wrote: > From: Greg KH > Date: Fri, 30 Sep 2016 08:30:05 +0200 > > > On Fri, Sep 30, 2016 at 01:55:55AM -0400, David Miller wrote: > >> From: Amir Levy > >> Date: Wed, 28 Sep 2016 17:44:22 +0300 > >> > >> > This driver enables Thunderbolt Networking

RE: [PATCH v6 2/8] thunderbolt: Updating the register definitions

On Sun, Sep 11 2016, 03:02 AM, Andreas Noever wrote: > On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy wrote: > > Adding more Thunderbolt(TM) register definitions and some helper > > macros. > > Thinking about this again I would prefer it if you would put your definitions >

RE: [PATCH v6 2/8] thunderbolt: Updating the register definitions

On Sun, Sep 11 2016, 03:02 AM, Andreas Noever wrote: > On Mon, Aug 1, 2016 at 2:23 PM, Amir Levy wrote: > > Adding more Thunderbolt(TM) register definitions and some helper > > macros. > > Thinking about this again I would prefer it if you would put your definitions > into a separate file under

RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

On Sun, Jul 31 2016, 09:45 PM, David Miller wrote: > From: "Levy, Amir (Jer)" <amir.jer.l...@intel.com> > Date: Sun, 31 Jul 2016 10:15:52 + > > > The network stack thinks it is Ethernet, it might not accept Runt > > frames, so the driver pads the fra

RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

On Sun, Jul 31 2016, 09:45 PM, David Miller wrote: > From: "Levy, Amir (Jer)" > Date: Sun, 31 Jul 2016 10:15:52 + > > > The network stack thinks it is Ethernet, it might not accept Runt > > frames, so the driver pads the frame in receive. > > The network

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

On Sat, Jul 30 2016, 12:03 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:17 +0300 > Amir Levy wrote: > > > +int nhi_send_message(struct tbt_nhi_ctxt *nhi_ctxt, enum pdf_value > pdf, > > +u32 msg_len, const u8 *msg, bool ignore_icm_resp) { > >

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

On Sat, Jul 30 2016, 12:03 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:17 +0300 > Amir Levy wrote: > > > +int nhi_send_message(struct tbt_nhi_ctxt *nhi_ctxt, enum pdf_value > pdf, > > +u32 msg_len, const u8 *msg, bool ignore_icm_resp) { > > Why not make msg a void *

RE: [PATCH v5 5/8] thunderbolt: Networking state machine

On Thu, Jul 28 2016, 02:35 PM, Lukas Wunner wrote: > On Thu, Jul 28, 2016 at 11:15:18AM +0300, Amir Levy wrote: > > + nhi_ctxt->net_devices[ > > + port_num].medium_sts = > > Looks like a carriage return slipped in here. Will be fixed.

RE: [PATCH v5 5/8] thunderbolt: Networking state machine

On Thu, Jul 28 2016, 02:35 PM, Lukas Wunner wrote: > On Thu, Jul 28, 2016 at 11:15:18AM +0300, Amir Levy wrote: > > + nhi_ctxt->net_devices[ > > + port_num].medium_sts = > > Looks like a carriage return slipped in here. Will be fixed.

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

On Sat, Jul 30 2016, 12:48 AM, Greg KH wrote: > On Fri, Jul 29, 2016 at 02:02:24PM -0700, Stephen Hemminger wrote: > > On Thu, 28 Jul 2016 11:15:17 +0300 > > Amir Levy wrote: > > > > > +static LIST_HEAD(controllers_list); static > > >

RE: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

On Sat, Jul 30 2016, 12:48 AM, Greg KH wrote: > On Fri, Jul 29, 2016 at 02:02:24PM -0700, Stephen Hemminger wrote: > > On Thu, 28 Jul 2016 11:15:17 +0300 > > Amir Levy wrote: > > > > > +static LIST_HEAD(controllers_list); static > > > +DECLARE_RWSEM(controllers_list_rwsem); > > > > Why use a

RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

On Sat, Jul 30 2016, 12:07 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:19 +0300 > Amir Levy wrote: > > > + /* pad short packets */ > > + if (unlikely(skb->len < ETH_ZLEN)) { > > + int pad_len = ETH_ZLEN - skb->len; > > +

RE: [PATCH v5 6/8] thunderbolt: Networking transmit and receive

On Sat, Jul 30 2016, 12:07 AM, Stephen Hemminger wrote: > On Thu, 28 Jul 2016 11:15:19 +0300 > Amir Levy wrote: > > > + /* pad short packets */ > > + if (unlikely(skb->len < ETH_ZLEN)) { > > + int pad_len = ETH_ZLEN - skb->len; > > + > > +

RE: [PATCH v4 5/7] thunderbolt: Networking state machine

On Mon, Jul 25 2016, 01:36 AM, Lukas Wunner wrote: > On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote: > > + const unique_id_be proto_uuid = > APPLE_THUNDERBOLT_IP_PROTOCOL_UUID; > > + > > + if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid, > > + sizeof(proto_uuid)) !=

RE: [PATCH v4 5/7] thunderbolt: Networking state machine

On Mon, Jul 25 2016, 01:36 AM, Lukas Wunner wrote: > On Mon, Jul 18, 2016 at 01:00:38PM +0300, Amir Levy wrote: > > + const unique_id_be proto_uuid = > APPLE_THUNDERBOLT_IP_PROTOCOL_UUID; > > + > > + if (memcmp(proto_uuid, hdr->apple_tbt_ip_proto_uuid, > > + sizeof(proto_uuid)) !=

RE: [PATCH v4 2/7] thunderbolt: Updating the register definitions

On Tue, Jul 26 2016, 10:39 AM, Andreas Noever wrote: > On Mon, Jul 18, 2016 at 12:00 PM, Amir Levy > wrote: > > Adding more Thunderbolt(TM) register definitions and some helper > > macros. > > > > Signed-off-by: Amir Levy > > --- > >

RE: [PATCH v4 2/7] thunderbolt: Updating the register definitions

On Tue, Jul 26 2016, 10:39 AM, Andreas Noever wrote: > On Mon, Jul 18, 2016 at 12:00 PM, Amir Levy > wrote: > > Adding more Thunderbolt(TM) register definitions and some helper > > macros. > > > > Signed-off-by: Amir Levy > > --- > > drivers/thunderbolt/nhi_regs.h | 109 > >

RE: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Tue, Jul 19 2016, 08:14 PM, Joe Perches wrote: > On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote: > > This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. > [] > >  Documentation/00-INDEX   |2 + > >  Documentation/thunderbolt-networking.txt |  135 ++ > >  

RE: [PATCH v4 0/7] thunderbolt: Introducing Thunderbolt(TM) networking

On Tue, Jul 19 2016, 08:14 PM, Joe Perches wrote: > On Mon, 2016-07-18 at 13:00 +0300, Amir Levy wrote: > > This is version 4 of Thunderbolt(TM) driver for non-Apple hardware. > [] > >  Documentation/00-INDEX   |2 + > >  Documentation/thunderbolt-networking.txt |  135 ++ > >  

RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

On Sat, Jul 16 2016, 12:53 AM, David Miller wrote: > From: "Levy, Amir (Jer)" <amir.jer.l...@intel.com> > Date: Fri, 15 Jul 2016 18:56:39 + > > > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > >> From: Amir Levy <amir.jer.l...@intel.com&

RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

On Sat, Jul 16 2016, 12:53 AM, David Miller wrote: > From: "Levy, Amir (Jer)" > Date: Fri, 15 Jul 2016 18:56:39 + > > > On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > >> From: Amir Levy > >> Date: Thu, 14 Jul 2016 14:28:16 +0300 > >&

RE: [PATCH v3 6/8] thunderbolt: Networking state machine

On Fri, Jul 15 2016, 03:25 AM, Paul Gortmaker wrote: > > diff --git a/drivers/thunderbolt/icm/net.c > > b/drivers/thunderbolt/icm/net.c new file mode 100644 index > > 000..e983dfb > > --- /dev/null > > +++ b/drivers/thunderbolt/icm/net.c > > @@ -0,0 +1,802 @@ > > >

RE: [PATCH v3 6/8] thunderbolt: Networking state machine

On Fri, Jul 15 2016, 03:25 AM, Paul Gortmaker wrote: > > diff --git a/drivers/thunderbolt/icm/net.c > > b/drivers/thunderbolt/icm/net.c new file mode 100644 index > > 000..e983dfb > > --- /dev/null > > +++ b/drivers/thunderbolt/icm/net.c > > @@ -0,0 +1,802 @@ > > >

RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > From: Amir Levy > Date: Thu, 14 Jul 2016 14:28:16 +0300 > > > Adding the new Thunderbolt(TM) device IDs to the list. > > > > Signed-off-by: Amir Levy > > Unless these PCI-IDs, all of them,

RE: [PATCH v3 2/8] thunderbolt: Updating device IDs

On Fri, Jul 15 2016, 09:49 PM, David Miller wrote: > From: Amir Levy > Date: Thu, 14 Jul 2016 14:28:16 +0300 > > > Adding the new Thunderbolt(TM) device IDs to the list. > > > > Signed-off-by: Amir Levy > > Unless these PCI-IDs, all of them, are going to be used in multiple spots in > the >

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

On Thu, Jul 14 2016, 06:08 PM, Rosen, Rami wrote: > Hi Amir, Hi Rami, > Here are my 2 cents: > > This method always returns true, should be void (unless you will change > PDF_ERROR_NOTIFICATION or other pdf values to return false), and > likewise its invocation should not check return value. >

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

On Thu, Jul 14 2016, 06:08 PM, Rosen, Rami wrote: > Hi Amir, Hi Rami, > Here are my 2 cents: > > This method always returns true, should be void (unless you will change > PDF_ERROR_NOTIFICATION or other pdf values to return false), and > likewise its invocation should not check return value. >

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi Tomas, Thanks for your comments. On Thu, Jul 14 2016, 03:44 PM, Winkler, Tomas wrote: > > +/* NHI genetlink commands */ > > +enum { > > + NHI_CMD_UNSPEC, > > + NHI_CMD_SUBSCRIBE, > > + NHI_CMD_UNSUBSCRIBE, > > + NHI_CMD_QUERY_INFORMATION, > > + NHI_CMD_MSG_TO_ICM, > > +

RE: [PATCH v3 5/8] thunderbolt: Communication with the ICM (firmware)

Hi Tomas, Thanks for your comments. On Thu, Jul 14 2016, 03:44 PM, Winkler, Tomas wrote: > > +/* NHI genetlink commands */ > > +enum { > > + NHI_CMD_UNSPEC, > > + NHI_CMD_SUBSCRIBE, > > + NHI_CMD_UNSUBSCRIBE, > > + NHI_CMD_QUERY_INFORMATION, > > + NHI_CMD_MSG_TO_ICM, > > +

RE: [PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

On Wed, Jul 13 2016, 01:19 AM, Andreas Noever wrote: > Since this is now a separate driver I would prefer if it was in a different > (sub)directory (maybe thunderbolt/icm?). > Thanks Andreas for the comment, will change it in the next patch. Any more comments?

RE: [PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

On Wed, Jul 13 2016, 01:19 AM, Andreas Noever wrote: > Since this is now a separate driver I would prefer if it was in a different > (sub)directory (maybe thunderbolt/icm?). > Thanks Andreas for the comment, will change it in the next patch. Any more comments?

RE: [PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

On Wed, Jun 29 2016, 11:35 AM, Levy, Amir (Jer) wrote: > This is version 2 of Thunderbolt(TM) driver for non-Apple hardware. > > Changes since v1: > - Separation to 2 modules. > - Moved ICM specific registers definition to ICM header file. > - Added new Thunderbolt device

RE: [PATCH v2 0/8] thunderbolt: Introducing Thunderbolt(TM) networking

On Wed, Jun 29 2016, 11:35 AM, Levy, Amir (Jer) wrote: > This is version 2 of Thunderbolt(TM) driver for non-Apple hardware. > > Changes since v1: > - Separation to 2 modules. > - Moved ICM specific registers definition to ICM header file. > - Added new Thunderbolt device

RE: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

On 2016-06-22 Arnd Bergmann wrote: > On Wednesday, June 22, 2016 11:24:50 AM CEST Tomas Winkler wrote: > > On Tue, Jun 21, 2016 at 12:02 PM, Tomas Winkler > wrote: > > > On Tue, May 3, 2016 at 9:36 AM, Arnd Bergmann > wrote: > > >> On Monday 02 May 2016 16:32:25

RE: [PATCH v2] byteswap: try to avoid __builtin_constant_p gcc bug

On 2016-06-22 Arnd Bergmann wrote: > On Wednesday, June 22, 2016 11:24:50 AM CEST Tomas Winkler wrote: > > On Tue, Jun 21, 2016 at 12:02 PM, Tomas Winkler > wrote: > > > On Tue, May 3, 2016 at 9:36 AM, Arnd Bergmann > wrote: > > >> On Monday 02 May 2016 16:32:25 Andrew Morton wrote: > > > >>