Re: [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls

2020-12-10 Thread Libo Chen
On 12/10/20 4:45 PM, Steven Rostedt wrote: On Thu, 10 Dec 2020 15:09:46 -0800 Libo Chen wrote: Hi Steven, Just wanna check in and check on the status of it. I have it applied in my local repo (even in my for-next, which I forgot to push :-p) I've been testing it on all my build machines

Re: [PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls

2020-12-10 Thread Libo Chen
On 11/30/20 7:25 PM, Steven Rostedt wrote: On Sun, 29 Nov 2020 20:32:56 -0500 Masayoshi Mizuma wrote: On Fri, Nov 20, 2020 at 06:12:43PM -0800, Libo Chen wrote: This issue was first noticed when I was testing different kernels on Oracle Linux 8 which as Fedora 30+ adopts BLS as default

[PATCH 1/1] ktest.pl: Fix incorrect reboot for grub2bls

2020-11-20 Thread Libo Chen
OT_TYPE is "grub2bls" then we can boot to the correct kernel. Fixes: ac2466456eaa ("ktest: introduce grub2bls REBOOT_TYPE option") Signed-off-by: Libo Chen --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest

Re: balance storm

2014-05-29 Thread Libo Chen
On 2014/5/28 19:55, Mike Galbraith wrote: > On Wed, 2014-05-28 at 19:43 +0800, Libo Chen wrote: >> On 2014/5/28 17:08, Thomas Gleixner wrote: >>> On Wed, 28 May 2014, Libo Chen wrote: >>> >>>> On 2014/5/28 9:53, Mike Galbraith wrote: >>>>&

Re: balance storm

2014-05-29 Thread Libo Chen
On 2014/5/28 17:08, Thomas Gleixner wrote: > On Wed, 28 May 2014, Libo Chen wrote: > >> On 2014/5/28 9:53, Mike Galbraith wrote: >>> On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote: >>> >>>> oh yes, no tsc only hpet in my box. >>> >

Re: balance storm

2014-05-29 Thread Libo Chen
On 2014/5/28 17:08, Thomas Gleixner wrote: On Wed, 28 May 2014, Libo Chen wrote: On 2014/5/28 9:53, Mike Galbraith wrote: On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote: oh yes, no tsc only hpet in my box. Making poor E5-2658 box a crippled wreck. yes,it is. But cpu usage

Re: balance storm

2014-05-29 Thread Libo Chen
On 2014/5/28 19:55, Mike Galbraith wrote: On Wed, 2014-05-28 at 19:43 +0800, Libo Chen wrote: On 2014/5/28 17:08, Thomas Gleixner wrote: On Wed, 28 May 2014, Libo Chen wrote: On 2014/5/28 9:53, Mike Galbraith wrote: On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote: oh yes, no tsc only

Re: balance storm

2014-05-28 Thread Libo Chen
On 2014/5/28 17:08, Thomas Gleixner wrote: > On Wed, 28 May 2014, Libo Chen wrote: > >> On 2014/5/28 9:53, Mike Galbraith wrote: >>> On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote: >>> >>>> oh yes, no tsc only hpet in my box. >>> >

Re: balance storm

2014-05-28 Thread Libo Chen
On 2014/5/28 9:53, Mike Galbraith wrote: > On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote: > >> oh yes, no tsc only hpet in my box. > > Making poor E5-2658 box a crippled wreck. yes,it is. But cpu usage will be down from 15% to 5% when binding cpu, so maybe read_hpet is

Re: balance storm

2014-05-28 Thread Libo Chen
On 2014/5/28 9:53, Mike Galbraith wrote: On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote: oh yes, no tsc only hpet in my box. Making poor E5-2658 box a crippled wreck. yes,it is. But cpu usage will be down from 15% to 5% when binding cpu, so maybe read_hpet is not the root cause

Re: balance storm

2014-05-28 Thread Libo Chen
On 2014/5/28 17:08, Thomas Gleixner wrote: On Wed, 28 May 2014, Libo Chen wrote: On 2014/5/28 9:53, Mike Galbraith wrote: On Wed, 2014-05-28 at 09:04 +0800, Libo Chen wrote: oh yes, no tsc only hpet in my box. Making poor E5-2658 box a crippled wreck. yes,it is. But cpu usage

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/28 4:53, Thomas Gleixner wrote: > On Tue, 27 May 2014, Libo Chen wrote: >> On 2014/5/27 17:55, Mike Galbraith wrote: >>> On Tue, 2014-05-27 at 15:56 +0800, Libo Chen wrote: >>>>> On 2014/5/26 22:19, Mike Galbraith wrote: >>>>>>&

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 21:20, Mike Galbraith wrote: > On Tue, 2014-05-27 at 20:50 +0800, Libo Chen wrote: > >> in my box: >> >> perf top -g --sort=symbol >> >> Events: 3K cycles >> 73.27% [k] read_hpet >> 4.30% [k] _raw_spin_lock_irqsave >> 1.

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 18:55, Mike Galbraith wrote: > On Tue, 2014-05-27 at 12:43 +0200, Peter Zijlstra wrote: >> On Tue, May 27, 2014 at 12:05:33PM +0200, Mike Galbraith wrote: >>> On Tue, 2014-05-27 at 11:48 +0200, Peter Zijlstra wrote: >>> So I suppose this is due to the select_idle_sibling()

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 17:48, Peter Zijlstra wrote: > So: > > 1) what kind of weird ass workload is that? Why are you waking up so > often to do no work? it's just a testcase, I agree it doesn`t exist in real world. > > 2) turning on/off share_pkg_resource is a horrid hack whichever way > aruond you

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 17:55, Mike Galbraith wrote: > On Tue, 2014-05-27 at 15:56 +0800, Libo Chen wrote: >> > On 2014/5/26 22:19, Mike Galbraith wrote: >>> > > On Mon, 2014-05-26 at 20:16 +0800, Libo Chen wrote: >>>> > >> On 2014/5/26 13:11, Mike Galbraith

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/26 22:19, Mike Galbraith wrote: > On Mon, 2014-05-26 at 20:16 +0800, Libo Chen wrote: >> On 2014/5/26 13:11, Mike Galbraith wrote: > >>> Your synthetic test is the absolute worst case scenario. There has to >>> be work between wakeups for select_idl

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/26 22:03, Mike Galbraith wrote: > On Mon, 2014-05-26 at 19:49 +0800, Libo Chen wrote: > >> how to turn off SD_SHARE_PKG_RESOURCES in userspace ? > > I use a script Ingo gave me years and years ago to > twiddle /proc/sys/kernel/sched_domain/cpuN/domainN/flags

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/26 22:03, Mike Galbraith wrote: On Mon, 2014-05-26 at 19:49 +0800, Libo Chen wrote: how to turn off SD_SHARE_PKG_RESOURCES in userspace ? I use a script Ingo gave me years and years ago to twiddle /proc/sys/kernel/sched_domain/cpuN/domainN/flags domain wise. Doing that won't do

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/26 22:19, Mike Galbraith wrote: On Mon, 2014-05-26 at 20:16 +0800, Libo Chen wrote: On 2014/5/26 13:11, Mike Galbraith wrote: Your synthetic test is the absolute worst case scenario. There has to be work between wakeups for select_idle_sibling() to have any chance whatsoever

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 17:55, Mike Galbraith wrote: On Tue, 2014-05-27 at 15:56 +0800, Libo Chen wrote: On 2014/5/26 22:19, Mike Galbraith wrote: On Mon, 2014-05-26 at 20:16 +0800, Libo Chen wrote: On 2014/5/26 13:11, Mike Galbraith wrote: Your synthetic test is the absolute worst case

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 17:48, Peter Zijlstra wrote: So: 1) what kind of weird ass workload is that? Why are you waking up so often to do no work? it's just a testcase, I agree it doesn`t exist in real world. 2) turning on/off share_pkg_resource is a horrid hack whichever way aruond you turn it.

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 18:55, Mike Galbraith wrote: On Tue, 2014-05-27 at 12:43 +0200, Peter Zijlstra wrote: On Tue, May 27, 2014 at 12:05:33PM +0200, Mike Galbraith wrote: On Tue, 2014-05-27 at 11:48 +0200, Peter Zijlstra wrote: So I suppose this is due to the select_idle_sibling() nonsense again,

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/27 21:20, Mike Galbraith wrote: On Tue, 2014-05-27 at 20:50 +0800, Libo Chen wrote: in my box: perf top -g --sort=symbol Events: 3K cycles 73.27% [k] read_hpet 4.30% [k] _raw_spin_lock_irqsave 1.88% [k] __schedule 1.00% [k] idle_cpu 0.91% [k

Re: balance storm

2014-05-27 Thread Libo Chen
On 2014/5/28 4:53, Thomas Gleixner wrote: On Tue, 27 May 2014, Libo Chen wrote: On 2014/5/27 17:55, Mike Galbraith wrote: On Tue, 2014-05-27 at 15:56 +0800, Libo Chen wrote: On 2014/5/26 22:19, Mike Galbraith wrote: On Mon, 2014-05-26 at 20:16 +0800, Libo Chen wrote: On 2014/5/26 13:11

Re: balance storm

2014-05-26 Thread Libo Chen
On 2014/5/26 13:11, Mike Galbraith wrote: > On Mon, 2014-05-26 at 11:04 +0800, Libo Chen wrote: >> hi, >> my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on >> 3.4.24stable, startup 50 same process, every process is sample: >> >>

Re: balance storm

2014-05-26 Thread Libo Chen
On 2014/5/26 15:56, Mike Galbraith wrote: > On Mon, 2014-05-26 at 11:04 +0800, Libo Chen wrote: >> hi, >> my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on >> 3.4.24stable, startup 50 same process, every process is sample: >> >>

Re: balance storm

2014-05-26 Thread Libo Chen
On 2014/5/26 15:56, Mike Galbraith wrote: On Mon, 2014-05-26 at 11:04 +0800, Libo Chen wrote: hi, my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on 3.4.24stable, startup 50 same process, every process is sample: #include unistd.h int main

Re: balance storm

2014-05-26 Thread Libo Chen
On 2014/5/26 13:11, Mike Galbraith wrote: On Mon, 2014-05-26 at 11:04 +0800, Libo Chen wrote: hi, my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on 3.4.24stable, startup 50 same process, every process is sample: #include unistd.h int main

balance storm

2014-05-25 Thread Libo Chen
hi, my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on 3.4.24stable, startup 50 same process, every process is sample: #include int main() { for (;;) { unsigned int i = 0;

balance storm

2014-05-25 Thread Libo Chen
hi, my box has 16 cpu (E5-2658,8 core, 2 thread per core), i did a test on 3.4.24stable, startup 50 same process, every process is sample: #include unistd.h int main() { for (;;) { unsigned int i = 0;

Re: [PATCH v2] scsi: Add 'retry_timeout' to avoid infinite command retry

2014-02-06 Thread Libo Chen
On 2014/2/7 13:46, James Bottomley wrote: > On Fri, 2014-02-07 at 09:22 +0900, Eiichi Tsukata wrote: >> Currently, scsi error handling in scsi_io_completion() tries to >> unconditionally requeue scsi command when device keeps some error state. >> For example, UNIT_ATTENTION causes infinite retry

Re: [PATCH v2] scsi: Add 'retry_timeout' to avoid infinite command retry

2014-02-06 Thread Libo Chen
On 2014/2/7 13:46, James Bottomley wrote: On Fri, 2014-02-07 at 09:22 +0900, Eiichi Tsukata wrote: Currently, scsi error handling in scsi_io_completion() tries to unconditionally requeue scsi command when device keeps some error state. For example, UNIT_ATTENTION causes infinite retry with

Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff

2014-01-07 Thread Libo Chen
On 2014/1/3 13:34, David Miller wrote: > From: Libo Chen > Date: Fri, 3 Jan 2014 11:11:04 +0800 > >> >> introduce backup_classid to struct skbuff, >> we can use it to backup sk_classid when net_ns switch. >> >> Signed-off-by: Libo Chen &g

Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff

2014-01-07 Thread Libo Chen
On 2014/1/3 13:34, David Miller wrote: From: Libo Chen clbchenlibo.c...@huawei.com Date: Fri, 3 Jan 2014 11:11:04 +0800 introduce backup_classid to struct skbuff, we can use it to backup sk_classid when net_ns switch. Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com Sorry, no new

Re: [RFC PATCH net-next 0/4] net_cls for sys container

2014-01-06 Thread Libo Chen
yes On 2014/1/6 16:42, Gao feng wrote: > On 01/06/2014 03:54 PM, Libo Chen wrote: >> On 2014/1/3 13:20, Cong Wang wrote: >>> On Thu, Jan 2, 2014 at 7:11 PM, Libo Chen >>> wrote: >>>> Hi guys, >>>> >>>> Now, lx

Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff

2014-01-06 Thread Libo Chen
On 2014/1/3 14:21, John Fastabend wrote: > On 01/02/2014 09:34 PM, David Miller wrote: >> From: Libo Chen >> Date: Fri, 3 Jan 2014 11:11:04 +0800 >> >>> >>> introduce backup_classid to struct skbuff, >>> we can use it to backup sk_classid when

Re: [RFC PATCH net-next 0/4] net_cls for sys container

2014-01-06 Thread Libo Chen
yes On 2014/1/6 16:42, Gao feng wrote: On 01/06/2014 03:54 PM, Libo Chen wrote: On 2014/1/3 13:20, Cong Wang wrote: On Thu, Jan 2, 2014 at 7:11 PM, Libo Chen clbchenlibo.c...@huawei.com wrote: Hi guys, Now, lxc created with veth can not be under control by cls_cgroup. the former

Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff

2014-01-06 Thread Libo Chen
On 2014/1/3 14:21, John Fastabend wrote: On 01/02/2014 09:34 PM, David Miller wrote: From: Libo Chen clbchenlibo.c...@huawei.com Date: Fri, 3 Jan 2014 11:11:04 +0800 introduce backup_classid to struct skbuff, we can use it to backup sk_classid when net_ns switch. Signed-off-by: Libo Chen

Re: [RFC PATCH net-next 0/4] net_cls for sys container

2014-01-05 Thread Libo Chen
On 2014/1/3 13:20, Cong Wang wrote: > On Thu, Jan 2, 2014 at 7:11 PM, Libo Chen wrote: >> Hi guys, >> >> Now, lxc created with veth can not be under control by >> cls_cgroup. >> >> the former discussion: >> http://lkml.indiana.edu/hypermail/linux/ker

Re: [RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns

2014-01-05 Thread Libo Chen
On 2014/1/3 18:45, Sergei Shtylyov wrote: > Hello. > > On 03-01-2014 7:11, Libo Chen wrote: > >> dev_forward_skb will clear skb->sk, so we need save classid >> before that, otherwise the skb can not be under control by >> net_cls. > >> Signed-off-by:

Re: [RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns

2014-01-05 Thread Libo Chen
On 2014/1/3 18:45, Sergei Shtylyov wrote: Hello. On 03-01-2014 7:11, Libo Chen wrote: dev_forward_skb will clear skb-sk, so we need save classid before that, otherwise the skb can not be under control by net_cls. Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- drivers/net

Re: [RFC PATCH net-next 0/4] net_cls for sys container

2014-01-05 Thread Libo Chen
On 2014/1/3 13:20, Cong Wang wrote: On Thu, Jan 2, 2014 at 7:11 PM, Libo Chen clbchenlibo.c...@huawei.com wrote: Hi guys, Now, lxc created with veth can not be under control by cls_cgroup. the former discussion: http://lkml.indiana.edu/hypermail/linux/kernel/1312.1/00214.html In short

[RFC PATCH net-next 0/4] net_cls for sys container

2014-01-02 Thread Libo Chen
() in veth_xmit(). so I add backup_classid in struct sk_buffer to save classid before dev_forward_skb(). In cls_cgroup_classify(), if skb->sk is NULL, we can try to restore classid form skb->bk_classid. Libo Chen (4): net: introduce bk_classid to struct sk_buff cls_cgroup: introduce a

[RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns

2014-01-02 Thread Libo Chen
dev_forward_skb will clear skb->sk, so we need save classid before that, otherwise the skb can not be under control by net_cls. Signed-off-by: Libo Chen --- drivers/net/veth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/veth.c b/drivers/net/veth.c index 2ec2

[RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff

2014-01-02 Thread Libo Chen
introduce backup_classid to struct skbuff, we can use it to backup sk_classid when net_ns switch. Signed-off-by: Libo Chen --- include/linux/skbuff.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index c5cd016..b76e871 100644

[RFC PATCH net-next 4/4] cls_cgroup: restore classid from skb->sk_classid

2014-01-02 Thread Libo Chen
if skb->sk is NULL, we can try to restore from skb->bk_classid, because we may have saved it. Signed-off-by: Libo Chen --- net/sched/cls_cgroup.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c index d228a5d..6

[RFC PATCH net-next 2/4] cls_cgroup: introduce a helper: bk_cls_classid()

2014-01-02 Thread Libo Chen
it can save classid from skb->sk->sk_classid to skb->bk_classid Signed-off-by: Libo Chen --- include/net/cls_cgroup.h | 11 +++ net/sched/cls_cgroup.c | 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/net/cls_cgroup.h b/include/net/cls_cgrou

[RFC PATCH net-next 4/4] cls_cgroup: restore classid from skb-sk_classid

2014-01-02 Thread Libo Chen
if skb-sk is NULL, we can try to restore from skb-bk_classid, because we may have saved it. Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- net/sched/cls_cgroup.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c

[RFC PATCH net-next 2/4] cls_cgroup: introduce a helper: bk_cls_classid()

2014-01-02 Thread Libo Chen
it can save classid from skb-sk-sk_classid to skb-bk_classid Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- include/net/cls_cgroup.h | 11 +++ net/sched/cls_cgroup.c | 1 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/net/cls_cgroup.h b/include/net

[RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff

2014-01-02 Thread Libo Chen
introduce backup_classid to struct skbuff, we can use it to backup sk_classid when net_ns switch. Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- include/linux/skbuff.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index c5cd016

[RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns

2014-01-02 Thread Libo Chen
dev_forward_skb will clear skb-sk, so we need save classid before that, otherwise the skb can not be under control by net_cls. Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- drivers/net/veth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/veth.c b/drivers/net

[RFC PATCH net-next 0/4] net_cls for sys container

2014-01-02 Thread Libo Chen
() in veth_xmit(). so I add backup_classid in struct sk_buffer to save classid before dev_forward_skb(). In cls_cgroup_classify(), if skb-sk is NULL, we can try to restore classid form skb-bk_classid. Libo Chen (4): net: introduce bk_classid to struct sk_buff cls_cgroup: introduce a helper

Re: cgroup filter on physics interface can't control container

2013-12-18 Thread Libo Chen
assid and put it in skb->sk pointer. can we put sk_classid form struct sock to struct sk_buff? then sk_classid will not be affected by dev_forward_skb()->skb_scrub_packet() ? any comment are welcome! thanks, Libo On 2013/12/12 20:18, Libo Chen wrote: > ping... > > On 2013

Re: cgroup filter on physics interface can't control container

2013-12-18 Thread Libo Chen
it in skb-sk pointer. can we put sk_classid form struct sock to struct sk_buff? then sk_classid will not be affected by dev_forward_skb()-skb_scrub_packet() ? any comment are welcome! thanks, Libo On 2013/12/12 20:18, Libo Chen wrote: ping... On 2013/12/9 10:32, Libo Chen wrote: hello network

Re: cgroup filter on physics interface can't control container

2013-12-12 Thread Libo Chen
ping... On 2013/12/9 10:32, Libo Chen wrote: > hello network hackers, > > A linux container was builded with veth pair(veth0 inside container, > veth1 outside container), > > the config as below: > > lxc.network.type = veth > lxc.network.flags = up

Re: cgroup filter on physics interface can't control container

2013-12-12 Thread Libo Chen
ping... On 2013/12/9 10:32, Libo Chen wrote: hello network hackers, A linux container was builded with veth pair(veth0 inside container, veth1 outside container), the config as below: lxc.network.type = veth lxc.network.flags = up lxc.network.link = br0 // base on eth0

[PATCH] security: ima: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen --- security/integrity/ima/ima_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index c38bbce..6d76d4a 100644 --- a/security/integrity/ima/ima_api.c +++ b/security/integrity/ima

[PATCH] fs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 121f11f..a146e2a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2780,7 +2780,7 @@ static inline bool dir_emit(struct

[PATCH RESEND] fs: btrfs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen --- fs/btrfs/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) - just change style diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a111622..fdfc0d7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2690,7 +2690,7 @@ static long

[PATCH] fs: btrfs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen f_dentry->d_inode; + struct inode *src = file_inode(file); struct file *dst_file = NULL; struct inode *dst; u64 off; @@ -2779,7 +2779,7 @@ static long btrfs_ioctl_file_extent_same(struct file *file, if (file->f_pa

[PATCH] fs: ceph: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen --- fs/ceph/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 3de8982..7549bd6 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1018,7 +1018,7 @@ static long ceph_fallocate(struct file *file, int mode

[PATCH] fs: cifs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen --- fs/cifs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/ioctl.c b/fs/cifs/ioctl.c index 7749230..45cb59b 100644 --- a/fs/cifs/ioctl.c +++ b/fs/cifs/ioctl.c @@ -85,7 +85,7 @@ static long cifs_ioctl_clone(unsigned int xid, struct

[PATCH] fs: cifs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- fs/cifs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/ioctl.c b/fs/cifs/ioctl.c index 7749230..45cb59b 100644 --- a/fs/cifs/ioctl.c +++ b/fs/cifs/ioctl.c @@ -85,7 +85,7 @@ static long cifs_ioctl_clone

[PATCH] fs: ceph: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- fs/ceph/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 3de8982..7549bd6 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -1018,7 +1018,7 @@ static long ceph_fallocate

[PATCH] fs: btrfs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- fs/btrfs/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a111622..fdfc0d7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2690,7 +2690,7 @@ static long

[PATCH RESEND] fs: btrfs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- fs/btrfs/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) - just change style diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a111622..fdfc0d7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2690,7

[PATCH] fs: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- include/linux/fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/fs.h b/include/linux/fs.h index 121f11f..a146e2a 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2780,7 +2780,7 @@ static

[PATCH] security: ima: new helper: file_inode(file)

2013-12-10 Thread Libo Chen
Signed-off-by: Libo Chen clbchenlibo.c...@huawei.com --- security/integrity/ima/ima_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index c38bbce..6d76d4a 100644 --- a/security/integrity/ima/ima_api.c

cgroup filter on physics interface can't container

2013-12-08 Thread Libo Chen
hello network hackers, A linux container was builded with veth pair(veth0 inside container, veth1 outside container), the config as below: lxc.network.type = veth lxc.network.flags = up lxc.network.link = br0 // base on eth0 lxc.network.name = eth0 lxc.network.ipv4 =

cgroup filter on physics interface can't container

2013-12-08 Thread Libo Chen
hello network hackers, A linux container was builded with veth pair(veth0 inside container, veth1 outside container), the config as below: lxc.network.type = veth lxc.network.flags = up lxc.network.link = br0 // base on eth0 lxc.network.name = eth0 lxc.network.ipv4 =

Re: Q: use vlan in container

2013-11-29 Thread Libo Chen
On 2013/11/29 22:18, Serge Hallyn wrote: > Quoting Libo Chen (clbchenlibo.c...@huawei.com): >> On 2013/11/29 13:05, Serge Hallyn wrote: >>> Quoting Libo Chen (clbchenlibo.c...@huawei.com): >>>> Hello LXC experts, >>>> >>>>I meet a probl

Re: Q: use vlan in container

2013-11-29 Thread Libo Chen
On 2013/11/29 22:18, Serge Hallyn wrote: Quoting Libo Chen (clbchenlibo.c...@huawei.com): On 2013/11/29 13:05, Serge Hallyn wrote: Quoting Libo Chen (clbchenlibo.c...@huawei.com): Hello LXC experts, I meet a problem. When using vlan as network device in suse11 system container, I can

Re: Q: use vlan in container

2013-11-28 Thread Libo Chen
On 2013/11/29 13:05, Serge Hallyn wrote: > Quoting Libo Chen (clbchenlibo.c...@huawei.com): >> Hello LXC experts, >> >> I meet a problem. When using vlan as network device in suse11 system >> container, >> I can not use halt to stop this container. It hun

Re: Q: use vlan in container

2013-11-28 Thread Libo Chen
On 2013/11/29 13:05, Serge Hallyn wrote: Quoting Libo Chen (clbchenlibo.c...@huawei.com): Hello LXC experts, I meet a problem. When using vlan as network device in suse11 system container, I can not use halt to stop this container. It hung on eth0 is still used from interfaces eth0

Q: use vlan in container

2013-11-27 Thread Libo Chen
Hello LXC experts, I meet a problem. When using vlan as network device in suse11 system container, I can not use halt to stop this container. It hung on "eth0 is still used from interfaces eth0" in cycle. The config file: lxc.network.type = vlan lxc.network.flags = up lxc.network.link

Q: use vlan in container

2013-11-27 Thread Libo Chen
Hello LXC experts, I meet a problem. When using vlan as network device in suse11 system container, I can not use halt to stop this container. It hung on eth0 is still used from interfaces eth0 in cycle. The config file: lxc.network.type = vlan lxc.network.flags = up lxc.network.link =

[PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease node device_node refcount after task completion Signed-off-by: Libo Chen --- drivers/input/misc/twl4030-vibra.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c index 68a5f33..b8d1526

[PATCH 1/3] driver: input: 88pm860x-ts: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease np device_node refcount after task completion Signed-off-by: Libo Chen --- drivers/input/touchscreen/88pm860x-ts.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/88pm860x-ts.c b/drivers/input/touchscreen

[PATCH 3/3] driver: input: twl6040-vibra: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease twl6040_core_node device_node refcount after task completion There are two ways to implement the function of_node_put through the marco CONFIG_OF_DYNAMIC, so it is save to call directly. Signed-off-by: Libo Chen --- drivers/input/misc/twl6040-vibra.c |3 +++ 1 files changed, 3

[PATCH 0/3] driver: input: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease np device_node refcount after task completion Libo Chen (3): driver: input: 88pm860x-ts: fix missing of_node_put driver: input: twl4030-vibra: fix missing of_node_put driver: input: twl6040-vibra: fix missing of_node_put drivers/input/misc/twl4030-vibra.c |4

[PATCH 0/3] driver: input: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease np device_node refcount after task completion Libo Chen (3): driver: input: 88pm860x-ts: fix missing of_node_put driver: input: twl4030-vibra: fix missing of_node_put driver: input: twl6040-vibra: fix missing of_node_put drivers/input/misc/twl4030-vibra.c |4

[PATCH 1/3] driver: input: 88pm860x-ts: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease np device_node refcount after task completion Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/input/touchscreen/88pm860x-ts.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/88pm860x-ts.c b/drivers

[PATCH 3/3] driver: input: twl6040-vibra: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease twl6040_core_node device_node refcount after task completion There are two ways to implement the function of_node_put through the marco CONFIG_OF_DYNAMIC, so it is save to call directly. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/input/misc/twl6040-vibra.c |3 +++ 1

[PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put

2013-08-31 Thread Libo Chen
decrease node device_node refcount after task completion Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/input/misc/twl4030-vibra.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c

[PATCH RESEND 3/4] usb: phy-tegra-usb: use platform_{get,set}_drvdata()

2013-08-29 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 files changed, 1 inserti

[PATCH RESEND 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-29 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/host/r8a66597-hcd.c |4 ++-- 1 files changed, 2 inserti

[PATCH RESEND 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-29 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with of-dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/usb/host/r8a66597-hcd.c |4 ++-- 1 files

[PATCH RESEND 3/4] usb: phy-tegra-usb: use platform_{get,set}_drvdata()

2013-08-29 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with of-dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 files

Re: [PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-28 Thread Libo Chen
On 2013/8/28 12:36, Greg KH wrote: > On Tue, Aug 27, 2013 at 04:10:22PM +0800, Libo Chen wrote: >> >> Use the wrapper functions for getting and setting the driver data using >> platform_device instead of using dev_{get,set}_drvdata() with >dev, >> so we can directly

Re: [PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-28 Thread Libo Chen
On 2013/8/28 12:36, Greg KH wrote: > On Tue, Aug 27, 2013 at 04:10:22PM +0800, Libo Chen wrote: >> >> Use the wrapper functions for getting and setting the driver data using >> platform_device instead of using dev_{get,set}_drvdata() with >dev, >> so we can directly

Re: [PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-28 Thread Libo Chen
On 2013/8/28 12:36, Greg KH wrote: On Tue, Aug 27, 2013 at 04:10:22PM +0800, Libo Chen wrote: Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with pdev-dev, so we can directly pass a struct platform_device

Re: [PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-28 Thread Libo Chen
On 2013/8/28 12:36, Greg KH wrote: On Tue, Aug 27, 2013 at 04:10:22PM +0800, Libo Chen wrote: Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with pdev-dev, so we can directly pass a struct platform_device

[PATCH 0/4] usb: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Libo Chen (4): usb: fotg210-udc: use platform_{get,set}_drvdata() usb: r8a66597-hcd: use platform_{

[PATCH 1/4] usb: fotg210-udc: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/gadget/fotg210-udc.c |4 ++-- 1 files changed, 2 inserti

[PATCH 3/4] usb: phy-tegra-usb: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/phy/phy-tegra-usb.c |2 +- 1 files changed, 1 inserti

[PATCH 4/4] usb: renesas_usbhs: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/renesas_usbhs/common.c |2 +- 1 files changed, 1 inserti

[PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen --- drivers/usb/host/r8a66597-hcd.c |4 ++-- 1 files changed, 2 inserti

[PATCH 4/4] usb: renesas_usbhs: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with pdev-dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/usb/renesas_usbhs/common.c |2 +- 1

[PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-27 Thread Libo Chen
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with pdev-dev, so we can directly pass a struct platform_device. Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/usb/host/r8a66597-hcd.c |4 ++-- 1

  1   2   3   4   5   >