Re: [PATCH v3] i2c: mediatek: i2c multi transfer optimization

2016-04-15 Thread liguo zhang
On Tue, 2016-04-12 at 23:13 +0200, Wolfram Sang wrote: > Hi, > > thanks for the submission! > > On Tue, Mar 08, 2016 at 02:23:51AM +0800, Liguo Zhang wrote: > > Signal complete() in the i2c irq handler after one transfer done, > > and then wait_for_compl

Re: [PATCH v3] i2c: mediatek: i2c multi transfer optimization

2016-04-15 Thread liguo zhang
On Tue, 2016-04-12 at 23:13 +0200, Wolfram Sang wrote: > Hi, > > thanks for the submission! > > On Tue, Mar 08, 2016 at 02:23:51AM +0800, Liguo Zhang wrote: > > Signal complete() in the i2c irq handler after one transfer done, > > and then wait_for_compl

[PATCH v3] i2c: mediatek: i2c multi transfer optimization

2016-03-07 Thread Liguo Zhang
Signal complete() in the i2c irq handler after one transfer done, and then wait_for_completion_timeout() will return, this procedure may cost much time, so only signal complete() when the entire transaction has been completed, it will reduce the entire transaction time. Signed-off-by: Liguo Zhang

[PATCH v3] i2c: mediatek: i2c multi transfer optimization

2016-03-07 Thread Liguo Zhang
Signal complete() in the i2c irq handler after one transfer done, and then wait_for_completion_timeout() will return, this procedure may cost much time, so only signal complete() when the entire transaction has been completed, it will reduce the entire transaction time. Signed-off-by: Liguo Zhang

Re: [PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

2016-03-06 Thread liguo zhang
On Mon, 2016-01-04 at 10:55 +0100, Wolfram Sang wrote: > On Mon, Jan 04, 2016 at 02:15:37PM +0800, Liguo Zhang wrote: > > Add a dt binding for the MT2701 soc. > > > > Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> > > This should probably go

Re: [PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

2016-03-06 Thread liguo zhang
On Mon, 2016-01-04 at 10:55 +0100, Wolfram Sang wrote: > On Mon, Jan 04, 2016 at 02:15:37PM +0800, Liguo Zhang wrote: > > Add a dt binding for the MT2701 soc. > > > > Signed-off-by: Liguo Zhang > > This should probably go with the other patch via arm-soc, or? T

[PATCH v2] i2c: mediatek: i2c multi transfer optimization

2016-02-25 Thread Liguo Zhang
Send the next transfer in the i2c irq handler, and only signal complete() when the entire transaction has been completed. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- change in v2: Remove the unused variable left_num in mtk_i2c_transfer(). --- drivers/i2c/busses/i2c-mt65xx.c

[PATCH v2] i2c: mediatek: i2c multi transfer optimization

2016-02-25 Thread Liguo Zhang
Send the next transfer in the i2c irq handler, and only signal complete() when the entire transaction has been completed. Signed-off-by: Liguo Zhang --- change in v2: Remove the unused variable left_num in mtk_i2c_transfer(). --- drivers/i2c/busses/i2c-mt65xx.c | 221

[PATCH] i2c: mediatek: i2c multi transfer optimization

2016-02-25 Thread Liguo Zhang
Send the next transfer in the i2c irq handler, and only signal complete() when the entire transaction has been completed. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- drivers/i2c/busses/i2c-mt65xx.c | 220 ++-- 1 file changed, 123 inse

[PATCH] i2c: mediatek: i2c multi transfer optimization

2016-02-25 Thread Liguo Zhang
Send the next transfer in the i2c irq handler, and only signal complete() when the entire transaction has been completed. Signed-off-by: Liguo Zhang --- drivers/i2c/busses/i2c-mt65xx.c | 220 ++-- 1 file changed, 123 insertions(+), 97 deletions(-) diff --git

[PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver.

2016-02-01 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang --- change in v6: Remove unnecessary init for reg_4g_mode. change in v5: Use BIT_ULL() to fix kernel building warning. change in v4: Use BIT_ULL() to fix

[PATCH v5] i2c: mt8173: add 4GB mode support in i2c driver.

2016-02-01 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang --- change in v5: Use BIT_ULL() to fix kernel building warning. change in v4: Use BIT_ULL() to fix kernel building warning. change in v3: Only inline

[PATCH v4] i2c: mt8173: add 4GB mode support in i2c driver.

2016-02-01 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang --- change in v4: Use BIT_ULL() to fix kernel building warning. change in v3: Only inline the computation of reg_4g_mode in mtk_i2c_set_4g_mode(). change

[PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver.

2016-02-01 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- change in v6: Remove unnecessary init for reg_4g_mode. change in v5: Use BIT_ULL() to fix kernel building warning. change

[PATCH v5] i2c: mt8173: add 4GB mode support in i2c driver.

2016-02-01 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- change in v5: Use BIT_ULL() to fix kernel building warning. change in v4: Use BIT_ULL() to fix kernel building warning.

[PATCH v4] i2c: mt8173: add 4GB mode support in i2c driver.

2016-02-01 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- change in v4: Use BIT_ULL() to fix kernel building warning. change in v3: Only inline the computation of reg_4

[PATCH v3] i2c: mt8173: add 4GB mode support in i2c driver.

2016-01-29 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang --- change in v3: Only inline the computation of reg_4g_mode in mtk_i2c_set_4g_mode(). change in v2: Define a static inline funtion mtk_i2c_set_4g_mode

[PATCH v3] i2c: mt8173: add 4GB mode support in i2c driver.

2016-01-29 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- change in v3: Only inline the computation of reg_4g_mode in mtk_i2c_set_4g_mode(). change in v2: Define a static inline f

[PATCH v2] i2c: mt8173: add 4GB mode support in i2c driver.

2016-01-28 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang --- change in v2: Define a static inline funtion mtk_i2c_set_4g_mode() for support 4g mode. --- drivers/i2c/busses/i2c-mt65xx.c | 51

[PATCH v2] i2c: mt8173: add 4GB mode support in i2c driver.

2016-01-28 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- change in v2: Define a static inline funtion mtk_i2c_set_4g_mode() for support 4g mode. --- drivers/i2c/busses/i2c-mt

[PATCH] i2c: mt8173: add 4GB mode support in i2c driver.

2016-01-22 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang --- drivers/i2c/busses/i2c-mt65xx.c | 41 +++ 1 file changed, 41 insertions(+) diff --git a/drivers/i2c/busses/i2c

[PATCH] i2c: mt8173: add 4GB mode support in i2c driver.

2016-01-22 Thread Liguo Zhang
If 4GB mode is enable, we should add 4gb mode support in i2c driver. Set 4GB mode register to support 4GB mode. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- drivers/i2c/busses/i2c-mt65xx.c | 41 +++ 1 file changed, 41 insertions(+) diff

[PATCH 2/2] dts: MT2701: add i2c dts info for MT2701

2016-01-03 Thread Liguo Zhang
Add i2c dtsi node for MT2701. Signed-off-by: Liguo Zhang --- arch/arm/boot/dts/mt2701.dtsi | 42 ++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi index bd88ae9..bb34770 100644 --- a/arch/arm

[PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

2016-01-03 Thread Liguo Zhang
Add a dt binding for the MT2701 soc. Signed-off-by: Liguo Zhang --- Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c

[PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

2016-01-03 Thread Liguo Zhang
Add a dt binding for the MT2701 soc. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.

[PATCH 2/2] dts: MT2701: add i2c dts info for MT2701

2016-01-03 Thread Liguo Zhang
Add i2c dtsi node for MT2701. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- arch/arm/boot/dts/mt2701.dtsi | 42 ++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi index b

[PATCH v3] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-12-14 Thread Liguo Zhang
For mt8173 platform with auto restart support, when doing i2c multi transfer in high speed, we should ignore the first restart irq after the master code, otherwise the first transfer will be discarded. Signed-off-by: Liguo Zhang Reviewed-by: Eddie Huang --- Change in v3: ignore the first

[PATCH v3] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-12-14 Thread Liguo Zhang
For mt8173 platform with auto restart support, when doing i2c multi transfer in high speed, we should ignore the first restart irq after the master code, otherwise the first transfer will be discarded. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> Reviewed-by: Eddie Huang <

Re: [PATCH v2 2/2] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-12-01 Thread liguo zhang
On Sat, 2015-11-14 at 22:38 +0800, Daniel Kurtz wrote: > On Mon, Nov 9, 2015 at 1:43 PM, Liguo Zhang wrote: > > For platform with auto restart support, when doing i2c multi transfer > > in high speed, for example, doing write-then-read transfer, the master > > code will occu

Re: [PATCH v2 2/2] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-12-01 Thread liguo zhang
On Sat, 2015-11-14 at 22:38 +0800, Daniel Kurtz wrote: > On Mon, Nov 9, 2015 at 1:43 PM, Liguo Zhang <liguo.zh...@mediatek.com> wrote: > > For platform with auto restart support, when doing i2c multi transfer > > in high speed, for example, doing write-then-read transfer

[PATCH v2 0/2] Mediatek I2C Fixup

2015-11-08 Thread Liguo Zhang
. If hardware support auto restart, need driver to send master code first. Change in v2: fix i2c checkpatch error. Liguo Zhang (2): i2c: mediatek: add i2c first write then read optimization i2c: mediatek: fix i2c multi transfer issue in high speed mode drivers/i2c/busses/i2c-mt65xx.c | 78

[PATCH v2 2/2] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-11-08 Thread Liguo Zhang
the master code, and then start i2c multi transfer. Signed-off-by: Liguo Zhang Reviewed-by: Eddie Huang --- drivers/i2c/busses/i2c-mt65xx.c | 45 + 1 file changed, 45 insertions(+) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c

[PATCH v2 1/2] i2c: mediatek: add i2c first write then read optimization

2015-11-08 Thread Liguo Zhang
latency. Signed-off-by: Liguo Zhang Reviewed-by: Eddie Huang --- drivers/i2c/busses/i2c-mt65xx.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c index 9b86716..dc4aac6 100644

[PATCH v2 1/2] i2c: mediatek: add i2c first write then read optimization

2015-11-08 Thread Liguo Zhang
latency. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> Reviewed-by: Eddie Huang <eddie.hu...@mediatek.com> --- drivers/i2c/busses/i2c-mt65xx.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt65xx

[PATCH v2 0/2] Mediatek I2C Fixup

2015-11-08 Thread Liguo Zhang
. If hardware support auto restart, need driver to send master code first. Change in v2: fix i2c checkpatch error. Liguo Zhang (2): i2c: mediatek: add i2c first write then read optimization i2c: mediatek: fix i2c multi transfer issue in high speed mode drivers/i2c/busses/i2c-mt65xx.c | 78

[PATCH v2 2/2] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-11-08 Thread Liguo Zhang
the master code, and then start i2c multi transfer. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> Reviewed-by: Eddie Huang <eddie.hu...@mediatek.com> --- drivers/i2c/busses/i2c-mt65xx.c | 45 + 1 file changed, 45 insertions(+) diff --git a

[PATCH 1/2] i2c: mediatek: add i2c first write then read optimization

2015-10-27 Thread Liguo Zhang
latency. Signed-off-by: Liguo Zhang --- drivers/i2c/busses/i2c-mt65xx.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c index 9b86716..dc4aac6 100644 --- a/drivers/i2c/busses

[PATCH 2/2] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-10-27 Thread Liguo Zhang
the master code, and then start i2c multi transfer. Signed-off-by: Liguo Zhang --- drivers/i2c/busses/i2c-mt65xx.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c index dc4aac6..0b9e9f5

[PATCH 0/2] Mediatek I2C driver fixup

2015-10-27 Thread Liguo Zhang
. If hardware support auto restart, need driver to send master code first. Liguo Zhang (2): i2c: mediatek: add i2c first write then read optimization i2c: mediatek: fix i2c multi transfer issue in high speed mode drivers/i2c/busses/i2c-mt65xx.c | 77 + 1 file

[PATCH 1/2] i2c: mediatek: add i2c first write then read optimization

2015-10-27 Thread Liguo Zhang
latency. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- drivers/i2c/busses/i2c-mt65xx.c | 33 +++-- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c index 9b86716..dc4aac6

[PATCH 2/2] i2c: mediatek: fix i2c multi transfer issue in high speed mode

2015-10-27 Thread Liguo Zhang
the master code, and then start i2c multi transfer. Signed-off-by: Liguo Zhang <liguo.zh...@mediatek.com> --- drivers/i2c/busses/i2c-mt65xx.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt

[PATCH 0/2] Mediatek I2C driver fixup

2015-10-27 Thread Liguo Zhang
. If hardware support auto restart, need driver to send master code first. Liguo Zhang (2): i2c: mediatek: add i2c first write then read optimization i2c: mediatek: fix i2c multi transfer issue in high speed mode drivers/i2c/busses/i2c-mt65xx.c | 77 + 1 file