[no subject]

2019-07-28 Thread Lin Xiulei
unsubscribe linux-kernel

Re: [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu

2018-03-12 Thread Lin Xiulei
2018-03-12 20:24 GMT+08:00 Peter Zijlstra : > On Wed, Mar 07, 2018 at 07:19:15PM +0800, Lin Xiulei wrote: > >> >> + /* >> >> + * if only the cgroup is running on this cpu >> >> + * and cpuctx->cgrp == NULL (otherwise it would've &g

Re: [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu

2018-03-12 Thread Lin Xiulei
2018-03-12 15:53 GMT+08:00 Ingo Molnar : > > * linxiu...@gmail.com wrote: > >> /* >>* Because cgroup events are always per-cpu events, >>* this will always be called from the right CPU. >>*/ > >> + /* >> + * if only the cgroup is running on this cpu >> +

Re: [PATCH RESEND v5] perf/core: Fix installing arbitrary cgroup event into cpu

2018-03-07 Thread Lin Xiulei
2018-03-06 19:50 GMT+08:00 Peter Zijlstra : > On Tue, Mar 06, 2018 at 05:36:37PM +0800, linxiu...@gmail.com wrote: >> From: "leilei.lin" >> >> Do not install cgroup event into the CPU context and schedule it >> if the cgroup is not running on this CPU > > OK, so far so good, this explains the bit

Re: [PATCH RESEND v4] perf/core: Fix installing cgroup event into cpu

2018-02-10 Thread Lin Xiulei
2018-02-09 18:11 GMT+08:00 Peter Zijlstra : > On Thu, Feb 08, 2018 at 11:33:44AM +0800, linxiu...@gmail.com wrote: >> From: "leilei.lin" >> >> Do not install cgroup event into the CPU context and schedule it >> if the cgroup is not running on this CPU >> >> While there is no task of cgroup running

Re: [PATCH RESEND v4] perf/core: Fix installing cgroup event into cpu

2018-02-08 Thread Lin Xiulei
2018-02-08 23:36 GMT+08:00 Jiri Olsa : > > On Thu, Feb 08, 2018 at 11:33:44AM +0800, linxiu...@gmail.com wrote: > > From: "leilei.lin" > > > > Do not install cgroup event into the CPU context and schedule it > > if the cgroup is not running on this CPU > > > > While there is no task of cgroup runn

Re: [PATCH RESEND] perf/core: Fix installing cgroup event into cpu

2018-01-28 Thread Lin Xiulei
2018-01-26 10:02 GMT+08:00 kbuild test robot : > Hi leilei.lin, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on tip/perf/core] > [also build test ERROR on v4.15-rc9 next-20180119] > [if your patch is applied to the wrong git tree, please drop us a note to > hel

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Lin Xiulei
2018-01-24 17:46 GMT+08:00 Peter Zijlstra : > On Wed, Jan 24, 2018 at 05:19:34PM +0800, Lin Xiulei wrote: >> Sure, and I consider this "OK" works for "What goes wrong if we leave >> it set?". : ) > > It would be good if you inspect the code for the case of

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Lin Xiulei
2018-01-24 17:14 GMT+08:00 Peter Zijlstra : > On Wed, Jan 24, 2018 at 04:32:38PM +0800, Lin Xiulei wrote: >> >> kernel/events/core.c | 44 +++- >> >> 1 file changed, 31 insertions(+), 13 deletions(-) >> >> >>

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Lin Xiulei
2018-01-24 16:20 GMT+08:00 Peter Zijlstra : > On Wed, Jan 24, 2018 at 03:50:10PM +0800, linxiu...@gmail.com wrote: >> From: "leilei.lin" >> >> Do not install cgroup event into the CPU context if the cgroup >> is not running on this CPU >> >> While there is no task of cgroup running specified CPU,

Re: [PATCH RESEND] perf/core: Fix installing cgroup event into cpu

2018-01-23 Thread Lin Xiulei
yes, you are right. In my cases, there also are some issues in add_event_to_ctx(), I am gonna fix it at v2 Thanks 2018-01-24 0:37 GMT+08:00 Peter Zijlstra : > On Tue, Jan 23, 2018 at 12:13:06PM +0800, linxiu...@gmail.com wrote: >> From: "leilei.lin" >> >> Do not install cgroup event into the CPU

Re: [PATCH] perf/core: Fix installing cgroup event into cpu

2018-01-17 Thread Lin Xiulei
Hi Peter Could you please have a look of this thanks 2018-01-11 11:09 GMT+08:00 : > From: "leilei.lin" > > Do not install cgroup event into the CPU context if the cgroup > is not running on this CPU > > While there is no task of cgroup running specified CPU, current > kernel still install cgro

[PATCH v2] perf/core: Fix updating cgroup time with descendants

2017-09-28 Thread Lin Xiulei
From: "leilei.lin" This fix updating cgroup time when event is being scheduled in by descendants Signed-off-by: leilei.lin Reviewed-and-tested-by: Jiri Olsa --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c

Re: [PATCH] perf/core: Update cgroup time with descendants

2017-09-18 Thread Lin Xiulei
Add steps of reproducing 1 ``` mkdir /sys/fs/cgroup/perf_event/root1 mkdir /sys/fs/cgroup/perf_event/root1/leaf1 ``` 2 $pid is any running process ``` echo $pid > /sys/fs/cgroup/perf_event/root1/cgroup.procs ``` 3 ``` perf stat -e cycles -G root1 -a -I 1000 ``` You shall get 0 cycles from it, w