[PATCH 0/2] drm: mali-dp: Fixes for v4.11-rc2

2017-03-06 Thread Liviu Dudau
A couple of fixes that I have queued in my tree waiting for the dust to settle on the main drm pull request. Best regards, Liviu Mihail Atanassov (2): drm: mali-dp: Remove mclk rate management drm: mali-dp: Fix smart layer not going to composition drivers/gpu/drm/arm/malidp_crtc.c | 3 +-

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

2017-03-03 Thread Liviu Dudau
PGU node. > > Again inspired by ARM's HDLCD code. Again, Reviewed-by: Liviu Dudau :) > > Signed-off-by: Alexey Brodkin > Cc: Liviu Dudau > Cc: Daniel Vetter > Cc: David Airlie > Cc: Rob Herring > --- > arch/arc/boot/dts/axs10x_mb.dtsi | 1 - > dr

Re: [PATCH] drm/arcpgu: Opt in debugfs

2017-03-03 Thread Liviu Dudau
Cc. FWIW: Reviewed-by: Liviu Dudau Best regards, Liviu > > Signed-off-by: Alexey Brodkin > Cc: Liviu Dudau > Cc: Daniel Vetter > Cc: David Airlie > Cc: Jose Abreu > --- > drivers/gpu/drm/arc/arcpgu_drv.c | 29 + > 1 file changed,

[PATCH] ALSA: ASoC: TLV320AIC23: Unquote NULL from control name

2017-03-01 Thread Liviu Dudau
gt; NULL -> Mic Input tegra-snd-trimslice sound: tlv320aic23-hifi <-> 70002800.i2s mapping ok Signed-off-by: Liviu Dudau --- sound/soc/codecs/tlv320aic23.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic

Re: [RFC] drm: Helper macro for drm state duplication

2017-02-09 Thread Liviu Dudau
On Thu, Feb 09, 2017 at 05:57:04PM +0100, Daniel Vetter wrote: > On Thu, Feb 09, 2017 at 03:41:41PM +, Mihail Atanassov wrote: > > Hi, > > > > I was working on a few patches adding fields to struct malidp_crtc_state and > > found myself writing memcpy multiple times in the ->atomic_duplicate_s

Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node

2017-02-08 Thread Liviu Dudau
the HDLCD and Mali DP part you can also add: Tested-by: Liviu Dudau Best regards, Liviu > drivers/gpu/drm/bridge/adv7511/adv7533.c| 12 + > drivers/gpu/drm/bridge/dumb-vga-dac.c | 15 ++ > drivers/gpu/drm/bridge/ti-tfp410.c | 15 ++ > drivers

Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node

2017-02-06 Thread Liviu Dudau
On Mon, Feb 06, 2017 at 05:34:07PM +, Russell King - ARM Linux wrote: > On Mon, Feb 06, 2017 at 05:23:06PM +0000, Liviu Dudau wrote: > > On Mon, Feb 06, 2017 at 11:09:49AM -0600, Rob Herring wrote: > > > On Mon, Feb 06, 2017 at 10:29:33AM +, Liviu Dudau wrote: > >

Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node

2017-02-06 Thread Liviu Dudau
On Mon, Feb 06, 2017 at 11:09:49AM -0600, Rob Herring wrote: > On Mon, Feb 06, 2017 at 10:29:33AM +0000, Liviu Dudau wrote: > > On Fri, Feb 03, 2017 at 09:36:33PM -0600, Rob Herring wrote: > > > Convert drivers to use the new of_graph_get_remote_node() helper > > > inst

Re: [PATCH v2 2/2] drm: mali-dp: enable gamma support

2017-02-06 Thread Liviu Dudau
gamma curve > to set the hardware curve on DP550/650. For the sake of > simplicity, it uses the same table of coefficients for > all 3 curves on DP500. > > Signed-off-by: Mihail Atanassov > Reviewed-by: Brian Starkey For the whole series: Acked-by: Liviu Dudau Thank

Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node

2017-02-06 Thread Liviu Dudau
On Fri, Feb 03, 2017 at 09:36:33PM -0600, Rob Herring wrote: > Convert drivers to use the new of_graph_get_remote_node() helper > instead of parsing the endpoint node and then getting the remote device > node. Now drivers can just specify the device node and which > port/endpoint and get back the c

Re: [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge

2017-02-06 Thread Liviu Dudau
On Fri, Feb 03, 2017 at 09:36:32PM -0600, Rob Herring wrote: > Many drivers have a common pattern of searching the OF graph for either an > attached panel or bridge and then finding the DRM struct for the panel > or bridge. Also, most drivers need to handle deferred probing when the > DRM device is

Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition.

2017-02-01 Thread Liviu Dudau
On Wed, Feb 01, 2017 at 10:26:08AM +0100, Lucas Stach wrote: > Hi Liviu, > > Am Dienstag, den 31.01.2017, 18:58 + schrieb Liviu Dudau: > > Commit 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite > > to take only vmf") updated the etnaviv

[PATCH] drm/etnaviv: Remove duplicate header file include

2017-01-31 Thread Liviu Dudau
etnaviv_gem.h header gets included twice. Remove duplicate. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c index 590be0d1dd95..ce3e8cf2cd11

[PATCH 1/3] drm: armada: fix armada_gem_vm_fault() to match new signature.

2017-01-31 Thread Liviu Dudau
Jiang Cc: Russell King Signed-off-by: Liviu Dudau --- drivers/gpu/drm/armada/armada_gem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c index a293c8be232c..1ec0419003f3 100644 --- a/drivers/gpu/

[PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition.

2017-01-31 Thread Liviu Dudau
e only vmf") Cc: Dave Jiang Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Signed-off-by: Liviu Dudau --- drivers/gpu/drm/etnaviv/etnaviv_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv

[PATCH 3/3] drm/omapdrm: Update omap_gem_fault() declaration to match definition.

2017-01-31 Thread Liviu Dudau
e only vmf") Cc: Dave Jiang Cc: Tomi Valkeinen Signed-off-by: Liviu Dudau --- drivers/gpu/drm/omapdrm/omap_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h index 36d93ce84a29..65977982f15f 100644 -

[PATCH] Documentation/gpu: drm-mm.rst: fix formatting for struct vm_operations_struct

2017-01-31 Thread Liviu Dudau
pfn_mkwrite to take only vmf). Signed-off-by: Liviu Dudau --- Documentation/gpu/drm-mm.rst | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst index 91d82f39fbf4..a1c0ae3b2c38 100644 --- a/Documentation

Re: [PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Liviu Dudau
On Mon, Jan 30, 2017 at 03:42:26PM +, Mihail Atanassov wrote: > The reset hook needs to allocate space for a > malidp_plane_state, which is larger than drm_plane_state. > Otherwise, the hook is identical to the default one. > > Signed-off-by: Mihail Atanassov Acked-by: Liviu

[PATCH 2/2] drm: mali-dp: fix stride setting for multi-plane formats

2017-01-26 Thread Liviu Dudau
-by: Mihail Atanassov [Removed smart layer stride setup, comment and commit message clarifications] Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_hw.c | 17 ++--- drivers/gpu/drm/arm/malidp_hw.h | 5 + drivers/gpu/drm/arm/malidp_planes.c | 34

[PATCH 1/2] drm: mali-dp: Add plane offset to the plane's physical start address register

2017-01-26 Thread Liviu Dudau
Add the fb->offset[] value to the plane's physical start address registe. Without that, packed formats are rendered incorrectly. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_planes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b

Re: [PATCH 2/2] drm: mali-dp: Check for sufficient address space

2017-01-23 Thread Liviu Dudau
+ ret = -EINVAL; > + goto query_hw_fail; > + } > + Small nitpick: s/malidp_is_sufficient_address_space/malidp_has_sufficient_address_space/g Otherwise, for the whole series: Acked-by: Liviu Dudau > if (!malidp_is_compatible_hw_id(hwdev, dev_id)) {

[PATCH 3/8] drm: mali-dp: Check more use cases in the plane's ->atomic_check()

2017-01-17 Thread Liviu Dudau
g issues. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_planes.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index d1cc15724dc3..f684fe4a80d2 100644 --- a/drivers/gpu

[PATCH 1/8] drm/arm/malidp: Fix possible dereference of NULL

2017-01-17 Thread Liviu Dudau
From: Shailendra Verma There is possible deference of NULL pointer on return of malidp_duplicate_plane_state() if kmalloc fails. Check the returned kmalloc pointer before continuing. Signed-off-by: Shailendra Verma [cleaned up the code and re-formatted the commit message] Signed-off-by: Liviu

[PATCH 7/8] drm: mali-dp: fix Lx_CONTROL register fields clobber

2017-01-17 Thread Liviu Dudau
From: Mihail Atanassov When updating the rotation fields, one of the assignments zeroes out the rest of the register fields, which include settings for chroma siting, inverse gamma, AMBA AXI caching, and alpha blending. Signed-off-by: Mihail Atanassov Signed-off-by: Liviu Dudau --- drivers

[PATCH 8/8] drm: mali-dp: Rename malidp_input_format to malidp_pixel_format

2017-01-17 Thread Liviu Dudau
From: Brian Starkey We're going to use the same format list for output formats, so rename everything related to input formats to avoid confusion. Signed-off-by: Brian Starkey [touched commit message to clarify the final struct name] Signed-off-by: Liviu Dudau --- drivers/gpu/dr

[PATCH 4/8] drm: mali-dp: Don't force source size == crtc size

2017-01-17 Thread Liviu Dudau
redundant in any case. Signed-off-by: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_planes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index f684fe4a80d2

[PATCH 0/8] drm/mali-dp: Fixes for v4.11

2017-01-17 Thread Liviu Dudau
ource size == crtc size drm: mali-dp: Fix destination size handling when rotating drm: mali-dp: Fix transposed horizontal/vertical flip drm: mali-dp: Rename malidp_input_format to malidp_pixel_format Liviu Dudau (2): drm: malidp: Remove event_list member from struct malidp_drm drm: mali-dp:

[PATCH 6/8] drm: mali-dp: Fix transposed horizontal/vertical flip

2017-01-17 Thread Liviu Dudau
From: Brian Starkey The horizontal and vertical flip flags were the wrong way around, causing reflect-x to result in reflect-y being applied and vice-versa. Fix them. Fixes: ad49f8602fe8 ("drm/arm: Add support for Mali Display Processors") Signed-off-by: Brian Starkey Signed-off

[PATCH 2/8] drm: malidp: Remove event_list member from struct malidp_drm

2017-01-17 Thread Liviu Dudau
This struct member managed to outlive the submission process without being removed. It is useless. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_drv.c | 2 -- drivers/gpu/drm/arm/malidp_drv.h | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arm

[PATCH 5/8] drm: mali-dp: Fix destination size handling when rotating

2017-01-17 Thread Liviu Dudau
swap. Fixes: ad49f8602fe8 ("drm/arm: Add support for Mali Display Processors") Signed-off-by: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_planes.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c

[GIT PULL] Another HDLCD fix

2016-11-25 Thread Liviu Dudau
Hi Dave, Thanks for pulling the previous patch for HDLCD. Unfortunately, yesterday Robin Murphy discovered another issue while playing with CMA allocation sizes, which he has submitted a fix for. If you think it is too late for this to go into v4.9, please let me know. Many thanks, Liviu The fol

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
On Wed, Nov 23, 2016 at 02:47:53PM +0200, Jani Nikula wrote: > On Wed, 23 Nov 2016, Daniel Vetter wrote: > > On Wed, Nov 23, 2016 at 11:23:23AM +0000, Liviu Dudau wrote: > >> On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > >> > On Wed, 2

Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
On Wed, Nov 23, 2016 at 01:00:07PM +0200, Jani Nikula wrote: > On Wed, 23 Nov 2016, Liviu Dudau wrote: > > drm_get_format_name() de-references the buf parameter without checking > > if the pointer was not NULL. Given that the function is EXPORT-ed, lets > > sanitise

[PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-23 Thread Liviu Dudau
("drm: move allocation out of drm_get_format_name()) Cc: Eric Engestrom Cc: Rob Clark Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Liviu Dudau --- I still think sanity checking the parameters of an exported function is worth doing, even if the way one triggers the NULL pointer cra

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-22 Thread Liviu Dudau
; On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark wrote: > >> >> On Tue, Nov 22, 2016 at 11:50 AM, Ville Syrjälä > >> >> wrote: > >> >> > On Tue, Nov 22, 2016 at 04:41:06PM +, Liviu Dudau wrote: > >> >> >> drm_get_format_na

Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-22 Thread Liviu Dudau
On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark wrote: > On Tue, Nov 22, 2016 at 11:50 AM, Ville Syrjälä > wrote: > > On Tue, Nov 22, 2016 at 04:41:06PM +, Liviu Dudau wrote: > >> drm_get_format_name() de-references the buf parameter without checking > >&g

[PATCH] drm: check for NULL parameter in exported drm_get_format_name() function.

2016-11-22 Thread Liviu Dudau
: Rob Clark Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_fourcc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 90d2cc8..0a3ff0b 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/driver

[GIT PULL] arm/hdlcd fixes for v4.9-rc7

2016-11-22 Thread Liviu Dudau
Hi David, A late issue discovered by Russell King while testing his setup on Juno. I would be really happy if it goes into v4.9-rc7 as it fixes a reference counting problem with the pixelclock clock, but if it is too late for that then I guess it can go into drm-next. The following changes since

Re: [PATCH] drm/atomic: cleanup debugfs entries on un-registering the driver.

2016-11-17 Thread Liviu Dudau
On Thu, Nov 17, 2016 at 11:41:29AM +, Liviu Dudau wrote: > Cleanup the debugfs entries created by commit 6559c901cb48 when > the driver's minor gets un-registered. Without it, DRM drivers > compiled as modules cannot be rmmod-ed and modprobed again. Bah, naughty of me: sho

[PATCH] drm/atomic: cleanup debugfs entries on un-registering the driver.

2016-11-17 Thread Liviu Dudau
Cleanup the debugfs entries created by commit 6559c901cb48 when the driver's minor gets un-registered. Without it, DRM drivers compiled as modules cannot be rmmod-ed and modprobed again. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_atomic.c | 7 +++ drivers/gpu/drm/drm_debugfs.

Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Liviu Dudau
On Fri, Nov 11, 2016 at 01:58:46PM +, Emil Velikov wrote: > On 11 November 2016 at 10:56, Liviu Dudau wrote: > > Hi Shailendra, > > > > On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: > >> From: "Shailendra Verma" > >> >

Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Liviu Dudau
em is. > So return NULL if kmalloc fails. > > Signed-off-by: Shailendra Verma Acked-by: Liviu Dudau Thanks for spotting this! Liviu > --- > drivers/gpu/drm/arm/malidp_planes.c |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/a

Re: [PATCH V5 2/3] ARM64 LPC: Add missing range exception for special ISA

2016-11-09 Thread liviu . dudau
On Tue, Nov 08, 2016 at 11:47:08AM +0800, zhichang.yuan wrote: > This patch solves two issues: > 1) parse and get the right I/O range from DTS node whose parent does not > define the corresponding ranges property; > > There are some special ISA/LPC devices that work on a specific I/O range where >

Re: [PATCH] drm: mali-dp: Add support for setting plane's rotation property from userspace.

2016-11-08 Thread Liviu Dudau
On Tue, Nov 08, 2016 at 05:16:41PM +0100, Daniel Vetter wrote: > On Tue, Nov 08, 2016 at 01:43:25PM +0000, Liviu Dudau wrote: > > In order to support DRM_IOCTL_MODE_OBJ_SETPROPERTY for the rotation property > > we need to have a ->set_property hook defined for the planes. S

[PATCH] drm: mali-dp: Add support for setting plane's rotation property from userspace.

2016-11-08 Thread Liviu Dudau
In order to support DRM_IOCTL_MODE_OBJ_SETPROPERTY for the rotation property we need to have a ->set_property hook defined for the planes. Set the plane's ->set_property hook to drm_atomic_helper_plane_set_property() Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_planes

Re: linux-next: manual merge of the mali-dp tree with the drm-misc tree

2016-11-04 Thread Liviu Dudau
On Sat, Nov 05, 2016 at 03:55:03AM +1100, Stephen Rothwell wrote: > Hi Liviu, > > On Fri, 4 Nov 2016 15:48:02 +0000 Liviu Dudau wrote: > > > > Brian Starkey is a co-maintainer for the Mali DP tree, so his Signed-off-by > > alone should be good. Baoyou's patch is i

Re: linux-next: manual merge of the mali-dp tree with the drm-misc tree

2016-11-04 Thread Liviu Dudau
On Fri, Nov 04, 2016 at 04:38:54PM +1100, Stephen Rothwell wrote: > Hi Liviu, > > On Thu, 3 Nov 2016 17:19:58 +0000 Liviu Dudau wrote: > > > > I have revamped the mali-dp tree and rebased it on the newer > > version of drm-next (which includes the drm-misc change)

Re: linux-next: manual merge of the mali-dp tree with the drm-misc tree

2016-11-03 Thread Liviu Dudau
On Tue, Oct 25, 2016 at 11:20:44AM +1100, Stephen Rothwell wrote: > Hi Liviu, Hi Stephen, > > Today's linux-next merge of the mali-dp tree got a conflict in: > > drivers/gpu/drm/arm/malidp_planes.c > > between commit: > > ea0e1ce20f73 ("drm/arm: Use per-plane rotation property") > > from

Re: [PATCH] drm/arm: mark symbols static where possible

2016-10-24 Thread liviu . dudau
On Mon, Oct 24, 2016 at 12:18:37PM +0200, Arnd Bergmann wrote: > On Saturday, October 22, 2016 5:13:01 PM CEST Baoyou Xie wrote: > > We get 2 warnings when building kernel with W=1: > > drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype > > for 'malidp_duplicate_plane_state'

Re: [PATCH] drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY

2016-10-24 Thread liviu . dudau
On Mon, Oct 24, 2016 at 10:52:28AM +0100, Brian Starkey wrote: > We need to explicitly disable our planes, so don't set the flag which > would otherwise skip the plane disable when the CRTC is disabled. > > Signed-off-by: Brian Starkey Acked-by: Liviu Dudau > --- &g

Re: [PATCH 1/8] drm: mali-dp: Set the drm->irq_enabled flag to match driver's state.

2016-10-11 Thread liviu . dudau
On Tue, Oct 11, 2016 at 03:26:02PM +0100, Brian Starkey wrote: > From: Liviu Dudau > > Mali DP driver does not use drm_irq_{un,}install() function so the > drm->irq_enabled flag does not get set automatically. > drm_wait_vblank() checks the value of the flag among other func

Re: [PATCH] drm: arm: mark symbols static where possible

2016-09-26 Thread liviu . dudau
Hi Baoyou, On Sun, Sep 25, 2016 at 03:20:24PM +0800, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/arm/malidp_planes.c:49:25: warning: no previous prototype for > 'malidp_duplicate_plane_state' [-Wmissing-prototypes] > drivers/gpu/drm/arm/malidp_planes.c:6

Re: [PATCH] drm/i2c: tda998x: don't register the connector

2016-09-23 Thread Liviu Dudau
On Fri, Sep 23, 2016 at 09:05:50AM +0200, Daniel Vetter wrote: > On Thu, Sep 22, 2016 at 4:14 PM, Brian Starkey wrote: > > On Thu, Sep 22, 2016 at 04:22:40AM -0700, Sean Paul wrote: > >> > >> On Thu, Sep 22, 2016 at 3:51 AM, Russell King - ARM Linux > >> wrote: > >>> > >>> On Thu, Sep 22, 2016 at

Re: [PATCH] drm/arm: mark symbols static where possible

2016-09-06 Thread liviu . dudau
ks these functions with 'static'. > > Signed-off-by: Baoyou Xie Acked-by: Liviu Dudau > --- > drivers/gpu/drm/arm/malidp_planes.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/malidp_planes.c > b/drivers/g

Re: [PATCH] debugfs: Add proxy function for the mmap file operation

2016-09-01 Thread Liviu Dudau
On Thu, Sep 01, 2016 at 08:19:33AM +0200, Greg Kroah-Hartman wrote: > On Wed, Aug 31, 2016 at 04:23:52PM +0100, Liviu Dudau wrote: > > On Wed, Aug 31, 2016 at 03:07:49PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Aug 05, 2016 at 01:11:45PM +0200, Nicolai Stange wrote: >

Re: [PATCH] debugfs: Add proxy function for the mmap file operation

2016-08-31 Thread Liviu Dudau
On Wed, Aug 31, 2016 at 03:07:49PM +0200, Greg Kroah-Hartman wrote: > On Fri, Aug 05, 2016 at 01:11:45PM +0200, Nicolai Stange wrote: > > Brian Starkey writes: > > > > > On Tue, Aug 02, 2016 at 07:31:36PM +0200, Nicolai Stange wrote: > > >>Nicolai Stange writes: > > >>> However, if you wish to h

[PATCH 2/2] drm: mali-dp: Set the drm->irq_enabled flag to match driver's state.

2016-07-29 Thread Liviu Dudau
Mali DP driver does not use drm_irq_{un,}install() function so the drm->irq_enabled flag does not get managed automatically. Among other DRM framework functions, drm_wait_vblank() checks the value of the flag and return -EINVAL if not set. Cc: Brian Starkey Signed-off-by: Liviu Du

[PATCH 1/2] drm: mali-dp: Clear the config_valid flag before using it in wait_event.

2016-07-29 Thread Liviu Dudau
config_valid variable is used to signal the activation of the CVAL request when the vsync interrupt has fired. malidp_set_and_wait_config_valid() uses the variable in wait_event_interruptible_timeout without clearing it first, so the wait is skipped. Cc: Brian Starkey Signed-off-by: Liviu Dudau

Cleanup patches for mali-dp driver

2016-07-29 Thread Liviu Dudau
Hi, A couple of patches to fix issues that I have discovered during the development of more Mali DP features :) I would like to take these patches through drm-misc and don't go through the mali-dp tree as I will be going on holiday for a month. If anyone has patches for Mali DP driver (or HDL

[PATCH] debugfs: Add proxy function for the mmap file operation

2016-07-29 Thread Liviu Dudau
Add proxy function for the mmap file_operations hook under the full_proxy_fops structure. This is useful for providing a custom mmap routine in a driver's debugfs implementation. Cc: Nicolai Stange Signed-off-by: Liviu Dudau --- fs/debugfs/file.c | 6 ++ 1 file changed, 6 inser

Re: [PATCH -next] drm/arm: mali-dp: Remove redundant dev_err call in malidp_bind()

2016-07-28 Thread Liviu Dudau
On Thu, Jul 28, 2016 at 02:09:13AM +, Wei Yongjun wrote: > There is a error message within devm_ioremap_resource > already, so remove the DRM_ERROR call to avoid redundant > error message. Yeah, good catch! > > Signed-off-by: Wei Yongjun Acked-by: Liviu Dudau Thanks

Re: [PATCH] drm/hdlcd: Delete an unnecessary check before drm_fbdev_cma_hotplug_event()

2016-07-18 Thread Liviu Dudau
call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by: Liviu Dudau > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/

Re: [PATCH 5/7] bus: vexpress-config: add missing of_node_put after calling of_parse_phandle

2016-07-11 Thread Liviu Dudau
On Fri, Jul 01, 2016 at 05:41:59PM +0800, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Signed-off-by: Peter Chen

Re: [PATCH V3] clocksource/drivers/mps2-timer: Convert init function to return error

2016-06-20 Thread liviu . dudau
ret = mps2_clockevent_init(np); > if (!ret) { > has_clockevent = 1; > - return; > + return 0; > } > } > + > + return 0; > } > > -CLOCKSOURCE_OF_DECLARE(

Re: [PATCH V2 51/63] clocksource/drivers/versatile: Convert init function to return error

2016-06-20 Thread Liviu Dudau
s-sysreg", > versatile_sched_clock_init); > -CLOCKSOURCE_OF_DECLARE(versatile, "arm,versatile-sysreg", > +CLOCKSOURCE_OF_DECLARE_RET(versatile, "arm,versatile-sysreg", > versatile_sched_clock_init); > -- > 1.9.1 > Acked-by: Liviu Dudau -- | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --- ¯\_(ツ)_/¯

Re: [PATCH V2 25/63] clocksource/drivers/mxs_timer: Convert init function to return error

2016-06-20 Thread Liviu Dudau
On Thu, Jun 16, 2016 at 11:26:44PM +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and >make the system boot up correctly > > or > > - print an error an

Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

2016-06-16 Thread Liviu Dudau
Hi Russell, On Wed, Jun 15, 2016 at 09:11:16PM +0100, Russell King - ARM Linux wrote: > On Wed, Jun 15, 2016 at 06:21:04PM +0100, Liviu Dudau wrote: > > Could be the tda998x_drv fault, but I'm getting this splat: > > > > [1.347687] kobject_add_internal failed for

Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

2016-06-15 Thread Liviu Dudau
On Wed, Jun 15, 2016 at 06:35:37PM +0100, Chris Wilson wrote: > On Wed, Jun 15, 2016 at 06:21:04PM +0100, Liviu Dudau wrote: > > On Wed, Jun 15, 2016 at 07:13:15PM +0200, Daniel Vetter wrote: > > > On Wed, Jun 15, 2016 at 6:17 PM, Liviu Dudau wrote: > > > > On W

Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

2016-06-15 Thread Liviu Dudau
On Wed, Jun 15, 2016 at 07:13:15PM +0200, Daniel Vetter wrote: > On Wed, Jun 15, 2016 at 6:17 PM, Liviu Dudau wrote: > > On Wed, Jun 15, 2016 at 05:23:10PM +0200, Daniel Vetter wrote: > >> On Wed, Jun 15, 2016 at 03:51:34PM +0100, Liviu Dudau wrote: > >> > Add

Re: [PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver

2016-06-15 Thread Liviu Dudau
On Wed, Jun 15, 2016 at 06:12:08PM +0200, Daniel Vetter wrote: > On Wed, Jun 15, 2016 at 04:35:24PM +0100, Eric Engestrom wrote: > > On Wed, Jun 15, 2016 at 03:51:35PM +0100, Liviu Dudau wrote: > > > Add MAINTAINERS entry for ARM Mali-DP driver and update the > > > HDL

Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

2016-06-15 Thread Liviu Dudau
On Wed, Jun 15, 2016 at 05:23:10PM +0200, Daniel Vetter wrote: > On Wed, Jun 15, 2016 at 03:51:34PM +0100, Liviu Dudau wrote: > > Add support for the new family of Display Processors from ARM Ltd. > > This commit adds basic support for Mali DP500, DP550 and DP650 > > parts,

Re: Mali DP tree for linux-next

2016-06-15 Thread Liviu Dudau
On Wed, Jun 15, 2016 at 05:21:02PM +0200, Daniel Vetter wrote: > On Wed, Jun 15, 2016 at 04:03:04PM +0100, Liviu Dudau wrote: > > Hi Stephen, > > > > I would like to add the Mali DP DRM driver tree to linux-next. I'm planning > > to send a pull request for inc

Mali DP tree for linux-next

2016-06-15 Thread Liviu Dudau
Hi Stephen, I would like to add the Mali DP DRM driver tree to linux-next. I'm planning to send a pull request for inclusion into v4.8 and I hope that getting a wider exposure for a few weeks is beneficial. Please add the following git tree: git://linux-arm.org/linux-ld for-upstream/mali-dp

[PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

2016-06-15 Thread Liviu Dudau
Add support for the new family of Display Processors from ARM Ltd. This commit adds basic support for Mali DP500, DP550 and DP650 parts, with only the display engine being supported at the moment. Cc: David Brown Cc: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/Kconfig

[PATCH v5 3/3] MAINTAINERS: Add entry for Mali-DP driver

2016-06-15 Thread Liviu Dudau
Add MAINTAINERS entry for ARM Mali-DP driver and update the HDLCD file matching pattern to cover only HDLCD rather than the whole drivers/gpu/drm/arm directory. Signed-off-by: Liviu Dudau --- MAINTAINERS | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b

[PATCH v5 0/3] Add support for ARM Mali Display Processors

2016-06-15 Thread Liviu Dudau
_DS (display split) from this version pending further development - Renamed module from malidp to mali-dp. - Added MAINTAINERS update Many thanks, Liviu [1] https://lists.freedesktop.org/archives/dri-devel/2016-June/110855.html [2] https://lists.freedesktop.org/archives/dri-devel/2016-June/110922.

[PATCH v5 1/3] dt/bindings: display: Add DT bindings for Mali Display Processors.

2016-06-15 Thread Liviu Dudau
Add DT bindings documentation for the Mali Display Processor. The bindings describe the Mali DP500, DP550 and DP650 processors from ARM Ltd. Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Liviu Dudau Acked-by: Rob Herring --- .../devicetree/bindings/display

Re: [PATCH V9 09/11] ARM64/PCI: ACPI support for legacy IRQs parsing and consolidation with DT code

2016-06-13 Thread Liviu . Dudau
On Mon, Jun 13, 2016 at 11:40:05AM +0100, Lorenzo Pieralisi wrote: > On Fri, Jun 10, 2016 at 06:36:12PM -0500, Bjorn Helgaas wrote: > > On Fri, Jun 10, 2016 at 09:55:17PM +0200, Tomasz Nowicki wrote: > > > To enable PCI legacy IRQs on platforms booting with ACPI, arch code > > > should include ACPI

[PATCH v4 2/3] drm/arm: Add support for Mali Display Processors

2016-06-13 Thread Liviu Dudau
Add support for the new family of Display Processors from ARM Ltd. This commit adds basic support for Mali DP500, DP550 and DP650 parts, with only the display engine being supported at the moment. Cc: David Brown Cc: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/Kconfig

[PATCH v4 1/3] dt/bindings: display: Add DT bindings for Mali Display Processors.

2016-06-13 Thread Liviu Dudau
Add DT bindings documentation for the Mali Display Processor. The bindings describe the Mali DP500, DP550 and DP650 processors from ARM Ltd. Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Liviu Dudau Acked-by: Rob Herring --- .../devicetree/bindings/display

[PATCH v4 0/3] Add support for ARM Mali Display Processors

2016-06-13 Thread Liviu Dudau
isplay split) from this version pending further development - Renamed module from malidp to mali-dp. - Added MAINTAINERS update Many thanks, Liviu Liviu Dudau (3): dt/bindings: display: Add DT bindings for Mali Display Processors. drm/arm: Add support for Mali Display Processors MAINTAIN

[PATCH v4 3/3] MAINTAINERS: Add entry for Mali-DP driver

2016-06-13 Thread Liviu Dudau
Add MAINTAINERS entry for ARM Mali-DP driver and update the HDLCD file matching pattern to cover only HDLCD rather than the whole drivers/gpu/drm/arm directory. Signed-off-by: Liviu Dudau --- MAINTAINERS | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b

Re: [PATCH v3 2/3] drm/arm: Add support for Mali Display Processors

2016-06-10 Thread Liviu Dudau
On Fri, Jun 10, 2016 at 04:33:13PM +0200, Daniel Vetter wrote: > On Fri, Jun 10, 2016 at 09:52:59AM +0100, Liviu Dudau wrote: > > On Thu, Jun 09, 2016 at 08:56:29PM +0200, Daniel Vetter wrote: > > I'm seeing ->disable being called at HPD event time, which is

[PATCH] drm: Fix comment making reference to non-existing function

2016-06-10 Thread Liviu Dudau
Documentation for drm_atomic_crtc_for_each_plane() makes reference to a function called drm_crtc_for_each_pending_plane(). I've guessed that the actual function name is drm_atomic_crtc_state_for_each_plane() as that matches best the intent of the comment. Signed-off-by: Liviu Dudau --- in

Re: [PATCH v3 2/3] drm/arm: Add support for Mali Display Processors

2016-06-10 Thread Liviu Dudau
On Thu, Jun 09, 2016 at 08:56:29PM +0200, Daniel Vetter wrote: > On Thu, Jun 09, 2016 at 05:18:18PM +0100, Liviu Dudau wrote: > > Add support for the new family of Display Processors from ARM Ltd. > > This commit adds basic support for Mali DP500, DP550 and DP650 > > parts,

[PATCH v3 1/3] dt/bindings: display: Add DT bindings for Mali Display Processors.

2016-06-09 Thread Liviu Dudau
Add DT bindings documentation for the Mali Display Processor. The bindings describe the Mali DP500, DP550 and DP650 processors from ARM Ltd. Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Liviu Dudau Acked-by: Rob Herring --- .../devicetree/bindings/display

[PATCH v3 3/3] MAINTAINERS: Add entry for Mali-DP driver

2016-06-09 Thread Liviu Dudau
Add MAINTAINERS entry for ARM Mali-DP driver and update the HDLCD file matching pattern to cover only HDLCD rather than the whole drivers/gpu/drm/arm directory. Signed-off-by: Liviu Dudau --- MAINTAINERS | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b

[PATCH v3 0/3] Add support for ARM Mali Display Processors

2016-06-09 Thread Liviu Dudau
for the use of interrupt-names. - removed the MALIDP_HW_FEATURE_DS (display split) from this version pending further development - Renamed module from malidp to mali-dp. - Added MAINTAINERS update Many thanks, Liviu Liviu Dudau (3): dt/bindings: display: Add DT bindings for Mali Display Pr

[PATCH v3 2/3] drm/arm: Add support for Mali Display Processors

2016-06-09 Thread Liviu Dudau
Add support for the new family of Display Processors from ARM Ltd. This commit adds basic support for Mali DP500, DP550 and DP650 parts, with only the display engine being supported at the moment. Cc: David Brown Cc: Brian Starkey Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/Kconfig

Re: [RFC][PATCH 6/6] staging: android: ion: Introduce new ioctls for dynamic heaps

2016-06-08 Thread Liviu Dudau
On Mon, Jun 06, 2016 at 11:23:33AM -0700, Laura Abbott wrote: > From: Laura Abbott > > > The Ion ABI for heaps is limiting to work with for more complex systems. > Heaps have to be registered at boot time with known ids available to > userspace. This becomes a tight ABI which is prone to breakag

Re: [RFC][PATCH 4/6] staging: android: ion: Pull out ion ioctls to a separate file

2016-06-08 Thread Liviu Dudau
On Mon, Jun 06, 2016 at 11:23:31AM -0700, Laura Abbott wrote: > > The number of Ion ioctls may continue to grow along with necessary > validation. Pull it out into a separate file for easier management > and review. > > Signed-off-by: Laura Abbott Reviewed-by: Liviu Dudau

Re: [RFC][PATCH 2/6] staging: android: ion: Switch to using an idr to manage heaps

2016-06-08 Thread Liviu Dudau
dev->heaps_debug_root, heap, > &debug_heap_fops); > @@ -1639,7 +1662,7 @@ int ion_device_add_heap(struct ion_device *dev, struct > ion_heap *heap) > path, debug_name); > } > } > - > + dev->heap_cnt++; > up_write(&dev->lock); > return 0; > } > @@ -1689,7 +1712,7 @@ debugfs_done: > idev->buffers = RB_ROOT; > mutex_init(&idev->buffer_lock); > init_rwsem(&idev->lock); > - plist_head_init(&idev->heaps); > + idr_init(&idev->idr); > idev->clients = RB_ROOT; > ion_root_client = &idev->clients; > mutex_init(&debugfs_mutex); > -- > 2.5.5 > Reviewed-by: Liviu Dudau -- | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --- ¯\_(ツ)_/¯

Re: [RFC][PATCH 1/6] staging: android: ion: return error value for ion_device_add_heap

2016-06-08 Thread Liviu Dudau
On Mon, Jun 06, 2016 at 11:23:28AM -0700, Laura Abbott wrote: > From: Laura Abbott > > > ion_device_add_heap doesn't return an error value. Change it to return > information to callers. > > Signed-off-by: Laura Abbott Reviewed-by: Liviu Dudau > --- > d

Re: [PATCH] drm/fb_cma_helper: Implement fb_mmap callback

2016-06-07 Thread liviu . dudau
On Tue, Jun 07, 2016 at 04:43:05PM +0200, Daniel Vetter wrote: > On Tue, Jun 07, 2016 at 01:18:09PM +0100, Robin Murphy wrote: > > In the absence of an fb_mmap callback, the fbdev code falls back to a > > naive implementation which relies upon the DMA address being the same > > as the physical addr

Re: [RFC][PATCH 1/3] staging: ion: Move away from the DMA APIs for cache flushing

2016-05-26 Thread Liviu Dudau
On Wed, May 25, 2016 at 12:48:02PM -0700, Laura Abbott wrote: > > Ion is currently using the DMA APIs in non-compliant ways for cache > maintaince. The issue is Ion needs to do cache operations outside of > the regular DMA model. The Ion model matches more closely with the > DRM model which calls

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-24 Thread Liviu Dudau
t I hope it is going to be a one off occurence. > > On 25 April 2016 at 15:19, Liviu Dudau wrote: > > > --- /dev/null > > +++ b/drivers/gpu/drm/arm/malidp_crtc.c > > @@ -0,0 +1,259 @@ > > > +static void malidp_crtc_enable(struct drm_crtc *crtc) &

[PATCH] drm: hdlcd: Revamp runtime power management

2016-05-20 Thread Liviu Dudau
the runtime PM after the component master has finished collecting the slave components and use the DRM atomic helpers to suspend and resume the device. Tested-by: Robin Murphy Signed-off-by: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_crtc.c | 23 +-- drivers/gpu/drm/arm

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-20 Thread Liviu Dudau
On Fri, May 20, 2016 at 08:57:47AM +0200, Daniel Vetter wrote: > On Thu, May 19, 2016 at 04:26:49PM +0100, Liviu Dudau wrote: > > On Mon, Apr 25, 2016 at 03:19:23PM +0100, Liviu Dudau wrote: > > > Add support for the new family of Display Processors from ARM Ltd. > >

Re: [PATCH v2 2/3] drm/arm: Add support for Mali Display Processors

2016-05-19 Thread Liviu Dudau
On Mon, Apr 25, 2016 at 03:19:23PM +0100, Liviu Dudau wrote: > Add support for the new family of Display Processors from ARM Ltd. > This commit adds basic support for Mali DP500, DP550 and DP650 > parts, with only the display engine being supported at the moment. > > Cc: David Bro

Re: [PATCH 1/2] drm: hdlcd: Skip PM callbacks if unbound

2016-05-09 Thread liviu . dudau
s_and_enter+0x9c/0x480 > > [ 52.390699] [] pm_suspend+0x1d0/0x240 > > [ 52.395890] [] state_store+0x80/0x100 > > [ 52.401084] [] kobj_attr_store+0x14/0x28 > > [ 52.406535] [] sysfs_kf_write+0x48/0x58 > > [ 52.411899] [] kernfs_fop_write+0xbc/0x188 > > [ 52.4175

<    1   2   3   4   5   6   7   8   9   10   >