Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 01:16:55PM +0100, Thierry Reding wrote: > On Wed, Nov 11, 2015 at 04:09:42PM +0000, Liviu Dudau wrote: > > On Tue, Nov 10, 2015 at 05:56:15PM +0100, Thierry Reding wrote: > > > On Tue, Nov 10, 2015 at 03:01:03PM +, Liviu Dudau wrote: > > > >

Re: [PATCH v2 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 10:52:25AM +, Jon Medhurst (Tixy) wrote: > On Thu, 2015-11-12 at 10:42 +0000, Liviu Dudau wrote: > > > This is on-chip RAM or nornal system RAM? We already have bindings > > for > > > both. > > > > Juno has a set of TLX (T

Re: [PATCH v2 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.

2015-11-12 Thread Liviu Dudau
On Wed, Nov 11, 2015 at 12:48:50PM -0600, Rob Herring wrote: > On Wed, Nov 11, 2015 at 04:06:47PM +0000, Liviu Dudau wrote: > > Cc: Rob Herring > > Cc: Pawel Moll > > Cc: Mark Rutland > > Cc: Ian Campbell > > Cc: Kumar Gala > > > > Signe

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 04:32:33PM +0800, Mark yao wrote: >On 2015年11月10日 23:01, Liviu Dudau wrote: > > Hello, > > When booting my Juno board with the HDLCD driver that I have converted to > atomic operations I'm getting the following warning: > >

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 02:34:57PM +0800, Mark yao wrote: Mark, >On 2015年11月12日 14:27, Mark yao wrote: > > On 2015年11月11日 00:56, Thierry Reding wrote: > > On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Dudau wrote: > > Hello, > > When booting my Juno

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 02:34:57PM +0800, Mark yao wrote: Mark, >On 2015年11月12日 14:27, Mark yao wrote: > > On 2015年11月11日 00:56, Thierry Reding wrote: > > On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Dudau wrote: > > Hello, > > When booting my Juno

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 04:32:33PM +0800, Mark yao wrote: >On 2015年11月10日 23:01, Liviu Dudau wrote: > > Hello, > > When booting my Juno board with the HDLCD driver that I have converted to > atomic operations I'm getting the following warning: > >

Re: [PATCH v2 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.

2015-11-12 Thread Liviu Dudau
On Wed, Nov 11, 2015 at 12:48:50PM -0600, Rob Herring wrote: > On Wed, Nov 11, 2015 at 04:06:47PM +0000, Liviu Dudau wrote: > > Cc: Rob Herring <robh...@kernel.org> > > Cc: Pawel Moll <pawel.m...@arm.com> > > Cc: Mark Rutland <mark.rutl...@arm.co

Re: [PATCH v2 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 10:52:25AM +, Jon Medhurst (Tixy) wrote: > On Thu, 2015-11-12 at 10:42 +0000, Liviu Dudau wrote: > > > This is on-chip RAM or nornal system RAM? We already have bindings > > for > > > both. > > > > Juno has a set of TLX (T

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 01:16:55PM +0100, Thierry Reding wrote: > On Wed, Nov 11, 2015 at 04:09:42PM +0000, Liviu Dudau wrote: > > On Tue, Nov 10, 2015 at 05:56:15PM +0100, Thierry Reding wrote: > > > On Tue, Nov 10, 2015 at 03:01:03PM +, Liviu Dudau wrote: > > > >

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 02:34:11PM +0100, Thierry Reding wrote: > On Thu, Nov 12, 2015 at 06:49:38PM +0800, Mark yao wrote: > > On 2015年11月12日 18:36, Liviu Dudau wrote: > > >On Thu, Nov 12, 2015 at 04:32:33PM +0800, Mark yao wrote: > > >> On 2015年1

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-12 Thread Liviu Dudau
On Thu, Nov 12, 2015 at 05:12:33PM +0100, Thierry Reding wrote: > On Thu, Nov 12, 2015 at 02:03:35PM +0000, Liviu Dudau wrote: > > On Thu, Nov 12, 2015 at 02:34:11PM +0100, Thierry Reding wrote: > > > On Thu, Nov 12, 2015 at 06:49:38PM +0800, Mark yao wrote: > > > &g

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-11 Thread Liviu Dudau
On Wed, Nov 11, 2015 at 05:46:47PM +, Lorenzo Pieralisi wrote: > On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: > > [...] > > > >> In particular, I would like to understand, for an eg DWordIO descriptor, > > >> what Range Minimum, Range Maximum and Translation Offset represent, >

Re: [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.

2015-11-11 Thread Liviu Dudau
On Wed, Nov 11, 2015 at 05:51:52PM +, Russell King - ARM Linux wrote: > On Wed, Nov 11, 2015 at 03:34:32PM +0000, Liviu Dudau wrote: > > While going through the code testing I've noticed an unbalanced > > .unbind missing drm_connector_unregister() > > That actually d

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-11 Thread Liviu Dudau
On Tue, Nov 10, 2015 at 05:56:15PM +0100, Thierry Reding wrote: > On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Dudau wrote: > > Hello, > > > > When booting my Juno board with the HDLCD driver that I have converted to > > atomic operations I'm getting the following wa

[PATCH v2 3/4] arm64: Juno: Add HDLCD support to the Juno boards.

2015-11-11 Thread Liviu Dudau
ARM's Juno board has two HDLCD controllers, each linked to an NXP TDA19988 HDMI transmitter that provides output encoding. Add them to the device tree. Signed-off-by: Liviu Dudau --- arch/arm64/boot/dts/arm/juno-base.dtsi | 74 -- 1 file changed, 70 insertions

[PATCH v2 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.

2015-11-11 Thread Liviu Dudau
Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Ian Campbell Cc: Kumar Gala Signed-off-by: Liviu Dudau --- .../devicetree/bindings/drm/arm/arm,hdlcd.txt | 74 ++ 1 file changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/drm/arm/arm

[PATCH v2 4/4] MAINTAINERS: Add Liviu Dudau as maintainer for ARM HDLCD driver.

2015-11-11 Thread Liviu Dudau
Update MAINTAINERS file for HDLCD driver. Cc: Andrew Morton Cc: Arnd Bergmann Cc: Mauro Carvalho Chehab Cc: Greg KH Cc: Joe Perches Cc: Jiri Slaby Signed-off-by: Liviu Dudau --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fca7daf

[PATCH v2 2/4] drm: Add support for ARM's HDLCD controller.

2015-11-11 Thread Liviu Dudau
The HDLCD controller is a display controller that supports resolutions up to 4096x4096 pixels. It is present on various development boards produced by ARM Ltd and emulated by the latest Fast Models from the company. Cc: David Airlie Cc: Robin Murphy Signed-off-by: Liviu Dudau --- drivers/gpu

[PATCH v2 0/4] drm: Add support for the ARM HDLCD display controller

2015-11-11 Thread Liviu Dudau
support for atomic modeset v1: Original DRM submission can be found here [2] [1] http://lists.freedesktop.org/archives/dri-devel/2015-November/094172.html [2] http://lists.freedesktop.org/archives/dri-devel/2015-August/087685.html Best regards, Liviu Liviu Dudau (4): drm: arm: Add DT bindings

[PATCH 1/3] drm/i2c: tda998x: Unregister the connector in the unbind function.

2015-11-11 Thread Liviu Dudau
tda998x uses drm_connector_register() in the .bind function that needs to be balanced with a drm_connector_unregister() in the .unbind. Otherwise dangling sysfs entries are left behind and future rebinds will fail. Signed-off-by: Liviu Dudau Cc: Russell King --- drivers/gpu/drm/i2c

[PATCH 2/3] drm/i2c: tda998x: Increase the supported dotclock frequency to 165MHz for TDA19988.

2015-11-11 Thread Liviu Dudau
Spec sheet states that the TDA19988 supports up to 165MHz dotclock speeds. Without this change modes higher than 1080p are un-attainable. Signed-off-by: Liviu Dudau Cc: Russell King --- drivers/gpu/drm/i2c/tda998x_drv.c | 5 +++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.

2015-11-11 Thread Liviu Dudau
drm_connector_unregister() and updated the pixel clock support for TDA19988. These patches are to be applied on top of David Airlie's drm-next. I've used commit 816d2206f0f9 as that includes Russell's cleanup for tda998x that has gone into v4.4-rc1. Best regards, Liviu Liviu Dudau (3): drm/i2c: tda998x

[PATCH 3/3] drm/i2c: tda998x: Add support for atomic modesetting.

2015-11-11 Thread Liviu Dudau
When used with a DRIVER_ATOMIC enabled CRTC driver, the tda998x will cause crashes due to missing atomic operations. Fill the drm_connector_funcs struct with the atomic versions of the required functions and add the atomic modeset specific callbacks. Signed-off-by: Liviu Dudau Cc: Russell King

Re: [PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.

2015-11-11 Thread Liviu Dudau
On Wed, Nov 11, 2015 at 05:51:52PM +, Russell King - ARM Linux wrote: > On Wed, Nov 11, 2015 at 03:34:32PM +0000, Liviu Dudau wrote: > > While going through the code testing I've noticed an unbalanced > > .unbind missing drm_connector_unregister() > > That actually d

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-11-11 Thread Liviu Dudau
On Wed, Nov 11, 2015 at 05:46:47PM +, Lorenzo Pieralisi wrote: > On Tue, Nov 10, 2015 at 01:50:46PM +0800, Jiang Liu wrote: > > [...] > > > >> In particular, I would like to understand, for an eg DWordIO descriptor, > > >> what Range Minimum, Range Maximum and Translation Offset represent, >

Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-11 Thread Liviu Dudau
On Tue, Nov 10, 2015 at 05:56:15PM +0100, Thierry Reding wrote: > On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Dudau wrote: > > Hello, > > > > When booting my Juno board with the HDLCD driver that I have converted to > > atomic operations I'm getting the following wa

[PATCH v2 3/4] arm64: Juno: Add HDLCD support to the Juno boards.

2015-11-11 Thread Liviu Dudau
ARM's Juno board has two HDLCD controllers, each linked to an NXP TDA19988 HDMI transmitter that provides output encoding. Add them to the device tree. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- arch/arm64/boot/dts/arm/juno-base.dtsi | 74 --

[PATCH 3/3] drm/i2c: tda998x: Add support for atomic modesetting.

2015-11-11 Thread Liviu Dudau
When used with a DRIVER_ATOMIC enabled CRTC driver, the tda998x will cause crashes due to missing atomic operations. Fill the drm_connector_funcs struct with the atomic versions of the required functions and add the atomic modeset specific callbacks. Signed-off-by: Liviu Dudau <liviu

[PATCH 0/3] drm/i2c: tda998x: Add support for atomic modesetting.

2015-11-11 Thread Liviu Dudau
drm_connector_unregister() and updated the pixel clock support for TDA19988. These patches are to be applied on top of David Airlie's drm-next. I've used commit 816d2206f0f9 as that includes Russell's cleanup for tda998x that has gone into v4.4-rc1. Best regards, Liviu Liviu Dudau (3): drm/i2c: tda998x

[PATCH v2 1/4] drm: arm: Add DT bindings documentation for HDLCD driver.

2015-11-11 Thread Liviu Dudau
Cc: Rob Herring <robh...@kernel.org> Cc: Pawel Moll <pawel.m...@arm.com> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Ian Campbell <ijc+devicet...@hellion.org.uk> Cc: Kumar Gala <ga...@codeaurora.org> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> ---

[PATCH v2 4/4] MAINTAINERS: Add Liviu Dudau as maintainer for ARM HDLCD driver.

2015-11-11 Thread Liviu Dudau
<jsl...@suse.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index fca7daf..d74af10 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -820,6 +820,12 @@ S: Maintained F: driv

[PATCH v2 0/4] drm: Add support for the ARM HDLCD display controller

2015-11-11 Thread Liviu Dudau
support for atomic modeset v1: Original DRM submission can be found here [2] [1] http://lists.freedesktop.org/archives/dri-devel/2015-November/094172.html [2] http://lists.freedesktop.org/archives/dri-devel/2015-August/087685.html Best regards, Liviu Liviu Dudau (4): drm: arm: Add DT bindings

[PATCH v2 2/4] drm: Add support for ARM's HDLCD controller.

2015-11-11 Thread Liviu Dudau
.@arm.com> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/arm/Kconfig | 29 ++ drivers/gpu/drm/arm/Makefile | 2 + drivers/gpu/drm/arm/hdlcd_crtc.c | 334 ++

[PATCH 1/3] drm/i2c: tda998x: Unregister the connector in the unbind function.

2015-11-11 Thread Liviu Dudau
tda998x uses drm_connector_register() in the .bind function that needs to be balanced with a drm_connector_unregister() in the .unbind. Otherwise dangling sysfs entries are left behind and future rebinds will fail. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Cc: Russell King &l

[PATCH 2/3] drm/i2c: tda998x: Increase the supported dotclock frequency to 165MHz for TDA19988.

2015-11-11 Thread Liviu Dudau
Spec sheet states that the TDA19988 supports up to 165MHz dotclock speeds. Without this change modes higher than 1080p are un-attainable. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Cc: Russell King <rmk+ker...@arm.linux.org.uk> --- drivers/gpu/drm/i2c/tda998x_drv.c | 5 +++- 1

drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-10 Thread Liviu Dudau
Hello, When booting my Juno board with the HDLCD driver that I have converted to atomic operations I'm getting the following warning: [ cut here ] WARNING: at /work/repositories/kernel/drivers/gpu/drm/drm_atomic_helper.c:674 Modules linked in: hdlcd(+) clk_scpi

Re: [PATCH] Revert "drm/rockchip: Convert the probe function to the generic drm_of_component_probe()"

2015-11-10 Thread Liviu . Dudau
On Tue, Nov 10, 2015 at 04:47:19PM +0800, Mark Yao wrote: > This reverts commit 52f5eb60940de889ce98a876f6933b574ead3225. > > Rockchip drm can't work with generic drm_of_component_probe now > > Signed-off-by: Mark Yao Acked-by: Liviu Dudau > --- > drivers/gpu/drm/rockch

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-10 Thread Liviu Dudau
On Tue, Nov 10, 2015 at 04:53:09PM +0800, Mark yao wrote: >On 2015年11月09日 19:57, Liviu Dudau wrote: > > Meanwhile, what is your suggestion regarding the patchset. I've seen David > has > sent Linus a pull request for 4.4-rc1 that includes it. Should we send a > revert f

drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ?

2015-11-10 Thread Liviu Dudau
Hello, When booting my Juno board with the HDLCD driver that I have converted to atomic operations I'm getting the following warning: [ cut here ] WARNING: at /work/repositories/kernel/drivers/gpu/drm/drm_atomic_helper.c:674 Modules linked in: hdlcd(+) clk_scpi

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-10 Thread Liviu Dudau
On Tue, Nov 10, 2015 at 04:53:09PM +0800, Mark yao wrote: >On 2015年11月09日 19:57, Liviu Dudau wrote: > > Meanwhile, what is your suggestion regarding the patchset. I've seen David > has > sent Linus a pull request for 4.4-rc1 that includes it. Should we send a > revert f

Re: [PATCH] Revert "drm/rockchip: Convert the probe function to the generic drm_of_component_probe()"

2015-11-10 Thread Liviu . Dudau
On Tue, Nov 10, 2015 at 04:47:19PM +0800, Mark Yao wrote: > This reverts commit 52f5eb60940de889ce98a876f6933b574ead3225. > > Rockchip drm can't work with generic drm_of_component_probe now > > Signed-off-by: Mark Yao <mark@rock-chips.com> Acked-by: Liviu Dudau

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-09 Thread Liviu Dudau
On Mon, Nov 09, 2015 at 12:03:35PM +, Russell King - ARM Linux wrote: > On Mon, Nov 09, 2015 at 11:57:27AM +0000, Liviu Dudau wrote: > > Meanwhile, what is your suggestion regarding the patchset. I've seen David > > has > > sent Linus a pull request for 4.4-rc1 that i

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-09 Thread Liviu Dudau
On Mon, Nov 09, 2015 at 11:43:00AM +, Russell King - ARM Linux wrote: > On Mon, Nov 09, 2015 at 05:39:25PM +0800, Mark yao wrote: > > Hi Liviu > > Rockchip drm can't work with drm_of_component_probe function now, > > > > At drm_of_component_probe: > >

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-09 Thread Liviu Dudau
On Mon, Nov 09, 2015 at 05:39:25PM +0800, Mark yao wrote: > On 2015年10月19日 23:07, Liviu Dudau wrote: > >A lot of component based DRM drivers use a variant of the same code > >as the probe function. They bind the crtc ports in the first iteration > >and then scan through the

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-09 Thread Liviu Dudau
On Mon, Nov 09, 2015 at 05:39:25PM +0800, Mark yao wrote: > On 2015年10月19日 23:07, Liviu Dudau wrote: > >A lot of component based DRM drivers use a variant of the same code > >as the probe function. They bind the crtc ports in the first iteration > >and then scan through the

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-09 Thread Liviu Dudau
On Mon, Nov 09, 2015 at 11:43:00AM +, Russell King - ARM Linux wrote: > On Mon, Nov 09, 2015 at 05:39:25PM +0800, Mark yao wrote: > > Hi Liviu > > Rockchip drm can't work with drm_of_component_probe function now, > > > > At drm_of_component_probe: > >

Re: [RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-11-09 Thread Liviu Dudau
On Mon, Nov 09, 2015 at 12:03:35PM +, Russell King - ARM Linux wrote: > On Mon, Nov 09, 2015 at 11:57:27AM +0000, Liviu Dudau wrote: > > Meanwhile, what is your suggestion regarding the patchset. I've seen David > > has > > sent Linus a pull request for 4.4-rc1 that i

Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init

2015-11-03 Thread Liviu . Dudau
On Tue, Nov 03, 2015 at 02:32:14PM +, Lorenzo Pieralisi wrote: > On Wed, Oct 28, 2015 at 11:49:40AM +, liviu.du...@arm.com wrote: > > On Tue, Oct 27, 2015 at 05:38:42PM +0100, Tomasz Nowicki wrote: > > [...] > > > > +static int __init pcibios_assign_resources(void) > > > +{ > > > + if

Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init

2015-11-03 Thread Liviu . Dudau
On Tue, Nov 03, 2015 at 02:32:14PM +, Lorenzo Pieralisi wrote: > On Wed, Oct 28, 2015 at 11:49:40AM +, liviu.du...@arm.com wrote: > > On Tue, Oct 27, 2015 at 05:38:42PM +0100, Tomasz Nowicki wrote: > > [...] > > > > +static int __init pcibios_assign_resources(void) > > > +{ > > > + if

Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init

2015-10-28 Thread Liviu . Dudau
config space regions) and > >>_CRS (IO/irq resources) to initialize PCI hostbridge. > >> > >>Signed-off-by: Tomasz Nowicki > >>Signed-off-by: Hanjun Guo > >>Signed-off-by: Suravee Suthikulpanit > >>CC: Arnd Bergmann > >>CC: Catalin

Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init

2015-10-28 Thread Liviu . Dudau
y: Suravee Suthikulpanit > CC: Arnd Bergmann > CC: Catalin Marinas > CC: Liviu Dudau > CC: Lorenzo Pieralisi > CC: Will Deacon > --- > arch/arm64/Kconfig | 6 ++ > arch/arm64/kernel/pci.c | 208 > +--- > 2 files

Re: [PATCH V1 10/11] pci, acpi: Provide generic way to assign bus domain number.

2015-10-28 Thread Liviu . Dudau
> - * corresponding error. > + * to mix domain numbers obtained from DT, ACPI and > + * pci_get_new_domain_nr(), which is a recipe for domain mishandling and > + * it is prevented by invalidating the domain value (domain = -1) and > + * printing a correspondin

Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init

2015-10-28 Thread Liviu . Dudau
config space regions) and > >>_CRS (IO/irq resources) to initialize PCI hostbridge. > >> > >>Signed-off-by: Tomasz Nowicki <t...@semihalf.com> > >>Signed-off-by: Hanjun Guo <hanjun@linaro.org> > >>Signed-off-by: Suravee Suthikulpanit <

Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init

2015-10-28 Thread Liviu . Dudau
uo <hanjun@linaro.org> > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> > CC: Arnd Bergmann <a...@arndb.de> > CC: Catalin Marinas <catalin.mari...@arm.com> > CC: Liviu Dudau <liviu.du...@arm.com> > CC: Lorenzo Pieralisi <

Re: [PATCH V1 10/11] pci, acpi: Provide generic way to assign bus domain number.

2015-10-28 Thread Liviu . Dudau
* printing a corresponding error. >*/ > + > + domain = of_get_pci_domain_nr(parent->of_node); Not sure what you've got here by splitting the original line into two other than an increase in the change count. Otherwise, it looks sensible. Reviewed-by: Liv

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 07:49:13PM +0800, Jiang Liu wrote: > On 2015/10/21 19:27, Tomasz Nowicki wrote: > > On 21.10.2015 13:02, Liviu Dudau wrote: > >> On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > >>> On 14.10.2015 08:29, Jiang Liu wrote: >

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 01:27:33PM +0200, Tomasz Nowicki wrote: > On 21.10.2015 13:02, Liviu Dudau wrote: > >On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > >>On 14.10.2015 08:29, Jiang Liu wrote: > >>>Introduce common interface acpi_pci_

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > On 14.10.2015 08:29, Jiang Liu wrote: > >Introduce common interface acpi_pci_root_create() and related data > >structures to create PCI root bus for ACPI PCI host bridges. It will > >be used to kill duplicated arch specific code for

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 01:27:33PM +0200, Tomasz Nowicki wrote: > On 21.10.2015 13:02, Liviu Dudau wrote: > >On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > >>On 14.10.2015 08:29, Jiang Liu wrote: > >>>Introduce common interface acpi_pci_

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 07:49:13PM +0800, Jiang Liu wrote: > On 2015/10/21 19:27, Tomasz Nowicki wrote: > > On 21.10.2015 13:02, Liviu Dudau wrote: > >> On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > >>> On 14.10.2015 08:29, Jiang Liu wrote: >

Re: [Patch v7 4/7] PCI/ACPI: Add interface acpi_pci_root_create()

2015-10-21 Thread Liviu Dudau
On Wed, Oct 21, 2015 at 11:57:53AM +0200, Tomasz Nowicki wrote: > On 14.10.2015 08:29, Jiang Liu wrote: > >Introduce common interface acpi_pci_root_create() and related data > >structures to create PCI root bus for ACPI PCI host bridges. It will > >be used to kill duplicated arch specific code for

Re: [PATCH v4 0/4] drm: Cleanup probe function for component based masters.

2015-10-20 Thread Liviu Dudau
On Tue, Oct 20, 2015 at 12:02:33PM +0200, Daniel Vetter wrote: > On Tue, Oct 20, 2015 at 10:23:11AM +0100, Liviu Dudau wrote: > > Changelog: > > v4: Fixed a bug where the wrong pointer was sent to component_match_add() > > and > > component_master_add_with_match

Re: [PATCH v4 1/4] drm: Introduce generic probe function for component based masters.

2015-10-20 Thread Liviu Dudau
On Tue, Oct 20, 2015 at 11:09:09AM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 20, 2015 at 11:00:55AM +0100, Emil Velikov wrote: > > Hi Liviu, > > > > On 20 October 2015 at 10:23, Liviu Dudau wrote: > > > A lot of component based DRM drivers

[PATCH v4 1/4] drm: Introduce generic probe function for component based masters.

2015-10-20 Thread Liviu Dudau
drm_of_component_probe() in order to increase code reuse. Cc: David Airlie Signed-off-by: Liviu Dudau Acked-by: Russell King --- drivers/gpu/drm/drm_of.c | 88 include/drm/drm_of.h | 13 +++ 2 files changed, 101 insertions(+) diff --git a/drivers

[PATCH v4 2/4] drm/imx: Convert the probe function to the generic drm_of_component_probe()

2015-10-20 Thread Liviu Dudau
The generic function is functionally equivalent to the driver's imx_drm_platform_probe(). Use the generic function and reduce the overall code size. Signed-off-by: Liviu Dudau Acked-by: Russell King --- drivers/gpu/drm/imx/imx-drm-core.c | 55 +++--- 1 file

[PATCH v4 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

2015-10-20 Thread Liviu Dudau
). This way future cleanup can further remove support for it. Signed-off-by: Liviu Dudau Acked-by: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 68 +++-- 1 file changed, 19 insertions(+), 49 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b

[PATCH v4 3/4] drm/rockchip: Convert the probe function to the generic drm_of_component_probe()

2015-10-20 Thread Liviu Dudau
Use the generic drm_of_component_probe() function to probe for components. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 81 +++-- 1 file changed, 6 insertions(+), 75 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b

[PATCH v4 0/4] drm: Cleanup probe function for component based masters.

2015-10-20 Thread Liviu Dudau
error codes and used in armada to trigger old platform_data support. Also looking for thoughts on the correctness of the patch and if it possible to co-opt more drivers into using the function. Best regards, Liviu Liviu Dudau (4): drm: Introduce generic probe function for component based maste

Re: [PATCH v4 2/3] arm64: Juno: Add support for the PCIe host bridge on Juno R1

2015-10-20 Thread Liviu Dudau
lin, Will, are you OK with pulling this patch into arm64 and if so do you want me to send a different pull request or are you happy to fetch it from the git tree git://linux-arm.org/linux-ld.git for-upstream/juno-pcie. Best regards, Liviu >On Fri, Oct 16, 2015 at 11:22 PM, Liviu Dudau <[1

Re: [PATCH v4 2/3] arm64: Juno: Add support for the PCIe host bridge on Juno R1

2015-10-20 Thread Liviu Dudau
lin, Will, are you OK with pulling this patch into arm64 and if so do you want me to send a different pull request or are you happy to fetch it from the git tree git://linux-arm.org/linux-ld.git for-upstream/juno-pcie. Best regards, Liviu >On Fri, Oct 16, 2015 at 11:22 PM, Liviu Dudau <[1

[PATCH v4 3/4] drm/rockchip: Convert the probe function to the generic drm_of_component_probe()

2015-10-20 Thread Liviu Dudau
Use the generic drm_of_component_probe() function to probe for components. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 81 +++-- 1 file changed, 6 insertions(+), 75 deletions(-) diff --git a/drivers/gpu/drm/ro

[PATCH v4 0/4] drm: Cleanup probe function for component based masters.

2015-10-20 Thread Liviu Dudau
error codes and used in armada to trigger old platform_data support. Also looking for thoughts on the correctness of the patch and if it possible to co-opt more drivers into using the function. Best regards, Liviu Liviu Dudau (4): drm: Introduce generic probe function for component based maste

[PATCH v4 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

2015-10-20 Thread Liviu Dudau
). This way future cleanup can further remove support for it. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Acked-by: Russell King <rmk+ker...@arm.linux.org.uk> --- drivers/gpu/drm/armada/armada_drv.c | 68 +++-- 1 file changed, 19 insertions(+),

[PATCH v4 1/4] drm: Introduce generic probe function for component based masters.

2015-10-20 Thread Liviu Dudau
drm_of_component_probe() in order to increase code reuse. Cc: David Airlie <airl...@linux.ie> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Acked-by: Russell King <rmk+ker...@arm.linux.org.uk> --- drivers/gpu/drm/drm_of.c | 88 in

Re: [PATCH v4 1/4] drm: Introduce generic probe function for component based masters.

2015-10-20 Thread Liviu Dudau
On Tue, Oct 20, 2015 at 11:09:09AM +0100, Russell King - ARM Linux wrote: > On Tue, Oct 20, 2015 at 11:00:55AM +0100, Emil Velikov wrote: > > Hi Liviu, > > > > On 20 October 2015 at 10:23, Liviu Dudau <liviu.du...@arm.com> wrote: > > > A lot of compo

[PATCH v4 2/4] drm/imx: Convert the probe function to the generic drm_of_component_probe()

2015-10-20 Thread Liviu Dudau
The generic function is functionally equivalent to the driver's imx_drm_platform_probe(). Use the generic function and reduce the overall code size. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Acked-by: Russell King <rmk+ker...@arm.linux.org.uk> --- drivers/gpu/drm/imx/imx-drm

Re: [PATCH v4 0/4] drm: Cleanup probe function for component based masters.

2015-10-20 Thread Liviu Dudau
On Tue, Oct 20, 2015 at 12:02:33PM +0200, Daniel Vetter wrote: > On Tue, Oct 20, 2015 at 10:23:11AM +0100, Liviu Dudau wrote: > > Changelog: > > v4: Fixed a bug where the wrong pointer was sent to component_match_add() > > and > > component_master_add_with_match

Re: [RFC PATCH v3 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
On Mon, Oct 19, 2015 at 04:17:14PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 04:07:50PM +0100, Liviu Dudau wrote: > > The armada DRM driver keeps some old platform data compatibility in the > > probe function that makes moving to the generic drm_of_

[RFC PATCH v3 3/4] drm/rockchip: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
Use the generic drm_of_component_probe() function to probe for components. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 81 +++-- 1 file changed, 6 insertions(+), 75 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b

[RFC PATCH v3 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
drm_of_component_probe() in order to increase code reuse. Cc: David Airlie Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_of.c | 88 include/drm/drm_of.h | 13 +++ 2 files changed, 101 insertions(+) diff --git a/drivers/gpu/drm/drm_of.c b

[RFC PATCH v3 0/4] drm: Cleanup probe function for component based masters.

2015-10-19 Thread Liviu Dudau
is different from the other possible error codes and used in armada to trigger old platform_data support. Also looking for thoughts on the correctness of the patch and if it possible to co-opt more drivers into using the function. Best regards, Liviu Liviu Dudau (4): drm: Introduce generic p

[RFC PATCH v3 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
). This way future cleanup can further remove support for it. Signed-off-by: Liviu Dudau Cc: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 73 +++-- 1 file changed, 22 insertions(+), 51 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers

[RFC PATCH v3 2/4] drm/imx: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
The generic function is functionally equivalent to the driver's imx_drm_platform_probe(). Use the generic function and reduce the overall code size. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/imx/imx-drm-core.c | 55 +++--- 1 file changed, 4 insertions(+), 51

Re: [RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
On Mon, Oct 19, 2015 at 03:50:27PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 04:42:25PM +0200, Daniel Vetter wrote: > > On Mon, Oct 19, 2015 at 02:26:38PM +0100, Russell King - ARM Linux wrote: > > > On Mon, Oct 19, 2015 at 02:02:58PM +0100, Liviu Dudau wro

Re: [RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
On Mon, Oct 19, 2015 at 02:26:38PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 02:02:58PM +0100, Liviu Dudau wrote: > > On Mon, Oct 19, 2015 at 01:25:37PM +0100, Russell King - ARM Linux wrote: > > > Please don't move this into here, it's completely in

Re: [RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
On Mon, Oct 19, 2015 at 01:25:37PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 01:21:50PM +0100, Liviu Dudau wrote: > > A lot of component based DRM drivers use a variant of the same code > > as the probe function. They bind the crtc ports in the

[RFC PATCH v2 2/4] drm/imx: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
The generic function is functionally equivalent to the driver's imx_drm_platform_probe(). Use the generic function and reduce the overall code size. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/imx/imx-drm-core.c | 54 +- 1 file changed, 1 insertion(+), 53

[RFC PATCH v2 0/4] drm: Cleanup probe function for component based masters.

2015-10-19 Thread Liviu Dudau
support. Also looking for thoughts on the correctness of the patch and if it possible to co-opt more drivers into using the function. Best regards, Liviu Liviu Dudau (4): drm: Introduce generic probe function for component based masters. drm/imx: Convert the probe function to the generic drm_of_co

[RFC PATCH v2 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
). This way future cleanup can further remove support for it. Signed-off-by: Liviu Dudau Cc: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 73 +++-- 1 file changed, 22 insertions(+), 51 deletions(-) diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers

[RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
drm_of_component_probe() in order to increase code reuse. Cc: David Airlie Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_of.c | 92 include/drm/drm_of.h | 12 +++ 2 files changed, 104 insertions(+) diff --git a/drivers/gpu/drm/drm_of.c b

[RFC PATCH v2 3/4] drm/rockchip: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
Use the generic drm_of_component_probe() function to probe for components. Signed-off-by: Liviu Dudau --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 86 ++--- 1 file changed, 6 insertions(+), 80 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b

[RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
drm_of_component_probe() in order to increase code reuse. Cc: David Airlie <airl...@linux.ie> Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/drm_of.c | 92 include/drm/drm_of.h | 12 +++ 2 files changed, 104 inserti

[RFC PATCH v2 3/4] drm/rockchip: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
Use the generic drm_of_component_probe() function to probe for components. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 86 ++--- 1 file changed, 6 insertions(+), 80 deletions(-) diff --git a/drivers/gpu/drm/ro

[RFC PATCH v2 0/4] drm: Cleanup probe function for component based masters.

2015-10-19 Thread Liviu Dudau
support. Also looking for thoughts on the correctness of the patch and if it possible to co-opt more drivers into using the function. Best regards, Liviu Liviu Dudau (4): drm: Introduce generic probe function for component based masters. drm/imx: Convert the probe function to the generic drm_of_co

[RFC PATCH v2 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
). This way future cleanup can further remove support for it. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Cc: Russell King <rmk+ker...@arm.linux.org.uk> --- drivers/gpu/drm/armada/armada_drv.c | 73 +++-- 1 file changed, 22 insertions(+), 51 deleti

[RFC PATCH v2 2/4] drm/imx: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
The generic function is functionally equivalent to the driver's imx_drm_platform_probe(). Use the generic function and reduce the overall code size. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/imx/imx-drm-core.c | 54 +- 1 file c

Re: [RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
On Mon, Oct 19, 2015 at 01:25:37PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 01:21:50PM +0100, Liviu Dudau wrote: > > A lot of component based DRM drivers use a variant of the same code > > as the probe function. They bind the crtc ports in the

Re: [RFC PATCH v2 1/4] drm: Introduce generic probe function for component based masters.

2015-10-19 Thread Liviu Dudau
On Mon, Oct 19, 2015 at 02:26:38PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 02:02:58PM +0100, Liviu Dudau wrote: > > On Mon, Oct 19, 2015 at 01:25:37PM +0100, Russell King - ARM Linux wrote: > > > Please don't move this into here, it's completely in

[RFC PATCH v3 4/4] drm/armada: Convert the probe function to the generic drm_of_component_probe()

2015-10-19 Thread Liviu Dudau
). This way future cleanup can further remove support for it. Signed-off-by: Liviu Dudau <liviu.du...@arm.com> Cc: Russell King <rmk+ker...@arm.linux.org.uk> --- drivers/gpu/drm/armada/armada_drv.c | 73 +++-- 1 file changed, 22 insertions(+), 51 deleti

<    3   4   5   6   7   8   9   10   11   12   >