[RFC PATCH] initramfs: finish fput() before accessing any binary from initramfs

initramfs as fput() is still pending on that binary. This patch makes sure that fput() is completed after unpacking initramfs. Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> --- - Reproduced on TI K2HK EVM. K2HK Queue Manager subsystem driver[1] tries to load a firmware from initr

[RFC PATCH] initramfs: finish fput() before accessing any binary from initramfs

initramfs as fput() is still pending on that binary. This patch makes sure that fput() is completed after unpacking initramfs. Signed-off-by: Lokesh Vutla --- - Reproduced on TI K2HK EVM. K2HK Queue Manager subsystem driver[1] tries to load a firmware from initramfs during boot. Sometim

Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration

On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote: > Add support for programmable MAC impedance configuration > > Signed-off-by: Mugunthan V N > --- > drivers/net/phy/dp83867.c | 28 > 1 file changed, 28 insertions(+) > > diff --git

Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration

On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote: > Add support for programmable MAC impedance configuration > > Signed-off-by: Mugunthan V N > --- > drivers/net/phy/dp83867.c | 28 > 1 file changed, 28 insertions(+) > > diff --git

Re: [PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings

On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote: > The default impedance settings of the phy is not the optimal > value, due to this the second ethernet is not working. Fix it > with correct values which makes the second ethernet port to work. > > Signed-off-by: Mugunthan V N

Re: [PATCH v2 3/4] ARM: dts: dra72-evm-revc: fix correct phy delay and impedance settings

On Tuesday 04 October 2016 06:26 PM, Mugunthan V N wrote: > The default impedance settings of the phy is not the optimal > value, due to this the second ethernet is not working. Fix it > with correct values which makes the second ethernet port to work. > > Signed-off-by: Mugunthan V N > --- >

Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control

On Saturday 20 August 2016 04:21 AM, Nishanth Menon wrote: > Texas Instrument's System Control Interface (TI-SCI) Message Protocol > is used in Texas Instrument's System on Chip (SoC) such as those > in keystone family K2G SoC to communicate between various compute > processors with a central

Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control

On Saturday 20 August 2016 04:21 AM, Nishanth Menon wrote: > Texas Instrument's System Control Interface (TI-SCI) Message Protocol > is used in Texas Instrument's System on Chip (SoC) such as those > in keystone family K2G SoC to communicate between various compute > processors with a central

Re: [PATCH 2/5] firmware: Add basic support for TI System Control Interface (TI-SCI) protocol

On 8/20/2016 4:21 AM, Nishanth Menon wrote: > Texas Instrument's System Control Interface (TI-SCI) Message Protocol > is used in Texas Instrument's System on Chip (SoC) such as those > in keystone family K2G SoC to communicate between various compute > processors with a central system controller

Re: [PATCH 2/5] firmware: Add basic support for TI System Control Interface (TI-SCI) protocol

On 8/20/2016 4:21 AM, Nishanth Menon wrote: > Texas Instrument's System Control Interface (TI-SCI) Message Protocol > is used in Texas Instrument's System on Chip (SoC) such as those > in keystone family K2G SoC to communicate between various compute > processors with a central system controller

Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6

On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote: > dra72x device has i2c6 controller. > Adding hwmod definition for the same. > > Reference DRA72x TRM [ SPRUHP2Q ] > > Signed-off-by: Ravikumar Kattekola > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23

Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6

On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote: > dra72x device has i2c6 controller. > Adding hwmod definition for the same. > > Reference DRA72x TRM [ SPRUHP2Q ] > > Signed-off-by: Ravikumar Kattekola > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23

Re: [PATCH 3/3] ARM: configs: keystone: Enable PINCTRL_SINGLE Config

On Monday 23 May 2016 05:59 PM, Keerthy wrote: > keystone-k2l devices use pinmux and are compliant with PINCTRL_SINGLE. > Hence enable the config option. > > Signed-off-by: Keerthy A similar patch[1] is already posted. [1]https://patchwork.kernel.org/patch/8958091/ Thanks

Re: [PATCH 3/3] ARM: configs: keystone: Enable PINCTRL_SINGLE Config

On Monday 23 May 2016 05:59 PM, Keerthy wrote: > keystone-k2l devices use pinmux and are compliant with PINCTRL_SINGLE. > Hence enable the config option. > > Signed-off-by: Keerthy A similar patch[1] is already posted. [1]https://patchwork.kernel.org/patch/8958091/ Thanks and regards,

Re: [PATCH 2/3] arm: mach-keystone: Enable PINCTRL config

On Monday 23 May 2016 05:59 PM, Keerthy wrote: > keystone-k2l uses pinmux and is compliant with PINCTRL_SINGLE > which depends on PINCTRL. Hence enable PINCTRL. > > Signed-off-by: Keerthy > --- > arch/arm/mach-keystone/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 2/3] arm: mach-keystone: Enable PINCTRL config

On Monday 23 May 2016 05:59 PM, Keerthy wrote: > keystone-k2l uses pinmux and is compliant with PINCTRL_SINGLE > which depends on PINCTRL. Hence enable PINCTRL. > > Signed-off-by: Keerthy > --- > arch/arm/mach-keystone/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2 0/3] AM57/DRA7 Clock Tree DTSI Fix-ups

ed for a few of the clocks and their resulting > frequencies. Tested on my DRA74-evm. Tested-by: Lokesh Vutla <lokeshvu...@ti.com> Thanks and regards, Lokesh > > v2 Changes: > * Rebased on linux-next as requested by Tony Lindgren > * Eliminated previous patch 2 as ano

Re: [PATCH v2 0/3] AM57/DRA7 Clock Tree DTSI Fix-ups

ed for a few of the clocks and their resulting > frequencies. Tested on my DRA74-evm. Tested-by: Lokesh Vutla Thanks and regards, Lokesh > > v2 Changes: > * Rebased on linux-next as requested by Tony Lindgren > * Eliminated previous patch 2 as another change fixing th

Re: [PATCH v3] arm: omap2: remove redundant multiplatform checks

a > silent option and all machines selecting this option are multiplatform > devices. As a consequence checks for CONFIG_ARCH_MULTIPLATFORM as well > as CONFIG_ARCH_OMAP2PLUS within that directory are superfluous and can > be removed. Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> Thanks and regards, Lokesh

Re: [PATCH v3] arm: omap2: remove redundant multiplatform checks

ing this option are multiplatform > devices. As a consequence checks for CONFIG_ARCH_MULTIPLATFORM as well > as CONFIG_ARCH_OMAP2PLUS within that directory are superfluous and can > be removed. Reviewed-by: Lokesh Vutla Thanks and regards, Lokesh

Re: [PATCH v2] arm: omap2: remove redundant multiplatform checks

On Wednesday 06 April 2016 04:05 AM, Jonas Rabenstein wrote: > The directory arch/arm/mach-omap2 is only selected for compilation if > CONFIG_ARCH_OMAP2PLUS is selected. CONFIG_ARCH_OMAP2PLUS itself is a > silent option and all machines selecting this option are multiplatform > devices. As a

Re: [PATCH v2] arm: omap2: remove redundant multiplatform checks

On Wednesday 06 April 2016 04:05 AM, Jonas Rabenstein wrote: > The directory arch/arm/mach-omap2 is only selected for compilation if > CONFIG_ARCH_OMAP2PLUS is selected. CONFIG_ARCH_OMAP2PLUS itself is a > silent option and all machines selecting this option are multiplatform > devices. As a

Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

On Tuesday 13 October 2015 07:14 PM, Franklin S Cooper Jr wrote: > ELM address information is provided by device tree. No longer need > to include this information within hwmod. Reviewed-by: Lokesh Vutla Thanks and regards, Lokesh > > Signed-off-by: Franklin S Cooper Jr >

Re: [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

On Tuesday 13 October 2015 01:14 PM, Heiko Schocher wrote: > Hello Lokesh, > > Am 13.10.2015 um 08:46 schrieb Lokesh Vutla: >> +Nishanth, >> >> On Tuesday 13 October 2015 10:59 AM, Heiko Schocher wrote: >>> On embedded devices, often there is a combination of

Re: [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

+Nishanth, On Tuesday 13 October 2015 10:59 AM, Heiko Schocher wrote: > On embedded devices, often there is a combination of > removable mmc devices (e.g. MMC/SD cards) and hard > wired ones (e.g. eMMC). Depending on the hardware > configuration, the 'mmcblkN' node might change if > the removable

Re: [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

On Tuesday 13 October 2015 01:14 PM, Heiko Schocher wrote: > Hello Lokesh, > > Am 13.10.2015 um 08:46 schrieb Lokesh Vutla: >> +Nishanth, >> >> On Tuesday 13 October 2015 10:59 AM, Heiko Schocher wrote: >>> On embedded devices, often there is a combination of

Re: [PATCH] mmc: omap_hsmmc: fix initialization order of mmc block devices

+Nishanth, On Tuesday 13 October 2015 10:59 AM, Heiko Schocher wrote: > On embedded devices, often there is a combination of > removable mmc devices (e.g. MMC/SD cards) and hard > wired ones (e.g. eMMC). Depending on the hardware > configuration, the 'mmcblkN' node might change if > the removable

Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data

On Tuesday 13 October 2015 07:14 PM, Franklin S Cooper Jr wrote: > ELM address information is provided by device tree. No longer need > to include this information within hwmod. Reviewed-by: Lokesh Vutla <lokeshvu...@ti.com> Thanks and regards, Lokesh > > Signed-off-by: Fr

[PATCH v3] crypto: omap-aes: Add support for GCM mode

OMAP AES hw supports AES-GCM mode. Adding support for GCM and RFC4106 GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla --- Tested on BeagleBone-Black: http://pastebin.ubuntu.com/12417512/ Changes since v1: - Addressed comments by Herbert. Previously posted here: https://www.mail

[PATCH v3] crypto: omap-aes: Add support for GCM mode

OMAP AES hw supports AES-GCM mode. Adding support for GCM and RFC4106 GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla <lokeshvu...@ti.com> --- Tested on BeagleBone-Black: http://pastebin.ubuntu.com/12417512/ Changes since v1: - Addressed comments by Herbert. Previously poste

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

Hi Herbert, On Wednesday 08 July 2015 09:48 AM, Herbert Xu wrote: > On Tue, Jul 07, 2015 at 09:01:48PM +0530, Lokesh Vutla wrote: >> >> +static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd, >> + struct aead_request *req) [..sn

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

Hi Herbert, On Wednesday 08 July 2015 09:48 AM, Herbert Xu wrote: On Tue, Jul 07, 2015 at 09:01:48PM +0530, Lokesh Vutla wrote: +static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd, + struct aead_request *req) [..snip..] +static int do_encrypt_iv

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

On Wednesday 08 July 2015 01:23 PM, Herbert Xu wrote: > On Wed, Jul 08, 2015 at 03:48:05PM +0800, Herbert Xu wrote: >> On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote: >>> >>>>> + if (req->assoclen + req->cryptlen == 0) { >>>>>

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

On Wednesday 08 July 2015 01:18 PM, Herbert Xu wrote: > On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote: >> >>>> + if (req->assoclen + req->cryptlen == 0) { >>>> + scatterwalk_map_and_copy(ctx->auth_tag, req->dst, 0, authle

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

On Wednesday 08 July 2015 09:48 AM, Herbert Xu wrote: > On Tue, Jul 07, 2015 at 09:01:48PM +0530, Lokesh Vutla wrote: >> >> +static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd, >> + struct aead_request *req) >> +{ >> +

Re: [PATCH v2 5/7] crypto: aead: Add aead_request_cast() api

On Wednesday 08 July 2015 09:26 AM, Herbert Xu wrote: > On Tue, Jul 07, 2015 at 09:01:47PM +0530, Lokesh Vutla wrote: >> Add aead_request_cast() api to get pointer to aead_request >> from cryto_async_request. >> >> Signed-off-by: Lokesh Vutla >> --- >&

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

On Wednesday 08 July 2015 01:23 PM, Herbert Xu wrote: On Wed, Jul 08, 2015 at 03:48:05PM +0800, Herbert Xu wrote: On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote: + if (req-assoclen + req-cryptlen == 0) { + scatterwalk_map_and_copy(ctx-auth_tag, req-dst, 0, authlen

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

On Wednesday 08 July 2015 01:18 PM, Herbert Xu wrote: On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote: + if (req-assoclen + req-cryptlen == 0) { + scatterwalk_map_and_copy(ctx-auth_tag, req-dst, 0, authlen, + 1); + return 0

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

On Wednesday 08 July 2015 09:48 AM, Herbert Xu wrote: On Tue, Jul 07, 2015 at 09:01:48PM +0530, Lokesh Vutla wrote: +static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd, + struct aead_request *req) +{ +void *buf_in; +int pages, alen, clen

Re: [PATCH v2 5/7] crypto: aead: Add aead_request_cast() api

On Wednesday 08 July 2015 09:26 AM, Herbert Xu wrote: On Tue, Jul 07, 2015 at 09:01:47PM +0530, Lokesh Vutla wrote: Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/crypto/internal/aead.h | 6

[PATCH v2 1/7] crypto: omap-aes: Fix CTR mode

is not aligned with AES_BLOCK_SIZE. Adding support for omap-aes driver for inputs with length not aligned with AES_BLOCK_SIZE. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers

[PATCH v2 7/7] crypto: tcrypt: Fix AEAD speed tests

The AEAD speed tests doesn't do a wait_for_completition, if the return value is EINPROGRESS or EBUSY. Fixing it here. Also add a test case for gcm(aes). Signed-off-by: Lokesh Vutla --- crypto/tcrypt.c | 65 ++--- 1 file changed, 43 insertions

[PATCH v2 5/7] crypto: aead: Add aead_request_cast() api

Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla --- include/crypto/internal/aead.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/crypto/internal/aead.h b/include/crypto/internal/aead.h index 4b25471..0423fa5

[PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

OMAP AES hw supports AES-GCM mode. Adding support for GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla --- drivers/crypto/Kconfig| 1 + drivers/crypto/Makefile | 3 +- drivers/crypto/omap-aes-gcm.c | 376 ++ drivers/crypto/omap

[PATCH v2 2/7] crypto: omap-aes: Increase priority of hw accelerator

Increasing the priority of omap-aes hw algos, in order to take precedence over sw algos. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 4a0e808

[PATCH v2 3/7] crypto: omap-aes: Fix configuring of AES mode

AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before configuring any AES mode. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 13 + 1 file changed

[PATCH v2 4/7] crypto: omap-aes: Use BIT() macro

Use BIT()/GENMASK() macros for all register definitions instead of hand-writing bit masks. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers

[PATCH v2 0/7] crypto: omap-aes: Add support for GCM mode

This series does some basic cleanup and adds support for AES GCM mode for omap aes driver. Changes since v1: - Switched GCM to new AEAD interface Lokesh Vutla (7): crypto: omap-aes: Fix CTR mode crypto: omap-aes: Increase priority of hw accelerator crypto: omap-aes: Fix configuring of AES

[PATCH v2 1/7] crypto: omap-aes: Fix CTR mode

is not aligned with AES_BLOCK_SIZE. Adding support for omap-aes driver for inputs with length not aligned with AES_BLOCK_SIZE. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff

[PATCH v2 4/7] crypto: omap-aes: Use BIT() macro

Use BIT()/GENMASK() macros for all register definitions instead of hand-writing bit masks. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/omap

[PATCH v2 0/7] crypto: omap-aes: Add support for GCM mode

This series does some basic cleanup and adds support for AES GCM mode for omap aes driver. Changes since v1: - Switched GCM to new AEAD interface Lokesh Vutla (7): crypto: omap-aes: Fix CTR mode crypto: omap-aes: Increase priority of hw accelerator crypto: omap-aes: Fix configuring of AES

[PATCH v2 3/7] crypto: omap-aes: Fix configuring of AES mode

AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before configuring any AES mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 13

[PATCH v2 2/7] crypto: omap-aes: Increase priority of hw accelerator

Increasing the priority of omap-aes hw algos, in order to take precedence over sw algos. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c

[PATCH v2 7/7] crypto: tcrypt: Fix AEAD speed tests

The AEAD speed tests doesn't do a wait_for_completition, if the return value is EINPROGRESS or EBUSY. Fixing it here. Also add a test case for gcm(aes). Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- crypto/tcrypt.c | 65 ++--- 1 file

[PATCH v2 5/7] crypto: aead: Add aead_request_cast() api

Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/crypto/internal/aead.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/crypto/internal/aead.h b/include/crypto/internal/aead.h index

[PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

OMAP AES hw supports AES-GCM mode. Adding support for GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/Kconfig| 1 + drivers/crypto/Makefile | 3 +- drivers/crypto/omap-aes-gcm.c | 376

Re: [PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

Hi, On Monday 06 July 2015 01:14 PM, Herbert Xu wrote: > On Thu, Jul 02, 2015 at 10:48:40AM +0530, Lokesh Vutla wrote: >> Adding simple speed tests for a range of block sizes for Async AEAD crypto >> algorithms. >> >> Signed-off-by: Lokesh Vutla > > What's w

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

Hi, On Monday 06 July 2015 01:05 PM, Herbert Xu wrote: > On Thu, Jul 02, 2015 at 10:48:38AM +0530, Lokesh Vutla wrote: >> Now the driver supports gcm mode, add omap-aes-gcm >> algo info to omap-aes driver. >> >> Signed-off-by: Lokesh Vutla > > You're using th

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

Hi, On Monday 06 July 2015 01:05 PM, Herbert Xu wrote: On Thu, Jul 02, 2015 at 10:48:38AM +0530, Lokesh Vutla wrote: Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com You're using the old AEAD interface. We

Re: [PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

Hi, On Monday 06 July 2015 01:14 PM, Herbert Xu wrote: On Thu, Jul 02, 2015 at 10:48:40AM +0530, Lokesh Vutla wrote: Adding simple speed tests for a range of block sizes for Async AEAD crypto algorithms. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com What's wrong with the existing AEAD

[PATCH] crypto: omap-des: Fix unmapping of dma channels

(). Reported-by: Tomi Valkeinen Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-des.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c index 4630709..0a70e46 100644 --- a/drivers/crypto/omap-des.c +++ b/drivers/crypto/omap-des.c

Re: [PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

On Thursday 02 July 2015 01:36 PM, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 10:48:39AM +0530, Lokesh Vutla wrote: >> Add support for PIO mode for GCM mode. >> >> Signed-off-by: Lokesh Vutla > > why do you require PIO ? Is there any situation where DMA can't be &

Re: [PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

On Thursday 02 July 2015 01:34 PM, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 10:48:36AM +0530, Lokesh Vutla wrote: >> Its not necessary that assoc data and plain text is passed always. >> Add these checks before processing the input. >> >> Signed-off-by: L

Re: [PATCH 05/10] crypto: omap-aes: Add support for GCM mode

On Thursday 02 July 2015 01:34 PM, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 10:48:35AM +0530, Lokesh Vutla wrote: >> OMAP AES hw supports aes gcm mode. > > here you refer to it as 'gcm' Will update it in next revision. > >> Adding support for GCM mode in omap-aes

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

On Thursday 02 July 2015 01:30 PM, Stephan Mueller wrote: > Am Donnerstag, 2. Juli 2015, 10:48:38 schrieb Lokesh Vutla: > > Hi Lokesh, > >> Now the driver supports gcm mode, add omap-aes-gcm >> algo info to omap-aes driver. >> >> Signed-off-by: Lokesh Vutla

Re: [PATCH 03/10] crypto: aead: Add aead_request_cast() api

On Thursday 02 July 2015 01:28 PM, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 10:48:33AM +0530, Lokesh Vutla wrote: >> Add aead_request_cast() api to get pointer to aead_request >> from cryto_async_request. >> >> Signed-off-by: Lokesh Vutla >> --- >> inc

Re: [PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

On Thursday 02 July 2015 01:27 PM, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 10:48:32AM +0530, Lokesh Vutla wrote: >> AES_CTRL_REG is used to configure AES mode. Before configuring >> any mode we need to make sure all other modes are reset or else >> driver will misbeha

Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

On Thursday 02 July 2015 01:23 PM, Felipe Balbi wrote: > On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote: >> OMAP AES driver returns an error if the data is not aligned with >> AES_BLOCK_SIZE bytes. >> But OMAP AES hw allows data input upto 1 byte aligne

Re: [PATCH 05/10] crypto: omap-aes: Add support for GCM mode

On Thursday 02 July 2015 01:34 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:35AM +0530, Lokesh Vutla wrote: OMAP AES hw supports aes gcm mode. here you refer to it as 'gcm' Will update it in next revision. Adding support for GCM mode in omap-aes driver. while here

Re: [PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

On Thursday 02 July 2015 01:27 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:32AM +0530, Lokesh Vutla wrote: AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

On Thursday 02 July 2015 01:30 PM, Stephan Mueller wrote: Am Donnerstag, 2. Juli 2015, 10:48:38 schrieb Lokesh Vutla: Hi Lokesh, Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c

Re: [PATCH 03/10] crypto: aead: Add aead_request_cast() api

On Thursday 02 July 2015 01:28 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:33AM +0530, Lokesh Vutla wrote: Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/linux/crypto.h |6

Re: [PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

On Thursday 02 July 2015 01:36 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:39AM +0530, Lokesh Vutla wrote: Add support for PIO mode for GCM mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com why do you require PIO ? Is there any situation where DMA can't be used? What would

Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

On Thursday 02 July 2015 01:23 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote: OMAP AES driver returns an error if the data is not aligned with AES_BLOCK_SIZE bytes. But OMAP AES hw allows data input upto 1 byte aligned, but still zeros are to be appended

Re: [PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

On Thursday 02 July 2015 01:34 PM, Felipe Balbi wrote: On Thu, Jul 02, 2015 at 10:48:36AM +0530, Lokesh Vutla wrote: Its not necessary that assoc data and plain text is passed always. Add these checks before processing the input. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com why can't

[PATCH] crypto: omap-des: Fix unmapping of dma channels

) [4.328500] [c004a840] (irq_exit) from [c000f9ac] (handle_IRQ+0x50/0xb0) [4.335589] [c000f9ac] (handle_IRQ) from [c0008688] (gic_handle_irq+0x28/0x5c) Removing the duplicate call to dma_unmap_sg(). Reported-by: Tomi Valkeinen tomi.valkei...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com

[PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

Its not necessary that assoc data and plain text is passed always. Add these checks before processing the input. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes-gcm.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/omap

[PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

Adding simple speed tests for a range of block sizes for Async AEAD crypto algorithms. Signed-off-by: Lokesh Vutla --- crypto/tcrypt.c | 233 +++ crypto/tcrypt.h |1 + 2 files changed, 234 insertions(+) diff --git a/crypto/tcrypt.c b

[PATCH 03/10] crypto: aead: Add aead_request_cast() api

Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla --- include/linux/crypto.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 10df5d2..20fac3d 100644 --- a/include

[PATCH 04/10] crypto: omap-aes: Use BIT() macro

Use BIT()/GENMASK() macros for all register definitions instead of hand-writing bit masks. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers

[PATCH 05/10] crypto: omap-aes: Add support for GCM mode

OMAP AES hw supports aes gcm mode. Adding support for GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla --- drivers/crypto/Makefile |3 +- drivers/crypto/omap-aes-gcm.c | 304 + drivers/crypto/omap-aes.c | 238

[PATCH 08/10] crypto: omap-aes: gmc: Add algo info

Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index e5e9a19..11f3850

[PATCH 07/10] crypto: omap-aes: gcm: Add support for unaligned lengths

Check if the inputs are not aligned, if not process the input before starting the hw acceleration. Similarly after completition of hw acceleration. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes-gcm.c | 82 + 1 file changed, 74 insertions(+), 8

[PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

Add support for PIO mode for GCM mode. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes-gcm.c | 10 ++ drivers/crypto/omap-aes.c | 24 ++-- drivers/crypto/omap-aes.h |3 ++- 3 files changed, 26 insertions(+), 11 deletions(-) diff --git

[PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before configuring any AES mode. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 13 + 1 file changed

[PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

for inputs not aligned with AES_BLOCK_SIZE. Signed-off-by: Lokesh Vutla --- drivers/crypto/omap-aes.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 9a28b7e..a923101 100644

[PATCH 00/10] crypto: omap-aes: Add support for GCM mode

This series does some basic cleanup and adds support for AES GCM mode for omap aes driver. Also adds a test case for async aead algos. Tested on BeagelBoneBlack: http://pastebin.ubuntu.com/11808341/ Lokesh Vutla (10): crypto: omap-aes: Add support for lengths not aligned

[PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode

Add support for PIO mode for GCM mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes-gcm.c | 10 ++ drivers/crypto/omap-aes.c | 24 ++-- drivers/crypto/omap-aes.h |3 ++- 3 files changed, 26 insertions(+), 11 deletions

[PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode

AES_CTRL_REG is used to configure AES mode. Before configuring any mode we need to make sure all other modes are reset or else driver will misbehave. So mask all modes before configuring any AES mode. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 13

[PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

Adding simple speed tests for a range of block sizes for Async AEAD crypto algorithms. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- crypto/tcrypt.c | 233 +++ crypto/tcrypt.h |1 + 2 files changed, 234 insertions(+) diff --git

[PATCH 03/10] crypto: aead: Add aead_request_cast() api

Add aead_request_cast() api to get pointer to aead_request from cryto_async_request. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- include/linux/crypto.h |6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 10df5d2..20fac3d

[PATCH 04/10] crypto: omap-aes: Use BIT() macro

Use BIT()/GENMASK() macros for all register definitions instead of hand-writing bit masks. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/crypto/omap

[PATCH 05/10] crypto: omap-aes: Add support for GCM mode

OMAP AES hw supports aes gcm mode. Adding support for GCM mode in omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/Makefile |3 +- drivers/crypto/omap-aes-gcm.c | 304 + drivers/crypto/omap-aes.c | 238

[PATCH 08/10] crypto: omap-aes: gmc: Add algo info

Now the driver supports gcm mode, add omap-aes-gcm algo info to omap-aes driver. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index

[PATCH 07/10] crypto: omap-aes: gcm: Add support for unaligned lengths

Check if the inputs are not aligned, if not process the input before starting the hw acceleration. Similarly after completition of hw acceleration. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes-gcm.c | 82 + 1 file changed

[PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly

Its not necessary that assoc data and plain text is passed always. Add these checks before processing the input. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes-gcm.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git

[PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

for inputs not aligned with AES_BLOCK_SIZE. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com --- drivers/crypto/omap-aes.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 9a28b7e..a923101

[PATCH 00/10] crypto: omap-aes: Add support for GCM mode

This series does some basic cleanup and adds support for AES GCM mode for omap aes driver. Also adds a test case for async aead algos. Tested on BeagelBoneBlack: http://pastebin.ubuntu.com/11808341/ Lokesh Vutla (10): crypto: omap-aes: Add support for lengths not aligned

[PATCH v3 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

and leaves it enabled until the rtc driver removal. This eliminates the idea of preventing spurious writes when RTC driver is loaded. So implement rtc lock and unlock functions before and after register writes. Signed-off-by: Lokesh Vutla Acked-by: Alexandre Belloni --- -- This is as advised

Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

On Thursday 02 April 2015 06:03 PM, Alexandre Belloni wrote: > On 02/04/2015 at 16:39:09 +0530, Lokesh Vutla wrote : [..snip..] >> } >> >> +static inline void am3352_rtc_unlock(struct omap_rtc *rtc) >> +{ >> +rtc_writel(rtc, OMAP_RTC_KICK0_REG, KIC

<    1   2   3   4   5   6   >