Re: [PATCH net-next 6/6] mvneta: recycle buffers

[...] > > diff --git a/drivers/net/ethernet/marvell/mvneta.c > > b/drivers/net/ethernet/marvell/mvneta.c > > index a635cf84608a..8b3250394703 100644 > > --- a/drivers/net/ethernet/marvell/mvneta.c > > +++ b/drivers/net/ethernet/marvell/mvneta.c > > @@ -2332,7 +2332,7 @@

Re: mt76: mt7921: add MCU support

> Hi, > Hi Colin, a fix for this issue has been already posted upstream: https://patchwork.kernel.org/project/linux-wireless/patch/857ff74f736d4e593f5ad602cee7ac67ebfca5ca.1612867656.git.lore...@kernel.org/ Regards, Lorenzo > Static analysis with Coverity on linux-next has found an issue

Re: [PATCH] mt76: Fix queue ID variable types after mcu queue split

quot;mt76: move mcu queues to mt76_dev q_mcu array") > Link: https://github.com/ClangBuiltLinux/linux/issues/1229 > Signed-off-by: Nathan Chancellor Acked-by: Lorenzo Bianconi > --- > drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +- > drivers/net/wireless/mediatek/mt76/

Re: [PATCH] iio: imu: st_lsm6dsx: Scaling factor type set to IIO_VAL_INT_PLUS_NANO

6411 and the FS now > is 0.001196411 × ((2^15)−1) ~= 39.2028 m/s^2. > > This patch extends to IIO_VAL_INT_PLUS_NANO type the scaling factor to all > IMU devices where SensorParameterRangeTest CTS test fails. > > Signed-off-by: Mario Tesi Hi Mario, just a minor comment inline. Fix

Re: mt7612 suspend/resume issue

> On Mon, Jun 22, 2020 at 4:53 PM Lorenzo Bianconi > wrote: > > > On Sun, Jun 21, 2020 at 10:54 PM Lorenzo Bianconi > > > wrote: > > > > > > +static int __maybe_unused > > > > > > +mt76x2e_suspend(struct pci_dev *pdev, pm_message_t

Re: mt7612 suspend/resume issue

> Hello, Lorenzo. > > On Sun, Jun 21, 2020 at 10:54 PM Lorenzo Bianconi wrote: > > > > +static int __maybe_unused > > > > +mt76x2e_suspend(struct pci_dev *pdev, pm_message_t state) > > > > +{ > > > > + struct mt76_dev *mdev = p

Re: mt7612 suspend/resume issue

> Hello, Lorenzo. Hi Oleksandr, > > Thanks for the quick reply. Please see my observation below. > > On Thu, Jun 18, 2020 at 01:18:59PM +0200, Lorenzo Bianconi wrote: > > I have not reproduced the issue myself yet, but I guess we can try: > > 1- update to latest Fe

Re: mt7612 suspend/resume issue

patch below? (compile-test only) Regards, Lorenzo [1] https://github.com/nbd168/wireless From 400268a0ee5843cf736308504dfbd2f20a291eaf Mon Sep 17 00:00:00 2001 Message-Id: <400268a0ee5843cf736308504dfbd2f20a291eaf.1592478809.git.lore...@kernel.org> From: Lorenzo Bianconi Date: Th

Re: mt76x2e hardware restart

fix buffer unmap with non-linear skbs mt76 dma layer is supposed to unmap skb data buffers while keep txwi mapped on hw dma ring. At the moment mt76 wrongly unmap txwi or does not unmap data fragments in even positions for non-linear skbs. This issue may result in hw hangs with A-MSUD if the system relies on IOMM

Re: mt76x2e hardware restart

> Hello. > > On 15.10.2019 18:52, Oleksandr Natalenko wrote: > > Thanks for the answer and the IRC discussion. As agreed I've applied > > [1] and [2], and have just swapped the card to try it again. So far, > > it works fine in 5 GHz band in 802.11ac mode as an AP. > > > > I'll give it more load

Re: mt76x2e hardware restart

? Hi Oleksandr, sorry for the delay. Felix and me worked on this issue today. Could you please try if the following patch fixes your issue? Regards, Lorenzo From cf3436c42a297967235a9c9778620c585100529e Mon Sep 17 00:00:00 2001 Message-Id: From: Lorenzo Bianconi Date: Sat, 12 Oct 2019 17

Re: [PATCH] mt7601u: phy: simplify zero check on val

> From: Colin Ian King > > Currently the zero check on val to break out of a loop > is a little obscure. Replace the val is zero and break check > with a loop while value is non-zero. > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/mediatek/mt7601u/phy.c | 4 +--- > 1 file

Re: [PATCH] iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo

gt; Hence I won't wait for Lorenzo to take a look (though there > is still a small window for comments whilst the autobuilders > poke at it!) > > Applied to the togreg branch of iio.git and pushed out as testing > for the autobuilders to take a look. > > Thanks, Acked-by: Lore

Re: [PATCH v4 1/3] iio: imu: st_lsm6sdx: move register definitions to sensor_settings struct

> Move some register definitions to the per-device array of struct > st_lsm6dsx_sensor_settings in order to simplify adding new sensor > devices to the driver. > > Also, remove completely unused register definitions. > > Signed-off-by: Martin Kepplinger Acked

Re: [PATCH] iio: imu: st_lsm6dsx: make IIO_CHAN_INFO_SCALE shared by type

l direction. Doubt that applies on these modern > parts though! > > Thanks, > > Jonathan AFAIK all the supported sensors have the same sensitivity on all axis and so I am fine with this patch (it should be done in this way from day 0 actually :)) but is it going to break uapi?

Re: [PATCH v3 4/5] iio: imu: st_lsm6dsx: add support for accel/gyro unit of lsm9sd1

> On Sun, 28 Jul 2019 08:04:51 +0200 > Martin Kepplinger wrote: > > > On 27.07.19 19:48, Jonathan Cameron wrote: > > > On Thu, 25 Jul 2019 07:31:31 +0200 > > > Martin Kepplinger wrote: > > > > > >> The LSM9DS1's accelerometer / gyroscope unit and it's magnetometer > > >> (separately > > >>

Re: [PATCHv2 2/3] iio: imu: st_lsm6dsx: add support for accel/gyro unit of lsm9sd1

t; * > + * - LSM9DS1: > + * - Accelerometer supported ODR [Hz]: 10, 50, 119, 238, 476, 952 > + * - Accelerometer supported full-scale [g]: +-2/+-4/+-8/+-16 > + * - Gyroscope supported ODR [Hz]: 15, 60, 119, 238, 476, 952 > + * - Gyroscope supported full-scale [dps]: +-245/+-

Re: [PATCH 2/3] iio: imu: st_lsm6dsx: add support for accel/gyro unit of lsm9sd1

- LSM9DS1: > + * - Accelerometer supported ODR [Hz]: 10, 50, 119, 238, 476, 952 > + * - Accelerometer supported full-scale [g]: +-2/+-4/+-8/+-16 > + * - Gyroscope supported ODR [Hz]: 15, 60, 119, 238, 476, 952 > + * - Gyroscope supported full-scale [dps]: +-2

Re: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

> From: Vitor Soares > Date: Thu, Jul 11, 2019 at 11:12:34 > > > Hi Lorenzo, > > > > From: Lorenzo Bianconi > > Date: Wed, Jul 10, 2019 at 20:44:05 > > > > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6D

Re: [PATCH v3 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

> For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > spi and i2c mode. > > The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to > them. Hi Vitor, just few comments inline. Regards, Lorenzo > > Signed-off-by: Vitor Soares

Re: linux-next: Fixes tag needs some work in the wireless-drivers-next tree

> Hi all, > > In commit > > d923cf6bc38a ("mt76: mt7615: fix sparse warnings: warning: cast from > restricted __le16") > > Fixes tag > > Fixes: 3ca0a6f6e9df ("mt7615: mcu: use standard signature for > mt7615_mcu_msg_send") > > has these problem(s): > > - Target SHA1 does not exist >

Re: [PATCH v2] mt76: mt7615: add support for per-chain signal strength reporting

> Fill in RX status->chain_signal to avoid empty value. > > Signed-off-by: Ryder Lee > --- > Changes since v2 - correct calculation sequence > --- > .../net/wireless/mediatek/mt76/mt7615/mac.c | 30 ++- > .../net/wireless/mediatek/mt76/mt7615/mac.h | 5 > 2 files

Re: [PATCH 2/2] mt76: mt7615: update peer's bssid when state transition changes

> Driver should update peer's bssid and bss information when > state transition changes. > > Signed-off-by: Ryder Lee > --- > .../net/wireless/mediatek/mt76/mt7615/main.c | 5 +- > .../net/wireless/mediatek/mt76/mt7615/mcu.c | 49 ++- > 2 files changed, 27 insertions(+), 27

Re: [PATCH v2 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

> On Thu, 6 Jun 2019 17:12:04 +0200 > Vitor Soares wrote: > > > For today the st_lsm6dsx driver support LSM6DSO and LSM6DSR sensor only in > > spi and i2c mode. > > > > The LSM6DSO and LSM6DSR are also i3c capable so lets give i3c support to > > them. > > > > Signed-off-by: Vitor Soares > >

Re: [PATCH v2 3/3] iio: imu: st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR

acked-by for st_lsm6dsx part in v3 Acked-by: Lorenzo Bianconi Regards, Lorenzo > Changes in v2: > Add support for LSM6DSR > Set pm_ops to st_lsm6dsx_pm_ops > > drivers/iio/imu/st_lsm6dsx/Kconfig | 8 ++- > drivers/iio/imu/st_lsm6dsx/Makefile | 1 + >

Re: [PATCH v3 1/2] mt76: mt7615: enable support for mesh

> > i tested your patch against a qca 9984 chipset using SAE and without > encryption. both did not work. the devices are connecting, but no data > connection is possible Hi Sebastian, I tested Ryder's patch using mt76x2 as mesh peer and it works fine for me. Could you please provide some more

Re: [PATCH 1/2] mt76: mt7615: enable support for mesh

> Enable NL80211_IFTYPE_MESH_POINT and add its path. > > Signed-off-by: Ryder Lee > --- > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 6 ++ > drivers/net/wireless/mediatek/mt76/mt7615/main.c | 1 + > drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 5 - > 3 files changed, 11

Re: [PATCH 3/3] iio: imu: st_lsm6dsx: Add i3c basic support

> > On Mon, 15 Apr 2019 21:19:41 +0200 > Vitor Soares wrote: > > > For today the st_lsm6dsx driver support lsm6dso sensor only in > > spi and i2c mode. > > > > The lsm6dso is also i3c capable so lets give i3c support to it. > > > > Signed-off-by: Vitor Soares > > --- > >

Re: MT76x2U crashes XHCI driver on AMD Ryzen system

> (cc: IOMMU & page_frag_alloc maintainers) > > On Tue, Jan 15, 2019 at 10:04:01AM +0100, Lorenzo Bianconi wrote: > > > On Mon, Jan 14, 2019 at 1:18 AM Lorenzo Bianconi > > > wrote: > > > > > > > > > On Sun,

Re: [PATCH v2] iio: humidity: hts221: Fix sensor reads after resume

> AV_CONF register (RH & TEMP. oversampling ratio's) and CTRL1 register > (ODR & BDU settings) values are lost after suspend. > > While the change in AV_CONF updates the sensor resolution modes > (overriding the user configuration before the device went to suspend); > loss of the contents of the

Re: [PATCH v2] iio: humidity: hts221: Fix sensor reads after resume

> AV_CONF register (RH & TEMP. oversampling ratio's) and CTRL1 register > (ODR & BDU settings) values are lost after suspend. > > While the change in AV_CONF updates the sensor resolution modes > (overriding the user configuration before the device went to suspend); > loss of the contents of the

Re: [GIT] Networking

Hi all, > On Wed, Sep 2, 2015 at 10:35 PM, David Miller wrote: >> >> Another merge window, another set of networking changes. I've heard >> rumblings that the lightweight tunnels infrastructure has been voted >> networking change of the year. > > .. and others say that the most notable feature

Re: [GIT] Networking

Hi all, > On Wed, Sep 2, 2015 at 10:35 PM, David Miller wrote: >> >> Another merge window, another set of networking changes. I've heard >> rumblings that the lightweight tunnels infrastructure has been voted >> networking change of the year. > > .. and others say that the