On 9/28/2017 3:29 PM, Lori Hikichi wrote:
> The SPDIF port cannot modify its format so a set_fmt function is not
> needed. Previously, we used a generic set_fmt for all ports and returned
> an error code for the SPDIF port. It is cleaner to not populate the
> set_fmt field.
>
The SPDIF port cannot modify its format so a set_fmt function is not
needed. Previously, we used a generic set_fmt for all ports and returned
an error code for the SPDIF port. It is cleaner to not populate the
set_fmt field.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 9
The helper function cygnus_ssp_set_custom_fsync_width() is intended
to be called from an ASoC machine driver, need to export symbol
if using modules.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound
The SPDIF port cannot modify its format so a set_fmt function is not
needed. Previously, we used a generic set_fmt for all ports and returned
an error code for the SPDIF port. It is cleaner to not populate the
set_fmt field.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 9
These modes of operation were not working properly and it is
unclear if the hardware could fully support these modes properly.
There is little to be gained by enabling these modes, therefore,
we will just remove support.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 22
This patchset contains a few small updates to the DAI driver.
Lori Hikichi (3):
ASoC: cygnus: Add EXPORT_SYMBOL for helper function
ASoC: cygnus: Remove set_fmt from SPDIF dai ops
ASoC: cygnus: Remove support for 8 bit audio and for mono
sound/soc/bcm/cygnus-ssp.c | 32
On 8/22/2017 9:07 AM, Mark Brown wrote:
> On Wed, Aug 16, 2017 at 12:39:42PM -0700, Lori Hikichi wrote:
>
>> By far the most common usage case for Cygnus is a configuration which
>> uses only the three i2s/tdm ports. In this case each port is assigned
>> a clock.
On 8/16/2017 3:59 AM, Mark Brown wrote:
> On Tue, Aug 15, 2017 at 12:29:44PM -0700, Lori Hikichi wrote:
>
>> I have put the mux assignment in DT because the assignment is a
>> static property and did not need run time programmability from the
>> machine driver.
> Wh
On 8/15/2017 10:14 AM, Mark Brown wrote:
> On Mon, Aug 14, 2017 at 03:06:50PM -0700, Lori Hikichi wrote:
>> Allow each audio port to select which clock (if any) it wants to use.
> Why is this in DT for the port and not either using standard clock
> bindings to configure the clock t
Allow the audio ports to operate at 384kHz.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 235 +++--
1 file changed, 55 insertions(+), 180 deletions(-)
diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c
index e710bb0
Add the ability to assign which of the 3 audio PLL outputs are to be
used by each port. Remove the suspend and resume handlers because the only
thing they were doing was unnecessarily maintaining the clock state.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 332
Adds copies of the frequently accessed io handles to each ports
data structure, making it more convenient to access. Also, a small
cleanup to the type names used in cygnus_pcm. None of this should
result in a functional change to the driver.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm
The helper function cygnus_ssp_set_custom_fsync_width() is intended
to be called from an ASoC machine driver, need to export symbol
if using modules.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound
The MCLK pins are now only enabled when they are in use.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/sound/soc/bcm/cygnus-ssp.c b/sound/soc/bcm/cygnus-ssp.c
index 00fd4dc..4c476ce 100644
These modes of operation were not working properly. There is little to
be gained by enabling these modes and the changes required to
potentially fix these modes would complicate the driver.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 24 +---
1 file changed
The SPDIF port cannot modify its format so a set_fmt function is not
needed. Previously, we used a generic set_fmt for all ports and returned
an error code for the SPDIF port. It is cleaner to not populate the
set_fmt field.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c | 11
Problems were found with multi-channel (4+) TDM transfers. The alignment
of the channels within the frame could shift when starting a new transfer.
In order to implement a fix the register programming sequence needed to
be revised.
Signed-off-by: Lori Hikichi
---
sound/soc/bcm/cygnus-ssp.c
This patch series contains an number of improvements and refinements
to the driver. There is also a fix for a problem when transferring
four or more channels in TDM mode.
Lori Hikichi (9):
ASoC: cygnus: Add support for 384kHz frame rates
ASoC: cygnus: Update bindings for audio clock changes
Allow each audio port to select which clock (if any) it wants to use.
Signed-off-by: Lori Hikichi
---
.../bindings/sound/brcm,cygnus-audio.txt | 70 ++
1 file changed, 45 insertions(+), 25 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/brcm
api
instead of round_rate.
Signed-off-by: Simran Rai
Signed-off-by: Lori Hikichi
---
drivers/clk/bcm/clk-iproc-pll.c | 33 +
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/drivers/clk/bcm/clk-iproc-pll.c b/drivers/clk/bcm/clk-iproc-pll.c
index
From: Lori Hikichi
The iproc plls are capable of doing small rate changes without the
need for a full reset and re-lock procedure. This feature will
allow for small tweaks to the PLL rate to occur smoothly.
Signed-off-by: Lori Hikichi
---
drivers/clk/bcm/clk-iproc-pll.c | 47
From: Lori Hikichi
There were a few fields in the iproc pll data structures that were
holding information that was not true state information.
Using stack variables is sufficient and simplifies the structure.
There are not any functional changes in this commit.
Signed-off-by: Lori Hikichi
frequencies larger
than 2^31 to be returned. Those large frequencies are interpreted as an
error code. Therefore, we are moving to the determine_rate api which
solves this problem.
Signed-off-by: Simran Rai
Signed-off-by: Lori Hikichi
---
drivers/clk/bcm/clk-cygnus.c| 25 +++
drivers/clk/bcm
This patchset enables the ability for the iproc plls to do small rate changes
without glitching the clock.
Lori Hikichi (4):
clk: iproc: Allow iproc pll to runtime calculate vco parameters
clk: iproc: Fix error in the pll post divider rate calculation
clk: iproc: Allow plls to do minor rate
On 15-04-08 11:54 AM, Mark Brown wrote:
> On Tue, Apr 07, 2015 at 07:28:40PM -0700, Lori Hikichi wrote:
>> On 15-04-06 02:58 AM, Mark Brown wrote:
>
>>> OK, then it's going to need to be a clock provider at some point - the
>>> clock will be going into exter
On 15-04-06 09:19 AM, Mark Brown wrote:
On Thu, Apr 02, 2015 at 11:47:18AM -0700, Lori Hikichi wrote:
On 15-03-30 11:42 PM, Mark Brown wrote:
+config SND_SOC_CYGNUS
+ tristate "SoC platform audio for Broadcom Cygnus chips"
+ depends on ARCH_BCM_CYGNUS || CO
On 15-04-06 02:58 AM, Mark Brown wrote:
On Fri, Apr 03, 2015 at 12:33:12PM -0700, Scott Branden wrote:
On 15-03-30 11:43 PM, Mark Brown wrote:
On Mon, Mar 30, 2015 at 08:16:22PM -0700, Scott Branden wrote:
The audio PLL is embedded in the audio block and only used
by the audio block. The a
On 15-03-31 12:26 AM, Lars-Peter Clausen wrote:
On 03/31/2015 05:16 AM, Scott Branden wrote:
[...]
+- ssp-port-id: The ssp port interface to use
+Valid value are 0, 1, 2, or 3 (for spdif)
How about using 'reg' as the property name here. It is the standard
property name for identifying or
On 15-03-30 11:42 PM, Mark Brown wrote:
On Mon, Mar 30, 2015 at 08:16:24PM -0700, Scott Branden wrote:
The CC list for this patch is pretty wide - please look at who you're
sending this to and try to send to only relevant people (for example I'm
not sure the Raspberry Pi people need to review
On 15-03-30 10:58 PM, Mark Brown wrote:
On Mon, Mar 30, 2015 at 08:16:23PM -0700, Scott Branden wrote:
+SSP Subnode properties:
+- dai-name: The name of the DAI registered with ASOC
ASoC.
Okay.
Why is this in the DT - it sounds like this is just an internal
implementation detail for Lin
30 matches
Mail list logo
