Re: [PATCH v2] Allow hwrng to initialize crng.

2018-12-13 Thread Louis Collard
On Thu, Dec 13, 2018 at 5:48 PM Ard Biesheuvel wrote: > > On Thu, 13 Dec 2018 at 10:18, Louis Collard wrote: > > > > Some systems, for example embedded systems, do not generate > > enough entropy on boot through interrupts, and boot may be blocked for > > several

Re: [RESEND PATCH] Allow hwrng to initialize crng.

2018-12-13 Thread Louis Collard
On Thu, Dec 13, 2018 at 4:51 PM Herbert Xu wrote: > > On Thu, Dec 13, 2018 at 04:40:17PM +0800, Louis Collard wrote: > > Some systems, for example embedded systems, do not generate > > enough entropy on boot through interrupts, and boot may be blocked for > > several minut

[PATCH v2] Allow hwrng to initialize crng.

2018-12-13 Thread Louis Collard
53893/ Signed-off-by: Louis Collard Acked-by: Jarkko Sakkinen --- drivers/char/hw_random/core.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index 95be7228f327..7736e1a96321 100644 --- a/drivers/char/hw_r

[RESEND PATCH] Allow hwrng to initialize crng.

2018-12-13 Thread Louis Collard
53893/ Signed-off-by: Louis Collard Acked-by: Jarkko Sakkinen --- drivers/char/hw_random/core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index 95be7228f327..99c3e4127949 100644 --- a/drivers/char/hw_r

Re: [PATCH] Allow hwrng to initialize crng.

2018-12-12 Thread Louis Collard
On Sun, Nov 18, 2018 at 4:15 AM Michael Niewöhner wrote: > > Hi Louis, > > On Wed, 2018-09-26 at 11:24 +0800, Louis Collard wrote: > > Some systems, for example embedded systems, do not generate > > enough entropy on boot through interrupts, and boot may be blocked for >

Re: [PATCH] Allow hwrng to initialize crng.

2018-10-04 Thread Louis Collard
On Wed, Sep 26, 2018 at 6:35 PM Jarkko Sakkinen wrote: > > On Wed, Sep 26, 2018 at 11:24:55AM +0800, Louis Collard wrote: > > Some systems, for example embedded systems, do not generate > > enough entropy on boot through interrupts, and boot may be blocked for > > sever

[PATCH] Allow hwrng to initialize crng.

2018-09-25 Thread Louis Collard
53893/ Signed-off-by: Louis Collard --- drivers/char/hw_random/core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index aaf9e5afaad4..47f358aa0c3d 100644 --- a/drivers/char/hw_random/core.c +++ b/drivers

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-07-03 Thread Louis Collard
On Fri, Jun 29, 2018 at 9:03 PM, David R. Bild wrote: > On Wed, Jun 27, 2018 at 1:11 AM, Louis Collard > wrote: >> >> On some systems we have seen large delays in boot time, due to >> blocking on a call to getrandom() before the entropy pool has been >> initializ

[PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality.

2018-06-29 Thread Louis Collard
Adds plumbing required for drivers based on tpm_tis to set hwrng quality. Signed-off-by: Louis Collard --- Changes since v1: - based on (hopefully!) correct git tree drivers/char/tpm/tpm_tis_core.c | 2 ++ drivers/char/tpm/tpm_tis_core.h | 1 + 2 files changed, 3 insertions(+) diff --git a

[PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality.

2018-06-29 Thread Louis Collard
Adds plumbing required for drivers based on tpm_tis to set hwrng quality. Signed-off-by: Louis Collard --- Changes since v1: - based on (hopefully!) correct git tree drivers/char/tpm/tpm_tis_core.c | 2 ++ drivers/char/tpm/tpm_tis_core.h | 1 + 2 files changed, 3 insertions(+) diff --git a

Re: [PATCH] tpm: Add module parameter for hwrng quality.

2018-06-26 Thread Louis Collard
Thanks for all the replies, let me add some background around the motivation for this change. On some systems we have seen large delays in boot time, due to blocking on a call to getrandom() before the entropy pool has been initialized. On these systems the usual sources of entropy are not suffici

Re: [PATCH] tpm: Allow tpm_tis drivers to set hwrng quality.

2018-06-26 Thread Louis Collard
Hi sorry I'm not sure I understand; I based the change on linux-next master, let me know if I should be using something else. The change is not dependent on https://patchwork.kernel.org/patch/10453893/ On Wed, Jun 27, 2018 at 1:28 PM, Louis Collard wrote: > Hi sorry I'm not sure I

[PATCH] tpm: Allow tpm_tis drivers to set hwrng quality.

2018-06-08 Thread Louis Collard
Adds plumbing required for drivers based on tpm_tis to set hwrng quality. Signed-off-by: Louis Collard --- drivers/char/tpm/tpm_tis_core.c | 2 ++ drivers/char/tpm/tpm_tis_core.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm

[PATCH] tpm: Add module parameter for hwrng quality.

2018-06-07 Thread Louis Collard
-by: Louis Collard --- drivers/char/tpm/tpm-chip.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c index 0a62c19937b6..4def49cfc634 100644 --- a/drivers/char/tpm/tpm-chip.c +++ b/drivers/char/tpm/tpm-chip.c @@ -33,6 +33,11