This doesn't matter much, but is what the standard says.
Signed-off-by: Louis Taylor
---
tools/testing/selftests/nolibc/nolibc-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c
b/tools/testing/selftests/nolibc/n
On Thu Mar 6, 2025 at 5:10 PM GMT, Thomas Weißschuh wrote:
> On 2025-03-04 07:58:15+0000, Louis Taylor wrote:
> > openat is useful to avoid needing to construct relative paths, so expose
> > a wrapper for using it directly.
> >
> > Signed-off-by: Louis Taylor
>
openat is useful to avoid needing to construct relative paths, so expose
a wrapper for using it directly.
Signed-off-by: Louis Taylor
---
tools/include/nolibc/sys.h | 25
tools/testing/selftests/nolibc/nolibc-test.c | 17 +
2 files changed, 42
It was mentioned that a new test_ function should be static, so go back
over existing functions and mark those static as well.
Signed-off-by: Louis Taylor
---
tools/testing/selftests/nolibc/nolibc-test.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools
openat is useful to avoid needing to construct relative paths, so expose
a wrapper for using it directly.
Signed-off-by: Louis Taylor
---
tools/include/nolibc/sys.h | 25
tools/testing/selftests/nolibc/nolibc-test.c | 21
2 files changed
On Mon Mar 3, 2025 at 8:49 AM GMT, Louis Taylor wrote:
> > > +}
> > > +
> > > +static __attribute__((unused))
> > > +int openat(int dirfd, const char *path, int flags, ...)
> > > +{
> > > + mode_t mode = 0;
> > >
On Sun Mar 2, 2025 at 10:24 PM GMT, Thomas Weißschuh wrote:
> Hi Louis,
>
> On 2025-03-02 20:25:23+0000, Louis Taylor wrote:
> > openat is useful to avoid needing to construct relative paths, so expose
> > a wrapper for using it directly.
>
> Can you say what you are us
openat is useful to avoid needing to construct relative paths, so expose
a wrapper for using it directly.
Signed-off-by: Louis Taylor
---
tools/include/nolibc/sys.h | 29
tools/testing/selftests/nolibc/nolibc-test.c | 22 +++
2 files changed
On Wed, Jun 19, 2019 at 11:18:44AM -0700, 'Nick Desaulniers' via Clang Built
Linux wrote:
> Add keyword support so that our mailing list gets cc'ed for clang/llvm
> patches. We're pretty active on our mailing list so far as code review.
> There are numerous Googlers like myself that are paid to su
fs.h, so use the correct format characters.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
fs/afs/dir.c | 2 +-
fs/afs/flock.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index 8a2562e3a316..4ceaec94e9c
l_type is declared as an unsigned char unconditionally in
include/linux/fs.h, so use the correct format characters.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
fs/afs/flock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/a
Commit-ID: e4a0bd0308f05c1354d28feec8439e869eae6372
Gitweb: https://git.kernel.org/tip/e4a0bd0308f05c1354d28feec8439e869eae6372
Author: Louis Taylor
AuthorDate: Sat, 2 Mar 2019 18:49:29 +
Committer: Thomas Gleixner
CommitDate: Wed, 6 Mar 2019 22:55:30 +0100
x86/boot/KASLR: Always
Commit-ID: 08c25ca37f0b37311dbac1426c356165182c4c99
Gitweb: https://git.kernel.org/tip/08c25ca37f0b37311dbac1426c356165182c4c99
Author: Louis Taylor
AuthorDate: Sat, 2 Mar 2019 18:49:29 +
Committer: Thomas Gleixner
CommitDate: Wed, 6 Mar 2019 22:53:16 +0100
x86/boot/KASLR: Always
On Wed, Mar 06, 2019 at 09:02:47PM +0100, Thomas Gleixner wrote:
> On Sat, 2 Mar 2019, Louis Taylor wrote:
>
> > When compiling with -Wreturn-type, clang warns:
> >
> > arch/x86/boot/compressed/kaslr.c:704:1: warning: control may reach end of
> > no
Commit-ID: d9a9db4625362b062ee40c9065a06307f7b5c0c9
Gitweb: https://git.kernel.org/tip/d9a9db4625362b062ee40c9065a06307f7b5c0c9
Author: Louis Taylor
AuthorDate: Sat, 2 Mar 2019 18:49:29 +
Committer: Thomas Gleixner
CommitDate: Wed, 6 Mar 2019 21:29:23 +0100
x86/boot/KASLR: Always
A few commonly used integer types were absent from this table, so add
them.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Suggested-by: Nick Desaulniers
Signed-off-by: Louis Taylor
---
Documentation/core-api/printk-formats.rst | 8
1 file changed, 8 insertions(+)
diff
b.com/ClangBuiltLinux/linux/issues/360
Signed-off-by: Louis Taylor
---
arch/x86/boot/compressed/kaslr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
index fa0332dda9f2..2e53c056ba20 100644
--- a/arch/x86
~~
This patch fixes the format strings to use the format type for int.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
drivers/i2c/busses/i2c-sis630.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-sis63
};
>
> -static inline size_t ckhdid_printf(char *pr_ckhdid, size_t size,
> -const struct wusb_ckhdid *ckhdid)
> -{
> - return scnprintf(pr_ckhdid, size,
> - "%02hx %02hx %02hx %02hx %02hx %02hx %02hx %02hx "
> - "%02hx %02hx %02hx %02hx %02hx %02hx %02hx %02hx",
> - ckhdid->data[0], ckhdid->data[1],
> - ckhdid->data[2], ckhdid->data[3],
> - ckhdid->data[4], ckhdid->data[5],
> - ckhdid->data[6], ckhdid->data[7],
> - ckhdid->data[8], ckhdid->data[9],
> - ckhdid->data[10], ckhdid->data[11],
> - ckhdid->data[12], ckhdid->data[13],
> - ckhdid->data[14], ckhdid->data[15]);
> -}
This removes the original clang warning and seems like a nice cleanup.
Reviewed-by: Louis Taylor
Cheers,
Louis
nconditionally defined, so this patch
updates the format character to the correct ones for unsigned ints.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
drivers/vfio/pci/vfio_pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
is unconditionally defined as `u8 data[16]`, so this patch
updates the format characters to the correct one for unsigned char types.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
include/linux/usb/wusb.h | 4 ++--
1 file changed, 2 insertions(+), 2 d
is unconditionally defined as `u8 data[16]`, so this patch
updates the format characters to the correct one for unsigned char types.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
include/linux/usb/wusb.h | 4 ++--
1 file changed, 2 insertions(+), 2 d
^~
The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
fs/cifs/ci
^~
The types of these arguments are unconditionally defined, so this patch
updates the format character to the correct ones for ints and unsigned
ints.
Link: https://github.com/ClangBuiltLinux/linux/issues/378
Signed-off-by: Louis Taylor
---
fs/cifs/cifs
r, hdev->product);
^
./include/linux/hid.h:1170:48: note: expanded from macro 'dbg_hid'
printk(KERN_DEBUG "%s: " format, __FILE__, ##arg); \
~~ ^~~
4 warnings generated.
This patch fixes the format strings to use the
r, hdev->product);
^
./include/linux/hid.h:1170:48: note: expanded from macro 'dbg_hid'
printk(KERN_DEBUG "%s: " format, __FILE__, ##arg); \
~~ ^~~
4 warnings generated.
This patch fixes the format strings to use the
26 matches
Mail list logo