[PATCH v9 3/7] usb: mux: add driver for Intel gpio controlled port mux

2016-05-29 Thread Lu Baolu
by Chanwoo Choi] Signed-off-by: David Cohen <david.a.co...@linux.intel.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> Reviewed-by: Chanwoo Choi <cw00.c...@samsun

[PATCH v9 1/7] regulator: fixed: add support for ACPI interface

2016-05-29 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/regulator/fixed.

[PATCH v9 3/7] usb: mux: add driver for Intel gpio controlled port mux

2016-05-29 Thread Lu Baolu
by Chanwoo Choi] Signed-off-by: David Cohen Signed-off-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi Reviewed-by: Chanwoo Choi --- drivers/usb/mux/Kconfig | 13 +++ drivers/usb/mux/Makefile | 1 + drivers/usb/mux/portmux-intel-gpio.c | 183

[PATCH v9 1/7] regulator: fixed: add support for ACPI interface

2016-05-29 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu --- drivers/regulator/fixed.c | 46 ++ 1 file changed

[PATCH v9 0/7] usb: add support for Intel dual role port mux

2016-05-29 Thread Lu Baolu
mux could be found in Cherry Trail and Broxton devices. All patches have been verified to work on Intel's BayTrail, CherryTrail, and Broxton P platforms. Lu Baolu (7): regulator: fixed: add support for ACPI interface usb: mux: add generic code for dual role port mux usb: mux: add driver

[PATCH v9 2/7] usb: mux: add generic code for dual role port mux

2016-05-29 Thread Lu Baolu
that users are able to control the port role from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could also be leveraged for those archs. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <hei

[PATCH v9 4/7] usb: mux: add driver for Intel drcfg controlled port mux

2016-05-29 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Lu Baolu

[PATCH v9 0/7] usb: add support for Intel dual role port mux

2016-05-29 Thread Lu Baolu
mux could be found in Cherry Trail and Broxton devices. All patches have been verified to work on Intel's BayTrail, CherryTrail, and Broxton P platforms. Lu Baolu (7): regulator: fixed: add support for ACPI interface usb: mux: add generic code for dual role port mux usb: mux: add driver

[PATCH v9 2/7] usb: mux: add generic code for dual role port mux

2016-05-29 Thread Lu Baolu
that users are able to control the port role from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could also be leveraged for those archs. Signed-off-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi

[PATCH v9 4/7] usb: mux: add driver for Intel drcfg controlled port mux

2016-05-29 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus Signed-off-by: Lu Baolu Signed-off-by: Wu Hao Reviewed-by: Felipe

Re: [PATCH v8 2/7] usb: mux: add generic code for dual role port mux

2016-05-27 Thread Lu Baolu
x could >> > be retrieved with portmux_lookup_by_name() and controlled via >> > portmux_switch(). >> > >> > Is this helpful? > It works for me, and we can improve it later if needed. Okay, thanks. Best regards, Lu Baolu

Re: [PATCH v8 2/7] usb: mux: add generic code for dual role port mux

2016-05-27 Thread Lu Baolu
x could >> > be retrieved with portmux_lookup_by_name() and controlled via >> > portmux_switch(). >> > >> > Is this helpful? > It works for me, and we can improve it later if needed. Okay, thanks. Best regards, Lu Baolu

Re: [PATCH v8 2/7] usb: mux: add generic code for dual role port mux

2016-05-25 Thread Lu Baolu
void portmux_unregister(struct portmux_dev *pdev); I will add below ones. struct portmux_dev *portmux_lookup_by_name(char *name); int portmux_switch(struct portmux_dev *pdev, enum port_role); The normal usage mode is 1) the mux device is registered as soon as a mux is detected with portmux_register(); 2) In components like USB PHY or changer drivers, the mux could be retrieved with portmux_lookup_by_name() and controlled via portmux_switch(). Is this helpful? Best regards, Lu Baolu

Re: [PATCH v8 2/7] usb: mux: add generic code for dual role port mux

2016-05-25 Thread Lu Baolu
void portmux_unregister(struct portmux_dev *pdev); I will add below ones. struct portmux_dev *portmux_lookup_by_name(char *name); int portmux_switch(struct portmux_dev *pdev, enum port_role); The normal usage mode is 1) the mux device is registered as soon as a mux is detected with portmux_register(); 2) In components like USB PHY or changer drivers, the mux could be retrieved with portmux_lookup_by_name() and controlled via portmux_switch(). Is this helpful? Best regards, Lu Baolu

Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface

2016-05-15 Thread Lu Baolu
Hi, On 05/13/2016 07:17 PM, Mark Brown wrote: > On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote: > >> +gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS); >> +if (IS_ERR(gpiod)) >> +return ERR_PTR(-ENODEV); >> +config->

Re: [PATCH v8 1/7] regulator: fixed: add support for ACPI interface

2016-05-15 Thread Lu Baolu
Hi, On 05/13/2016 07:17 PM, Mark Brown wrote: > On Thu, May 05, 2016 at 01:32:57PM +0800, Lu Baolu wrote: > >> +gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS); >> +if (IS_ERR(gpiod)) >> +return ERR_PTR(-ENODEV); >> +config->

[PATCH v8 0/7] usb: add support for Intel dual role port mux

2016-05-04 Thread Lu Baolu
series includes a driver for GPIO USB mux. (3) Drivers for USB port mux controlled through memory mapped registers and the logic to create the mux device. This type of dual role port mux could be found in Cherry Trail and Broxton devices. Lu Baolu (7): regulator: fixed: add support

[PATCH v8 0/7] usb: add support for Intel dual role port mux

2016-05-04 Thread Lu Baolu
series includes a driver for GPIO USB mux. (3) Drivers for USB port mux controlled through memory mapped registers and the logic to create the mux device. This type of dual role port mux could be found in Cherry Trail and Broxton devices. Lu Baolu (7): regulator: fixed: add support

[PATCH v8 2/7] usb: mux: add generic code for dual role port mux

2016-05-04 Thread Lu Baolu
control the port mux from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could be leveraged for those archs as well. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <hei

[PATCH v8 2/7] usb: mux: add generic code for dual role port mux

2016-05-04 Thread Lu Baolu
control the port mux from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could be leveraged for those archs as well. Signed-off-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi Reviewed-by: Chanwoo Choi

[PATCH v8 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-05-04 Thread Lu Baolu
per platform_no_drv_owner.cocci] Suggested-by: David Cohen <david.a.co...@linux.intel.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/mfd/Kconfig| 8 + drivers/mfd/Makefile | 1 + drivers/mfd/i

[PATCH v8 3/7] usb: mux: add driver for Intel gpio controlled port mux

2016-05-04 Thread Lu Baolu
.co...@linux.intel.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/usb/mux/Kconfig | 11 +++ drivers/usb/mux/Makefile

[PATCH v8 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-05-04 Thread Lu Baolu
per platform_no_drv_owner.cocci] Suggested-by: David Cohen Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi --- drivers/mfd/Kconfig| 8 + drivers/mfd/Makefile | 1 + drivers/mfd/intel-vuport.c | 89 ++ 3 files changed, 98

[PATCH v8 3/7] usb: mux: add driver for Intel gpio controlled port mux

2016-05-04 Thread Lu Baolu
-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi --- drivers/usb/mux/Kconfig | 11 +++ drivers/usb/mux/Makefile | 1 + drivers/usb/mux/portmux-intel-gpio.c | 149 +++ 3 files changed, 161 insertions(+) create mode

[PATCH v8 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-05-04 Thread Lu Baolu
mux switch. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/usb/host/pci-quirks.c| 45 ++-- drivers/usb/host/xhci-ext-caps.h | 2 ++ 2 files changed, 45 insertions(+), 2 deletions(-)

[PATCH v8 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-05-04 Thread Lu Baolu
mux switch. Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi --- drivers/usb/host/pci-quirks.c| 45 ++-- drivers/usb/host/xhci-ext-caps.h | 2 ++ 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb

[PATCH v8 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-05-04 Thread Lu Baolu
Add a maintainer entry for Intel USB dual role mux drivers and add myself as a maintainer. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d5b4be..6ab9e02 100644 --- a/MAINT

[PATCH v8 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-05-04 Thread Lu Baolu
Add a maintainer entry for Intel USB dual role mux drivers and add myself as a maintainer. Signed-off-by: Lu Baolu --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d5b4be..6ab9e02 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH v8 4/7] usb: mux: add driver for Intel drcfg controlled port mux

2016-05-04 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Lu Baolu

[PATCH v8 1/7] regulator: fixed: add support for ACPI interface

2016-05-04 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/regulator/fixed.

[PATCH v8 4/7] usb: mux: add driver for Intel drcfg controlled port mux

2016-05-04 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus Signed-off-by: Lu Baolu Signed-off-by: Wu Hao Reviewed-by: Felipe

[PATCH v8 1/7] regulator: fixed: add support for ACPI interface

2016-05-04 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu --- drivers/regulator/fixed.c | 46 ++ 1 file changed

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-03 Thread Lu Baolu
Hi, On 05/03/2016 07:49 PM, Mark Brown wrote: > On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: >> On 05/02/2016 07:00 PM, Mark Brown wrote: >>> On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: >>>> + gpiod = gpiod_get(dev, "vbus_en"

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-03 Thread Lu Baolu
Hi, On 05/03/2016 07:49 PM, Mark Brown wrote: > On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: >> On 05/02/2016 07:00 PM, Mark Brown wrote: >>> On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: >>>> + gpiod = gpiod_get(dev, "vbus_en"

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-02 Thread Lu Baolu
Hi, On 05/02/2016 07:00 PM, Mark Brown wrote: > On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > >> +gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); >> +if (IS_ERR(gpiod)) >> +return PTR_ERR(gpiod); > This is clearly an inappro

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-02 Thread Lu Baolu
Hi, On 05/02/2016 07:00 PM, Mark Brown wrote: > On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: > >> +gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); >> +if (IS_ERR(gpiod)) >> +return PTR_ERR(gpiod); > This is clearly an inappro

Re: [PATCH v7 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-05-01 Thread Lu Baolu
Hi, On 04/29/2016 02:26 PM, Lu Baolu wrote: > Add a maintainer entry for Intel USB dual role mux drivers and > add myself as a maintainer. > > Signed-off-by: Lu Baolu <baolu...@linux.intel.com> > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) >

Re: [PATCH v7 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-05-01 Thread Lu Baolu
Hi, On 04/29/2016 02:26 PM, Lu Baolu wrote: > Add a maintainer entry for Intel USB dual role mux drivers and > add myself as a maintainer. > > Signed-off-by: Lu Baolu > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/MAINTA

[PATCH v7 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-04-29 Thread Lu Baolu
mux switch. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/usb/host/pci-quirks.c| 45 ++-- drivers/usb/host/xhci-ext-caps.h | 2 ++ 2 files changed, 45 insertions(+), 2 deletions(-)

[PATCH v7 4/7] usb: mux: add driver for Intel drcfg controlled port mux

2016-04-29 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Lu Baolu

[PATCH v7 0/7] usb: add support for Intel dual role port mux

2016-04-29 Thread Lu Baolu
series includes a driver for GPIO USB mux. (3) Drivers for USB port mux controlled through memory mapped registers and the logic to create the mux device. This type of dual role port mux could be found in Cherry Trail and Broxton devices. Lu Baolu (7): regulator: fixed: add support

[PATCH v7 6/7] usb: pci-quirks: add Intel USB drcfg mux device

2016-04-29 Thread Lu Baolu
mux switch. Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi --- drivers/usb/host/pci-quirks.c| 45 ++-- drivers/usb/host/xhci-ext-caps.h | 2 ++ 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb

[PATCH v7 4/7] usb: mux: add driver for Intel drcfg controlled port mux

2016-04-29 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus Signed-off-by: Lu Baolu Signed-off-by: Wu Hao Reviewed-by: Felipe

[PATCH v7 0/7] usb: add support for Intel dual role port mux

2016-04-29 Thread Lu Baolu
series includes a driver for GPIO USB mux. (3) Drivers for USB port mux controlled through memory mapped registers and the logic to create the mux device. This type of dual role port mux could be found in Cherry Trail and Broxton devices. Lu Baolu (7): regulator: fixed: add support

[PATCH v7 3/7] usb: mux: add driver for Intel gpio controlled port mux

2016-04-29 Thread Lu Baolu
.co...@linux.intel.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/usb/mux/Kconfig | 11 +++ drivers/usb/mux/Makefile

[PATCH v7 3/7] usb: mux: add driver for Intel gpio controlled port mux

2016-04-29 Thread Lu Baolu
-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi --- drivers/usb/mux/Kconfig | 11 +++ drivers/usb/mux/Makefile | 1 + drivers/usb/mux/portmux-intel-gpio.c | 149 +++ 3 files changed, 161 insertions(+) create mode

[PATCH v7 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-04-29 Thread Lu Baolu
Add a maintainer entry for Intel USB dual role mux drivers and add myself as a maintainer. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d5b4be..682c8a5 100644 --- a/MAINT

[PATCH v7 2/7] usb: mux: add generic code for dual role port mux

2016-04-29 Thread Lu Baolu
control the port mux from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could be leveraged for those archs as well. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <hei

[PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-04-29 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/regulator/fixed.

[PATCH v7 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-04-29 Thread Lu Baolu
per platform_no_drv_owner.cocci] Suggested-by: David Cohen <david.a.co...@linux.intel.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/mfd/Kconfig| 8 + drivers/mfd/Makefile | 1 + drivers/mfd/i

[PATCH v7 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-04-29 Thread Lu Baolu
Add a maintainer entry for Intel USB dual role mux drivers and add myself as a maintainer. Signed-off-by: Lu Baolu --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d5b4be..682c8a5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH v7 2/7] usb: mux: add generic code for dual role port mux

2016-04-29 Thread Lu Baolu
control the port mux from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could be leveraged for those archs as well. Signed-off-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi Reviewed-by: Chanwoo Choi

[PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-04-29 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu --- drivers/regulator/fixed.c | 46 ++ 1 file changed

[PATCH v7 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-04-29 Thread Lu Baolu
per platform_no_drv_owner.cocci] Suggested-by: David Cohen Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi --- drivers/mfd/Kconfig| 8 + drivers/mfd/Makefile | 1 + drivers/mfd/intel-vuport.c | 89 ++ 3 files changed, 98

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-28 Thread Lu Baolu
Hi, On 04/29/2016 01:15 AM, Mark Brown wrote: > On Thu, Apr 28, 2016 at 01:55:35PM +0800, Lu Baolu wrote: > >> How about below code? >> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); >> + if (IS_ERR(gpiod)) >> + return PTR_

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-28 Thread Lu Baolu
Hi, On 04/29/2016 01:15 AM, Mark Brown wrote: > On Thu, Apr 28, 2016 at 01:55:35PM +0800, Lu Baolu wrote: > >> How about below code? >> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); >> + if (IS_ERR(gpiod)) >> + return PTR_

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-27 Thread Lu Baolu
Hi, On 04/27/2016 08:33 PM, Mark Brown wrote: > On Wed, Apr 27, 2016 at 09:54:10AM +0800, Lu Baolu wrote: > >> Please refer to Documentation/acpi/gpio-properties.txt. > That's not visibly what your driver is doing, that is also recommending > using a static name which is what I'

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-27 Thread Lu Baolu
Hi, On 04/27/2016 08:33 PM, Mark Brown wrote: > On Wed, Apr 27, 2016 at 09:54:10AM +0800, Lu Baolu wrote: > >> Please refer to Documentation/acpi/gpio-properties.txt. > That's not visibly what your driver is doing, that is also recommending > using a static name which is what I'

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-26 Thread Lu Baolu
Hi, On 04/26/2016 06:23 PM, Mark Brown wrote: > On Tue, Apr 26, 2016 at 10:24:56AM +0800, Lu Baolu wrote: > >> The GPIO name might be different in different use cases. For my case, >> it is "vbus_en", but other cases should use the different name. >> On ACPI co

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-26 Thread Lu Baolu
Hi, On 04/26/2016 06:23 PM, Mark Brown wrote: > On Tue, Apr 26, 2016 at 10:24:56AM +0800, Lu Baolu wrote: > >> The GPIO name might be different in different use cases. For my case, >> it is "vbus_en", but other cases should use the different name. >> On ACPI co

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-25 Thread Lu Baolu
Hi Mark, On 04/26/2016 01:30 AM, Mark Brown wrote: > On Mon, Apr 25, 2016 at 04:04:50PM +0800, Lu Baolu wrote: > >> +ret = device_property_read_string(dev, "gpio-name", _name); >> +if (!ret) { >> +gpiod = gpiod_get(dev, gpio_name, GPIOD_ASIS);

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-25 Thread Lu Baolu
Hi Mark, On 04/26/2016 01:30 AM, Mark Brown wrote: > On Mon, Apr 25, 2016 at 04:04:50PM +0800, Lu Baolu wrote: > >> +ret = device_property_read_string(dev, "gpio-name", _name); >> +if (!ret) { >> +gpiod = gpiod_get(dev, gpio_name, GPIOD_ASIS);

Re: [PATCH v6 03/10] regulator: fixed: add device binding for platform device

2016-04-25 Thread Lu Baolu
Hi Mark, On 04/26/2016 12:40 AM, Mark Brown wrote: > On Mon, Apr 25, 2016 at 04:04:49PM +0800, Lu Baolu wrote: > >> This is needed to handle the GPIO connected USB vcc pin found on >> Intel Baytrail devices. > In what way is this needed? The we defualt to using the driver

Re: [PATCH v6 03/10] regulator: fixed: add device binding for platform device

2016-04-25 Thread Lu Baolu
Hi Mark, On 04/26/2016 12:40 AM, Mark Brown wrote: > On Mon, Apr 25, 2016 at 04:04:49PM +0800, Lu Baolu wrote: > >> This is needed to handle the GPIO connected USB vcc pin found on >> Intel Baytrail devices. > In what way is this needed? The we defualt to using the driver

Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

2016-04-25 Thread Lu Baolu
Hi, On 04/26/2016 07:51 AM, Chanwoo Choi wrote: > Hi Lu, > > On 2016년 04월 25일 17:04, Lu Baolu wrote: >> GPIO resource could be retrieved through APCI as well. >> >> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> >> Reviewed-by: Felipe Balbi <ba...@ker

Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

2016-04-25 Thread Lu Baolu
Hi, On 04/26/2016 07:51 AM, Chanwoo Choi wrote: > Hi Lu, > > On 2016년 04월 25일 17:04, Lu Baolu wrote: >> GPIO resource could be retrieved through APCI as well. >> >> Signed-off-by: Lu Baolu >> Reviewed-by: Felipe Balbi >> Acked-by: Chanwoo Choi >>

Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device

2016-04-25 Thread Lu Baolu
Hi, On 04/26/2016 07:51 AM, Chanwoo Choi wrote: > Hi Lu, > > On 2016년 04월 25일 17:04, Lu Baolu wrote: >> This is needed to handle the GPIO connected USB ID pin found on >> Intel Baytrail devices. >> >> Signed-off-by: Lu Baolu <baolu...@linux.intel.c

Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device

2016-04-25 Thread Lu Baolu
Hi, On 04/26/2016 07:51 AM, Chanwoo Choi wrote: > Hi Lu, > > On 2016년 04월 25일 17:04, Lu Baolu wrote: >> This is needed to handle the GPIO connected USB ID pin found on >> Intel Baytrail devices. >> >> Signed-off-by: Lu Baolu >> Reviewed-by:

[PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device

2016-04-25 Thread Lu Baolu
This is needed to handle the GPIO connected USB ID pin found on Intel Baytrail devices. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- drivers/extcon/extcon-usb-gpio.c | 7 +

[PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device

2016-04-25 Thread Lu Baolu
This is needed to handle the GPIO connected USB ID pin found on Intel Baytrail devices. Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi Acked-by: Chanwoo Choi --- drivers/extcon/extcon-usb-gpio.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/extcon/extcon-usb-gpio.c b

[PATCH v6 03/10] regulator: fixed: add device binding for platform device

2016-04-25 Thread Lu Baolu
This is needed to handle the GPIO connected USB vcc pin found on Intel Baytrail devices. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/regulator/fixed.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index f

[PATCH v6 03/10] regulator: fixed: add device binding for platform device

2016-04-25 Thread Lu Baolu
This is needed to handle the GPIO connected USB vcc pin found on Intel Baytrail devices. Signed-off-by: Lu Baolu --- drivers/regulator/fixed.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index ff62d69..e6f376f 100644

[PATCH v6 00/10] usb: add support for Intel dual role port mux

2016-04-25 Thread Lu Baolu
series includes a driver for GPIO USB mux. (3) Drivers for USB port mux controlled through memory mapped registers and the logic to create the mux device. This type of dual role port mux could be found in Cherry Trail and Broxton devices. Lu Baolu (10): extcon: usb-gpio: add device binding

[PATCH v6 00/10] usb: add support for Intel dual role port mux

2016-04-25 Thread Lu Baolu
series includes a driver for GPIO USB mux. (3) Drivers for USB port mux controlled through memory mapped registers and the logic to create the mux device. This type of dual role port mux could be found in Cherry Trail and Broxton devices. Lu Baolu (10): extcon: usb-gpio: add device binding

[PATCH v6 05/10] usb: mux: add generic code for dual role port mux

2016-04-25 Thread Lu Baolu
control the port mux from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could be leveraged for those archs as well. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <hei

[PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-25 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/regulator/fixed.

[PATCH v6 05/10] usb: mux: add generic code for dual role port mux

2016-04-25 Thread Lu Baolu
control the port mux from user space. Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could be leveraged for those archs as well. Signed-off-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi Reviewed-by: Chanwoo Choi

[PATCH v6 04/10] regulator: fixed: add support for ACPI interface

2016-04-25 Thread Lu Baolu
Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus. Signed-off-by: Lu Baolu --- drivers/regulator/fixed.c | 48 +++ 1 file

[PATCH v6 07/10] usb: mux: add driver for Intel drcfg controlled port mux

2016-04-25 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Signed-off-by: Lu Baolu

[PATCH v6 07/10] usb: mux: add driver for Intel drcfg controlled port mux

2016-04-25 Thread Lu Baolu
Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register. Signed-off-by: Heikki Krogerus Signed-off-by: Lu Baolu Signed-off-by: Wu Hao Reviewed-by: Felipe

[PATCH v6 10/10] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-04-25 Thread Lu Baolu
Add a maintainer entry for Intel USB dual role mux drivers and add myself as a maintainer. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 03e00c7..e2609e6 100644 --- a/MAINT

[PATCH v6 09/10] usb: pci-quirks: add Intel USB drcfg mux device

2016-04-25 Thread Lu Baolu
mux switch. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/usb/host/pci-quirks.c| 45 ++-- drivers/usb/host/xhci-ext-caps.h | 2 ++ 2 files changed, 45 insertions(+), 2 deletions(-)

[PATCH v6 10/10] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

2016-04-25 Thread Lu Baolu
Add a maintainer entry for Intel USB dual role mux drivers and add myself as a maintainer. Signed-off-by: Lu Baolu --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 03e00c7..e2609e6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH v6 09/10] usb: pci-quirks: add Intel USB drcfg mux device

2016-04-25 Thread Lu Baolu
mux switch. Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi --- drivers/usb/host/pci-quirks.c| 45 ++-- drivers/usb/host/xhci-ext-caps.h | 2 ++ 2 files changed, 45 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb

[PATCH v6 06/10] usb: mux: add driver for Intel gpio controlled port mux

2016-04-25 Thread Lu Baolu
.co...@linux.intel.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.kroge...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/usb/mux/Kconfig | 11 +++ drivers/usb/mux/Makefile

[PATCH v6 08/10] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-04-25 Thread Lu Baolu
per platform_no_drv_owner.cocci] Suggested-by: David Cohen <david.a.co...@linux.intel.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> --- drivers/mfd/Kconfig| 8 + drivers/mfd/Makefile | 1 + drivers/mfd/i

[PATCH v6 06/10] usb: mux: add driver for Intel gpio controlled port mux

2016-04-25 Thread Lu Baolu
-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed-by: Felipe Balbi --- drivers/usb/mux/Kconfig | 11 +++ drivers/usb/mux/Makefile | 1 + drivers/usb/mux/portmux-intel-gpio.c | 149 +++ 3 files changed, 161 insertions(+) create mode

[PATCH v6 08/10] mfd: intel_vuport: Add Intel virtual USB port MFD Driver

2016-04-25 Thread Lu Baolu
per platform_no_drv_owner.cocci] Suggested-by: David Cohen Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi --- drivers/mfd/Kconfig| 8 + drivers/mfd/Makefile | 1 + drivers/mfd/intel-vuport.c | 90 ++ 3 files changed, 99

[PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

2016-04-25 Thread Lu Baolu
GPIO resource could be retrieved through APCI as well. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Reviewed-by: Felipe Balbi <ba...@kernel.org> Acked-by: Chanwoo Choi <cw00.c...@samsung.com> --- drivers/extcon/extcon-usb-gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

2016-04-25 Thread Lu Baolu
GPIO resource could be retrieved through APCI as well. Signed-off-by: Lu Baolu Reviewed-by: Felipe Balbi Acked-by: Chanwoo Choi --- drivers/extcon/extcon-usb-gpio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Lu Baolu
Hi, On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: >>>> +struct intel_mux_dev

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-06 Thread Lu Baolu
Hi, On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: >>>> +struct intel_mux_dev

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-05 Thread Lu Baolu
Hi, On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform >>> b/Documentati

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

2016-04-05 Thread Lu Baolu
Hi, On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform >>> b/Documentati

[PATCH 1/2] usb: xhci: fix wild pointers in xhci_mem_cleanup

2016-03-25 Thread Lu Baolu
This patch fixes some wild pointers produced by xhci_mem_cleanup. These wild pointers will cause system crash if xhci_mem_cleanup() is called twice. Reported-and-tested-by: Pengcheng Li <lpc...@hisilicon.com> Signed-off-by: Lu Baolu <baolu...@linux.intel.com> Cc: sta...@vge

[PATCH 2/2] usb: xhci: remove hardcoded gfp_t in xhci_mem_init

2016-03-25 Thread Lu Baolu
xhci_mem_init() should use @flags, instead of hardcode, for DMA memory allocation. Signed-off-by: Lu Baolu <baolu...@linux.intel.com> --- drivers/usb/host/xhci-mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/hos

[PATCH 1/2] usb: xhci: fix wild pointers in xhci_mem_cleanup

2016-03-25 Thread Lu Baolu
This patch fixes some wild pointers produced by xhci_mem_cleanup. These wild pointers will cause system crash if xhci_mem_cleanup() is called twice. Reported-and-tested-by: Pengcheng Li Signed-off-by: Lu Baolu Cc: sta...@vger.kernel.org --- drivers/usb/host/xhci-mem.c | 6 ++ 1 file

[PATCH 2/2] usb: xhci: remove hardcoded gfp_t in xhci_mem_init

2016-03-25 Thread Lu Baolu
xhci_mem_init() should use @flags, instead of hardcode, for DMA memory allocation. Signed-off-by: Lu Baolu --- drivers/usb/host/xhci-mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index bad0d1f..7c2f884

[PATCH v4 4/7] usb: mux: add driver for Intel gpio controlled port mux

2016-03-19 Thread Lu Baolu
In some Intel platforms, a single usb port is shared between USB host and device controller. The shared port is under control of GPIO pins. This patch adds the support for USB GPIO controlled port mux. Signed-off-by: David Cohen <david.a.co...@linux.intel.com> Signed-off-by: Lu Baolu

[PATCH v4 4/7] usb: mux: add driver for Intel gpio controlled port mux

2016-03-19 Thread Lu Baolu
In some Intel platforms, a single usb port is shared between USB host and device controller. The shared port is under control of GPIO pins. This patch adds the support for USB GPIO controlled port mux. Signed-off-by: David Cohen Signed-off-by: Lu Baolu Reviewed-by: Heikki Krogerus Reviewed

<    8   9   10   11   12   13   14   15   16   17   >