Re: [PATCH v6 2/4] leds: Add driver for Qualcomm LPG

2020-10-22 Thread Luca Weiss
ers/leds/Makefile|1 + > drivers/leds/leds-qcom-lpg.c | 1190 ++ > 3 files changed, 1200 insertions(+) > create mode 100644 drivers/leds/leds-qcom-lpg.c Tested on msm8974 (pm8941) on the Fairphone 2, works great there! Tested-by: Luca Weiss Regards Luca

Re: [PATCH v4 2/4] leds: Add driver for Qualcomm LPG

2020-10-07 Thread Luca Weiss
Hi Bjorn, On Mon Sep 28, 2020 at 8:15 PM, Bjorn Andersson wrote: > The Light Pulse Generator (LPG) is a PWM-block found in a wide range of > PMICs from Qualcomm. It can operate on fixed parameters or based on a > lookup-table, altering the duty cycle over time - which provides the > means for

[PATCH] drm/msm/adreno: fix probe without iommu

2020-09-11 Thread Luca Weiss
The function iommu_domain_alloc returns NULL on platforms without IOMMU such as msm8974. This resulted in PTR_ERR(-ENODEV) being assigned to gpu->aspace so the correct code path wasn't taken. Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization") Signed-off-b

Re: [PATCH] arm64: dts: sun50i-pinephone: add led flash

2020-07-29 Thread Luca Weiss
Hi Maxime, On Mittwoch, 29. Juli 2020 14:34:44 CEST Maxime Ripard wrote: > Hi! > > On Sat, Jul 25, 2020 at 01:08:12PM +0200, Luca Weiss wrote: > > All revisions of the PinePhone have an SGM3140 LED flash. The gpios were > > swapped on v1.0 of the board but this was fix

[PATCH] arm64: dts: sun50i-pinephone: add led flash

2020-07-25 Thread Luca Weiss
All revisions of the PinePhone have an SGM3140 LED flash. The gpios were swapped on v1.0 of the board but this was fixed in later revisions. Signed-off-by: Luca Weiss --- .../boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 5 + .../boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 5

[PATCH 2/2] ARM: dts: msm8974-FP2: Increase load on l20 for sdhci

2019-09-26 Thread Luca Weiss
execution failed: -5 [ 137.569832] mmcblk0: error -110 requesting status [ 137.593558] mmcblk0: recovery failed! With this patch, there are no more sdhci errors and booting works fine. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 2 ++ 1 file changed, 2

[PATCH 1/2] ARM: dts: msm8974-FP2: Drop unused card-detect pin

2019-09-26 Thread Luca Weiss
The gpio is not used for SD card detection on the FP2. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974

Re: [PATCH 00/15] thermal: qcom: tsens: Add interrupt support

2019-07-29 Thread Luca Weiss
On Montag, 29. Juli 2019 11:07:35 CEST Brian Masney wrote: > On Sat, Jul 27, 2019 at 12:58:54PM +0530, Amit Kucheria wrote: > > On Fri, Jul 26, 2019 at 4:59 PM Brian Masney wrote: > > > On Fri, Jul 26, 2019 at 04:40:16PM +0530, Amit Kucheria wrote: > > > > How well does cpufreq work on 8974? I

Re: [PATCH 12/15] arm64: dts: msm8974: thermal: Add interrupt support

2019-07-29 Thread Luca Weiss
On Freitag, 26. Juli 2019 00:18:47 CEST Amit Kucheria wrote: > Register upper-lower interrupt for the tsens controller. > > Signed-off-by: Amit Kucheria > --- > Cc: masn...@onstation.org > > arch/arm/boot/dts/qcom-msm8974.dtsi | 36 +++-- > 1 file changed, 19

[PATCH v2] ARM: dts: msm8974-FP2: add reboot-mode node

2019-07-13 Thread Luca Weiss
This enables userspace to signal the bootloader to go into the bootloader or recovery mode. The magic values can be found in both the downstream kernel and the LK kernel (bootloader). Reviewed-by: Brian Masney Signed-off-by: Luca Weiss --- Changes v1 -> v2: - Move the majority of the n

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-07-13 Thread Luca Weiss
Hi Brian, how about something like that (formatting is surely broken because I'm not sending this with git-send-email^^)? I'd says this should be work fine with all devices as all modes are defined in the device-specific dts but the reg and offset values are in the board dts. Should I also add

[PATCH v2] ASoC: sunxi: sun50i-codec-analog: Add earpiece

2019-07-03 Thread Luca Weiss
This adds the necessary registers and audio routes to play audio using the Earpiece, that's supported on the A64. Signed-off-by: Luca Weiss --- Changes v1 -> v2: * Make the earpiece enable register a DAPM widget * Adjust the audio routes to include the new Earpiece Amp widget * Left/Right Ana

[PATCH 3/3] iio: light: stk3310: Add device tree support

2019-07-03 Thread Luca Weiss
Add device tree support for the stk33xx family of ambient light sensors. Tested-by: Martijn Braam Signed-off-by: Luca Weiss --- drivers/iio/light/stk3310.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index b955183edfe8

[PATCH 2/3] dt-bindings: iio: light: add stk33xx

2019-07-03 Thread Luca Weiss
Add binding documentation for the stk33xx family of ambient light sensors. Signed-off-by: Luca Weiss --- .../bindings/iio/light/stk33xx.yaml | 49 +++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/stk33xx.yaml diff

[PATCH 1/3] dt-bindings: Add vendor prefix for sensortek

2019-07-03 Thread Luca Weiss
Sensortek Technology Corp. produces Proximity Sensors with ALS and Accelerometers. Signed-off-by: Luca Weiss --- This patch series depends on "iio: light: stk3310: Add support for stk3335", that's curerntly in linux-next. Documentation/devicetree/bindings/vendor-prefixes.yaml | 2

[PATCH] ASoC: sunxi: sun50i-codec-analog: Add earpiece

2019-07-02 Thread Luca Weiss
This adds the necessary registers and audio routes to play audio using the Earpiece, that's supported on the A64. Signed-off-by: Luca Weiss --- So, first of all: This is my first audio patch and I hope I didn't make too many mistakes :) , especially with the routes at the bottom of the patch

Re: [PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-21 Thread Luca Weiss
On Freitag, 21. Juni 2019 02:01:22 CEST you wrote: > I think that it makes sense to put this snippet in qcom-msm8974.dtsi > with a status of disabled, and then enable it in > qcom-msm8974-fairphone-fp2.dts like so: > > imem@fe805000 { > status = "ok"; > }; Do you want me to put the whole

[PATCH] media: ov5640: Add support for flash and lens devices

2019-06-21 Thread Luca Weiss
Parse async sub-devices related to the sensor by switching the async sub-device registration function. Signed-off-by: Luca Weiss --- drivers/media/i2c/ov5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index

[PATCH] ARM: dts: msm8974-FP2: add reboot-mode node

2019-06-20 Thread Luca Weiss
This enables userspace to signal the bootloader to go into the bootloader or recovery mode. The magic values can be found in both the downstream kernel and the LK kernel (bootloader). Signed-off-by: Luca Weiss --- Sidenote: Why are there no userspace tools to be found that support this? Anyways

[PATCH v2 1/2] dt-bindings: input: sun4i-lradc-keys: Add A64 compatible

2019-06-04 Thread Luca Weiss
Add the A64 compatible with a fallback to the A83T compatible. Signed-off-by: Luca Weiss --- Changes from v1: - New patch. Document new compatible string. Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v2 2/2] arm64: dts: allwinner: a64: Add lradc node

2019-06-04 Thread Luca Weiss
Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss --- Changes since v1: - Use a a64 compatible with a fallback to the a83t one (the A64 also uses a 3/4 voltage divider, as is the case with the A83T) - Correct the reg property (size 0x100 => 0x400) arch/arm64/boot/

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-04 Thread Luca Weiss
devicetree patch was squashed into the driver patch by the maintainer while merging. I'll fix this up asap. Luca On Dienstag, 4. Juni 2019 16:59:07 CEST Maxime Ripard wrote: > Hi Luca, > > On Tue, Jun 04, 2019 at 04:42:53PM +0200, Luca Weiss wrote: > > Add a node describing the KE

[PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-04 Thread Luca Weiss
Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss --- .../devicetree/bindings/input/sun4i-lradc-keys.txt| 1 + arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 8 2 files changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH] iio: light: stk3310: Add support for stk3335

2019-06-03 Thread Luca Weiss
From: Martijn Braam The stk3335 light/proximity sensor is similar to the stk3310 and stk3311 sensors and works with the stk3310 driver. Signed-off-by: Martijn Braam Signed-off-by: Luca Weiss --- drivers/iio/light/stk3310.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-06-03 Thread Luca Weiss
On Montag, 3. Juni 2019 09:42:47 CEST Maxime Ripard wrote: > Hi, > > On Fri, May 31, 2019 at 12:27:55PM +0200, Luca Weiss wrote: > > On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > > It would be great to drop the -keys from the compatible, and to >

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-31 Thread Luca Weiss
On Freitag, 24. Mai 2019 11:20:01 CEST Maxime Ripard wrote: > > It would be great to drop the -keys from the compatible, and to > document the bindings > > Looks good otherwise > > Maxime Hi again, So I should just document the "allwinner,sun50i-a64-lradc" string in

Re: [PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-24 Thread Luca Weiss
On May 20, 2019 1:07:42 PM GMT+02:00, Maxime Ripard > > > > > > wrote: > > >> >On Sat, May 18, 2019 at 07:09:30PM +0200, Luca Weiss wrote: > > >> >> Add a node describing the KEYADC on the A64. > > >> >> > > >> >

[PATCH] arm64: dts: allwinner: a64: Add lradc node

2019-05-18 Thread Luca Weiss
Add a node describing the KEYADC on the A64. Signed-off-by: Luca Weiss --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 7734f70e1057

[PATCH v5 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-26 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile | 1 + drivers/input/misc/gpio-vibra.c | 209 3 files changed

[PATCH v5 1/3] dt-bindings: input: add GPIO controllable vibrator

2019-04-26 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss Reviewed-by: Rob Herring --- Changes for v5: - Simply compatible property definition - Remove reference to regulator schema .../bindings/input/gpio-vibrator.yaml | 37

[PATCH v5 3/3] ARM: dts: msm8974-FP2: Add vibration motor

2019-04-26 Thread Luca Weiss
Add a node describing the vibration motor on the Fairphone 2. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2

[PATCH v4 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-20 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- Changes from v3: - Apply suggestions from Stephen Boyd drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile | 1 + drivers/input/misc/gpio-vibra.c

[PATCH v4 1/3] dt-bindings: input: add GPIO controllable vibrator

2019-04-20 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- Changes from v3: - Convert .txt based doc to the new yaml based format .../bindings/input/gpio-vibrator.yaml | 39 +++ 1 file changed, 39

[PATCH v4 3/3] ARM: dts: msm8974-FP2: Add vibration motor

2019-04-20 Thread Luca Weiss
Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts index 643c57f84818..bf402ae39226 100644 --- a/arch/arm

Re: [PATCH v3 1/3] dt-bindings: input: add GPIO controllable vibrator

2019-04-17 Thread Luca Weiss
On Freitag, 12. April 2019 17:06:23 CEST Luca Weiss wrote: > Provide a simple driver for GPIO controllable vibrators. > It will be used by the Fairphone 2. > > Signed-off-by: Luca Weiss > --- > .../bindings/input/gpio-vibrator.txt | 20 +++ >

Re: [PATCH v3 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-16 Thread Luca Weiss
On Freitag, 12. April 2019 19:43:52 CEST Stephen Boyd wrote: > Quoting Luca Weiss (2019-04-12 08:06:24) > > > diff --git a/drivers/input/misc/gpio-vibra.c > > b/drivers/input/misc/gpio-vibra.c new file mode 100644 > > index ..3fd2dfd4f670 > > --- /dev/nul

[PATCH v3 1/3] dt-bindings: input: add GPIO controllable vibrator

2019-04-12 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- .../bindings/input/gpio-vibrator.txt | 20 +++ 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/gpio

[PATCH v3 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-12 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile | 1 + drivers/input/misc/gpio-vibra.c | 209 3 files changed

[PATCH v3 3/3] ARM: dts: msm8974-FP2: Add vibration motor

2019-04-12 Thread Luca Weiss
Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts index 643c57f84818..bf402ae39226 100644 --- a/arch/arm

Re: [PATCH v2 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-09 Thread Luca Weiss
200, Luca Weiss wrote: > > Provide a simple driver for GPIO controllable vibrators. > > It will be used by the Fairphone 2. > > > > Signed-off-by: Luca Weiss > > --- > > > > drivers/input/misc/Kconfig | 12 ++ > > drivers/input/misc/Makefi

[PATCH v2 1/3] dt-bindings: input: add GPIO controllable vibrator

2019-04-07 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- Changes from v1: - Mark vcc-supply as optional .../bindings/input/gpio-vibrator.txt | 20 +++ 1 file changed, 20 insertions(+) create mode 100644

[PATCH v2 2/3] Input: add a driver for GPIO controllable vibrators

2019-04-07 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile | 1 + drivers/input/misc/gpio-vibra.c | 214 3 files changed

[PATCH v2 3/3] ARM: dts: msm8974-FP2: Add vibration motor

2019-04-07 Thread Luca Weiss
Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dts index 643c57f84818..bf402ae39226 100644 --- a/arch/arm

[PATCH 2/2] Input: add a driver for GPIO controllable vibrators

2019-03-02 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile | 1 + drivers/input/misc/gpio-vibra.c | 214 3 files changed

[PATCH 1/2] dt-bindings: input: add GPIO controllable vibrator

2019-03-02 Thread Luca Weiss
Provide a simple driver for GPIO controllable vibrators. It will be used by the Fairphone 2. Signed-off-by: Luca Weiss --- .../devicetree/bindings/input/gpio-vibrator.txt | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/gpio

[PATCH] drm/msm: Fix NULL pointer dereference

2019-03-02 Thread Luca Weiss
) [4.294933] ---[ end trace 18729cc2bca2b4b3 ]--- Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/msm_gem_vma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index 49c04829cf34..fcf7a83f0e6f 100644

Re: [v2] mmc: sdhci-msm: Optionally wait for signal level changes

2017-11-21 Thread Luca Weiss
"mmc: sdhci-msm: Add sdhci msm register write APIs > which wait for pwr irq") Signed-off-by: Bjorn Andersson > <bjorn.anders...@linaro.org> Tested-by: Luca Weiss <l...@z3ntu.xyz> > --- > > The offending patch is part of your v4.15 pull request, so please p

Re: [v2] mmc: sdhci-msm: Optionally wait for signal level changes

2017-11-21 Thread Luca Weiss
> which wait for pwr irq") Signed-off-by: Bjorn Andersson > Tested-by: Luca Weiss > --- > > The offending patch is part of your v4.15 pull request, so please pick > this up for the -rcs. > > Changes since v1: > - Fixed spelling of swichable... > > drive

Re: spmi: pmic-arb: Always allocate ppid_to_apid table

2017-07-09 Thread Luca Weiss
} > - > - pa->ppid_to_apid = devm_kcalloc(>dev, > - PMIC_ARB_MAX_PPID, > - sizeof(*pa->ppid_to_apid), > - GFP_KERNEL); >

Re: spmi: pmic-arb: Always allocate ppid_to_apid table

2017-07-09 Thread Luca Weiss
PMIC_ARB_MAX_PPID, > - sizeof(*pa->ppid_to_apid), > - GFP_KERNEL); > - if (!pa->ppid_to_apid) { > - err = -ENOMEM; > - goto err_put_ctrl; > - } > } > > dev_info(>dev, "PMIC arbiter version %s (0x%x)\n", Tested-by: Luca Weiss

<    1   2   3   4   5