[PATCH v7 12/14] Documentation: fix few typos and clarifications for the firmware loader

Fix a few typos, and clarify a few sentences. Reviewed-by: Kees Cook <keesc...@chromium.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 +

[PATCH v7 12/14] Documentation: fix few typos and clarifications for the firmware loader

Fix a few typos, and clarify a few sentences. Reviewed-by: Kees Cook Signed-off-by: Luis R. Rodriguez --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions

[PATCH v3 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c and mm/vmalloc.c code have been using PAGE_KERNEL as a fallback for years. Move this fallback to asm-generic. Suggested-by: Matthew Wilcox <wi...@infradead.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org>

[PATCH v3 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c and mm/vmalloc.c code have been using PAGE_KERNEL as a fallback for years. Move this fallback to asm-generic. Suggested-by: Matthew Wilcox Signed-off-by: Luis R. Rodriguez --- include/asm-generic/pgtable.h | 4 mm/nommu.c

[PATCH v3 1/2] mm: provide a fallback for PAGE_KERNEL_RO for architectures

-generic header. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fallback.c | 5 - include/asm-generic/pgtable.h | 14 ++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/base/firmware_loader/fallback.c b/d

[PATCH v3 1/2] mm: provide a fallback for PAGE_KERNEL_RO for architectures

-generic header. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 5 - include/asm-generic/pgtable.h | 14 ++ 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader

[PATCH v3 0/2] mm: PAGE_KERNEL_* fallbacks

he fallback mechanism for PAGE_KERNEL_RO. Luis R. Rodriguez (2): mm: provide a fallback for PAGE_KERNEL_RO for architectures mm: provide a fallback for PAGE_KERNEL_EXEC for architectures drivers/base/firmware_loader/fallback.c | 5 - include/asm-generic/pgtable.h | 18

[PATCH v3 0/2] mm: PAGE_KERNEL_* fallbacks

he fallback mechanism for PAGE_KERNEL_RO. Luis R. Rodriguez (2): mm: provide a fallback for PAGE_KERNEL_RO for architectures mm: provide a fallback for PAGE_KERNEL_EXEC for architectures drivers/base/firmware_loader/fallback.c | 5 - include/asm-generic/pgtable.h | 18

Re: [PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks

On Thu, May 10, 2018 at 08:07:33AM +0200, Greg KH wrote: > On Wed, May 09, 2018 at 06:44:45PM -0700, Luis R. Rodriguez wrote: > > While dusting out the firmware loader closet I spotted a PAGE_KERNEL_* > > fallback hack. This hurts my eyes, and it should also be blinding > >

Re: [PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks

On Thu, May 10, 2018 at 08:07:33AM +0200, Greg KH wrote: > On Wed, May 09, 2018 at 06:44:45PM -0700, Luis R. Rodriguez wrote: > > While dusting out the firmware loader closet I spotted a PAGE_KERNEL_* > > fallback hack. This hurts my eyes, and it should also be blinding > >

Re: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

On Thu, May 10, 2018 at 03:33:55PM +, Luis R. Rodriguez wrote: > On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote: > > Hi Luis, > > > > On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez <mcg...@kernel.org> > > wrote: > &g

Re: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

On Thu, May 10, 2018 at 03:33:55PM +, Luis R. Rodriguez wrote: > On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote: > > Hi Luis, > > > > On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez > > wrote: > > > Some architectures just don't h

Re: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote: > Hi Luis, > > On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c > > and mm/vmalloc.c code

Re: [PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

On Thu, May 10, 2018 at 09:45:56AM +0200, Geert Uytterhoeven wrote: > Hi Luis, > > On Thu, May 10, 2018 at 3:44 AM, Luis R. Rodriguez wrote: > > Some architectures just don't have PAGE_KERNEL_EXEC. The mm/nommu.c > > and mm/vmalloc.c code have been using PAGE_KERNEL as

[PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

-by: Matthew Wilcox <wi...@infradead.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- include/asm-generic/pgtable.h | 12 mm/nommu.c| 4 mm/vmalloc.c | 4 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a

[PATCH v2 2/2] mm: provide a fallback for PAGE_KERNEL_EXEC for architectures

-by: Matthew Wilcox Signed-off-by: Luis R. Rodriguez --- include/asm-generic/pgtable.h | 12 mm/nommu.c| 4 mm/vmalloc.c | 4 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/include/asm-generic/pgtable.h b/include/asm-generic

[PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks

love or review. At least 0-day was happy with the changes. Matthew Wilcox did put together a PAGE_KERNEL_RO patch for ia64, that needs review and testing, and if it goes well it should be merged. Luis R. Rodriguez (2): mm: provide a fallback for PAGE_KERNEL_RO for architectures mm: provide

[PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks

love or review. At least 0-day was happy with the changes. Matthew Wilcox did put together a PAGE_KERNEL_RO patch for ia64, that needs review and testing, and if it goes well it should be merged. Luis R. Rodriguez (2): mm: provide a fallback for PAGE_KERNEL_RO for architectures mm: provide

[PATCH v2 1/2] mm: provide a fallback for PAGE_KERNEL_RO for architectures

in place on the firmware loader for years. Move the fallback into the respective asm-generic header. Architectures which don't define this yet: o alpha o ia64 o m68k o mips o sparc64 o sparc Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fall

[PATCH v2 1/2] mm: provide a fallback for PAGE_KERNEL_RO for architectures

in place on the firmware loader for years. Move the fallback into the respective asm-generic header. Architectures which don't define this yet: o alpha o ia64 o m68k o mips o sparc64 o sparc Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 5 - include

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

On Wed, May 02, 2018 at 03:11:13PM +, Luis R. Rodriguez wrote: > On Wed, May 02, 2018 at 12:08:57PM +0200, Geert Uytterhoeven wrote: > > Hi Luis, > > > > On Sat, Apr 28, 2018 at 2:15 AM, Luis R. Rodriguez <mcg...@kernel.org> > > wrote: > > > Some

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

On Wed, May 02, 2018 at 03:11:13PM +, Luis R. Rodriguez wrote: > On Wed, May 02, 2018 at 12:08:57PM +0200, Geert Uytterhoeven wrote: > > Hi Luis, > > > > On Sat, Apr 28, 2018 at 2:15 AM, Luis R. Rodriguez > > wrote: > > > Some architectures do not d

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

On Tue, May 08, 2018 at 06:39:35PM -0700, Matthew Wilcox wrote: > On Wed, May 09, 2018 at 01:04:38AM +0000, Luis R. Rodriguez wrote: > > On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote: > > > ia64: Add PAGE_KERNEL_RO and PAGE_KERNEL_EXEC > > > &

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

On Tue, May 08, 2018 at 06:39:35PM -0700, Matthew Wilcox wrote: > On Wed, May 09, 2018 at 01:04:38AM +0000, Luis R. Rodriguez wrote: > > On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote: > > > ia64: Add PAGE_KERNEL_RO and PAGE_KERNEL_EXEC > > > &

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Wed, May 09, 2018 at 06:06:57PM -0400, Mimi Zohar wrote: > On Wed, 2018-05-09 at 21:22 +0000, Luis R. Rodriguez wrote: > > > > OK, its still not clear to what it will do. If it does not touch the > > firmware > > loader code, and it just sets and configur

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Wed, May 09, 2018 at 06:06:57PM -0400, Mimi Zohar wrote: > On Wed, 2018-05-09 at 21:22 +0000, Luis R. Rodriguez wrote: > > > > OK, its still not clear to what it will do. If it does not touch the > > firmware > > loader code, and it just sets and configur

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Wed, May 09, 2018 at 03:57:18PM -0400, Mimi Zohar wrote: > On Wed, 2018-05-09 at 19:15 +0000, Luis R. Rodriguez wrote: > > > > > > If both are enabled, do we require both signatures or is one enough. > > > > > > > > Good question. Considering

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Wed, May 09, 2018 at 03:57:18PM -0400, Mimi Zohar wrote: > On Wed, 2018-05-09 at 19:15 +0000, Luis R. Rodriguez wrote: > > > > > > If both are enabled, do we require both signatures or is one enough. > > > > > > > > Good question. Considering

Re: [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

On Tue, May 08, 2018 at 03:42:33PM -0700, Kees Cook wrote: > On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > + This used to be the default firmware loading facility, and udev > > used > > + to listen for uvents to l

Re: [PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

On Tue, May 08, 2018 at 03:42:33PM -0700, Kees Cook wrote: > On Tue, May 8, 2018 at 11:12 AM, Luis R. Rodriguez wrote: > > + This used to be the default firmware loading facility, and udev > > used > > + to listen for uvents to load firmware for the

Re: [PATCH v6 12/13] Documentation: remove stale firmware API reference

On Wed, May 09, 2018 at 12:12:09PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 8 May 2018 11:12:46 -0700 > "Luis R. Rodriguez" <mcg...@kernel.org> escreveu: > > > It refers to a pending patch, but this was merged eons ago. > > Didn't know that

Re: [PATCH v6 12/13] Documentation: remove stale firmware API reference

On Wed, May 09, 2018 at 12:12:09PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 8 May 2018 11:12:46 -0700 > "Luis R. Rodriguez" escreveu: > > > It refers to a pending patch, but this was merged eons ago. > > Didn't know that such patch was already merge

Re: [PATCH v7 1/4] ipc: IPCMNI limit check for msgmni and shmmni

On Mon, May 07, 2018 at 07:57:12PM -0400, Waiman Long wrote: > On 05/07/2018 06:39 PM, Luis R. Rodriguez wrote: > > On Mon, May 07, 2018 at 04:59:09PM -0400, Waiman Long wrote: > >> A user can write arbitrary integer values to msgmni and shmmni sysctl > >> param

Re: [PATCH v7 1/4] ipc: IPCMNI limit check for msgmni and shmmni

On Mon, May 07, 2018 at 07:57:12PM -0400, Waiman Long wrote: > On 05/07/2018 06:39 PM, Luis R. Rodriguez wrote: > > On Mon, May 07, 2018 at 04:59:09PM -0400, Waiman Long wrote: > >> A user can write arbitrary integer values to msgmni and shmmni sysctl > >> param

Re: [PATCH 13/24] selftests: kmod: return Kselftest Skip code for skipped tests

ftest framework SKIP code is 4 and the framework prints appropriate > messages to indicate that the test is skipped. > > Signed-off-by: Shuah Khan (Samsung OSG) <sh...@kernel.org> Reviewed-by: Luis R. Rodriguez <mcg...@kernel.org> Luis

Re: [PATCH 13/24] selftests: kmod: return Kselftest Skip code for skipped tests

ftest framework SKIP code is 4 and the framework prints appropriate > messages to indicate that the test is skipped. > > Signed-off-by: Shuah Khan (Samsung OSG) Reviewed-by: Luis R. Rodriguez Luis

Re: [PATCH 08/24] selftests: firmware: return Kselftest Skip code for skipped tests

ped. > > Signed-off-by: Shuah Khan (Samsung OSG) <sh...@kernel.org> Reviewed-by: Luis R. Rodriguez <mcg...@kernel.org> Luis > --- > tools/testing/selftests/firmware/fw_fallback.sh | 4 ++-- > tools/testing/selftests/firmware/fw_filesystem.sh | 4 +++- > tools/

Re: [PATCH 08/24] selftests: firmware: return Kselftest Skip code for skipped tests

ped. > > Signed-off-by: Shuah Khan (Samsung OSG) Reviewed-by: Luis R. Rodriguez Luis > --- > tools/testing/selftests/firmware/fw_fallback.sh | 4 ++-- > tools/testing/selftests/firmware/fw_filesystem.sh | 4 +++- > tools/testing/selftests/firmware/fw_lib.sh| 7

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Wed, May 09, 2018 at 07:30:28AM -0400, Mimi Zohar wrote: > On Tue, 2018-05-08 at 17:34 +0000, Luis R. Rodriguez wrote: > > On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote: > > > On Fri, 2018-05-04 at 00:07 +, Luis R. Rodriguez wrote: > > > > On T

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Wed, May 09, 2018 at 07:30:28AM -0400, Mimi Zohar wrote: > On Tue, 2018-05-08 at 17:34 +0000, Luis R. Rodriguez wrote: > > On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote: > > > On Fri, 2018-05-04 at 00:07 +, Luis R. Rodriguez wrote: > > > > On T

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote: > On Fri, Apr 27, 2018 at 05:15:26PM -0700, Luis R. Rodriguez wrote: > > Some architectures do not define PAGE_KERNEL_RO, best we can do > > for them is to provide a fallback onto PAGE_KERNEL. Remove the > > h

Re: [PATCH] mm: provide a fallback for PAGE_KERNEL_RO for architectures

On Fri, Apr 27, 2018 at 08:18:10PM -0700, Matthew Wilcox wrote: > On Fri, Apr 27, 2018 at 05:15:26PM -0700, Luis R. Rodriguez wrote: > > Some architectures do not define PAGE_KERNEL_RO, best we can do > > for them is to provide a fallback onto PAGE_KERNEL. Remove the > > h

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Tue, May 08, 2018 at 05:17:41PM -0700, Darrick J. Wong wrote: > On Wed, May 09, 2018 at 12:03:28AM +0000, Luis R. Rodriguez wrote: > > Groovy, thanks, let's not forget the xfs_repair respective fix :) let me > > know > > if you have any feedback on that. > >

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Tue, May 08, 2018 at 05:17:41PM -0700, Darrick J. Wong wrote: > On Wed, May 09, 2018 at 12:03:28AM +0000, Luis R. Rodriguez wrote: > > Groovy, thanks, let's not forget the xfs_repair respective fix :) let me > > know > > if you have any feedback on that. > >

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Mon, May 07, 2018 at 05:30:55PM -0700, Darrick J. Wong wrote: > On Tue, May 01, 2018 at 05:45:12PM +0000, Luis R. Rodriguez wrote: > > On Tue, May 01, 2018 at 10:23:19AM -0700, Darrick J. Wong wrote: > > > On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wr

Re: [RFC] vfs: skip extra attributes check on removal for symlinks

On Mon, May 07, 2018 at 05:30:55PM -0700, Darrick J. Wong wrote: > On Tue, May 01, 2018 at 05:45:12PM +0000, Luis R. Rodriguez wrote: > > On Tue, May 01, 2018 at 10:23:19AM -0700, Darrick J. Wong wrote: > > > On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wr

[PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum

From: Andres Rodriguez <andre...@gmail.com> This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: coding style fixes, merge kdoc with

[PATCH v6 01/13] firmware: wrap FW_OPT_* into an enum

From: Andres Rodriguez This should let us associate enum kdoc to these values. While at it, kdocify the fw_opt. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: coding style fixes, merge kdoc with enum move] Signed-off-by: Luis R. Rodriguez --- drivers/base

[PATCH v6 02/13] firmware: use () to terminate kernel-doc function names

From: Andres Rodriguez <andre...@gmail.com> The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Randy Dunlap <rdun...@infradead.org> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: adjust s

[PATCH v6 02/13] firmware: use () to terminate kernel-doc function names

From: Andres Rodriguez The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez Acked-by: Randy Dunlap Acked-by: Luis R. Rodriguez [mcgrof: adjust since the wide API rename is not yet merged] Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader

[PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback()

This also sets the expecations for future fallback interfaces, even if they are not exported. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_

[PATCH v6 04/13] firmware_loader: document firmware_sysfs_fallback()

This also sets the expecations for future fallback interfaces, even if they are not exported. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader/fallback.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers

[PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

into the firmware_loader/ directory later. This also now recommends using firmwared [0] for folks left needing a uevent handler in userspace for the sysfs firmware fallback mechanis given udev's uevent firmware mechanism was ripped out a while ago. [0] https://github.com/teg/firmwared Signed-off-by: Luis R

[PATCH v6 05/13] firmware_loader: enhance Kconfig documentation over FW_LOADER

into the firmware_loader/ directory later. This also now recommends using firmwared [0] for folks left needing a uevent handler in userspace for the sysfs firmware fallback mechanis given udev's uevent firmware mechanism was ripped out a while ago. [0] https://github.com/teg/firmwared Signed-off-by: Luis R

[PATCH v2] mm: expland documentation over __read_mostly

__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Acked-by: Christoph Lameter <c...@linux.com> Signed-off-by:

[PATCH v2] mm: expland documentation over __read_mostly

__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Acked-by: Christoph Lameter Signed-off-by: Luis R. Rodriguez

[PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file

This will make it easier to track and easier to understand what components and features are part of the FW_LOADER. There are some components related to firmware which have *nothing* to do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.

[PATCH v6 06/13] firmware_loader: move kconfig FW_LOADER entries to its own file

This will make it easier to track and easier to understand what components and features are part of the FW_LOADER. There are some components related to firmware which have *nothing* to do with the FW_LOADER, souch as PREVENT_FIRMWARE_BUILD. Signed-off-by: Luis R. Rodriguez --- drivers/base

Re: [PATCH] mm: expland documentation over __read_mostly

On Tue, May 08, 2018 at 08:39:30AM -0700, Randy Dunlap wrote: > On 05/08/2018 04:23 AM, Matthew Wilcox wrote: > > On Tue, May 08, 2018 at 09:28:14AM +0100, David Howells wrote: > >> Randy Dunlap wrote: > >> > + * execute a critial path. We should be mindful and

Re: [PATCH] mm: expland documentation over __read_mostly

On Tue, May 08, 2018 at 08:39:30AM -0700, Randy Dunlap wrote: > On 05/08/2018 04:23 AM, Matthew Wilcox wrote: > > On Tue, May 08, 2018 at 09:28:14AM +0100, David Howells wrote: > >> Randy Dunlap wrote: > >> > + * execute a critial path. We should be mindful and selective if its > use.

[PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware

From: Andres Rodriguez <andre...@gmail.com> This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Kalle Valo <kv...@codeaurora.o

[PATCH v6 09/13] ath10k: use firmware_request_nowarn() to load firmware

From: Andres Rodriguez This reduces the unnecessary spew when trying to load optional firmware: "Direct firmware load for ... failed with error -2" Signed-off-by: Andres Rodriguez Acked-by: Kalle Valo Signed-off-by: Luis R. Rodriguez --- drivers/net/wireless/ath/ath10k/core.c | 2

[PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode

eeping the fallback mechanism enabled. So use that instead. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Kalle Valo <kv...@codeaurora.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1

[PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful

with the fallback mechanism, we will soon, so just respect its use consistently. And even if you *don't* want to print always on failure, you may want to print when debugging so enable dynamic debug print when FW_OPT_NO_WARN is used. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- d

[PATCH v6 10/13] ath10k: re-enable the firmware fallback mechanism for testmode

enabled. So use that instead. Signed-off-by: Andres Rodriguez Acked-by: Kalle Valo Signed-off-by: Luis R. Rodriguez --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/testmode.c b/drivers/net/wireless

[PATCH v6 07/13] firmware_loader: make firmware_fallback_sysfs() print more useful

with the fallback mechanism, we will soon, so just respect its use consistently. And even if you *don't* want to print always on failure, you may want to print when debugging so enable dynamic debug print when FW_OPT_NO_WARN is used. Signed-off-by: Luis R. Rodriguez --- drivers/base/firmware_loader

[PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader

Fix a few typos, and clarify a few sentences. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-)

[PATCH v6 11/13] Documentation: fix few typos and clarifications for the firmware loader

Fix a few typos, and clarify a few sentences. Signed-off-by: Luis R. Rodriguez --- Documentation/driver-api/firmware/fallback-mechanisms.rst | 5 +++-- Documentation/driver-api/firmware/firmware_cache.rst | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings

riguez <andre...@gmail.com> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> [mcgrof: used the old API calls as the full rename is not done yet, and add the caller for when FW_LOADER is disabled, enhance documentation ] Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> ---

[PATCH v6 08/13] firmware: add firmware_request_nowarn() - load firmware without warnings

. Rodriguez [mcgrof: used the old API calls as the full rename is not done yet, and add the caller for when FW_LOADER is disabled, enhance documentation ] Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/request_firmware.rst | 5 drivers/base/firmware_loader/main.c | 27

[PATCH v6 12/13] Documentation: remove stale firmware API reference

It refers to a pending patch, but this was merged eons ago. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- Documentation/dell_rbu.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/dell_rbu.txt b/Documentation/dell_rbu.txt index 0fdb6aa2704c..077fdc29a0d0

[PATCH v6 12/13] Documentation: remove stale firmware API reference

It refers to a pending patch, but this was merged eons ago. Signed-off-by: Luis R. Rodriguez --- Documentation/dell_rbu.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/dell_rbu.txt b/Documentation/dell_rbu.txt index 0fdb6aa2704c..077fdc29a0d0 100644 --- a/Documentation

[PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

From: Andres Rodriguez <andre...@gmail.com> This is done since this call is now exposed through kernel-doc, and since this also paves the way for different future types of fallback mechanims. Signed-off-by: Andres Rodriguez <andre...@gmail.com> Acked-by: Luis R. Rodriguez <mc

[PATCH v6 03/13] firmware: rename fw_sysfs_fallback to firmware_fallback_sysfs()

From: Andres Rodriguez This is done since this call is now exposed through kernel-doc, and since this also paves the way for different future types of fallback mechanims. Signed-off-by: Andres Rodriguez Acked-by: Luis R. Rodriguez [mcgrof: small coding style changes] Signed-off-by: Luis R

[PATCH v6 00/13] firmware_loader changes for v4.18

() to load firmware ath10k: re-enable the firmware fallback mechanism for testmode Luis R. Rodriguez (7): firmware_loader: document firmware_sysfs_fallback() firmware_loader: enhance Kconfig documentation over FW_LOADER firmware_loader: move kconfig FW_LOADER entries to its own file

[PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- .../driver-api/firmware/fallback-mechanisms.rst | 9 ++--- 1 file changed, 6 insertions

[PATCH v6 00/13] firmware_loader changes for v4.18

() to load firmware ath10k: re-enable the firmware fallback mechanism for testmode Luis R. Rodriguez (7): firmware_loader: document firmware_sysfs_fallback() firmware_loader: enhance Kconfig documentation over FW_LOADER firmware_loader: move kconfig FW_LOADER entries to its own file

[PATCH v6 13/13] Documentation: clarify firmware_class provenance and why we can't rename the module

Clarify the provenance of the firmware loader firmware_class module name and why we cannot rename the module in the future. Signed-off-by: Luis R. Rodriguez --- .../driver-api/firmware/fallback-mechanisms.rst | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 00/18] Fix some build warnings/errors with Sphinx

On Tue, May 08, 2018 at 10:13:42AM -0600, Jonathan Corbet wrote: > On Mon, 7 May 2018 06:35:36 -0300 > Mauro Carvalho Chehab wrote: > > > I decided to give a try with Sphinx last stable version > > (1.17.4), and noticed several issues. The worse one was > > with the

Re: [PATCH 00/18] Fix some build warnings/errors with Sphinx

On Tue, May 08, 2018 at 10:13:42AM -0600, Jonathan Corbet wrote: > On Mon, 7 May 2018 06:35:36 -0300 > Mauro Carvalho Chehab wrote: > > > I decided to give a try with Sphinx last stable version > > (1.17.4), and noticed several issues. The worse one was > > with the networking book: a

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote: > On Fri, 2018-05-04 at 00:07 +0000, Luis R. Rodriguez wrote: > > On Tue, May 01, 2018 at 09:48:20AM -0400, Mimi Zohar wrote: > > > Allow LSMs and IMA to differentiate between signed regulatory.db and &g

Re: [PATCH 3/6] firmware: differentiate between signed regulatory.db and other firmware

On Thu, May 03, 2018 at 08:24:26PM -0400, Mimi Zohar wrote: > On Fri, 2018-05-04 at 00:07 +0000, Luis R. Rodriguez wrote: > > On Tue, May 01, 2018 at 09:48:20AM -0400, Mimi Zohar wrote: > > > Allow LSMs and IMA to differentiate between signed regulatory.db and &g

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Fri, May 04, 2018 at 07:54:28AM +0200, Ard Biesheuvel wrote: > On 4 May 2018 at 01:29, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: > [...] > >> diff --git a/Documentation/driver-api/firmware/r

Re: [PATCH v5 2/5] efi: Add embedded peripheral firmware support

On Fri, May 04, 2018 at 07:54:28AM +0200, Ard Biesheuvel wrote: > On 4 May 2018 at 01:29, Luis R. Rodriguez wrote: > > On Sun, Apr 29, 2018 at 11:35:55AM +0200, Hans de Goede wrote: > [...] > >> diff --git a/Documentation/driver-api/firmware/request_firmware.rst > >&

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote: > On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez <mcg...@kernel.org> > > wrote: > > > A

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

On Tue, May 08, 2018 at 03:38:05PM +, Luis R. Rodriguez wrote: > On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez > > wrote: > > > Android became the primary user of CONFIG_FW_LOA

Re: [PATCH 02/18] docs: fix location of request_firmware & friends

into its own directory") > Cc: Kees Cook <keesc...@chromium.org> > Cc: Luis R. Rodriguez <mcg...@kernel.org> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Signed-off-by: Mauro Carvalho Chehab <mchehab+sams...@kernel.org> > --- > Documentation/dell

Re: [PATCH 02/18] docs: fix location of request_firmware & friends

changed accordingly, > causing Sphinx errors. > > Change the location accordingly at the documentation files. > > While here, add a missing entry at request_firmware.rst for > release_firmware() function. > > Fixes: 5d6d1ddd2730 ("firmware: move firmware loader into i

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > Android became the primary user of CONFIG_FW_LOADER_USER_HELPER_FALLBACK. > > > > It would be good for us to hear from And

Re: [PATCH v3 2/5] efi: Add embedded peripheral firmware support

On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote: > On Wed, Apr 25, 2018 at 10:55 AM, Luis R. Rodriguez wrote: > > Android became the primary user of CONFIG_FW_LOADER_USER_HELPER_FALLBACK. > > > > It would be good for us to hear from Android folks

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

On Fri, May 04, 2018 at 10:43:49AM -0700, Luis R. Rodriguez wrote: > Greg, > > I've reviewed the pending patches for the firmware_laoder and as for > v4.18, the following 3 patches from Andres have been iterated enough > that they're ready after I made some final minor chang

Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18

On Fri, May 04, 2018 at 10:43:49AM -0700, Luis R. Rodriguez wrote: > Greg, > > I've reviewed the pending patches for the firmware_laoder and as for > v4.18, the following 3 patches from Andres have been iterated enough > that they're ready after I made some final minor chang

Re: [PATCH 6/9] firmware: print firmware name on fallback path

On Fri, May 04, 2018 at 10:57:26PM -0400, Andres Rodriguez wrote: > On 2018-05-03 07:42 PM, Luis R. Rodriguez wrote: > > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: > > > Previously, one could assume the firmware name from the preceding > > > mes

Re: [PATCH 6/9] firmware: print firmware name on fallback path

On Fri, May 04, 2018 at 10:57:26PM -0400, Andres Rodriguez wrote: > On 2018-05-03 07:42 PM, Luis R. Rodriguez wrote: > > On Mon, Apr 23, 2018 at 04:12:02PM -0400, Andres Rodriguez wrote: > > > Previously, one could assume the firmware name from the preceding > > > mes

[PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

This makes it clearer this code is part of the coredump code, and is not an exported generic helper from kernel/umh.c. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- fs/coredump.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/coredump.c b/fs/core

[PATCH] coredump: rename umh_pipe_setup() to coredump_pipe_setup()

This makes it clearer this code is part of the coredump code, and is not an exported generic helper from kernel/umh.c. Signed-off-by: Luis R. Rodriguez --- fs/coredump.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/coredump.c b/fs/coredump.c index 1e2c87acac9b

Re: [PATCH v7 3/4] ipc: Allow boot time extension of IPCMNI from 32k to 2M

On Mon, May 07, 2018 at 04:59:11PM -0400, Waiman Long wrote: > diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c > index 49f9bf4..d62335f 100644 > --- a/ipc/ipc_sysctl.c > +++ b/ipc/ipc_sysctl.c > @@ -120,7 +120,8 @@ static int proc_ipc_sem_dointvec(struct ctl_table *table, > int write, > static

Re: [PATCH v7 3/4] ipc: Allow boot time extension of IPCMNI from 32k to 2M

On Mon, May 07, 2018 at 04:59:11PM -0400, Waiman Long wrote: > diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c > index 49f9bf4..d62335f 100644 > --- a/ipc/ipc_sysctl.c > +++ b/ipc/ipc_sysctl.c > @@ -120,7 +120,8 @@ static int proc_ipc_sem_dointvec(struct ctl_table *table, > int write, > static

[PATCH] mm: expland documentation over __read_mostly

__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> --- include

[PATCH] mm: expland documentation over __read_mostly

__read_mostly can easily be misused by folks, its not meant for just read-only data. There are performance reasons for using it, but we also don't provide any guidance about its use. Provide a bit more guidance over it use. Signed-off-by: Luis R. Rodriguez --- include/linux/cache.h | 10

<    1   2   3   4   5   6   7   8   9   10   >