The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
arch/arc/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/se
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
arch/powerpc/kvm/book3s_xive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kvm/book3s_xive.c b/arch/po
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing them since they don't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
Similar to the other drivers/clocksource/ patch [0].
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
Similar to the other drivers/clocksource/ patch [0].
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi Dan,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing the two instances of them since they don't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best re
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
Commit-ID: dd8bd53ab86133327412e74bf5ba31a8ec2826d4
Gitweb: https://git.kernel.org/tip/dd8bd53ab86133327412e74bf5ba31a8ec2826d4
Author: Luis de Bethencourt
AuthorDate: Thu, 11 Jan 2018 15:50:20 +
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 12 Jan 2018 11:02:55 -0300
perf
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards,
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards,
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards,
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
It is completely stripped out by the compiler. Removing it since it doesn't do
anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I f
The trailing semicolon is an empty statement that does no operation.
It is completely stripped out by the compiler. Removing it since it doesn't do
anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I f
The trailing semicolon is an empty statement that does no operation.
It is completely stripped out by the compiler. Removing it since it doesn't do
anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
An other trailing semicolon to remove.
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
On 01/15/2018 07:18 PM, Takashi Iwai wrote:
> On Mon, 15 Jan 2018 19:18:57 +0100,
> Luis de Bethencourt wrote:
>>
>> From: Ubuntu
>
> Is this from address intentional? It'd be taken as is via git-am.
>
>
> thanks,
>
> Takashi
>
>> The
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Changes from v1:
- Fix commit message
sound/core/pcm_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
From: Ubuntu
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
On 01/11/2018 05:21 PM, Shuah Khan wrote:
> On 01/11/2018 06:46 AM, Luis de Bethencourt wrote:
>> The trailing semicolon is an empty statement that does no operation.
>> Removing it since it doesn't do anything.
>>
>> Signed-off-by: Luis de Bethencourt
>>
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0]
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi Shuah,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards :)
Luis
On 01/11/2018 01:19 AM, Joe Perches wrote:
> On Wed, 2018-01-10 at 17:01 +0000, Luis de Bethencourt wrote:
>> On 01/10/2018 04:51 PM, Luis de Bethencourt wrote:
>>> Hi,
>>>
>>> Removing the last patch from the original series after Dan's comment.
>&
On 01/10/2018 04:51 PM, Luis de Bethencourt wrote:
> Hi,
>
> Removing the last patch from the original series after Dan's comment.
>
> Tomorrow, I will send a new patch that removes the commented out code. This
> will
> replace that last patch.
>
> Thanks for th
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723b
Hi,
Removing the last patch from the original series after Dan's comment.
Tomorrow, I will send a new patch that removes the commented out code. This will
replace that last patch.
Thanks for the review,
Luis
Luis de Bethencourt (2):
staging: rtl8723bs: Fix trailing semicolon
st
The trailing semicolon is an empty statement that does nothing.
Removing it since it has no purpose.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal
hanks,
Luis
[0] Sorry I don't have a link, LKML is down
Luis de Bethencourt (3):
staging: rtl8723bs: Fix trailing semicolon
staging: rtl8723bs: Fix trailing semicolon
staging: rtl8723bs: Fix trailing semicolon in comment
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
drive
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723b
The trailing semicolon is an empty statement that does nothing.
Removing it since it has no purpose.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal
Even though the code is commented out, it has a small bug. The trailing
semicolon is an empty statement that does no operation. Removing it since
it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(
_USERCOPY
> whitelisting code in the last public patch of grsecurity/PaX based on my
> understanding of the code. Changes or omissions from the original code are
> mine and don't reflect the original grsecurity/PaX code.
>
> Signed-off-by: David Windsor
> [kees: adjust commit
On 01/09/2018 04:46 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 09, 2018 at 04:17:01PM +0000, Luis de Bethencourt wrote:
>> Fix trailing semicolon.
>
> Please be more explicit. That says what it does, but not _why_ :)
>
After walking around with my head down in shame I
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt
---
Hi all,
Testing the waters with this cleanup patch. If it is OK to send these there are
two very similar ones, plus more in general. Hap
Fix trailing semicolon.
Signed-off-by: Luis de Bethencourt
---
Changes since v1:
- Added a changelog body to the commit message
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
On 01/09/2018 04:11 PM, Hans de Goede wrote:
> Hi,
>
> On 09-01-18 17:02, Luis de Bethencourt wrote:
>> On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
>>> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
>>>> Signed-off-by: Luis de Bethen
On 01/09/2018 03:20 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 09, 2018 at 03:09:27PM +0000, Luis de Bethencourt wrote:
>> Signed-off-by: Luis de Bethencourt
>> ---
>
> I can't take patches without any changelog text, sorry :(
>
Hi Greg,
I have done some resear
Signed-off-by: Luis de Bethencourt
---
Hi all,
Testing the waters with this cleanup patch. If it is OK to send these there are
two very similar ones, plus more in general. Happy to send them.
I have a C.H.I.P. board, which is why this driver is interesting for me to play
with.
Thanks,
Luis
> of the lustre code that never reached the mainline kernel.
> Just discard it.
>
> Signed-off-by: NeilBrown
> ---
Thanks Neil! Nice cleanup indeed.
Acked-by: Luis de Bethencourt
If an "if" branch is terminated by a "goto", there's no need to have an
"else" statement and an indented block of code.
Remove the "else" statement to simplify the code flow.
Signed-off-by: Luis de Bethencourt
---
Hi,
The following patches rem
There is no need to use 'else' if in main branch 'goto' is present.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/lustre/lustre/llite/llite_lib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.
There is no need to use 'else' if in main branch 'return' is present.
Signed-off-by: Luis de Bethencourt
---
drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/vvp_io.c
b/dr
On 11/26/2017 03:17 AM, Alex Frappier Lachapelle wrote:
Fixed some coding standard issues.
Signed-off-by: Alex Frappier Lachapelle
---
fs/befs/btree.c | 97 ++---
1 file changed, 51 insertions(+), 46 deletions(-)
diff --git a/fs/befs/btree
ff-by: David Windsor
[kees: adjust commit log, provide usage trace]
Cc: Luis de Bethencourt
Cc: Salah Triki
Signed-off-by: Kees Cook
Acked-by: Luis de Bethencourt
---
fs/befs/linuxvfs.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/fs/befs/linuxvfs
On 08/29/2017 04:36 PM, Kees Cook wrote:
On Tue, Aug 29, 2017 at 3:12 AM, Luis de Bethencourt wrote:
Hello Kees,
This is great. Thanks :)
Will merge into my befs tree.
Hi! Actually, this depends on the rest of the series, which should be
merged together. If you can Ack this, I'll in
l code are
mine and don't reflect the original grsecurity/PaX code.
Signed-off-by: David Windsor
[kees: adjust commit log, provide usage trace]
Cc: Luis de Bethencourt
Cc: Salah Triki
Signed-off-by: Kees Cook
---
fs/befs/linuxvfs.c | 14 +-
1 file changed, 9 insertions(+), 5 delet
Hi Linus,
Very little activity in the befs file system this time since I'm busy
settling into a new job.
Hence the new-car-smell shiny address [0].
Merged one patch from Tommy Nguyen related to documentation.
Thank you very much,
Luis
[0] https://lkml.org/lkml/2017/7/9/37
The following chang
On 07/12/2017 11:00 PM, Andrew Morton wrote:
On Wed, 12 Jul 2017 23:40:53 +0200 "Luis R. Rodriguez"
wrote:
A soft bump to see if this can make it before the merge window closes.
Which is probably too late for already.
I've bounced a copy to Andrew. Andrew can this go through your tree this
On 07/09/2017 12:00 PM, Luis de Bethencourt wrote:
Updating the location of the befs git tree and my email address.
Signed-off-by: Luis de Bethencourt
---
Hello,
The currently listed email address isn't valid anymore due to a job change.
It felt like a good moment to request a kerne
Updating the location of the befs git tree and my email address.
Signed-off-by: Luis de Bethencourt
---
Hello,
The currently listed email address isn't valid anymore due to a job change.
It felt like a good moment to request a kernel.org account (thanks Konstantin
for the prompt respons
On 23/06/17 11:48, Tommy Nguyen wrote:
> fs/befs/TODO mentions some comments needing conversion to Kernel-Doc
> formatting. This patch changes the comment describing befs_bt_read_super().
>
> Signed-off-by: Tommy Nguyen
> ---
Hello Tommy,
This looks great, thank you very much.
Sorry for the in
From: Luis de Bethencourt
The current email address will stop being valid next week. Update it to the
email address that should be used instead from now on.
Signed-off-by: Luis de Bethencourt
---
Hello,
I wonder if people would prefer I use a kernel.org account. I think I have
enough
Hi Linus,
Third git pull request since I took maintainership of the befs file system [0].
This time it is a light one.
One fix from Fabian Frederick making the nfs client still work after a cache
drop.
Thank you very much,
Luis
[0] https://lkml.org/lkml/2016/7/27/502
The following changes si
)
>
> Signed-off-by: Fabian Frederick
>
Signed-off-by: Luis de Bethencourt
Hi Fabian,
I tested this and it looks to work well.
Merged it into my for-next branch [0].
Thanks,
Luis
[0] https://github.com/luisbg/linux-befs/commits/for-next
On 28/03/17 19:16, Fabian Frederick wrote:
> based on commit b3b42c0deaa1
> ("fs/affs: make export work with cold dcache")
>
> This adds get_parent function so that nfs client can still work after
> cache drop (Tested on NFS v4 with echo 3 > /proc/sys/vm/drop_caches)
>
> Signed-off-by: Fabian Fre
)
befs fixes for 4.10-rc1
Luis de Bethencourt (9):
befs: fix style issues in debug.c
befs: fix style issues in inode.c
befs: fix style issues in io.c
befs: fix typos in
On 05/11/16 12:42, Luis de Bethencourt wrote:
> Implement mandatory export_operations, so it is possible to export befs via
> nfs.
>
> Signed-off-by: Luis de Bethencourt
> ---
Forgot to add Richard.
Sorry Richard,
Luis
Implement mandatory export_operations, so it is possible to export befs via
nfs.
Signed-off-by: Luis de Bethencourt
---
Hi,
NFS exporting is a very useful feature. I implement here fh_to_dentry because
it is the mandatory member of struct export_operations, and fh_to_parent since
it is easy
A typo sneaked in the latest change on the USB documentation. Fixing it
and also a trailing whitespace since it is also in the "USB Host-Side API
Model" chapter.
Signed-off-by: Luis de Bethencourt
---
Documentation/DocBook/usb.tmpl | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
+0100)
befs fixes for 4.9-rc1
Luis de Bethencourt (21):
befs: check return of sb_min_blocksize
befs: fix function name in documentation
befs: remove unused functions
fs: befs: check silent flag b
) {
ERROR: space required before the open parenthesis '('
+ if( befs_sb->num_blocks > ~((sector_t)0) ) {
Signed-off-by: Luis de Bethencourt
---
fs/befs/linuxvfs.c | 49 ++---
1 file changed, 26 insertions(+), 23 deletions(-)
Signed-off-by: Luis de Bethencourt
---
fs/befs/linuxvfs.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index d307c1e..e99f1a8 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -491,13 +491,10 @@ fail
Fixing the two following checkpatch.pl issues:
ERROR: trailing whitespace
+ * Based on portions of file.c and inode.c $
WARNING: labels should not be indented
+ error:
Signed-off-by: Luis de Bethencourt
---
fs/befs/io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
No idea why some comments have signatures. These predate git. Removing them
since they add noise and no information.
Signed-off-by: Luis de Bethencourt
---
fs/befs/datastream.c | 2 --
fs/befs/io.c | 3 +--
fs/befs/linuxvfs.c | 3 ---
3 files changed, 1 insertion(+), 7 deletions
"foo *bar"
+befs_dump_index_node(const struct super_block *sb, befs_btree_nodehead * node)
Signed-off-by: Luis de Bethencourt
---
fs/befs/debug.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/fs/befs/debug.c b/fs/befs/debug.c
index 85c1339..36656
Hi,
Finishing the unglamorous series of typos and style issues.
The code is much cleaner and nicer to read now.
Thanks,
Luis
Luis de Bethencourt (7):
befs: fix style issues in debug.c
befs: fix style issues in inode.c
befs: fix style issues in io.c
befs: fix typos in linuxvfs.c
befs
return BEFS_SB(sb)->block_size / sizeof (befs_disk_inode_addr);
ERROR: "foo * bar" should be "foo *bar"
+ const char *key, befs_off_t * value);
ERROR: Macros with complex values should be enclosed in parentheses
+#define PACKED __attribute__ ((__pack
lock *sb, befs_inode * raw_inode,
Signed-off-by: Luis de Bethencourt
---
fs/befs/inode.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/befs/inode.c b/fs/befs/inode.c
index fa4b718..5367a64 100644
--- a/fs/befs/inode.c
+++ b/fs/befs/inode.c
@@ -1,6 +1,
; %s length: %llu", __func__, len);
WARNING: Block comments use * on subsequent lines
+ /*
+ Double indir block, plus all the indirect blocks it maps.
(and other instances of these)
Signed-off-by: Luis de Bethencourt
---
Hi,
Removing the second "befs:" that
Signed-off-by: Luis de Bethencourt
---
Hi,
This is a series of patches fixing small issues in datastream.c.
On the process of doing the same for the rest of files. To finish cleanup
and start adding documentation and new features.
Thanks,
Luis
fs/befs/datastream.c | 8
1 file
Convert function descriptions to kernel-doc style.
Signed-off-by: Luis de Bethencourt
---
fs/befs/datastream.c | 193 ++-
1 file changed, 98 insertions(+), 95 deletions(-)
diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c
index b2eb5b5
; %s length: %llu", __func__, len);
WARNING: Block comments use * on subsequent lines
+ /*
+ Double indir block, plus all the indirect blocks it maps.
(and other instances of these)
Signed-off-by: Luis de Bethencourt
---
fs/befs/datastream.c | 32 +--
t using blocks_per_ag properly, but users and avoiding
regressions go first.
Which BeFS images are you using to test the befs code? Since all the ones
I have are generated from Haiku OS, all of them have a bad blocks_per_ag.
LOL
Maybe we should contact Haiku OS developers and ask them to wri
On 12/08/16 08:26, Salah Triki wrote:
> On Thu, Aug 11, 2016 at 11:56:16AM +0100, Luis de Bethencourt wrote:
>> On 10/08/16 23:12, Salah Triki wrote:
>>> Check that the allocation group number is not greater or equal to the
>>> number of allocations group in the file s
Fixing typos in kernel-doc function descriptions in fs/befs/btree.c.
Signed-off-by: Luis de Bethencourt
---
Hi,
Noticed the typo of "actuall" below and decided to fix all typos in the
btree.c file.
Thanks,
Luis
fs/befs/btree.c | 7 +++
1 file changed, 3 insertions(+), 4
On 10/08/16 23:12, Salah Triki wrote:
> There is no need to init block, since it will be overwitten later by
> iaddr2blockno().
>
> Signed-off-by: Salah Triki
> ---
> fs/befs/io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/befs/io.c b/fs/befs/io.c
> index f9790f
On 10/08/16 23:12, Salah Triki wrote:
> Check that the allocation group number is not greater or equal to the
> number of allocations group in the file system and return BEF_ERR in the
> case of error.
>
> Signed-off-by: Salah Triki
> ---
> fs/befs/befs.h | 5 +
> 1 file changed, 5 insertion
On 10/08/16 22:41, Salah Triki wrote:
> On Tue, Aug 09, 2016 at 11:01:23PM +0100, Luis de Bethencourt wrote:
>> befs_dump_super_block() wasn't giving the inode_size information when
>> dumping all elements of the superblock. Add this element to have complete
>> inf
Commit-ID: 9279e0d2e565e0217618c2087de83d3239811329
Gitweb: http://git.kernel.org/tip/9279e0d2e565e0217618c2087de83d3239811329
Author: Luis de Bethencourt
AuthorDate: Sun, 10 Jul 2016 15:00:26 +0100
Committer: Ingo Molnar
CommitDate: Wed, 10 Aug 2016 14:03:32 +0200
sched/core: Add
befs_dump_super_block() wasn't giving the inode_size information when
dumping all elements of the superblock. Add this element to have complete
information of the superblock.
Signed-off-by: Luis de Bethencourt
---
Hi,
This is a series of superblock information related changes.
Thanks,
The description of befs_load_sb was confusing the kernel-doc system since,
because it starts with /**, it thinks it will document the function with
kernel-doc formatting. Which it isn't.
Fix other comment style issues in the file while we are at it.
Signed-off-by: Luis de Bethencourt
--
ted strings at a space character
+ befs_error(sb, "blocksize(%u) cannot be larger"
+ "than system pagesize(%lu)", befs_sb->block_size,
WARNING: line over 80 characters
+ if (befs_sb->log_start != befs_sb->log_end || befs_sb
n-fatal if
they don't match and just having it as a warning.
Signed-off-by: Luis de Bethencourt
---
fs/befs/super.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/fs/befs/super.c b/fs/befs/super.c
index dc13df8..c36745d 100644
--- a/fs/befs/super.c
+++ b/fs/befs/super.c
@@
1 - 100 of 644 matches
Mail list logo