Re: [PATCH] Fix use after free in get_tree_bdev()

2020-04-29 Thread Lukas Czerner
ke it ought to occur with other users of get_tree_bdev() such as > XFS, but apparently doesn't. > > Fix this by switching the order of the lines. This fixes the problem I was seeing. Thanks David. Reviewed-by: Lukas Czerner > > Fixes: 6fcf0c72e4b9 ("vfs: add missing blkdev_put() in

Re: [PATCH] vfs: Handle fs_param_neg_with_empty

2019-10-16 Thread Lukas Czerner
31d921c7fb96 ("vfs: Add configuration parser helpers") > Reported-by: Lukas Czerner > Signed-off-by: David Howells > --- > > fs/fs_parser.c |5 + > 1 file changed, 5 insertions(+) > > diff --git a/fs/fs_parser.c b/fs/fs_parser.c > index d1930adce68d

Re: [PATCH v2] VFS: Handle lazytime in do_mount()

2017-09-19 Thread Lukas Czerner
- SB_POSIXACL); > + SB_POSIXACL | > + SB_LAZYTIME); Looks good. Although I still think that this can be per mountpoint options. Regardless of that, you can add Reviewed-by: Lukas Czerner <lczer...@redhat.com> > > if (flags & MS_REMOUNT) > retval = do_remount(, flags, sb_flags, mnt_flags, > -- > Markus

Re: [PATCH v2] VFS: Handle lazytime in do_mount()

2017-09-19 Thread Lukas Czerner
SB_POSIXACL | > + SB_LAZYTIME); Looks good. Although I still think that this can be per mountpoint options. Regardless of that, you can add Reviewed-by: Lukas Czerner > > if (flags & MS_REMOUNT) > retval = do_remount(, flags, sb_flags, mnt_flags, > -- > Markus

[RFC][PATCH] fs: Prevent syncing frozen file system

2015-07-09 Thread Lukas Czerner
t's certainly different from what we've been used to. Signed-off-by: Lukas Czerner --- fs/super.c | 7 +++ fs/sync.c | 8 2 files changed, 15 insertions(+) diff --git a/fs/super.c b/fs/super.c index b613723..d337c91 100644 --- a/fs/super.c +++ b/fs/super.c @@ -514,10 +514,17 @@ v

[RFC][PATCH] fs: Prevent syncing frozen file system

2015-07-09 Thread Lukas Czerner
certainly different from what we've been used to. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/super.c | 7 +++ fs/sync.c | 8 2 files changed, 15 insertions(+) diff --git a/fs/super.c b/fs/super.c index b613723..d337c91 100644 --- a/fs/super.c +++ b/fs/super.c @@ -514,10

[PATCH v4 03/20] ext4: use ->invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in all ext4 invalidatepage routines. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext4/inode.c | 30 +++--- include/trace/events/ext4.h |

[PATCH v4 05/20] xfs: use ->invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in xfs_vm_invalidatepage() Signed-off-by: Lukas Czerner Reviewed-by: Ben Myers Cc: x...@oss.sgi.com --- v4: use xfs_page_class instead of separate tracepoint fs/xfs/xfs_aops.c |9 + fs/xfs/xfs_trac

[PATCH v4 06/20] ocfs2: use ->invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in ocfs2_invalidatepage(). Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara Acked-by: Joel Becker --- fs/ocfs2/aops.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/aops.

[PATCH v4 02/20] jbd2: change jbd2_journal_invalidatepage to accept length

2013-05-14 Thread Lukas Czerner
length argument to the jbd2_journal_invalidatepage() and updates all instances in ext4 and ocfs2. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext4/inode.c |3 ++- fs/jbd2/transaction.c | 24 +--- fs/ocfs2/aops.c |3 ++- include/linux/jbd2.h

[PATCH v4 01/20] mm: change invalidatepage prototype to accept length

2013-05-14 Thread Lukas Czerner
implementations will follow except the file systems where the changes are really simple and should not change the behaviour in any way .Implementation for truncate_page_range() which will be able to accept page unaligned ranges will follow as well. Signed-off-by: Lukas Czerner Cc: Andrew Morton Cc

[PATCH v4 07/20] ceph: use ->invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in ceph_invalidatepage(). Signed-off-by: Lukas Czerner Acked-by: Sage Weil Cc: ceph-de...@vger.kernel.org --- fs/ceph/addr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH v4 11/20] Revert "ext4: remove no longer used functions in inode.c"

2013-05-14 Thread Lukas Czerner
and remove ext4_discard_partial_page_buffers() since it is duplicating some code and also partially duplicating work of truncate_pagecache_range(), moreover the old implementation was much clearer. Signed-off-by: Lukas Czerner --- fs/ext4/ext4.h |4 ++ fs/ext4/inode.c | 120

[PATCH v4 08/20] gfs2: use ->invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in gfs2_invalidatepage(). Signed-off-by: Lukas Czerner Acked-by: Steven Whitehouse Cc: cluster-de...@redhat.com --- fs/gfs2/aops.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a

[PATCH v4 13/20] Revert "ext4: fix fsx truncate failure"

2013-05-14 Thread Lukas Czerner
pc64 machine with block size of 1024 bytes without any problems. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext4/inode.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 8187c3e..34ebb62 100644 --- a/fs/

[PATCH v4 16/20] ext4: remove unused discard_partial_page_buffers

2013-05-14 Thread Lukas Czerner
The discard_partial_page_buffers is no longer used anywhere so we can simply remove it including the *_no_lock variant and EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED define. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext4/ext4.h |8 -- fs/ext4/inode.c | 206

[PATCH v4 14/20] ext4: truncate_inode_pages() in orphan cleanup path

2013-05-14 Thread Lukas Czerner
this out. Signed-off-by: Lukas Czerner --- fs/ext4/super.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index dbc7c09..b971066 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2173,6 +2173,7 @@ static void ext4_orphan_cleanup(struct

[PATCH v4 10/20] mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-05-14 Thread Lukas Czerner
new ability in truncate_inode_pages_range(). Signed-off-by: Lukas Czerner Cc: Andrew Morton Cc: Hugh Dickins --- mm/truncate.c | 104 - 1 files changed, 73 insertions(+), 31 deletions(-) diff --git a/mm/truncate.c b/mm/truncate.c index fdba

[PATCH v4 09/20] reiserfs: use ->invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in reiserfs_invalidatepage() Signed-off-by: Lukas Czerner Cc: reiserfs-de...@vger.kernel.org --- fs/reiserfs/inode.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/reise

[PATCH v4 20/20] ext4: Allow punch hole with bigalloc enabled

2013-05-14 Thread Lukas Czerner
-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext4/inode.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index f504efa..daffbb8 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3557,11 +3557,6 @@ int ext4_punch_hole(struct

[PATCH v4 18/20] ext4: update ext4_ext_remove_space trace point

2013-05-14 Thread Lukas Czerner
Add "end" variable. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext4/extents.c |6 +++--- include/trace/events/ext4.h | 21 ++--- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c ind

[PATCH v4 19/20] ext4: make punch hole code path work with bigalloc

2013-05-14 Thread Lukas Czerner
be described in simple diagram: |FFF...FF..FF.UUU| ^--^ punch hole . - free space | - cluster boundary F - freed extent U - used extent Also update respective tracepoints to use signed long long type for partial_cluster. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs

[PATCH v4 17/20] ext4: remove unused code from ext4_remove_blocks()

2013-05-14 Thread Lukas Czerner
nused code completely and makes use of ext4_error() instead of printk if dubious range is provided. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext4/extents.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/exten

[PATCH v4 12/20] ext4: Call ext4_jbd2_file_inode() after zeroing block

2013-05-14 Thread Lukas Czerner
In data=ordered mode we should call ext4_jbd2_file_inode() so that crash after the truncate transaction has committed does not expose stall data in the tail of the block. Thanks Jan Kara for pointing that out. Signed-off-by: Lukas Czerner --- fs/ext4/inode.c |5 - 1 files changed, 4

[PATCH v4 15/20] ext4: use ext4_zero_partial_blocks in punch_hole

2013-05-14 Thread Lukas Czerner
and xfstests without any problems. Signed-off-by: Lukas Czerner --- v4: Use start-len arguments in ext4_zero_partial_blocks() fs/ext4/ext4.h |2 + fs/ext4/inode.c | 118 +- 2 files changed, 48 insertions(+), 72 deletions(-) diff --git a/fs

[PATCH v4 04/20] jbd: change journal_invalidatepage() to accept length

2013-05-14 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in journal_invalidatepage() and all the users in ext3 file system. Also update ext3 trace point to print out length argument. Signed-off-by: Lukas Czerner Reviewed-by: Jan Kara --- fs/ext3/inod

[PATCH v4 00/20] change invalidatepage prototype to accept length

2013-05-14 Thread Lukas Czerner
Hi, This set of patches are aimed to allow truncate_inode_pages_range() handle ranges which are not aligned at the end of the page. Currently it will hit BUG_ON() when the end of the range is not aligned. Punch hole feature however can benefit from this ability saving file systems some work not

[PATCH v4 00/20] change invalidatepage prototype to accept length

2013-05-14 Thread Lukas Czerner
Hi, This set of patches are aimed to allow truncate_inode_pages_range() handle ranges which are not aligned at the end of the page. Currently it will hit BUG_ON() when the end of the range is not aligned. Punch hole feature however can benefit from this ability saving file systems some work not

[PATCH v4 04/20] jbd: change journal_invalidatepage() to accept length

2013-05-14 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in journal_invalidatepage() and all the users in ext3 file system. Also update ext3 trace point to print out length argument. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs

[PATCH v4 12/20] ext4: Call ext4_jbd2_file_inode() after zeroing block

2013-05-14 Thread Lukas Czerner
In data=ordered mode we should call ext4_jbd2_file_inode() so that crash after the truncate transaction has committed does not expose stall data in the tail of the block. Thanks Jan Kara for pointing that out. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/inode.c |5 - 1

[PATCH v4 15/20] ext4: use ext4_zero_partial_blocks in punch_hole

2013-05-14 Thread Lukas Czerner
and xfstests without any problems. Signed-off-by: Lukas Czerner lczer...@redhat.com --- v4: Use start-len arguments in ext4_zero_partial_blocks() fs/ext4/ext4.h |2 + fs/ext4/inode.c | 118 +- 2 files changed, 48 insertions(+), 72 deletions

[PATCH v4 17/20] ext4: remove unused code from ext4_remove_blocks()

2013-05-14 Thread Lukas Czerner
and makes use of ext4_error() instead of printk if dubious range is provided. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs/ext4/extents.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/fs/ext4/extents.c b

[PATCH v4 19/20] ext4: make punch hole code path work with bigalloc

2013-05-14 Thread Lukas Czerner
be described in simple diagram: |FFF...FF..FF.UUU| ^--^ punch hole . - free space | - cluster boundary F - freed extent U - used extent Also update respective tracepoints to use signed long long type for partial_cluster. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed

[PATCH v4 20/20] ext4: Allow punch hole with bigalloc enabled

2013-05-14 Thread Lukas Czerner
-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs/ext4/inode.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index f504efa..daffbb8 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3557,11 +3557,6

[PATCH v4 18/20] ext4: update ext4_ext_remove_space trace point

2013-05-14 Thread Lukas Czerner
Add end variable. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs/ext4/extents.c |6 +++--- include/trace/events/ext4.h | 21 ++--- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/fs/ext4/extents.c b/fs

[PATCH v4 09/20] reiserfs: use -invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in reiserfs_invalidatepage() Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: reiserfs-de...@vger.kernel.org --- fs/reiserfs/inode.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCH v4 10/20] mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-05-14 Thread Lukas Czerner
ability in truncate_inode_pages_range(). Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: Andrew Morton a...@linux-foundation.org Cc: Hugh Dickins hu...@google.com --- mm/truncate.c | 104 - 1 files changed, 73 insertions(+), 31 deletions

[PATCH v4 14/20] ext4: truncate_inode_pages() in orphan cleanup path

2013-05-14 Thread Lukas Czerner
this out. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/super.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index dbc7c09..b971066 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2173,6 +2173,7 @@ static void

[PATCH v4 16/20] ext4: remove unused discard_partial_page_buffers

2013-05-14 Thread Lukas Czerner
The discard_partial_page_buffers is no longer used anywhere so we can simply remove it including the *_no_lock variant and EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED define. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs/ext4/ext4.h |8 -- fs/ext4

[PATCH v4 13/20] Revert ext4: fix fsx truncate failure

2013-05-14 Thread Lukas Czerner
machine with block size of 1024 bytes without any problems. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs/ext4/inode.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 8187c3e

[PATCH v4 11/20] Revert ext4: remove no longer used functions in inode.c

2013-05-14 Thread Lukas Czerner
and remove ext4_discard_partial_page_buffers() since it is duplicating some code and also partially duplicating work of truncate_pagecache_range(), moreover the old implementation was much clearer. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/ext4.h |4 ++ fs/ext4/inode.c

[PATCH v4 08/20] gfs2: use -invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in gfs2_invalidatepage(). Signed-off-by: Lukas Czerner lczer...@redhat.com Acked-by: Steven Whitehouse swhit...@redhat.com Cc: cluster-de...@redhat.com --- fs/gfs2/aops.c |9 +++-- 1 files changed, 7

[PATCH v4 07/20] ceph: use -invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in ceph_invalidatepage(). Signed-off-by: Lukas Czerner lczer...@redhat.com Acked-by: Sage Weil s...@inktank.com Cc: ceph-de...@vger.kernel.org --- fs/ceph/addr.c | 12 ++-- 1 files changed, 6 insertions

[PATCH v4 01/20] mm: change invalidatepage prototype to accept length

2013-05-14 Thread Lukas Czerner
implementations will follow except the file systems where the changes are really simple and should not change the behaviour in any way .Implementation for truncate_page_range() which will be able to accept page unaligned ranges will follow as well. Signed-off-by: Lukas Czerner lczer...@redhat.com Cc

[PATCH v4 02/20] jbd2: change jbd2_journal_invalidatepage to accept length

2013-05-14 Thread Lukas Czerner
length argument to the jbd2_journal_invalidatepage() and updates all instances in ext4 and ocfs2. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs/ext4/inode.c |3 ++- fs/jbd2/transaction.c | 24 +--- fs/ocfs2/aops.c

[PATCH v4 06/20] ocfs2: use -invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in ocfs2_invalidatepage(). Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz Acked-by: Joel Becker jl...@evilplan.org --- fs/ocfs2/aops.c |3 +-- 1 files changed, 1 insertions

[PATCH v4 05/20] xfs: use -invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in xfs_vm_invalidatepage() Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Ben Myers b...@sgi.com Cc: x...@oss.sgi.com --- v4: use xfs_page_class instead of separate tracepoint fs/xfs/xfs_aops.c |9

[PATCH v4 03/20] ext4: use -invalidatepage() length argument

2013-05-14 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in all ext4 invalidatepage routines. Signed-off-by: Lukas Czerner lczer...@redhat.com Reviewed-by: Jan Kara j...@suse.cz --- fs/ext4/inode.c | 30 +++--- include/trace/events/ext4

[PATCH v3 01/18] mm: change invalidatepage prototype to accept length

2013-04-09 Thread Lukas Czerner
implementations will follow except the file systems where the changes are really simple and should not change the behaviour in any way .Implementation for truncate_page_range() which will be able to accept page unaligned ranges will follow as well. Signed-off-by: Lukas Czerner Cc: Andrew Morton Cc

[PATCH v3 03/18] ext4: use ->invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in all ext4 invalidatepage routines. Signed-off-by: Lukas Czerner --- fs/ext4/inode.c | 30 +++--- include/trace/events/ext4.h | 22 -- 2 files changed,

[PATCH v3 04/18] jbd: change journal_invalidatepage() to accept length

2013-04-09 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in journal_invalidatepage() and all the users in ext3 file system. Also update ext3 trace point to print out length argument. Signed-off-by: Lukas Czerner --- fs/ext3/inode.c |6 +++--- fs/

[PATCH v3 07/18] ceph: use ->invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in ceph_invalidatepage(). Signed-off-by: Lukas Czerner Cc: ceph-de...@vger.kernel.org --- fs/ceph/addr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ceph/addr.c b/fs/c

[PATCH v3 05/18] xfs: use ->invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in xfs_vm_invalidatepage() Signed-off-by: Lukas Czerner Cc: x...@oss.sgi.com --- fs/xfs/xfs_aops.c |5 +++-- fs/xfs/xfs_trace.h | 41 - 2 files changed, 43 inserti

[PATCH v3 06/18] ocfs2: use ->invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in ocfs2_invalidatepage(). Signed-off-by: Lukas Czerner Cc: Joel Becker --- fs/ocfs2/aops.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 7c47

[PATCH v3 09/18] reiserfs: use ->invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in reiserfs_invalidatepage() Signed-off-by: Lukas Czerner Cc: reiserfs-de...@vger.kernel.org --- fs/reiserfs/inode.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/reise

[PATCH v3 12/18] Revert "ext4: fix fsx truncate failure"

2013-04-09 Thread Lukas Czerner
pc64 machine with block size of 1024 bytes without any problems. Signed-off-by: Lukas Czerner --- fs/ext4/inode.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 5729d21..d58e13c 100644 --- a/fs/ext4/inode.c +++ b/fs/

[PATCH v3 11/18] Revert "ext4: remove no longer used functions in inode.c"

2013-04-09 Thread Lukas Czerner
and remove ext4_discard_partial_page_buffers() since it is duplicating some code and also partially duplicating work of truncate_pagecache_range(), moreover the old implementation was much clearer. Signed-off-by: Lukas Czerner --- fs/ext4/ext4.h |4 ++ fs/ext4/inode.c | 120

[PATCH v3 14/18] ext4: remove unused discard_partial_page_buffers

2013-04-09 Thread Lukas Czerner
The discard_partial_page_buffers is no longer used anywhere so we can simply remove it including the *_no_lock variant and EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED define. Signed-off-by: Lukas Czerner --- fs/ext4/ext4.h |8 -- fs/ext4/inode.c | 206

[PATCH v3 16/18] ext4: update ext4_ext_remove_space trace point

2013-04-09 Thread Lukas Czerner
Add "end" variable. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c |6 +++--- include/trace/events/ext4.h | 21 ++--- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 4adaa8a..9023b76 10064

[PATCH v3 15/18] ext4: remove unused code from ext4_remove_blocks()

2013-04-09 Thread Lukas Czerner
nused code completely and makes use of ext4_error() instead of printk if dubious range is provided. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 6c5a70a..4ada

[PATCH v3 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-04-09 Thread Lukas Czerner
new ability in truncate_inode_pages_range(). Signed-off-by: Lukas Czerner Cc: Andrew Morton Cc: Hugh Dickins --- mm/truncate.c | 104 - 1 files changed, 73 insertions(+), 31 deletions(-) diff --git a/mm/truncate.c b/mm/truncate.c index fdba

[PATCH v3 18/18] ext4: Allow punch hole with bigalloc enabled

2013-04-09 Thread Lukas Czerner
-by: Lukas Czerner --- fs/ext4/inode.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0d452c1..87d6171 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3536,11 +3536,6 @@ int ext4_punch_hole(struct file *file, loff_t

[PATCH v3 17/18] ext4: make punch hole code path work with bigalloc

2013-04-09 Thread Lukas Czerner
be described in simple diagram: |FFF...FF..FF.UUU| ^--^ punch hole . - free space | - cluster boundary F - freed extent U - used extent Also update respective tracepoints to use signed long long type for partial_cluster. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c

[PATCH v3 08/18] gfs2: use ->invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in gfs2_invalidatepage(). Signed-off-by: Lukas Czerner Cc: cluster-de...@redhat.com --- fs/gfs2/aops.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aop

[PATCH v3 13/18] ext4: use ext4_zero_partial_blocks in punch_hole

2013-04-09 Thread Lukas Czerner
and xfstests without any problems. Signed-off-by: Lukas Czerner --- fs/ext4/ext4.h |2 + fs/ext4/inode.c | 110 --- 2 files changed, 42 insertions(+), 70 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index 3aa5943..2428244 100644

[PATCH v3 00/18] change invalidatepage prototype to accept length

2013-04-09 Thread Lukas Czerner
Hi, This set of patches are aimed to allow truncate_inode_pages_range() handle ranges which are not aligned at the end of the page. Currently it will hit BUG_ON() when the end of the range is not aligned. Punch hole feature however can benefit from this ability saving file systems some work not

[PATCH v3 02/18] jbd2: change jbd2_journal_invalidatepage to accept length

2013-04-09 Thread Lukas Czerner
length argument to the jbd2_journal_invalidatepage() and updates all instances in ext4 and ocfs2. Signed-off-by: Lukas Czerner --- fs/ext4/inode.c |3 ++- fs/jbd2/transaction.c | 24 +--- fs/ocfs2/aops.c |3 ++- include/linux/jbd2.h |2 +- 4 files

[PATCH v3 00/18] change invalidatepage prototype to accept length

2013-04-09 Thread Lukas Czerner
Hi, This set of patches are aimed to allow truncate_inode_pages_range() handle ranges which are not aligned at the end of the page. Currently it will hit BUG_ON() when the end of the range is not aligned. Punch hole feature however can benefit from this ability saving file systems some work not

[PATCH v3 02/18] jbd2: change jbd2_journal_invalidatepage to accept length

2013-04-09 Thread Lukas Czerner
length argument to the jbd2_journal_invalidatepage() and updates all instances in ext4 and ocfs2. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/inode.c |3 ++- fs/jbd2/transaction.c | 24 +--- fs/ocfs2/aops.c |3 ++- include/linux/jbd2.h

[PATCH v3 08/18] gfs2: use -invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in gfs2_invalidatepage(). Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: cluster-de...@redhat.com --- fs/gfs2/aops.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/gfs2

[PATCH v3 13/18] ext4: use ext4_zero_partial_blocks in punch_hole

2013-04-09 Thread Lukas Czerner
and xfstests without any problems. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/ext4.h |2 + fs/ext4/inode.c | 110 --- 2 files changed, 42 insertions(+), 70 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index

[PATCH v3 17/18] ext4: make punch hole code path work with bigalloc

2013-04-09 Thread Lukas Czerner
be described in simple diagram: |FFF...FF..FF.UUU| ^--^ punch hole . - free space | - cluster boundary F - freed extent U - used extent Also update respective tracepoints to use signed long long type for partial_cluster. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4

[PATCH v3 18/18] ext4: Allow punch hole with bigalloc enabled

2013-04-09 Thread Lukas Czerner
-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/inode.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 0d452c1..87d6171 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3536,11 +3536,6 @@ int ext4_punch_hole(struct file

[PATCH v3 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-04-09 Thread Lukas Czerner
ability in truncate_inode_pages_range(). Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: Andrew Morton a...@linux-foundation.org Cc: Hugh Dickins hu...@google.com --- mm/truncate.c | 104 - 1 files changed, 73 insertions(+), 31 deletions

[PATCH v3 15/18] ext4: remove unused code from ext4_remove_blocks()

2013-04-09 Thread Lukas Czerner
and makes use of ext4_error() instead of printk if dubious range is provided. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/extents.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 6c5a70a

[PATCH v3 16/18] ext4: update ext4_ext_remove_space trace point

2013-04-09 Thread Lukas Czerner
Add end variable. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/extents.c |6 +++--- include/trace/events/ext4.h | 21 ++--- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 4adaa8a

[PATCH v3 14/18] ext4: remove unused discard_partial_page_buffers

2013-04-09 Thread Lukas Czerner
The discard_partial_page_buffers is no longer used anywhere so we can simply remove it including the *_no_lock variant and EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED define. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/ext4.h |8 -- fs/ext4/inode.c | 206

[PATCH v3 11/18] Revert ext4: remove no longer used functions in inode.c

2013-04-09 Thread Lukas Czerner
and remove ext4_discard_partial_page_buffers() since it is duplicating some code and also partially duplicating work of truncate_pagecache_range(), moreover the old implementation was much clearer. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/ext4.h |4 ++ fs/ext4/inode.c

[PATCH v3 12/18] Revert ext4: fix fsx truncate failure

2013-04-09 Thread Lukas Czerner
machine with block size of 1024 bytes without any problems. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/inode.c | 11 ++- 1 files changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 5729d21..d58e13c 100644 --- a/fs/ext4/inode.c

[PATCH v3 09/18] reiserfs: use -invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in reiserfs_invalidatepage() Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: reiserfs-de...@vger.kernel.org --- fs/reiserfs/inode.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCH v3 06/18] ocfs2: use -invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in ocfs2_invalidatepage(). Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: Joel Becker jl...@evilplan.org --- fs/ocfs2/aops.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/fs/ocfs2

[PATCH v3 05/18] xfs: use -invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in xfs_vm_invalidatepage() Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: x...@oss.sgi.com --- fs/xfs/xfs_aops.c |5 +++-- fs/xfs/xfs_trace.h | 41 - 2 files

[PATCH v3 07/18] ceph: use -invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in ceph_invalidatepage(). Signed-off-by: Lukas Czerner lczer...@redhat.com Cc: ceph-de...@vger.kernel.org --- fs/ceph/addr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/ceph

[PATCH v3 04/18] jbd: change journal_invalidatepage() to accept length

2013-04-09 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in journal_invalidatepage() and all the users in ext3 file system. Also update ext3 trace point to print out length argument. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext3/inode.c |6

[PATCH v3 03/18] ext4: use -invalidatepage() length argument

2013-04-09 Thread Lukas Czerner
-invalidatepage() aop now accepts range to invalidate so we can make use of it in all ext4 invalidatepage routines. Signed-off-by: Lukas Czerner lczer...@redhat.com --- fs/ext4/inode.c | 30 +++--- include/trace/events/ext4.h | 22 -- 2

[PATCH v3 01/18] mm: change invalidatepage prototype to accept length

2013-04-09 Thread Lukas Czerner
implementations will follow except the file systems where the changes are really simple and should not change the behaviour in any way .Implementation for truncate_page_range() which will be able to accept page unaligned ranges will follow as well. Signed-off-by: Lukas Czerner lczer...@redhat.com Cc

[PATCH v2 03/18] ext4: use ->invalidatepage() length argument

2013-02-05 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in all ext4 invalidatepage routines. Signed-off-by: Lukas Czerner --- fs/ext4/inode.c | 47 ++ include/trace/events/ext4.h | 22 +++- 2 fi

[PATCH v2 01/18] mm: change invalidatepage prototype to accept length

2013-02-05 Thread Lukas Czerner
implementations will follow except the file systems where the changes are really simple and should not change the behaviour in any way .Implementation for truncate_page_range() which will be able to accept page unaligned ranges will follow as well. Signed-off-by: Lukas Czerner Cc: Andrew Morton Cc

[PATCH v2 04/18] jbd: change journal_invalidatepage() to accept length

2013-02-05 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in journal_invalidatepage() and all the users in ext3 file system. Also update ext3 trace point to print out length argument. Signed-off-by: Lukas Czerner --- fs/ext3/inode.c |6 +++--- fs/

[PATCH v2 05/18] xfs: use ->invalidatepage() length argument

2013-02-05 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in xfs_vm_invalidatepage() Signed-off-by: Lukas Czerner Cc: x...@oss.sgi.com --- fs/xfs/xfs_aops.c |5 +++-- fs/xfs/xfs_trace.h | 41 - 2 files changed, 43 inserti

[PATCH v2 11/18] Revert "ext4: remove no longer used functions in inode.c"

2013-02-05 Thread Lukas Czerner
and remove ext4_discard_partial_page_buffers() since it is duplicating some code and also partially duplicating work of truncate_pagecache_range(), moreover the old implementation was much clearer. Signed-off-by: Lukas Czerner --- fs/ext4/ext4.h |4 ++ fs/ext4/inode.c | 120

[PATCH v2 09/18] reiserfs: use ->invalidatepage() length argument

2013-02-05 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in reiserfs_invalidatepage() Signed-off-by: Lukas Czerner Cc: reiserfs-de...@vger.kernel.org --- fs/reiserfs/inode.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/reise

[PATCH v2 10/18] mm: teach truncate_inode_pages_range() to handle non page aligned ranges

2013-02-05 Thread Lukas Czerner
new ability in truncate_inode_pages_range(). Signed-off-by: Lukas Czerner Cc: Andrew Morton Cc: Hugh Dickins --- mm/truncate.c | 104 - 1 files changed, 73 insertions(+), 31 deletions(-) diff --git a/mm/truncate.c b/mm/truncate.c index fdba

[PATCH v2 12/18] Revert "ext4: fix fsx truncate failure"

2013-02-05 Thread Lukas Czerner
pc64 machine with block size of 1024 bytes without any problems. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c | 13 ++--- fs/ext4/indirect.c | 13 ++--- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 5ae

[PATCH v2 13/18] ext4: use ext4_zero_partial_blocks in punch_hole

2013-02-05 Thread Lukas Czerner
of the ext4_discard_partial_page_buffers() completely. This has been tested on ppc64 with 1k block size with fsx and xfstests without any problems. Signed-off-by: Lukas Czerner --- fs/ext4/ext4.h|2 + fs/ext4/extents.c | 79 ++--- fs/ext4/inode.c

[PATCH v2 08/18] gfs2: use ->invalidatepage() length argument

2013-02-05 Thread Lukas Czerner
->invalidatepage() aop now accepts range to invalidate so we can make use of it in gfs2_invalidatepage(). Signed-off-by: Lukas Czerner Cc: cluster-de...@redhat.com --- fs/gfs2/aops.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aop

[PATCH v2 14/18] ext4: remove unused discard_partial_page_buffers

2013-02-05 Thread Lukas Czerner
The discard_partial_page_buffers is no longer used anywhere so we can simply remove it including the *_no_lock variant and EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED define. Signed-off-by: Lukas Czerner --- fs/ext4/ext4.h |8 -- fs/ext4/inode.c | 206

[PATCH v2 16/18] ext4: update ext4_ext_remove_space trace point

2013-02-05 Thread Lukas Czerner
Add "end" variable. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c |6 +++--- include/trace/events/ext4.h | 21 ++--- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 966a09e..2b7e521 10064

[PATCH v2 17/18] ext4: make punch hole code path work with bigalloc

2013-02-05 Thread Lukas Czerner
be described in simple diagram: |FFF...FF..FF.UUU| ^--^ punch hole . - free space | - cluster boundary F - freed extent U - used extent Also update respective tracepoints to use signed long long type for partial_cluster. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c

[PATCH v2 15/18] ext4: remove unused code from ext4_remove_blocks()

2013-02-05 Thread Lukas Czerner
nused code completely and makes use of ext4_error() instead of printk if dubious range is provided. Signed-off-by: Lukas Czerner --- fs/ext4/extents.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 7b44dc1..966a

  1   2   >